From patchwork Wed Jan 24 02:34:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhijian Li (Fujitsu)" X-Patchwork-Id: 13528415 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07203C47DDB for ; Wed, 24 Jan 2024 02:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ci/pvTJ3zOnM0ME3M77nd/4YQIh6sfc7pva80NYzPYw=; b=3o9rwMINzZokXJ BuetS+9GVsn3jJsQLg1wuNdRpqgZxAF4T3/DG7IeI2OzshXqhu27LuUu49uwqNpTCuKXnL3k7PhAw 3Z89qjaCC6/4Vggg/OPQ6H5Vvq98IBudmMQM+AXCQg359oTDLdFL5ko7olRrCNLX+THECNJcjCFtT jQRNZ+dzvxO5FDinRn43JyIwvWjHL0EXYdhdVIce1HTU4X4uM4kzOUFngLSncFnvswQhWCqtLW/Dp w5nUp+j8T8J5hNg2AaFbtLmoLZ/08d9Gwmyyu47l34WUsaEQ/IJFCryMvp1xEetXjDQp2x+32uu7X kmptwo9bLbTb5aTGJMsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rST6V-0019V7-2i; Wed, 24 Jan 2024 02:35:03 +0000 Received: from esa3.hc1455-7.c3s2.iphmx.com ([207.54.90.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rST6O-0019TI-0S for linux-arm-kernel@lists.infradead.org; Wed, 24 Jan 2024 02:34:58 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="147063285" X-IronPort-AV: E=Sophos;i="6.05,215,1701097200"; d="scan'208";a="147063285" Received: from unknown (HELO yto-r3.gw.nic.fujitsu.com) ([218.44.52.219]) by esa3.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 11:34:49 +0900 Received: from yto-m1.gw.nic.fujitsu.com (yto-nat-yto-m1.gw.nic.fujitsu.com [192.168.83.64]) by yto-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id 25A5DD4F5A for ; Wed, 24 Jan 2024 11:34:47 +0900 (JST) Received: from kws-ab4.gw.nic.fujitsu.com (kws-ab4.gw.nic.fujitsu.com [192.51.206.22]) by yto-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id 6DEBDCFA5D for ; Wed, 24 Jan 2024 11:34:46 +0900 (JST) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) by kws-ab4.gw.nic.fujitsu.com (Postfix) with ESMTP id E87F56B4C1 for ; Wed, 24 Jan 2024 11:34:45 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.226.45]) by edo.cn.fujitsu.com (Postfix) with ESMTP id 51F441A006A; Wed, 24 Jan 2024 10:34:45 +0800 (CST) From: Li Zhijian To: linux-kernel@vger.kernel.org Cc: Li Zhijian , Russell King , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] arch/arm/mm: Convert snprintf to sysfs_emit Date: Wed, 24 Jan 2024 10:34:42 +0800 Message-Id: <20240124023442.105333-1-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-28138.004 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-28138.004 X-TMASE-Result: 10--10.112700-10.000000 X-TMASE-MatchedRID: st9CF01730Y4ibokZ3+Q0CoiRKlBVkYIBXngI6jFvpfvd49YGReckIP+ YDa/Dhu9O3wTUW8jWH5M0AWQBBcXdg8rYO92b9NmzYK5U+QI3O5MVCcj56k8htWM2x6EZ/S99vr PTUDmrVhVLU87vVnq1eZtbVQsdt0o0ekSi+00U24ReM8i8p3vgEyQ5fRSh265p8OlUPvzGP3Ivl CZY6Ax8PdcQ4/ZOO0Rnagtny7ZPcQfE8yM4pjsD67rlQMPRoOCxEHRux+uk8h+ICquNi0WJO261 rahe0eoSLldSTV5Pef2pn+LVzkfoezQKsahjBoIftwZ3X11IV0= X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_183456_467249_A6CD0E18 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: please use sysfs_emit or sysfs_emit_at This patch is generated by make coccicheck MODE=patch COCCI=scripts/coccinelle/api/device_attr_show.cocci No functional change intended CC: Russell King CC: linux-arm-kernel@lists.infradead.org Signed-off-by: Li Zhijian --- V2: extract patch from the patch set[1] so that maintainer can accept it separately. [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/ --- arch/arm/mm/cache-l2x0-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c index 993fefdc167a..a9bd05b82003 100644 --- a/arch/arm/mm/cache-l2x0-pmu.c +++ b/arch/arm/mm/cache-l2x0-pmu.c @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev, struct l2x0_event_attribute *lattr; lattr = container_of(attr, typeof(*lattr), attr); - return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config); + return sysfs_emit(buf, "config=0x%x\n", lattr->config); } static umode_t l2x0_pmu_event_attr_is_visible(struct kobject *kobj,