From patchwork Wed Jan 24 22:31:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529748 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E62B13666B; Wed, 24 Jan 2024 22:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=o2QNbmjVlLirQ9WVMyak0/W2HoTYDOMwM3Z+WkpJHbXZRzaGFvBmnfP8hg4u9X6Hr7tsZF+ZEXTBklhzJ9BweDcAtiubW4KHBU6HYrwkmrN09ghcGSpCkcYicM538ErEfcFPQEXzVYvRYupZOQI0VUWHLTr8vmungQS+Rd2NXyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=oTUeFEtg6tccmFigk3+uGgzU7tYf0ybllVSeTx5SFNo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gK5GNtt/WPj7pV/qhzDGg3yaOy5QSFzBFQCcr/8g8gzmWwJMZuiJgxeRSLVmquyjPgJaR+SoibQXgem8YAq5NSMfzTB711w0tIbmnYe/Kg9P8G2BZ4wUyEfRmT2oNCpSySKua9ZWiPBCg4pRimJ9aeT8xHGgrSSr4ezrNNVwpVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=GeM0OEty; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="GeM0OEty" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135557; x=1706740357; i=wahrenst@gmx.net; bh=oTUeFEtg6tccmFigk3+uGgzU7tYf0ybllVSeTx5SFNo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=GeM0OEty1WprvABKm6oFt6ei1Pa0ywWhkGTXRAnmY1cdp1YHsvrj2RcnSW9ibFSF /FXA9akbsLYe3HVPuGGt3GZMrL4jmNyTuFMnvIe5mddIlDkbYzShXinm1Akb4LO6/ GuCqL7aLAgpQVG/InJ33TnJ+G/KiHL0OcSI4Mj7kJbVBfiCeSBp8jdXJQXiA7UDJ4 zRzuJBK+cnLi6Qmrj7w6K2PHFE33cZ0g84zj1Up2U5wWceZZcoxApUtvKjjOaknj5 hytPfUS9o/9/MomX+wqD/O0621Ru6Mbr/1VnYHJqhC3eJ1NtqTu36mUQUblMT4jsb bBVoUmmk9qRjBvJaZA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MKbkC-1rnkam3dNs-00L088; Wed, 24 Jan 2024 23:32:36 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V3 01/14 next] qca_spi: Improve SPI thread creation Date: Wed, 24 Jan 2024 23:31:58 +0100 Message-Id: <20240124223211.4687-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:qXB0zT9UcdmILQH3Ox0z6aqoMNMu6aDxj+AwPV4yoKpEJi8lN3K w+AZ541wA92PBNpWcSbGSnfIJmI6kX1j9G3g6AniOlxi4c0cuHBIuplQNLlx4oBa2Tgj+cT sb/ScNqvQ0el1HJHJcjxr6HCpWozpUR+5KO7NJBGRs30Jeb3HdZrHzuHo/8BXIXztSrSaMe LLt5tLBpL//rfABNHY76w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qDhLsbAxpQM=;qo1pRUbvoR/eFgttBz6l/3EaWWn 4JDI3wPNsR/ragy2ItG1UTC+Rtv6JYj0tuDr8b8gPD6ar8ittogMU4AQKNJg+7glG3jw0136L T4qfd6SbSLwXIqrvHOwN/oDIw4D/oeRtzm7kwBijlkZvL5zwMbs72XORqhppkobflEEhO04Hr vQGxi70lPdKaId9zaigP4qEs7OwZC/IKWnvO9m/xMtKbWYggchPgOT4eMIUd0RcotEX4SrD69 850/itSQQWfUKxtSNfT5myRoKhXHfVOS6aKt8rEN4HVIzowgtkmKxGUWfzBz6wHOpg0Aj5jCP vCY4Hacte72Ky+6hx8e+AThf9tcvDl1vMfOQ5UCvCWDP4gFS8O3LRF2JOAsBZdM+EEexZifRy H15xrACsmJNy8hT+p2UcJlGZXNipiB/snezsee13Zm5iQk0i499KLslCERwwFU27JW6K01qgd 7eu/OwyCV+9ROm+5i68/xCU0oGxBkecQ1ffCBaAjoUA6qCAGO6VMZoj0HIlCPTuDpp4nKVUak li1xYruWJRQBCWW4bmAnyYiH+2flX1QFn7LOsZQQrfIWNu0SuQU8XMkhn2Yq2TjOCMqXcGHA0 NzVWJbyZWj+k+3j/DC1fbh1qfZuQmDAewnXEWqwWtbUclo9zu27GCK6cJorvDo2STan8+QmSZ 2NmkxaRGZ58a3AkmP7zL121gqHbxX8T52PcRR12/3UHWq8+GNEIGDTk/uOrZwz0OPqQDiW1bC Zw/dQ1DRa1LBCjz99vnvNobu8v6mlHlWrst2Sk7A8DB4+68FhqKiEqVlpxauGEg+WgUlm32EI MLadV0YgC+x/dh1hZXyf/Eb2iBrFIn6KrtPzox53u8BzWUjj+wyfGBQ6b0jGZmDQee/tNtnbE 9akalUJr2SG7d7EOlwoBmMRQF0NXJYGhJwNpva1yS8jXjEupMgPxIt2zypOZiQ501HUxYNKMC +S9jr6ZNEQillpmcO6OlBSpJIvk= X-Patchwork-Delegate: kuba@kernel.org The qca_spi driver create/stop the SPI kernel thread in case of netdev_open/close. This isn't optimal because there is no need for such an expensive operation. So improve this by moving create/stop of the SPI kernel into the init/uninit ops. The open/close ops could just 'park/unpark' the SPI kernel thread. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 33 ++++++++++++++----------- 1 file changed, 18 insertions(+), 15 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 5f3c11fb3fa2..fc272ca7bdca 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -697,25 +697,17 @@ qcaspi_netdev_open(struct net_device *dev) qca->sync = QCASPI_SYNC_UNKNOWN; qcafrm_fsm_init_spi(&qca->frm_handle); - qca->spi_thread = kthread_run((void *)qcaspi_spi_thread, - qca, "%s", dev->name); - - if (IS_ERR(qca->spi_thread)) { - netdev_err(dev, "%s: unable to start kernel thread.\n", - QCASPI_DRV_NAME); - return PTR_ERR(qca->spi_thread); - } - ret = request_irq(qca->spi_dev->irq, qcaspi_intr_handler, 0, dev->name, qca); if (ret) { netdev_err(dev, "%s: unable to get IRQ %d (irqval=%d).\n", QCASPI_DRV_NAME, qca->spi_dev->irq, ret); - kthread_stop(qca->spi_thread); return ret; } /* SPI thread takes care of TX queue */ + kthread_unpark(qca->spi_thread); + wake_up_process(qca->spi_thread); return 0; } @@ -725,15 +717,11 @@ qcaspi_netdev_close(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); - netif_stop_queue(dev); + kthread_park(qca->spi_thread); qcaspi_write_register(qca, SPI_REG_INTR_ENABLE, 0, wr_verify); free_irq(qca->spi_dev->irq, qca); - kthread_stop(qca->spi_thread); - qca->spi_thread = NULL; - qcaspi_flush_tx_ring(qca); - return 0; } @@ -825,6 +813,7 @@ static int qcaspi_netdev_init(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); + struct task_struct *thread; dev->mtu = QCAFRM_MAX_MTU; dev->type = ARPHRD_ETHER; @@ -848,6 +837,15 @@ qcaspi_netdev_init(struct net_device *dev) return -ENOBUFS; } + thread = kthread_create(qcaspi_spi_thread, qca, "%s", dev->name); + if (IS_ERR(thread)) { + netdev_err(dev, "%s: unable to start kernel thread.\n", + QCASPI_DRV_NAME); + return PTR_ERR(thread); + } + + qca->spi_thread = thread; + return 0; } @@ -856,6 +854,11 @@ qcaspi_netdev_uninit(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); + if (qca->spi_thread) { + kthread_stop(qca->spi_thread); + qca->spi_thread = NULL; + } + kfree(qca->rx_buffer); qca->buffer_size = 0; dev_kfree_skb(qca->rx_skb); From patchwork Wed Jan 24 22:31:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529742 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E01C135A56; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; cv=none; b=MJH7xeciJI1vv3kHVA3Q+zTAZYPorIn0/mQ80HDgZ36so1lAO4mJqDhN7thJvolip1FVSxO7RTdPLKjAZczxd/9mTf/RIBQ/1iylPmmuxN5zWP0pVmLwleoVly0ZA/MYBrFxNnNBJkGj58vqIHhUesx1UrFVA5gcn/OqNS2Zwus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; c=relaxed/simple; bh=W+XG7gUVjX2CJXaxEMB61egMLVz4lNEs6++C8B0jnZs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N+qA5Oqck2w3XvWujeORyxUIB58/ANK8wA4jcAacyY2av/ULI49AXPCVn+Kyq5b93KSFN4iyD7X90lEX9rlnGN4kNc+/oWMxgQmv33bU+pqOiTdTnOGStUDt38NuQDBYX2LAbrSiBm5PqfBeb7UncxWKargeRvmfMeimrKTsgKs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=XwLOTZhY; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="XwLOTZhY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135557; x=1706740357; i=wahrenst@gmx.net; bh=W+XG7gUVjX2CJXaxEMB61egMLVz4lNEs6++C8B0jnZs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=XwLOTZhYKGcOKVwX/KTtIyl2EZYGLncjwnR0fJeWGd0uId7TE1noTkKyOfeXv+nn pFXDdPGCzBFS/O7+OI+e71AmtFOa8j5qkdqQZcg1MGItVefjDSbSz+HNeWJPLTksb 1Asrr5UCSD8+7YlWaeATw7VUFALy6Eidc2H3CR7Bv24vc0sXNjd84NguczG02EAcI /oQiZnbalzbg09CpPD3qAiQXtq47URTUpvH/UApH8ynmXA+XPVzFL2t0CvTiQsOZF xy3AjVDvyLb/aDwlvacLBPZReR+ZWTeGy3Cvp7OZeC8XJU/Fs5E0xJABHxt8FPwND 70j0mWrtQyCFxUzg5w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mof57-1qiBie2pOj-00p20r; Wed, 24 Jan 2024 23:32:37 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 02/14 next] qca_spi: Improve SPI IRQ handling Date: Wed, 24 Jan 2024 23:31:59 +0100 Message-Id: <20240124223211.4687-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:aL6VB/gYI/E9S57gwbqxv807a1LZCLoaNBRTrL4zhQqVL3P83zu gb+CXzh1WmHLfPfRstfzmjTxREd3Kqww7xpEZz9L5U5kB6aicd5dQp/slzKw0FVhCHeLdw1 SDL01NjMwn9pE4jFfg4bFAizsVNxLoqYbdK/zObzwkoMvZUnRykI1PryhxmR5QwsmIYsSmH /SdWxVmOGsc+PSeNFTlow== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PpK0zX9pg1Y=;GZXcBir7R06/D2XQlG2oEyGhOCS grTnmSIjwzsyZlg/L1yL9OwCx+WXOYzjPR85KZwn+t0h1G7jOICV9vVRpshcjVmtkp1C/dWES fuuEyEn60yE9xuvNOcMnxwZad/h5hThCWLf4VITkMMZRQyZdFzgsyQgL86kW9Mrox2jcesOa6 HbowcOkhoOO0OpLJGce2lZEscXGLkqm6buCWJZ+N/Gi3OEB272iUUolqM/IyhHkntHybFrhdr kqwZAEVB2t5gPj4MFfJXFWcf3m76ccbcR6OZB/cnjylhR74f26gmgj8kP453pqgWTeFDfmjNF 45uXxFYrbfen2+7bA12Y0ubreazyrkWM9JO0DOL0DNkvLdKauzTlJdBVnEATj3XUndisiJ0lm W89MKOK1C+gUnUb7/76M0r/KYOIkh/ClhIbqJlISNcvxqkg7Pk4478RfJ7DH7UZghrzAT8xUL 60xh8y3rElSUB+pfC+JJ4CebiyUlGeZ7nyV9W9v57nhzKXSTj+Nz2TCPdXFQn/br0Y2T24LXN +L46eDYcbG7CUUVAbm5oA/pdIzG/owNcmXbf36W8hJMks0MXYcOKbiS0qP9n/rJL5p6CI1tb4 BAlyeqEDWBfeL0QtpqCC5fFnYkHkFSdCclmcRLkgnS7ggcmMuKZ+KENmeJcvmQCANw6aCki6N F7UT64wyqA4NW7bF8qAsVg+3E8oFHv30BM2indy+yQk3IK2ieuRrm98/vdj//nffrXZEPbgz7 QIN143ThNSgqf31Zf3LPjaI6Xn/z4DUgixCqkU7fS1WcsvZLSzTuHTXlrCqfPW7OvMuzEWHwi PY82GPr0BDSLGbCiQ3T8HZpHmW/p49M57oMc4BBCLQuBxYxNdZsw4Nu/0CI8XPjYYp1O6kKxT Xu/pmZnk7LMx3UgOXx+CA5AVcJIJrUxVjvR3E9igyb2M3n7lw2DvCuEZnLjzJVJB8KcvvZjWk YHPOng== X-Patchwork-Delegate: kuba@kernel.org The functions qcaspi_netdev_open/close are responsible of request & free of the SPI interrupt, which wasn't the best choice because allocation problems are discovered not during probe. So let us split IRQ allocation & enabling, so we can take advantage of a device managed IRQ. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index fc272ca7bdca..294d4ee3b38f 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -687,7 +687,6 @@ static int qcaspi_netdev_open(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); - int ret = 0; if (!qca) return -EINVAL; @@ -697,13 +696,7 @@ qcaspi_netdev_open(struct net_device *dev) qca->sync = QCASPI_SYNC_UNKNOWN; qcafrm_fsm_init_spi(&qca->frm_handle); - ret = request_irq(qca->spi_dev->irq, qcaspi_intr_handler, 0, - dev->name, qca); - if (ret) { - netdev_err(dev, "%s: unable to get IRQ %d (irqval=%d).\n", - QCASPI_DRV_NAME, qca->spi_dev->irq, ret); - return ret; - } + enable_irq(qca->spi_dev->irq); /* SPI thread takes care of TX queue */ kthread_unpark(qca->spi_thread); @@ -720,7 +713,7 @@ qcaspi_netdev_close(struct net_device *dev) kthread_park(qca->spi_thread); qcaspi_write_register(qca, SPI_REG_INTR_ENABLE, 0, wr_verify); - free_irq(qca->spi_dev->irq, qca); + disable_irq(qca->spi_dev->irq); return 0; } @@ -987,6 +980,15 @@ qca_spi_probe(struct spi_device *spi) spi_set_drvdata(spi, qcaspi_devs); + ret = devm_request_irq(&spi->dev, spi->irq, qcaspi_intr_handler, + IRQF_NO_AUTOEN, qca->net_dev->name, qca); + if (ret) { + dev_err(&spi->dev, "Unable to get IRQ %d (irqval=%d).\n", + spi->irq, ret); + free_netdev(qcaspi_devs); + return ret; + } + ret = of_get_ethdev_address(spi->dev.of_node, qca->net_dev); if (ret) { eth_hw_addr_random(qca->net_dev); From patchwork Wed Jan 24 22:32:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529747 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBD31353F3; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=Y/uMxi5zgvhw5aU1PTAsfSngjQT2TLv0YANKpIxGJ01/Vbcj2/MIkaNNn+FYqoNDxgxUisT8sjlMUcJU66B93U82toQLJDbFAXHP3vapkNy3ScXBPdikTXi+b0cdH2vfcqxz2IQ2npTvLKvnc9oXnRzuy+x5uaqVP9yU6eIEkJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=ZkQWzZ1tqQ+RtdmjwZVBTOtlj+vwXzEAwzG2LCDJfng=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qQbaCHb5oQS+pjvQDsEn5hj/gpJIrCUJB9cZdbtACqybaSoOgcnKtWdF57Up50sqVj+NwcU0WgIihwwY7jWo2LeonM77UTtgFjrU6fu7+MaQy/PjoQKWsFT21yEgJu2+mY2h7o6FwLmxkeePl61ihNwE9xIibPDZbSKQHiLawt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=iY6VFbsc; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="iY6VFbsc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135558; x=1706740358; i=wahrenst@gmx.net; bh=ZkQWzZ1tqQ+RtdmjwZVBTOtlj+vwXzEAwzG2LCDJfng=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=iY6VFbscuKy7fMaZbS4ls4F6iM/doo8A72dKzcm6G3ARJioGHEQ7U8ZFX3HXbxxu M7mPY+odDnD02ll1v3EYKdb4TjXTOlncWCp1LmuyEnsYFuivnK8bObNOtQCpx4Lpb 8fjpfG6TTIuuGwMIIMtIBETKJhBJAQOhA2OpYnBteC7ZuDrP1McIggWkRGdlUJ1Ea 2/gvUKTw/XLwNr766YjpR+zfuI+ayyV6FFloaPNmowqCNpZy7t9vJjT8s44KJp3oZ bCTf8Ly6B53gJia6Bumy6NFEytKNhgTxxbqNPN2aDtGi0VcGHVXwW5uId8/7UtMAk 3TBuCmyYEG1Y22W5CQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1r3RUQ0rno-010uXA; Wed, 24 Jan 2024 23:32:38 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 03/14 next] qca_spi: Avoid skb_copy_expand in TX path Date: Wed, 24 Jan 2024 23:32:00 +0100 Message-Id: <20240124223211.4687-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:l6d25/OxlNTDfb9rsSl/KAhlnToWqi0QjdZWqxfWfLo1e6aJTjI OtG3wQef5tap9sVXOCxPq7YmyXE8+DIglZw9Bp9hWEnlDc+oTSyARKyhEKyoBEVmLE2E+IZ hpl4AfMxF3eo55hEU7pvRiU/v2v6L+GkTR5jnaaLjqGswfI2VhRCf6pvWEdRGbiQTPnQ/f3 NSidEML+mYhdxGRd6Ta3g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Xhtu9VDwTRk=;H8oiTroUBKrKH8kvEeuyfZNp7yV VRl7jmuLStV4Jz9TALf8/EqpClXB/mGEJwyHMqPLAVNWO5m9zCMsWX8DnjpBKhMOx5uO1vMbr TKHA0zVZpze/dq9xQM5aNIjvvAAbz3CYzbklBUqYwQ2QMaetJKcLBGCTm+esYM++UhX1rn6jP Cvd4KB3AkBxAPVjnnYqdTKo0gEw+rUmifnilCNFMWSDcVsu9QuV/IJohpEl/pKGNHdH5d69WW faFmxtoHvUls2ANGluQ9zm2Zb+LlrTfvVZUy1fqcOTY3h272xvMA4bZdNx0WibXQv+V9lIZn/ QHDabkIhXC5pt6zjr0siYuN/9cqTDvgVeuLb0xBZZixrIUg6fITwS9H2MzVp77gUq5iLbk/Ey +3/GYtDg3A56DhznQ+8uBn1ZQpSv4L9PNdkaexPFTtYIhoChWPOqooB2CkBClrmd5/sLYDFBj WX31W2/QWYXZUpokeKVmuq545a0RHjzSYTnAaG0SrhUdZ08QSQPww147Nwr2oVjlpM4QuwbuD DE0yvvymodkS+y8b77iqRmyAAsO2fkpkNrh+HlDDMSF00lEPRlpLIxskzHU57174QKrajuSbI dqyBnZzQJ7uCg1lZW39d0RmkQsi4i5xCygk5mXInJ8wgmyINJFiIoZFVFoFFRioGE+bCTYQ7R re7M6qbAd5k7FrczPgt8jK4g7MUqtH+4UUGVvPyuSAtogHiXVIh4Vo6an8+GDxfkAsRcGCUZG BBY0nLryo7mGV0NFY5m7pGGLvuwWcofCDovdl/7FVk9XE56HHtEgDpTS1DBGWfXXpUrlhZqOY qxJFtafZ9aZcLO5yDj6r+U4THriKzGBq9F/EgyGDdPZMdMe32/h9XzANMVmkIq2DuVqY9rkZ6 aYZj+bOmiFi5dBmrpe1p+75HEzLwUScFijlI2zeKiCMffVLDN6AwAOeDfqfEMSVkBwCEuROhz Wi4/Ig== X-Patchwork-Delegate: kuba@kernel.org The skb spare room needs to be expanded for SPI header, footer and possible padding within the TX path. So announce the necessary space in order to avoid expensive skb_copy_expand calls. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 294d4ee3b38f..919a400412cb 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -877,6 +877,8 @@ qcaspi_netdev_setup(struct net_device *dev) qcaspi_set_ethtool_ops(dev); dev->watchdog_timeo = QCASPI_TX_TIMEOUT; dev->priv_flags &= ~IFF_TX_SKB_SHARING; + dev->needed_tailroom = ALIGN(QCAFRM_FOOTER_LEN + QCAFRM_MIN_LEN, 4); + dev->needed_headroom = ALIGN(QCAFRM_HEADER_LEN, 4); dev->tx_queue_len = 100; /* MTU range: 46 - 1500 */ From patchwork Wed Jan 24 22:32:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529740 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB9E1E882; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; cv=none; b=MZ9d0N5/LjaUw4GPvt/Y+t0Zag8sb3LYIdBUiwvIaRno84aaWuKCS6lSopRZMBhPTGJtWvKYhVLt+IigKUGsC0e/wTWIus+EWCGRzFUDlHxzqzLFMi93gwcuFX2mIrLohphpZ/HiXkL8fy2/ABx9bgyqBUj+7aZEIrUYAm/20eQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; c=relaxed/simple; bh=qrDaTsk7HTfc8TrmJHba7pRVGRstI4yMYwXgF2rjUlY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ny3tCSlCJsFenumjcTGT/4uD24y88YSS8NR3/Y7/cCSyffskd6U1eXXW78gy4nmDugQddXUVk9qBR7zm7iX3oU9QeePodvr2bBW/lm6tgTpfKN5i9274Q1FauwRUsZNpHcudw+2Nhod8v+1w5Mehstncm+n+EtmuFris81TULzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=QocG5xe8; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="QocG5xe8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135558; x=1706740358; i=wahrenst@gmx.net; bh=qrDaTsk7HTfc8TrmJHba7pRVGRstI4yMYwXgF2rjUlY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=QocG5xe8JcuBN+Kydmhil3GdAGNCirjPCxAsym2xBAtYF7jzLiDzx3u9znVZ2/sX mMLh43TkkYW7BCPiHfH6e2XpAkyBbO8mSWlahIrAMGDpydBKOxEeeVyin3DmLFNls hPKp47Fuuc7rBVrD7ck0mt7tWN+fTgj1lDMkGkCeN865z6Bk63ZcqO76p5xakwxD+ 2NtnwhHwGe24hxa8XiJ/3+lieqJ7xImemro9LauvycFTbZskuhHYzEHBFdcKVfXhJ X0Vx+oybsAfDzSklncFKJyz1x+LGwL8tzhOHYeK28szd14Vn1E5IncYq+0eeVGQbF siulkBqY2IAqNwPQwg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5G9t-1r3AVX363h-011BeL; Wed, 24 Jan 2024 23:32:38 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 04/14 next] qca_7k_common: Drop unnecessary function description Date: Wed, 24 Jan 2024 23:32:01 +0100 Message-Id: <20240124223211.4687-5-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:haDaJ774AzzypKlRpr+jQwx8oGav0zVwZAc/Q2T11GxpOsacOAO a4b8i1YA0My3Ff8GlWQTeQyCxyYN3/e8l6Jukc4mCRzKPT7Jl2VBa8ACqBRnRTy80wsHSAU U5zTZxumjiwN9OwYp3ZaSly2CUsT/wnpGMG3NnapHbMlDVCQiUyQpDhIgYK/of0pJR50Fbb Hod8ZRaevpb8Sh4JQfKxQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0GZ4805+wNI=;Zg9tXZn4ciFBgbquN0uYItUapEL XlIGVmCCMmJJrRIa/DIJxhP4VwM3K7h5M8N3/GPFlR6TW9qA1tIs/BHk1SQx2LvtFj/T3MKq7 td0NSpL9sV/8VgKdzYPcCClVcd5owmwi/LETrEn2OwBbWW5Bts6ONrY7wI+IgztKL1+sWQ0YP W5Wx7z8fygA7OOGvPdYC4I7A6VjwcKDT2xNbelnwZgNkUazm3y/5fR7FlKASEvlxYVLAF0fQJ 8FOs3lJPC9367XPHst1BllIM418tfGR679BW7WCc5B443ggIT7UVhRymJGEzqRWx8iIJ6X0fB GKlLG0mBy0FIAfTKUhSYlwpypXtIeA9pLFV/hxg3LiG5RRPXyFDnn82SuEo4BIwP4dsL2vZK2 6984+9TP3UMm3jxbOa+BGDLQBzzWcpIExE/ac81vg4OszMtwZZ+mtdqd1QdaInBW20E0d71Ms wNWqj/MySXDel73HXMBsRfhI9fsZW3hIGKgZi4um3kT3/6raWBAxBXf1bMCAa8TD8LPp5qJ2K FJV+J/sc6pp7Ig13YHcgRAyYGJZPBulV/oFAQrkfU+ObtLWF1M2b/H7FqdZWzlAjcpThqwYxP B4jUBlquellLJCxzomHUIDxTEYhwzdIMhT1eMO4IXnPR+F2U7WZV006bj0UzYqzpPcnOEdQ6Q zXo1gP/5UGJub8uqhwxPGjLEcnOuXarS6vQCDMdR8JJJLFv47xll9uNiwamOGxx3wK5oXO8hx dTJkuatGUYvmK2s+657ycUcZmkusa7LAtlNxCBPbKkPue3nx2uWFa/zqZvrBQz2Ky/DrhhHUv Ap+lgoQCRlDYwMIa50N1/YcmjjW/Mo/nM6OvNWOButXCpsnr5chp3I+H0S1PnylsmdD3izXR8 EcdNnJ2vCatY2ejiWBO2JR6byBMiz3qcolm/yJMF51schVIs1VbpkVN7ONfj00+z6OTa4V5K8 Ox0CDDC+ZGQiwUfm4Qj/+P9y+c4= X-Patchwork-Delegate: kuba@kernel.org qcafrm_fsm_decode has the almost the same function description in qca_7k_common.c. So drop the comment here. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.h | 11 ----------- 1 file changed, 11 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 928554f11e35..71bdf5d9f8d7 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -128,17 +128,6 @@ static inline void qcafrm_fsm_init_uart(struct qcafrm_handle *handle) handle->state = handle->init; } -/* Gather received bytes and try to extract a full Ethernet frame - * by following a simple state machine. - * - * Return: QCAFRM_GATHER No Ethernet frame fully received yet. - * QCAFRM_NOHEAD Header expected but not found. - * QCAFRM_INVLEN QCA7K frame length is invalid - * QCAFRM_NOTAIL Footer expected but not found. - * > 0 Number of byte in the fully received - * Ethernet frame - */ - s32 qcafrm_fsm_decode(struct qcafrm_handle *handle, u8 *buf, u16 buf_len, u8 recv_byte); #endif /* _QCA_FRAMING_H */ From patchwork Wed Jan 24 22:32:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529746 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BF6136665; Wed, 24 Jan 2024 22:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=Ki1/MmKayclzMompiaAF9jmgW95+Tq7vFMpf70+iEGkmZ5RCwquIXnj1un6uOA6oGAfW43c1elIm+xlrnKNkxFoFXIr53z0p1eoAgHvfap59SFRVnhlf8Yb7jmD4HCON9rguETafUAR+gkoOtFzQ7BQRlGNttWsXemPZ0yVzmSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=s+C5yRBMXtAg248/XAUH77adEcGlMjvS8LegdnUr0Qo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Cf8iKlqNli4ySUIKxMlN55277jEqoILI+yJugqpThQLrw+GkWGKCDoItkmz2wos7gZLsj3P3BurvUtipblFZKw9haG5FBjMkYDYpFIXxqxx3fB/BwPYqNxyJYnY5tJaNSrqDYcWQUZuwllNBDMciNGpwGgFt238fQqYifUyCuUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=LG0iE5+A; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="LG0iE5+A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135559; x=1706740359; i=wahrenst@gmx.net; bh=s+C5yRBMXtAg248/XAUH77adEcGlMjvS8LegdnUr0Qo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=LG0iE5+AiYZoaOylOS2JD3zjQXf+vZE6Zt9lc8uong2WuCHu2jI91EIPn8ejcx6J siZ7UrRqOKxKLaMtgI43GcalkioUH+jiIFBJAyUPEDuJboXeXSjJqW6LIjWJAjXdS i3WcnM6eDbbYDKRABJ1h4VM0Sno7TYz3N98NqxXzeqQXSTP3kCtl0nPAzuPpLENOk ctd9CLqognvcbU+QNoGb71GKEwZtM2scZdGq/gx2b3ApiqC2vKGJCVVPKGiuMMB5W WeKrvdUu3lM/C9tRG76rdOzyC1q0UKkEpF5aAg1szoEmrmXTPFMyDAYZNZxRrFPic 5UvOXDdoN8Su5v/Jcg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5wLT-1rQq7w0z4l-007Tz5; Wed, 24 Jan 2024 23:32:39 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 05/14 next] qca_7k_common: Drop unused len from qcafrm_handle Date: Wed, 24 Jan 2024 23:32:02 +0100 Message-Id: <20240124223211.4687-6-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:+SuZi/0u10m1P5jyBmdtkcS73RAKkaeuN2Z+lELxTKX6LDgfoJc Yar6ss22riQf+pdHWY3z6pxcBp+HKkw13W/w46wMQmJSZxs3dK49Dd3W66YZT+ou8kwJT+q +/EI++PnIXq/TLzVRH3MzvPpNNjcN0LI0JrYgH7aYC2GM9BFOADqIh6buMS0IfNdhCoXX4U vfOlWpDSDNQeDvDUPRerg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:we1Zf7Dv0uw=;Ppq1h2j7vnp19IwoHAkD3X91UZf 7zA6MT5zAAVvMPnKM+phPRO2su3u4gcfpzvhmtv1itVxAhHXZEq/BIaYKXqmpvxpKzm2HakLU Nii5ezDQNBkiX8sAeYaloi2WnRXxUYjsqAhDhiZ0J1+ajVVC1iXY+H83eM/uYufGMqb0Eyf2b j6vL29wDgRWLfrPtVwwlXXa3aLnkLB3VwyHCxVGccOksh1t5ucS7ooPb0tj/udrU+T7jA9jMw JGfQDLFF4Tbt9/hX74/LPaB4otgKecI4nA7AStsdWXpZZytf9SKGifPqpROYoiHMZaLFVpc+C 4Uyt0nRkBKXSd8u4rz4gItQfSXXfkF07fQmwWVPFMTv/EAnSd9kFbQkgrr0nXDQx8V6mOhKBq y5z4yIv/cq2ApY90tvi0b5LLrQvS4Fc8eiNGjSM0kERFAs39e2dQ6vGgUJr+x/P3lIRPRyQiy xpFUPymib2Px/lHfCtA13/dDdAO/kMzD4CHXxyO5Yu0A0u7tCwtbnco+7+dRzalycVkexvYGF Jr7WV+ItyWs0rfoY13rfSZHZ3Do9NUOx9AppuGehpfNRbpjw0GVUrL6uIXJyjNb5ppk4U5L33 h5jIOvO01LYcgrANW3C3VtZPx212l0ApjpgNBQi6slByJiWcHDSvjozUPTudjvCDriYWNC2qa ZiEOg8sZ8hGQlfZp+tjtYbJNqbBj4X/ZDhPznHOXcU0xU+mowVo4R4eo3R0yXjCEz4EDlBnoH iQS+tWXDkYll5ExdcyBuFbJNGZ/lLSr02WNYoplJsudwZCyarsU4rrLVtuYZSDn2QQ/eNqOzI A8PoL36DpEUZNqDcWzrG1G46YwJyzeJGdp03I+1KtJml2uDJNRChh9dmxI1B6E30U2vR7AVqg W419qyS391osKO620JXZAhfT/6X9UMZ6pBR9IY4reHzBGuHqtJPwVVo7UMFMwjb0iPo0Hk2ZI eQm97Q== X-Patchwork-Delegate: kuba@kernel.org This member is never used. So drop it. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.h | 3 --- 1 file changed, 3 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 71bdf5d9f8d7..088cca7f61db 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -107,9 +107,6 @@ struct qcafrm_handle { /* Offset in buffer (borrowed for length too) */ u16 offset; - - /* Frame length as kept by this module */ - u16 len; }; u16 qcafrm_create_header(u8 *buf, u16 len); From patchwork Wed Jan 24 22:32:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529743 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 235F7135403; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=Pzm4vJZBwp7SNM0EjjWNzGRahp/k2x3ueF8K1ltISc+J/XZmPOmvQg8Q6lGykjXAh7R0TS8PkhVCvoVGqD60J85VzTmO0JeXv0iZv66lUfELDAFa8lwA74aKVY/PFcNBhSWZhCTQ9dmwd5E200vewGJE4ZQu8JtE7RfKEPqglpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=a5awrOpTPwikDiOyOVG3aK1l4bf9XY8Ggcl++Tz/DlI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rs1WN0Y84SKyiOzKDKK47iQ3viwLP9Mex2mDZEWkZsYbD3SARD3PvxWq7Sjj9vc/e81NouGhxXyNA7ebcSVFUoww+AfqXxzzgqzZpu1BJIyuTO4uIIZvw5KD3kWstm+i7+uzxHkAgURl72KoTk0I2L0pYpKOo0oi+Zotmu5dYjc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=msbJGOvh; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="msbJGOvh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135560; x=1706740360; i=wahrenst@gmx.net; bh=a5awrOpTPwikDiOyOVG3aK1l4bf9XY8Ggcl++Tz/DlI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=msbJGOvhIeZnY1lQSzyrRFGyzr3bQQmeY6qUSftUI4bYpmKakXWJpGZI6uhx40Jv GZXVNtoXNVTyDDWWTaxzAClZo7y1xbqmQ8QzsOgnlStHDcXReiFIpdmWdG01gxnbD qJGu7y95ZwBm9+ByNaLGifHEYgJlQennMnGjg8UCtM8f1IcbPpK3PMbXvGBbvPM4D F7X1Wmz9tAkxOhKkCGNV53OKKz8/YGgG9YGY6Jn6DBpYYjambZoSB7Yxn93Mz+Ums ywWIlnaHcw6yiEwlyIsM1/mbTC0vQ3uXRsZ3W27ZcWRfRzhAL5pCaMIgSjPalaTGS VAVdykHR7VSqHf3Qsw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MnJlc-1qlm5538dg-00jF7o; Wed, 24 Jan 2024 23:32:39 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 06/14 next] qca_spi: Add QCASPI prefix to ring defines Date: Wed, 24 Jan 2024 23:32:03 +0100 Message-Id: <20240124223211.4687-7-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:V0hZf6rafJ9IERZbp0y+4Wh5HTXNAjXNZ4uOSpS7zDkXS/9o0K5 K1CLQCFsEMpBCU98eSC2Tg7vV0v/BKounoFNmgDTwsiDzblQo/pJrRjklOm83J/XOLkIkoF zp9LkKr1gClWQSzbenvZi2kZMKdCq+ZrJ/Qw6bGZi35BSxKh1uKQ1gZTxSzJii8PxK3Tx2d +FJapMMyXm+PL21+LbDHw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Xl/9Ft5BOxw=;WJmBDu5UWoHf8xhT0WtnHW0zLwV 1NQQgtGjLhqB11H9pM83WbI8UBS6UWwwaHOjtqHZQ0cHnDJcrxw9oYkRTk7erFOzigWgsavjV 9wUBgi3xDKCM/7keQX7kPDkxt4Jws3dDYf1x+hFaMx4CFsFSapEumzmqCIOvycbN31kGjmjtv /t17HH3C2J8eGAFeat5XYSD02TXpP0LBd6YYrRA7Ps4kAssa9xJSV2BFYawId3WwOJrrIHYf/ 73F4CxtftGh0hevyM44B0BPDEPiTuHS3ch8UdiBLPuzwzybjDbrf+Mu49T/1oYOVZIsdloTjD jS27zNk2GGFxWcM08nZxw+vbptZX3OQkQtvQ04+gCchXBXEP0NGJfvAp15R5QawdTTHGCtcvm OQ6Sg/xMXYFSBFAKXWn9TxOVyfknBik8sLDKTPX7IG6ifWHtRauIczKIAl5EWq1P9hbu5gJKJ eGCiNJ1TdqiaGR0eXNGb955tH5Vd0Azi3i4X5ROk2Qnp4nafWyvnaCXFPixy9eW4o5ompHMqv NtpLY9BtT1b0gHbNwzZJfW90Pj9izHbSyOvPl+ksj59TstXoE4NPa1V5gugbZa16kAoFE5Hpq +5a8Xt8GJCjvyXTwfHvm1yNw99XWSNjh7KccVCfHMjnzuRrveEMC0gSyDa7e+XzvOKKk7XaY2 HSEstPyG1jNimi4ETCNp5K1aiqbaREnKpiLzxA+gvxoUUQX6it2hFkJ0A4WTPYbnCBMseIOWR 3selW0VKw17EJ4w+EMLr9L11q1LA2ksxZqCuo41nDz5M33d2zSl5Lr9+fkOvivfp1cG0Lczww m/33eawEd+Gcc4Ud+K9a3RQKtU55R5yb4/k1bwtfTKf2hcmTlx8+L6+LJJJM/iaXTVVsD9013 mSBD4LH5kdUVBF99HG0gFrkpYiBYCxWogfvF76TDz++8w7rWRmHn20diqXeSb74njLXHJHyHy ZIHDdQ== X-Patchwork-Delegate: kuba@kernel.org All defines in qca_spi.h except of the two ring limit defines have a QCASPI prefix. Since the name is quite generic add the QCASPI prefix to avoid possible name conflicts. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_debug.c | 6 +++--- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- drivers/net/ethernet/qualcomm/qca_spi.h | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 1822f2ad8f0d..857883d0b5ed 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -255,7 +255,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring, struct qcaspi *qca = netdev_priv(dev); ring->rx_max_pending = QCASPI_RX_MAX_FRAMES; - ring->tx_max_pending = TX_RING_MAX_LEN; + ring->tx_max_pending = QCASPI_TX_RING_MAX_LEN; ring->rx_pending = QCASPI_RX_MAX_FRAMES; ring->tx_pending = qca->txr.count; } @@ -275,8 +275,8 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring, if (qca->spi_thread) kthread_park(qca->spi_thread); - qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN); - qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN); + qca->txr.count = max_t(u32, ring->tx_pending, QCASPI_TX_RING_MIN_LEN); + qca->txr.count = min_t(u16, qca->txr.count, QCASPI_TX_RING_MAX_LEN); if (qca->spi_thread) kthread_unpark(qca->spi_thread); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 919a400412cb..2ca25844d91c 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -476,7 +476,7 @@ qcaspi_flush_tx_ring(struct qcaspi *qca) * has been replaced by netif_tx_lock_bh() and so on. */ netif_tx_lock_bh(qca->net_dev); - for (i = 0; i < TX_RING_MAX_LEN; i++) { + for (i = 0; i < QCASPI_TX_RING_MAX_LEN; i++) { if (qca->txr.skb[i]) { dev_kfree_skb(qca->txr.skb[i]); qca->txr.skb[i] = NULL; @@ -889,7 +889,7 @@ qcaspi_netdev_setup(struct net_device *dev) memset(qca, 0, sizeof(struct qcaspi)); memset(&qca->txr, 0, sizeof(qca->txr)); - qca->txr.count = TX_RING_MAX_LEN; + qca->txr.count = QCASPI_TX_RING_MAX_LEN; } static const struct of_device_id qca_spi_of_match[] = { diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index 3067356106f0..dcecb072b8eb 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -39,8 +39,8 @@ #define QCASPI_GOOD_SIGNATURE 0xAA55 -#define TX_RING_MAX_LEN 10 -#define TX_RING_MIN_LEN 2 +#define QCASPI_TX_RING_MAX_LEN 10 +#define QCASPI_TX_RING_MIN_LEN 2 /* sync related constants */ #define QCASPI_SYNC_UNKNOWN 0 @@ -54,7 +54,7 @@ #define QCASPI_EVENT_CPUON 1 struct tx_ring { - struct sk_buff *skb[TX_RING_MAX_LEN]; + struct sk_buff *skb[QCASPI_TX_RING_MAX_LEN]; u16 head; u16 tail; u16 size; From patchwork Wed Jan 24 22:32:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529745 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C62E13665A; Wed, 24 Jan 2024 22:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=UON93yz/yFM/B2itUPXWngMXNFXkqlSfwRA1Nf3KD9PsU7M0WyFMyFSajey/0Z1c38zFA2k0+OzZ3To30poalmIrE64Yua90uOBpm12L7PpMUv2T8B2Mxs/dXSYRqV4wRD8JLfKfqDLLAguDNdztuNrRY14Ts4JIMT5EcKDUBMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=2d30L/9cmkRO/WDG+K1BNz5a2b/Cm1vGtAAK89cu4K8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c9iWfNjx6yyGV3Far0kv7Qz6n49XNrEDuTKe+PJ7ekp7huvMfdr0HTDTZNNhyOHXptWoSrCkSQyWCY03HdfE3z02DFCeKZxlswRahdP8VmzfInU5nBbczMj2URT9F+LFbCEbBnC/cRJUZEtwHLEuuIeKBAe6KrZxKYUIxBj3SlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=uAFsImG1; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="uAFsImG1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135560; x=1706740360; i=wahrenst@gmx.net; bh=2d30L/9cmkRO/WDG+K1BNz5a2b/Cm1vGtAAK89cu4K8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=uAFsImG1Wf/jyi8h5ZXtWNZuZRmEOgIRZb+2vS8yz05LjJtMF2cgskiK5ub2Sjc2 5BBZrDVqDymmz5pMiWQ9pCyW0kG7a6NhyJ+rHY8X7D1NYNXB2N7sdSJoSF/EOk6BE NwOpr4WhX/y52BnJz89RzNOiyswRb603O0ViS1JGTg4jnfAn7GGyQp1uYEaHTGWS9 hqwMbJs9kFX6XxCXZwazAtj2zyENe6MD7NBCr6B8KbETduSXEWkDeexCPuZWNDk2O khedraDLHHZD7N2Sre+68XEJYR2u6DHAtvhAeN3Ok5agLXZzfTIiJ8rCuKJxhiD/h Z5C2aiz3qLmxYjOZJg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6bjy-1r1mnm13fC-0184Sw; Wed, 24 Jan 2024 23:32:40 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 07/14 next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES Date: Wed, 24 Jan 2024 23:32:04 +0100 Message-Id: <20240124223211.4687-8-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:pNkWmArcSJL/MHR69zQw6xo3lRLg87y3skKCJrkSglOuOE2z9qd ff/Swto1BMY5T2WHf9azhuRBNMWdPQmKa3grlFoR6d3EiDh1GWJCcHK3Z1S1cgldLehF9FR +8SXmoe0mSLmN4LQ1MA3Gk3sE3A4kAlIRxsrST73e4m14OlnbJlYRihGJ+SaZv/XMZy9cGw q5U7vtNGkZ8jueplyeUng== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Qw5q0iuuywM=;6Y+cs0RRIy8Wmjncvhepicx5uS5 d9HGWomSamtw3OjimSWLB2BafCkf8d9jQoAgq/q6vDfxGPg0vUTd3KWujYyKvLhxhSScH3vJH ntmkBDkht5jquApRvwbWGiYt2yPvgEQEFUQxP1wGcgk1svqtJpVPdIeVxKXu/sJq3plD7nE2k 2F7C9+QZo4dBjoviLYz726hEUMcxLvl08ApZLve+8z4IciPDOrhMnIhR0kbyOUpCtri59yhWW +YBWKSLThybtVIonlRxJRdsIunnmTg2PV4brg0VmTRVYdhqIkVAoIvxpBEDYo0AyU6xPn1cFC WO5pt/E3fVH+ygTvyV/BWQ0eoKMeOFW79iJUPWdu1QFyUliHVc1HrOn93NfGCJuz4kOTTR8Bn XouqY6MEKczsAMetSAcYAMT5nu5crE3eqCf6YMhe4bMnhlaRzLaXYNziuz7VY6eKnmpKfSKkJ k3XZKaYbzo67+axt4c3OX9JZAmaEzB8TiHo+/gKYmhnzG2fY3x34FFTtEf+6c9s1MdV/l/NtL kXri5cdhut8wS/U9VESjqr1t1/BAZOvL5o3pTAr64EwB7sZRsAxWIy4aty1u90c7iCPwpgqep LTn2TFdp2jBu3D5cj1f/jki83hPengnKhGM/i5OZ+FR6Qri8jZsCZt7nbsBAjpRizI4Q3hW+I qnTujRoWOjzKyqo3L0VTkX+iZQ6KuAJcnT1DfH8LPqPa1dcSj5B/v0QRur9hJCpoT1fif18UB a4j94uk0ZD4eSBEtwDoP9pb1w+uOVO39F67HYDZuqRfCeI+FxWaUB1mlh+BW1w0lxgPw1WK9k wwhEPxQqhO2B3DJ8ta5wLKOJCWiAmLSsZyW74xEh/v4FwXfgTagTEPpMzKvJwNjkn2c9MrPG/ +qQo1xO2f1vqR9L/uuyniY/5YgBxHyWwBVhLsemO50pDxPx6dTDJ1JshESmQvi82CjPBQxJtr jVVQDw== X-Patchwork-Delegate: kuba@kernel.org Currently qca_spi reserves enough space for 4 complete Ethernet over SPI frames in the receive buffer. Unfortunately this is hidden under a magic number. So replace it with a more self explaining define. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- drivers/net/ethernet/qualcomm/qca_spi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 2ca25844d91c..80182f8a4a50 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -814,7 +814,7 @@ qcaspi_netdev_init(struct net_device *dev) qca->burst_len = qcaspi_burst_len; qca->spi_thread = NULL; qca->buffer_size = (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + - QCAFRM_FOOTER_LEN + 4) * 4; + QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES; memset(&qca->stats, 0, sizeof(struct qcaspi_stats)); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index dcecb072b8eb..f735ad77402f 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -41,6 +41,7 @@ #define QCASPI_TX_RING_MAX_LEN 10 #define QCASPI_TX_RING_MIN_LEN 2 +#define QCASPI_RX_MAX_FRAMES 4 /* sync related constants */ #define QCASPI_SYNC_UNKNOWN 0 From patchwork Wed Jan 24 22:32:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529741 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29879135A52; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; cv=none; b=rfAe7nQCxQZQ87QKzdP+Mp5hwCcj509nVVsJlJHc81Okfwn1xZ/SpB09KDnQgFW9YXPl1patKx1S7CYaE7AXkCI8o9EqPmG2Xmvnzt+47AKwu18ndl5dv0csF9rG+35P+V0bPMLzGLom3zjsbZNT4wSq6IYpedNiqGamEHFtDdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135599; c=relaxed/simple; bh=DKx8YCk6CvT5TPKgEWvZvqxJNyIHRyULsJ4f2zOAZbQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q/N/ZlT071I+tyi99ZkUEa3pCK7LkpFVd0KQh3JUcsx7WrFWUki4JdJVOMuGe8JxdWcvZjjKY4jKcw65Kptkk1kQZPwveyFCFb6p2yaNcY374wPX175ejHEdzM7ctwx61SvNjicIotw9WgMYIo/GMglOMDNXAK3iqjeOCJm6JLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=GVv1oiMn; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="GVv1oiMn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135560; x=1706740360; i=wahrenst@gmx.net; bh=DKx8YCk6CvT5TPKgEWvZvqxJNyIHRyULsJ4f2zOAZbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=GVv1oiMnWyRdqCtF9xB36UNqK21KrJyA4vtWVReKV+QUAk6jUug5fh5S8gWmvX8h D0GRy/DXzjsk+Egc5EvoLdmrNK9h46HZTId8jfUEp+NuvfBjFxNCbVZes8CUPvxK+ 5yJYfel52IjhG2sHrvd4jALZEoXR9v5snY2rtNVrgsm2OqlSuFp4M7dyeJddJeXsY /cJpqeLSjvDcF/xzyHsYj8ZCXkX87+D5/p/S3ELgpmDQuRMYIcViqDaeMibyhIfXX zkQLxXBHufvEqG+VoyucMovjcg+1H+SfTxQyZiNWxUxPxy5p8A5pnMVJnAxX1317j jCEXfhokq4bmAJwuRg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MKKUp-1ro1qB30QR-00LpTf; Wed, 24 Jan 2024 23:32:40 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 08/14 next] qca_spi: Improve calculation of RX buffer size Date: Wed, 24 Jan 2024 23:32:05 +0100 Message-Id: <20240124223211.4687-9-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:PBoXn1z7n6aZj88X6gKN7TzTl6JnE/RGUP8sTmqzy6ZP1uoZVvg OWv9vZgB8/gRdauVDngHXYqDbrSTMHEu6IBhbPsj04adI/rlHUYZD2lR+3yaFmGLOehyHwy 5ErWugWu3vJDqB/SEgmmvXFDd0aROcAbeH06G85J7zXe/JzzM3Tl4CAWI372nGjSHRtEkdq OjpSd+Ofyf/rGyf1QqObA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8aTzaSACv8Q=;D2gdFLGU8Wv2c5/OSBbKtOaPqpV 435zqOgGrggpm0CpQpbyAT4rjUNF3jrqG5h9cjSqQNdDl70zgURr8GV6DhoIQc7VLnBVMVxec e1VU1ySvY6JN7Fq/p+jglJn3z/mA1c9nWV3grzxFoxtO+mkj3tP1yv9Fw5r7KhgCEXP4GOplO u5CYY7ZDAq2glX7gjSnK8Mcj43jnWOEjfvjtbOzUE4AZkTkzSMcljqF5K62KI11Tk4NuSykMU UQMfjiqYljTahB1g7kgJfv8QErLXGkIbkllENP5vWShq6nB/CkfFnptjpYRGHyBY1mgYJiIPe MYLEkjkEwBuGkg94NDPtjOcXTXyu/i/biHnDhutwlIlrN33TlScymWlLmTicXZDl86FCSfAj1 CldZWSBTlSGoXnLNLE3OWBJiW+LQgLyEzHz6X0n9BFKICyGu47BP7C9jSABQEYY55N495/c2P If98fNfBc7bGmu3bkL8hVqW8nMZY20pWBu/CRRP4n0tIRPnhetyrTihXhqJo1IKFeHmuvjKsP zf77pQkoWA5zBB7cdwVAq4iqkWtMPrjubWxPvxDof8ALwnJs3AnNMgalXXkdLvHQbt6Mc21/L 7SPwhPnFkKTV/xKTk6GrQK6bLPIU6Ev0sgp5cHKjO0R2X+5Xr++t1luIOcj0Lgrer829mQBDc Jx4gQGDzISqC4pfUhMAZr3VudKeL8gHjzj4n0tRONWQ1r5aDyKRsltLPDLvbTWMUF6LzRcvD5 Otc/v9Kh9zT6lDI6L7Ntj0soFzxFcuLpNSsfKc6eT+H5SY3F8y8g75wf/UtM/EzGgJZ0rfA+e Kdr7OdGR4K4Z5Cs6C5mTPSZ0r/EuRSO5s/q2REspm4Khu7MsKum7DUpem2ldTdMvFs2BCVOw6 nyODdfuTWz3Kr6m+/DOrJ+cCPR7Uohh0ZzUKYTDKIn2mJRm+GDNQj+9pd6F/dF2K/y6ZQiyef AnThCw== X-Patchwork-Delegate: kuba@kernel.org There are two points with the calculation of RX buffer size which are not optimal: 1. dev->mtu is a mutual parameter and it's currently initialized with QCAFRM_MAX_MTU. But for RX buffer size calculation we always need the maximum possible MTU. So better use the define directly. 2. This magic number 4 represent the hardware generated frame length which is specific to SPI. We better replace this with the suitable define. There is no functional change. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 80182f8a4a50..6d2859aad921 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -813,8 +813,8 @@ qcaspi_netdev_init(struct net_device *dev) qca->clkspeed = qcaspi_clkspeed; qca->burst_len = qcaspi_burst_len; qca->spi_thread = NULL; - qca->buffer_size = (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + - QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES; + qca->buffer_size = (QCAFRM_MAX_MTU + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + + QCAFRM_FOOTER_LEN + QCASPI_HW_PKT_LEN) * QCASPI_RX_MAX_FRAMES; memset(&qca->stats, 0, sizeof(struct qcaspi_stats)); From patchwork Wed Jan 24 22:32:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529749 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35410137C25; Wed, 24 Jan 2024 22:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135601; cv=none; b=KWZINK5jcJmhG1KcHFgmQK5NJArzrL/gQeLJw3ZvLAKVSxjJqhFPv0oeTPqN/ta3A09pDx1meI8YcyQvSUthp1wrAG3stn6aLI6ODxCZBWRyrRLvYubv/QeBYlNo4H7dtr30g3mxzRE72KfUag+0n8ewvZV+wQoKv+Zw+E08+t4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135601; c=relaxed/simple; bh=k46vRpXLmQ05TSStQTxL2RYgiONz7SsdmJja7gLHbZI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I6UmxBEG5NUk5Ft0BjUqzjWHoyiBwt4ovup94lmX88Ti7COLlFt219gUKSNU3/7TGKPLbP1nvUy3XeIgzdAX77u7RGnKAaJ0R4JstFhuryq/nZVNttQMkYrVQvcHQ6ZY9a2Xt7gOpJYfcMjuuIF5lnaguAPoHVoxjKbQ4/LeN2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=X8MZ59Fa; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="X8MZ59Fa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135561; x=1706740361; i=wahrenst@gmx.net; bh=k46vRpXLmQ05TSStQTxL2RYgiONz7SsdmJja7gLHbZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=X8MZ59Faskn5zwSgJ4RtSebhqtXQS2S77BE98/tKPG0AIbacw4j86O48LCNPxE0d E9d/VEE9F1SckTZPw8mNSMMJk3IQiiRzkQwAFHDqmx2nYlT4CZ2K5rd9v+i1AEfb2 w0MwKmYkqzXw9Rx2xt5eZAejhzVFcomRGztOD3rh059xp+Houa+P2I9diecV5wVAs FeDXFbDcN+z/SmOOj7XjbJIPBQDtWznL9RwBnXccMVjtR0RDs7C7/1eUuyOmvBjAa PH6amBrXnpVw1E4XrwSMqS1NiVcM0mhpkYo+EX81FaMTiwrEPQtSdQpHX6JtA7B1h q3B91IH2RNlKJMVBZg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDywu-1rL6pp0pDo-009uJ6; Wed, 24 Jan 2024 23:32:41 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 09/14 next] qca_spi: Log expected signature in error case Date: Wed, 24 Jan 2024 23:32:06 +0100 Message-Id: <20240124223211.4687-10-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:dLdi0zahvxkgjsOoYMSSrmqPRETKk4DjTwif4r/ZSXb0u0dQBlS F6wY4N0xMyiwVx3G/OTTEsoGdIWcXpMaMP0OtLKPmqjAWXkykedj71s7SqFleMG9AoD9fHp zqZpQzGAa6rqOtkeLGy4ut7Vsz3iG3eaEDMdlDa7f1cTgGuiU3i+qbbLn38v2iwjv00BT+A IP+gckdJkiy4EOZ9S3SWA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:njsc23fLaME=;k/DZ59u1mWpIhnxuR4KdZft2Xds ghqXGQ6gHi8/C94swPgvN3kx5tSMOpOsVt1BX2lbRa0YrSQTyjTNusmuAR6tOSdWpwaviN4dF CdoKTr44H2y9hevuJhVyoc0etyPOtJZxBKj61crvuuHmfdTXhHlsIfUzygzcLE/YY3ODKfdu5 U8CnNGS7ShP+uSiZ1HBtL0cpGtYuSXuwywdnsvs5aMby4/ztQ//azFxbXcmtlphn+zMaNTPkE 7OxPx487wd1TXoCTNij1Wj6bzOs5vP64RWHbQjzwc96EsM7E4qopzmgO4taH+LWqVFx0ffmvC kF0rHQHhXWh7ppdRUZHPGPRtX3I5XjJMZ3eYSXWN4T+LxQgkxyW/sn5eMOjlfCsL+Ghlg1K2H 1DQOlM/FomaswwhxcDuwi981hFDuMErm9ZZq2XR4gmzFUhDqdOkVgmBTKIYmCbbgSN1C3TUgk 17iSoYsnXic4bogKQoTkxQz0YY6tJM18uVDYwmPXTD/eE/a8H6kX8HIAUgYxxUCECW7MAvvKq qdYF1TLxH0xwaX2VH5NSVGvpikXDr0h+aMXqTW0x8ZMxoEjDbFkEDqpfGjGGzc+/NZw8W9u0F O2rEfnD5aRkV1Fu4m7/7qYLTKSxzeHRYCHoVq2EF8IFD7MArrrVieMr2jd97zFJUEmWhpiDIr EYnor44Z3CNZTs0QUEen0wWSLwoXFy50TkLw5rIteGqOTaXrRlNMBY8QK1hPQdC4kmQOHK2ln AgtJ9AI/Bt2Pgw5wGUE0c0pqJxOrAgsOAjJAf0KFn/+bBcLYPAaummvLxjQKEBS6G5BjHTY30 s7j0rS/bEZcTCMYTOKqgQNoRZO8NyAJz/ns6oo6CeIYhmZrnERkWOCeLyrrhC+wXJ8CCxGHut jMRAnPiZuhnDbn0U4rFXgR4PFYInIrfsx2fm1Xn5k4XrICJtT7URedge88XsqyPxqA18XbRKn 0Bc4FQ== X-Patchwork-Delegate: kuba@kernel.org Most of the users doesn't know the expected signature of the QCA700x. So provide it within the error message. Btw use lowercase for hex as in the rest of the driver. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 6d2859aad921..c5d240fe4146 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1005,8 +1005,8 @@ qca_spi_probe(struct spi_device *spi) qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature); if (signature != QCASPI_GOOD_SIGNATURE) { - dev_err(&spi->dev, "Invalid signature (0x%04X)\n", - signature); + dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n", + QCASPI_GOOD_SIGNATURE, signature); free_netdev(qcaspi_devs); return -EFAULT; } From patchwork Wed Jan 24 22:32:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529738 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C35D130E3D; Wed, 24 Jan 2024 22:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135597; cv=none; b=ciWrwkX0btv4BEmgyh+ZE2qTfjw7F2oViXY1s2DRLvj3VuZs409/CoWAktlZ+a+T+TYnc56+7/gNVenshADACmuS6VG3S0zFFNrgZIXro4Mk8BC7T1Tmwyl+KZdcQ47vxbWSKYShFN8IbQEVBxjbG33SSDnB5qdND0x6gfcNYjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135597; c=relaxed/simple; bh=aPLUUURCdX8yefR9B+X+EaFFqrqIchv4U4ygOF8Vdzc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZmDXALMz2gAt1iAD9Da5zrxzt1kN91Oy+w/HgdymDH7z9NBIUOYSMfnurHqbH6JA9iNOEQIWolIjDRfFpBiLDY8DiJHffi2g+wjJJkD6CFt2zDatzf5rqWWBLBI26DqEgg42a5q+qYEO1qAZxDqRF4ztU9AasLJCm2/4rpzxJGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=QLwRG93g; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="QLwRG93g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135561; x=1706740361; i=wahrenst@gmx.net; bh=aPLUUURCdX8yefR9B+X+EaFFqrqIchv4U4ygOF8Vdzc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=QLwRG93gvugH69luDdbo1sna8wmWggF6jXwuflJC9Zaig0l1InFcAmQ4XagZ73UE HrqvtGHUdjWh9C6hI2evhPS6dRVwdvRn/gnkMzC1RozhoHoSTg6nbZ5AEfkq3yaxZ z06+9W9ICdN8Ws1dcgi5rNvTPoD4aZMsZwRYAXui8eb4mszpdAUekd5RimcN0Y9l/ te/Q5sPlc0vqtwHdyUjFkmZFN2NG4Fd94UgwBunGS5oMN5vRAbkZbMYUX1jOR4xhI ke7dMkASvAdTgLjVAMVRzSLxPAiPbVZ3KDJbIiDITGWqkMY96FvF/m+jPeXawAaA1 79d7a+8HZw5zJ5mqew== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MI5QF-1rGyEw2jN1-00F9Ux; Wed, 24 Jan 2024 23:32:41 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 10/14 next] qca_spi: Adjust log of SPI_REG_RDBUF_BYTE_AVA Date: Wed, 24 Jan 2024 23:32:07 +0100 Message-Id: <20240124223211.4687-11-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:RKnQJ8mFyiEBeynNQ4tWzggzqo0rymb9752Iu0YtU45KsP6H+TG oDZpwW3VdD5CuZOXwKB4LGdYx4qXDa5a/tmMqUBHk5uULAwzMzkHhHPXh2byWyJTUUSgyd4 o2NgSxCCOW6xmlUtjp1ZXXGBu4CYVd6jPFvC22DmV6tTTX5cixPnNqA/VaPPvoAZgbFPtX2 aK5fKIWCvBfArcFwiQP5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ugjREs5rMqw=;0rqJ9cyuQ05gzrybB2cW0gMwyRI VqY+YM0/rwxeISipI4WR+P6DR20f6BEKSp39Kt3Fu412Un9ffHFr7Pzx97B6dHjGHC2wYFKXN d/HDEf8yza0+Z8pXSzeVA7hHMb5QDJBaFzXw3HBvSqk7mNfwdOzsB9VHEsv6EQamQ/KHPWV+I ZgaudVXhBOsN/YPHxd4WHwtnZSs8ZwW+OUhnvemOtwh2qL9NRr7PRLGO73u0tyQcILMZO8q76 o/pyu32qjp8JfP3th+QV+p9p1NkwAp2pwkhi48PuDesvw7vkgpbgGmMskQ7fdLz3Ls3vMjM9s oPryfuIbsO9JtTiTRUz6cktknpirmmGCJz9jwtpVZ02fz38DPKrbNuB/Bp3JdnMWFS0XdlYES +ZbrzIcp+KY8wdkiYe92OGYtXQ8M/cX3ecStR8i4ACYuETbdXfCrfkBmD3H0ig42ObXJZ91M8 Cfay/Yr7Vep4nM9af7LrNEsek/WH++8Vkgx2yjAG7Iz/vW/Ir8ClWojVSKpwj9uZLd90x78s3 mSjaRypq5yjswP2QwjzTqH0gxCPIEMoNPjeiTS0eqjAzEDYFQInmUhFZZ/xSbXQe5/st68MJ0 q6VM5DR2nGpEbLg0WEWrMmFjq7wrKRID0Nsz3jtIyjrBCW/4KtoC9NfoD/3etQIqz87taa+rJ 1Tk69fiamUJVk8dEqxbI7tvvWcJDnDWStIZX234Vy3ozWafxc6ejmBBcQXfWzTet7NWmG6bTl BwPUKrbQOvWy9trA/j0Y+uSFKf8MVoKDsFBLu1ZqQnK6X6Cgjyie8ai2V0WqQnh7IsADr7nX2 t6kPO3sNAGx33FDoMJbiAFjjKmiM/T97vgqQrRfaXoIVUifbXXNFmAa4YJ+sP29vVNOXz1ucU z+tSW6QLvlpTuHg1FlW0xFa/23ikmt8/6sp1+B/IXPHDrYSwa6xKa36bnoU9g/qv1gJD8bF7Z hUW0FOoJERHoqMzxMkC90uDddqk= X-Patchwork-Delegate: kuba@kernel.org All known SPI registers of the QCA700x are 16 bit long. So adjust the formater width accordingly. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index c5d240fe4146..d3109eb24b4d 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -359,7 +359,7 @@ qcaspi_receive(struct qcaspi *qca) /* Read the packet size. */ qcaspi_read_register(qca, SPI_REG_RDBUF_BYTE_AVA, &available); - netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %08x\n", + netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %04x\n", available); if (available > QCASPI_HW_BUF_LEN + QCASPI_HW_PKT_LEN) { From patchwork Wed Jan 24 22:32:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529750 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35170137C24; Wed, 24 Jan 2024 22:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135601; cv=none; b=RSV2L2ziVFM1FpIlkve/HXpyUOUqwM9LALTotp0HL5EKnUtZpbYLTASdeVLoTtvHtia1+G43p9xHFFIR8thyGWSw0C8LtDzLUO22TfRIeCNKLyNAzIKtAtXgkEtq9yYLOOq9erimeJdWm+lbB6aR6XLZZcafNohA2VMGPIB/d2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135601; c=relaxed/simple; bh=RDndYU/UJoApIcvHSwbCFnZCrA4471ZL4jmcwAK2gCw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V3GTSNUzCEOEtihRtvK+w0coH0NoUMp8YmiQztRcWuOQkXwFAkVOxwSCghrf/Mie6vG0jcdCLHme6DNnGXGc54UqZlTqAkQuKpGSmq1sPjtgZdZktz2IdxtTYuL0mULA8yODOfjyiO/TPHmKvzgEHxZb/yLrWDt3SnyP+6flI1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=ZOzwnXMl; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="ZOzwnXMl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135562; x=1706740362; i=wahrenst@gmx.net; bh=RDndYU/UJoApIcvHSwbCFnZCrA4471ZL4jmcwAK2gCw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=ZOzwnXMlq1fqAu2xfqP8JbsO3NvTEF2lf5GjznbjySjJF6h01bo7gVAt4tmqAksc Petd5KqgqNMTNLZ7mYbYjoZhKf7QgE4+NR7GQpBbYGZVVgD7J2p8HUJ8rQ+l+9gbM rqx7walvFUIRjQy/CNnNR/pLtcU3rq/XI8klOZmjV0voG1hEz8KQh0zQKnhgFL1rh U2eM8hKp5Iu6e6CRub9Fehr7oB6Y9PFG5GuDFsC9YCf8AhgWO7HQoNgy2yGWuuLCM zsUKaLcWD6rg6LbN0RTzcrMzoXa/YsZb8i6+d3BSnaNe8N7JaMQS+JD1nEac961PE RWHFFm31xuWSsKMUOw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MlNp7-1qni1X0e0D-00li65; Wed, 24 Jan 2024 23:32:42 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Stefan Wahren , Jacob Keller Subject: [PATCH V3 11/14 next] qca_7k: Replace BSD boilerplate with SPDX Date: Wed, 24 Jan 2024 23:32:08 +0100 Message-Id: <20240124223211.4687-12-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:1KGzPM3vAPeQ78Lo4tnVvpL5N+I4Iimqb4T9or5sZULdIZDt2ra N6pEqS4NtG/z2e1Du/B+6VK3432vSa9+Q0j5vqsJbgb5Y38k3otP1dS/taHmnrmfMAHJDBa O/pii8v6qu6sYHMjtGhOyhqwyz6xD6OkFRfUz3HqVmbEAjGAYh706rAcRNlhVMD8Cf2YRlQ dUroEa8JcTtKCw9vxubdg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QsGj+4zh6gs=;tIuKtwgL1D3h+0mIIA9N2egloP4 vdDSRzZ7Dv3U5zeyQH04n8HCR8BD9zeuHLO4F8oI+8nlmRxqYjJ/e3N6vhskMaCalb0aXgBBn z/NJbP5ddgJCVBs4TBEjKO8VxcxXV21sehBLjpkM1vzS0dwfypokMkWvpp8dq+4Ke+ui3vZZ4 O71WBNK7uxK7jPGezdDoOptOFqtLzdDWYmrFsg/sqwJoexINAcNOrHO1ZKH8Ei+nkF4w9OCyD E5YnY5HTGVtDF8CMPsMgUwtyldEVjkgZN2OwP3y8NFfA7mKNsZaD+Zp6/IF9Fmhr8DkfmLL/E J6G7qmyK1Wzde/9ar5jB5ZrnoNvcMiMyc23Iwbg5IhnVIYR6Mrjmkv5ixCd8OS9my56RstyiC VFdI0vRTEGcZK6r/yQO5McNlY64d8+rq4YWTzkTcvYFpfUkhg4uoE6idYvIM55+FWg8nRGLc4 LtSb5ModmBXxn+M5ZLbhQ6/EzKNSpJIEI0/MmrXgVXWMqHlHxE8LIfN4hnPDt+U5Tb6bvWcke YaIaMkDQ/Bh6N9XjJlmDWK+7ZKzVdtQVWn+CcNvkzGnwm3kE9cFtFp4ke2PRkB2b2ys+PCWMA jKVcREbS6tXoxTpeBbWBTxsWVEfY218woVidIT9mHNTNLqby5aU4r3/0LTB8gHdWVxCmeOSIk oJ8jtWjRxtcdzbbnoHxj1SW55em0PEgy6mxzRVkYKEx91D6o6le5peVd4R8lACSBbMtKp2vwA Vm0uNSE7kPvSje6Arwt/xdMwpwEgVAeaoioiOtIIR5dZRr9Te2KkF/bUmseiFl1p0+tIk5ewK JaXa6QKsIO1i6V4EyETgLp7sxz+FPXT95I0mqJbVpyqTeUFbidiUb16arw4+kvUDrKPLwaDXj z0EXrEiw+lUY/WePwawJsYxTjwHHT7gqEIPDoezHEGcuNkAue66Grtai8LXJAUwdiyXkPU1i/ rzYcVxxmboOGKKreZGGQ6tECVew= X-Patchwork-Delegate: kuba@kernel.org From: Stefan Wahren According to MODULE_LICENSE the driver is under a dual license. So replace the BSD license text with the proper SPDX tag. Signed-off-by: Stefan Wahren Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k.c | 17 +---------------- drivers/net/ethernet/qualcomm/qca_7k.h | 16 +--------------- drivers/net/ethernet/qualcomm/qca_7k_common.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_7k_common.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_debug.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_debug.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_spi.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_spi.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_uart.c | 15 +-------------- 9 files changed, 9 insertions(+), 129 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index 4292c89bd35c..6263e4cf47fa 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k.c +++ b/drivers/net/ethernet/qualcomm/qca_7k.c @@ -1,22 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* - * * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. - * */ /* This module implements the Qualcomm Atheros SPI protocol for diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h index 356de8ec5d48..828ee9c27578 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k.h +++ b/drivers/net/ethernet/qualcomm/qca_7k.h @@ -1,21 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. - * */ /* Qualcomm Atheros SPI register definition. diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.c b/drivers/net/ethernet/qualcomm/qca_7k_common.c index 6b511f05df61..be2f754efd21 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.c +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Atheros ethernet framing. Every Ethernet frame is surrounded diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 088cca7f61db..44ed66fdb407 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Atheros Ethernet framing. Every Ethernet frame is surrounded by an atheros diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 857883d0b5ed..ff3b89e9028e 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This file contains debugging routines for use in the QCA7K driver. diff --git a/drivers/net/ethernet/qualcomm/qca_debug.h b/drivers/net/ethernet/qualcomm/qca_debug.h index 46a785844421..0d98cef3abc4 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.h +++ b/drivers/net/ethernet/qualcomm/qca_debug.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This file contains debugging routines for use in the QCA7K driver. diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index d3109eb24b4d..7c63baeb3844 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This module implements the Qualcomm Atheros SPI protocol for diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index f735ad77402f..d59cb2352cee 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Qualcomm Atheros SPI register definition. diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index 223321897b96..d0db9d0adad7 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2017, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This module implements the Qualcomm Atheros UART protocol for From patchwork Wed Jan 24 22:32:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529739 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51FEE7C08E; Wed, 24 Jan 2024 22:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135597; cv=none; b=Rbbv4PI+OD5SHW1xRIcjrIuea/G/kAbugQ6K3NCOmqV/HcYkVcm2LexOAQomNJU9OSvC5prXHey2K/hnJMBHb5syn4hvTUXAgpEAXyVE1LFSmZSZL8ANv7Q0MBD/19NLQN+F/EPEU6gCW5e9l9rNtEbxBLAtNYMKMH4l6EjmMdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135597; c=relaxed/simple; bh=tkLKTn8DhkyrcCxWX8yT7dnXK3EVIGJJiLfX8uXj23M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BwaKMVGgIYJqKJkyr6EzT0MV0ZfDQkAnpsbSfmNukdAwL/LSqCLzgxtibNu8wcswLaRh8IQ4b67wvOSJaEl07lbCWEgOetrCvh9CYKvgK9DgNdLovQKyYwqhj3/+vuZM+UpgjYPKEcsLw41UsfP8htMZfTOiGZyD/OMYQfLUgEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=IrZFIK6c; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="IrZFIK6c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135562; x=1706740362; i=wahrenst@gmx.net; bh=tkLKTn8DhkyrcCxWX8yT7dnXK3EVIGJJiLfX8uXj23M=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=IrZFIK6cLJSYUSlJRhn4JJls7izj3y65r29pBWImkw038qmeonmwRIXx45LoSktO fOxgG5wCGRNHwR2KwAeFZ9A9depFBpmD4Yy7/JHCSk85DlJYSt4ObA+1Vru9lYPiD RttKCU8mzSvbSAjN9z8E+6iJxH/4ujBR2VvuinnQwXiIXEhg6Eub4RijFytk2qN5E +eTkpasUdHy4WAHfb2Ds8lhoZR9gwkoS7t9XXYynbC9uEXLPseSqM8nCN4P+OjClS 355H66aeERcj3mEFWkEnG9UVXCDfbEldLzdhhQ8AoDzn9LDdGAgBoC5RzIIrUh69l irUTBpMGLFmewWIvTg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVHU-1rme822j2e-00JuCa; Wed, 24 Jan 2024 23:32:42 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Stefan Wahren , Jacob Keller Subject: [PATCH V3 12/14 next] qca_7k: Replace old mail address Date: Wed, 24 Jan 2024 23:32:09 +0100 Message-Id: <20240124223211.4687-13-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:q3a0x4qQk5+uqt/dkBIkcBItlhLqcHvgSjgq3jq9a/cLwV2w2pa VNoMrGlqqCcgPzvNc3BpOaqTqVmf/42k7oY73heOOxeG+T1gEOnon9RiZss6d2ZRZ3MugWv 8PQ1j69qHhr4S8A/qV34gdFwAN3ofLP5+IsH61op3JbWkw+ALUuEiPWRIlE95tGH3wYl3WT +U7w8vlHYL4rZlocBrUeA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:LAFXGoU9gpE=;V/M62mMDW3UBbW8g/Ves+20EiTZ SQxZqTrmxwXRDo9u41vuZ1EM9pWS9B6uZYyaUVje7ji27lHIrzLLMH3XJiQV9laDcRyFteQ4h fPQcqV0GgBTIhKT5nkXGMBQm3hxZTcQUcHtpm4OojGrNXqRrlSizuiJ6hVatmQQgPK1k8awFf OpVuuAhMthUyrK0F9wwyEsSF2MHNTq9yWLBqwz+atQg2uBVGbncMAES/LvY6yJtLXE49luyrE UtIe7lkC2quU3N7JpgKJX5e+GZfi1hBPTMYuHHsSdaTR1OM+wgblND6w3f+n5lWv6dv7uZ555 6LVU1jmtcia/SDZ/0dU6J6dIaE2wWrUQXqPmV3OtCVf1jyD4dnvImi0nq1MRGOS/4wWiODt7U aywniOPj2AmVA+vDZEpYmjG3Cotf4ifo0afffZvRrNJWIJLJrihcRvn1YiBEJWPQRxNEUKHkv Q7gSzujbjEa5gnLDCVFNqd9c8nVWkIeL+DFvfOisMjQW5WE25xPN2NisEhuM+hEhL3OdGgP2v OSzE59W1uTCyIKrkCLlVfZtx8Mm7EvWrPGM5nvGpBlS+7tI3hIg47LJTWBg/SgvjPmtZgqvxR nN7a5J1kAKv+Qq0NfTVgwym6f9xUj+j4Dl4gEm8aTJZbkaO1hBcR6P0ntltGCptUtSJkWjG/H ovT2mOrA2zNVKqKanSKXEnM+BymDKpIzoakpUzZ1ShrrbfU3TOeVkWLIOfwhT8mjzb0eC7lRJ AmEX2RYkOgDQeHrkq2kuRFoJ8UWIkar4qNFW/ljg3BR2CBxliJURUjRvw+DLXm8uPxqz6dZii QhMv4z36EdVhVdS5NAHCu9245tUY1RSBWZTwMHcdTu8BqySLZsRKhaq+9yBDgFa9C2PrfUrVI f4dLxCnwUqwltUKks0k225O4FN8V2coY0InXWBsf0KkaQSOaYSKWAI1jd/24Ykl6sEul892Ul BWpNJSxFo8UDgA848eTjAn89Id4= X-Patchwork-Delegate: kuba@kernel.org From: Stefan Wahren The company I2SE has been acquired a long time ago. Switch to my private mail address before the I2SE account is deactivated. Signed-off-by: Stefan Wahren Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.c | 2 +- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- drivers/net/ethernet/qualcomm/qca_uart.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.c b/drivers/net/ethernet/qualcomm/qca_7k_common.c index be2f754efd21..5302da587620 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.c +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.c @@ -149,5 +149,5 @@ EXPORT_SYMBOL_GPL(qcafrm_fsm_decode); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 common"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 7c63baeb3844..29be0fe0b235 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1042,6 +1042,6 @@ module_spi_driver(qca_spi_driver); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 SPI Driver"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(QCASPI_DRV_VERSION); diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index d0db9d0adad7..321fd8d00730 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -397,6 +397,6 @@ module_serdev_device_driver(qca_uart_driver); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 UART Driver"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(QCAUART_DRV_VERSION); From patchwork Wed Jan 24 22:32:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529744 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF9D2136651; Wed, 24 Jan 2024 22:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=lUppW+Ol0mS+dsDx3yoISzBX7xG+LNRZ1RQC6KwQcUtwy8vDdvYYLKq/3GlhSQLPuoNYElLviQo7TqMhRc+uy9+0KwbMVMr5hG8M1JPkWM+Rv0rmhtWTTyV6ziRX5GJ1fZZ4bvwwaxKP+YqHaIrEhwcxtBqGfofpgBXggj4SLLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=qomwzeZ0+VdI6mZ2yu+WT993r+YiIAfvdX9TkSDmq08=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=LvtE096BYOxyLAYFJStrEx3Ga1t3t2CjXrULx/NCH3E+klbUmrHjYEf9qoIbb/uAJ755q3zqh4DuvNElconqPf3qPOoDMZmLeFbPJ6laX6voES+jYalz6jFrFLGxavQ5Xw9jvcmQm8D41puGRDUdSTVj3WQWxus8KgxNNI7phyc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=RN9y/4ct; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="RN9y/4ct" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135563; x=1706740363; i=wahrenst@gmx.net; bh=qomwzeZ0+VdI6mZ2yu+WT993r+YiIAfvdX9TkSDmq08=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=RN9y/4ctJFpF3bqorIIKKoX6tEIqUXGLM65tihxfggrHmF8H7xqotvmpsYbz5yXO p9EC+WsSbHBkPeLNIswS0emRMyMb9xyLKrP1l4j3HwG+jMmS5NggF0JniRGaoNgcL 6sCyfM16zmkYXUZ+uispQrE1mYZZmHIAlhoPZ/vaIFYlkE4ZXuhSOEnuXBzZ877hG f/2XJn7zvG0zy9y6v4mlVXmr2Gi05SblwcBW8H9qqrGD43y2jpzCoHfpQwc4NMdcx fpWLN+acuxmDoB7EWhHxU1NhDq9oaKS0ioyTb8TO8bLfXdIqwIpXe8/lX43CLwU2t GGQisCIG3j8i+Fdg4A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M6lpG-1rSDZN0LNu-008InS; Wed, 24 Jan 2024 23:32:43 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V3 13/14 next] mailmap: add entry for Stefan Wahren Date: Wed, 24 Jan 2024 23:32:10 +0100 Message-Id: <20240124223211.4687-14-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:YvVG3RKT34IC/0QHC/pRgLRH4saf1SaSfj6zVwL6L1JmhH6unri KwWjTh4rmzviK1sL6EgRECqznvz7eH0BQ1w4/unCD3WEHP/H8sJdF70IMyqZae91g75/LZD W9ZL4Z5j/ZL7Nd5eFuKBw0kythuKEL7yQVT2vVVMLr/wlF0nGs+lf/2Zszya667dxCcQoVt wBpOaUh72q9X0eRVXFmmQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:iBC/vrINn5k=;FX0F+DH5/dJMmVAgy8RdOCzM5Ou fr9OnPM62P+9dcLlnlFSjQ1kSxCstegu7cXaFY2bAKDshHvWQr/wniARP4LlRKevGF3dp93SL C0spCZRugw5SOIu3K7XQITA56PEYc1PgaRU7EaoEkgkthcSAc7iUpnlKu2sovCUvZEmzm/MiN TG1gL3heJCXLrU4uFF9pEDijW+fhbTQDgW4iIlGr3MYsBz00YMpgqS/GjMoz+VHJEKQ1YZ6JD Ur6dqv+sB7ebYBG2Qlwz0cPeNgx6yoZ0CdZXC9ECoOhkWtGKFxP/afLBSDnOrZajqQC9yj3h6 Q7LRZSdVUUOiMVIZCgZ9ihf4iLqy3ij4uRs6NJoNgqq59moYZOa/A7TSga9OZNwKZGppL7NkK uApVIukrr+2MjIa6/O2KE2Y5J3wLM54QLUS++EZGRRzB0unXwsGIF/BFt7CXLQzbELdcpPSld 8BIcWt0//VrsspyjI6WSyP9aYnbBKEYSDJnpqs72im1gPM89FYbezpxAO8B4LaSm+s7AJO8nk rOMd316h6y3Ef63j41fo8UCYG9CH6GyxrKLZ/ocjKPZYGnNWps+1C305Xyl1T2LGrpv0Xffwh XsB43UII1sb7SMjIJ1wQBmTBOIeOmw3gezB3m/bMgj7Twwblgagq+jY4ui0bRmC/osAdQE+5t RULFvpEtYoW7tyL0y/poUNDDCHypDVEq94u/sqP8uIDxjei2xAAWFbcVRdp7s3KvELxewNQAB hQT0PyV+ST8gwFQXLJN/k1W9O6Kh0byduegAMJBUCx5LOd4PcZ6pSjfF6LnsL5KmQDfhbmrJI w22GXVqG73/aQdnhb06VjFm70MxajN7CYc4FEfkshcghgOuWmDIEgtA4v3vui6Hbze9FgGQ7A n70fFGgOlLY/GTfLu0m7VroMNMZwsLAvB3mvuNSMR+WgDvi9xuPm2UPyvMTNsnuKxJfDRAh8z ysO1oA== Add a .mailmap entry because my old i2se.com address will be deactivated in the near future. Signed-off-by: Stefan Wahren --- .mailmap | 1 + 1 file changed, 1 insertion(+) -- 2.34.1 diff --git a/.mailmap b/.mailmap index 04998f7bda81..95b4fe465cc6 100644 --- a/.mailmap +++ b/.mailmap @@ -568,6 +568,7 @@ Simon Kelley Sricharan Ramabadhran Srinivas Ramana Sriram R +Stefan Wahren Stéphane Witzmann Stephen Hemminger Stephen Hemminger From patchwork Wed Jan 24 22:32:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13529751 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93792137C40; Wed, 24 Jan 2024 22:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135602; cv=none; b=um8BVYkxipYqP7i4x73y7zL66VnNOWp0gFAZt0amh/VtvAfGxzv+5HcFp8WYOX9Meb3VARqS9pQanAq2wZopYLJoDmnGtrHwR7hR7SywQBI123pU78fW/KY9GM6JSHrCSv2T/YoUs24OjNcsvX6jqXcsH50aCqyFh+3/bfZWSs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135602; c=relaxed/simple; bh=86IbXZg2D8dZ14CMAOHu2fJ9DPKToZGpqc5c/wgcbic=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C6rheg8hGFXG7I5rNc9WKN8b2tP5cBR0EHTyFikj1ZV1NKTF9mmXrdb1caAH9t9X3TTMfKCHptTDPf4U7jrYYoTx5XQLfrrT2X2rugzBZ2CeXi6OV3ejZthFes6TPl/cq+TUtcWyLTtfEFBQfvnWdZikE3W9ya2SsfvcGhZAGEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=QrEmGNw4; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="QrEmGNw4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135563; x=1706740363; i=wahrenst@gmx.net; bh=86IbXZg2D8dZ14CMAOHu2fJ9DPKToZGpqc5c/wgcbic=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=QrEmGNw49fdFCnb9BqA7tcRfqzGBhuN9iZPjkVmzmBkuFNQLWTUSzBksGe0oQu6I pBmvYP6ZowcfwDE1MCSkxvSu7o7jlrYKaqK1V4MuvLhwUqpr82frU0fDw4b0sJOMd AKHw/t7XAl+rDz+5ml6Bzkj5l89YQfraWj5dFu2tNflIPbD5B2neCsJRqS4HgP220 +NUgvRMSgo7KD8RfGdZi01xBnrHKJi0quQ21XUrBMxUWu1mLCgLN6TDdwLIxrIlMV 5kEBVvqFeabFNJOGuiEuqOhN6SuOixN2G9pRSoRuO7MyXNuQ8HjOxuVeUHmO9Dilk gp+ZdIN7DqqViyOG8w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2E1G-1r6Ce5293W-013ecc; Wed, 24 Jan 2024 23:32:43 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V3 14/14 next] MAINTAINERS: add entry for qca7k driver(s) Date: Wed, 24 Jan 2024 23:32:11 +0100 Message-Id: <20240124223211.4687-15-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:An8E5MmPXOy0Qfm6lQu1YYOOU2P8WzbmtkdufPdgrrGHAjI0V7G u5Wd1TrEMwb5QVMDWkLoL9WRYGmgy5VkmxYVKLwnK+f6DDAWijKkFED/8T2O7HUTjq+UTKC FG9eznhdJdjAxaGaFq6wnd473nFEmymuS+5Log5UJ7nbhRmqx3vLpohFXP157AyR4isI8T8 y+O4pZERFrEwYsRJmmJCg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jhNNaGn7XvM=;fMxvYjVDhqTxkoA8NMapSUXoR+x UFJsFxwwh18uQ/8whJreOnD+MkwmqfaI4m2mFm24K2k/mdq941hY7V4ezWkMdry4Zts4q1l+U jZafyJYMdFuR9kTfzkk6dofGRLGzam9DQffYVb1T9LBoJ5428ac/NFF+GAGNMLF1aZM33gNwm QX9J1crfBsYId0KIOLa1DQlXYekTzD4obok5mtmv8TezRwgAgEbqjr18Vs0xx7rJs1x7pVpi7 QDYcq6YIZHh5dDWZFU9PEagnw002SKA1agoEA2RSjMeqJMzu0flW7NpRawC42tFmqeSqs3C5Z d2BQw/Hmti5AyJXGkN8QEV0u1eH+EYTrVAzaLj93mUn2u3kiH2ql1s4ZbM+icZU76d30DhJxK acsttIZhPOSiG7V1VPzdHCQZIq22nKMAPxvcvrLv5rhoW5cxOlos54WtiUzipLr/XrX6ufmVZ EeVJUMwXcx8KQqoDabDd9Q6dLKrNZ+tAjZT653PE8S3JASKOiPEWBVHm0O1tMDKFoE8XrvLnk i2a7B1S+oQhBY8RyEPBtfwQNACLhfhTtjSxa7UtUSgx955+zx3szdk9lSzVsOtRAJL3cWzo8O AW4gkND/F3KsJ0u16qGOvqD9bbgKNyyPD5FBsmBNaeIifVuvSzt4WOo0v9uq9NNrkhWaI2/LK OiVy+xHScJJY+vOs3+Os4BCPoPLcrIv4dyFaILKOG7eLFWr3173uYWmI8XZtC1mXqNGCQ5rKD FrHRUMzuD/LAXlcrcC9LKz6AFVRoruVyRmRJhPs60qdGvr4fh14JazA/uTG2k9sSZAnNQYkx8 /lRcu+MpM6D6UYQO1ZksQBBPkA4/4v+fvICyChBgbeB0mhZwouTwD4qEPIeyMo0UCumbAjF0j n8iPqM1zuJGYTg3bOI7rQQiAuaYJEL7yBk70z8a5Pqk2OT2DqQnu/PtlJD29AecjkBpwVeCpW tE+3Wg== Since upstreaming i contributed a lot to this driver(s), so add myself as a maintainer. Signed-off-by: Stefan Wahren --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.34.1 diff --git a/MAINTAINERS b/MAINTAINERS index 8d1052fa6a69..5808f06b4ccf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18009,6 +18009,13 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git F: Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml F: drivers/net/wireless/ath/ath9k/ +QUALCOMM ATHEROS QCA7K ETHERNET DRIVER +M: Stefan Wahren +L: netdev@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/net/qca,qca7000.txt +F: drivers/net/ethernet/qualcomm/qca* + QUALCOMM BAM-DMUX WWAN NETWORK DRIVER M: Stephan Gerhold L: netdev@vger.kernel.org