From patchwork Mon Feb 18 23:13:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Zhao X-Patchwork-Id: 10818929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 911FB1390 for ; Mon, 18 Feb 2019 23:13:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71B2C2BA64 for ; Mon, 18 Feb 2019 23:13:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 61E402BB29; Mon, 18 Feb 2019 23:13:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF2422BA64 for ; Mon, 18 Feb 2019 23:13:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6917D8E0003; Mon, 18 Feb 2019 18:13:26 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6199B8E0002; Mon, 18 Feb 2019 18:13:26 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BAD28E0003; Mon, 18 Feb 2019 18:13:26 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) by kanga.kvack.org (Postfix) with ESMTP id 1ED458E0002 for ; Mon, 18 Feb 2019 18:13:26 -0500 (EST) Received: by mail-it1-f197.google.com with SMTP id z3so1379144itj.2 for ; Mon, 18 Feb 2019 15:13:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=U/EYw2rlCI4mDqlXBqXNVekL8hDo+V+cu5waHUfY2FU=; b=f8lPMHYBR2CH9WjWc2Q6H37mkT7sJAG83rJJorsbiQKaJ3aYuETRo9M4L4DJUB17QF xdFgfzCjyl51OoX+KBd5OL1/CrqI0CKG8Yb0ZMp9rpYw/zJNot3/48ybHJzP1QEKkzPn u5SYNCG39jPIrXjmKIs+tDAReRljpMG9TmN0Dh5klvCqIx+r+S9jVPBxGicXXJn7PfWI DJ6fbUtKL9sphgsT0h4NMd7JnxGjirR+pHABzlK/1BAPZ8u87hkxSdKCnLR4ScnoB51x 6e9gwl5228xRYZ3nlHKeYuklfLEyg6//xP9XVcSK7H3ZrwV4A6SVdVf6NKETYKvmuvnL PeWw== X-Gm-Message-State: AHQUAubMTr7m9dEY3eayjYkfe48LkzYwYD12BrjebJmxbuOytUmhjGch Nko33PjLj8IbwyAJBWX3BrJR4YZeKj9FiN3usqWSA9nVJOA80++OoY1ZI5X1e0bWhr9Dlng2k5R X9BNcMFMCtV69EbAgIJxcJ8069LLzpqa/SbMhxhmVje2Y0qDYqmZ03PpsQV2k1Zy4fnu6NzFcNj MpAuWrGSeweX+x3Zt0mCsUEG/SA4OcXBuHoH1K5vYAPT7ZbpAedesgEbRlY/+XS2NrXyLJK1zjM 0DvZCKRh0HZloPSpNdT2bySrD3JTZMSpMhI1z0Sx8GDNzkjNad+i41yQyii0mYQTmRaxhRbETC3 7grzQUrlmw0vJvf+n98GfA5MGkoSfu5+Q2HFH2D7GCdAa2/kQk6Sml+yB+ZF4ckwNFtMDV1k+g4 M X-Received: by 2002:a6b:d81a:: with SMTP id y26mr16607840iob.221.1550531605806; Mon, 18 Feb 2019 15:13:25 -0800 (PST) X-Received: by 2002:a6b:d81a:: with SMTP id y26mr16607812iob.221.1550531605147; Mon, 18 Feb 2019 15:13:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550531605; cv=none; d=google.com; s=arc-20160816; b=s4W33muK4A/wJng/LFS34bevHkCdM5NVh87AinYxi8qGLiW6UP7P6mb0rJk6MBVq6I uMnidO9U+7hmwKalx+SPaEq41FSWJVLBqiYXkZN3P6CgXjw0x6S5NEVEwVE48QJpmfgG VWEjC02CbMw9LzkQ5ivjet16a/F2xFY67xSGBmil5OgDu8Vtlw55nmO0Z+uV3ixvEfkY SY2Ou+WSF3BIpvZNjvswpQaBOeMVUnhDzpkLoKoqeQ3TKVsfomKDhoF1E/3/YEk9LV79 3D+GeFDTRgYUKxB/TH3Qt2LVOk6MpCxaTVu+YBp+g3HQVh7xm6YiL9v+qzKO7Rn1d/el Bq/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=U/EYw2rlCI4mDqlXBqXNVekL8hDo+V+cu5waHUfY2FU=; b=BmOQrwCAGKOKETjq2UHsy2fD4SSbnCmsVgYEbQ2yTYQ7/+N8WfKu46wkvh3Rwda+iv Sv5UGyWVK0aH1tEaPfO6hrH4twc5vFiwQsnGCCg2bE+jqFvK+ulT0dwNgZSamwhUw4kL q4sy3mL9x8ppLlj2J5L5pScs56CCtrubXGzrdbJr2qkATVgnjCocZ/ANrq0wm4XZRfVD npum1iDDbOjAxn63p91fJiTTi4GOVeo0KyUiDzU9w/yyPmkC5q0fpOYxuJpXGo03C20l oMrOYNxUze9ZTl+xhD+mAbPYgvPO1bGNZ8vPit2fkH1umLWu1Cee4Dba2hgCVJQWEkPG so1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Kim7VCp0; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id h202sor1227251ith.17.2019.02.18.15.13.24 for (Google Transport Security); Mon, 18 Feb 2019 15:13:25 -0800 (PST) Received-SPF: pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Kim7VCp0; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U/EYw2rlCI4mDqlXBqXNVekL8hDo+V+cu5waHUfY2FU=; b=Kim7VCp0StMXRnvvAWqYcMEpvO63kYz5zHERRNvlruuQQyJ/O/6e+78airAc6V3njt QPh65tXH7igo5M8n9Y+AY35NXYR4O99incnRtGZjj5tDT4G/3SpUfm/d5+VrXm3QMc14 75MeWggtjgmG93XKz8SbkdnbNJxnW40gBOu2nYy4fTAaAZalUyFgJHBLbbsFBZcpmf7r gIqdQ766/KCsrLwCM+YpAq/CN78i4u/aY+3DZvUca0RcFYIOEnylrKumqeycBQkWaONH MUXpvu3EkRdDRMckSlclBjo8KbsFUEzseKNLXMHT/gA5Kd3J8udX+m6D9rsbbBHZIn4Z 4luA== X-Google-Smtp-Source: AHgI3IZhDNTkjmRqX5ciPMAt1QHx6yCLXNgtuFuVzvtd4/Fv0kqYiBMJG132E3NRHTpB/NiNuEH4qw== X-Received: by 2002:a24:918c:: with SMTP id i134mr744158ite.92.1550531604541; Mon, 18 Feb 2019 15:13:24 -0800 (PST) Received: from yuzhao.bld.corp.google.com ([2620:15c:183:0:a0c3:519e:9276:fc96]) by smtp.gmail.com with ESMTPSA id x23sm6541463ion.38.2019.02.18.15.13.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 15:13:23 -0800 (PST) From: Yu Zhao To: Catalin Marinas , Will Deacon Cc: "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Joel Fernandes , "Kirill A . Shutemov" , Mark Rutland , Ard Biesheuvel , Chintan Pandya , Jun Yao , Laura Abbott , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Yu Zhao Subject: [PATCH v2 1/3] arm64: mm: use appropriate ctors for page tables Date: Mon, 18 Feb 2019 16:13:17 -0700 Message-Id: <20190218231319.178224-1-yuzhao@google.com> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog In-Reply-To: <20190214211642.2200-1-yuzhao@google.com> References: <20190214211642.2200-1-yuzhao@google.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP For pte page, use pgtable_page_ctor(); for pmd page, use pgtable_pmd_page_ctor() if not folded; and for the rest (pud, p4d and pgd), don't use any. Signed-off-by: Yu Zhao Acked-by: Mark Rutland --- arch/arm64/mm/mmu.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index b6f5aa52ac67..fa7351877af3 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -98,7 +98,7 @@ pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn, } EXPORT_SYMBOL(phys_mem_access_prot); -static phys_addr_t __init early_pgtable_alloc(void) +static phys_addr_t __init early_pgtable_alloc(int shift) { phys_addr_t phys; void *ptr; @@ -173,7 +173,7 @@ static void init_pte(pmd_t *pmdp, unsigned long addr, unsigned long end, static void alloc_init_cont_pte(pmd_t *pmdp, unsigned long addr, unsigned long end, phys_addr_t phys, pgprot_t prot, - phys_addr_t (*pgtable_alloc)(void), + phys_addr_t (*pgtable_alloc)(int), int flags) { unsigned long next; @@ -183,7 +183,7 @@ static void alloc_init_cont_pte(pmd_t *pmdp, unsigned long addr, if (pmd_none(pmd)) { phys_addr_t pte_phys; BUG_ON(!pgtable_alloc); - pte_phys = pgtable_alloc(); + pte_phys = pgtable_alloc(PAGE_SHIFT); __pmd_populate(pmdp, pte_phys, PMD_TYPE_TABLE); pmd = READ_ONCE(*pmdp); } @@ -207,7 +207,7 @@ static void alloc_init_cont_pte(pmd_t *pmdp, unsigned long addr, static void init_pmd(pud_t *pudp, unsigned long addr, unsigned long end, phys_addr_t phys, pgprot_t prot, - phys_addr_t (*pgtable_alloc)(void), int flags) + phys_addr_t (*pgtable_alloc)(int), int flags) { unsigned long next; pmd_t *pmdp; @@ -245,7 +245,7 @@ static void init_pmd(pud_t *pudp, unsigned long addr, unsigned long end, static void alloc_init_cont_pmd(pud_t *pudp, unsigned long addr, unsigned long end, phys_addr_t phys, pgprot_t prot, - phys_addr_t (*pgtable_alloc)(void), int flags) + phys_addr_t (*pgtable_alloc)(int), int flags) { unsigned long next; pud_t pud = READ_ONCE(*pudp); @@ -257,7 +257,7 @@ static void alloc_init_cont_pmd(pud_t *pudp, unsigned long addr, if (pud_none(pud)) { phys_addr_t pmd_phys; BUG_ON(!pgtable_alloc); - pmd_phys = pgtable_alloc(); + pmd_phys = pgtable_alloc(PMD_SHIFT); __pud_populate(pudp, pmd_phys, PUD_TYPE_TABLE); pud = READ_ONCE(*pudp); } @@ -293,7 +293,7 @@ static inline bool use_1G_block(unsigned long addr, unsigned long next, static void alloc_init_pud(pgd_t *pgdp, unsigned long addr, unsigned long end, phys_addr_t phys, pgprot_t prot, - phys_addr_t (*pgtable_alloc)(void), + phys_addr_t (*pgtable_alloc)(int), int flags) { unsigned long next; @@ -303,7 +303,7 @@ static void alloc_init_pud(pgd_t *pgdp, unsigned long addr, unsigned long end, if (pgd_none(pgd)) { phys_addr_t pud_phys; BUG_ON(!pgtable_alloc); - pud_phys = pgtable_alloc(); + pud_phys = pgtable_alloc(PUD_SHIFT); __pgd_populate(pgdp, pud_phys, PUD_TYPE_TABLE); pgd = READ_ONCE(*pgdp); } @@ -344,7 +344,7 @@ static void alloc_init_pud(pgd_t *pgdp, unsigned long addr, unsigned long end, static void __create_pgd_mapping(pgd_t *pgdir, phys_addr_t phys, unsigned long virt, phys_addr_t size, pgprot_t prot, - phys_addr_t (*pgtable_alloc)(void), + phys_addr_t (*pgtable_alloc)(int), int flags) { unsigned long addr, length, end, next; @@ -370,11 +370,20 @@ static void __create_pgd_mapping(pgd_t *pgdir, phys_addr_t phys, } while (pgdp++, addr = next, addr != end); } -static phys_addr_t pgd_pgtable_alloc(void) +static phys_addr_t pgd_pgtable_alloc(int shift) { void *ptr = (void *)__get_free_page(PGALLOC_GFP); - if (!ptr || !pgtable_page_ctor(virt_to_page(ptr))) - BUG(); + BUG_ON(!ptr); + + /* + * Initialize page table locks in case later we need to + * call core mm functions like apply_to_page_range() on + * this pre-allocated page table. + */ + if (shift == PAGE_SHIFT) + BUG_ON(!pgtable_page_ctor(virt_to_page(ptr))); + else if (shift == PMD_SHIFT && PMD_SHIFT != PUD_SHIFT) + BUG_ON(!pgtable_pmd_page_ctor(virt_to_page(ptr))); /* Ensure the zeroed page is visible to the page table walker */ dsb(ishst); From patchwork Mon Feb 18 23:13:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Zhao X-Patchwork-Id: 10818931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 17C851390 for ; Mon, 18 Feb 2019 23:13:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 043342BA64 for ; Mon, 18 Feb 2019 23:13:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EBF152BB29; Mon, 18 Feb 2019 23:13:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D4DF2BA64 for ; Mon, 18 Feb 2019 23:13:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A15648E0004; Mon, 18 Feb 2019 18:13:27 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 9C7CC8E0002; Mon, 18 Feb 2019 18:13:27 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8197F8E0004; Mon, 18 Feb 2019 18:13:27 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) by kanga.kvack.org (Postfix) with ESMTP id 4FAE78E0002 for ; Mon, 18 Feb 2019 18:13:27 -0500 (EST) Received: by mail-it1-f197.google.com with SMTP id i186so1273683ite.8 for ; Mon, 18 Feb 2019 15:13:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=V1IdqbYubtCixESl5TR0muUvkg/E2O8mQvzM202vMJY=; b=Q2/hm4yQZXbAVQQ0foHZhAqo8TfBMlc8R1NAbKk/onb0U+tPYFAzabPE7L5HfbXx50 Qo22TxQjTQbmEMDezvZueoggjXyLv7GYp3lo50ZKT85Q6ZTSy6NxNgpVAt5sTdJf3YGS +ycVRlbBR266ssS2P/ip1Yxm7MYjitYwgdj5bYzpMqyeLYLfdvuLgp38bR35b1DapB/O byUb3q3ZM4jB1KIG/5iyZDeBtqjItvwt4UHCmCZPp2NvHZAYqm7VbDI5h+NbO0ZZvoH+ U/Eo/dw4rPamzVh44eV8v8J470L3jx/JGI6S9zSv6ZmfcE4794j++IUeqrm8WIHTvb7v 0+cw== X-Gm-Message-State: AHQUAubXq6ue6Je5x8ZtBSs+AsQQEOE5N7H0amC7SjImtJz8ZGvfNqFd 5ZyDPd6oPbA2887xLdDjY3yx/ihpjSQV+LAOPFuVA7RpzB6MTEaJHBpa1hH90AZTV5dTX6GT0Dn guMO5ZSSijzgJ9SrYGgWelRKZNPQjvm4NXHbs/PKls0qIYeCtB6z3TnuZAGXpb4B+rKWvUnwtbD yCF2jHJzXnZnWWEG0jy3mxb5K9scDyAWlU81dOvQY3sxl9oLfOc8HHUg9uoEh6ix7ssbA/TW4qU Wgg9q0atRMFOX3sbh4PEwkJuOHnysKTvlveed7b4PM8+thK/ZdqC8XZHba+iEizRlPrsH0g4+ym cyAevZcz4wgfPFTmd/3Wln8Mx1aZe/ZJ4sX4UHUIIHNno4dFEI7aOjl1o3WcWqUYkg+CV6OHkDg P X-Received: by 2002:a6b:e810:: with SMTP id f16mr16922921ioh.194.1550531607094; Mon, 18 Feb 2019 15:13:27 -0800 (PST) X-Received: by 2002:a6b:e810:: with SMTP id f16mr16922896ioh.194.1550531606551; Mon, 18 Feb 2019 15:13:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550531606; cv=none; d=google.com; s=arc-20160816; b=JJ9Fpwg0uERHQxKYC5uueUx7MoEH4o7GHY9YVA+v9TaFCQ0J0utl5tP0HYN7f6MOuI LHeDFYoVwAJSyc7SFnebbNyIhP0Fqz0siuls/FXrSCnLfIelnUSmTcuIE9sVszaMbgTa oDnMczixkTCFZGKQoSKZM/zMlQtJAUb+yi9jlO31Q3zFM0Lq6r03RFQAFeVSvPe+bYjW Zf7yViQ7nZp2QaNkx+eLpYZ4rtNQSinLE7Ys6tM/hT3amLeVB3vveUWfHq/wEnT/h0ap kdqItyPqpIQ5JJX6SDb5reqi3yOKGIUX+XxvhKea1ZQOmcYDZc2/g9+J7IC5ViN0Ay1o i0wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=V1IdqbYubtCixESl5TR0muUvkg/E2O8mQvzM202vMJY=; b=VaRY5Oltd4uJonZNBY94VYbgz59R3EkyOIlks7gurEPxn1OaC+b5K+774KFbz6BXko ADTPiA5qevg1WiPxGNN6MjKXYFAXluVK0VjZ6wJv6aq2gXM/XQCakiSYJ3Psk/e2HaB/ ecTtCxrRDqBfTMQEni08B7CFepBLhdr1NjTW7i7XGYdD+a0/YYERLwWZLmClWgKlmXlS LCNp0E3JDZnzm93K+x7SwK1snOefuoE67VmRW1NZdVASOBoMwMqUl6+qdfRECTyPGph4 Z9P+HjjaXTGcbkzDYLVzbis/0ADHg2TjKwWAQHNofYToa7nZGt6gM2Rkrxm1k9IiyaO5 9+Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=bsfGy1P+; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 68sor1232954itu.24.2019.02.18.15.13.26 for (Google Transport Security); Mon, 18 Feb 2019 15:13:26 -0800 (PST) Received-SPF: pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=bsfGy1P+; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V1IdqbYubtCixESl5TR0muUvkg/E2O8mQvzM202vMJY=; b=bsfGy1P+JAaNzK2xsZmC2Tj104zGh/lur1QTBqvenBJ2/qYq2g/zlrWxNZQtQfM35p SvHcbH51aav58mTv6SC3r+eXafQV/q2wT7dySMfLdYtqGwd3IU4BO5OncxK0Sc1m+fIj nQfKurxrxsrekUV5Engn2LJyRILWrYvwJyz5n0SWzgddARHKb325HaCw91Il4vDU1Zx/ mk9/PYlyIFAHhkP2hr5znpaOUFZOUpl6KFCa/NcBzVtwHJoN4RB7/T7YpN2vbUZpYTCL LQgIbfhf2ht7PVFcOoXfG78S2gMcj0aiK0WoV3lEAuUhwncWxtNbknbhAN1dIFxSI790 gxtw== X-Google-Smtp-Source: AHgI3IZT6Mu4hL5CdKV5I1EiL7aKLnA6dLePkX8jtfw/N38Liese0eXKCRasVCtk+AF0ZUvijxlkeQ== X-Received: by 2002:a24:7d88:: with SMTP id b130mr796701itc.163.1550531606189; Mon, 18 Feb 2019 15:13:26 -0800 (PST) Received: from yuzhao.bld.corp.google.com ([2620:15c:183:0:a0c3:519e:9276:fc96]) by smtp.gmail.com with ESMTPSA id x23sm6541463ion.38.2019.02.18.15.13.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 15:13:25 -0800 (PST) From: Yu Zhao To: Catalin Marinas , Will Deacon Cc: "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Joel Fernandes , "Kirill A . Shutemov" , Mark Rutland , Ard Biesheuvel , Chintan Pandya , Jun Yao , Laura Abbott , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Yu Zhao Subject: [PATCH v2 2/3] arm64: mm: don't call page table ctors for init_mm Date: Mon, 18 Feb 2019 16:13:18 -0700 Message-Id: <20190218231319.178224-2-yuzhao@google.com> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog In-Reply-To: <20190218231319.178224-1-yuzhao@google.com> References: <20190214211642.2200-1-yuzhao@google.com> <20190218231319.178224-1-yuzhao@google.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP init_mm doesn't require page table lock to be initialized at any level. Add a separate page table allocator for it, and the new one skips page table ctors. The ctors allocate memory when ALLOC_SPLIT_PTLOCKS is set. Not calling them avoids memory leak in case we call pte_free_kernel() on init_mm. Signed-off-by: Yu Zhao Acked-by: Mark Rutland --- arch/arm64/mm/mmu.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index fa7351877af3..e8bf8a6300e8 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -370,6 +370,16 @@ static void __create_pgd_mapping(pgd_t *pgdir, phys_addr_t phys, } while (pgdp++, addr = next, addr != end); } +static phys_addr_t pgd_kernel_pgtable_alloc(int shift) +{ + void *ptr = (void *)__get_free_page(PGALLOC_GFP); + BUG_ON(!ptr); + + /* Ensure the zeroed page is visible to the page table walker */ + dsb(ishst); + return __pa(ptr); +} + static phys_addr_t pgd_pgtable_alloc(int shift) { void *ptr = (void *)__get_free_page(PGALLOC_GFP); @@ -591,7 +601,7 @@ static int __init map_entry_trampoline(void) /* Map only the text into the trampoline page table */ memset(tramp_pg_dir, 0, PGD_SIZE); __create_pgd_mapping(tramp_pg_dir, pa_start, TRAMP_VALIAS, PAGE_SIZE, - prot, pgd_pgtable_alloc, 0); + prot, pgd_kernel_pgtable_alloc, 0); /* Map both the text and data into the kernel page table */ __set_fixmap(FIX_ENTRY_TRAMP_TEXT, pa_start, prot); @@ -1067,7 +1077,8 @@ int arch_add_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap, flags = NO_BLOCK_MAPPINGS | NO_CONT_MAPPINGS; __create_pgd_mapping(swapper_pg_dir, start, __phys_to_virt(start), - size, PAGE_KERNEL, pgd_pgtable_alloc, flags); + size, PAGE_KERNEL, pgd_kernel_pgtable_alloc, + flags); return __add_pages(nid, start >> PAGE_SHIFT, size >> PAGE_SHIFT, altmap, want_memblock); From patchwork Mon Feb 18 23:13:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Zhao X-Patchwork-Id: 10818933 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2BC41390 for ; Mon, 18 Feb 2019 23:13:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 904CF2BA64 for ; Mon, 18 Feb 2019 23:13:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8476E2BB29; Mon, 18 Feb 2019 23:13:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C2AC2BA64 for ; Mon, 18 Feb 2019 23:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA9CB8E0005; Mon, 18 Feb 2019 18:13:28 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id DE4258E0002; Mon, 18 Feb 2019 18:13:28 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C38358E0005; Mon, 18 Feb 2019 18:13:28 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-it1-f200.google.com (mail-it1-f200.google.com [209.85.166.200]) by kanga.kvack.org (Postfix) with ESMTP id 97C8F8E0002 for ; Mon, 18 Feb 2019 18:13:28 -0500 (EST) Received: by mail-it1-f200.google.com with SMTP id m136so1301724ita.9 for ; Mon, 18 Feb 2019 15:13:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Ptp8Fjet112pFAX81FwzCfRXujZdfs3mZO2hPYz+OK0=; b=WsPJxLKtEzTT0QJzdGPkV10gdmdFnBzm74SjAeztHhcta/a6uMHweC+nAJhC2lIsb6 pcrz9OyRzuC6GS0W6kLmyPCtHSEJiqSqzviFTouqxatWi0iys/nxfMof3dGLqs5p5ti7 yFDVZzCzKNNgovojcuVXmbRWpPP71TnJI+oq8GvtSV1iF/TtrLKsM78wmbTohnKBfpyY zx0UxJd3wAYOSM16BlQUy4aBj7pQG+U4J5XRIWlVHKaMNCdWp1+VT35MM8Aq7UyJ007D zbdmggO2dfJcLM/Gd6PfOtvLLz4UhcL/H1huUH8oopIUFCdsS8YPSgD4+jIJLt1ubhIX YisQ== X-Gm-Message-State: AHQUAuZkAuVhY2E7CUGbEoOLejo5IhMSlounVi/rGTmVhoBaKbFX5/nu QULzhWOk2pNprbHOJiGgCmEUd142ShK3/EwV81RXniL+GCMjx+nh+iNs/qDOdLfZAb9ujTRJY2o 98ycQMcyo7835pnmqrh+egJ+9YKhWHHm5YVaSJ0l5P5pNP5WOCVeVWP/mEA3xj4M3Z92HHL5w9T m8ip8VW7RXIk0qhlEKlbr7rmdCLljJ9KUCjDnLjqTCQ6jgKdc1yf3f/Ib4aBdFA7nzeyVg2BmK1 0tQTn//hDHRazYfiumV6JIaJfi9brfu8F/Pd6BoK38YHvG/TimxntarG94LdjDmN6YmhFVgZ22o /KZUqzlRNIBVFGcE7TdptJSDyzc35USivIgDXa9B91+wdt2lq1TazpitT7PUesXI5KK/Crdbt2t W X-Received: by 2002:a05:660c:12c7:: with SMTP id k7mr714763itd.148.1550531608426; Mon, 18 Feb 2019 15:13:28 -0800 (PST) X-Received: by 2002:a05:660c:12c7:: with SMTP id k7mr714740itd.148.1550531607708; Mon, 18 Feb 2019 15:13:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550531607; cv=none; d=google.com; s=arc-20160816; b=YZwYmsZT2ILwT9t5vxpvQYI+zovR9FoJSJ6kn8KRDCBslNKWOUZG8JnQKYy8pTfSUT IQZ2sCzmFrNrFZxQOMmqPOLaz5rAha5qIzLSTJZ1K8U1Gdx+MCBPk9XTb9HjMH6HFzjK fWIPaoYbnilZwkPLG50lOjKjm9yjh0X0yXZJIrVS1cglL6vEVUt05dCNUuyuNmjQ/Vzl PD0qdp0SS4kyETDHzU3x6ux2UVvPvJfBOcNZRRFXZt5863NPDcJm/QjzoIFpvOlx25wG zAyeKw1esoJ+jRwlwdISblsw5/p1Y/SNJDGSifwWtT1c6xB/TAv2m/mx1Zvglcj9GiRV Hyiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ptp8Fjet112pFAX81FwzCfRXujZdfs3mZO2hPYz+OK0=; b=HcHwqUYxV8g3t7nBKexWvBsyjuux3x6/sYn+WfUDnzYnO6QFY/lrvbx1h7XG/8POD4 1I/XJhrL2sgyuC6BQ27AdHDKnVM/Tvlu3xWWzAwudNyJrCmw99iooU+eOvcKrgTYaq7d 8r6nmJme3hXb5CQ1IyQP9MWfKO1/VEKrDK+yA99D2GBw01Dn3ilDmb9zHAK0inmpVKoH NtSjYzV/Z9eQwa3ZmLFhyl1t/BiQp9qo5NNuagvTklBCUZWk2sq7si1wrm4HbAjD8plr 6/WIg4e+6J8Llu97OpG5QOoaz2FDCxRGGCfEpp51pHDiJizYPS+WBS6cmu6ZPb6SkjJv zmIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=oz6Vj4Z9; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p3sor8806916ioh.112.2019.02.18.15.13.27 for (Google Transport Security); Mon, 18 Feb 2019 15:13:27 -0800 (PST) Received-SPF: pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=oz6Vj4Z9; spf=pass (google.com: domain of yuzhao@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ptp8Fjet112pFAX81FwzCfRXujZdfs3mZO2hPYz+OK0=; b=oz6Vj4Z9Eu13inGGnH5X0txN4tIEXnED3IA3SA+DL8Hs6lXNzNnfm18np5LEndb7ZA voPhslSSyKSjUqu885dvRfDAXX/PbCgZmQFNVkOsVEN+4xI1ESCcr1mz5xtEvA5kvars 09wiPRS+Hwsa+5nu9xpAsdZrJaodFZfBOg3XimOLubN9MU2y8MKftP9YelUNkAzC/6g9 QAcyLa4Y+3B7hEfLJ2RdQBWvCjW1fk05ykLXknVMZlQjFrReHBgkwhMkb22PovOrMA07 3g+h9qiMKm7CgJHN837fmuTIcRUGWB9IqflxYJVAswPy/99fhVawSTjRKNSbOu0mCQwq hz5w== X-Google-Smtp-Source: AHgI3IacpXhp7hqR4gpLOYb6jmTOiOS9RIZiMJQCPu5S8CRxsY3H9kPVQ0HReFAyHwtbAO1IIUX12g== X-Received: by 2002:a5d:8545:: with SMTP id b5mr15973963ios.288.1550531607332; Mon, 18 Feb 2019 15:13:27 -0800 (PST) Received: from yuzhao.bld.corp.google.com ([2620:15c:183:0:a0c3:519e:9276:fc96]) by smtp.gmail.com with ESMTPSA id x23sm6541463ion.38.2019.02.18.15.13.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 15:13:26 -0800 (PST) From: Yu Zhao To: Catalin Marinas , Will Deacon Cc: "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Joel Fernandes , "Kirill A . Shutemov" , Mark Rutland , Ard Biesheuvel , Chintan Pandya , Jun Yao , Laura Abbott , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Yu Zhao Subject: [PATCH v2 3/3] arm64: mm: enable per pmd page table lock Date: Mon, 18 Feb 2019 16:13:19 -0700 Message-Id: <20190218231319.178224-3-yuzhao@google.com> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog In-Reply-To: <20190218231319.178224-1-yuzhao@google.com> References: <20190214211642.2200-1-yuzhao@google.com> <20190218231319.178224-1-yuzhao@google.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Switch from per mm_struct to per pmd page table lock by enabling ARCH_ENABLE_SPLIT_PMD_PTLOCK. This provides better granularity for large system. I'm not sure if there is contention on mm->page_table_lock. Given the option comes at no cost (apart from initializing more spin locks), why not enable it now. Signed-off-by: Yu Zhao --- arch/arm64/Kconfig | 3 +++ arch/arm64/include/asm/pgalloc.h | 12 +++++++++++- arch/arm64/include/asm/tlb.h | 5 ++++- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index a4168d366127..8dbfa49d926c 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -872,6 +872,9 @@ config ARCH_WANT_HUGE_PMD_SHARE config ARCH_HAS_CACHE_LINE_SIZE def_bool y +config ARCH_ENABLE_SPLIT_PMD_PTLOCK + def_bool y if PGTABLE_LEVELS > 2 + config SECCOMP bool "Enable seccomp to safely compute untrusted bytecode" ---help--- diff --git a/arch/arm64/include/asm/pgalloc.h b/arch/arm64/include/asm/pgalloc.h index 52fa47c73bf0..dabba4b2c61f 100644 --- a/arch/arm64/include/asm/pgalloc.h +++ b/arch/arm64/include/asm/pgalloc.h @@ -33,12 +33,22 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) { - return (pmd_t *)__get_free_page(PGALLOC_GFP); + struct page *page; + + page = alloc_page(PGALLOC_GFP); + if (!page) + return NULL; + if (!pgtable_pmd_page_ctor(page)) { + __free_page(page); + return NULL; + } + return page_address(page); } static inline void pmd_free(struct mm_struct *mm, pmd_t *pmdp) { BUG_ON((unsigned long)pmdp & (PAGE_SIZE-1)); + pgtable_pmd_page_dtor(virt_to_page(pmdp)); free_page((unsigned long)pmdp); } diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h index 106fdc951b6e..4e3becfed387 100644 --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -62,7 +62,10 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) { - tlb_remove_table(tlb, virt_to_page(pmdp)); + struct page *page = virt_to_page(pmdp); + + pgtable_pmd_page_dtor(page); + tlb_remove_table(tlb, page); } #endif