From patchwork Fri Jan 26 08:08:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532176 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FF1F62A07; Fri, 26 Jan 2024 08:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256531; cv=fail; b=m22B4AiupIG6vQBowyUVNzoya5f9i8l+QU7UW2qrHEDTrAhspT0hXt1mO9BHmbVUfEHUE1pFclCtqjrxkiZqdf/3xxKL9UvOadkLnUL11O8/sC7xSeVXMKQFo63jS0x1lAPgbdLevb63y2g0074+4QygnBSJcNUee8LCA/IshVo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256531; c=relaxed/simple; bh=3yJMwxobrIJsk1KFSskxiV7y8hdpzxIHbTp+/BbOeNU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mPyu9PffEhjlBrEpUi6oZQhFA9oD818wyKutX587K47cjw4UfBqhCk+jnzt5TarBTwLjrRwrH//lWk5bkDce8elHiAPWUta6jSQesGiQA+ZoGXCdTqym6yCzNSl+GOmRToAQhCC+WObjFHfnB+KP4vCneXw3UWBpmElJFJOkkuA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Ho9dW2v9; arc=fail smtp.client-ip=40.107.220.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Ho9dW2v9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OElq9mczbaQFuZqMnX7FWrPIBXdICePICw9B3BpX9aDcFFlgm7ude0Gqa5iaqu/+UHWvmwKkQKa2kJqPYuWoEUP5wXe0lBvZa++z0ZCQnRCeqLmy0BKdXLnQid1AwGiIN16ti5Mj9LeNXIq6d55IsWbFhgiGNQ73rLIDreSeqU0xqD6AbniObccZt5zjccckvniAtoUiNyGTBS7uSZmXZgEvv3iOHiTuRG3uX+uxS0JZF62BiMLHV1MIXaFgTf+n9c4fhSGWcsLF8DZKoXd4+NhHieSIwzSiklxxNm5NB2KclrlFm1LSQ8qcidsnGvDGIK5kT+ojrVd7yiBWt8jGzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pubakwJL3Bbb/5I1Ypp2OiUAZ8NLMJkn861b8yY7Nes=; b=VGCfJBBlJCE/QVVFGyOjMRCHLiWb5HsRYYD/XDk+y7Dv56JGRMgDkM+6RrR1CyagBlakXkWPDtErA+v1HZYZNne3StemAJMFL05qUHQV9I9quCM3vkpXUU3hHd0tiZeqa2CCRirqnwW+tDQx4FjN2Q137+XqowASkCQb8GrnznhxozLxhaEZ0NLXadQXeRngyRe/zesqlbxEZVJ3f0Ld2bQDQdWWUL9yPbNao0wpUu8YFBy3TVkra9GYvTEP07XnZO+o/a6iQphAPSyNi7CiLQqvN+QXgvLmoDsHO+lJlpb81luB1q/Dvgt7v0taTY1wIJuFWIkhBLC0j8qBvHj2Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pubakwJL3Bbb/5I1Ypp2OiUAZ8NLMJkn861b8yY7Nes=; b=Ho9dW2v9pZfuyAnBSnOoHTEArUD7Unpj5pubAE3TdLFP1FsyXraapWlCSc/G2O+WOcNWk5pn1EsCT/WQvfYOh0wrJIHmGsohfVFOMW71dA63BTbQUCGYts1/N+XSXUhQpxXJOfkiiBQY0XJNZVYr81NCFQYhcXZZGa07Gd1lDoY= Received: from BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) by DM4PR12MB5311.namprd12.prod.outlook.com (2603:10b6:5:39f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 08:08:45 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a02:80:cafe::e1) by BYAPR01CA0008.outlook.office365.com (2603:10b6:a02:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Fri, 26 Jan 2024 08:08:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:08:45 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:42 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 1/7] cpufreq: amd-pstate: remove set_boost callback for passive mode Date: Fri, 26 Jan 2024 16:08:04 +0800 Message-ID: <3404e063b86a5517b70d497b066c3fdeb5d8bef3.1706255676.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|DM4PR12MB5311:EE_ X-MS-Office365-Filtering-Correlation-Id: 71ebeea6-447c-4ae7-519d-08dc1e4604bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /gerS5qFq2ay3zGra5aFPPirwoZQtjLSb8LzhMvVoxThLX80XGNbLw0jMLLTwi/eJo9UuCBVxVgWvORKeUUQgqF31Ma6IQFaYU1xki5BbGwpJNLuISupW1AgEXreVWOzekYtCXdiOJAfYqm80AasdNc/7Rj0b9CmhXUTXhtBHPDDpw3NfG+Zh5p5xC0yHE7nftxWWFh7Gp/f+5iOu9+sBqp99xRbu82K606VVs803FUjzJwKnNGmUNAeOwHKf7BobBXFz6QEEmLd5VCn/+3U5/JvAgAkDTJfcb6XHce7CmyyoJOhU3sIeObTcri8j4IiyMJgYdWT3eF/eOpICtlcE/+mXeHsumaw0q6fdJWXFXHMuP4rPxNw+OLp9aPDO9+8vQ18YNPeaKWS0pRhoEVeNiv4WyO192oU2+ezfsmBvl+WbQphRyCjCqElnWW9pIC33mqhsBf9SX98eCKQuymPKD858L6AkURLZqEDj7FENa6QYfJkA1H0gNFbq/MdYkpKORuuDXzSJE5Hrj68oGUJKc9ZG2oDttHFXgSAHAR34Jze7y1Wl9+/mJEvee36SVAddZqWc0cGDxg9V1Xm0ORLNqUtGwg99FFiwCV6A/YdW7aZAmlP+/PIhMcyzCmUHx5Uu2a51LDovbD8LReZNSwu4Wule2KU7a/9dE73frTpQCJanaNqEhMTgB/fDW7OT9gZS+KcWB1+9qHwfNEGXprhjc3LexgLuLyuZD59EjqrJ5KnLgwFT1RKW1p8o3+cSrvMQoUd3PxTlfKMLv+KvNNItQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(39860400002)(346002)(376002)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(82310400011)(40470700004)(46966006)(36840700001)(41300700001)(26005)(16526019)(2616005)(7696005)(6666004)(83380400001)(426003)(336012)(8676002)(8936002)(4326008)(5660300002)(44832011)(478600001)(6636002)(54906003)(316002)(86362001)(70206006)(70586007)(110136005)(356005)(36860700001)(82740400003)(81166007)(47076005)(40480700001)(40460700003)(2906002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:08:45.4199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71ebeea6-447c-4ae7-519d-08dc1e4604bc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5311 From: Perry Yuan The following patches will enable `amd-pstate` CPU boost control method which will not need this common boost control callback anymore, so we remove the legacy set_boost interface from amd-pstate driver. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 9a1e194d5cf8..8f308f56ade6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -632,31 +632,6 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) return lowest_nonlinear_freq * 1000; } -static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) -{ - struct amd_cpudata *cpudata = policy->driver_data; - int ret; - - if (!cpudata->boost_supported) { - pr_err("Boost mode is not supported by this processor or SBIOS\n"); - return -EINVAL; - } - - if (state) - policy->cpuinfo.max_freq = cpudata->max_freq; - else - policy->cpuinfo.max_freq = cpudata->nominal_freq; - - policy->max = policy->cpuinfo.max_freq; - - ret = freq_qos_update_request(&cpudata->req[1], - policy->cpuinfo.max_freq); - if (ret < 0) - return ret; - - return 0; -} - static void amd_pstate_boost_init(struct amd_cpudata *cpudata) { u32 highest_perf, nominal_perf; @@ -1391,7 +1366,6 @@ static struct cpufreq_driver amd_pstate_driver = { .exit = amd_pstate_cpu_exit, .suspend = amd_pstate_cpu_suspend, .resume = amd_pstate_cpu_resume, - .set_boost = amd_pstate_set_boost, .name = "amd-pstate", .attr = amd_pstate_attr, }; From patchwork Fri Jan 26 08:08:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532177 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2047.outbound.protection.outlook.com [40.107.220.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0921A66B5E; Fri, 26 Jan 2024 08:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256532; cv=fail; b=kuMr2JAhpyROl16qyPy/09jpHVH1/tiSjZq2ZPiAaPr72PRV3sx3c24IqOKVDueRXFbvXVo4jNOsgG1ZK6WLr/n/fVURCmYcJCNJRkcXLsjhhjBDzEBTFXV+FF1QM5lpAlUmgibS44tJZSqp5rJ1ehJAvvU+DUA5rb26yMWmcVQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256532; c=relaxed/simple; bh=FQhdeqBABGQevdCOeKTLkYQntoXQSjVMSy2guOjCtEo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tz+q4eu1dSbpYMWqw4xWDmUZiOeVfXKVwJMw9T6Tn6HjeVFdMJI9+fNsYDh/Yz81W2yA2L7n4r77fatf/aaBq/9Vk9QrtuLUa/GyF5c9frFQgWk3cHppBcwy4AJVkLRsvnJ00l3ZpYwVxyqHnWvUtF+Kuu0huiDQ/zvaU3Wr9pM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=rmVw5GMi; arc=fail smtp.client-ip=40.107.220.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="rmVw5GMi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwCCIDE9eh4jt+1YhEahxVaVanfxeUiGZY/WUDbsPT7uyFDyCkmw1NmEIvQxaYItBiJYh3SG5aJo6qj+Uks9RAA+FTEYZ06M/IzuFIJErOc3N55rYm3VuTaSMXrUXL9eRW1z5a6j87AEzyRgK63R4zz18MwN+/MTH0e5eLpgzIi6UTAAJJrD2xgN91BHESELxD0SYM5V1JzJS5IhXO1gkLz2xNsKKNfxrY13Xh9mA0PDl4FepYGYWamTM/tACSL5vCa25BDfrnl+3OzRIMjxxmGDchnooVShMOBEdwYZBme6tKHIh/BkyEpjbgoCXBlzEZDgm6XLuB1fVTgLkv5kKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SQ4JdInETrt07iGA7sHRatZnkDgbYvAn5F5tTGvZ52Q=; b=fl3uVVT2hWm/udFiRlh1RX3HhzRZlxTtrL2EinEUErGF6PjM4Myvv77webjzlQhdDWSw8ZZZuPh3cjF9I9ZpL+YBoLjG1Ot3vtkc7Xrv1EUnIJseNrwnv23NznDxpFVggRNy9GJr1Ayze9U964POh0Qud/4Zjy30L4dsPoBjKhnIkPJmPmo8ILntl8HUydfF34W8ld/nq0EY11MK1bxvv+AR0E6+1kaxJkWvripbHNcXBEwv6MKrKBby8Vfdajmoyu6QwK7X/KjrwFG6c+8boCziaruC6jBY9Q38MpubAOfJKuj5Ltsmh8bxCN1xtlmRue3Cn9YE6A8l5s4+ntwPVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQ4JdInETrt07iGA7sHRatZnkDgbYvAn5F5tTGvZ52Q=; b=rmVw5GMi3nEgbJZIPVKtp0Q/wuq9OxriyMgEoBlCbfK3o5v3nFxLFW8wf9VC7FDTIWsbOWCi1GpKdTqvmt8AqrgUw1HSA9YCwQnPful+E90v9d5VJwNnCt/ybGWtQ0Qdj2xMzU0S/10k385YUe34lvtuVIhBCkHxlxWLgbAiHS4= Received: from BYAPR01CA0026.prod.exchangelabs.com (2603:10b6:a02:80::39) by MW4PR12MB6874.namprd12.prod.outlook.com (2603:10b6:303:20b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 08:08:49 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a02:80:cafe::1) by BYAPR01CA0026.outlook.office365.com (2603:10b6:a02:80::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27 via Frontend Transport; Fri, 26 Jan 2024 08:08:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:08:48 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:45 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 2/7] cpufreq: amd-pstate: initialize new core precision boost state Date: Fri, 26 Jan 2024 16:08:05 +0800 Message-ID: <0409d40c500eeb8d4d84ecb028b73f2eee147822.1706255676.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|MW4PR12MB6874:EE_ X-MS-Office365-Filtering-Correlation-Id: 8eea2675-04a7-418e-b15b-08dc1e4606a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V5zK1ierk8sOlVnX9vjIQCtDXg8JiKBCFlugzlneldIl0lttngyG5YpNg3oFak1ZkT5kYxohK8izdXOtLMCuqNaZLYUfu5vgmxqip7YjCIWzUndd+Pj7nMGfYBKXqamYqF75mbwENyUtQOJJyOv+iId6FnHmfkRtYfZZT/jnUAqDXSSkebanacrZi1a6qvI/791m7iCaI3Cqeyhl9gFudk5xnSka5OSPkBtqJhdY2IB52O0rr4kgU18SyF3z/rlLmnHNIDxOyeZV0XBafBIRGzzmvPg/DnX65iWHw4f2ehmhSaewbC334ltGi9JIjkGdivjP75osbRzOmrQdNGh8e/0HYJWK1zEvodhpssqd8Wk1EuEgLJIIcBalRXJjB+ZiE1XER4KydUnzkvt71WV6rLjmEk1xiRMpvblNFJPZEmFbq/LV9eQXseEDXT4WJ1HEsz9V72nDsGbvA7a0xtPiEOuwWYYZ1D8haJpsmk/VAtvYSXBa5l3RuGDgMZvXwDrBCyRZpTx/9ZWjd8bGqEHxdyJc7z6j4UyRFM4zBuy2XYQGcfCyREtsBdcv6ft2s7VnRLb9QSG7m+DitygXjokHE6mH5qB/bEoZINhEvWQYYiZOXMhgIE0fEKtyGAbuEflmu2gEG91waVut+JDvnlB5jzkn+3Xj4cezk7tKvJdJHY61GJP3hsA5sHP7jF+/bDAXuNkP0wvLrkCNjnUPpfJEQiRdfcfV1eFsqirL/g7YUeMmmo9xeyK+LARGARwZDt39Qq/90br8UWAkJK58CTzlGMdESPtGpKStsWwUYTMfgPU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(82310400011)(64100799003)(451199024)(186009)(1800799012)(40470700004)(46966006)(36840700001)(41300700001)(83380400001)(426003)(4326008)(336012)(26005)(2616005)(7696005)(82740400003)(36860700001)(110136005)(81166007)(44832011)(966005)(8676002)(47076005)(5660300002)(8936002)(16526019)(316002)(2906002)(6666004)(54906003)(6636002)(478600001)(70206006)(70586007)(86362001)(356005)(36756003)(40480700001)(40460700003)(518174003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:08:48.6074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8eea2675-04a7-418e-b15b-08dc1e4606a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6874 From: Perry Yuan Add gloal global_params to represent current CPU Performance Boost(cpb) state for cpu frequency scaling, both active and passive modes all can support CPU cores frequency boosting control which is based on the BIOS setting, while BIOS turn on the "Core Performance Boost", it will allow OS control each core highest perf limitation from OS side. If core performance boost is disabled while a core is in a boosted P-state, the core transitions to the highest performance non-boosted P-state, that is the same as the nominal frequency limit. Issue: https://bugzilla.kernel.org/show_bug.cgi?id=217931 Reported-by: Artem S. Tashkinov" Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 46 ++++++++++++++++++++++++++++-------- include/linux/amd-pstate.h | 1 - 2 files changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 8f308f56ade6..0dc9124140d4 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -65,6 +65,19 @@ static struct cpufreq_driver amd_pstate_epp_driver; static int cppc_state = AMD_PSTATE_UNDEFINED; static bool cppc_enabled; +/** + * struct global_params - Global parameters, mostly tunable via sysfs. + * @cpb_boost: Whether or not to use boost CPU P-states. + * @cpb_supported: Whether or not CPU boost P-states are available + * based on the MSR_K7_HWCR bit[25] state + */ +struct global_params { + bool cpb_boost; + bool cpb_supported; +}; + +static struct global_params global; + /* * AMD Energy Preference Performance (EPP) * The EPP is used in the CCLK DPM controller to drive @@ -632,18 +645,27 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) return lowest_nonlinear_freq * 1000; } -static void amd_pstate_boost_init(struct amd_cpudata *cpudata) +static int amd_pstate_boost_init(struct amd_cpudata *cpudata) { - u32 highest_perf, nominal_perf; + u64 boost_state, boost_val; + int ret; - highest_perf = READ_ONCE(cpudata->highest_perf); - nominal_perf = READ_ONCE(cpudata->nominal_perf); + ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val); + if (ret) { + pr_err_once("failed to read initial CPU boost state!\n"); + return ret; + } - if (highest_perf <= nominal_perf) - return; + boost_state = (boost_val >> 25) & 0x1; + if (!boost_state) { + global.cpb_supported = true; + global.cpb_boost = true; + } else { + global.cpb_supported = false; + global.cpb_boost = false; + } - cpudata->boost_supported = true; - current_pstate_driver->boost_enabled = true; + return ret; } static void amd_perf_ctl_reset(unsigned int cpu) @@ -676,6 +698,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + /* initialize cpu cores boot state */ + amd_pstate_boost_init(cpudata); + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -725,7 +750,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) policy->driver_data = cpudata; - amd_pstate_boost_init(cpudata); if (!current_pstate_driver->adjust_perf) current_pstate_driver->adjust_perf = amd_pstate_adjust_perf; @@ -1093,6 +1117,9 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + /* initialize cpu cores boot state */ + amd_pstate_boost_init(cpudata); + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -1143,7 +1170,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; WRITE_ONCE(cpudata->cppc_cap1_cached, value); } - amd_pstate_boost_init(cpudata); return 0; diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 446394f84606..66d939a344b1 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -80,7 +80,6 @@ struct amd_cpudata { struct amd_aperf_mperf prev; u64 freq; - bool boost_supported; /* EPP feature related attributes*/ s16 epp_policy; From patchwork Fri Jan 26 08:08:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532178 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2060.outbound.protection.outlook.com [40.107.237.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD5DB679F1; Fri, 26 Jan 2024 08:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256537; cv=fail; b=a+U0u0D0I810CpoRpM619q8Wh/E72i3PZDKdiArd8wQK/w7iNjSiaJK7wGGNqsJc6gYA4SDg0qt609pA8rEWPKEpUA6FaLW6yXGjRbFLSsy7q4YZUXUpY3gTidAKJNhnJ0HboTWrH/UvKTRJ+JdYaVnIAMLIXXW/uBoJ9rBXmmI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256537; c=relaxed/simple; bh=2ffpd9uHwBDo2ir+uRhyoRLhZ7P8UjR+V6tHgLibQ3Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NuwZHwtnIZfhpAPZAKgScdH3oIcF2JsiaX++UQbc6m97eFCdGu6GeAsXL/E+1KO1hVnZt7K7pBOQ5ZJalFATQTx48AvfgJ0PO6T1evR0I/GvKaey1AQUFOgi/W0SEJWK7A9l7KTWDXmsQSZ+60m0VMaOPV8e0hBxVw6Wb5go5SA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=36T7c1Di; arc=fail smtp.client-ip=40.107.237.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="36T7c1Di" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DEnP3vUUkPdWgKlPVy4Kh5hl/RZNgL111HgID9MMwe9JQJlkjNAVyNlGTlDPSh/kbBs8jVuG5hywvvpr8hXxZY8d6mC6qQbpcyQmG0++kxOLVA0vpl573uYUxkVkRYP4Kfj+U5el9szTUqNJQwfjSeG2c2tSyDBwsf4SpFeU74luviq5mFnHCvHlZqcAtdCwnNzKSmeie/lbj2JU3TS04qPC0OHvRMIxUeCBY34BeqMZwNV2Ww9jnU5ilixGoI29r9n1z8vARiZlXL/tfjW7OaaVtREjKbkwLorGeDLS44pVJ5Y4UsdHwp2H3JFtIVCXincqrn7ib46mAIzr+ooaRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9o3tOlnVNCRcTkaUjU1dbmZwtDSay+3FKXi89/ZsCrM=; b=oIew93UTmYNdX51uyJmazXhbieWd3mRfWEKlr/zrsk/ONX88byL4S9Z2wVLXITc++FZslQHOqUUFkBauDLr2/Ug9OwYPHSDsUrtZQfE7uPkAkzcrEAcQ32SMSb7OjuSeKJJ0vSFVR1XgRY+dB/8ckdQHTySEug0lbU+2S9sG+wPD8M/D/OjoFhXAGFkpYmF8E4BITUQIdu2CKAn+Ges1EKQZVNhTSBOEKGW4x69wcNmBpOl7L2oP10kHgsgmXbThoH0jRLFBDsJpSeM7IsJM3UOqrvq9r6U06k76EIDHA9SrQPVpTSMVErxJuYrLtrdMfKgDNlB/cOZEzfyEjyjH+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9o3tOlnVNCRcTkaUjU1dbmZwtDSay+3FKXi89/ZsCrM=; b=36T7c1DidgeCumDOzWnWAx09rLg7mEFvxKQbczpNZtvQtr9TcpO6Zs9JcE2YlHO/7rWA+hyEjYlZOPD1psraTiorQkBJzCRGnclbnJGxiVY3WCUcm1YXv+9AH0aXlBy6CvpNzp0Whjh1CgroPuc1BZvuxEkvTUwJsYePRdhjd6c= Received: from BYAPR01CA0031.prod.exchangelabs.com (2603:10b6:a02:80::44) by IA0PR12MB8747.namprd12.prod.outlook.com (2603:10b6:208:48b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Fri, 26 Jan 2024 08:08:52 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a02:80:cafe::e6) by BYAPR01CA0031.outlook.office365.com (2603:10b6:a02:80::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27 via Frontend Transport; Fri, 26 Jan 2024 08:08:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:08:52 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:48 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 3/7] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Date: Fri, 26 Jan 2024 16:08:06 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|IA0PR12MB8747:EE_ X-MS-Office365-Filtering-Correlation-Id: ef55b06a-48ae-4a8d-bd5a-08dc1e4608f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WxHRKTf+Ts56SZILMpEGu0fPOPdRe7yBAN/RqW5ncqDZ6nyfKz4Kcip26e3mS9oxIVmH71PX17exL8thpKvR8WTLMKkEpk/xg4a9VyaVnKNXUq+5MunhTGFrHtRe32/rLsVVcHXLBmDlHLRXBalCSW4XG1deB+7bOCdsH+R6Lz9h19hh2l1Zlwz5ayRJYgsiUtaXBSmcR6OflksSG6OenxHD/3zsuYgnfwqqb0xS0pV4fziT0wUUp4HFh3RuHJw+iKz/QUHQTuSxBKYReojDAR/dU9asuMWH03LIU8AOX1LUE5uXPaKMKV5K1pJ9hBGOzAoZ51QaDxk6vBf15RLLXMV07dvI6J0+bpYVjR4YvlDpkoyQP9KTWJMs5Igppcpb+xcvxurtnxd4Fzqa2e5ZAsBam5w0W/vrGtKdBoxkhbB+mDLLyV9jrptD05OAtzDVJ4fT0K5qEPiPhOmcrdecIM2crbPIm2GqW7M1kkXXDLu3znz5p/GUy02SRnbyZNsWtDZs9B/ocLRgAxSq+ORo2klDZ/Ae8US7P7pZTQqnv8uZP8VYZHnR0OVre1Hg7ig6mtQMPBv5x4pd87AYzPhSdEki7TGrknj8Oz1aO+XcwewT23DcD9Wk6x2JNe1AoG4nN5X3vZMOiPXowcKuYsECf9hlF5s9X/c3BO/tF0pQwEYq3EtVpp4lP0rqF6IZTiKlao/bJc1cyph0r7Y+AL2jzHARUgLY7D6jIAArjVy51jlyvOMSApyRdzx9xNGXhxZBQ8A9Ny4nV6F7D+hIVinA4yQDPeCt0aRPnZq9Ypd7y9A= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(376002)(396003)(136003)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(82310400011)(46966006)(36840700001)(40470700004)(70206006)(2906002)(44832011)(5660300002)(16526019)(26005)(356005)(81166007)(36860700001)(478600001)(966005)(36756003)(336012)(82740400003)(2616005)(86362001)(426003)(41300700001)(83380400001)(7696005)(6666004)(54906003)(4326008)(8676002)(8936002)(47076005)(316002)(6636002)(110136005)(70586007)(40480700001)(40460700003)(36900700001)(309714004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:08:52.0606 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef55b06a-48ae-4a8d-bd5a-08dc1e4608f6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8747 From: Perry Yuan With this new sysfs entry `cpb_boost`created, user can change CPU boost state dynamically under `active` and `passive` modes. And the highest perf and frequency will also be updated as the boost state changing. 0: check current boost state cat /sys/devices/system/cpu/amd_pstate/cpb_boost 1: disable CPU boost sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost" 2: enable CPU boost sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost" Link: https://bugzilla.kernel.org/show_bug.cgi?id=217931 Link: https://bugzilla.kernel.org/show_bug.cgi?id=217618 Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 97 ++++++++++++++++++++++++++++++++++++ 1 file changed, 97 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 0dc9124140d4..b37bea7440b9 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1036,6 +1036,101 @@ static ssize_t status_store(struct device *a, struct device_attribute *b, return ret < 0 ? ret : count; } +static int amd_cpu_boost_update(struct amd_cpudata *cpudata, u32 on) +{ + struct cpufreq_policy *policy = cpufreq_cpu_acquire(cpudata->cpu); + struct cppc_perf_ctrls perf_ctrls; + u32 highest_perf, nominal_perf; + int ret; + + if (!policy) + return -ENODATA; + + highest_perf = READ_ONCE(cpudata->highest_perf); + nominal_perf = READ_ONCE(cpudata->nominal_perf); + + if (boot_cpu_has(X86_FEATURE_CPPC)) { + u64 value = READ_ONCE(cpudata->cppc_req_cached); + + value &= ~GENMASK_ULL(7, 0); + value |= on ? highest_perf : nominal_perf; + WRITE_ONCE(cpudata->cppc_req_cached, value); + + wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); + + } else { + perf_ctrls.max_perf = on ? highest_perf : nominal_perf; + ret = cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1); + if (ret) { + pr_debug("failed to set energy perf value (%d)\n", ret); + return ret; + } + } + + if (on) + policy->cpuinfo.max_freq = cpudata->max_freq; + else + policy->cpuinfo.max_freq = cpudata->nominal_freq; + + policy->max = policy->cpuinfo.max_freq; + + if (cppc_state == AMD_PSTATE_PASSIVE) { + ret = freq_qos_update_request(&cpudata->req[1], + policy->cpuinfo.max_freq); + } + + cpufreq_cpu_release(policy); + + return ret; +} + +static ssize_t cpb_boost_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%u\n", global.cpb_boost); +} + +static ssize_t cpb_boost_store(struct device *dev, struct device_attribute *b, + const char *buf, size_t count) +{ + bool new_state; + ssize_t ret; + int cpu; + + mutex_lock(&amd_pstate_driver_lock); + if (!global.cpb_supported) { + pr_err("Boost mode is not supported by this processor or SBIOS\n"); + return -EINVAL; + } + + ret = kstrtobool(buf, &new_state); + if (ret) + return -EINVAL; + + global.cpb_boost = !!new_state; + + for_each_possible_cpu(cpu) { + + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); + struct amd_cpudata *cpudata = policy->driver_data; + + if (!cpudata) { + pr_err("cpudata is NULL\n"); + ret = -ENODATA; + cpufreq_cpu_put(policy); + goto err_exit; + } + + amd_cpu_boost_update(cpudata, global.cpb_boost); + refresh_frequency_limits(policy); + cpufreq_cpu_put(policy); + } + +err_exit: + mutex_unlock(&amd_pstate_driver_lock); + return ret < 0 ? ret : count; +} + cpufreq_freq_attr_ro(amd_pstate_max_freq); cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq); @@ -1043,6 +1138,7 @@ cpufreq_freq_attr_ro(amd_pstate_highest_perf); cpufreq_freq_attr_rw(energy_performance_preference); cpufreq_freq_attr_ro(energy_performance_available_preferences); static DEVICE_ATTR_RW(status); +static DEVICE_ATTR_RW(cpb_boost); static struct freq_attr *amd_pstate_attr[] = { &amd_pstate_max_freq, @@ -1062,6 +1158,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = { static struct attribute *pstate_global_attributes[] = { &dev_attr_status.attr, + &dev_attr_cpb_boost.attr, NULL }; From patchwork Fri Jan 26 08:08:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532179 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337F467A03; Fri, 26 Jan 2024 08:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256539; cv=fail; b=eh5k7bvM2R9bRlxHZmCYrbru0qshIbrfR+OCrP5nNZZAMITb8Hz1Mu3jq382rjiTszXFen4J5ee2A181p1S17rigs0hcNXoVQ64wuCgqsn1w73M2eMdSFhr7xRQMlSLpZUNIPJq0mJz5bAY9BoTuOusRDiwkOtd6eVNxYJ9EQCk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256539; c=relaxed/simple; bh=QaCVwhJ5K1bcZx9S/s8l5zkzYV25FnXmETFvgzxYmGw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R0ID3DMuTCVNUcUCdwDh8U0H6kW/bjvKmdbo+5fU/nMOAye1c4NccJp9r3NzI0bZHlmTIpKLfrJJ6tGa9rhT7v8UcyWjU9mDY3l8tIpOImd11lPFNeoUFuZ4grxnLrFz+QJXzramRPmxh6qofgJvk75qti7258rgnFduEo98a0w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Fbm82af9; arc=fail smtp.client-ip=40.107.223.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Fbm82af9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/MC9wI7aPhr9c6DDKW3haaqMKHWixfdUiRk3rZ3lknOQRzQ3fB0q/hYdsszR3B5TUJ5D9ErlHVjsXdCAR4A4IaAldedgsm/pzpdgYtAnymeGd06dCLlMIN+2rpJVMA3rL3XebLMFtYNbdpZhAei6N2NiX3mE8iMyMDuyZDTBGYtafLu4Wc2niMdrZvx++XCb/Un9GXmg874Llw5aG5ZSPvf7KRl1KZO4IbHbkLTbNhjW35V0GmKavZdnI6pWvoz0/hVzcLpbECqeVP2nxFDkt2N15WMjbWudaowZl4QzIB6CoT2nDGunPif2skcLTuDfez90Xk82ysf5dRUjis2sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jwVm9ByLssW2HF44IFbTvQDOaahTnjdTRl9oJcjYVIQ=; b=K4HZ3nep7wd8oWOpG2Y0QY0me4Ct4PNA7YoDqxfO0GZTLdsE09Dd8ttBZ+G4CQnUgYTcsv9dQ3WJLCBjz/dlv6CjoIyz7PI2v+fYjgb9YUAnDMOv9PwnFF20GL8QnVKjRhJ4S0xsfmQJxY+KqRMztMfgj27Wr2VRdyAn6JgT7b3eq/nQpDjzJBx8TFxge89wsmk54kFg4uwWaMH5lMSqwFObW1r/eUgtUCHW+TihYhvUzPdrMWrobHvaQAsYkuCmX71I2fL2gk6EGjlS4QWGKcuFtoZNUINi9QxKL9n4ot1YI8NFuVv/Y+dXQb7d94xb4Ts/tt9mb+mpnEYLvz3Wew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jwVm9ByLssW2HF44IFbTvQDOaahTnjdTRl9oJcjYVIQ=; b=Fbm82af9yMRb9+C+xlAycV5GHe7c9gNgHbwh6kNtuECjBfk+x72Q6MW8VLlhQ4GfKFE4WUFVOKnw3admgIg+3tC5xym7Bl/nVWt0guRBOLrccxt2EaHEy2OtACXmYPNyH+zyyWVDBKTuQEF6m7O+JIaI1inYHO4vZre1o7l9Zwo= Received: from SJ0PR13CA0147.namprd13.prod.outlook.com (2603:10b6:a03:2c6::32) by SA3PR12MB7976.namprd12.prod.outlook.com (2603:10b6:806:312::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 08:08:55 +0000 Received: from CO1PEPF000044EF.namprd05.prod.outlook.com (2603:10b6:a03:2c6:cafe::f9) by SJ0PR13CA0147.outlook.office365.com (2603:10b6:a03:2c6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.21 via Frontend Transport; Fri, 26 Jan 2024 08:08:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044EF.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:08:55 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:51 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 4/7] cpufreq: amd-pstate: fix max_perf calculation for amd_get_max_freq() Date: Fri, 26 Jan 2024 16:08:07 +0800 Message-ID: <675807d1888f77d7d0f3bc335b5bb3bd2c023670.1706255676.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EF:EE_|SA3PR12MB7976:EE_ X-MS-Office365-Filtering-Correlation-Id: edda5461-d99a-4ce9-f592-08dc1e460a78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EMgTtnblQzdTnrur6iwe7ZmxtTiUp75oJ4S4POMPoLDQ1fE7ev9Fbx6eMo6NJhKCeSlaGosNrDsTg1UALgiLVQsxmNBSjKnCl1FxjmGNqpeltC+WH6POZwi3+Sqzu00Kfmxyek1+P7+OurHRj8up4jVv99l3/QPvIldMXc9OnqxVWF/BBzAw/t5nQPnzjPEh2hXJm5cFI5zM81KrTSwH21ACOet4QxCiHabZbsmiNB5cn59asHg6rJsh/bhG2Rht8aVL7iM+eqvLUzRGTDuLPa1SMQYnj3YSESl/NkpzEsHh9QeyK2783j6iTCVN0PE1OXJMO8BzSQReKUtcq71/tyx878O4ONc2lmOxO8tOelMrkcnB7Wi7b0S60QCr7xc1oih5lve1fIzF8dnsfzAup7tUd4GvFMUKjeYEqDuDjdlrNSgtXmRzHYNpr7e75jhqYUYLQyvYcuQDg/Jfn2Y2N5uW2uEQKRe9LtMOQp7bV5Ae1pvzrgi4SpM7YouwTR5VqluPdglHgXHPjMO8yjA5QCHBL/iY04SUh+Un4RNEgIOOXH6j4JFoIoxHN0ji7DIfK9l+wenY4wary1EyQI4jQZNfe0MC7vDbCWqfmTBJInvh/tMjSLglkijR0B3HKMrCsrONOgQhwXNnU8eixETASkEdAqCvEyFOSyIXGiPcrDLJJiEQdp2OT87hjr2H6lwoicGeUswMNdyK9cswnR1VtXh+oRUFrZyzCEefN9zjm60C4JBoVTShAzochMd9IMzBqnCHxn8kuVC63a8xkz0mAg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(136003)(396003)(39860400002)(230922051799003)(451199024)(64100799003)(82310400011)(1800799012)(186009)(36840700001)(40470700004)(46966006)(40480700001)(40460700003)(6666004)(2616005)(7696005)(426003)(336012)(478600001)(16526019)(26005)(110136005)(70206006)(54906003)(70586007)(6636002)(316002)(8676002)(8936002)(83380400001)(47076005)(4326008)(86362001)(82740400003)(41300700001)(5660300002)(44832011)(36756003)(356005)(81166007)(4744005)(36860700001)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:08:55.0448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edda5461-d99a-4ce9-f592-08dc1e460a78 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7976 From: Perry Yuan When CPU core Precision Boost state changed, the max frequency will also need to be updated according to the current boost state, if boost is disabled now, the max perf will be limited to nominal perf values. otherwise the max frequency will be showed wrongly. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index b37bea7440b9..3286d72f375e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -599,6 +599,10 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata) nominal_perf = READ_ONCE(cpudata->nominal_perf); max_perf = READ_ONCE(cpudata->highest_perf); + /* when boost is off, the highest perf will be limited to nominal_perf */ + if (!global.cpb_boost) + max_perf = nominal_perf; + boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT, nominal_perf); From patchwork Fri Jan 26 08:08:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532180 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435E167E70; Fri, 26 Jan 2024 08:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256542; cv=fail; b=dJJbtrJazDmfY5Rd0dRU7l5rd/mjU5A9YdSPATeqDhsUUxMugBXa4OIOo/z1nxEgXoFMR3SD5dt607UhUcIlCKAYWwv69zCV9iVF9HfxfWDpyO5M626+4Ni4cmZF0J6gUKMfWZMVAagy529asVVnn4iXr142tgWqbl9nM9IVNXQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256542; c=relaxed/simple; bh=HHN68mUMnQ/ke/MzVYKq29cso4Wlt0lOHTl5DYePJ7M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S0h9AFU5WhVWL+8No93ePCFIgEbMrKKO64zlvQL6gCVM8NV8rDY4kUNcy7j+e8w3460IBue8Efw2lFrUgIx72tHmO1ezWH5WGSM0OJY3DU2TwG1Gu7HOHGiVQBB7dPYxOFYp4KqT999PzZpqmBAHXDvU1yC0NGmC8psl9l4wY4w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=WDE3u4e6; arc=fail smtp.client-ip=40.107.223.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="WDE3u4e6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkT8wVjNuz45YZ+kHf2AsNrryKT9gkQFBLttk9mCr5+CbVszD2FRhTHSN9fklE1joptUJeWa+7waPSKBnSqqJZA9BKaywPiLj6iyrE5L0IL0wlsJYwo35Z/nlv+3JqaugSPJHhKClA1DrczI5qWuSTML6Iw1bO7FT8eZp0vf1SQT96fKJjZx2dVg2NwvnEA8MGAx6tiC5wKGd8QEUUy5Pixd22n1ihHF3T2pAIRDJaXmbtklPJADyHZXIldLY9mY5165hziCQhUR8VAnwzF87Tox7xIRxAsmKuuZIgPqfuUf/lCm+BeCkZdElew4eMM+Nub8SDFuWMr0HejdgErvLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Sp20khTAJZurAfz42nx13ejcvn5tzFPqNDo5+iMW3o=; b=ehw1j5CLL+bxsg9ddQGMFmdDAFZ9w1LDKAoSh25KYEVSeg/byIx3/5DbIeUTzn2VljF41puPgXoSOyDMwfr1TU54KQE6exFWpCCA/3FDfmdfQxx6vXt1Xo4wRI858zePGqrvwjQ9emZxgFf6Dx832DUwNtN9wNxcCQFIru5MeUi+PY4XRNKg8dcqmCCQSkuQkMb6WCy4RiYcX4QprSF7aaa3HgQQflBtW9yCLPm/KYQmLiB7GzzRMlS97WvYnSiPFlrjiAgyUJYbsL2ACeeuTynJjETRkkos1zvVROtLXXzkPxYN+u5hzk+E3qiHsllHrAkjP3ZuW/k73K5FRbWEIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Sp20khTAJZurAfz42nx13ejcvn5tzFPqNDo5+iMW3o=; b=WDE3u4e6yM6ZOE5UMZEhBhV4YSqGutPDVea5otoX2TNP2qWHxvOlRkQD39+1RMU15q8oh3xbME7tMKBOo6Chjal+6DuslPLaVjSjZ8z9si2zzJDrghV7WJPz3IcCRHNHkKaHvFfTV56CkmzYfW081eX87rK7WQC1ADMudp3JEsw= Received: from BYAPR01CA0033.prod.exchangelabs.com (2603:10b6:a02:80::46) by CY8PR12MB7489.namprd12.prod.outlook.com (2603:10b6:930:90::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 08:08:58 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a02:80:cafe::11) by BYAPR01CA0033.outlook.office365.com (2603:10b6:a02:80::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27 via Frontend Transport; Fri, 26 Jan 2024 08:08:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:08:58 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:54 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 5/7] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Date: Fri, 26 Jan 2024 16:08:08 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|CY8PR12MB7489:EE_ X-MS-Office365-Filtering-Correlation-Id: b4297f0a-6abb-4ae5-cf16-08dc1e460c74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /WqGENfOFwcI1+4Sc+IMo58DIWa9HjicTz8vZEnvv3bIyYbwwAKxwaqGznvmzHEW3iW/OQfXC6YzOEuGvZ3Ebe/Ox1ALVeleQ4ejvgAnNlokIYyeVSrp/X0ZZL1PhOSz2qDW1XZzROPoKKOgAk4E20UbPMPt8n55Ql9Rm9kX+lG8fHIYqzstz56eSxLOql9k+gIzr6CX5dB2Om1BTTUPudCfC51WVuMZabmigB8CYNleC1Tn2XTV72kwayLoFuUaKuFEdNsDK2AkcSar4nG47KZoN9/jJpGycYnPclGZvxFw1dys2uUJm37YMNk3IDsukr3DBqiiJOGlPt2ve3vTfq+Ubx4YJnBJnQGZvWzrcrvHM724eNNgDqP616xxH06FmULgSmonwGhwvOjE6Ug9QpZ+HjAjAQRRMo1JLMXsSARfZwB9fhkGgvCtO2jARMMa+UsRmOKUjwi7/Xxryl7NI6fMYXRnBYUNNkMSogIuiqU53uXchG7wWyRygk/qB+tXKA8ndanY1XqGgjCfUjPpQSRCEO+NwouBOD3VG9vT2o5/Fd7wjsky8+8haY2zPA+dDDaNLZZ8qyaBu5hwi9Y7iqUjdn1StSRDHN0CJYdHxy0V+w5VLcY4oYfMnRZ4YJT6PgPYLzKqX7UtepSl1tuMA9GSFkVqhmQrcrAIkF+Zq1Z00lVD7cr7G5scuNHPjQFXsoL+1uFKlANKQO7HReS3+2SOWFEb9OdgsJhO8kk6edJHL+N8EkY9hx2mU6/J3uVQmLZ7mQQ/tMaIGG0ZI0pnJg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(396003)(136003)(346002)(376002)(39860400002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(46966006)(40470700004)(36840700001)(5660300002)(36860700001)(40460700003)(40480700001)(81166007)(356005)(2906002)(86362001)(110136005)(70586007)(70206006)(47076005)(44832011)(82740400003)(54906003)(36756003)(41300700001)(83380400001)(6636002)(426003)(8936002)(336012)(316002)(4326008)(8676002)(478600001)(26005)(16526019)(2616005)(7696005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:08:58.3574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4297f0a-6abb-4ae5-cf16-08dc1e460c74 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7489 From: Perry Yuan Select the min perf to fix the highest perf value while update pstate CPPC request MSR register, here we need to limit the max perf value when CPU boost is disabled in case of that highest perf value in the MSR will be reset to original highest perf value which cause the BOOST control failed. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 3286d72f375e..5cbbc2999d9a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -443,6 +443,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, u32 max_perf, bool fast_switch, int gov_flags) { u64 prev = READ_ONCE(cpudata->cppc_req_cached); + u64 nominal_perf = READ_ONCE(cpudata->nominal_perf); u64 value = prev; des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf); @@ -458,6 +459,10 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, value &= ~AMD_CPPC_DES_PERF(~0L); value |= AMD_CPPC_DES_PERF(des_perf); + /* limit the max perf when core performance boost feature is disabled */ + if (!global.cpb_boost) + max_perf = min_t(unsigned long, nominal_perf, max_perf); + value &= ~AMD_CPPC_MAX_PERF(~0L); value |= AMD_CPPC_MAX_PERF(max_perf); From patchwork Fri Jan 26 08:08:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532181 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9B06A011; Fri, 26 Jan 2024 08:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256548; cv=fail; b=KK91O6/sUHVb9bwr0HSuSK85trSr4XzVSWUvBkJYeSYbqqP/QQ7oiJXshaw4FgwRlWQGOAwnaihiPVE+1X1ZKUuRLW9E11AFyUIF9rE2jLAB2ZGBbawb0PU2cM7d3MGSkYdGxwp8M0thGyRkjRMG49+EjxkmXcPrpDzkSQISQB0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256548; c=relaxed/simple; bh=M4/qwvxU6Y+sZcnEZ0MOa/RCcaIUtKNnuvnxPqz/xQo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JXwQv6bp2FiCaqjVdB0gQBZzsi66aryrGzZGLudM7Kipc6rrXy9XK0RUd+s5fL7yztzSXe011w0gci9OaN28WP1mph+03y4Ne67vwg8MI6mC9ROBYJtIh6BCOq8wXSD0goeIFUsq5bA/qU+o67CvU1AFF0+FJ9e2WmYl62mbNpo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Oe1lhNwj; arc=fail smtp.client-ip=40.107.243.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Oe1lhNwj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZSMsXr/UesJeUWuDTZPJsR0yiFg3jUebIEpo26NBgYf4f97UN4oQZ5jIrTqXUcaglMAXlk6CZYWT0fcDxhyF0TB/Q0We98uQwK3+h50xLwX6uuwBU0eBCbIwHGJ8p+OWPr54Sj8kDISPTPkhxXSj4poJ4nm5p7qZ93FFkS1ZfeX/50GB5WA5uAC6ADQjTv1jdSBdVPL/NYPeBzxUYwBR4gaBBEKYdI4pMLWC8pEykRhtPyO4dnNxX9CwfbKOmzfzeikYAjSYJrVfJYdO4KdrTu+N8dah6OW+e6YsUL2dwb5bqWM+1ZFoQFXFFcCcEcjcH8gYExwjcWkxVW2ew1tpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tSVXH/Glb4osiEi1PuWUEzoJaQnYF588omniEI8iyvk=; b=g5WOEq3/tERSGKmdyqtKru0dVoMmktcsUq21HawoOkUVh29D2sd0XlWXoeiI37kKndJrUARmWEQee31jfi4cN4sI8Ggk6zkAmZsrmFGyoJ9DaptzZq3pN+ihk0yDoAzzUnjPoXT8+MWYKT7zUiBXpTxOMeb7oLMjV0HIGxcDM05nQb9Y2WGdglDNQWyt7dn9BQja4ow/otMv9yrrJO+/vH1SS6MLeo0m75czxCHvH7qmCmV42QXTvEdSVGykTYBl4ixT3WL5t+XnkgmO9PcEXSAm8/1OBOyqN36vSYk5EaiEsrlQ7M7mqdL5KD58PBXpWfW6gdsldioX6DzjD8FeAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tSVXH/Glb4osiEi1PuWUEzoJaQnYF588omniEI8iyvk=; b=Oe1lhNwjxutrqTSYn9Z361bUERNNuIhN9kNrHZubzQl68I6UzA5QLLD0AjG5P1djx7/qTfZJxbOuFIHVBBdprpeC63QnSlH9tz9qdX4gFb/Z/pP36ye7lYia0PU1U0lkiXP3F3oIjBEkeQr2b/0uf89W7tFeZGNOUNJTrGkP11U= Received: from SJ0PR13CA0135.namprd13.prod.outlook.com (2603:10b6:a03:2c6::20) by DM6PR12MB4172.namprd12.prod.outlook.com (2603:10b6:5:212::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 08:09:04 +0000 Received: from CO1PEPF000044F2.namprd05.prod.outlook.com (2603:10b6:a03:2c6:cafe::f0) by SJ0PR13CA0135.outlook.office365.com (2603:10b6:a03:2c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.10 via Frontend Transport; Fri, 26 Jan 2024 08:09:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F2.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:09:03 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:08:58 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 6/7] cpufreq:amd-pstate: add suspend and resume callback for passive mode Date: Fri, 26 Jan 2024 16:08:09 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F2:EE_|DM6PR12MB4172:EE_ X-MS-Office365-Filtering-Correlation-Id: c69c41a8-2d83-4a7c-81ef-08dc1e460fc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1g+umRVw36QsDv9ltFeoGF2780uBo04cbuhvNlZ/3Kdvrnd0IeecqN5IH03ylMvkJOruZU8kOUUSR7OEaAkbjllCBw7aXlMoKJASH9Sl4KQJ8EaMdda4w6Rq7xcrX3PL7lybMVOr4rwqKp+ngabHpNLruF+ncsjCeYV5ZWLaBpm+fCSbr+h1lmpRun6rVE6Up1NMzW6qVA8j75IuwHq0Z7YaHXupKQePa4QIX5q4XFVGH0++5CIkCLEEJKJiXioyxMlgYHWiSqrYQM0/zOare0WhxcJcedGAC/N3whmA6Oep1b3AHrzvfx8uPl/Ch3borghUG3InX1DUTER4EDywEzhUiYbc0hU7loMJiT8radiXCoS534if7YwqcP7SB3R/fcrHGCz6aKwWnUGaMA8qjOi9j5ba9jgPgHeN1pVEw8XV9hqKgkLt8LAMjGixJwtt8/3D95jMoo5dNX3idCQt6QTWOUUYfknw8BmKksBhicONpIiLTALAK4NJrj7Oy2OUWyJlHmUZeJ0adBdAksoZnc2K47BfPpvDnp2fEvfR6ZAt1ggarepgA2sxXsAG4PqMGg/N/WwKD6fc4ftN3LW1c48XF6AJdrkklgwu50NZYcVEZZY3U0hs9jXxqd0stNrSkBAvw2zvF8mJ40eTUxZh6/A5jp6QgHc/ILlwflbnlyFD/AAc6pKqzjwOwYFN2KtkVlaQ16tfTmszwoAzaUZHOrJgH67GtD+k56DATJY2FMC7WMwGkZF94i2x7qn677huvQULCQeAA+Gh5yYwBF+TkQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(39860400002)(376002)(346002)(396003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(82310400011)(36840700001)(46966006)(40470700004)(41300700001)(26005)(16526019)(2616005)(6666004)(7696005)(83380400001)(426003)(336012)(8676002)(8936002)(4326008)(5660300002)(44832011)(478600001)(6636002)(316002)(54906003)(86362001)(70206006)(70586007)(110136005)(356005)(36860700001)(82740400003)(81166007)(47076005)(40480700001)(40460700003)(15650500001)(2906002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:09:03.9245 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c69c41a8-2d83-4a7c-81ef-08dc1e460fc1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4172 From: Perry Yuan Add suspend and resume support for `passive` mode driver which can save the previous CPU Pstate values and restore them while resuming, on some old platforms, the highest perf needs to be restored from driver side, otherwise the highest frequency could be changed during suspend. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 48 ++++++++++++++++++++++++++++++++---- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 5cbbc2999d9a..bba7640d46e0 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -785,23 +785,61 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) static int amd_pstate_cpu_resume(struct cpufreq_policy *policy) { + struct cppc_perf_ctrls perf_ctrls; + struct amd_cpudata *cpudata = policy->driver_data; + u64 value, max_perf; int ret; - ret = amd_pstate_enable(true); - if (ret) - pr_err("failed to enable amd-pstate during resume, return %d\n", ret); + if (cpudata->suspended) { + mutex_lock(&amd_pstate_driver_lock); - return ret; + ret = amd_pstate_enable(true); + if (ret) { + pr_err("failed to enable amd-pstate during resume, return %d\n", ret); + mutex_unlock(&amd_pstate_driver_lock); + return ret; + } + + value = READ_ONCE(cpudata->cppc_req_cached); + max_perf = READ_ONCE(cpudata->highest_perf); + + if (boot_cpu_has(X86_FEATURE_CPPC)) { + wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); + } else { + perf_ctrls.max_perf = max_perf; + cppc_set_perf(cpudata->cpu, &perf_ctrls); + } + + cpudata->suspended = false; + mutex_unlock(&amd_pstate_driver_lock); + } + + return 0; } static int amd_pstate_cpu_suspend(struct cpufreq_policy *policy) { + struct amd_cpudata *cpudata = policy->driver_data; int ret; + /* avoid suspending when EPP is not enabled */ + if (cppc_state != AMD_PSTATE_PASSIVE) + return 0; + + mutex_lock(&amd_pstate_driver_lock); + + /* set this flag to avoid calling core offline function + * when system is suspending, use this flag to skip offline function + * called + */ + cpudata->suspended = true; + ret = amd_pstate_enable(false); if (ret) pr_err("failed to disable amd-pstate during suspend, return %d\n", ret); + mutex_unlock(&amd_pstate_driver_lock); + return ret; } @@ -1460,7 +1498,7 @@ static int amd_pstate_epp_suspend(struct cpufreq_policy *policy) if (cppc_state != AMD_PSTATE_ACTIVE) return 0; - /* set this flag to avoid setting core offline*/ + /* set this flag to avoid setting core offline */ cpudata->suspended = true; /* disable CPPC in lowlevel firmware */ From patchwork Fri Jan 26 08:08:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13532182 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F396A6A024; Fri, 26 Jan 2024 08:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256551; cv=fail; b=spYcFKwkdAD35+LSlGlYOCUjbAKYH4PtmhcGCBZABsOLgg6puAo3+d2OUqfyCyi72sdhZQnyJIeB8nukYY4BvVsnH/Sjg0mmct5LZuHcE0O0VKWFvazWaeTvVpm7hG2Hi0YnSrMIWYjMZCDjj4BAegO5zDN3vmd6u1oNIwEYTrQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706256551; c=relaxed/simple; bh=Rca+pkGTOn1V8qBOTuTa2KS/EBSLBggibKR/oeICyDI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hInWy166YIWXzXGXM/fYjc5KRqr4elPGCbgFFeR/BkuXsWSjLjWSXRF6ILAsU19tObPhj3jzs7nx++2hTGUahKxpvVLDbgrTideD1Ecm5gWeHN8onI+WcyDPcJGQDZy/pCOdlzBjl9JlWDGLl6xux7YUDzOf3hYBC0SxvF/+ivQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=PjqguNqE; arc=fail smtp.client-ip=40.107.237.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="PjqguNqE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNxag8Ou7dztMbTVSuTmivMR/7UG8OZPWcTARx4Ut47qO+ZQlyi+yN4JC78nNAVbOA8G5za7FKB1+xLfiqHshQ7O37+o9XmElZzkjvtKegpYcjyQxOqtuFURIEfezRSeOCiI4PQ3P0uutvoBQtyQYbl3ECHMIGOrqlF6T9wTrShjRle+3sAjd6EtLgutHnnTP615wIEcuEYFxME4pFKFl6M7xlV4wLP/iP+jeHabmIXvmoMKMpNUUIxFQO5dFVm1im4ZpqUgwA7l5Z6loR1DCZkJTFnd8rFfFZ/f+LZYwJozXWnfq1uWkPDtKWXeRinxfY4LEwyFIP7HdQPpm59Vng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pW9y79Sp5ovfASU9Wv/i0zw9lUzkOy2sk54Ik1mgXx4=; b=f2/GgHkYCYz2g9+t8GBKQ9GwpAVth77MtO3vYqAAdtZ98zBSppU6vmfxx8uWAJ+0FqP0bpq54CJbHAlZ2DskYTJd+b+G6e8tT8pOugfkxc2yNC17ZoOUFSTmHXRe89505q3nzlLmXLd55tRdwxXASUPEUkYOPyf1imPWjDhT7DEckuvmPROh+NLjrpAETYQEdVWT0iVhsbEgsDJlz0g4h0bS5MUFT+SuQ6PKle84/dI6eQqmpSBsKY/YLwbjv+3FVpKiocFsnwyoDGg92DutkXzEa24aBcIxMyhrQV0pZ56l/iJJtHR84vHE8M5wsVBHcZLnkkTe9j1xyakD+B1YFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pW9y79Sp5ovfASU9Wv/i0zw9lUzkOy2sk54Ik1mgXx4=; b=PjqguNqEtrpAmHSR9RjlXUPLVqOdC7uZzNnChBwR1SHaO/UqtFrBbTsq0QC/RKPBnzd6LBumUVsSTreIJl6EXB/H6GdcOr0ZvO+6p5mgIDJmNypBH2TFMTeRxoj+vY1Lg7q/0n4yRb/6sn9CwmM+f9FKalMbXTFg/tMpWalb/ew= Received: from SJ0PR13CA0142.namprd13.prod.outlook.com (2603:10b6:a03:2c6::27) by DM3PR12MB9391.namprd12.prod.outlook.com (2603:10b6:0:3d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Fri, 26 Jan 2024 08:09:05 +0000 Received: from CO1PEPF000044F2.namprd05.prod.outlook.com (2603:10b6:a03:2c6:cafe::46) by SJ0PR13CA0142.outlook.office365.com (2603:10b6:a03:2c6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.21 via Frontend Transport; Fri, 26 Jan 2024 08:09:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F2.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 08:09:05 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 02:09:01 -0600 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH 7/7] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Date: Fri, 26 Jan 2024 16:08:10 +0800 Message-ID: <1be9c97cafb1406a607184ea48dcdae883dc4cd0.1706255676.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F2:EE_|DM3PR12MB9391:EE_ X-MS-Office365-Filtering-Correlation-Id: adc8cd7d-251d-4dc8-04fd-08dc1e461066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ox3Dx9HW05YyWO/SQhki4+sYjq7r2yUYypGA9BZ3sNe15iJzGmopSGMIRYxIbF16i/u+p3N77PB5WAOcg2UyMjgAdfGKoqdWbEIttS0kn/YNZxmnambHI9gsWOJFQ7mQr6XVR5udHQjwGN6U3DU5ZM67yRkI5o7W9ia4g9IujYY1VoHoLUwxzxm0Q7JMHcEdUxe+aoJNqoOEpSvmXAVk5VTuTNN6UOx/BcmYhnTAUdojwD/VUfw6N4aHbM+URDa3pBmYncotBcnvshYbXmwO8gTw3n+WhFNzL3kBSNBZraymBm+gX1XnpuT75XHJ7+rAOlxRZe9TUoUtvFYpzG/Yj8fIPn34OTXC4qdkmJMqqkGb+UZpV5elGdFyp/3MYFa73pDEn4cd4D0JKgQfqVNZJYq727TUXofxgC5sqzeamXRS9vEmNr4+gI0a+xgCmHc8Q/V6BzJm9KvUY8nPOFq0iCZUg9c0oDN6rEip3+IM5XZoUSKAvN9AFNNYPOYYHNY0ZPiPF7YUyoFCQ3umWtQS+fnX087n8WABjOLKNpLfn9sBZFLRY0Bga0P9bNY7NBm3eLrn5HUuQoHZV4Yke4DI0Rv4yVEqQIX6SKW4aDYqWq8f5ofbvwodsrxrhNOdXWkib54jII9SbqYEx/FtYxO5dJEnwi61/ahq9hieHXqd7PD6ycf/bNfUHXPG3+ZthP8aEMjl6ZcvBTysGcXqYYeVwkMOWH9JjQ8Bz+e2bqF4FRxcXc0h4EYTpJhN3dZ77feGpK1IDRPXhJPo2te/nyFBjA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(39860400002)(136003)(396003)(346002)(230922051799003)(186009)(1800799012)(64100799003)(82310400011)(451199024)(46966006)(40470700004)(36840700001)(83380400001)(41300700001)(47076005)(426003)(2616005)(16526019)(26005)(336012)(81166007)(36860700001)(4326008)(5660300002)(44832011)(8676002)(8936002)(478600001)(6666004)(2906002)(7696005)(54906003)(70206006)(316002)(70586007)(6636002)(110136005)(82740400003)(356005)(86362001)(36756003)(40480700001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 08:09:05.0026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: adc8cd7d-251d-4dc8-04fd-08dc1e461066 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9391 From: Perry Yuan Introduce AMD CPU frequency boosting control sysfs entry which userd for switching boost on and boost off. If core performance boost is disabled while a core is in a boosted P-state, the core automatically transitions to the highest performance non-boosted P-state The highest perf and frequency will be limited by the setting value. Signed-off-by: Perry Yuan --- Documentation/admin-guide/pm/amd-pstate.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 1cf40f69278c..d72dc407c4db 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -385,6 +385,17 @@ control its functionality at the system level. They are located in the to the operation mode represented by that string - or to be unregistered in the "disable" case. +``cpb_boost`` + Specifies whether core performance boost is requested to be enabled or disabled + If core performance boost is disabled while a core is in a boosted P-state, the + core automatically transitions to the highest performance non-boosted P-state. + AMD Core Performance Boost(CPB) is controlled by this new attribute file which + allow user to change all cores frequency boosting state. It supports both + ``active mode`` and ``passive mode`` control with below value write to it. + + "0" Disable Core performance Boosting + "1" Enable Core performance Boosting + ``cpupower`` tool support for ``amd-pstate`` ===============================================