From patchwork Sun Jan 28 20:10:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534631 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE713219F; Sun, 28 Jan 2024 20:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472694; cv=none; b=qQ9wGpFbUsAT3jMwf801TeIZDCnfFwkzTWd76ajRPgPGkPPbjrDkiz/Cc5xrUNnWb7IwicTDuKsGu9L1jyYApq97coJATWsndpRqK62SjNGKmtEnJ4+epooSBQmirq3zE03ihySMtCjJ4P/KZShYvfHo1Lu/yTgn+SBHX3U+wW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472694; c=relaxed/simple; bh=NdM5m5BreW0faIZS4cTcvHWKX6LbtdeWVP2uCpexkPc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LE35Ui3IsUenkGoJqjtk5Z46BAR0Nbe08LfgESJRHavhNQMIOi0XmaK/ztas+jCdGKEgP0NpFtVnn2Ls0gB8+RHr3OMsFghBx2ZywAC2x/Sq4LGQwdOz6oyvoRagoZq9I+l/qsHco08rG3babEiAQalWcCg4Kts70X+sgHH5AMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=MZpOhqET; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="MZpOhqET" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472678; x=1707077478; i=wahrenst@gmx.net; bh=NdM5m5BreW0faIZS4cTcvHWKX6LbtdeWVP2uCpexkPc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=MZpOhqET4EeKHDvfCXZLbDdMj8wtDxw2G6yZ5LZiZNLXOBBEd+cNbz7QIiC4JK7i E+DVJ8MqfHiCwKHTcNx+pOuY17J/P9c69wRDH4nOUK6LnvTJ5BlcSUTLpoXNaRj60 YyJOkqcCiCWBlEUL/oQWE+YJYpAKMNnw6/c3dAuqMQvBzgnkKe6Q7rXT9Xg6wPeCl pagqcQX6CXAflS/LNIiFMpIpcX3F4NwqgcHIxSVruSc28NjHSTLsPnzFL2rpRJkK9 5/qYw9DEqahXma1sC+wGJ9zEQy5MpNDBoLaPJx4/otc6z/6BAvkmSZXTsImyzqnZ1 tpQB4VXBvRg5wNq0zw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mg6Zq-1qqzKi36NC-00hiIe; Sun, 28 Jan 2024 21:11:18 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V4 01/15 net-next] qca_spi: Add check for kthread_stop Date: Sun, 28 Jan 2024 21:10:45 +0100 Message-Id: <20240128201059.6259-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:AfxYoHf5IGBDGU2Xrvj5CO4LhdvOjncPUGYKr98mfwYamLDzI+5 0B4phhl/JO2X3U0/6wMUDbZ/2wBN2UR9m+Xyn2R6twnCA7rnkO7wzMDCWySEceDTF1DmHQm hCO55vd6zFtK0QHHTD2DOP3Bgh/bpj6MtqOpTQoMjLyemR+OPHwu2fOLIM21QQYWekaReFb KfMoxxFvFB+9vI5AS3nOw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QNuBhD05qr0=;kRf4KuQNIURDBXsBf1vEyWebEVO vnLFEtdvfZEbiFNTgMCzW3FJUFEcRV9jvZhu+SDxuzlbuy7iajUofiI4hKwSMYVhoXpQzYMOY HD41X8PLnl0MKBToHjPce7jmtcbDSMsIZ/6OqHYiIWqtQIQzSFMI6VnCYrs6N0CZ8VSCw12Lp oPv/KMelu8VGCbUA249EjH9gacuPqv7cdkiww9/YiCtlF0nA/he6KFSyeQ9T14Ybt6PLfWcGR vknbEjHIXbMpjQxZ5IJlfdubIOZDGcBkzgUR8NH6bmzjAiDaE24ouUNL5tXAGwILvrcWn/1af wzTFgvMhElfjtfl+s7TpvHjHba2IdMu2hosiYdffo2dsWiHX11XFhbynKCqV8tXO4wrlSHtPO OyFWCANck+alfz7e9fdM2iTRpRcvM3vCezRRjCedS7pX1X4Cv4zOOe7jCxny62jk2QO7O0OSN sAv1UT8mCJZuczaOi8nclDvJEKBnpn4MnRMkXP4ey8CMm2wNgaxphDzrsDQIEdiDifaQkYK0f cU+oMeknw53te3mPexYNP/lnFAJ2GLzvnIWREPA6oIa8s6AKuT+Z3VHy6wHfc+nd1kSzYh/iL pdn8I1uzNOTFi4r0epPGt9GzP4N/mSCuavwgDGjjfyJkj1VSTNJUll85VdimGNqOAUr4oJ6Yi Gpuq5snTjPh47u32bMVhJZbVNN3YqWF+q8XKPuCy1+IWfN2OqXO9mbtWyJDzWIoij0IrjPVrc 5MtLFy0+diAtHIR24EouQT6UKZTL+Y2F1LkZS9NYrjusbfhRWDHUiZsR6hBGqKZOMAnkGzri1 cG1/iMQzd7Nzo/yX/dmdoFzYZDWHFS11yC5jdPW2brUKEJLjawG0p0BqZ2VO4BxehtDTOgW2M oufYvLDHWaFQYotvJpdhA8ahr96xREDiziIusRCGzrbudb1kGY0ILnj31qfp224SGCdcZ4vkT eoRYMw== X-Patchwork-Delegate: kuba@kernel.org We better not rely on that spi_thread points to a running thread. So add an check for this. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 5f3c11fb3fa2..77bab8bf5203 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -730,8 +730,10 @@ qcaspi_netdev_close(struct net_device *dev) qcaspi_write_register(qca, SPI_REG_INTR_ENABLE, 0, wr_verify); free_irq(qca->spi_dev->irq, qca); - kthread_stop(qca->spi_thread); - qca->spi_thread = NULL; + if (qca->spi_thread) { + kthread_stop(qca->spi_thread); + qca->spi_thread = NULL; + } qcaspi_flush_tx_ring(qca); return 0; From patchwork Sun Jan 28 20:10:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534632 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931A433CFB; Sun, 28 Jan 2024 20:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472695; cv=none; b=M52Vncg9xWS4rr4Jxn30icz3IwtakOnKmyjheC3+cGdqC/+OSjMLuZOe1V7FXuxYJnHlyoqcJ5rkhu2N6flYV78CRSwuVxEUn5Fg6AoZfSaO4qNapTOXOmQCf33zH4TVoOV9Q9+TDIAZz49cYzKRoLhWryD8Ji7HnHZSXIYzm3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472695; c=relaxed/simple; bh=/a3XjCwkev4UaYRviAJl/ZXYOyQ9EIrLw/7tcHWkLhU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qUIzD6w3XHnNyOaYvjlQdtklJ/8dZ947B/7rzKJWLoGgrtZsSXE22YePyn3K21s/tkB6M+SR2gxBZFuDPtcufg0OLN+iRGFmSViAdsBdCXgpF2JGMVZ6xuz2bSZBMNzi4fy1yMJaJvPHSjKOml37Lp08ay9PuM0guhSmaqOlZV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=otzzt1QX; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="otzzt1QX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472679; x=1707077479; i=wahrenst@gmx.net; bh=/a3XjCwkev4UaYRviAJl/ZXYOyQ9EIrLw/7tcHWkLhU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=otzzt1QXppw4obX+GPdGZOxii8Z06Ewhus1r+tAKsXsNVZI+YbF3nglLyJNw0sEc L6lP24L+lXB25FKKkQoPULoShQSiQPn50bpvktfw5/CyA7F72gZtLIbMROh0IvJNR B9WofLgHBen6tX43YgC0jerpWJil1m5C7XSYiAz9B8hhHiKr+17E8WW3wh1WYbb5u twPEyVRpaEKnjcRh5I3aKRDHVSjyDTnL2y4EsaE/BhnyIXoxLQXzHyKMNo8b+hutO c/AhaG4A2Y6eb7+96sJeKm1tKk4RqyAgKItmg2H/e2saBglO+0q+85E44sdLo+u5s G3zad8iM8KuS9JoD5g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1qzXcc0i5B-014Qt9; Sun, 28 Jan 2024 21:11:19 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V4 02/15 net-next] qca_spi: Improve SPI thread creation Date: Sun, 28 Jan 2024 21:10:46 +0100 Message-Id: <20240128201059.6259-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:aSIglkDEsq3lvXRURyTBI5gPLVY4vpipUM2fSsP0gU2Uz2gH2rB 1QEncOnqSzk4xWAl1JueiJ09GmqadnIBEAKZuxMOnLj/8G2sphgbPHJREFxkRrhbmFb5y+X CDRpswJNhoV3znHHrSRZPGUnjQa2Xe97OGn6Q+OXAPD54sY7prCxeRhyoeHYt1AWYY6CxtU nDgCVAS6OZp9fH/Pq4jUA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rKY1ZPzsqiU=;x6UvKh/oCtolnBl8IPtzKpMzoJu 0XtzR/eXHTLA7bk/ONfy1zL84PIvnpg7bSR3kxHIohnoXh5joLpx/hBvR0TqyLAfVyVW28/4A J/F/UWZIwvwuXypZVXUip+wyly/2ZQupVjcjq1k7ULjUbM4w6rzsHHKlid72yEUfN13ZfPsif c+p2wY3z6Dat2Fa8xUmexn+Jbrc6133UcLPYTM4AVZzJOfoLGfceNZwwRRy49F1xSDJjB5Kny m835jvDSf5sPl7sJCbYrvjfFiMOv3h1p8NWwEwm7ofIze/wlAvPS4T4kFXhwuWBqHQLa5p5PI 6bO7xL7svKzVCbIShMAuvM2eymn4OEfz1/ts0ghgpj7AvJhNE7c7jim0a47tUr9mZwUgkHQ46 kAotx6zQLzqaMsAf5CjcRK3j7ecLWOxSOg9uuy07rp8V1Y7/752ptKLwq13viZbbNY++zgryL 3Isxlu24//mR2UWN0V12S5+WtkI4T7QYiKwfKaMBxQXpD9xrZPpRDpYM9/FXhjGVWWQXmCXHO lDEJ2/nVU8teTSKKNscKc7ROgTPvWCgmNnGztQIVJHI7FnjGAZ4QtqIz4jTt5/3eBJvGGCSZ+ +0vx5Q2X4mLrJQh0NX/JhMr1Lt/650kOY6BV2l58GovHW4TD3xEr+W8MfnthagavvO94W5hXN ihAYbgR5IxZkIA4ZuplhkD+ea4fGLfoVOj8kLG4EyBxfQBSLanUQx7Ct8ntPQdVM/f6wT3T8e HzCOEBe/AIrS8z9AD+Qlz6dTQYpVugqO8vTrrWbWC0smMCQqTxVzZ6NxfyNDQahtBcDjmBxXx TL69+J61mNhld67uurJi8qjtTeT9A19qnoOZX0PyNjHP6EV0bjYzybfJ7+Y1DolbmAL/xMCrY NeWawaLU5X0iPrlha7xxU8cvaxllGkaj9GH075BNv3jPCP4yYgEK33p1Gwh4889hzOzot9dTN ojYiHA== X-Patchwork-Delegate: kuba@kernel.org Directly storing the result of kthread_run within the private driver data makes it harder to identify if the pointer has a running thread or not. So better use a local variable for the result check and we don't have to care about error pointer in the rest of the code. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 77bab8bf5203..fe50c2dd7cc8 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -687,6 +687,7 @@ static int qcaspi_netdev_open(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); + struct task_struct *thread; int ret = 0; if (!qca) @@ -697,15 +698,17 @@ qcaspi_netdev_open(struct net_device *dev) qca->sync = QCASPI_SYNC_UNKNOWN; qcafrm_fsm_init_spi(&qca->frm_handle); - qca->spi_thread = kthread_run((void *)qcaspi_spi_thread, - qca, "%s", dev->name); + thread = kthread_run((void *)qcaspi_spi_thread, + qca, "%s", dev->name); - if (IS_ERR(qca->spi_thread)) { + if (IS_ERR(thread)) { netdev_err(dev, "%s: unable to start kernel thread.\n", QCASPI_DRV_NAME); - return PTR_ERR(qca->spi_thread); + return PTR_ERR(thread); } + qca->spi_thread = thread; + ret = request_irq(qca->spi_dev->irq, qcaspi_intr_handler, 0, dev->name, qca); if (ret) { From patchwork Sun Jan 28 20:10:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534636 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2340E4205B; Sun, 28 Jan 2024 20:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; cv=none; b=ofVjrUgRPGfrUm3xTG8s8UapWH0XoBip0bM1/BbOayQdvZSvQD44aIPZIgrH6hN/DDhdVYmChUCQdOnZojYG6VF57pZjSG9bcojbtWcyPZBHQMiIUXcns4AVvFfD7QlLFSOFkY1U/BAceUqFGkjEqsWZX2s1kgyJM/TNBX7uz3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; c=relaxed/simple; bh=EvWVaRec1ycNuQtUFFeYTjYmPaMgYbG3dLiPYQu5/tA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZZJo+vtBm+q73UXHIjQTQEjwcUY4IKUnWVtPW+WPSSEczGThFzqiPuYAsXXS3kpVe+1ARVdqUmcE60pFqHTgu9PgxEqdJqScDdvWTi+W9vr+2pBPgFcajQc1pRQpO4BteQBmshr7mzaZpPA3GOrS9VqRuovWcBy7DIMc4r/W5nA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=UrR3EttZ; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="UrR3EttZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472680; x=1707077480; i=wahrenst@gmx.net; bh=EvWVaRec1ycNuQtUFFeYTjYmPaMgYbG3dLiPYQu5/tA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=UrR3EttZj3Z2wsFOp415PThIDGs8xyaaV6WbV8tkqbW2cQFlQ3e/G9q+wh2+BdR5 EPadAbx0epd5fRN1+eEiqzQsP6vl1ds8nMLi4P2AFbFkIIWmFtfM2S1radAwJWbTW 4TkxiYtEz70dRLJscpQoTcXbI4YWMpk/KFZT3uw94ou0jgZhPB4dLwhqZKDPlRCNX Gr2BgNK3R9QbvAqvklTN4DUGZKscmRX6y1KAk4HrsXpe3d9B/0ZjTLvA0pBl/BBJ0 ownLgLWSxiBCMAls2UW6X+n/O3+RUW2RcrOE7Y+UfafJ4cl1jyEUMcSiQPbV9Yx0p OZGqXpgQlfx92A2Qew== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZTmY-1rWwtq0tlu-00WSqi; Sun, 28 Jan 2024 21:11:20 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 03/15 net-next] qca_spi: Improve SPI IRQ handling Date: Sun, 28 Jan 2024 21:10:47 +0100 Message-Id: <20240128201059.6259-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:0qDF2kdiWLKjmfUwJYeiHshUoj2sGIuQE7pBTDcXDxqU8T0VUo2 rBGqTThab3fjaL7hWHqHZLV/QY9Une6vElWDWBASFZpJz5UAlWZh2KWBZW2hlQOwxAWaj1T Z7vWX3PJ0mLOyB96nqx9GjwdnJh8cyyzjhKtO5i357PhCkGKZO/y8+0q3IxNn5g/CJGzlJU vA3EKRXebpUMtqdHi00Xg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qugKrmXZGRc=;I7ZoPvnut6nxSVLeyeeLCLFwlL9 uuE/hgVWJs5Q0jTUTqmz+lowGz5ZORbsgPX1QWgAeRhm+/7CPjdfACuIz46Iq6KKvmw3LZlD4 bMfHfHj/oAeQNfHIlcqlDgFgJnm5QhMDTOPH7twMfJfMvGaaGEJXBPeNpauu3Nhwg5jYZaPJn Vrj5pz53vuguG11PoKBEupBwqZkklkeUGss+IOQ1yvsbwyp5n40RpT68fN9qnu2Y8mBy/1NbF Bu5K8GqzCKpiIsGvlm+cwV+SJyFT43Yc857VmHKWHOKLuDM6oii57TiI2N4qmnXVpzsvn12EP jof2Xv4zkfv2d8Rn4/2rOEQRsfLCaohQY5L9WxEHPfbT67pcRwQVpatcmLrOhXGnIS1Wt/3uM RZ/XGX+9Qis7Wv+ieJPr/FUJ5IfRDWrstB4tpxKB/mVlyZeDxzklKDNTPq+8P+Ec2xNfic2sK 4ZTjp+eMW/eLoXvDM8ajJYmCttZQadm8EoaRnrqVGU63gQzc7f1dwefRoJ+1rqAUvJb4BU6Pf ONRZjLYn1TNmFNCeG20XqcueVl2L1x/RfLGIJofX46h9FFOS3Ut5QnY0j4tUuAZrDRABheaZJ sEW7MA28IgoPUkp8lAEI5xWaBKak/V+Qty3cXGckBLWu3eqZs/b5Hoy4hlRu1FhxYf/TJFpHu R5o7mYKHeZIoDuTtcBvpCwYKh1opFMG6jhm6PyZvo6GRLxZTPcBscbiwIVAD+JVPssFvcP90g ftxWfivIXKIOon9FfzezQKQ/4J109zs91SdvmPYvt9F5MOSj1/7moFaAAMDO6PnwEpWJbNTCw n6tyrpiRsOBk8AnwwexOeRcErvVcevCN8Hs5tYQeIMC8wb+xBMOM+vRG3hWc5iBL6gEV0i9mA bZrJ1IzzkpDbiuKv8RHse7bs7YtmjX3mPWsZCtHSXOFrmSi1qJzMS2Ix82VGVJtQ3SkT6Qlic 0WmxXWmNCKSK9OHhwjfduOz5wpE= X-Patchwork-Delegate: kuba@kernel.org The functions qcaspi_netdev_open/close are responsible of request & free of the SPI interrupt, which wasn't the best choice because allocation problems are discovered not during probe. So let us split IRQ allocation & enabling, so we can take advantage of a device managed IRQ. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index fe50c2dd7cc8..3f7e38a11ba0 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -688,7 +688,6 @@ qcaspi_netdev_open(struct net_device *dev) { struct qcaspi *qca = netdev_priv(dev); struct task_struct *thread; - int ret = 0; if (!qca) return -EINVAL; @@ -709,14 +708,7 @@ qcaspi_netdev_open(struct net_device *dev) qca->spi_thread = thread; - ret = request_irq(qca->spi_dev->irq, qcaspi_intr_handler, 0, - dev->name, qca); - if (ret) { - netdev_err(dev, "%s: unable to get IRQ %d (irqval=%d).\n", - QCASPI_DRV_NAME, qca->spi_dev->irq, ret); - kthread_stop(qca->spi_thread); - return ret; - } + enable_irq(qca->spi_dev->irq); /* SPI thread takes care of TX queue */ @@ -731,7 +723,7 @@ qcaspi_netdev_close(struct net_device *dev) netif_stop_queue(dev); qcaspi_write_register(qca, SPI_REG_INTR_ENABLE, 0, wr_verify); - free_irq(qca->spi_dev->irq, qca); + disable_irq(qca->spi_dev->irq); if (qca->spi_thread) { kthread_stop(qca->spi_thread); @@ -989,6 +981,15 @@ qca_spi_probe(struct spi_device *spi) spi_set_drvdata(spi, qcaspi_devs); + ret = devm_request_irq(&spi->dev, spi->irq, qcaspi_intr_handler, + IRQF_NO_AUTOEN, qca->net_dev->name, qca); + if (ret) { + dev_err(&spi->dev, "Unable to get IRQ %d (irqval=%d).\n", + spi->irq, ret); + free_netdev(qcaspi_devs); + return ret; + } + ret = of_get_ethdev_address(spi->dev.of_node, qca->net_dev); if (ret) { eth_hw_addr_random(qca->net_dev); From patchwork Sun Jan 28 20:10:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534634 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21033C684; Sun, 28 Jan 2024 20:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472697; cv=none; b=GmEiQR4wM/Sp96It4zVSPinEBOxdehnuhiNB4wtdJCKXP1bvhSRbpIs704mKa0y00I0SQ0j3ZsNYwCSuJ0Addx13qH+SRiPIBBidrf/VOpTvkoReP3mTxtDx3WeSWBtfmVsax6DaGOtCJdtrc/iYnUdTzcW0s727zA8CsNoVT5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472697; c=relaxed/simple; bh=JpsH264rChdlD49OAGFAPCLKSi7oz0Y/8/+8WGun5XU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k0BzibXnKM1m8fLh1ChOnKo8UVtMESFmFGBCmZZF9AnTNzfUfvpn/+uchngCVzESU2hQ5XqjlVGzYztRXH4XzQg3Z2S6xzfwJClOUzm3N330ufszEM9VCgGzVLjBxntIhlaewav9bXCIO9ze9L3fa/7bSsK6aI+l7kBdpaSzUmI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=K8HEBIe3; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="K8HEBIe3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472680; x=1707077480; i=wahrenst@gmx.net; bh=JpsH264rChdlD49OAGFAPCLKSi7oz0Y/8/+8WGun5XU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=K8HEBIe300lnhZp+w9MtRCT/QwnURiPXWa5au52TH6EDnVLrPjK+2cWAxAFFkjGd gauuozhTYMUgrIO7KizXk0qPIrS4hyf5RewzwE4U7NjihsnZGlf5hVW893TdeXiF9 f4W5E6UiPQ39SpfP480cyoA5hSmIWEHUBW3LdQNngN9mQTyE1XqgjykuvfgmZNzpB ihctsY5Tgp2J0c/wxOrVDeGJRt2xY20hFw91P/8PF1h5G+prp5w7e1zgEc2bVfrsA EoK7Kbe1fgH7SgXlQ1CfYCfqEAbSb78sikcU1uOAssoTQtaq3ClM25bdBK1cj63uE tsAe3bhBP6W1PNNm2w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7R1J-1r0e5F2yPF-017jkF; Sun, 28 Jan 2024 21:11:20 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 04/15 net-next] qca_spi: Avoid skb_copy_expand in TX path Date: Sun, 28 Jan 2024 21:10:48 +0100 Message-Id: <20240128201059.6259-5-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:Tfke7F+thVAsXv0rFm40+OARM7IFVXTugVggjAqduJPvzj2kySu 0EZjDhM6wOQ2h946AFuFWZGLE/Lzu1TyIW0nzXPhIAFot2cLglm/uXEM03Izi3zVMvd71xJ eQPkPN5CJyNv2UQd8kllxwCs53YwdpXo0xMuqo3lf0OVS5VkAX0s4ieUsjuKrH0XIk2XwqC fK8u1L5kkcq4dFU/NHulw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3o1O60aU1+A=;eV2YbaWMVAVEQyv/yT1ngGE1N+/ p30oBDsIlTsRgnYLifM8q9N+/7BNcmGQeavvqz5PLtr0LWC8oQFDClIU+CJ8pbGhUUU0BBgKp 9eqja3GHLLHxedltoJSsHd8LnNu8H2ZRv/i1lb8TCbQCbibgbk3Lhaq9TVqwd8Ngs+WIDLM4u PArchYfmOdOhK2NeQe85+U/VSYpbdaW9IpLbBAxD9mVEC6Dgfbe6QJdrW3PT1/2mU+dFz5ARV +GxuAPBcFHgPYKVHgFKMvXwSxUMUApcEUDuoEI4VxPtyI41IIeBxBr59UkePr6UjKB360tyug 2G1TGnCF9usQeGWWzJoiy1GBF/6uoFj+1M9CmHolvedQR7c+340Nfbqovu8pWbDCtfIoxRLWv x57njfk6AV80DCejePiU3pa4xHFy0u4F+BjTbjDrApNFJQy0ZTn0r5ueL4/roSxP12EtYLmgB ktThIWKmrRrJhtYP3ATBxGAO/fBW1oiNgIEmDnaFRBAD10XOWuryzy9yM/rNU1AWN4IPJeqkH 5ThB14OuSKTnMCgQozQQhIb0YiGzRjkfHCEk5SZrsvQhOMkKTZzgWylS6EYh3wBzee+/SiG48 mamEwtUosHbtMW7NmGWsLy7wd0WTAfWXGZlWtlTTkX2gtWnAkxZYncne4xfjz6BgBLZTBGozI 2HMs1AfVthhQjVGHfj23m71P7sHcvIMO7DQl+VTeLfFJ0uWg54kbJytEiV6Nl8qYDDKnwlK2N +stCPSUOKlTmD8hHroVMANWVIwyezjB6ybPNONXxJHT+iYUqiDktvLe5ckZeGTWcns9qyUPo3 jPVE2WQ9ZQRwhHjJq+BFfofiO1oWwkseCDNxIjT2eG1r8xHcT6fALOIbRfhMNeYmotZZ9bqgs K0GXJKhDfpfCQcNzpb0a3sSXdtov7FqSVtk3EH229/WCCsvI7nuiCRAmf3PGP9qv2BySDAXBe eYJ22g7Mwk+IpX0bKlc5ICeE25M= X-Patchwork-Delegate: kuba@kernel.org The skb spare room needs to be expanded for SPI header, footer and possible padding within the TX path. So announce the necessary space in order to avoid expensive skb_copy_expand calls. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 3f7e38a11ba0..5fabb40cca05 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -878,6 +878,8 @@ qcaspi_netdev_setup(struct net_device *dev) qcaspi_set_ethtool_ops(dev); dev->watchdog_timeo = QCASPI_TX_TIMEOUT; dev->priv_flags &= ~IFF_TX_SKB_SHARING; + dev->needed_tailroom = ALIGN(QCAFRM_FOOTER_LEN + QCAFRM_MIN_LEN, 4); + dev->needed_headroom = ALIGN(QCAFRM_HEADER_LEN, 4); dev->tx_queue_len = 100; /* MTU range: 46 - 1500 */ From patchwork Sun Jan 28 20:10:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534637 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE33D41C85; Sun, 28 Jan 2024 20:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; cv=none; b=CchqvnBiwD5LF3wGcypPUR8huEdtYO4wy66ez0XmCNbtjtobLAzn9uGMqSWcWbUaBj5tF4laweanEE6dgTnCyfE6pIVV2VaP78G2B0oLf7IsmzDgVMhvDy99VDuHUoB91gdvo7m+F+vgtBzzaMh2AGOArCAoklkyM+gkW7VSk3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; c=relaxed/simple; bh=qrDaTsk7HTfc8TrmJHba7pRVGRstI4yMYwXgF2rjUlY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=krW1Aj94fMgfI6rOMWLIdFh+akoZOleLbwE5CuT6kHwEYI1jllTvinAfwcRnE3fR0AxxQ/G9xXMQzdOtn0yHERSRmRWLQ25ZkSRgYPVJWmsp8ge7ejScR9OZH9hf2MsRq8Num6xRcEH4gh8tpzbfdkjY+FeXb0wMR9uwoA0Uxnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=tTcF6HLp; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="tTcF6HLp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472681; x=1707077481; i=wahrenst@gmx.net; bh=qrDaTsk7HTfc8TrmJHba7pRVGRstI4yMYwXgF2rjUlY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=tTcF6HLprL22VAD0O+Ir7RABGx40LNO5i7fDqumLJFRm3GwodUul70mmVT02+8T8 I0PFEOrBeXcwh6K150d45gcSPZM8sq9wTD3j++nCmeh62PUS8YjBYszFoVbwnwu5n gyHNK/BGj/fYqaHdD3NnjJR6sS5b0guuB7nAO2iCRQWeogz3b5pkXBSzNDAC78QzH SAlFloTVfs0OoOPJ1Ap8ZWE8evP0hfkN0KeaWNfeJ5bHFCV+wNC4Tzbe+IaicOdMn rRPzJQTkdp81lUS+iX3zjJqpvyb81Dz1cUL5pASqIUOnh8rlwNhiTNN0IuiZx+egi F5fmIU0oQK6xl6WpJg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MUGiJ-1rckJu0dFb-00REBN; Sun, 28 Jan 2024 21:11:21 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 05/15 net-next] qca_7k_common: Drop unnecessary function description Date: Sun, 28 Jan 2024 21:10:49 +0100 Message-Id: <20240128201059.6259-6-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:+Qu2GViOiUfHEkQicjzPEyIBrIAa1MFYCLZ5ZvBNpPxXfLIdsG6 Di4QCjyU7rsdzl7sXQVNqn0EZ8EU77Tctz+dbYzAMhZsuEtES+TBJxhCUctdl5axdFJ1cuE mXRKDn+0/b2HiMrqYKjYQSaLmAiNK5CMxg7nVZlgbZIbhZWtWieZfrUo3yO8Nr8XSzUL75k kU33VH9SpVGZD2Jg6c65g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kAoRPM2GeSk=;7JUgHRIaySRwE7vGkfoM01Y1e9c KLYMwhjzBqttNp81J116rMohewK2pEuFZTUIXvSPDtHVvbH79oTIwZ5YINJcIy4VtGMC+3/dt 5h/punMBQvGgFhHux4pRFOA5rUiQRaF2IPcppB6GpKtxHWCxBnZYqKTrdv2GpAXRo0ViVJVIx 1LV4MXMplqlDTn6ojUGeC2LIZWTIVrb4Q/6Xg19hFK6Xx8LG0TWxBYTbbatPHWnlKa34r+3xu 8c3WKTzN+A3V+XJyutnpHMapUz7k+JOxyp4v+XTBoFudI40h0clHaKq5UPzpe+YSiZp6ugYT8 LQ5/8VLg8f53ptVcTrorTiC+Nl0UeVoXlZycazjJDmD51+sSHB44qq1EqCDolxtxr7XR6IzUs k3zpLIZXD719r81F7J6qcJUtcrfyEEeAuVM2daIHH8UpV29X5qZ5G1E6SQfo25QMTRUM4XU5T BQrevwBtRlBb2VyiFdVHVOanQJ/ELq15AcTjSt53AReg9iLKDkA5wkwBIgR7Gprp34myB5Uxf QtpxJIhqPBKj6IJQBkF238uVlv6SA+sjrYgKEVC8GHCrrB32yJCgNFvbfKsMJuiJQIuJ9j5co e1ltAIredbWyE/i/EbLXU3GfN3fXgh9+Wcw/rxUYsonXyMnE3heaDhHZ2Z0B438lbG3bQjfra uIFz/RctPu5m6M/ysEQdX79SOfVXaqllNs0KzbPSr4b9L/Qw3nRyvQ7iLz5f9xnz8liweLeNn i8e3NFbB2cIEZXlUNtfVC3FYKSiKhDTlAjoIBVdQmh2G3jlZbWqHo0GgDiEhFm5Uy/78Nn1Gz gobbgHlH3em83Kj4cemsdINZTfEhgPJns6XXogbAwaqwnZurwhisnoXw6F/FkdxBiJnXVKUO2 mQ+Hf82rYt2kgEkNLZTyeJOf6kSe93mSoU1McEJvLua2wOx8N4JzqlPtGMXcjMgetWgA1rMtO Sqvs6bJDi/oRI+Vz3FoH5OSsE54= X-Patchwork-Delegate: kuba@kernel.org qcafrm_fsm_decode has the almost the same function description in qca_7k_common.c. So drop the comment here. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.h | 11 ----------- 1 file changed, 11 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 928554f11e35..71bdf5d9f8d7 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -128,17 +128,6 @@ static inline void qcafrm_fsm_init_uart(struct qcafrm_handle *handle) handle->state = handle->init; } -/* Gather received bytes and try to extract a full Ethernet frame - * by following a simple state machine. - * - * Return: QCAFRM_GATHER No Ethernet frame fully received yet. - * QCAFRM_NOHEAD Header expected but not found. - * QCAFRM_INVLEN QCA7K frame length is invalid - * QCAFRM_NOTAIL Footer expected but not found. - * > 0 Number of byte in the fully received - * Ethernet frame - */ - s32 qcafrm_fsm_decode(struct qcafrm_handle *handle, u8 *buf, u16 buf_len, u8 recv_byte); #endif /* _QCA_FRAMING_H */ From patchwork Sun Jan 28 20:10:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534633 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105F23C699; Sun, 28 Jan 2024 20:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472697; cv=none; b=P6lFeD5g+e60jSkOpo0SBaK2cYQgrn5K6xTg99AEHDvLb5cGiyH5o0ExNv92JTa4Yg9gjWVTBujO38DjufDOXUux6Yb628AtXtVlVkDrYIZ2yix88aDTRyGLmG/DdWwXtufT6RJ46K3yYbvE/Nj4xs5JkurWLI93dtCjUhbIhd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472697; c=relaxed/simple; bh=s+C5yRBMXtAg248/XAUH77adEcGlMjvS8LegdnUr0Qo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dOm5hMuo+dm2I8Uq92uwNsfcCJCibyPvLwmE0KO+d1L2NNd19ZXfMz1FS2zwljN3fk6QUOWd/RQSngn6SAtIK2HwRPCM962aOjY7+B2Y7gVDLCxqoauc7Fc2DXnRB0ytwFK8ZRbtK2oh2fa8etsrsqkRpQpzFhex8hLPXAvA2kQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=pLkrkDb8; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="pLkrkDb8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472681; x=1707077481; i=wahrenst@gmx.net; bh=s+C5yRBMXtAg248/XAUH77adEcGlMjvS8LegdnUr0Qo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=pLkrkDb8Jc0oAEY/WseIA4TLBNGf30xJw/u4CC+fRPlzt1/fJzD2c4y6+ZMplQ25 vBOUqsMtmlqBIcdMGU1y6SURcI5UjkS8BS2D442A0CKluurpfjQbmwxvrX91DDBm4 xjXV+YgNwQmJzsb1kZnZShoajGiBDSx1VdZQld9QB+t/ATDD6C/yadGZSVNanf9Gt Jitwoo6HvNiye8+awaRen+bLnm88m/v49ex0We912fyhbyjirzJQaw3MO5Ou4vamu xEVS6y2YIW3jvRzpq9LL991qDmBGhQfn0CjykBvk7pWD/oYGttDd5UXhpEbjinrXZ dD6/+CFbMS0zTTxU+g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwfWU-1r9lAZ2Vxa-00y9Dk; Sun, 28 Jan 2024 21:11:21 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 06/15 net-next] qca_7k_common: Drop unused len from qcafrm_handle Date: Sun, 28 Jan 2024 21:10:50 +0100 Message-Id: <20240128201059.6259-7-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:E/sFtk9/uq2rtDnmVUG7YxQ1S/BpIZ31n091PvTo2DhEWfYuLie ThSN5Ix4JmtqDH9NtKKFZYeqY4ONhhmzWfT/C+XB1zmQsbXDlXRLRAQ6XoYi6PcMLO/vvXT EEG1wMdvopt3/z3l81wj7qqyf1Eeo6SqdIMCRgTCKFX2kv7iWB2IhPM1mIMdRd1Ya+cQ3a2 mfW6J8YVhSSyO7mqQ+ihA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AWUveRcSymQ=;oKLwGwV5/z4+29d4ar82OFldb8K IalBExTsPAA7TFEwSPRWrTzUj8Gnqqbh5pt6eo+qh54LGKPCTg7VHte3/1Fo3ERH1faXjAxx6 JVR5kiOsWxgiFEH28UitDjiC7UcbdSnfKVCwJswv53qw+oFJPekriRz4UJwxOJId8vXI6dtye OiBEkG5DgraAeMpCLkjMFdZq8JfQJBHP0U/cDCEGSNlt7prXU/5LTM2snLPrQ2KmUsOIl5NfN Sd2I9iVv5rUhVE1uIaGszPJk+gOxm/ojq+aq0OYta1uYZ8NIHmJfysBFLrhjf4q5rBNTRXgre SdviqLOBOi+oNiqAhsCZIAzqJccJBTL/HNiKvNCviZtuNbt7a6JpJRIn9D2vAHfhvMqhBS+oO WHvsjillpmt2n4DKjt8h/8xUVL1q4gDt6bqMg+Q/ovHkPu1zAosG4kwYEiJDEzIEjZ1ouZt2Q qAfv24zKxYUGVr3/dGdDgGffzXI3L/dSxHKS4V4iiO11e7+fXE3u3bu+TCMO2WKLbGC3ZWkRd c865q/yvk/iAn/xRTIrGUM26DSdV0VBvWgG9jVfbsZ5LIuwKqBHUrT4QUj19EkMRSNWuh2AkE 1SyN+75YjdvNZYf9C0BGv/RKQAx4pJUWTTEe3JM7vfW7bjW6kuAESfeiJuv8eTRsp60L0Pgop t+lo7wFaz8qsFksY542Go48mfEbL2rFG573Xc2aOV3zJtKZtp8fkhk+iO6Pjti9HoQYTAtY44 j5KvGO+7CHg0/Tn8G05P4Xd21imSxJDqSBot5ojMENZfRzSEa8cYBF47nECKFXBOsAiL3iCIK v3LeoNy5oFify3A1URfK8A43UXhIjQRVKyY3fX7Dcl6C8HDduU9tD0ud34hIhk9TmeEBflp43 YH+u0mbNUZzOVpyQc1h8QS/aHPcPc/ThIkTxwrsaP58GPnes9v5t2qanXubWcE2JbIc2SwVB8 hYlxVw== X-Patchwork-Delegate: kuba@kernel.org This member is never used. So drop it. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.h | 3 --- 1 file changed, 3 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 71bdf5d9f8d7..088cca7f61db 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -107,9 +107,6 @@ struct qcafrm_handle { /* Offset in buffer (borrowed for length too) */ u16 offset; - - /* Frame length as kept by this module */ - u16 len; }; u16 qcafrm_create_header(u8 *buf, u16 len); From patchwork Sun Jan 28 20:10:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534639 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB06D446CB; Sun, 28 Jan 2024 20:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; cv=none; b=Crfwxhe3nglZEog8Z+z5sd+Xy9HDyaBMSbWDxY3BAiE4epGcrRSHUx6M+U8g2u8qOYL2YJpTfz9MxP/XV5x12P/PFTv59S4UXIkIjC2L39nECFltqAQq448Sln1x7tjFQCRlS7oGEQWn5shCEHxnJarG6lVUnMPREfPTrSCFVrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; c=relaxed/simple; bh=9nG5ZfkBuUN5ZV4k7LbMvMOomZnYYGTfrpZMBZK0cUg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c4TfDZvFIi6zp2Xe/gId26ORILG1mwFkKmjQq5AKR6gJ9yIeKEjroCIl9QzGRrlU4IsCAeJFWvdijEyYDgf0BS/nAynE9iWk7eGjyz5ncdtR6cPlNdseAGlVGqA4Jkd4yr4K0KhAfncYlM7xAvz6TZHZ5pDNJaT6mzuuNJ3fXoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=BgjNj8CE; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="BgjNj8CE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472682; x=1707077482; i=wahrenst@gmx.net; bh=9nG5ZfkBuUN5ZV4k7LbMvMOomZnYYGTfrpZMBZK0cUg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=BgjNj8CE2rG6QdmCmyGQ2Zt2YlBOgh0katb68v9mfl8MViOUQsdmWGnSrnoJVaxQ +eK8U4VVZZxkBLRNa0U2SJEKB/3dgA0Y+sOTkku3ycyaUlU3xBgIxtfL9WXxZcMAI nGzqNPbYsneUHWmppNdYqCfrQBilKNTyaSq3n6sUHPzeplSEF+AyjA9C1cmgZY1/s l24rCYatZPbAwv+XhOgxG4CfQazsgqhuCaAkhTG/LIwSMcnwuZaOay3v7cbqAlvR0 HrG8tpM4NC4KK2GpORyKwxAuW2JwpTVtmX9hvPC96ITkiEUTGiAbnwR8flLHhMPHI 6Wd/Uf9m1MYtRGnYRw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvK4f-1rCnAh0Rt3-00rFat; Sun, 28 Jan 2024 21:11:22 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 07/15 net-next] qca_spi: Add QCASPI prefix to ring defines Date: Sun, 28 Jan 2024 21:10:51 +0100 Message-Id: <20240128201059.6259-8-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:xd6H6boX0x0vPmc3Nn20WYgdShANCNE5HSgTLr+F8IBZklTlvE3 QgxQz7CO7ZdmxLXYk9eWw3MD2m+7gt66Ss9ck7Yy4DU7tc0YqygSrDrWsQ4LnhzTpP0vrz/ yd5InRL+oJg1xGdDHwEdl9Lo+DJLw0YzuXSo8To0jdB42vQKrMuMpaDU2jBbTIaun6fE1Hs jpeA6zADxWGdbGA/MHeQQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ByA3BbDXA2c=;G+aFXPNrSEH7qcBlachS1bg8OtT A0U+V7xeROpa0pihRtTiMkxi0G82RmrEElDDTqPSrCtyGfd+jayFXdHUnXf7gEmN1HO7JWrrC uat4XpEj7zrNP5BD7Y4WeRuxbdxcNePvZXBBLgTpCwJl+0aezz1QV8Ys0nDelumzKBX4Ck0zC g99W29B45731m+k+dOogK/5X28zkM74cK4+zJY5dF1/hvwmgWWm5gCSAa4qJALxylo18S+zjv dYkq1DRXPtlgHVlokpOcGagb/mXOlZAbXXCGh7ylHuGacz61uklHCgFBEEVtFe7Ku0uTbPiOJ xGpTg7DpwQ+OzcfIAhQzXohrGxVUtXRh5vF/LRKIYPURLIy/3JHDuYfn3I3V4Rd3kPtzpuipK EFCsk5f+ml5Z/YEGcJYvo6NfNKYDHCBQhCLO6B/l/bH97jmADVb5gAxOpX9x2d4e9SjKrFFak iNfb1hO+ajKbbWUoq7Sm1aYZcXhmRXljIiK7HxJL3I1h1QzBMshcYEjVr5Q6gFGr18TXx+/au RUfw66FpLkEbfA1insTL0Pm9l4a7JdEHca5huXncTc+du2cUAbtlCRvCxQ5X2IwPyG7/lX/1i oiZOnbrNANtizIEQlO8qm/TaNd9w80JJnJfR3gVAknTMSv/Ig3QK+jK0sBQSq7oLeis+YmlUs bqV2er09eYPXZ6i1PE1H1Mi5Ck9TDbwjLSZ4wThfnmbXH7edT8uOOkm8EKFKTLwWqTfpeKTMq Ax4RZlEGVsO4Qpe4sWW9x1vP4NEfVpTPoeEciyCB4ZpCz1tk89nPFg3WfUsm54DLRar7jKCoU 1o2E8ZOWYRuAhezWPQViUkCJVElZ44Dd6tYo8c4MZB8f2lWUkeBmqTbY3GdKZbnk2xbJpEMRK ui65kyIpHVRvjphJAEBF1dG5fwQpkYNt4fSxMHt/9YF5KN2U04gd4UG1HgnIbxADjUjrOCvAM CC/zJKMj7Rr6D9VWjOw43Xh/PMU= X-Patchwork-Delegate: kuba@kernel.org All defines in qca_spi.h except of the two ring limit defines have a QCASPI prefix. Since the name is quite generic add the QCASPI prefix to avoid possible name conflicts. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_debug.c | 6 +++--- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- drivers/net/ethernet/qualcomm/qca_spi.h | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 1822f2ad8f0d..857883d0b5ed 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -255,7 +255,7 @@ qcaspi_get_ringparam(struct net_device *dev, struct ethtool_ringparam *ring, struct qcaspi *qca = netdev_priv(dev); ring->rx_max_pending = QCASPI_RX_MAX_FRAMES; - ring->tx_max_pending = TX_RING_MAX_LEN; + ring->tx_max_pending = QCASPI_TX_RING_MAX_LEN; ring->rx_pending = QCASPI_RX_MAX_FRAMES; ring->tx_pending = qca->txr.count; } @@ -275,8 +275,8 @@ qcaspi_set_ringparam(struct net_device *dev, struct ethtool_ringparam *ring, if (qca->spi_thread) kthread_park(qca->spi_thread); - qca->txr.count = max_t(u32, ring->tx_pending, TX_RING_MIN_LEN); - qca->txr.count = min_t(u16, qca->txr.count, TX_RING_MAX_LEN); + qca->txr.count = max_t(u32, ring->tx_pending, QCASPI_TX_RING_MIN_LEN); + qca->txr.count = min_t(u16, qca->txr.count, QCASPI_TX_RING_MAX_LEN); if (qca->spi_thread) kthread_unpark(qca->spi_thread); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index 5fabb40cca05..f53438c4aea2 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -476,7 +476,7 @@ qcaspi_flush_tx_ring(struct qcaspi *qca) * has been replaced by netif_tx_lock_bh() and so on. */ netif_tx_lock_bh(qca->net_dev); - for (i = 0; i < TX_RING_MAX_LEN; i++) { + for (i = 0; i < QCASPI_TX_RING_MAX_LEN; i++) { if (qca->txr.skb[i]) { dev_kfree_skb(qca->txr.skb[i]); qca->txr.skb[i] = NULL; @@ -890,7 +890,7 @@ qcaspi_netdev_setup(struct net_device *dev) memset(qca, 0, sizeof(struct qcaspi)); memset(&qca->txr, 0, sizeof(qca->txr)); - qca->txr.count = TX_RING_MAX_LEN; + qca->txr.count = QCASPI_TX_RING_MAX_LEN; } static const struct of_device_id qca_spi_of_match[] = { diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index 3067356106f0..dcecb072b8eb 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -39,8 +39,8 @@ #define QCASPI_GOOD_SIGNATURE 0xAA55 -#define TX_RING_MAX_LEN 10 -#define TX_RING_MIN_LEN 2 +#define QCASPI_TX_RING_MAX_LEN 10 +#define QCASPI_TX_RING_MIN_LEN 2 /* sync related constants */ #define QCASPI_SYNC_UNKNOWN 0 @@ -54,7 +54,7 @@ #define QCASPI_EVENT_CPUON 1 struct tx_ring { - struct sk_buff *skb[TX_RING_MAX_LEN]; + struct sk_buff *skb[QCASPI_TX_RING_MAX_LEN]; u16 head; u16 tail; u16 size; From patchwork Sun Jan 28 20:10:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534635 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B4B41C73; Sun, 28 Jan 2024 20:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472698; cv=none; b=ZsQ42ECIfQSJ9JB6Y0kXM6iOyBZFTgeeD8f987SGpIdsxTN0/V8lEOZVupXaBk7tFCX657bs1JnCKyne/CJkNVwnRPxHNs4a1YHitFbrKkj+iSCWvZyMM0ba7rSqo66PJ/S8YJuZX9TdV/Ru+xEVixe6ZpYE5bUoSxWyCFvolCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472698; c=relaxed/simple; bh=brs+KzeuIYeo/VPn51BkrIoo6mMzcYsP95CaSI8Cyqs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=evbzMxYPzXgnlnDANEEC4rGHPWem5V8zQCDtn0NtpHZmw3wVZdrHOeampCwGXjRhC8y+IlcaUgonKmx51ssvnKNQqQ+40QPw/VOTNDGF+TtMp8BH10X5JC9+6OD7sGCkFwmoqs+pn3YSECqL9CMfxNlIptp92OIjBme8iu4hoy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=p9N4VS6T; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="p9N4VS6T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472682; x=1707077482; i=wahrenst@gmx.net; bh=brs+KzeuIYeo/VPn51BkrIoo6mMzcYsP95CaSI8Cyqs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=p9N4VS6T8VrwoDIQhyxjJFS1gIQDqmoWbKFzaXJ7FSpjkgbfKTGM3/ewnE1xxlOO 52CGUGrGckxainniGgIjWI9pIC9TOsr6VbNikZBQkqTAdBAt44Kf85k7lGAXPpCiw BPt9xO8hfEJ00y6J7+c/C5cRYMXKeT6FdNqFN+V183yTE85yC/jFNWEZZTQoBIutL iVjvxPGTyhyfrfUGJZDhBM9mLLLuAWsTai5EPfxyCirZqukHabXaBlgK3BL9eTtb4 064dchEUQEtCX8YULq5Dj4C7ZQTaBzxMJlVtdejq/NS36HsxTaTI7gDHAHM7Cb3NP GNliornm0xFaz8e/KQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1My36N-1r8vp72Eyl-00zWGb; Sun, 28 Jan 2024 21:11:22 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 08/15 net-next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES Date: Sun, 28 Jan 2024 21:10:52 +0100 Message-Id: <20240128201059.6259-9-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:1aI6hyxVWayTcrdbOb7yY/nFyOSxa78d9MrfQ4Geyxrmfm4OOl0 jo+mGZ4R51wU/lbC3R5LiCTVMia9PuXtdvG9EFCIauNbVwYh6q5UfMRKw9y6mLd/DzpGVQ4 LbRXGfNU63njrIvI/c+cIDtizFtSflCgdRgE1B8WMN46vpQktF5C97h2MQ/NkzXV2WXfvIE TI4F3K6SGL0p8fshRmIsg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Xbs6vihAokg=;TwnCR9Wkj9Yf9wWnXU7JTQFfjuN j4lLumrIOJdvJ+UDLcQFSjoUwAULG0VuUfqo1qCiqlJxN223c/U4nATZUJEpvSsvDAowQI/IE tMux6eDwbIlnmt65anhHRuuXW+bbSKH4DxYZaf1c8nccAtFug6e3916Hogt7Q9C6+5uaJ7BOV +Lr4WEoDe4C9vSrCvk3n6mJxLlnXayaiOQc5HAEn2Y+iF0fsuN5UcsBNIs0rTxWfSFNZF4NPv QzFsllIFZpzmyG6/7LeDuCjuyQ8ZuxL8qzykHJzBnWVmGCnbzsruvApOJ8bkEyDqv8ukvuiVJ gxJut0S2i2QKp0Mk+KKHe7Nllj/eWMLM3CgMf8c5v0Am+I9hCinLGDUpvyAuwrYrG7/18KB56 kc+LmjkBHWWhpVUPRFns3M6993kGPDAwFbNxYMwuQ6QOWcg2Sh3TflrXrGZ6/mwjZCNRcmB2V dcWxUkgG9tdfH1ucQMQ0e9kYXTrzxc7PkMcbet1ZmmehfRXzvU/7i5i1O6VUxAG2NmSF3Ko/u yyQwdvfIrOaN6J7kVbvk5gglnmXojj/wjMALLob9m0H2SqAA6vlmf8COchMFvk4DwbotLyM1w ED5OpaGW3csS3rx3JoW/VFv82Mv3Txb8IWs0Tl34X/0wnG3SrYnXe3Qf4ZfsooEluxYXGUXF6 hydq5scQkB+ntcYq6HLZFqXC3iIiiNI4hKGVEAbqdPjFciphhraRn77xEG1S+LKEcQAolhicu +yw1eh94o05v70zGA8VkUiDZdVNMI/Ek6tqkxYssb4u+08bTdoqkw7E1Teup1vE56042JYESw Dxvv8uEPxk+GfB3D12iep02XDvZcER3wCWR/7vkCW9S9/LuvFx3MCVCarrEvRJ+VBAH/fHd5B vnKRiV2f6nvsRcmrbeg/29spD0cCzpF/qh0JjhY1up2XAr6igWOtwNPczbHBt4msdatq5ovLx 0Vi20A== X-Patchwork-Delegate: kuba@kernel.org Currently qca_spi reserves enough space for 4 complete Ethernet over SPI frames in the receive buffer. Unfortunately this is hidden under a magic number. So replace it with a more self explaining define. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- drivers/net/ethernet/qualcomm/qca_spi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index f53438c4aea2..c0f6bd3d331a 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -829,7 +829,7 @@ qcaspi_netdev_init(struct net_device *dev) qca->burst_len = qcaspi_burst_len; qca->spi_thread = NULL; qca->buffer_size = (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + - QCAFRM_FOOTER_LEN + 4) * 4; + QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES; memset(&qca->stats, 0, sizeof(struct qcaspi_stats)); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index dcecb072b8eb..f735ad77402f 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -41,6 +41,7 @@ #define QCASPI_TX_RING_MAX_LEN 10 #define QCASPI_TX_RING_MIN_LEN 2 +#define QCASPI_RX_MAX_FRAMES 4 /* sync related constants */ #define QCASPI_SYNC_UNKNOWN 0 From patchwork Sun Jan 28 20:10:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534638 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD2D446C6; Sun, 28 Jan 2024 20:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; cv=none; b=lT+Aj7KSSk6igmFbB9SVh5v6tXPUH48+GP9wY95AFNPH3FfGM9EnV21rRggzwNesHtRIXZIKXiuiOansdYk8Md6QZVaYEmhOWiJXbN1r5zBTU9sWKkZU9+0BurERdNHnBr/llM/UhJWVnzPOtNux3vVUivxBhbxZgfgRtoFYZe0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472699; c=relaxed/simple; bh=h1bRRRY/FCZQLy4wDwHzxX7GldpDd9TCNFjh9pcU9A4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W3j5uCcCu/cx0TfuDZZn4eXKRmigTlIeyVy0KdKX2xKyDK9XR+Hu5SyIj2wTc7Py21SuFxkmmE5PWlnqJWTXpjMXRxFaJ4L1vgRzfNTi5igQqm+5RAQ3uJrKz1PZxakKmFqyTD0ca/wk5dIdFj77pBfQKvt1WGv1rZv0l3CnYEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=r6ae9JeS; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="r6ae9JeS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472683; x=1707077483; i=wahrenst@gmx.net; bh=h1bRRRY/FCZQLy4wDwHzxX7GldpDd9TCNFjh9pcU9A4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=r6ae9JeSEnQIjEUur+y45c+7j56bya2DGrIgYoGIcsD1eCBR60CLdMki6D6GABvQ b7wQaNmr0Yctt9izc8YEt1qzL8MF2AAsBgbUS/GBRiAXoe54BmCx7uTkHklgO6LrP I60YQ09dxszUK9g2HA4WXLXVb/QILMo70TqVJWeIadgW/XQtBgVehnvewHNlWjvnX dO1LWy4uZR4IP+1gl3RtYqc7LZ1PDO5GZ3LmgRrvuNaf/5HT365nHpjeUZA+quUZR EoRt6efjQMVK42s+bePog9q4Glaq9mwm6xceTD52w1JsONF+IhB7UvjA4LCsnhFw+ N7kUBHQvaP+wevb2LA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MryXN-1qglmp49Vl-00nzy3; Sun, 28 Jan 2024 21:11:23 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 09/15 net-next] qca_spi: Improve calculation of RX buffer size Date: Sun, 28 Jan 2024 21:10:53 +0100 Message-Id: <20240128201059.6259-10-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:GpuL5zWeB90TuO9uSQDgdEb89KM9M+6A0tu0E6ZGeFrbn2VEh54 OylkLOomk9qabeX59uMDRiNsskuydqlOKHx0gCP7tQM4MzM3YPbcbfNZ577ZFr4Bu91cMF1 36YAe+tbJQ+j5zSHW0ameSlYhhqe+liK4AFpKLpEEfokNrvX9NnMhaM2uhteuss9uHPs/+5 MIn38seGJbNJutZUieqSw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:CbkIpR0cq8k=;X2z0o+pYvxeEgaoaRyY+zRdtQyT apwhvG98UPrU9OylE7Vl9lVbBrAPx33/cNI38hNA87ZrJ9+BqNVn3WYGi8EFMgQ1VR+WHZ3Qa WRiB4p9iMbVsgIlWwMQuVwPVEBD/MMC9iUGgV9tqp/7xTUOYqMWgJ66Od6u9v2774hu2Ny8+N aAGl05kyOF04OiTU3JcR5qgeCJ4ErLRsEsKtHX+9aIZO4VhTO0b/vGKDrdWpPmD8yUkLfsYJk v6tRvU8YX2oeMtq9X7d8XzCbheIUzZliJFjT9Facty8u+GRBNNKRpBihW3ZO2BMUmgN9nOCje gZsa6L+qT5GsGhd4rgR5GQxbZlCFoScuqqAUIbYJ3EqmQuwFg/nqCl+mGkfVHf/6lCsUNnoVl BvLMppVYZVq0NovnvT4NKMMeWT8Gq2SbfcHrrATWfmzhM1WWzWrDL6XbUt+PjRWIzYkxwtVbz w4jA0yJ8DIqPrI+gT7Za2jaX4x+15act1PosMFc8VmICiH9Oun3hT6AKg+d0hXIduFH4/VjFF NQ4l9YwfZWxKi5G6XNeV2EihsAHZq4uBa1rBzY2eFCAKY4OgHA6RtMUrGwUcBLemdmS9Jvzak Qs6pmtoc8Hcsm1FNiB2XB//ZLvjQVvPLCargZNMq71xBm81D4qpqaVTzt/GAe84yJL7RQmPnL BDOq2wvzvxOHdpocy7eGPOSSAvvATGeb8v5zSieExbQExAkPKyCOKWklKTma5EeyELCzNd56n fBiZvPhE6Tm3s6LMSpvzRT0zvmtQtEegP8Fa76y2VIDeDzl2xq2qiURbVkNQzdvIS+uJrlaiv o7Wd5e4zz4iNnui2F1WF+ON2iuo2dg39OTuOVVaDihwAGwBo4H35WdN91q0iJJ38WDYyBpmBp VQOjYcwtuHgLekBUpOa35YFMjBS1itrCeVmDSzK4S2iVHXz9cXSRt/IcBrhXf3UuhkK6UU7Lq q4Hnsw== X-Patchwork-Delegate: kuba@kernel.org There are two points with the calculation of RX buffer size which are not optimal: 1. dev->mtu is a mutual parameter and it's currently initialized with QCAFRM_MAX_MTU. But for RX buffer size calculation we always need the maximum possible MTU. So better use the define directly. 2. This magic number 4 represent the hardware generated frame length which is specific to SPI. We better replace this with the suitable define. There is no functional change. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index c0f6bd3d331a..b35fabcd488b 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -828,8 +828,8 @@ qcaspi_netdev_init(struct net_device *dev) qca->clkspeed = qcaspi_clkspeed; qca->burst_len = qcaspi_burst_len; qca->spi_thread = NULL; - qca->buffer_size = (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + - QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES; + qca->buffer_size = (QCAFRM_MAX_MTU + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN + + QCAFRM_FOOTER_LEN + QCASPI_HW_PKT_LEN) * QCASPI_RX_MAX_FRAMES; memset(&qca->stats, 0, sizeof(struct qcaspi_stats)); From patchwork Sun Jan 28 20:10:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534641 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CFA7446D2; Sun, 28 Jan 2024 20:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; cv=none; b=fdnzFrJf61UY7BSpIl/LmJXZnEhkTr4Ctgxvv7voLXzYkDrnfAWugV/QiZ53iyRxOCRiLNGGQjBRn3KMa28ZqtTNkAXHbfkZiAlb5ozxYKWPKG8QTOFcrIVKfv2LCKe2KZ/tqVFPKGD9Qr/VUl+dWuj9MwcifPVLDFQI0r+ZDfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; c=relaxed/simple; bh=ckHhRGX1uFe4zXOay/HZNXKKKQjSfzNMM+9KeqUPzlk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mX00Q+vF/6qnbWGtdVLrBzGpEoklahs9LU0B4b9aU1KfwbnNIw+R0ix8fVvzAntGvfiU/EQF+v/EWC6V0QJEI6fk+cu+BSXX1nTKJkS5W9PWgAN+y2bpSpmDFPk9OUMJ4QoAcLNPm7qPrIYZ7Ww37nI8iqJJ0izIrrQ2ucy4pZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=k4Hgpt9z; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="k4Hgpt9z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472683; x=1707077483; i=wahrenst@gmx.net; bh=ckHhRGX1uFe4zXOay/HZNXKKKQjSfzNMM+9KeqUPzlk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=k4Hgpt9zRKMhtZsO6/LMZQGfK083sOv5ylNGnl6sclCUToWpCKsdpF63FJKfYeeL 9FgjSY981h4eRnyiqWfJER/bccMmd5HMRBgLSrXfHav9yVnz2waJ6tmM/ubifzllW qCvvtHM9bM5F43GMGxF5RP8IEwTxX3h39uI0Vacp0kBFEsbpIqcvzOh6coTxIWkE7 NSizIiJq5rpj83axkuvDg4PD0tb3EaY38Iu7LxBB1whp7N3POuFdYH/XnESOM7mGM 431IG6ZLCvZ72kV+DTF5GOnOSIv3JOZkp/DjRZPmHJ5YCOpbBqGqoBnxzXPV4bdCU /ui+fGKcrVMhHMN0Fw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McpJq-1quIiP1lS6-00Zzai; Sun, 28 Jan 2024 21:11:23 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 10/15 net-next] qca_spi: Log expected signature in error case Date: Sun, 28 Jan 2024 21:10:54 +0100 Message-Id: <20240128201059.6259-11-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:9dHEZTQTt3oQtnOq7nBtaz/TRLP2O8x1r4rxHiNaBMx8eoTD0A4 rbFq4f+RzEGZSs1gH3+T2CRDwl5lhwdufkw/mBOS3fya7QarNTtTxKYdOz9BgCmiEOHrdHc pQULQ2eYPd3bgJnrDouTYMcNTRoYxrR4WdJsVLIO7N2AiORxCDXqnPFK+Ph5HtX24MnMRTt 4/HnV414RDx4j1qtWdqiw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:R9CMuJyLgoQ=;34SKGDBlBplOqnPuEy9NEznJpAy PD2abgE73JEFTVPZj58zRHAgGKp9cY8X6zkRmYvoXx566PlgCH4Yi9w6moj46hxDyTxe4c/Nt qR9NisDCwllxtR76/dYQs12hVMIcc3FpKq1r/BS4NOZa13EfHortGf5RZpNk4pwnheZl6+W5r 15Gxb8EPZB7TwTI3auh5+SjfEeYWLCqzo4KgMjjrfeTqVp3rdJeL4WeVTckdgnq+DdvFv1kSl qSWREEeRNQvXyn/57Mj4gsdw5Na/2OIbKydi9aDMSpCdBBjLxuIHGEVTiOkMVK1xBRCfItFLV B3a+dOa0YXUH3bq+o1cxuCE9kkufiEyF7JhLFPPo91RUnl+lNS4abwwOqPiGSXuOyfXvecMla 5aAZjWc8eyFigywhRkqRNOa2q7HGibMHpRWPaLFoCWgu1vjT8dIuV8ckklCVjU2cUfHNNOT/+ Fj3+BS0J06yQa0f6cxSpccH20bbzcxeAl4Uwdk9e5oBJlh/RzCLh1QsgvLBm47m1k1/he2aHH hnbKJ90175CecMwdIFjVJKRFoK8addabPRiThYdFxAmXawOm0PoneIFhfKXhWJra6jOPbxVEx YI/RKz9C42OgFMlPq6QYiCW7+9j14QXleMHJmQuIVvrVmQ8xQ79TsNmmznSsf1LDKThgETLgg Tl9BVbfa5MQtz9/s3/NLR6kR388llSM06+Uchc/QT4eKeRmNplEIoXT2E7mOCPva1ZfHPYyTo Ovm2Xlf9qucKrSl45FLFpcwOTgJQzV2fhzdVqn6MC0FQvzSB/EliuRpYS/OoxGqxW08pHyHiM 3H6GgV4H9tv+xu/9x41JkQJUjS8TWW6CpoMOgsY5yI11Kb/xlOzzsvtdIOhQdKX1CURk+yOMA WE0Y1aBiHRo92pKxAakGqXzdaDCFeLmITWM82uCjT3pgunflGAZ7DYI4YvaUAFHZQOs14A4Un 0KYcyOdP1CLxrBMKqjX9BdC+xfo= X-Patchwork-Delegate: kuba@kernel.org Most of the users doesn't know the expected signature of the QCA700x. So provide it within the error message. Btw use lowercase for hex as in the rest of the driver. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index b35fabcd488b..d2d68c20b32c 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1006,8 +1006,8 @@ qca_spi_probe(struct spi_device *spi) qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature); if (signature != QCASPI_GOOD_SIGNATURE) { - dev_err(&spi->dev, "Invalid signature (0x%04X)\n", - signature); + dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n", + QCASPI_GOOD_SIGNATURE, signature); free_netdev(qcaspi_devs); return -EFAULT; } From patchwork Sun Jan 28 20:10:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534640 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2551A44C96; Sun, 28 Jan 2024 20:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; cv=none; b=lllsnzAHnUE9say4jh2ROErCkT7/+jQdSOrXY2cY+5Ff6TZIfaRjzpfTMky3CmSv9z5NlaRMtvGZxoGYIERFu8tAwfSN6W1XMc1VAe2S1HpFs883JA9RcpRYk9f9e8sZhSiG7V8dyuhYpK9AR3uBJwDejp1fH4G85oou3wVfYhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472700; c=relaxed/simple; bh=uST46aVMcO0oxyeJtONHXSQTVv+FoojlsknYZY7TYrs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jWrP34QEaZYg1GU3IgblH3hy+ruTRrUzVaVTg/ujPPKw+8SdTKyFOelN2ZP+ZHMmDn8My2UAvjyfPlcX4GkVrSDdIg0M2HaDRzDhHWnrCisr2dB+iFYpSVdhR4gAMAdjhGI+szvxzdCg/J8YDF7OZbcKbv+mAiRLeaH2+e3oHjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=Rkr4vVE/; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="Rkr4vVE/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472684; x=1707077484; i=wahrenst@gmx.net; bh=uST46aVMcO0oxyeJtONHXSQTVv+FoojlsknYZY7TYrs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=Rkr4vVE/iVXJPyyEUuFCsm5viHcodBnVccQwHRv8uSbBxjQfwcneAc6gIv4Zo8kM bc0RRa5YbKagFZn1wLdtLTtRwKeKiZU74UcaXd5bX+dzOO8ygVFjMxdvwa4yGqeFe AevJnB7O3VvSJwyf0tS/iBRKmc9swVy5NFzndVtT5AUUkimNq9lKV+1qZ07BCbvIL EjT3X6CuHeC5rWVBzeX8Co4EwE6AEPADkYh6uGUxfwDgtcuYAM0s0KIdol/s7/ABk Nkrqan06+28l5EOhEk1VZLdoaqRc2rM5lGpr4fcnJQs50FlUw+9oKyJeY5m3mIK78 55qAhwHayAXcNkNHzA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYeR1-1rYKTY3mWB-00Ve2D; Sun, 28 Jan 2024 21:11:24 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V4 11/15 net-next] qca_spi: Adjust log of SPI_REG_RDBUF_BYTE_AVA Date: Sun, 28 Jan 2024 21:10:55 +0100 Message-Id: <20240128201059.6259-12-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:9bSTfWo2H7bN9GNATqokZKzrpAXj8qGdG0JIg7kD+UeFZ7XESL2 DYOotE9tBV19InmYeRqOQkBsUSO7taaThvh4grA3yzUCyju3tcAfwc+faXk+ljC7ToqXk4l l5XMf7fcisL8XerUPKFc3cEVQ0HP6j5g+Us6QHRCCXFQtU+YwnkatORDAwP5tjXc8pM/OY1 LxrvpYPyn73nLPksGqlHQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:k+PyFEjTasg=;ZZNtwmw/ebZFR1tBph1IF7AV9zW su3Wah4RuT3qktXo6mNIYHwxJXecSAZSnKpYs+rWzWyOVTdhAaXH/8BOgyeTJ0ZBeBJZPA56D 62t/gIVuf86CpP51jnBM/kebi3+lXu75j4pwcw6/QiI1DAJu/5lFNS08O1EI0b4xNTeomOPDG soueA7KU3XdeOULGNT8mH9BNWbW9l7C0ouFUxa+MDv1nP4LqlqVyAI2naumEu9fee4nLRoWa6 hlN+l4PzFFgc02NT/Sr4bZzG8T1i7iOEe1hXcOayGgIb8+1PpW2kck1ryKmzD9qFafeweKbol RfNjq1SZ4A/WZeGqTVGYMsF5j5OktiBCMFmGbolBWh0Jpaf1GYwjt4BkRa2v07VRGadJkOtCV zUibMHr72SMlOS9Fo+r35hI/ZzkYeiQODTGuC4Y6R7AiDO4Z9l55AdsoNihJfMSKkaSulgh63 lu6vG8z8+K+tK0gR9K0BloH3+Zj3oC/mgevXPIAjF6IhuDXrRvR7BHL730FlcsMiGBeldbkRj e+w92kAVaAZNC5yBjsNhu+RnIKV2q7xvmX4DsDagPOWnvAXCfi4bVvaB8R83Y+7AmUZ223coF dGn01PDHabqUC/YiY3sL11JD+yeNk2UMLqyxIG7Tuq0hM2+YnMp6sPW3rg7rwNmOF9vjoM+LX v8ZBrNZRbidJfREFGFReKCx9nrp2q46evypZOLVAx65prm3wDsjwjQS9KneRAij7CT7E1En46 OMu8yt6IxVy4XjPP6+0P7BIgDtP4SE8KRofZIwdJ2XN0ytQ5sQRbk0oN+xPbfoAP7+3vYeQ1u 7siQnsEHg4GlyrB17whn5lEM1G5etZHpg2dChlmQnlwwHi5pJK/onr/57iWZv3914qBUBSI71 +kyNhkQRDSQfTKHVkOTGsR4hGC/TzFt0NerzIGBQeMEGTlJRmhl2wMJa2BNHhlVxsRd6VddEX HvOsbA== X-Patchwork-Delegate: kuba@kernel.org All known SPI registers of the QCA700x are 16 bit long. So adjust the formater width accordingly. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index d2d68c20b32c..ca8c0596a992 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -359,7 +359,7 @@ qcaspi_receive(struct qcaspi *qca) /* Read the packet size. */ qcaspi_read_register(qca, SPI_REG_RDBUF_BYTE_AVA, &available); - netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %08x\n", + netdev_dbg(net_dev, "qcaspi_receive: SPI_REG_RDBUF_BYTE_AVA: Value: %04x\n", available); if (available > QCASPI_HW_BUF_LEN + QCASPI_HW_PKT_LEN) { From patchwork Sun Jan 28 20:10:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534645 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CADB4EB5A; Sun, 28 Jan 2024 20:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472703; cv=none; b=nx5scTIpNghVcTkYNlbpnouPJp1HFAcpcho+LWUfhs0E8u6fNlzJRi+ww7QgNbhJWMp6Lc7N95Vi+q/TriZyBSvk2bSFDGo460p62kx8iZMDdButSJjpxkYrsYbAwJ7XGpl0OOLbc8htWxENuu1jtwjm6AsbaJwyVtx/YoOloFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472703; c=relaxed/simple; bh=23alTXm9k3lUbkrmIhUVX5VMI48Qopj/KB7hkWZaKlc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dgsfQ8O/qVDbZpVy8rcEO2CgWghQRtXJh+BZsBAUeFxI+ZcWaKvoppINWDGrVe6GbfNY5BAJz3h6Dgyg5cnG0J6ZPzZdE5nIg7YgjWXKrCinVZLmonpf17oRgTVt49fFOB/nCTaGELctYM5sWktZa6unCqN64aXBEaUmADHzY5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=gosZk95J; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="gosZk95J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472684; x=1707077484; i=wahrenst@gmx.net; bh=23alTXm9k3lUbkrmIhUVX5VMI48Qopj/KB7hkWZaKlc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=gosZk95JFvmUVPWauOOS4Npvv4ELr7lDNIr0T0YG3t9oSfIhC5NbvWV54xHbeHkm 9wxlkOf6g96n+pe6tR0zszm3GpOp5rGuMQcb5sHn3LcAJM/Kvzmd+I81KELBbZ1Wx APRO3QhYvkvBxwd8RPxzG4GjfV9psohzZOkoRSlVOanTDspoNUJMLM5/t1goz273K JWig2Fp1gythLNCNMzI684InIevwZggktGAp1ZP7Gg0HqcgMsSj8+qA0O1t0WRUHP KTOHucpmiDg3HIguWaSslVLVZwqEZCTJWp83Nczaozuh79n6YYKaD37WWiXAbVtuG qN8d8h7QdVwdLUk6QA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtfNf-1rDLfP1ZU7-00v6Pl; Sun, 28 Jan 2024 21:11:24 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Stefan Wahren , Jacob Keller Subject: [PATCH V4 12/15 net-next] qca_7k: Replace BSD boilerplate with SPDX Date: Sun, 28 Jan 2024 21:10:56 +0100 Message-Id: <20240128201059.6259-13-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:sv3C3CwzpQQO+yKvCE+VSbpj3mQKK33sLQnOkw1dQQwvbLUAbUr 6Feq5wsqmWh5vyrw0NjpKlQpkNe3cKHqys35UuZz7g6WyjDk6B+DJDEEUCtx59+QZFiKQrS iGMNchysZEHw98tXqXZJLVFAvxlSXYGL/SukxZG+F9oWdTa5oZy3opWt85n5bNsQPZR8iBV QM5cMb/AnLBXWj8ZVgy5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:B97AHIhxMB4=;q4B1ppViQhUZZpfOdX6hMzVLB7B 8jtXX1rzRyfzUwQhWb6HyzVhbIIXqPIvc9dj+SbKq3GqvFsyFWHsR4EcGoUPFeoF6eXl6X9b2 Uvhnezv6bsp02M2Pjhpb0+7zHSgIWIOfN3wS/yUnOCtSiC4r+Q83sgHUjESNJ+HAqpBsCCaTH Bz8LrOIGmr6wjf1VhTp0mI4uLAB29NfvRuN7ss+rwHz1DRQzNa1bF8y6PL2PE4gSVXEFiPvbg We8C7dtvd3QHjBysRuABp4Us3/E+FYpM4eQ0W2cj7hbKf9vhBe3A7iksEO8eOrW+HL8wCOYdZ PvgUgUe6X8M2Il8ervAFIA9sJ+74uhvoC+pAbfoh33IexZeUvKDPlk7WNwjgBh6uLUN/QqK9I y4BM85K0cgFipWCsDmw2/FctyBoYw7woKATQiDVjfZH7fFjyCpziXoRwKopn47hdB+7i88KAu gksukh+zvc8r6OMCGqEsMXdBDBad06/mD5twi07mwFe/DS8a7ymx2NyFSBrRNmvVzOKsE6wSN lkqVRV6zil2mLHVQDYCEGyacktBuIMzJaZ0OgzKQHXBUfpcmCb1FhijoXaZqpYmWD8S7QN9EF rwDiY/S7O++eu2fCYPANxcTRVbOP8MYurbBLhNHFCuVBhlme6in3GKUlGbwPLPuyGefIVuoxe 8/IL0wTh3YzS1hAYJ1ayOVizH9MDRRASLKDy0C2L2rbAaFeEW+u6RvYc39O8aNHl/vcr2Xc4u ApF7mdjEPfW9tBw15lu3RJ60hqgjHdwYiDBYZKMiimXdmC3GP6APGsXDjONP/YoZieDF9bqPm qoDuRAl74SNVdNKzLmipw++ULhJEk+HOURkbGlZnQ09lwJmRAsQAJZN1kTNG25wZlx18/oh9b z5Qra7EloRaVE4YMvQteI3yX6pFbgquLB9eWk1EaBs48BikRTMQzDNz2GVRCn0T1awNZKazqI tS02LA== X-Patchwork-Delegate: kuba@kernel.org From: Stefan Wahren According to MODULE_LICENSE the driver is under a dual license. So replace the BSD license text with the proper SPDX tag. Signed-off-by: Stefan Wahren Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k.c | 17 +---------------- drivers/net/ethernet/qualcomm/qca_7k.h | 16 +--------------- drivers/net/ethernet/qualcomm/qca_7k_common.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_7k_common.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_debug.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_debug.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_spi.c | 15 +-------------- drivers/net/ethernet/qualcomm/qca_spi.h | 15 +-------------- drivers/net/ethernet/qualcomm/qca_uart.c | 15 +-------------- 9 files changed, 9 insertions(+), 129 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index 4292c89bd35c..6263e4cf47fa 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k.c +++ b/drivers/net/ethernet/qualcomm/qca_7k.c @@ -1,22 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* - * * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. - * */ /* This module implements the Qualcomm Atheros SPI protocol for diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h index 356de8ec5d48..828ee9c27578 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k.h +++ b/drivers/net/ethernet/qualcomm/qca_7k.h @@ -1,21 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. - * */ /* Qualcomm Atheros SPI register definition. diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.c b/drivers/net/ethernet/qualcomm/qca_7k_common.c index 6b511f05df61..be2f754efd21 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.c +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Atheros ethernet framing. Every Ethernet frame is surrounded diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.h b/drivers/net/ethernet/qualcomm/qca_7k_common.h index 088cca7f61db..44ed66fdb407 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.h +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Atheros Ethernet framing. Every Ethernet frame is surrounded by an atheros diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index 857883d0b5ed..ff3b89e9028e 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This file contains debugging routines for use in the QCA7K driver. diff --git a/drivers/net/ethernet/qualcomm/qca_debug.h b/drivers/net/ethernet/qualcomm/qca_debug.h index 46a785844421..0d98cef3abc4 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.h +++ b/drivers/net/ethernet/qualcomm/qca_debug.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This file contains debugging routines for use in the QCA7K driver. diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index ca8c0596a992..ed6d20be19bb 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This module implements the Qualcomm Atheros SPI protocol for diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h index f735ad77402f..d59cb2352cee 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.h +++ b/drivers/net/ethernet/qualcomm/qca_spi.h @@ -1,20 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2014, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* Qualcomm Atheros SPI register definition. diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index 223321897b96..d0db9d0adad7 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -1,20 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause /* * Copyright (c) 2011, 2012, Qualcomm Atheros Communications Inc. * Copyright (c) 2017, I2SE GmbH - * - * Permission to use, copy, modify, and/or distribute this software - * for any purpose with or without fee is hereby granted, provided - * that the above copyright notice and this permission notice appear - * in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL - * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL - * THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM - * LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, - * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN - * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ /* This module implements the Qualcomm Atheros UART protocol for From patchwork Sun Jan 28 20:10:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534644 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B0C74C601; Sun, 28 Jan 2024 20:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; cv=none; b=dunlCuLa4pImc92m/6uNmFtSyf4Sa28rfvIrqyA0O4zmuQnadnG4/KPhRlgrt/vIyIKEJ5q+yGqjzscH2aKCFX57E7ArFsFKgEfA0JB0CojWoBrbafUBzbOXVbnd98/3txdgg0lXWcmVrlYEHnkpmue/CE/SZpA6diTMtUc7SO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; c=relaxed/simple; bh=TdAVXBepThtonvq05OjVh53CVgb2tOWE132D7XX4Sa4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cShq14lIrrG38QezTNuObNOcF8Li8KJ8cNag1evkfGA4LT9DmTf5t4kkATVKsGLIbcdRysrA3/bPsaOrvFymHuk7motcyKa/RyNi8QaUlEDqHusz0XtCtzNJ4kQQoWVSFnIk1xAe5g4JfrSdli0SjZGnz41zZXt5i4JAhpSuS6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=aj5epTaS; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="aj5epTaS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472685; x=1707077485; i=wahrenst@gmx.net; bh=TdAVXBepThtonvq05OjVh53CVgb2tOWE132D7XX4Sa4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=aj5epTaSsEtWxIOT7Kyn70WttkHX8mO97Y+usp+O9OaxDrZBh4/WCziFrRFiJl5w hgbjqctNJ5/R2T3RwoGqNkuxoxRRZIyWr3ZpQm5l4JpTxhbJrd9gG9lc/Ttq2bMTg Hs+EZs+cQpySfKuvPSl2S5TqChDgGJq6m1HTXcpYNwW2dcY0vIP487V8BqwwtZL0N 6mGXJ4djtWqNtLrFtVdPV4MNRVv6XI7V0I6SXf1k59aMzrxVzl4dPjkldPxuJhZk+ Ggu0kYz7l7YH2wPPFspZPzKlO9GM3piBsIs8XGjYCZB276ZtFRaBS/CnfOzRdPtYY bsHjSceec8Up3dNGqQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MHXFx-1rHD493e2j-00DZDf; Sun, 28 Jan 2024 21:11:24 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Stefan Wahren , Jacob Keller Subject: [PATCH V4 13/15 net-next] qca_7k: Replace old mail address Date: Sun, 28 Jan 2024 21:10:57 +0100 Message-Id: <20240128201059.6259-14-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:M7V2PLT1HdFWGe649SBJERW5zbJXCKK9SHEqd/xKGEfk9NdcNmI /UJK5NmLBgbvK4wHcp3waD3PRuxwTUhLElYIR62NFWCbBe3L3adtbv0zRSlZ70Rgb2TrYoT HKg4zsomHoIsCyvh6gOxzvyP332VtRRi4/orXftrNAu6Crkoew2JLo4dNiTfDQuF67OuDv6 lbLolxQ5y6pivDO1oy0kg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:cFGmtwLpARo=;p2dWNyQr6Cp6iuFFcjo23Njz2eJ +EdjIT7t66ij9YpcskLQ0S7q0wFRxUuFcMIUauI0lv7VGochwSBWX2SCMv5OMaqIP+0fmmPIM oJRW6jH/Y6YVg1sqNrXcpZkcNe9BqbMAVJjRqslAE0lSa4ahnJ2gWZhU4uR509BXrz04iWVpr QuD4eva+fn4zksDGCJjhG6SjegL2sHLEJMa14dii38lqAts+nNFDm+7KQToVQDBgzC5Q3+7MH ksCbmY1U2GwJcHLohs8c2WPEdVMjbLnzyTDjijMsVAFWXgOsG7GwD0k3vmwLrvzx2mPWqM8Kq 3A1HwZHFaTf7ZLfGp5WrRwlxNlHaP+X+GkS3pgpYA8YAy8lDxQtkd8c8fronDIxbsFDwjnvAt /9qVSDzapQWDiWkPpD2yyDrSkaoIh8hE2uKvHhU2K2fpzOBbQO1aMNr+rvgeIo12C8q/nWHXH b/ggv8CDhY75v3z/F37kSEZ9y1n9pxx3UXJEEwEpw0/h1SHU2UUR3I/iM5mIwaz7z+fK5UW9A r0v5QDqDmW4XbS7s5Wr8MuWAiu1kQV4tu8mGQSf7e8n+jVtLC//MiWxKcOcRWsfj6fzGDaceY Z4IrEID3BXQ06jVQHb9eYM849zmIJI0s1uNe23bxwB5OqDJj7f+Wdc9GHh8Zbx0fRXjWGRnkY 4G09s7uw2jnh0omUNUb31cI28c37QeJuuPKrPC4Uuf55Ch0/XX6x3MzZe1PdWXIQ7oUZP702L G3w6qM0sU6kVrBP2rN/Qxv5TEhSY8KzO5DTQ2wQsC0rBfwqmyEeqiGpdOrNNpEKXBiBL0kw/T pTfHUAbo4u6lkKEnQFbIAO8SXqb9wn+EGER+bhbgt9czWTmfyLK9h7is7c0t8zdvEjcoQGMlc iHV+d9JQA4je8cnuB7OsGsead+wNWLDBM12qdfOWzaNZ/wQxTyJl6DW9Ap5tmEOoM86NJmIK5 TN/rfA== X-Patchwork-Delegate: kuba@kernel.org From: Stefan Wahren The company I2SE has been acquired a long time ago. Switch to my private mail address before the I2SE account is deactivated. Signed-off-by: Stefan Wahren Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller --- drivers/net/ethernet/qualcomm/qca_7k_common.c | 2 +- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- drivers/net/ethernet/qualcomm/qca_uart.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/drivers/net/ethernet/qualcomm/qca_7k_common.c b/drivers/net/ethernet/qualcomm/qca_7k_common.c index be2f754efd21..5302da587620 100644 --- a/drivers/net/ethernet/qualcomm/qca_7k_common.c +++ b/drivers/net/ethernet/qualcomm/qca_7k_common.c @@ -149,5 +149,5 @@ EXPORT_SYMBOL_GPL(qcafrm_fsm_decode); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 common"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index ed6d20be19bb..5799ecc88a87 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -1043,6 +1043,6 @@ module_spi_driver(qca_spi_driver); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 SPI Driver"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(QCASPI_DRV_VERSION); diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index d0db9d0adad7..321fd8d00730 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c @@ -397,6 +397,6 @@ module_serdev_device_driver(qca_uart_driver); MODULE_DESCRIPTION("Qualcomm Atheros QCA7000 UART Driver"); MODULE_AUTHOR("Qualcomm Atheros Communications"); -MODULE_AUTHOR("Stefan Wahren "); +MODULE_AUTHOR("Stefan Wahren "); MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(QCAUART_DRV_VERSION); From patchwork Sun Jan 28 20:10:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534642 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF8E345BEA; Sun, 28 Jan 2024 20:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; cv=none; b=qw48/o06MEPv8Dn31wIdukX8ESYCgkpchZ5oyP2/auhCSgMVnxpHyc3j22Vdo9srqnNhNMSyGTgcShgrNTR+qgH550p6QXsf46hd6VWvWGOqRuU78wptoA16abhn4WaJ01nd9chpMT9V8HT3BiJ0uSoNrCCGoRYPjT77iuzpGFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; c=relaxed/simple; bh=qomwzeZ0+VdI6mZ2yu+WT993r+YiIAfvdX9TkSDmq08=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Ypl4v4tkw+h65b0dcb1ZtXJpuT6oy1zORVQuxyhh6kv4vfs/jsJD8dupUn90u0TFzObVJZYzmYaVzKwDWuf0ngLzlgMCjWXOcXcxwsYNMbqTKXtnF4ac7XKKMR0giVcI9mVA2hpfr5Aq7II8yhr8DdMm+SZ6mwJgk7+16C1CZU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=E5w0/h86; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="E5w0/h86" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472685; x=1707077485; i=wahrenst@gmx.net; bh=qomwzeZ0+VdI6mZ2yu+WT993r+YiIAfvdX9TkSDmq08=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=E5w0/h86kgKM+pPZP60JZkKNqdUVjJj8gvX+i37JI+u/d0CVWVh/ohcbOC8IWPwp ujD3buEPmemNz79K11vLkwH9A7oWFMwEj4zh1DzPYpjiNt3rs9m9yJavdTPhvlBvF nt/lK3od5c9kShy7ECSlzDtzlT1u94dacZokaL3UoEjEWT/2zN3jFmGlL0sJFLHG/ z+Bwe0rFWxYVpXTmhfUneUc/lJZ3L3RSCZ2oxurNaVAwFGuPszzn2Xbha2GJHJLEm h500/jgvChpINTAROrYJaWXmBAepi8IOxuIEIX0c+ZjPuMLO1HkYOZE6R8vUui3n9 I/cmChHDy/xqV0BrcQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBDj4-1rLuHz1BT4-00Cj4W; Sun, 28 Jan 2024 21:11:25 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V4 14/15 net-next] mailmap: add entry for Stefan Wahren Date: Sun, 28 Jan 2024 21:10:58 +0100 Message-Id: <20240128201059.6259-15-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:6f7TV1aAKo0U0E1wOpDbkUEDEgpYbTr0D+yMFV6k4LWK/x1cpT6 9rQb70QUJWxdrreJ/ScTIauS6tOWB4w2bPTYW9Awkw6Uhxqx4KxSZ9hn3LV8mJ5WKMbw2v0 9wtl17zw/G60UHcnDN1BbaTc2TwSPRaek3rNkvXDxdSWjFpphyoI5kiIpruJkAIcMZHVwh1 nB1uNUKtJ/iiX3XgfrdGQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3P9hcsEIbjA=;k7vNDQcKfYHjKoxTtuU0wI5t1ms ejdxHLh5JflPbTAdKJghHs3gKnB/4tM2qZOKJ0b7Nw9UPF5IbUkcqr1s/ZN6V5FS3BnWxQb7u 6akH+8SUBL3oVdHjZx+Pi4K/gRGrpth3bgT+xPWBSugbKjdsgjR0QKiQfOGpvjv1cxKHvtIpc HVrnCws2Ifsc7mbXFlhodBSlGGw3RKwZCfQJJ0fe0BlkGWFcSMMJBB8On0o5fVmCTkZwOD+ef MnryCPQKDLsv8iNC6mtg1MMKQQjtIPwDC1TETD4TwH2Z4l1fRrloX2CSMcvFGXBumb3QuFZxO txA5fRS0pjTq3mMxI9G94lT8xmwv8BbYKQFBcaDQJKcKy9Z67PB5Gvm8/8RZmEd3IauzT1blA jM5PcSDkv9hsdl1eNeksjcCgCp7eenzyVXNHGLHuhouKYeqvWdrm83SxHIpFV9v2mGPMXC9dV 7ab9nnIXMQCgDtMgpop609Jl0rddOfK1GWGIi/6/1OKqJX63QWDqna3J5EsNvA8VZGGLvFQ55 SzpC0wku6aD6XIr77Dzq3+MmHJ7hTr2bQktOVrcYe11Le9H+SWA2PY3pC2l/PA8/9URF5yevU kRSf4Sz7VSbyUlgkPgulA3RfZZbXw4ABO4PxFpBhXAq/fIMMc4D9/wGb9bWsHSJAnXSph53jJ k5Bdy/ExrT7b4r1CHT0UvdfrwZaSqmxKMHx4vxJpXLrWAY1ZgMuv4U1L3Hbh4hCpLEKqu2LDJ cMjvtLnIWPS3qHfpYFNUM/qBBXwbdyuuislFfLwjIMe1ngEqirlIrlX1FAgVJyIFQt8cURmVP qc7tyOh8kAKPFNzQmolvH5zhBBpAhqDSlswnXRNJ1Eei12QqFe/a88dF2AnOsRURGlnjzd1jb Q88QKoUzHh+yn+DDJolZs0NtOxKuRFziQP4q8n4dmX8Gw8+QefrRyKRecH61863P8N4hzo7Oc pUMG4w== X-Patchwork-Delegate: kuba@kernel.org Add a .mailmap entry because my old i2se.com address will be deactivated in the near future. Signed-off-by: Stefan Wahren --- .mailmap | 1 + 1 file changed, 1 insertion(+) -- 2.34.1 diff --git a/.mailmap b/.mailmap index 04998f7bda81..95b4fe465cc6 100644 --- a/.mailmap +++ b/.mailmap @@ -568,6 +568,7 @@ Simon Kelley Sricharan Ramabadhran Srinivas Ramana Sriram R +Stefan Wahren Stéphane Witzmann Stephen Hemminger Stephen Hemminger From patchwork Sun Jan 28 20:10:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13534643 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6A04BABE; Sun, 28 Jan 2024 20:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; cv=none; b=T5nFPYYyYBs5q03DNDg2teQGNpNAcT6wj4NBjv2gvo0yoj7T6ewjefhDF81yVpLWTRtVZ1NeU/UTHM7Im8oXMpflqPW5XMt3qIsrtz2Kf5auXyNMjoRtDR/QsvQoME6m8JCD/+eqaxyetDGHFEzELHBBh5dbmZ3G6QoKRZKjkaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706472701; c=relaxed/simple; bh=UprYL7c9BGFFx9RF+baFk/bCnsWzoZ6GnTm2K3A8nZc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=S01S2TQ1BhFT4IxURWNep/k4jFYy9hFEpy/Me6uIWK4Xcy+GdMDplt6DqI31A0jEuww7ElGIWYmrn7Ky2JRDezsU3jUHtXA02nUw1H9S72H07U4tc1INV23YMtoBGbm3DOeL4Kv9FcQDIdW3V5a2fOuA53bA949HZa0GS1yTwPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=GTSMhSXG; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="GTSMhSXG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706472685; x=1707077485; i=wahrenst@gmx.net; bh=UprYL7c9BGFFx9RF+baFk/bCnsWzoZ6GnTm2K3A8nZc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=GTSMhSXGZq+MRIbZEIrjxVFcQt/b+n1zGreEIXDDZWxdFccLf8OWw7AkE93lLWVD q3j7WWhWTdlETxNrdLRWpGV/+dJoD3ZaiWMG9C68m01P0AVDhVtmRCqPgkoguV7Fi fMXKACXL/ybPgC8X8Mdy8u0v8bw2ujMtVCVH7krf7arYpt8xBmFOrB8WIakECZJ3G LgoO4ffubkpsHjTHPNuU/ZlHbRSbAY2wf7jJDayLkDSplwNnv5eRE7g6f+twchajF PeuJ+k6jfkxRXI6FIMScKdJQhl5Od7AEw6yQQn9C1CTq0NLUb512QutXK0eFjnmhG NcWA3HqaAlfUz9Mu9g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1qzXci2x8b-014Qt9; Sun, 28 Jan 2024 21:11:25 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH V4 15/15 net-next] MAINTAINERS: add entry for qca7k driver(s) Date: Sun, 28 Jan 2024 21:10:59 +0100 Message-Id: <20240128201059.6259-16-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240128201059.6259-1-wahrenst@gmx.net> References: <20240128201059.6259-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:AmM69PQmlNUns0mIyx+OWnKo+2WuQh1suaLwUEklxKPCfWNso5d LeqiIIEnNO2o23Emtbi1vJ32V+O2LTbmdbC7aWztH/RGWoyBWPWSNi8t7s4mZdE+7GcPkkB AyfpzGmFC9VErvUzbhUce7MsqEw4oxy1wZuAv3AZ0jQZH/l7Ny9nVZ+MfIX97gYF375mfws WTILl9wx1Cja5ZyY3A9QA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kMUhhpJpCN0=;lnDTBNUZTKlAIbznG8+pTxaVIzA TopXl8QGZPURvTCVxDmHoaNESq38S0L2AdC4QTREqe1Xvn8cqCOvUvoMlkIofdt1iUmgKDouU FuhHUpg9piZqf8XZuXxiTUEv5ssoEPQNJxKi7+8iQGrfdtCueL8uuvXIQBXsbQAFRSRVbRkCS 0BM6IUX3qI6g5DSX/rz/E1d0r7ypdI0pix0iMIAJPzb1sjTyifhttKtvvQ3uYviNARvgrw0qb afTvDpeaCma1z3Rn0K/KIBy39g1Lt/LCQCJWtDkxBMW7PRwzjuEzDGS/B89x4Iwqg35/W0nSJ gX704RGref7Ad30gqpdIQHM5EK/SQcDbZz82DOpstmpIfDv4M+r/WgSt9rkvchqbz5Yer/VpG JstTuHRFVqH8MBO2IZUnQdUAY6PKXbcoTnTR6U9mLq6hNeFX33+PMA0zasUX3w4OM1TjZvZZv mrW68Pxz2T7AkI232aJUIgWj+QiNSpB88ciq5Eu4bmFCLE/gIJ8pE6Wwm7l/r7eUVHITbpDI4 cGptHqkYKLkUtTeejAwPZQyll5RyEuZlYuJCc5lqrC6qDhD9uyOTrfGe/4C1jlPiRl8lBNb3Q ZXTn/te6fF90pLTVJpjkXvj6LjjoxlZ3BwIm5t6Adm9Qti8EqbbeLvU53Ud7PY77nEn/jv0/g L+HO9bTrJ2W5t340rqYt4xD0vKuyyMpSe2gwpTnc4Co5BUGpebeEBb4Xkmal5mzlSO+C64D1X EhA1dPMuKwIUhU39APE2wWKzmU6SXslHWCsLBNeONWO1jZpV8+VVOSSwlcmijBWJYnXem4p9G JhMurjzlmAYtwImbeUwvSquPxTSV+dNMcN/jF4bP5Ldog1TltlsIryWRvE57Yiz804t5/yGWT aASbp0dxG/iOeoXmLqBDvNLSlVW++4mpeBGyvUcruagSI/jtfPx/OPa8Su8Rl6nMigBsL+7Kn oR4beFuc1YRObnL0q6k9wBpHp3Y= X-Patchwork-Delegate: kuba@kernel.org Since upstreaming i contributed a lot to this driver(s), so add myself as a maintainer. Signed-off-by: Stefan Wahren --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.34.1 diff --git a/MAINTAINERS b/MAINTAINERS index 8709c7cd3656..9768f1130522 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17990,6 +17990,13 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git F: Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml F: drivers/net/wireless/ath/ath9k/ +QUALCOMM ATHEROS QCA7K ETHERNET DRIVER +M: Stefan Wahren +L: netdev@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/net/qca,qca7000.txt +F: drivers/net/ethernet/qualcomm/qca* + QUALCOMM BAM-DMUX WWAN NETWORK DRIVER M: Stephan Gerhold L: netdev@vger.kernel.org