From patchwork Tue Jan 30 09:36:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537094 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14A90C46CD2 for ; Tue, 30 Jan 2024 09:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5oRt8258DkiBYMAMBz+PLZaJ6R1KFr8nLCfkibAPwWQ=; b=bOv2LfSDUeOiqy bW//DzeSErWguVcgjgRWPLH2WPyqzQgJL+bndU03wSw56nsmGrELgvU/Ndvyy732pMfIJ3w44WKgg xVCdKAKJYoWoGFp7vV92EaQKWXOz3QOXzM6rSF05NW+FW5Ihid7rLB2bYF3OAPKh6JhKVd42UHk0L PuYH0ColbBOcG9rG7O/htv5JGMGyPnM2lP4rKlrI2K7El/PhFoTNNARvFQar2nO3dU3QfLzdyxgLA 3R9TEhtlHWOjK0/kQwXyoVvZ0FU2W8xq3PttTtkA6qKa+y6CzLY4+VQ2T6cbY5cr1fVk5VcgRHZBc C+vA5DX8uKkKM6I45OEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZl-0000000FyKl-466q; Tue, 30 Jan 2024 09:38:41 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZZ-0000000FyCr-1OYX for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:30 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-55a9008c185so6483765a12.1 for ; Tue, 30 Jan 2024 01:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607507; x=1707212307; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z705+SHTSj/VSK3FgDpPeHNjW30UFZiT02gadyZNGK8=; b=ltrV8Ti3dwYmveD5f2u07+SCNxZ7da+bSXh5P1r/aNbYpKoPdMOiFwi0k4MPJtweZR QbOV6r+Tpy2lcpuBnzlHtbRtqB+vneAnjP95yHCncGhygNRR4QAGwy46BeQD6G03zE28 JLfgfQS0davkyScu/SrON09jQ1ER+188F5pGAlwMYkBIhfDd5c7as/QRlPpgBV32cMSb IUWnjOP98LgC58qgyNbTtVrd6DjP94YsZp9RSjWbtVE8cPTWKDHyYYa7FRrGyVAYkFZd GOOc6kV/A3/fAuB86KTcTHu93AbQks8wawOQODTIMkIbSXhg5EWmn+ITU0UdLf2hRfv9 pR9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607507; x=1707212307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z705+SHTSj/VSK3FgDpPeHNjW30UFZiT02gadyZNGK8=; b=qTxcTSUazZEKi6ZVQP+AuLbyKFhdkGMdhudZjIrScKqSPdquXByy6U+LX1O6ce2k/L 1MW6qlVUqDIFKG544fPL0CC6zyKMZYWeF+ouLgUGKMcfO6vjpgyBmlliSEKPWtgrD8GT PIZ+3Xsw7VqosN1ToOPhW+5nM0oAAOzqk8hYZaELag/wmJ/NrkNQBXlvh6Fpjb5miLKm tfL6jRM3anL8Y8Y4Ab6lOUUkNqExPbIXQK1tIGTqdAJzpbDSpAjTjVHTBErxHyQRgCFH sYCdIoJTgwltjUBfzX0ghLaCC8WnuWeHh6YKEhsMCBUoZFtR2IwsyVhoOheKNupu6hPD ReTg== X-Gm-Message-State: AOJu0YyGJwd9yFcgMch/qdL51rgbqDb1clu1UtkuRvtujEFzsxGtYbPp iBCpH3/kcmOIg38V4Vcj8XrrNQnJtdBteeP/jhKmMxMJsEK8cww/wleTn68gxv8= X-Google-Smtp-Source: AGHT+IFi7R6rGOIyVBaQx5RvUZ9n04l0vwkfwKqczrdhe8L2eBuu/DQhZhkDLCMWnDTWBH6N8cffeA== X-Received: by 2002:a05:6402:2054:b0:55f:18fa:eb59 with SMTP id bc20-20020a056402205400b0055f18faeb59mr938270edb.16.1706607507526; Tue, 30 Jan 2024 01:38:27 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on Date: Tue, 30 Jan 2024 09:36:40 +0000 Message-ID: <20240130093812.1746512-2-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013829_391997_F440E5D2 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This pclk clock is required any time we access the pinctrl registers of this block. Since pinctrl-samsung doesn't support a clock at the moment, we just keep the kernel from disabling it at boot, until we have an update for pinctrl-samsung to handle this required clock, at which point we'll be able to drop the flag again. Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- v2: collect Reviewed-by: tags --- drivers/clk/samsung/clk-gs101.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 4a0520e825b6..61bb0dcf84ee 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK, "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK, - 21, 0, 0), + 21, CLK_IGNORE_UNUSED, 0), /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK, "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user", From patchwork Tue Jan 30 09:36:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CEE9C47DDF for ; Tue, 30 Jan 2024 09:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mfgTV217rL9qhjhZr6VhAd5Azxs+n5YHBmHKTbPx1WQ=; b=Qugi/LZXJRCQhF EeyqM/JbbNs4tUOxCLS8efZsDKVDJUsScUEYKDqE6JTHAxSNEoBMP8wLKOBVT0uetTk+9dmAFcM5l /W7PsirZnYB3uX3KtmJKD7hKv1hGRUaFpPRa5fHyRnozw8LStxPuCO7DyGJx+EW7yXjl4AoxjfB7t 7HsKxS1mlnK9ZQJbsvVka7Ic55vrfDJuCqFjXCRnOGyHfPdQb8rm9xQTpibIHs4t66hTnp7PDNVLX s3MLXIYkricpvC7LMZojlLd4VHE7VBujdfD0zm16VF/EDRESZpgVEUZF2YwqelceHHsydGrHu3F3R MQYjhRJJiPnP5BSNjgeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZm-0000000FyLC-2wF7; Tue, 30 Jan 2024 09:38:42 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZa-0000000FyD5-07p4 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:31 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-55f279dca99so1823806a12.3 for ; Tue, 30 Jan 2024 01:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607508; x=1707212308; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/QlyL8STz7vLqr76PxDM7CwYVIS28ulp926LAaYNGGI=; b=YkcRmbYrk/ggg9R4uFPr0DruczPKS59ZLzS839AnIG2Sa8iKPSX/z1XEe2uXvteywC 2hkTGSsoZitfSTJFvrhYjCqYOkxp3UskBqp+PI7OKaCZBnZeO3JEF3V6ITTncTpjdyD8 8NvEhEHRReyS3feTE4xseKK/kb5CeQbS6HBVeDD2ewHPO0EZSZPBhYQGrp7SATS9sSva 2Pf3/VXO5ribdfxwRKEJEs1YPurQnBcBXIyAZD4CqiJjS3tznp+S8HoCszTl1ipnivxQ Cj7pldRSwYzxxYhgIzo22HMJpwSDDO3gY2CI4egy7x2/OjJkcb47ZC4i6cLIvZIg8lQW 2GkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607508; x=1707212308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/QlyL8STz7vLqr76PxDM7CwYVIS28ulp926LAaYNGGI=; b=HS6Bg+QUpnmkWzqSVEwwYHv/9YkFH18oq3PPFO1/QYNh/9JxGAXCmt7ra3F8UQBX7p LCLfVUPS70eakSqujT498lsJP5Ua/ymZ67bwDOokaZfqWSreAINIrz6ZXUOJE5zfA9nk z3EEJAwbnABOLBU6Wkrntv6j6wphp2I5UOmeZYUsGR6YEIUiUZgggddqpyiHVVk/T40B gLiv8vXIaoOMat33c3LPasw4VvU9wWEgw4UmyFDAFHkHks+igq+gR9yj2FDWVooF0E04 g675D7cBpiENp4/A/4BpjlpCclJCqDeXHQwCHcE2RYXiAxGjGzCMuSP6xP3wj2CTUe5g 3e0Q== X-Gm-Message-State: AOJu0YwQAPwuf2cDTuCDt0ee/lKfsVy+hb299Gm+AUDdSJYTjJicGqxQ 2fch61DKAEXPn+9e+0g22hAf/rKuz+B/D0UF9GE5+zk8JcnpbVrVyJu3pGa37Jo= X-Google-Smtp-Source: AGHT+IHfaN7UvY/vSPQqkfKgFdNu53zzkQ0W0rJtAiN/x0drxl5i2SZ2RU5QbIL/iyWQ+R2WTvXWvw== X-Received: by 2002:a05:6402:3590:b0:55d:1592:8323 with SMTP id y16-20020a056402359000b0055d15928323mr5771063edc.3.1706607508001; Tue, 30 Jan 2024 01:38:28 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 2/6] arm64: dts: exynos: gs101: fix usi8 default mode Date: Tue, 30 Jan 2024 09:36:41 +0000 Message-ID: <20240130093812.1746512-3-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013830_089092_85898C36 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot loader has configured it by the time Linux runs and it has a different value at this stage. Since we want board DTS files to explicitly select the mode, we should set it to none here so as to ensure things don't work by accident and to make it clear that board DTS actually need to set the mode based on the configuration. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- v2: collect Reviewed-by: tags --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index aaac04df5e65..bc251e565be6 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -384,6 +384,7 @@ usi8: usi@109700c0 { <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; + samsung,mode = ; status = "disabled"; hsi2c_8: i2c@10970000 { From patchwork Tue Jan 30 09:36:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BE27C48285 for ; Tue, 30 Jan 2024 09:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ZQpmE760BQkd+VAhnHSEDWwTdKGD1m6UjZiNnSnkRo=; b=0Kt7wK0R2bfEyW KwIrFjEfwNucCUiu/ZJ7npiEFIC9l4ScfFfb+6S1WN3mN2wAPTUg/i0jRVBOWqJcLVSsiUzgLehGA uLJlGe9NSr/yU2EsMnT2MN62aldUJNrTPuKYMHnh61CKEzMx7CZOSstjHm8wg9fdqrdhMxe88ApOZ OOp/BqzJiGbB1dUCQILafreJCG1+qAcEW7j0qrpOH7IHxtYLPhzC51C6EmW0QymTVkjzopkmcLsm0 Y+Ozfo+KsJOuhXVgU8rXDX6BGYbZuagfQhEM4zKAkbDRxxCGbIkh3tZbLK1dXaEj2ZXjahRMBcv+P xr2FUTSjvgs16C/pjuGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZn-0000000FyLk-2Pky; Tue, 30 Jan 2024 09:38:43 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZa-0000000FyD6-0Utm for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:31 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-55eed368b0bso3880568a12.0 for ; Tue, 30 Jan 2024 01:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607508; x=1707212308; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RQzBQ4TASuzmiR4SqIUWePUdwbCtW+Gyj+OrWEuWMsY=; b=RiLxmfejm75St/h6RVVHJW29zzxxXzwb37fvNBD1FKHdptMQ5xxuqTNM59s7ucR5hD DsFvbeofaiZJuSwbTNLkBAAurL51bmFFDrS+uAKcQEeHS74kUjP+ztpIVJJ+M2jJEHdR coBcYiVeWBtENztBnKn7TgF1tE2qs/6MsKjbgjg0RsywhtnBiD1oQ3x/o8s+kXT1Qpl3 3lEZuXnJVK2e1U3Q5RdZfr8OQ3SIuAuvFn64CaE1gnW9s40O0lUEjr3TADH8cnMUDJZe T5jU3K/tYH32ZpU3xI+QBQbLeS7wAMSaz7q2jp4j45xuuTxRMC3mhTA0n7/KPTOzHNQ5 Wakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607508; x=1707212308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RQzBQ4TASuzmiR4SqIUWePUdwbCtW+Gyj+OrWEuWMsY=; b=bYzRcwZrjjvjJerbSKUqEyTek2cEEFCrUysytmGckZz9Zbl1J4DhsH0Cx73CZGga7h dmOl/XjaOZobxowShw59qwBvOpo4n2XuUAgHEInrToX0OMvpx6Bp2A3zYFunWmkuRKPx IgU8b+YmVoKTN2vSbuwuaMBMdnlMIQM9uwAtZOsiL1iUBwD7cUvglyRohSInNO8v7tEw jWXO268R7Rz2fCzFXrp2hlVonXA08erHmDS6aANUi7qDvlLeGktVHUDjlP6mWvn4uGts S6yrbK5h9MXjnnWm1Btr8wGlK7Ujj+59zNPYxI5qjXipxN8IyIt6BfUZtXoUyUFxEc0x Yyrw== X-Gm-Message-State: AOJu0YxTuz1lXl4RsWP5ceg4LtMIpFkU9ewmHNuGaWIyC48Kgqx0pnFU Buydw0BUV5rWKt+waA5OyA+hrGx0JaND7XNPRgFCxbXiGiYgjXMq9Hi/W5HEBUo= X-Google-Smtp-Source: AGHT+IFTTT2SbZmkNKnDsCZ1HUru53gHa0hRj5NRGgC3qt8zxFK1NYKcOop/xbSK8ch3lSKW2/Vf2g== X-Received: by 2002:a05:6402:14d1:b0:55d:43e0:93d9 with SMTP id f17-20020a05640214d100b0055d43e093d9mr777384edx.20.1706607508436; Tue, 30 Jan 2024 01:38:28 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 3/6] arm64: dts: exynos: gs101: use correct clocks for usi8 Date: Tue, 30 Jan 2024 09:36:42 +0000 Message-ID: <20240130093812.1746512-4-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013830_182204_3A9BCB14 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi8 instance here. For USI and I2C, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI8_USI_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and i2c drivers. Update the DTSI accordingly. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- v2: * add an empty line to commit message * collect Reviewed-by: Tested-by: tags --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index bc251e565be6..e5b665be2d62 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -380,7 +380,7 @@ usi8: usi@109700c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; @@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 { pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, - <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>; + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; status = "disabled"; }; From patchwork Tue Jan 30 09:36:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24814C46CD2 for ; Tue, 30 Jan 2024 09:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JtQulPQMHmBodCXRftXEsMwp+JNCfZy6kQgGfxKQ3ts=; b=4QPRulFkW3dPG+ CX2+HcOZ2SwV0Tn2cJvlIw9c5GQcVtk0B3ePmEtooZWlFo0zqgy6yJMHUzb1sg9Sma5Xwf4IvVJzl qq6n70+kW0793rGUu056QI3/Sd8dVRL52eE1es2xVmsTQw0Wt7RIr7C24RNm8EMgqA3PWT+Vf6qfS SOdKVOA/sNcbjP33dRiKo3gKCBABgHyrj7pulJT7fa9NSvfv5fnwDAeaSPO0YAzUvxicvVBcYFKWq a5ctK2fxSsCllOtQ1iyKuzJZvG31gCX8Bxe48BsAThci3BE+CIhIDUC3kYXjO/CzOtqC4rVH9FgG1 PiM10bAYOPx14qgyHQXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZo-0000000FyMK-2kXj; Tue, 30 Jan 2024 09:38:44 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZa-0000000FyD8-1VUg for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:32 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-55f2b0c5ae9so1364510a12.2 for ; Tue, 30 Jan 2024 01:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607509; x=1707212309; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TAQSA+kK9jYgf9iRBFCJiMz1V0l84ZXoobUQ8ktAm0o=; b=blQinxI9Yy7QB8O3M/xHkPHtJN3+0NB3sLx7G6rCPjGUC1oBAhGnyjb83CepNfAgge fNLy4UvaL6DTJHmC50UEPO0F1u05PRz3OcWHP5Z4+ywaqqqG7rqkAf3CJCPvKf1GNyNW kgq5wctki2m5b+LfvcBuH4sPKWrDkDl564l3iWQ5szSMVq43q4G+eUu4ZvdIr2DLEdQp orVZHnkht/W5wsrd1qvRNsLu9wCWGipM8TpWuIy5yvkaTXphAEj1+txysHhUnyJeGAf3 UJPK85G+OAP9iUpR8LX34AieYIvWY5c7qNy8w1FmUiTiLy7cz3X5cgChZbgWw2GlnHHZ 1J4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607509; x=1707212309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TAQSA+kK9jYgf9iRBFCJiMz1V0l84ZXoobUQ8ktAm0o=; b=vqS2prgmnex/MkF3+mHfjzspQUFhCocDFFEQh4ES6ftPnWv1ysg8uAYk3m4kILi5Xa WKg5TmR7+eejt63K71mMIdFuP97Wdsoasx6qAePQiHi7J69C8G6vO/+GtjZkbqLqGwwi ge6Wjylzpk2bIf5KOpnC78PEg+c+m2jwQa7rkIG37daC6/eguvIccPe4Bb3NzyQzYf38 pmQ86qgp/XX/RUdnIH+Wb4Wx/RdQ3yrV+2U/J5N2sS69M0XgWrmV5lx+XcX4aIsGgDBP MikL3x6gHkAUXoRRYafG9Pr+X+8aFSFJ16j9RaUZBJF3gGJjUa458b3YvwAh7k/D444I w1Uw== X-Gm-Message-State: AOJu0YyRVFw9F3+i9HWGG86L+aqGIbzKU5A9zsbGiM3eTnVx0m73ej0b 8ztDjluFqvl3zSbKgWUi742GCei8OMODXT//nD8GuSZ80wz8aU4fqZKHvffunW8= X-Google-Smtp-Source: AGHT+IF/m5mOArbCMzdGKzrOsjS0gVO6XRzIQWNVZ+HOi84zCHVgcM0i192IppW0vZqT+Xw+n90eTw== X-Received: by 2002:aa7:d7c4:0:b0:55f:aa:12a7 with SMTP id e4-20020aa7d7c4000000b0055f00aa12a7mr3320283eds.16.1706607508887; Tue, 30 Jan 2024 01:38:28 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 4/6] arm64: dts: exynos: gs101: use correct clocks for usi_uart Date: Tue, 30 Jan 2024 09:36:43 +0000 Message-ID: <20240130093812.1746512-5-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013830_429593_1313A5B2 X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi_uart instance here. For USI and UART, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI0_UART_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and uart drivers. Update the DTSI accordingly. Fixes: d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- v2: * fix a typo in and add an empty line to the commit message * collect Reviewed-by: Tested-by: tags --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index e5b665be2d62..f93e937d2726 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -410,7 +410,7 @@ usi_uart: usi@10a000c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x1020>; @@ -422,7 +422,7 @@ serial_0: serial@10a00000 { reg = <0x10a00000 0xc0>; interrupts = ; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "uart", "clk_uart_baud0"; samsung,uart-fifosize = <256>; From patchwork Tue Jan 30 09:36:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B598C47DDF for ; Tue, 30 Jan 2024 09:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whaaN7YaZUBVMBj+IPOmVoLEQLegc+Cnl+g+1JT/gfg=; b=Jr81cF85c937ra mOD82oWof2AWSkACJuGv08wYaxMEFPVdkalUxTTRInz079qvsNUjZC6CN1ScsT7vQ5jWYg/01DcmH zDmWwWw6GM95r6VPun567JYmnTf5ZJluBTgcFiwxussh4o2RP/b1yyevLWa/N5mtYVKXCIlbSUwiY h83Blo5pP7L2b3c4wKNJBXNNZQg2+0CP2PFSL6CnPa315HPgNnfBu47SvdIEPI0I2j3XlCl6MoULk kh6RAmJONlYP5e55MMXoJVCUT0DS6W9cEeTIs+y0yuNTNjMvanfVoiPSOh1T11onglhMRxRE+7yaL cdxFGd683SXCTqwpJz4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZr-0000000FyOI-0gUe; Tue, 30 Jan 2024 09:38:47 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZa-0000000FyDN-35CE for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:32 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-55efbaca48bso2753552a12.2 for ; Tue, 30 Jan 2024 01:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607509; x=1707212309; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KZk2SdLQMZocjryQ3lzHBmDN2CyWaX4eaN62+3uup3Y=; b=JU2skpmG7tBef4jV4AcfbCB7V9fvOgq88b6fPTJJA1c6IpqcDcl/Pltux7xj8JStWs 6WQeyJQEz3lkB4msas3QvoJyGl1k66jsCLDI3ORfvLh+QVhYeKHOQRUBMG7lwkXHyk/0 IPylUUwfU5OMwGQ4KcvVsdFGbZ4eUAaKZQjSrPKolHJEgmYM7zOT4YJthSG1BC5nPo+T BdIdrak7QZI4r9NjHmUt6E1kDxbY8+XepHy0dFqAhsbeOA2KtCfs6u92kTgz+Gb3wnIe 9/q/Pa6GnGQvNCyIWuezO7adHaJa7DTHvVmLFaMhach+8b2Igpmaz94GkLWDkFNeWG9t TFNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607509; x=1707212309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZk2SdLQMZocjryQ3lzHBmDN2CyWaX4eaN62+3uup3Y=; b=AeR5zGnd+QjgcDGvs9QyObakhqHX9cnYijwWWfO3ne00i7Y/M41DFHXVREJzn8HAVJ N7QxXqAzExw6/by9b5Q14r3Sy7CuAkQ4rZKy7GZWf6gKmGYgvL5q22wF4WxaCPLc5YD/ 9sHaGhhmcEVBp9KbLIOJtd9tlXUZslE3xLfDhkFw3VekdK9tBFTj04GWmlc8LP6ngF3X CajH+aXssYbVmiZs4T2oVJ+B72Hje6bPntbZB3Rz7z/Yeq+OkSLDPRf4vbFCJ0m6Cpvu 4cGb1SDWiX+XF5tnSYMdDayyNf3q8FRbCfBl21JICqw4zrb4ICJMg1Mo+l4U6BjK+6Xc +FDw== X-Gm-Message-State: AOJu0Yxb30J6TV8h2pPPGDyqeko/azdX0ZFswG+y7KWhj53cInkZk2+S y2zQSZ15LmwR1fJe1BAusq4cIeIaB6Ggssy7SVE2qIDHowBybiJsXoEv2vJae/c= X-Google-Smtp-Source: AGHT+IG7IkqQTnuQtM1dYTaeZBlJz5eiTlvg8bHz5Ow9hYGMah/7/h7i5oV1q8kNWB+W5AGHnzsrgQ== X-Received: by 2002:a05:6402:79a:b0:55f:2aa0:caf1 with SMTP id d26-20020a056402079a00b0055f2aa0caf1mr2164556edy.17.1706607509358; Tue, 30 Jan 2024 01:38:29 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential clocks as critical Date: Tue, 30 Jan 2024 09:36:44 +0000 Message-ID: <20240130093812.1746512-6-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013830_895510_AD4ACB06 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The peric0_top1_ipclk_0 and peric0_top1_pclk_0 are the clocks going to peric0/uart_usi, with pclk being the bus clock. Without pclk running, any bus access will hang. Unfortunately, in commit d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") the gs101 DT ended up specifying an incorrect pclk in the respective node and instead the two clocks here were marked as critical. We have fixed the gs101 DT and can therefore drop this incorrect work-around here, the uart driver will claim these clocks as needed. Note that this commit has the side-effect of causing earlycon to stop to work sometime into the boot for two reasons: * peric0_top1_ipclk_0 requires its parent gout_cmu_peric0_ip to be running, but because earlycon doesn't deal with clocks that parent will be disabled when none of the other drivers that actually deal with clocks correctly require it to be running and the real serial driver (which does deal with clocks) hasn't taken over yet * hand-over between earlycon and serial driver appears to be fragile and clocks get enabled and disabled a few times, which also causes register access to hang while earlycon is still active Nonetheless we shouldn't keep these clocks running unconditionally just for earlycon. Clocks should be disabled where possible. If earlycon is required in the future, e.g. for debug, this commit can simply be reverted (locally!). Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- v2: * collect Reviewed-by: tags --- drivers/clk/samsung/clk-gs101.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 61bb0dcf84ee..5c338ac9231c 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2982,20 +2982,18 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { "gout_peric0_peric0_top0_pclk_9", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP0_IPCLKPORT_PCLK_9, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0, "gout_peric0_peric0_top1_ipclk_0", "dout_peric0_usi0_uart", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_2, "gout_peric0_peric0_top1_ipclk_2", "dout_peric0_usi14_usi", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_2, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0, "gout_peric0_peric0_top1_pclk_0", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_2, "gout_peric0_peric0_top1_pclk_2", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_2, From patchwork Tue Jan 30 09:36:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13537116 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF028C46CD2 for ; Tue, 30 Jan 2024 09:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c5wONrZiGD2PI+ryhp7A5joYLrHiJ7bNvoOK0ev8DGo=; b=b9Jc8auSXVVFBt IMelU1w1W7zVXhGjqHlxSxM4ijIp/A3F/WGkN6EsricJa94nXfm3Du2GVS1rbsH5e5W+MEJrgBGDQ Jc8cOfgoO442uHQ6zu02kFfisKLjPTSs6wn4J6ZtO3hiAbgwVK9FJYnOAg9B+52Cp+KORtaxW36rV 2RRcYWTeVcM5+E5tvaNvyJyoIpPYOqr1Mk7ZLZa//rm4nJjbMqicQTx3BZ01xRGMj+ohN1QkYO7KO bY1Dys4GEeTwZxalMOOTl6EE4m3MLAp3zPOsUwIurCiroyd2I92o1jZe0jzEmsthVq9U6jIZjsr3h +C2lnmY6afDXf8uDFBhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZt-0000000FyPx-287a; Tue, 30 Jan 2024 09:38:49 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUkZb-0000000FyDs-2W82 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 09:38:33 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a3510d79ae9so399896866b.0 for ; Tue, 30 Jan 2024 01:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706607509; x=1707212309; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uBWUUUJCFS/9FtiLA45qfsAAKoxP08mkjZtpzwkxvTA=; b=vLoKx6DYqj/TufqAJ14wBVv/SUw1xMGQaS67zAyziP9Ept3ZsUsDD+CadQ9D9WOdaa Wj9Vsbo7Auu0Z2CTQurKRkA9Oc7/Fdi66tlREoGQYaekd0o/bZuewQecWn2GpvYU/wQT BXb7aUnAj15gKdirmYdG5fCnerydUWe8l1mwhADA78OkpYu03Of6njxV8mF4HETAECIU L3/sHbVZkkAEs+NKVpjRW2zt+QrXEFe+7K6/1g00B7x8xmbUlzHEx/xyfJGcvjGgIpBt R7kvF5hd0eWuJiG8RGkjnsNh2dqhuvELeh8SKKTme3iAK3eRHn87Q9DFDV/jZArarlLX SEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706607509; x=1707212309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uBWUUUJCFS/9FtiLA45qfsAAKoxP08mkjZtpzwkxvTA=; b=ksoG0iYbb2Vx5ZtyyjWkcHOvlS4a3uu3GwXAoMK9bNx5616Rg7Wql+1ez2j9gaviHt TAPelDmJACRRB5sGRj1Uc21GYLMYBhCDXaXJFL0+G345gCc0Q6HtYOqGYFyyU3+x1Ah2 +xVlQLzbhV3kyaUyx2LRWXrd2i9m5jWJGhIMEEW8B8s1h5MiTl+jxMwj3fWKH8CUofAo a0qrf+fWB307anxFRsY+5SMdC5xxlJtCfsUaLcx9a25BaDIwC7Zrdxou/3KU2zkD/GbC rrQ0boqlqcsSE9FGWqlJYCPIFQPiieSyRrEZm84vI5L9ve6pzb2Mr2ErTBtmXEtRq/lG 4KVg== X-Gm-Message-State: AOJu0YyH5Ys66DA5Dy56j+ylm2P5kRz/p1cFfZGKDe83U8fcdX7nIHSW +NCOwRqhBpnCl2aU4/ZihKiwkJvespUIaaEU+eC04cx1sRWCbmtM0LrpGsQqF0I= X-Google-Smtp-Source: AGHT+IH1eXkaUxJ4mPZQgQ/90RiMgygCUgMPXA+UyHwqbaMjV0BERiWtej6ZrUx8ktC9nwPMG1a92A== X-Received: by 2002:a17:906:3794:b0:a36:1adf:6900 with SMTP id n20-20020a170906379400b00a361adf6900mr922180ejc.45.1706607509757; Tue, 30 Jan 2024 01:38:29 -0800 (PST) Received: from puffmais.c.googlers.com.com (94.189.141.34.bc.googleusercontent.com. [34.141.189.94]) by smtp.gmail.com with ESMTPSA id q10-20020aa7cc0a000000b0055ef56f4575sm2281225edt.39.2024.01.30.01.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 01:38:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Andr=C3=A9?= =?utf-8?q?_Draszik?= Subject: [PATCH v2 6/6] arm64: dts: exynos: gs101: reorder hsi2c_8 pinctrl-* properties Date: Tue, 30 Jan 2024 09:36:45 +0000 Message-ID: <20240130093812.1746512-7-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240130093812.1746512-1-andre.draszik@linaro.org> References: <20240130093812.1746512-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_013831_829278_D2D42625 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The preferred order for these is pinctrl-0 pinctrl-names. Update the DTSI accordingly. Signed-off-by: André Draszik Suggested-by: Sam Protsenko --- v2: new patch in this series --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index f93e937d2726..195533fe04c6 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -394,8 +394,8 @@ hsi2c_8: i2c@10970000 { interrupts = ; #address-cells = <1>; #size-cells = <0>; - pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; + pinctrl-names = "default"; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk";