From patchwork Tue Jan 30 19:13:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13537876 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 000647AE51 for ; Tue, 30 Jan 2024 19:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642038; cv=none; b=p7BLCYwJR9hmSpYt9HJ/CQtTOACh+bgAV61+vwd4Bcza9ojdM7XBmgn7TiVYJZT87YeTk9Ovx18QW8lO0doYtQmDOTxInFEbYKMFYHalGOX2IVlTeNFysSbLd8YWx4kegDT1vTNW31WKhI8ee9qfKrjFAihVRX9bMg0KJuRlus8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642038; c=relaxed/simple; bh=3IxaLm2u6Z+ocCVTpENV0mujBYA/bNS90YYEOFeSy7w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=c+XAMbTlVkkDfcdfrs+ZEWf1A18xm80MpAKYU2DE6kZBIcZTOGjxUNCVvIrVw1+dRqwYxBZSsw0SCoMCn89uZq75Vx64QTCN5GKSVUW6S32xwpTBvE/LmmzcdADKoI7G2aF2bUbNC2zKtQlm72hw1SsCNfwsuzpuHktGn9EC4jw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cyL+mTfV; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cyL+mTfV" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-42a446cb1baso34192661cf.0 for ; Tue, 30 Jan 2024 11:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706642035; x=1707246835; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5uVhvahCJ9APPpCmy5D1hXtKdmZPLwpKL/UrI8WUL7s=; b=cyL+mTfVk8BKI9FDEMzMx5ebVwJPjE5o3DcpDTbOrtysPd1d+AzxLfpXUZWRplw8z5 WTFc0ul9g2BQ42nriLWIcqQSe4eLuYLiDZSS3vwtE8XHiAnLhE9LePvcj605Lq2Z5GOW yhmkyG4mez1gRkr9bhvLsr/a8bMPzqzHqyyqS/3NtaUSQ13JVFrotxIKLDwbgq3RIyYi H9zWX9YDlS3dkiWag19TEsAWBwe5s6f1w7E6D8HR16a5Tpl8WsRmwrZmPm8snByVcNwJ vJQIT5byVJwVSnG+6RlRurnBSBPEPsK2f4gRtmKvamxpG20KMs5UYXI9tGZh8EG4RRqN TTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706642035; x=1707246835; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5uVhvahCJ9APPpCmy5D1hXtKdmZPLwpKL/UrI8WUL7s=; b=cY5TW8A/Wc4lVCbmo8No+/oDxjpo/YKY9tP45Vsv8TJZ2u0aWPOpm+pXVBB1CZgd7X b+UC3/7cghCJ20Qi5HEvBeuYhzIX6ZHHDrixNfqOxHqXNXKrlHrNSE94bAz6GcM/EKrV u5zXndm11qtfg9aRxyQ5EkMbNSaVFcbelJRBBH8CUXu6dzxxklqLkxRmA+mHJO5CXoEy 6tnqDYSm9JSozWw5AAK6eNDI4fxsJJNXqCbxVcOMiOOoBTYDrsgyUo6Vt4GxIg9LRL9m qAwaeQAw1hbk3neXdobXAnYtRMIeyqtgLmU7LFl+W/80y7EYJZoBWmvsgr2cDCABbxqY a71A== X-Gm-Message-State: AOJu0Yx/Gc1vJJA+6OhVNEjtuJO+hC6spX5xmiAYAQyr2G9WUAhyvv4y VIB9CrLglDzJAq6REFBPa5rwJF+91ar0InbuQsiKA+ULzTbD/8NrVQKU8gU2Xg4= X-Google-Smtp-Source: AGHT+IGmgVzLo+EZI90vMiGjn99pv9SRu5/AMH0EueyHHskYgfua+Z5MRNWwXDCNG2BzYmcNbOyI8g== X-Received: by 2002:a05:622a:1a26:b0:42a:33fa:4365 with SMTP id f38-20020a05622a1a2600b0042a33fa4365mr9922692qtb.28.1706642035518; Tue, 30 Jan 2024 11:13:55 -0800 (PST) Received: from LOCLAP699.rst-01.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id ie7-20020a05622a698700b00427fabefe3bsm4716110qtb.52.2024.01.30.11.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 11:13:55 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 1/3] netdev: fix setting a uint8_t with l_get_le16 Date: Tue, 30 Jan 2024 11:13:50 -0800 Message-Id: <20240130191352.85852-1-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netdev.c b/src/netdev.c index 522baf7a..f62a97cf 100644 --- a/src/netdev.c +++ b/src/netdev.c @@ -4734,7 +4734,7 @@ static void netdev_unprot_disconnect_event(struct l_genl_msg *msg, uint16_t type; uint16_t len; const void *data; - uint8_t reason_code; + uint16_t reason_code; if (!netdev->connected) return; From patchwork Tue Jan 30 19:13:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13537877 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1062A7AE52 for ; Tue, 30 Jan 2024 19:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642039; cv=none; b=PNM2SpAIgpW1EPdil0/FYZ1hdTLBmlpDqR37InUD7N8ASjU4a3yAhbvROcY1DsQ7F2twTV3Fu7E/F/4EkpD4VNoYJDSb1cFZu4/YHmCLX8aqt3KtoPjkR6NdvoT62Ju4RaBTwdD6VsofbAK1pLx5TAy1Au0qCP5a0XMLeqeoCqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642039; c=relaxed/simple; bh=UZlEPLn8+yb1k9gpTegsEDpfbbF7+g9FEpRPW8V36D0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KtGeqaepOI+nPmc1dxZtXFAAJP04XQN6XLiagz5tSAEteomhsNSbXmC4ycawBthhp9T1rjdX4WLQXY/tA5TuRL4qSZy9RV+O5TDGNr7q4R7/0Bg2WqhenKJebLwpoinP1NBot7EqPiVK6Zf80JNQWKz16hBhJeASu6X3410BUe0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3sv8AGv; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3sv8AGv" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-42a8900bb93so43205371cf.1 for ; Tue, 30 Jan 2024 11:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706642037; x=1707246837; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E/b0QAd+SwK8v5sNS6/hPJzjxAZkGnROv0+O7vE8+aE=; b=K3sv8AGvsZrgTVKIaTdHcRiW/9vj2pb719v1alHBqvJ2GYBrNW158Dde833jHNq21H u3VFBrrmEOrtr10qNxy1ubTYj+Y/A105Yd+cVdt/52JplclZBCW94H+3cISjPWSEw00Z J/q3F2eNKLJtOIj3+w/ssrLIV3eb2kJij6OC/T+WPLduUan5PMKFdYwfkp2LHAwaLGpE 93iP8SIeAtK1FN+6rZEUeRIFcYjFoLLyT7gFnHRFmimmG4ptlSew5fuM2QyPcWxQjT88 iTuijsgsQOK7Nhj85wc13nKZl5RRPKpfCRrF/rkB6920ZtedjB8esEToiUue/WFDfjk1 kZjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706642037; x=1707246837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E/b0QAd+SwK8v5sNS6/hPJzjxAZkGnROv0+O7vE8+aE=; b=w7F1DSFy81ty6b/FQFiBTCpYmp6GZKFOtre/3Wui0vyyTNfRrYutaNVnuaGd4N/c4U q0zfrTk5yQwZEz1TqyoCdCh8jJn0yG01IiLZij+RikiaKou55DljwPvPWYKMixIOVpQr EprMq/f9AoAyy5p8hmu0cg7kIQG13INFwexLq6q+N9fsL/XbhUUsJdlU2pkI932lsMAq V6gxI0T64HVPknc/Q72HZwW/0oOmgY0qUFsXoNO/U0vmx2sMvLsKaDlyRSKAv+qXU6FX mPITiwRqTZWTwF4lpAP2xiGuqUCxqwG5P7HxnAlIMBXPp5NnEFteioymMxniX+Le02Af 5QRQ== X-Gm-Message-State: AOJu0Yy34PW5+m8FfUu6XXNP50OtqP75tqWCphBF28ICReq2nbzGDq8u DXB9kRF4kwXxe5rIf0agRxWSWX9JzyRi44WMICf0QBRGxG8YolAiZktSdiB05lQ= X-Google-Smtp-Source: AGHT+IFdt0mC5XAYGB3FnOOU2pFdLuKU85ummNO1wG8wT89ogwrnEnYomyFTHzFVx4H8y7i7p86llw== X-Received: by 2002:ac8:5716:0:b0:42a:b649:ffb1 with SMTP id 22-20020ac85716000000b0042ab649ffb1mr2373043qtw.14.1706642036481; Tue, 30 Jan 2024 11:13:56 -0800 (PST) Received: from LOCLAP699.rst-01.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id ie7-20020a05622a698700b00427fabefe3bsm4716110qtb.52.2024.01.30.11.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 11:13:56 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 2/3] netdev: make unprotected disconnect debug log more clear Date: Tue, 30 Jan 2024 11:13:51 -0800 Message-Id: <20240130191352.85852-2-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240130191352.85852-1-prestwoj@gmail.com> References: <20240130191352.85852-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The debug log was just saying "disconnect event" but we should distinguish between unprotected and protected events. --- src/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/netdev.c b/src/netdev.c index f62a97cf..2b3925dc 100644 --- a/src/netdev.c +++ b/src/netdev.c @@ -4762,7 +4762,8 @@ static void netdev_unprot_disconnect_event(struct l_genl_msg *msg, reason_code = l_get_le16(mmpdu_body(hdr)); - l_info("disconnect event, src="MAC" dest="MAC" bssid="MAC" reason=%u", + l_info("unprotected disconnect event, src="MAC" dest="MAC + " bssid="MAC" reason=%u", MAC_STR(hdr->address_2), MAC_STR(hdr->address_1), MAC_STR(hdr->address_3), reason_code); From patchwork Tue Jan 30 19:13:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13537878 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E709B7AE51 for ; Tue, 30 Jan 2024 19:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642040; cv=none; b=YqrOQ2QpQDf/KBViPvdeOa6rG1n6jBVpa54Eb9oxWggk2QENTYnJlsU3ptYtHJaCXWuI8Teu5oROQ/eSW63ILm8Uk7qfPIdUA/1urV35MELZfMJYjqKweFUaPSiR5yXBXU88aCQdqoNXLpc5/gSw6GCVv/oCZH2buryIr03Rm54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706642040; c=relaxed/simple; bh=6FsYX5KHNRoQfEX4V29Y4TDRa6uJ2CLUjzATSgxG664=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=e3/JJLKULB3wXfUEcY6fi3M7vTTx2A/bRpgshjP2LvVVUEIfHudEHtbcEjklaezEBw1fwFO5j5DqBLls9rr2X+SFsPx0uskHMaxN5x6cX4K4gX+PBHzBnmXPRV1e6TY4meRDE6/SFOexIiweQIgij5svckT1ygsBcrqwDMs57cg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mFvi+bvh; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mFvi+bvh" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6e13cfc0b2fso632485a34.2 for ; Tue, 30 Jan 2024 11:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706642037; x=1707246837; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ml3VHPJO2cHtZQNGsrjvaqiHyx9RM3d7ziJFuj3XSlU=; b=mFvi+bvhf6bEZAHvdK598ZiXG4Q3wiKXVTem+qId0wzu4b+nLjtlygHxpuhOrYusbj 4WSRECUTeENUSR1Yb1EuFqN2JtaNKzf/gqC0XPfD02jZNiUCmZnT/YRP2XbnlINgLOpB 44TZL6jwLWjWaYlhap9WvAQmJ+nesjZEw3PpFPIpMMXP3VGqWsBOYP0aVLqcAxqk9YaL loP6CfysAVzs/1INJHKifCvETd46KqxEUY6su1B2G7sWPNzSKwzIPtSZYCYJ5miBBDR2 5PCArRCmDpuMguLOkhCB0XO9VCFKaKfD3Q7A70nh4Ht8BSm9yC821zJVe7dQ8jtZZBpK PDeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706642037; x=1707246837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ml3VHPJO2cHtZQNGsrjvaqiHyx9RM3d7ziJFuj3XSlU=; b=TX8j0FWRQSua68wNykW+TEuao6HKGnHfP7jnbaBLlRJp2I+5NRbDOFsD46xUwMSYjV GgeA4KYUFS2fHi4GbhULMWvn2pOKsuktQbyK45pT8NqqR9O9a8BBhYdWF8A5e6lEiILd Bfk8xUm7I2UCZxquN9fyTuxVGDUowhn5Tqyl1K83CR6ik4nR2ks1X+GdOfRJhqtpqbYv IJqioatXT4vyrCUp24SF6mQ93VzN+zgSUZyySlwtoywePXQnSihCn0nFDswtJ30jo0yl WHsHRBftHCwWl3qiI5mhbgmVcIOa4YZw3R0xSyOsr6m8/IY8KEkzqgd2aQ3IEfJ3mZpH S6qg== X-Gm-Message-State: AOJu0YzfbCS3KDv9ocZ6XLQreiU3CiFJmr0k4G6A9ZbvRt9LCwP6lL1i QoKj9TtBztfwfztQbrx8yxB0TDuJYC/qwQd5eRtN22sUffEqhFBEZJ3EGJX/nnM= X-Google-Smtp-Source: AGHT+IHDtLYghACeF+k1mAk6WgrjskAPOdIwh2w1zzMvVMNir6B6/mLZOI3HGxGlbSlXId8oZNMBww== X-Received: by 2002:a9d:664b:0:b0:6e0:ead6:5206 with SMTP id q11-20020a9d664b000000b006e0ead65206mr8506350otm.29.1706642037541; Tue, 30 Jan 2024 11:13:57 -0800 (PST) Received: from LOCLAP699.rst-01.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id ie7-20020a05622a698700b00427fabefe3bsm4716110qtb.52.2024.01.30.11.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 11:13:57 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 3/3] station: reverse roam scan results for sorted known frequencies Date: Tue, 30 Jan 2024 11:13:52 -0800 Message-Id: <20240130191352.85852-3-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240130191352.85852-1-prestwoj@gmail.com> References: <20240130191352.85852-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The known frequency list is now a sorted list and the roam scan results were not complying with this new requirement. The fix is easy though since the iteration order of the scan results does not matter (the roam candidates are inserted by rank). To fix the known frequencies order we can simply reverse the scan results list before iterating it. --- src/station.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/station.c b/src/station.c index 8a5f4e18..ea505ca2 100644 --- a/src/station.c +++ b/src/station.c @@ -2636,6 +2636,12 @@ static bool station_roam_scan_notify(int err, struct l_queue *bss_list, util_address_to_string(current_bss->addr), util_ssid_to_utf8(current_bss->ssid_len, current_bss->ssid)); + /* + * Reverse now so the known frequency list gets updated in the correct + * order (via network_bss_update). + */ + l_queue_reverse(bss_list); + while ((bss = l_queue_pop_head(bss_list))) { double rank; uint32_t kbps100 = DIV_ROUND_CLOSEST(bss->data_rate, 100000);