From patchwork Wed Jan 31 16:25:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13539646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A14C47258 for ; Wed, 31 Jan 2024 16:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A624F6B0093; Wed, 31 Jan 2024 11:25:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 928E46B0098; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 775086B0095; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C5B28D0007 for ; Wed, 31 Jan 2024 11:25:52 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21E5DC01F0 for ; Wed, 31 Jan 2024 16:25:52 +0000 (UTC) X-FDA: 81740132544.17.DD0215A Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf12.hostedemail.com (Postfix) with ESMTP id 70BDF40006 for ; Wed, 31 Jan 2024 16:25:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=EB06hVwq; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf12.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706718349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yt2CHrUIXOlD7LqPZ+/R1tzDg+XB4/CnMmFyvBmU2Ok=; b=2Ng1lXKFR9Z7Pzxs2U5B53hWzszofrJjEPBxNIVCILkLjWVygpoICMTQXhp4eLMOTUqTi/ cQDwaf3okeKXWYnEbcFW3N2QdTXYWqoRmqpDQO9wc0+08708iMbLE8A2fJIOyMBNu8RtU8 SWnDwlR6s6U5JW9kcvTtOqBajNQKpnc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=EB06hVwq; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf12.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706718349; a=rsa-sha256; cv=none; b=KO/pq5tFBOsEcsB8tV1FVaicC8Gd+nQsWjS4EwxdYPEtA3cfdBk1KxwAka9uSPNb/mrd+n PJw0vUsETlvSBBdqg3c9FdR1MF3qQQz8zMloBPg6vn1HRd8UZAHRY8JyVOmxDDCrKhWYEt +Vrdj/1rTsIXqiu5RoG40Y81Q2Ftdr0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706718348; bh=CfmY1KnEab9DsMrJbyvT5LgUiqxfD1jYSIdakS3IZw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EB06hVwqH30Biu+iJCPUcv/terkIISNlE4G2KLYR9OPO6YHERtB+CQuC+sUJ11GiS qanrhIUz9PaLQE+1Sfk0euf5aZEOnEh0ZmU+8GuZPFIs/dUfEpFpY4aR3hMNoQ0M4K YjYn8N+vE1erhhgi+WRevsbvvXyXBUbecJrhzvF+suEsrIh0Is3m8q7H9EX/5wMjZ9 p0E0sTMQLq4kN8hV//trJ3mjwoImjOLdvL5YGOOOSyKl//9q9lix/RG3EaWChntvIr cfkBAkZwRIFFgomMisFAqXV18H2U/8TgTzIZaM6+spiKRIWy+N1609kejZ5IMCInoX m8KJF4ssXA/MQ== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TQ6ph0mWTzVnx; Wed, 31 Jan 2024 11:25:48 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , dm-devel@lists.linux.dev, Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC PATCH v3 1/4] dm: Treat alloc_dax failure as non-fatal Date: Wed, 31 Jan 2024 11:25:30 -0500 Message-Id: <20240131162533.247710-2-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 70BDF40006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rjn39jzwfr9rndhkd5mp9yeu3qes6fp8 X-HE-Tag: 1706718349-662979 X-HE-Meta: U2FsdGVkX1+Tn8f/EJHg8u2xvk7bjqlBvDV+0oR7cx3eRjNpJ9sniaaAGx65uVHU1GNiz21xGEPDzkOJj7+HxW5+ZayBcqqBHSSeXgMsLCR8ImlF7Qzc8H0ggfOJv4B4UZaSASvtdoj1SaV/ONH8C4fkb8S5YnREDq7SVrzawhZU29qx36EeDg+wHYDj4cfW3Y5l576Ge4hmGHAQXNwAeQbbJQ7m1jVq2sueZLiLQRd6u/qupTdhscr+HMOyAuvySKzrDOXvxspmFElUIcp8lkojD/cLaZeCQkS5d0uSvAnoA4aDU2cSF3LLHmf9rIKMxo1vq6GMXgFVZ3WFo1i2soGcB2dJUO6xk0PxSFvZqbhJMUMV0wlZVoKI4F5yktUV92yZXv1TistMUXgYK5WkiX/PRJztAdX336W1R/RyM6OpfldEYwV/F6TusBbZ5wrpRWo7o+jLN9ZT0aCn+TO9dZUjSZ6VHMQ4Rr2rttvShzLNrrbjDJWBcdCpwtmBfLNwxtYhjKPCyrxPPCWBQBhxcQ+LTKFJ8TnGacoYCjqcoXp7Ffp+bBAXMwqs6bNZ7IjL+Lt6Q/YjcuF+2S84rSUZgunYir/ZPAzoGQfLDPk13qubFzLp75dyk/fssWEH75eQlAWW88XDjd3XcCfzlbmTljXiKrVEC0i7iNP0Ot6LdfubYPi/yYUKXjnB+bVIIVTgRnS2KADDihgdmTzoCBl0AWnfzOIuYARfILg660SKZE0g/YuGR3XlZGgHc4YAA+kAmLGkSYFJMuw/McGZfyXxPMFEMIzajlQF1sL825doOX6U4kGqIezHEEs+cA4DOwdc1kCWkEsWEI7bCpk9ni7tLaypf1oRnuUOHSWiO8F2TkQ9glYXHVolsOa5Yh9yM14SWQNcH7xZcr3WLoeRS9n8SjwQeUyjbwKq8uJaK49Ct8TlR3rtpgmHDS8w8u78q4Uu4Fdu1gOXvTRYCw3LpHp UsgUkyHb 3fMUL0Dj5r6XX9Sk+2ngO/q/9E9c6TS3wFcy/hhq7l+T9BIIUuCwAXz9C0Q6nKQ52tj21LYmHcwWXxIYqwn04u7tTaagQvPW5X98vAOOQfCbfFztyYNshthL243wCnC9/kMm5ffF5RgREG3vK67dGIbn+8kPSwobXzWPymFIYays12nuCO9Wp/DCHCaOVcF8nZkYrLi69+Ngo0d4ryhme+X0ErGLPUUu9zome+WcAdoHhmM5Hl5W0OSY7c7Vu2EXJaVV3b08LMtHlUysHq6bl6mJ3cnwd4NDJQY+BQJcmzs8007UoG826T17gFN3O416I5sD+EVY5oun/5VPhvmZCugUlMMlwFpNAScx123Y9xoTeRUDXimeV5X3PEy/Fcqa/G4luydqsMcAidpzNhmRS058SnnKgj6ZL0+Hqoy8Aimc2Ggt3kiB9Q4i4SKWM0i7tV5EqPsICQiLKoFpZxebmbClZ2+Otszq2sHD+XH7QzcmMh+IlgLPwMnhNkaOxU94jOqzwEhgRz64Aiw7VMHQVn2PVuvjWJhTF/vQ11+jn8gioET85hmW0ecrDk9L5uAxW6bGQCw2qhUoaqCmR++JjrgmEXv8sM/RyJ3kLmkay2WOID3RzsqVK6awAW6S9iXFW9YvoYpx0p3dJU7A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In preparation for checking whether the architecture has data cache aliasing within alloc_dax(), modify the error handling of dm alloc_dev() to treat alloc_dax() failure as non-fatal. Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Suggested-by: Dan Williams Signed-off-by: Mathieu Desnoyers Cc: Alasdair Kergon Cc: Mike Snitzer Cc: Mikulas Patocka Cc: dm-devel@lists.linux.dev Cc: Andrew Morton Cc: Linus Torvalds Cc: linux-mm@kvack.org Cc: linux-arch@vger.kernel.org Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: nvdimm@lists.linux.dev Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org --- drivers/md/dm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 23c32cd1f1d8..f90743a94da9 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2126,12 +2126,12 @@ static struct mapped_device *alloc_dev(int minor) md->dax_dev = alloc_dax(md, &dm_dax_ops); if (IS_ERR(md->dax_dev)) { md->dax_dev = NULL; - goto bad; + } else { + set_dax_nocache(md->dax_dev); + set_dax_nomc(md->dax_dev); + if (dax_add_host(md->dax_dev, md->disk)) + goto bad; } - set_dax_nocache(md->dax_dev); - set_dax_nomc(md->dax_dev); - if (dax_add_host(md->dax_dev, md->disk)) - goto bad; } format_dev_t(md->name, MKDEV(_major, minor)); From patchwork Wed Jan 31 16:25:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13539643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD62C47258 for ; Wed, 31 Jan 2024 16:25:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D699F6B007D; Wed, 31 Jan 2024 11:25:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D18B28D0001; Wed, 31 Jan 2024 11:25:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBC336B0095; Wed, 31 Jan 2024 11:25:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A7A546B007D for ; Wed, 31 Jan 2024 11:25:51 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 567EF14060A for ; Wed, 31 Jan 2024 16:25:51 +0000 (UTC) X-FDA: 81740132502.24.BC18B4D Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf06.hostedemail.com (Postfix) with ESMTP id BB89118000D for ; Wed, 31 Jan 2024 16:25:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=tPFOoGUC; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706718349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6wJ6k+XVGp97QkRoYqu73O7Askxr2TglC0OY8izxSN4=; b=oOjbOxCaxZ5PJ5bL+v/p0MyC8VraIDlqFYexDXxfnqA20EuyHbmUd2g8cpF0SfBOEJX292 //FozHu6bCXOZPBsdyK4KjwufFbw3veKhYEx2hp8yTW/M+a4WmDw+zhSPAC51Zuyo5ZTTN xuIiivEkv1PYWN/Ezi51Dz4S5H28u4g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706718349; a=rsa-sha256; cv=none; b=T6tZKCXOckvcutK+ETViN0WAsl+HVHkF+2aKhjcd9TuT11MyOg+82FwumhNUjU47czdibU dlEADm2toMei6yDRxIF+54GgZY/gGqZqEs6mCF6T82koP9iBf7Oy47aK7+XyjTZCOKssJT Vnbmu+nu6zRz2Uu3LqsVF/QVjY4ZHmM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=tPFOoGUC; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706718348; bh=QiUQHVE9OuD7A7XRfq4nHC+crkQnZ8+IZ0u7lnayc8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tPFOoGUCQpG6nbDTeV4EO+3l6CQr96GDzwrgBAkFN3BBXvvuVDa7KEgUQVhRO+9UJ OGBfhp6+IHWdIbnDgzb7rp6f5NoCAVT/MC/jdSqh/SbWXQai0GciSCZ5jGzJAZJFn9 zdbBdntL/XW+dTsVqtKTP0pFMFrIkzMRY2EjvD3nxnNlRo8+GV97CGNQTyzuR04/Bv DnVLu22IZhi/FCEikncgvc+r9uRAQtDTq6OOUCYLLFl+SPLOZdSfK/om2/oxbsUHtn heRyE9JrDmR4Al+5f3ZW4R/iVTnsP1/2fKc1z18/UCX+ap0fXxxnWGMUegUer3Cath BZBJCCPLX8AoA== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TQ6ph3nMyzVny; Wed, 31 Jan 2024 11:25:48 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@lists.linux.dev Subject: [RFC PATCH v3 2/4] dax: Check for data cache aliasing at runtime Date: Wed, 31 Jan 2024 11:25:31 -0500 Message-Id: <20240131162533.247710-3-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Stat-Signature: mpyd5yuc5ufmtjewyzefmxruxg6knyfs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BB89118000D X-Rspam-User: X-HE-Tag: 1706718349-292008 X-HE-Meta: U2FsdGVkX1++mqR6014KTBHKUPZNsvzWL6F77dJHBgYys9xf8Q3iBO1fK6ZuLahDv+0XEV+zdGY942Ozelpp/ZrnogzvCXbjbHfG8AvHBTiuiOJ4kO8r9GTuYEFaBcwU06NlqXK923B2uRiKYYjNTocimXc6aX15vF1GLwbov5ZKml5GCZZz2G8tdO6LA0/s6cFBD3DZ3kKqTHUx+QnPL5cqa14yhzoqu77hq6YAanrc0UH2ripgeng8pl0ElkjNlH9etYxTuQbz+5EbnWm7pG/UMket3KnzfdZooKvv3WDpfdpjF69P4VOHdRleB/2bwP7oZnN0KQnV6NyD/MpgDECvfNtJYVYM9oXsd/BNucwjE/ooHLMyTOYC6BXhcr8Cdu8LktiTZ3uWBFEMQnesZhFejoyUfTOZaNdBSh3Ciiy6do/Ni+md9hHD4SXPvu1rAqOVeQ662d+wxizpJfhmGTYx4/ffQ0LD5hzcSK/az5eMGGlDoi3DOL6I0BsHS4/m4F/Zwp5y1SDi+MnPCkmVe/3dOYhoHZE+W7pZkhe0qEnHJg5+JmVEkCa1a2vLg0OdhboN4ZErksF1O2Az4Rl77J/mQE5CLSElGOgNMSd/yJmLsx7iFcsk0b6q6aUaqL06Q2TMILXJq9GhYAFn5B+KLlrH9oZt1yx1t3Gx2ElLFsZZhptPk9j59yEYk90PdneY6SyZsUm11LfDzcyx5VHGWM1E82njUNCNDu6GjN8CMH3LMn9C2Zz8Fs9Kk5NOCfHJiAonhZH67msi3P8YHLDt7A8oadV7Zzj2/RbtNhHlldoVATfeZvS6C8w9FE22OJQVR1EeF+E+l/OXIS8TJYEzGc+EfYQBOdiv/2EzCqem1wSFGwq1E2H4wkb3DtSMLjQ+i20lyqgKmwuopbQU6Xd3kL66uXboAQwfmZbsDuD3viit7bY97pMJakpH1rqHPeR8Dpj5qBUNBFElk5I/+71 GMEwLIg4 Rvr5wmewnt8kTtH2URLQsgPb8mca+DpwY03S3lSq1/YX+ZY7PzvXwmFurLZG7BCuOIKiIuRMzNjGuSlfFfAo0QgHCa+vz8QGNh5qP7QUEp5NpoTeJcRtBEBNRRRCRktCEXXhz1X2Acdqj9BVxawkocekfNaVKR5CZ9i3Y4B7/iSZQ/e9tGc57PQUdZA+5UJnPTrKHizwy/3p8GU90HH0BO2jGUZRYG1BSBIylGVz2kyPil1N6c4yoRNGuB6PyPbARy+q7ceTgBckfDV6NzasWfBcS9SJe+FdTt3FcsrPZodeyrU924e7MCEpKZVy01VjFwEXDmn4jjAHB/nWYsaDcO+GixVKI4Lm/iRGaRhp3wB693S8lDp5pDskmJXlFCGZCvEJii3vZ1F5SwHf2lFUHfdTQbm1nnND4cXlCSaU4v9dfWZbmvnoUcr+eWra8gRByeO8XTcNRTjI/ZKzXp/jIo629m7vIEdQroMCf2z7bxWGPYlVbtZvAHGk6OubvYoYzQrbJMu24erjiJckrYZXNyIsdrmJ02JnOmBoowuVdbHCyOk5LiRZNZdtnDqJoEt1Zpu1X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Replace the following fs/Kconfig:FS_DAX dependency: depends on !(ARM || MIPS || SPARC) By a runtime check within alloc_dax(). This is done in preparation for its use by each filesystem supporting the "dax" mount option to validate whether DAX is indeed supported. This is done in preparation for using cpu_dcache_is_aliasing() in a following change which will properly support architectures which detect data cache aliasing at runtime. Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Signed-off-by: Mathieu Desnoyers Cc: Andrew Morton Cc: Linus Torvalds Cc: linux-mm@kvack.org Cc: linux-arch@vger.kernel.org Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: nvdimm@lists.linux.dev Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: dm-devel@lists.linux.dev Signed-off-by: Dan Williams --- drivers/dax/super.c | 6 ++++++ fs/Kconfig | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index 0da9232ea175..e9f397b8a5a3 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -445,6 +445,12 @@ struct dax_device *alloc_dax(void *private, const struct dax_operations *ops) dev_t devt; int minor; + /* Unavailable on architectures with virtually aliased data caches. */ + if (IS_ENABLED(CONFIG_ARM) || + IS_ENABLED(CONFIG_MIPS) || + IS_ENABLED(CONFIG_SPARC)) + return NULL; + if (WARN_ON_ONCE(ops && !ops->zero_page_range)) return ERR_PTR(-EINVAL); diff --git a/fs/Kconfig b/fs/Kconfig index 42837617a55b..e5efdb3b276b 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -56,7 +56,6 @@ endif # BLOCK config FS_DAX bool "File system based Direct Access (DAX) support" depends on MMU - depends on !(ARM || MIPS || SPARC) depends on ZONE_DEVICE || FS_DAX_LIMITED select FS_IOMAP select DAX From patchwork Wed Jan 31 16:25:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13539644 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03C3C47DB3 for ; Wed, 31 Jan 2024 16:25:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ABA98D0006; Wed, 31 Jan 2024 11:25:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 358598D0001; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15B936B0096; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0016B6B0093 for ; Wed, 31 Jan 2024 11:25:51 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C0B15A1452 for ; Wed, 31 Jan 2024 16:25:51 +0000 (UTC) X-FDA: 81740132502.21.B2C879E Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf16.hostedemail.com (Postfix) with ESMTP id DF4D5180018 for ; Wed, 31 Jan 2024 16:25:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=PHH5lEXE; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf16.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706718350; a=rsa-sha256; cv=none; b=e9RkzOd5P7ImqCTWEER2CSZebMSx8nprErAj3EM8BIf8ukr2L6dv1RUABhInpqipxz/5M2 2lLM/M8S7dQW4b1F/jG/FJRM2r2mgrItlSgXxU8Vtg0ed86mgrVAeOev8aGnWmiXsjRTLQ bDeC+jQo5fa5VdixkBSS7C42S8zjc70= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=PHH5lEXE; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf16.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706718350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OnWtP0uuB+8d8nf/j64w1Fep+7xiqVZWMN4dGaOqfLc=; b=c3IR1Ga8R7yzk/P129tSPT7E+USgUpFYeroTvgarvQh2cX0qg3BbkyIwk5tAp3GfEHRDDL tJ0/EDvYbbw3XDXM32mDXNDszgKnHzRn6om5MVwkz7dGuRlnqnsGEgyA7QnRzBVClfmM6e zezsK0NF8nWq2tP8Qyic4nr1EuK5TmA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706718349; bh=hx2BzTstie5hVA+TCGyykJTnAt4QlbGvKlxJtOj/jIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PHH5lEXENSjaIFC0LHBtbAHRLo6wsAqhZZtrptlYtkGt4ThnuU8537yXTXYijMu2J WYcjF34WOyPRGkR9s3pLsQ6e735CYJBVTcgCtCSmflUcuBpb22gglQxGhdTx/G71Et elxwYMa+dzcmnSBJaPUnwUQkdGeuD974kNHOoQ3/kKODmcK/MAh7/Oym86pv08CAL8 PJJXdufLeKMkO5WNiSYbn7iT3NuxxjD17ujEbSxjot8SoAslyptVXr79SYWWwxxJPK mxrrUijObDxLZgVC53jTuSrtyPlmGNj6rU0oefgJb9Uo/n4UhWwe4CGNvtVUIw6NVe m3nsL3dsvlJpw== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TQ6ph6frjzVp0; Wed, 31 Jan 2024 11:25:48 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev Subject: [RFC PATCH v3 3/4] Introduce cpu_dcache_is_aliasing() across all architectures Date: Wed, 31 Jan 2024 11:25:32 -0500 Message-Id: <20240131162533.247710-4-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DF4D5180018 X-Stat-Signature: rt36tw5qze3mehmuk14xkyii7u7tumk3 X-HE-Tag: 1706718349-993210 X-HE-Meta: U2FsdGVkX18ggiCF8Tz9ani5DUJYVIxZoxFm03cSbArJW9SXXp3CIPHtqRKpBntr33Y/M9KFv5uZpwLDzOVaA3/uqLsNGvld0ImQNT6ljG4HrF6NjclzEy9wSjr2bGZUYeW1WYIeG33GbzZ72LE82xws2iasPfVA4FyCywgcARyzEjbYKRp2Am1EBsZQjo7LJLfkb958BMQkAZFz1mLkqvQfS+j3cysTvNoqRL4D7wudqRhTjDOdgi3oWqtigxr4UXuwT+5InOjYQs0t/TcviUJOdWpwjP/GutSNRUPFewv0yST6qBc5cZ8nsw/6SKllrPSf08Ot8/nYgirahRHVKQIKglo8mRAH7uwgtjStfLYV+Um/XqWrFBqbPBSzEy+uW0SLcrylXplMFZy0muy7wRQ+3c3FHCVjeEfk2tUUH3a2l4X63500c2TWzdB7jV6O6mTRcysBLKGLcZozDdHrlpcDMuGNza4ecHl36mzeTn8qzcudInMFFXtjmcyOkZjqxGTV12B+Qp60qGip07zsuYXwwV/MraR1hmk/b62onIQF2jc+MpUkl+1DqfwrrE8tOD2tUiLIitdazvV4042Xi/0+u3fPaRuwkQdOi96tM7VU1asob3NnkFmNMtsyr6689q9UFjH5m8HO6QGJPq+BDC/1F7cnI22F4Ztfq7mo4/R4tWaDWuAsRXO11pLpebsDgsjX9vh8nqKAOz+kgc/FPFndeQrOJMiKRerMIcr+NcE9mYh1nANMjVAhRf8LhOgs2978UiYrvvg+Th1YdRVCX+9kkO5JeAFPQWPnM5XfRiO0yZYH1Ygcqrm5hz6lIFxFnwNunwu3Z2Wy0NIt4yRgphQpOkuVEumZ3r/yWVGW8hAe8aQHJ9qllI+6hwpq9jd9QaZCcBc38MOe393caKTAqbLwOES6dEqrRVDKis8Q1RcfCMvcbSZU0l+qFhSbBE8AROKmkHeFjccQd21PhTw EHf4AF57 gfjiGszVcIFY5oKZAAir3NszRGyabB3/sqpGXRVBY9b4WxDYxKLPDfnVoHBa3mZ2H1+5XHrN5u8K2pegKGF/ogjWf/OHKF5R2Hoj1wK+3BPatB7E0sOMrmBM9h1fuDYeIEzJpcb6yJ3PAM+kXn/zJMABgUndSgcxnIFUx/wG6xuLFUCIGUse2CDsXn99Ku4G/91EVYOmZBMEFIuyGXts3sp1cdhP6JUpNdFn3BwECnMHvMM+Bdyd+PCRbVy9J8wBrOum40XFCeghqxR8NkJewW6dJShnHVuPEsfsFX1Qjeh+ocIzB+ibTlPSZ4rp4bCaRJZ5DJrX8Ha/9uSvtPuW0fddJrV1cBvk0Ab61ErFgDwDkvBWuh7r7peTXb5KxAcx+w1B/RDpNPlfSY37maqJJv78TkBNbMKrZ7/OM2WMuGC4CsX4rXqYqPgBLjVEsPrhlo2UVqWKzE/lDzD4eoRuYLBZFWnN6vbGHca4ONGjLYE/p/+QtogOpdMKNWLHxNW1qGuwSjDu7MOcsGIpTIxoUwDJN01BCQ8W2IKQTGXHMj1qsoR1sEZExBGTbn50K3WGNtzkW1Mqdvdjr+3cryxGJ8yIJq8FsYwZ1O86YmtHzjTVCxHu0xEQqLqcoyWFvKq6rcQjEkyuBg/VS+5hn/CD/ryMv6M4+N6AADPNZqJStCw5SOx9mjFWvuKb+p4TdycgQh8oodZFDuWLJk2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Introduce a generic way to query whether the data cache is virtually aliased on all architectures. Its purpose is to ensure that subsystems which are incompatible with virtually aliased data caches (e.g. FS_DAX) can reliably query this. For data cache aliasing, there are three scenarios dependending on the architecture. Here is a breakdown based on my understanding: A) The data cache is always aliasing: * arc * csky * m68k (note: shared memory mappings are incoherent ? SHMLBA is missing there.) * sh * parisc B) The data cache aliasing is statically known or depends on querying CPU state at runtime: * arm (cache_is_vivt() || cache_is_vipt_aliasing()) * mips (cpu_has_dc_aliases) * nios2 (NIOS2_DCACHE_SIZE > PAGE_SIZE) * sparc32 (vac_cache_size > PAGE_SIZE) * sparc64 (L1DCACHE_SIZE > PAGE_SIZE) * xtensa (DCACHE_WAY_SIZE > PAGE_SIZE) C) The data cache is never aliasing: * alpha * arm64 (aarch64) * hexagon * loongarch (but with incoherent write buffers, which are disabled since commit d23b7795 ("LoongArch: Change SHMLBA from SZ_64K to PAGE_SIZE")) * microblaze * openrisc * powerpc * riscv * s390 * um * x86 Require architectures in A) and B) to select ARCH_HAS_CPU_CACHE_ALIASING and implement "cpu_dcache_is_aliasing()". Architectures in C) don't select ARCH_HAS_CPU_CACHE_ALIASING, and thus cpu_dcache_is_aliasing() simply evaluates to "false". Note that this leaves "cpu_icache_is_aliasing()" to be implemented as future work. This would be useful to gate features like XIP on architectures which have aliasing CPU dcache-icache but not CPU dcache-dcache. Use "cpu_dcache" and "cpu_cache" rather than just "dcache" and "cache" to clarify that we really mean "CPU data cache" and "CPU cache" to eliminate any possible confusion with VFS "dentry cache" and "page cache". Link: https://lore.kernel.org/lkml/20030910210416.GA24258@mail.jlokier.co.uk/ Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Signed-off-by: Mathieu Desnoyers Cc: Andrew Morton Cc: Linus Torvalds Cc: linux-mm@kvack.org Cc: linux-arch@vger.kernel.org Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: linux-cxl@vger.kernel.org Cc: nvdimm@lists.linux.dev Cc: linux-xfs@vger.kernel.org Cc: dm-devel@lists.linux.dev --- arch/arc/Kconfig | 1 + arch/arc/include/asm/cachetype.h | 9 +++++++++ arch/arm/Kconfig | 1 + arch/arm/include/asm/cachetype.h | 2 ++ arch/csky/Kconfig | 1 + arch/csky/include/asm/cachetype.h | 9 +++++++++ arch/m68k/Kconfig | 1 + arch/m68k/include/asm/cachetype.h | 9 +++++++++ arch/mips/Kconfig | 1 + arch/mips/include/asm/cachetype.h | 9 +++++++++ arch/nios2/Kconfig | 1 + arch/nios2/include/asm/cachetype.h | 10 ++++++++++ arch/parisc/Kconfig | 1 + arch/parisc/include/asm/cachetype.h | 9 +++++++++ arch/sh/Kconfig | 1 + arch/sh/include/asm/cachetype.h | 9 +++++++++ arch/sparc/Kconfig | 1 + arch/sparc/include/asm/cachetype.h | 14 ++++++++++++++ arch/xtensa/Kconfig | 1 + arch/xtensa/include/asm/cachetype.h | 10 ++++++++++ include/linux/cacheinfo.h | 6 ++++++ mm/Kconfig | 6 ++++++ 22 files changed, 112 insertions(+) create mode 100644 arch/arc/include/asm/cachetype.h create mode 100644 arch/csky/include/asm/cachetype.h create mode 100644 arch/m68k/include/asm/cachetype.h create mode 100644 arch/mips/include/asm/cachetype.h create mode 100644 arch/nios2/include/asm/cachetype.h create mode 100644 arch/parisc/include/asm/cachetype.h create mode 100644 arch/sh/include/asm/cachetype.h create mode 100644 arch/sparc/include/asm/cachetype.h create mode 100644 arch/xtensa/include/asm/cachetype.h diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index 1b0483c51cc1..7d294a3242a4 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -6,6 +6,7 @@ config ARC def_bool y select ARC_TIMERS + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_CACHE_LINE_SIZE select ARCH_HAS_DEBUG_VM_PGTABLE select ARCH_HAS_DMA_PREP_COHERENT diff --git a/arch/arc/include/asm/cachetype.h b/arch/arc/include/asm/cachetype.h new file mode 100644 index 000000000000..05fc7ed59712 --- /dev/null +++ b/arch/arc/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_ARC_CACHETYPE_H +#define __ASM_ARC_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() true + +#endif diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index f8567e95f98b..cd13b1788973 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -5,6 +5,7 @@ config ARM select ARCH_32BIT_OFF_T select ARCH_CORRECT_STACKTRACE_ON_KRETPROBE if HAVE_KRETPROBES && FRAME_POINTER && !ARM_UNWIND select ARCH_HAS_BINFMT_FLAT + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_CPU_FINALIZE_INIT if MMU select ARCH_HAS_CURRENT_STACK_POINTER select ARCH_HAS_DEBUG_VIRTUAL if MMU diff --git a/arch/arm/include/asm/cachetype.h b/arch/arm/include/asm/cachetype.h index e8c30430be33..b9dbe1d4c8fe 100644 --- a/arch/arm/include/asm/cachetype.h +++ b/arch/arm/include/asm/cachetype.h @@ -20,6 +20,8 @@ extern unsigned int cacheid; #define icache_is_vipt_aliasing() cacheid_is(CACHEID_VIPT_I_ALIASING) #define icache_is_pipt() cacheid_is(CACHEID_PIPT) +#define cpu_dcache_is_aliasing() (cache_is_vivt() || cache_is_vipt_aliasing()) + /* * __LINUX_ARM_ARCH__ is the minimum supported CPU architecture * Mask out support which will never be present on newer CPUs. diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig index cf2a6fd7dff8..8a91eccf76dc 100644 --- a/arch/csky/Kconfig +++ b/arch/csky/Kconfig @@ -2,6 +2,7 @@ config CSKY def_bool y select ARCH_32BIT_OFF_T + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_DMA_PREP_COHERENT select ARCH_HAS_GCOV_PROFILE_ALL select ARCH_HAS_SYNC_DMA_FOR_CPU diff --git a/arch/csky/include/asm/cachetype.h b/arch/csky/include/asm/cachetype.h new file mode 100644 index 000000000000..98cbe3af662f --- /dev/null +++ b/arch/csky/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_CSKY_CACHETYPE_H +#define __ASM_CSKY_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() true + +#endif diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig index 4b3e93cac723..a9c3e3de0c6d 100644 --- a/arch/m68k/Kconfig +++ b/arch/m68k/Kconfig @@ -3,6 +3,7 @@ config M68K bool default y select ARCH_32BIT_OFF_T + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_BINFMT_FLAT select ARCH_HAS_CPU_FINALIZE_INIT if MMU select ARCH_HAS_CURRENT_STACK_POINTER diff --git a/arch/m68k/include/asm/cachetype.h b/arch/m68k/include/asm/cachetype.h new file mode 100644 index 000000000000..7fad5d9ab8fe --- /dev/null +++ b/arch/m68k/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_M68K_CACHETYPE_H +#define __ASM_M68K_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() true + +#endif diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 797ae590ebdb..ab1c8bd96666 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -4,6 +4,7 @@ config MIPS default y select ARCH_32BIT_OFF_T if !64BIT select ARCH_BINFMT_ELF_STATE if MIPS_FP_SUPPORT + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_CPU_FINALIZE_INIT select ARCH_HAS_CURRENT_STACK_POINTER if !CC_IS_CLANG || CLANG_VERSION >= 140000 select ARCH_HAS_DEBUG_VIRTUAL if !64BIT diff --git a/arch/mips/include/asm/cachetype.h b/arch/mips/include/asm/cachetype.h new file mode 100644 index 000000000000..9f4ba2fe1155 --- /dev/null +++ b/arch/mips/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_MIPS_CACHETYPE_H +#define __ASM_MIPS_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() cpu_has_dc_aliases + +#endif diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index d54464021a61..760fb541ecd2 100644 --- a/arch/nios2/Kconfig +++ b/arch/nios2/Kconfig @@ -2,6 +2,7 @@ config NIOS2 def_bool y select ARCH_32BIT_OFF_T + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_DMA_PREP_COHERENT select ARCH_HAS_SYNC_DMA_FOR_CPU select ARCH_HAS_SYNC_DMA_FOR_DEVICE diff --git a/arch/nios2/include/asm/cachetype.h b/arch/nios2/include/asm/cachetype.h new file mode 100644 index 000000000000..eb9c416b8a1c --- /dev/null +++ b/arch/nios2/include/asm/cachetype.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_NIOS2_CACHETYPE_H +#define __ASM_NIOS2_CACHETYPE_H + +#include +#include + +#define cpu_dcache_is_aliasing() (NIOS2_DCACHE_SIZE > PAGE_SIZE) + +#endif diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig index d14ccc948a29..0f25c227f74b 100644 --- a/arch/parisc/Kconfig +++ b/arch/parisc/Kconfig @@ -8,6 +8,7 @@ config PARISC select HAVE_FUNCTION_GRAPH_TRACER select HAVE_SYSCALL_TRACEPOINTS select ARCH_WANT_FRAME_POINTERS + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_DMA_ALLOC if PA11 select ARCH_HAS_ELF_RANDOMIZE select ARCH_HAS_STRICT_KERNEL_RWX diff --git a/arch/parisc/include/asm/cachetype.h b/arch/parisc/include/asm/cachetype.h new file mode 100644 index 000000000000..e0868a1d3c47 --- /dev/null +++ b/arch/parisc/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_PARISC_CACHETYPE_H +#define __ASM_PARISC_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() true + +#endif diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 7500521b2b98..2ad3e29f0ebe 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -2,6 +2,7 @@ config SUPERH def_bool y select ARCH_32BIT_OFF_T + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_ENABLE_MEMORY_HOTPLUG if SPARSEMEM && MMU select ARCH_ENABLE_MEMORY_HOTREMOVE if SPARSEMEM && MMU select ARCH_HAVE_NMI_SAFE_CMPXCHG if (GUSA_RB || CPU_SH4A) diff --git a/arch/sh/include/asm/cachetype.h b/arch/sh/include/asm/cachetype.h new file mode 100644 index 000000000000..a5fffe536068 --- /dev/null +++ b/arch/sh/include/asm/cachetype.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_SH_CACHETYPE_H +#define __ASM_SH_CACHETYPE_H + +#include + +#define cpu_dcache_is_aliasing() true + +#endif diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 49849790e66d..5ba627da15d7 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -13,6 +13,7 @@ config 64BIT config SPARC bool default y + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_MIGHT_HAVE_PC_PARPORT if SPARC64 && PCI select ARCH_MIGHT_HAVE_PC_SERIO select DMA_OPS diff --git a/arch/sparc/include/asm/cachetype.h b/arch/sparc/include/asm/cachetype.h new file mode 100644 index 000000000000..caf1c0045892 --- /dev/null +++ b/arch/sparc/include/asm/cachetype.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_SPARC_CACHETYPE_H +#define __ASM_SPARC_CACHETYPE_H + +#include + +#ifdef CONFIG_SPARC32 +extern int vac_cache_size; +#define cpu_dcache_is_aliasing() (vac_cache_size > PAGE_SIZE) +#else +#define cpu_dcache_is_aliasing() (L1DCACHE_SIZE > PAGE_SIZE) +#endif + +#endif diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig index 7d792077e5fd..2dfde54d1a84 100644 --- a/arch/xtensa/Kconfig +++ b/arch/xtensa/Kconfig @@ -2,6 +2,7 @@ config XTENSA def_bool y select ARCH_32BIT_OFF_T + select ARCH_HAS_CPU_CACHE_ALIASING select ARCH_HAS_BINFMT_FLAT if !MMU select ARCH_HAS_CURRENT_STACK_POINTER select ARCH_HAS_DEBUG_VM_PGTABLE diff --git a/arch/xtensa/include/asm/cachetype.h b/arch/xtensa/include/asm/cachetype.h new file mode 100644 index 000000000000..51bd49e2a1c5 --- /dev/null +++ b/arch/xtensa/include/asm/cachetype.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __ASM_XTENSA_CACHETYPE_H +#define __ASM_XTENSA_CACHETYPE_H + +#include +#include + +#define cpu_dcache_is_aliasing() (DCACHE_WAY_SIZE > PAGE_SIZE) + +#endif diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h index d504eb4b49ab..2cb15fe4fe12 100644 --- a/include/linux/cacheinfo.h +++ b/include/linux/cacheinfo.h @@ -138,4 +138,10 @@ static inline int get_cpu_cacheinfo_id(int cpu, int level) #define use_arch_cache_info() (false) #endif +#ifndef CONFIG_ARCH_HAS_CPU_CACHE_ALIASING +#define cpu_dcache_is_aliasing() false +#else +#include +#endif + #endif /* _LINUX_CACHEINFO_H */ diff --git a/mm/Kconfig b/mm/Kconfig index 57cd378c73d6..db09c9ad15c9 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -1016,6 +1016,12 @@ config IDLE_PAGE_TRACKING See Documentation/admin-guide/mm/idle_page_tracking.rst for more details. +# Architectures which implement cpu_dcache_is_aliasing() to query +# whether the data caches are aliased (VIVT or VIPT with dcache +# aliasing) need to select this. +config ARCH_HAS_CPU_CACHE_ALIASING + bool + config ARCH_HAS_CACHE_LINE_SIZE bool From patchwork Wed Jan 31 16:25:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13539645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A374C47258 for ; Wed, 31 Jan 2024 16:25:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 778386B0096; Wed, 31 Jan 2024 11:25:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 727B78D0001; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A4C28D0005; Wed, 31 Jan 2024 11:25:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 198406B0093 for ; Wed, 31 Jan 2024 11:25:52 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD4B4A08B8 for ; Wed, 31 Jan 2024 16:25:51 +0000 (UTC) X-FDA: 81740132502.20.AA92B38 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf20.hostedemail.com (Postfix) with ESMTP id 4D7531C001F for ; Wed, 31 Jan 2024 16:25:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=HA2Zt+xx; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf20.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706718350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9FkgFod/IS4HkUrFEP6tB6rUBCIOXIehNKoOY5Spu6U=; b=BVGsivU9Lth9Pri0MQ2vdLzOLl/7KE8L0fh6dNWm+4W7jHhivzIHMIGdblFHh6lwvY1wi5 v8Yu6NU2egNlE6+DCNHcduOt3OGgW8wEQNeofftTPSfarkCW3Ql6Qk0+eM29t643r57UIh OMovP19zlO1+8wCP1xU0VdoPSjnQPog= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=HA2Zt+xx; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf20.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706718350; a=rsa-sha256; cv=none; b=Me+FIlM/hGTiXNp1iL7yly5rsA5MmlBsgBr52fOvjuUQe8QWCeTkR5OESsmPaBc8rGrq+U ki1j8jjwAO94NO3O7dadnHvdoEDwI6Ils2gEr2KE38btnE16tk/xZboXBiLrQLg07mHddP cDr/3sOFcBfClRrRQ/71CCD2/1KhDgw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706718349; bh=eX0TXo9pcQzgnT4JpiJ1uz+KvY1x3UAQjUEMAJVLHgE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HA2Zt+xxhsvOb4O2UchDtcajfJ8ji+gNYMyIjAGZ5EQWJYleafh08/eminp77aE82 yajKp/NCmwT9QgTnvK/lTjgc7JIeNPSy8OUEcPFCHvxToJXJOl1x+D89IDEw3SnePY HGYVNr8qWrGj0nxbnfdG/h4ky03ZNKXxoNWxV0+YPw/t1zr8gq/bQQlqqJb50gIUWj lAj2UWcRkVhbWaTg+78o35p3+S3Ghr9Cg2Ii6UU64XHEvV7/avptbzfMDDiPYGDOD+ vFw7mg9tqqdM9u0smvoSSRwh4/CSG1XgucTAvwWj3hKokxfqG7+Q+wSjDRNZ6qGj4w HNu4r51PyvvHw== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TQ6pj2GjXzVp1; Wed, 31 Jan 2024 11:25:49 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@lists.linux.dev Subject: [RFC PATCH v3 4/4] dax: Fix incorrect list of data cache aliasing architectures Date: Wed, 31 Jan 2024 11:25:33 -0500 Message-Id: <20240131162533.247710-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> References: <20240131162533.247710-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4D7531C001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6r5mq9npqdmxiuxhm45decoxdoxyroex X-HE-Tag: 1706718350-482095 X-HE-Meta: U2FsdGVkX1/+JgldQtfZUF3DyIK/Kz9rKuC0NqcGieAYPwEjJ8/iggNFhLesQpucvyUIGNxRmBES15n0xfNGVbotStRFuqpT+F+Z2l4XzfVGx4mO++AkYwADnV0h6q57MBLsZwT/QERjac+WEm/AK15Gse0cw9udPFoxdPCHBC+5mxw3f1fbkD/m06TQpZNQ2corq1WTZsL0EiMkMwztjHNynQtl283sj9j/7emmOyKKbogMVI3k7mqd152VcTMFQCIn1APxMx5L23U/YH6iolTmo18RDnDRq1dNsN5MQPNRkEXsqNWsMZLutaztms+mPGJmROhRIa6SdHTgC/q0rWGAugWHC3bAHiHWQmejrrkOt4kMQz27qP2mSVb5NrKcxl5xxxTRwkkFD9txplMzkBkbGc8JDV7pUPdXypyKS7w7UtNK+Vt36Gdl96MwcME6MfEFAQyd+QqL1T3u/QwUuPRwaP9P47Deb6IhwcJG4pQhIfZ4Myq138EK776/uyV0cNXK4eRHJ0OR0gEFtnqQsXHOMxmaKuz7okux7uwTLvh3wHbLcE6YBHPbLdBwEKuz5vNGVc++JVoVxzemG4vcN7lQCeyzke7aXmskRkYBDDjAu0ur47lXUkknJQ0NM6RCKmhxL15viRl7VvLOGKSEpHtn7lKQaunV9NpI6Gil0g+WgEfNmvLuv6kqb1bncZm54vrX6bv1EEubkUaB1cFuBojbODLuXrj2+XFof91axVMWaDbdBV/mQNZ9UfhNCDje53Y7H9x2YXvnBkH1kNl4EoMgPhtM7YmPGSja+WRVLxw2B3bdVQrhdzK7LAP716X2TCdSaK/eB8TmAaTDkATjG3pBOmhlSxAe7KTKIBOCxNs4oO7hq6w+aXL0C9WVPoeh8EFn4QeR1GI9qcBsSzn1KRB5Jp24uSCraFbIOhoi774X94qK2Y2LBqPM7+CZM+qCnHm0dhJmNuYhfTwltOr NTWqQTRG bHcnYmJnv8APKMUkEwSJkczGTeXSO5cMfyKa//4qN6BJRaSlnbwUQxLN8L/59VaZKS/6+Ijdp6d+T5h5LuzDWzR88mKpVpZmlgZ3MaNOmjoBVcgSP5L87ppejrSlRdBPg6pDOuyUbHxxhBO7uK7jWRPQQizxTJgbfdkMGI3fEksZnvmEWpHxNiezCU0NLi6a4cBZ0nNsGDR+r/DQbpP6dDgMBHS4gGCxKkTRVvvrVxSfs1Es7a6nhBhMG0wPUb+INWqqxEpN1Rj2rHXYa3FB7eFtxydRKMtNeQZD4cKgoQUawe+sV7SbQDa/3pUX+soz8Pzv5fqLN2Uh2lRflXmPUi/SEZA8swy4gUYN77YgMhNpZD8EPenqM6596O4ElVb7b95xlM69a1av8BDgBxj+hIUfZpTLrqlNW4hRfaqHUpJnnCNLjtv7xJ5vYuHmZWB+wn+RrlgRudgCu3uWWG2gWtluL1sqpt816LSj8eOdd4GxB+WRvUIPlaL273OfRf1QPJEOz5PmEgcIhg071TqLOc/wLktIYXJ7XZL7MPH0GqanPG7s3ftaY2UpTlFWWJJu27nNU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: commit d92576f1167c ("dax: does not work correctly with virtual aliasing caches") prevents DAX from building on architectures with virtually aliased dcache with: depends on !(ARM || MIPS || SPARC) This check is too broad (e.g. recent ARMv7 don't have virtually aliased dcaches), and also misses many other architectures with virtually aliased data cache. This is a regression introduced in the v5.13 Linux kernel where the dax mount option is removed for 32-bit ARMv7 boards which have no data cache aliasing, and therefore should work fine with FS_DAX. This was turned into the following check in alloc_dax() by a preparatory change: if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_MIPS) || IS_ENABLED(CONFIG_SPARC)) return NULL; Use cpu_dcache_is_aliasing() instead to figure out whether the environment has aliasing data caches. Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Signed-off-by: Mathieu Desnoyers Cc: Andrew Morton Cc: Linus Torvalds Cc: linux-mm@kvack.org Cc: linux-arch@vger.kernel.org Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: nvdimm@lists.linux.dev Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: dm-devel@lists.linux.dev --- drivers/dax/super.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index e9f397b8a5a3..8c3a6e8e6334 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "dax-private.h" /** @@ -446,9 +447,7 @@ struct dax_device *alloc_dax(void *private, const struct dax_operations *ops) int minor; /* Unavailable on architectures with virtually aliased data caches. */ - if (IS_ENABLED(CONFIG_ARM) || - IS_ENABLED(CONFIG_MIPS) || - IS_ENABLED(CONFIG_SPARC)) + if (cpu_dcache_is_aliasing()) return NULL; if (WARN_ON_ONCE(ops && !ops->zero_page_range))