From patchwork Thu Feb 1 18:03:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13541612 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D968F127B52; Thu, 1 Feb 2024 18:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810644; cv=none; b=IdRAbOkLlo/cIAbajE9mYgPeunegHBewsu1ee0Tykwo+kDtDoS81vjBs5QyVoVUJlmoQnqhGXiwQCMdvRrZwepyGUCq9JtkHU1eKv0g5vq3cHLymngJqSlRUhUaZoNl+GasNLMmeb0Qymx7/mtnYIBIfVAmOqYlD2e0qj+ZheIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810644; c=relaxed/simple; bh=wH0FTHH2f0Izmm4ituTnkzAKw0K7lbkSPsk6LoI5uM0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kPOJ5SEq/v7ZgoUGchMHx5VXgTMtqL2tQjNmp9tTTdkJeooVHr346P/ggC96RHWWzSAFE6GhKIBUMvqNEj/TlnZ5wx7T2Fo/SevZtyQl8Jy6ERfFX2gH656xQTx7489NosekYajmfGYeWtUm7q/FoXUa1/cbVlxRXk/qUpgnSwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aXMB6GeO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aXMB6GeO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF41C433C7; Thu, 1 Feb 2024 18:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706810644; bh=wH0FTHH2f0Izmm4ituTnkzAKw0K7lbkSPsk6LoI5uM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aXMB6GeOCRjKa6tbBpXKbvKI3nFivbOOTRaHj0uwBrw8ciRqeQNSq5mTLFLtPoP5J qESqz00JSuNgPdYS56Map/CxGCrL6g61ogcyxTcmNvsz9M8NnG6xC8QcJT+9pzgNRz azIL2oThlR5fg8fNQnVWsftEqH4YH4SePd00CZc9eFIt4oi3uRfJYYKzSqQoUaR9hr FLxCiVZ2jORoXfwd94vL2jXMNoCUDqayNF7oy9z2vz7QCwetC5fgdiIcFebOBkI0Zk 4E2y/8jqO6OlAX3ijJswiNPP7OJeg9d0v60v+P3VrpredtTvT1vZZYpyyEDOWztJCp FYyPt5+Dp15Sg== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH 1/4] btrfs: require no nodatacow for tests that exercise compression Date: Thu, 1 Feb 2024 18:03:47 +0000 Message-Id: <413f5f4f472480a66bcc3b48c45071cdeea12dfb.1706810184.git.fdmanana@suse.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana Several test cases fail when running with MOUNT_OPTIONS="-o nodatacow" because they attempt to use compression and compression can not be enabled on nodatacow files (it fails with -EINVAL). So make sure those tests are not run if nodatacow is specified in MOUNT_OPTIONS. Signed-off-by: Filipe Manana --- tests/btrfs/024 | 1 + tests/btrfs/048 | 1 + tests/btrfs/059 | 1 + tests/btrfs/138 | 1 + tests/btrfs/234 | 1 + tests/btrfs/281 | 1 + 6 files changed, 6 insertions(+) diff --git a/tests/btrfs/024 b/tests/btrfs/024 index 95c734ec..a8ca0e1d 100755 --- a/tests/btrfs/024 +++ b/tests/btrfs/024 @@ -17,6 +17,7 @@ _begin_fstest auto quick compress # real QA test starts here _supported_fs btrfs _require_scratch +_require_btrfs_no_nodatacow __workout() { diff --git a/tests/btrfs/048 b/tests/btrfs/048 index 8a88b8cc..aa2030b1 100755 --- a/tests/btrfs/048 +++ b/tests/btrfs/048 @@ -30,6 +30,7 @@ _require_test _require_scratch _require_btrfs_command "property" _require_btrfs_command inspect-internal dump-super +_require_btrfs_no_nodatacow send_files_dir=$TEST_DIR/btrfs-test-$seq diff --git a/tests/btrfs/059 b/tests/btrfs/059 index 76a1e76e..8b458b34 100755 --- a/tests/btrfs/059 +++ b/tests/btrfs/059 @@ -28,6 +28,7 @@ _supported_fs btrfs _require_test _require_scratch _require_btrfs_command "property" +_require_btrfs_no_nodatacow _scratch_mkfs >> $seqres.full 2>&1 _scratch_mount diff --git a/tests/btrfs/138 b/tests/btrfs/138 index f99e58e7..427fdede 100755 --- a/tests/btrfs/138 +++ b/tests/btrfs/138 @@ -18,6 +18,7 @@ _begin_fstest auto compress _supported_fs btrfs _require_scratch _require_btrfs_command property +_require_btrfs_no_nodatacow algos=($(_btrfs_compression_algos)) diff --git a/tests/btrfs/234 b/tests/btrfs/234 index c045ea6c..542515e8 100755 --- a/tests/btrfs/234 +++ b/tests/btrfs/234 @@ -18,6 +18,7 @@ _begin_fstest auto quick compress rw _supported_fs btrfs _require_scratch _require_odirect +_require_btrfs_no_nodatacow _require_chattr c _scratch_mkfs >>$seqres.full 2>&1 diff --git a/tests/btrfs/281 b/tests/btrfs/281 index 63fb89ea..64075225 100755 --- a/tests/btrfs/281 +++ b/tests/btrfs/281 @@ -25,6 +25,7 @@ _require_scratch_reflink _require_btrfs_send_v2 _require_xfs_io_command "fiemap" _require_fssum +_require_btrfs_no_nodatacow _fixed_by_kernel_commit a11452a3709e \ "btrfs: send: avoid unaligned encoded writes when attempting to clone range" From patchwork Thu Feb 1 18:03:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13541613 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C684127B52; Thu, 1 Feb 2024 18:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810647; cv=none; b=kByOgInSCWrcPYc3Ca+4Qne8LuY9HrkY5ssTXjsGVel/KNwQ62ptkoZc7tO6BugYJHRriDsWqEjId11xjcala5LDSDjtVCELYCtr31r8PIbE8SK4LNRix7jDhIGRN0xUbJVXABrrRTVVE0hCKTU/U0ht8OKWuLa3QgUUPr3JfOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810647; c=relaxed/simple; bh=Wz6y+ZQr5WBAqiVasEs/iYYNIQoVGkfxyGzfE9Bfwk4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F2RtxA+YCLqiE4Kibe2fs4E1G5C2s5mZ/42Sr8VHVYLuReVTL9rT869grY37T1hI7F89CXgCZ7IHQyU1YIsghNy/kwQ3kXqfuJ5ln9i1x1pBK0Uwmt3I4PbiITOparEj66NKm9PFr3uafStesUx/+RGyXKfUW0D+Tpn8g1tMn9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eOYtxeDN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eOYtxeDN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23FA7C433C7; Thu, 1 Feb 2024 18:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706810647; bh=Wz6y+ZQr5WBAqiVasEs/iYYNIQoVGkfxyGzfE9Bfwk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eOYtxeDNXmsELrHJVXc/IZ1JouWelgud4zdSOfe5rAzgJY8WBlRXgdJnmFKDrYol/ ENwcT/UL9KYJwPabchFELuormotHzJk5a7JKLv6xlMurgZBZsNmcDlpRjY2yj52lLk QjC1xMMpY+mP0MygHtrXEs9pdanoEXpGDcJ9INVL8l3a2RBFQlOM3bGpDlRDoi23Us h8g5hgyXRqA8UWSmJwXoQqCzGUgAIh2RwdIKnKdq8A5OAy7C540T2yVaU2j5QAX01F dkhaqPtog1dQ+J2fmqV0MTx5PC7h+oTS6aN01Pmmd2cjPVwl6f8E32iSERtPzpw7+E Ddps4QVclFSRg== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH 2/4] btrfs/173: make the test work when mounting with nodatacow Date: Thu, 1 Feb 2024 18:03:48 +0000 Message-Id: <0e243759cb9551eaac8b6f10f4dfbcbd5e880d56.1706810184.git.fdmanana@suse.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana Currently btrfs/173 fails when passing "-o nodatacow" to MOUNT_OPTIONS because it assumes that when creating a file it does not have the nodatacow flag set, which is obviously not true if the fs is mounted with "-o nodatacow". To allow the test to run successfully with nodatacow, just make sure it clears the nodatacow flag from the file if the fs was mounted with "-o nodatacow". Signed-off-by: Filipe Manana --- tests/btrfs/173 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/btrfs/173 b/tests/btrfs/173 index 6e78a826..42af2d26 100755 --- a/tests/btrfs/173 +++ b/tests/btrfs/173 @@ -23,6 +23,11 @@ echo "COW file" # unset it after the swap file has been created. rm -f "$SCRATCH_MNT/swap" touch "$SCRATCH_MNT/swap" +# Make sure we have a COW file if we were mounted with "-o nodatacow". +if _normalize_mount_options "$MOUNT_OPTIONS" | grep -q "nodatacow"; then + _require_chattr C + $CHATTR_PROG -C "$SCRATCH_MNT/swap" +fi chmod 0600 "$SCRATCH_MNT/swap" _pwrite_byte 0x61 0 $(($(_get_page_size) * 10)) "$SCRATCH_MNT/swap" >> $seqres.full $MKSWAP_PROG "$SCRATCH_MNT/swap" >> $seqres.full From patchwork Thu Feb 1 18:03:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13541614 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA373127B52; Thu, 1 Feb 2024 18:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810649; cv=none; b=BrYZJlaV73fg5rjoQVrW2RDhVEZ8fe1McTGPxAGYcIWb/DDkpXDzsVnHU4NxmhO/wucFQeKKqQTvynAC3ZWpmO48aYFgMeNQg9xan5QRtaQ91SWgLPjAse2RFTMpg4jn567Xi0MEu9ClXGcaoh0EglNh+InV58UvDhSzIJaCp6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810649; c=relaxed/simple; bh=pJey/BqAnBn9Q7A8kD7XQJQcSUF9vWU0CCQME/Wrf/k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oGswaXjvza0zwMDMbmP8l3KjTuJTAtJLGm3z3xe1JZGxr8YJ0y4XeHe0hSSjo152atuK40XYukwOOEe5SqU/GZTBPyBCJCCBM8nvbr4xKt4trEXvntk0ifvdU3nPa42Grv+3YWBXER0NtXiJLuTOmMjao9ubMerbZ3ofvbxeooo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UkJUGEaU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UkJUGEaU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82AE0C433C7; Thu, 1 Feb 2024 18:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706810649; bh=pJey/BqAnBn9Q7A8kD7XQJQcSUF9vWU0CCQME/Wrf/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UkJUGEaUQgc4APZot2PJ0JVP0BTiibY3/ljwylh6BQ8fZF46yIkf9Fo8px8g1nIY9 7E+BG5AO0Q5vwTrnE9YWYwnT6wd5P8K9zf3+OzTZnmXi5zqqMo6dOwCg7BcZYVvZjW NcuOsweraKLO4/KhEUz4/NuxlmiJQ1UJPBoHOH308NQ9ATFASTkIbxMick0pF9SPhZ 3FPYzUm9yFHEu2pfoh3dIB0ApwMIOialfzmeFjXi9AMFFpiSKfj+h9bY6s5L+DRfNa Udddg2be+pbQ67vxR4ODTkWwu6rBUlsPpm5VJU5N8YdCyLaWk0NtxnZ5qL76BuqCvG XOjeA+rL8tBuw== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH 3/4] btrfs/299: skip test if we were mounted with nodatacow Date: Thu, 1 Feb 2024 18:03:49 +0000 Message-Id: <92cf2f68139e3e8488c09372ef1fd46443b3299b.1706810184.git.fdmanana@suse.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana The test requires the ability to create an inline extent in a file with a prealloced extent, created with fallocate's FALLOC_FL_KEEP_SIZE mode, which can only happen when COW is enabled. If the test is run with MOUNT_OPTIONS="-o nodatacow", then COW never happens as all writes end up using the preallocated extent. This results in the logical-resolve command to return one file path when it should return none, since the base logical address of the prealloc extent is still in use unless COW happens. So make the test not run if nodatacow is specified in MOUNT_OPTIONS. Signed-off-by: Filipe Manana --- tests/btrfs/299 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/btrfs/299 b/tests/btrfs/299 index c4b1c7c5..d38bf2ac 100755 --- a/tests/btrfs/299 +++ b/tests/btrfs/299 @@ -23,6 +23,9 @@ _supported_fs btrfs _require_scratch _require_xfs_io_command "falloc" "-k" _require_btrfs_command inspect-internal logical-resolve +# Can't run with nodatacow because we need to be able to create an inline extent +# in a range with a prealloc extent, which can only happen with COW enabled. +_require_btrfs_no_nodatacow _fixed_by_kernel_commit 560840afc3e6 \ "btrfs: fix resolving backrefs for inline extent followed by prealloc" From patchwork Thu Feb 1 18:03:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13541615 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAB384FB2; Thu, 1 Feb 2024 18:04:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810654; cv=none; b=eNpdBp9xKVaTQuwoyVXmx7zkrX+Cl+/gsf996EBxmmQ1ge2cMcq73c+xOpdJssjJ8RyIWrbGHRLLz7PqmwEqfRyN3fM4uqJYE3KLwFFoIKgBCHX3+sGQtrn3tx/HaLOUcnz57cQvqdC57+Lmyyhfk33UCnrU9+2NbdQjRf8mjpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706810654; c=relaxed/simple; bh=BWiqFVO3jlZeDfqjBtpe5k9UV8+EHbM889pu2XrE0X4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Npvyr4cvE0R/RIfAUzTw8KsZOTFL3Rf4mNCsBPYB6Qs9mZEji69j8Q47SMaOGFgyPAmaNxtsRDW6um0foD0SGGGuwbGkQf7VR+BCQmtTgC9kl37UKJbq7zes3JFg9122I7FTr8KYGPNOhfllcW/qA2E6SER3h9sqh+FvyyhVjv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A+n5XHKt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A+n5XHKt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8E7CC433C7; Thu, 1 Feb 2024 18:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706810654; bh=BWiqFVO3jlZeDfqjBtpe5k9UV8+EHbM889pu2XrE0X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A+n5XHKtpIAPy6kh+z4TLy1uweNtAMCbZl7QOvYvxRR2accFYzWR9HWO/G1YuL3JF Q8sgcCKERyWbXzmd0cJvFOmcPdgKus0cAtXPcFD6oVvAO656Y1dTy1ous/Ow9Xobgt VHZBnFY/qEaxFBMl0Lc83X9O92RRebJ/nHrw/iru8yXrRa3YIQ0zJyWmgtMKHm+/1+ 2duvow9qtD31netPNNwbulidIqX+tVNXQAMXaGt29CK5mo868W3JitKt+x831RPQvh WeC/x20w1hT4p5PiS57ACLSQvYEn2Rd4DJ1Puu/j0AUUX4ufwXcxhATaFHuPmHJFLM YPcsN3jt14Pog== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH 4/4] btrfs: require no nodatacow for tests that exercise read repair Date: Thu, 1 Feb 2024 18:03:50 +0000 Message-Id: <5c3c56241dcb8d2b6c87bb4d6875d2c0659b9219.1706810184.git.fdmanana@suse.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana Several test cases that exercise the ability to detect corrupted data and repair it, fail when "-o nodatacow" is passed to MOUNT_OPTIONS, because that ability requires the existence of data checksums, and those are disabled in nodatacow mode. So skip the tests when "-o nodatacow" is present. Signed-off-by: Filipe Manana --- tests/btrfs/140 | 3 ++- tests/btrfs/141 | 2 ++ tests/btrfs/157 | 2 ++ tests/btrfs/158 | 2 ++ tests/btrfs/215 | 2 ++ tests/btrfs/265 | 2 ++ tests/btrfs/266 | 2 ++ tests/btrfs/267 | 2 ++ tests/btrfs/268 | 2 ++ tests/btrfs/269 | 2 ++ tests/btrfs/289 | 2 ++ 11 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tests/btrfs/140 b/tests/btrfs/140 index 247a7356..5ce65886 100755 --- a/tests/btrfs/140 +++ b/tests/btrfs/140 @@ -22,7 +22,8 @@ _begin_fstest auto quick read_repair fiemap # Modify as appropriate. _supported_fs btrfs _require_scratch_dev_pool 2 - +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_btrfs_command inspect-internal dump-tree _require_odirect # Overwriting data is forbidden on a zoned block device diff --git a/tests/btrfs/141 b/tests/btrfs/141 index 90a90d00..e1adb91e 100755 --- a/tests/btrfs/141 +++ b/tests/btrfs/141 @@ -22,6 +22,8 @@ _begin_fstest auto quick read_repair # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 2 _require_btrfs_command inspect-internal dump-tree diff --git a/tests/btrfs/157 b/tests/btrfs/157 index 022db511..648db0d0 100755 --- a/tests/btrfs/157 +++ b/tests/btrfs/157 @@ -30,6 +30,8 @@ _begin_fstest auto quick raid read_repair # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 4 _require_btrfs_command inspect-internal dump-tree _require_btrfs_fs_feature raid56 diff --git a/tests/btrfs/158 b/tests/btrfs/158 index aa85835a..28599d09 100755 --- a/tests/btrfs/158 +++ b/tests/btrfs/158 @@ -22,6 +22,8 @@ _begin_fstest auto quick raid scrub # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 4 _require_btrfs_command inspect-internal dump-tree _require_btrfs_fs_feature raid56 diff --git a/tests/btrfs/215 b/tests/btrfs/215 index 00646898..6fa226fe 100755 --- a/tests/btrfs/215 +++ b/tests/btrfs/215 @@ -25,6 +25,8 @@ get_physical() # Modify as appropriate. _supported_fs btrfs _require_scratch +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow # Overwriting data is forbidden on a zoned block device _require_non_zoned_device $SCRATCH_DEV diff --git a/tests/btrfs/265 b/tests/btrfs/265 index b75d9c84..127da7ad 100755 --- a/tests/btrfs/265 +++ b/tests/btrfs/265 @@ -19,6 +19,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch_dev_pool 3 +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device _require_non_zoned_device "${SCRATCH_DEV}" diff --git a/tests/btrfs/266 b/tests/btrfs/266 index 42aff7c0..acfb1d59 100755 --- a/tests/btrfs/266 +++ b/tests/btrfs/266 @@ -18,6 +18,8 @@ _begin_fstest auto quick read_repair # real QA test starts here _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 3 _require_odirect diff --git a/tests/btrfs/267 b/tests/btrfs/267 index 75a6fdcc..51b28d9b 100755 --- a/tests/btrfs/267 +++ b/tests/btrfs/267 @@ -20,6 +20,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch_dev_pool 3 +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device _require_non_zoned_device "${SCRATCH_DEV}" diff --git a/tests/btrfs/268 b/tests/btrfs/268 index 9dc14a18..d122ee36 100755 --- a/tests/btrfs/268 +++ b/tests/btrfs/268 @@ -16,6 +16,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch _require_odirect +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_non_zoned_device "${SCRATCH_DEV}" # no overwrites on zoned devices _require_scratch_dev_pool 2 _scratch_dev_pool_get 2 diff --git a/tests/btrfs/269 b/tests/btrfs/269 index ad8f7286..7ffad125 100755 --- a/tests/btrfs/269 +++ b/tests/btrfs/269 @@ -20,6 +20,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch _require_odirect +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_non_zoned_device "${SCRATCH_DEV}" # no overwrites on zoned devices _require_scratch_dev_pool 4 _scratch_dev_pool_get 4 diff --git a/tests/btrfs/289 b/tests/btrfs/289 index 39d8f733..f1aaf4cc 100755 --- a/tests/btrfs/289 +++ b/tests/btrfs/289 @@ -16,6 +16,8 @@ _begin_fstest auto quick scrub repair # Modify as appropriate. _supported_fs btrfs _require_scratch +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device