From patchwork Fri Feb 2 11:37:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Louis Peens X-Patchwork-Id: 13542782 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2136.outbound.protection.outlook.com [40.107.220.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E017A729; Fri, 2 Feb 2024 11:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873871; cv=fail; b=C9hyDWMpG16ytUWxCs5kW2qpTUw1iZUb8Nz3f4GFRpni1JJB2B6HUvib8phzUHCiJiQAQrhT/dYwoic31/vIG9FBGR/ohROHNDUdSGFdGuzNFISjcfp8u0q6WFJRlDmJTcse2tMLaHuO1WAVb1KdECcCzY8eLsZSatEh73X/MjE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873871; c=relaxed/simple; bh=T7dLewuFeVHtoBtsLAFRJi4WBkDwBrstTfQLDJN6ax8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=nmlEqLTydHBcABBXhGOdRqFQBtUkNvwa5YnIZfJVkMosLWYDe18/7d6yJk1yYH6jzIoqMfKPSP0h8i2x7VJlAs7HU+oIioozzqH7HN9ps9f+0gwLpe00hUtbYNIjifwvpDoAVQroLL16CH1Crab7Zh5w19NzHAXv85V4rmsoB4U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com; spf=pass smtp.mailfrom=corigine.com; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b=ob2i8ZI/; arc=fail smtp.client-ip=40.107.220.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=corigine.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b="ob2i8ZI/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAnPN4IZ0roPGbjTcOQ1c3x6gmq4lkwC+k3mWmSymqEQZNpdk4K1y0/YX0WO6PUGmCm8atva38bEf6acADqf2RWu5b9Hhsb15/EUnEHdm3RX0jYa+TrdsYtqykHcLCxeU0TRTfiS7/rKP/a00KoE+733gmLXzonnKmMyu0zSJ2bdwOUf+JA6C0WRUBRINv/2dlsUVgqQW0e2Se9CXXAmK8hnAU6pKHZZAsKyTH3uXeCOIHSenY2XHihNThTZIbFqad1g1OvG+h3iYWRJFIxsw5KOx7Gk1DuvxFA8Gd4F/GAPiPqGhwSwdmp4aeM9l4KItLtUaGwH8am8SIb6R3uheg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JUuH8Fj+KNpMuo0516R3jNK2NTY2LouYrDACzrG+SCQ=; b=mPb01odmDubhyLlj5NuW+SqRMYhCsu8CKqkwIt80Z0RRWRlDQ+bMM0qowVtJ76pEOqzgP2yaoXPm55hKP/XgPQZOnmljq4wO2ORnC290hCGnfe+ethfZ7Nm1zWkQOh+q0+k64lY7nIvVoVvVYAgho9nQWEex0yujE3XgKjUvZ7WCAP7DLhalnDmmbMmFfnZ0NLfsJ7txR5W+QgEojbEa7R9XKMUcIyFFn68Sox6/AnFPyMDoMlsg6iP4QFdx4tenL5TcdlXq9JQ4rd1TKr7YAlppHJHsCmAeOJyGBoebapA38XM1yeyL6+0rJim9UmljjQInVQ86PGGjsCx4HsaH2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JUuH8Fj+KNpMuo0516R3jNK2NTY2LouYrDACzrG+SCQ=; b=ob2i8ZI/lQhcT9BknVLKMeKW4AxFHKIXaCFLbMtvExyLVtlQZl07zG9WQrwMmy6skNBVSre1yhYpSqVN4mTVWCv0ObFaVIVYC/nbZ+0ffXk4QLEnrvZ8/KCjJ4v0tjXx0+1QqFJyPzamNjPe6MZGgpMpj8u0Vh03oRPlUaIQgf0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) by MN2PR13MB3853.namprd13.prod.outlook.com (2603:10b6:208:1e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 11:37:46 +0000 Received: from CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd]) by CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd%7]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 11:37:46 +0000 From: Louis Peens To: David Miller , Jakub Kicinski , Paolo Abeni Cc: James Hershaw , Daniel Basilio , netdev@vger.kernel.org, stable@vger.kernel.org, oss-drivers@corigine.com Subject: [PATCH net 1/3] nfp: use correct macro for LengthSelect in BAR config Date: Fri, 2 Feb 2024 13:37:17 +0200 Message-Id: <20240202113719.16171-2-louis.peens@corigine.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240202113719.16171-1-louis.peens@corigine.com> References: <20240202113719.16171-1-louis.peens@corigine.com> X-ClientProxiedBy: JN2P275CA0039.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:2::27) To CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR13MB4411:EE_|MN2PR13MB3853:EE_ X-MS-Office365-Filtering-Correlation-Id: 66e05c84-686c-45a2-7c43-08dc23e360bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3kE/Uwr2JRwX1CvgdBt/BBPp6y61kfVN+I7qYZ0YtBD7anFJk9mRmRsby59sB5tDwOo55ew3o1xjhsk6WH+FL7SKsjGbYV5hAnODZEVG2i6T/FwAWKHnYChw3aOOw6meJ1GfkM+387Bqn1glQqBLlcr6zgEBjf0Z3RFCsehZPTO90bv65pItCiGS6m8DF7wL5zui96XXyhr4yQubfAQmYH534GEwJC9MjW8t5ogljN07QzbH4lJgOtkrKR5bVTxSgh7NgclqhXuHg7RyHzhzUnT7IFKidOf25fsTIDoiL0nEOzeHmuPtiKMrF2mFK72a+pac9f0XPVOWOYblOzIyfbEg0AABs7pnafVm29sRvlVYtjRqB7fv7lBK1R6VzfHERdc/c57xT2L4S7pvmUnLLELzekoeNcisDYQ/EgCTZx+xONPWd4uLoeK8naO4FXQ3sPWhwSfHd20iUJfwZkB1EzRdkWzFFCi/cFvRu5Gb0Y895xJcz1Aoq5NAQGftgK3loRZ6fch09UMuPyJCP2CKzZIuoDv8qYsZAVqtv+KuWcbFMSi3pWDMFOOmQdBdbuAo13pjHyrRrZwHCknfgGo+iedyoOOGMliR/8E3A98SgWCXNjHJ1T4uC9EFtbhtleFH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR13MB4411.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(376002)(136003)(366004)(346002)(396003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(478600001)(110136005)(8676002)(83380400001)(66556008)(6506007)(6666004)(8936002)(316002)(54906003)(6486002)(19627235002)(66476007)(26005)(2616005)(6512007)(107886003)(1076003)(52116002)(41300700001)(2906002)(5660300002)(44832011)(4326008)(38350700005)(36756003)(66946007)(38100700002)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: no36oFlSr5IZmYdNGgz32e8e/qWd3rUqklIdc8q0YAfqLiSdrZ0BpWd2ojvEUAQJ3HAcTr/QYVCoCoHO26P42i4kxWpkeT9dEDAZ1Vc6vtd2xFHIXf525vWFcpOXyYlW78BGKlnKWY105hi3UoiBqBazWC2zjxeyJiZjHA44cHZVc/ZoB5RNYDx5NA6DazEqR5ca8NkBwcDJfd6sWr2NNMCh45Y6xsYun1p6D4cNoRlUCjO+jU5rUyZqgQePxhvv4hCgNljDBD/3kxMlGjaJW6A4Q20zMgpOL/qO3euald3U2qORFrTr0815ni4LllZpFtPpjrsesLslFnjCcBv98I0QDTVM1fTJrvW3fLR+/E0r22uN1sOp0qe6tFkJxXeJJI1gVIx5zkxxvHSUoXfDSQ4hvODZGE5nA/SKFDRH8d2+L+VGEW3SiRJFliX3QcoW82myopLDMoUqdFV61rzAXMvW6Df5bg4TdeD7qMbIJUX1JT2bN9lO4pafDB7bSxR9id8Tt+PUqrBTNeXHPjc0ART/hKb+MxAyPFnIswBVAVGQLp3+MiN3ZTwJAymcb1uxaZ5K2YAR8b2F9qfkP/Eh7w4JYJQyRFp+d//h930FVp2DzKsDijAo9hbborc9gOjUWXMZ9js4qtQ0keXDUf+cK+SK07znRUGUQrsTrkYsvbkkKS79gDFSdaSoGe1qYbjfAc3BjydjOlAUqwAkZTETk0fSDSDk9DYbRaeFd5dCdexK3rXWjbpwN/odzFEO2m4uQdTM8XC14PuFVRmygt4Wv7fubSBADaxaQ1+pyCijS5MuUFOVyyyY5wDBvv9oYx1v1wT27LVbGdXoPPFR8fEOXKfuGLtXzKOjCRTZt8RnJEzHysWxPgqFi6abvt6vmV6DqH7qQuf3izWhfpUHZ//UiVvheXCb67d5K2gTHMSJrGyUObJEyy/DSMkrXusz3PaiblpB/n1U21nODxHBaL6Ud7GHyq1YFujfuVR+18zlrnzWb0c1diS0tp3m264MEieQbp3VD/DS6hoQK1t1G4eR0FAVl4J3R97mMybQYy4skaAwqC3kzhZiwvD1GVyUvZ3+lMuXOnjwCfsXZLKGCYKhO33WSXK7bZlSaGVmYEOu5p8kHV9S4N8gM6qEvgwWIYYbpC/OF2IjYI2ZnYuWkAiRXf3mKNYhN4eS7miu7kWhQnOj/ZhVvTyjdW83uFXfxsG5FUTW2VLMqnwfYx6H1FGondSJdGqy2sm2DjluTnNONbHAyiaUfwKd5SYZUokiS7aoyX/sgJkHAxIuqq4keAD6I+rRTBCAqxjqI7zK0qSpKnDZ8df2w0oHY5bR6vs49/uFDXDN304MzJf0qVdB43hjgBCMfK0Y/gNSPsboc/0KaikIzl4LVqZs3Z2xQgmHR2oxYMedtLy59InL8RxeHiOaM4hoZFIxcWlLPy4705vPB4vuoaG9C+esmN7OFCi6+986Yi3jzL6aj9xcNkIw++w01t3b6FGNLgpbI7efcd4/XwKmhWO602QeqjQWOt4ZF3ZCAOBUK8zfji/pwgD/4sNdbsxyWWyX0BIBtsxNS7KjLhFn7ZZSN5iqwAVfvszXslc4SPAK10eV13If8zZayjwdoQ== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66e05c84-686c-45a2-7c43-08dc23e360bb X-MS-Exchange-CrossTenant-AuthSource: CH2PR13MB4411.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:37:46.8487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PUiObwS68IwrMDG1pzdvh9ODalskO0XkKqjMc1fKfIARvuJxsXwXe6R+Kri7kblw2qM+oODObgaUbPwoX3+9UosHYM4tQPKQYrYKYwFu76Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3853 X-Patchwork-Delegate: kuba@kernel.org From: Daniel Basilio The 1st and 2nd expansion BAR configuration registers are configured, when the driver starts up, in variables 'barcfg_msix_general' and 'barcfg_msix_xpb', respectively. The 'LengthSelect' field is ORed in from bit 0, which is incorrect. The 'LengthSelect' field should start from bit 27. This has largely gone un-noticed because NFP_PCIE_BAR_PCIE2CPP_LengthSelect_32BIT happens to be 0. Fixes: 4cb584e0ee7d ("nfp: add CPP access core") Cc: stable@vger.kernel.org # 4.11+ Signed-off-by: Daniel Basilio Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c index 33b4c2856316..3f10c5365c80 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c @@ -537,11 +537,13 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface) const u32 barcfg_msix_general = NFP_PCIE_BAR_PCIE2CPP_MapType( NFP_PCIE_BAR_PCIE2CPP_MapType_GENERAL) | - NFP_PCIE_BAR_PCIE2CPP_LengthSelect_32BIT; + NFP_PCIE_BAR_PCIE2CPP_LengthSelect( + NFP_PCIE_BAR_PCIE2CPP_LengthSelect_32BIT); const u32 barcfg_msix_xpb = NFP_PCIE_BAR_PCIE2CPP_MapType( NFP_PCIE_BAR_PCIE2CPP_MapType_BULK) | - NFP_PCIE_BAR_PCIE2CPP_LengthSelect_32BIT | + NFP_PCIE_BAR_PCIE2CPP_LengthSelect( + NFP_PCIE_BAR_PCIE2CPP_LengthSelect_32BIT) | NFP_PCIE_BAR_PCIE2CPP_Target_BaseAddress( NFP_CPP_TARGET_ISLAND_XPB); const u32 barcfg_explicit[4] = { From patchwork Fri Feb 2 11:37:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Louis Peens X-Patchwork-Id: 13542783 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2136.outbound.protection.outlook.com [40.107.220.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2265613D4E0; Fri, 2 Feb 2024 11:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.136 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873873; cv=fail; b=pB3MkRI2B3O8heLsCL3RqyTQeDcZ1E2HAZovnSvlwzHdujcGKnEgF1Y9HpEEzU+SiKeOUqDEbp3oPTRSr/e6HygzZB3dma4QYrMnCjYipr3P0jEQAkW2tb9Ivwqyblk7/z1AW2JSrBHL6jXlEfd3xY+v95eUiauXgEsiR+P/87E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873873; c=relaxed/simple; bh=kEwq2qL+BfDEayPAuD/dodl2Lg7SpUhSY0M9b8GahHA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jEb9fFWJ9VFF+w6gYZmRfokxFIPDH+L+0vHSXvk3OcKktMIu0z1zN6mIGMwaliVjCX4owqYKsXn/yg3i+ctKE/TyX/boxLBc1m4Q+qajSYnw4OIG33Vr9IB8m+EmW4QU7OrGl/EV1f4WGJCmWa86V/dx0gocKFouKB0lGiauu8E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com; spf=pass smtp.mailfrom=corigine.com; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b=IKlQdwE4; arc=fail smtp.client-ip=40.107.220.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=corigine.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b="IKlQdwE4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGTGvZnBXkjUBIRMDiaHz3Kl4ceASuhU6gdaQQ/D7XNMuwbPEmjTGjdin+OuE4U+Aohn6L++FKsKO2AGY04VRYxFq+cafyvs6sTq4wgYFO95zf0qDFk/lsYD+97WVoq0WywwABS2cOlJ4OrKxcwDHJLLoZyjE2hnFYg2wgFKHufzj+BVhACHXdHTaDugjlYQYL2jQXkuRPavUaH2qu765e7QvPTsc7NPk5panTU7eqKPiI9JGcMUXh5Oc4JW2eEPwRmER/QVgMPxZJZNEaGDIgrnk1w2qzzuaLGYs5ffeMoiko+YGmfKRwuJIdkbvaRuhZQ+zZKA+EQcbPBl6q+tpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QyTJuwV6BXlZoTMQ6lZauQDBgXqUOtjGzkERhO+NzAo=; b=PZ04NYUYbQKFLvTnCoCHaUfhIQ1reT6ko8VMAfF2v2M2kHaw32zWN1vSeQjzXeQdFY/n9OXIkdEZtqEVw5SYnvCjTqMZy8HIiOu36CxQssiM9GOyN5B2LKMkF2E1dUhrqzv5c2XQuMHu7XoUQ4ytNUDzt+xRf4BG5mVjfGPEy3cbBkCrz/65N0474hCby2oDoxOtATMSRUc95zAGG0WYSIfZdJH6lpbwXWqyEpbeJ5RN/rkbT43arscBIE1QYZA/HGRv9ADBWdXlWyStHjED5PqkkK7n7ThlBE75kpDS8N56NZJ19V8jU198I4mGFsQeROcyqWVul0ioF2Wa4/qqUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QyTJuwV6BXlZoTMQ6lZauQDBgXqUOtjGzkERhO+NzAo=; b=IKlQdwE4ymNnxxRUZdtcDP8lEMOvlv8AqDLcTr5qNdNXYJOzFzGIvrWt8wA11loLMr2WbkeHsLfryPqf3j1TfHlkkf5UsHO5Llu37OgMjx2vMeTnQRoGre8lVgrpjgEA5NFC8orlZw7YSW+5dPQQtqLGjitCvX7R06ZlJhOn1RI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) by MN2PR13MB3853.namprd13.prod.outlook.com (2603:10b6:208:1e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 11:37:50 +0000 Received: from CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd]) by CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd%7]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 11:37:50 +0000 From: Louis Peens To: David Miller , Jakub Kicinski , Paolo Abeni Cc: James Hershaw , Daniel Basilio , netdev@vger.kernel.org, stable@vger.kernel.org, oss-drivers@corigine.com Subject: [PATCH net 2/3] nfp: flower: prevent re-adding mac index for bonded port Date: Fri, 2 Feb 2024 13:37:18 +0200 Message-Id: <20240202113719.16171-3-louis.peens@corigine.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240202113719.16171-1-louis.peens@corigine.com> References: <20240202113719.16171-1-louis.peens@corigine.com> X-ClientProxiedBy: JN2P275CA0039.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:2::27) To CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR13MB4411:EE_|MN2PR13MB3853:EE_ X-MS-Office365-Filtering-Correlation-Id: bca6e2a5-ee3b-4bd3-e0dd-08dc23e36295 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o65jxrtEH/48lHaHGG7+CE/U6xWLj83UdpwrZO4wPMnqZviH3GtiIBSN3bof2r5YIWBk18b0MjxVuUD9NKFiG/P/kgZdJGmhx0rkYjOuxoU6Dt2qRTDuatYDptqz9Zk6k4y4+2Nr28UZ45djg+DIa8vvdtFzEs4Elw50VXambsiLGYca95Ipxe+IG9Ge7cyJYAKpYR8Fg9if9THy69Fy6Ietjfjp4ZTKKlSapoEhGDoIxH+HDxXtk52A5ncwP8+J+fvKA7vSw/9vz5JUeGQPtc+6suHgTWMeMXD8s1zbBSyj/heU5jRbxfmdXteJPC4GcPWOSEVNeM2yi3Pfpih7Kxj0kjMvi+1Qc2BYcZcVyNLCDAiRksH0CEptBSi7iOpos4qICU6+z4WRv8txTZ5i4lFuA+hoDiK0oH8T6ZyB4kwEuexGtTUrioGZZfgbNi/uO9td+/icXAM6BHXdDRXT2PCLiDuxFJzZ3b/gt9GeR4cZoECWBufRykvqd8ueycEjiB7g0Ms2j/q/1BNRt+eT4wb8zT5NupDuSYfJqEu6cVQT2I4q2N3tS/3xGZIzYlo0zBORnB0hR6FcgRhrUK9PFXzybzvrhNFddLNLlVOey7+MLQcF1BuIimocmQJ+LDGy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR13MB4411.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(376002)(136003)(366004)(346002)(396003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(478600001)(110136005)(8676002)(83380400001)(66556008)(6506007)(6666004)(8936002)(316002)(54906003)(6486002)(66476007)(26005)(2616005)(6512007)(107886003)(1076003)(52116002)(41300700001)(2906002)(5660300002)(44832011)(4326008)(38350700005)(36756003)(66946007)(38100700002)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rPrM72i/OIrUL6Pi3XHjjcpwj0sf4uq6EDUE2U6B7SGb/36T3I82glfaaPJ3XB7J3imk65eYm7JuIZjHpX2NeQHbFoVhfWzmqLwxR+NjePDkzlEplRbgJOWy7rWZge2+FiX+XQDnvb+7lZZq45TchKVGkROrc7CxRRprA78f+/8tDthlEnzjAMsF+h9loXXM5jwzXZQ4BqWCl2MDK9jWYmUofJ+eaimJfI5QLnq5LZV6h0r66K0+R9XrhT4QZxdmBkIBqmWuNOzrYJsngUgJLRQ4u2Q2pHFteos39nxZhZNb9p4Mnw6wBG8oTplAoe+E59rGXQ2lGMjWkGoAj/xvvdxG/7tN3TzZTh4tQJ/L/kFwKNXR7Oz0RDFo6JRgZkxLNkBSPhWBu1sCSEPYFGfkag8W0xLk1kqSYFZX9E6pCdvNkRDoixeT36VbGLWFBeaNc3C22BKUsocNM6/ANamQq1KaVDOjGw27HPSlmoprI2YsCv04tXE9y50aLes4KxWlQbr8JQIc7zgaPpi1SoRng3/27A/8wfqtMlMFozjnqAmtu2qCQUbTIH+q6HLK+CWcrDSJlFNJPl7shmgvm3N0JzCpo83fUro+8jkbF2NAZGF7IC/cgz/KxCQxHoyEonjBecuFYbPmMnGVEx7Han28zcqxK+zaVu3s+fK9JqJR6WPALESPwatICfl/4EGSHz02SxM0PIfYYMu7CbZYdYqo23lQL2Gor4fvQQ/huZ3+/8X7Zm55Hw6dqE3uVwfr0AGGl7aY/sKj2EMKusL26UutrSp6De1Z7Y2/qy9jrZFekifD7lSEmtoUgRc3gUGx68Z+JzkJB/lV4U6DXOR/TJFBhsiG9P4xPk3/BrC14/KQmdiROy8AczGTkqB5k5XAQ5o4t5abXO8suUT7WADUp69pG7+Uqf06seq4dEbPmNCbkhlOdQ9ZHqetGbdo0aKMx06Gi8AmXqPVlsh8bc93v7n8+3UtNRlG1XUe7ph0kzmmgEbOJjtylnK0HsMiZr9rLsAZZxpiJ0hmdbI35T2fjziQkUlaOR8G3c/ij6UjPO0it15SLueiu6H7yWG7COQPpKXVIZxkK8MlNFMkcJQU6v8R0ixfAfE9WzllLifHZLqZICylvfSGjEJN6f7j5FrsVuIV1us1+qjhhVASRfueyP/BNjk8gNe20eV0yp5Mi4fYdclFgV9Xs1kExxIB4Wiu+9C0A+UGJoh3chpZoIG0fmA3HBIytrp5N2EM+drzo5DZQY04wj/i9sg7FJW/aMUJItqqM80tr458GFegNhaZZC/y2CEurzv77kBeWBc4N/RYER6ZcQq7JxALfTOdY7tD81iyl7lfBRXOdfOfnr5cfIK4ExolmY4t+3hEaLEeBvPF/cwAHPl85tbZvVnK5qhMwS4/A7bgQ4UZ+gLcZa2d+KheqboP6MueJ+ej2lA3YxVcv27deGL0gr9Jmt3jC8dvitrbJ8b0DVpLdNMt8P+WccJgUovAWp8y5shKATyIFsMVc7O1UipK/UOQrlkbdQxtqVUSyaaDuxyrgzwNIFsvstUeX7rUJqWzxDDsC++yB0czcPmINZzg/7YHlgRbr9G6Ks1ey8nvd75hNHFCgmW2meRsgg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: bca6e2a5-ee3b-4bd3-e0dd-08dc23e36295 X-MS-Exchange-CrossTenant-AuthSource: CH2PR13MB4411.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:37:49.9278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NPx6otPnp/Fr86nf2IJEV4jfdewWYEiKAN1HiCMntsbH69pU39ZdbN3ikI6gGVPNFZNTbzBMSWPw7mBLTycNoOwlAXK4OKXqrWJKZr7uNg0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3853 X-Patchwork-Delegate: kuba@kernel.org From: Daniel de Villiers When physical ports are reset (either through link failure or manually toggled down and up again) that are slaved to a Linux bond with a tunnel endpoint IP address on the bond device, not all tunnel packets arriving on the bond port are decapped as expected. The bond dev assigns the same MAC address to itself and each of its slaves. When toggling a slave device, the same MAC address is therefore offloaded to the NFP multiple times with different indexes. The issue only occurs when re-adding the shared mac. The nfp_tunnel_add_shared_mac() function has a conditional check early on that checks if a mac entry already exists and if that mac entry is global: (entry && nfp_tunnel_is_mac_idx_global(entry->index)). In the case of a bonded device (For example br-ex), the mac index is obtained, and no new index is assigned. We therefore modify the conditional in nfp_tunnel_add_shared_mac() to check if the port belongs to the LAG along with the existing checks to prevent a new global mac index from being re-assigned to the slave port. Fixes: 20cce8865098 ("nfp: flower: enable MAC address sharing for offloadable devs") CC: stable@vger.kernel.org # 5.1+ Signed-off-by: Daniel de Villiers Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c index e522845c7c21..0d7d138d6e0d 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c +++ b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c @@ -1084,7 +1084,7 @@ nfp_tunnel_add_shared_mac(struct nfp_app *app, struct net_device *netdev, u16 nfp_mac_idx = 0; entry = nfp_tunnel_lookup_offloaded_macs(app, netdev->dev_addr); - if (entry && nfp_tunnel_is_mac_idx_global(entry->index)) { + if (entry && (nfp_tunnel_is_mac_idx_global(entry->index) || netif_is_lag_port(netdev))) { if (entry->bridge_count || !nfp_flower_is_supported_bridge(netdev)) { nfp_tunnel_offloaded_macs_inc_ref_and_link(entry, From patchwork Fri Feb 2 11:37:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Louis Peens X-Patchwork-Id: 13542784 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2135.outbound.protection.outlook.com [40.107.220.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E370A13E20C; Fri, 2 Feb 2024 11:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.135 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873876; cv=fail; b=FtbTz79SCgIr7ZpgC6tz5c/m8hcnGNjozvy9mAaoPLMUuRnkpj2FBCz+pRsc61G/uOvbZqzOLOsgqAwaJeXZcVgMdvbFBc7779doaZz3aQxSmRYG6Esypm7zsWpgeO0VzBlq5+cT11JEYvwqoUtcGWx7LJuTIgSB1AuvIcHXawg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706873876; c=relaxed/simple; bh=Z8NZsRoUCgtNPmcp3sVNjQgsDDfXTCXEs38kvtlRWmk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=sF3Q5sOhfEp9AUtqXSX0c5G4WssxU3nYfz+O8A9sxtPBa5ntZ2FrL+1tPNq7cpP5vGYmhshiofDGSXGK8xKuN7nvl+AanucOKx52gjdNThdvDYxgPJLp44Cxpc+c2L1WPjAou9RGdBfE9A3/Aotgextxu25gvltWbYgolX1OApY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com; spf=pass smtp.mailfrom=corigine.com; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b=klN0MR59; arc=fail smtp.client-ip=40.107.220.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=corigine.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=corigine.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=corigine.onmicrosoft.com header.i=@corigine.onmicrosoft.com header.b="klN0MR59" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iF0hx/bJNbV6pn9T5jUkIsoB5CpG5s+1Awt1ayftEjI9K3SwnRAsXDTiHjO+LZhQq0Gq1xhCdG6JCHms7g4QZHhVz4ei0vElnL0GF1cY/97rlxu3Fo6/3lVNCUfWTuV+GYoN6s8NR9D3mlz7GuOzpEuDLYwD5N20hDmGLXb+nM2mtgpwQNsoDjVXEQcyzrTRn/dW1wQNj3Iyx/A30cuFryEVX/tZ2lztBUw2fPoLHK/wEQ9GKPrjchMFHS+Vg0pChShWez/EPN1hgbqo2kG6if4RuXSiMQ9PtXQJNAYOg7eOEaj47bSVn01yLAD4FwPzo4Bp0z4dTIWSKJMloK3GEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BJ1QQTkGl4jr+HAoQdgVTbJO/HVLpnMoHJ07RoKN9as=; b=RPamo38UrbqXG1ego5/wHiNzqyOjyiM66jizgRHlwfloYABs/KfJ4oY117QfRIZJgV3Zm3UUa2c1Qrk1fcD5t1Fc0d8LQrVlyMvzUkcvyggVZYOrZEABR+C0cK8u62tur7bF3FMpiC7/oWrUhSjut+WbtBfO6AFQ36av3L90KQmP8L2lhLn6cPiBYPNOd78DTe5a+i9FUbf1Z7F2VaWmRpaZcwPO80Ooo9dHaNEVN0YbGGgcxHJqilX0v9OPySn240I1QVelMB2jxys3lFw2pBuvut9OM4jJEVfObixgUW1ArYndBHy8McIT1CwuDkJ6ZDV1oSppOQV13soWhkSDag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJ1QQTkGl4jr+HAoQdgVTbJO/HVLpnMoHJ07RoKN9as=; b=klN0MR59aSmeXg4AWj5p7vW2P98xMu7yP5GYkCrtkzUH8fQoAcrB+GAnJp4fcW4r1ScqE/1ABLr0GdmJTjx7H8cmUzO1jaq3SYdufdDTOhsm0WTUp6rxs+v/MAofOJllN1Of63+kgdkh7zN4ivzVX/ROXvdyEuHTFJfUsMZGfK8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) by MN2PR13MB3853.namprd13.prod.outlook.com (2603:10b6:208:1e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 11:37:53 +0000 Received: from CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd]) by CH2PR13MB4411.namprd13.prod.outlook.com ([fe80::a58c:f93f:a7fc:c3bd%7]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 11:37:53 +0000 From: Louis Peens To: David Miller , Jakub Kicinski , Paolo Abeni Cc: James Hershaw , Daniel Basilio , netdev@vger.kernel.org, stable@vger.kernel.org, oss-drivers@corigine.com Subject: [PATCH net 3/3] nfp: enable NETDEV_XDP_ACT_REDIRECT feature flag Date: Fri, 2 Feb 2024 13:37:19 +0200 Message-Id: <20240202113719.16171-4-louis.peens@corigine.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240202113719.16171-1-louis.peens@corigine.com> References: <20240202113719.16171-1-louis.peens@corigine.com> X-ClientProxiedBy: JN2P275CA0039.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:2::27) To CH2PR13MB4411.namprd13.prod.outlook.com (2603:10b6:610:6e::12) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR13MB4411:EE_|MN2PR13MB3853:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f247b5a-b541-4b1b-4a3b-08dc23e3646c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vppZHRLRv2ZwBmLtgmDsEWJX3wT83ZL//09Qxr3wrLxaosFU3UnjiGbE+D4JVZdv9grvM+AIgeZpXu3loA/6jwt2kmaGijRozHz1VlP2bVjZ7fvtAZFexYJZIwZF3bsmug2RO2wIW2ziMfbRmPEWtXFGxtntqwIpJ2XTabUExmf2U3wLg0W+nEff9Z5kW5DWvRTnOJ68p6hiboLuXyPZtsMMnE/UbKFz/WK3gFEHbD25B1w1a3Ql08kC3SzmfWUWE+xonUcY6zGpIlfJS/E7OYUZwaKAeJqIJwKeH53DZHrpyuLonJQv67KCGF5OoqHm8JTcpfqQ5i2MYbFvaWQvORwIME5tQtXdwDsKtHaPs/N/vxoC4T7G/OeFAouWsUfCPZTjyAUifkQ0k2sBRhIQx+Mfa7+RCTINDYe4JS9U5hz+LvigYPucT1ubfL67rNCldGDa0/WZ8EvjDaSVOYqbkKvizeU3ca5qO/ALDcAa3v4hFsZVxIczwj1q9RyX1Nml6VFEz2qds4W+lhAZtOj2THQbr0D4dHtcouLhDFXCqt98Vin2eh7JAYLctHr/jTW8rSuhOYM0RtR4riyHnUTaRvsoqsMPW4H3B2GTG6ChXzmi3srS7kxD3zL1+VAwG4dY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR13MB4411.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39840400004)(376002)(136003)(366004)(346002)(396003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(478600001)(110136005)(8676002)(83380400001)(66556008)(6506007)(6666004)(8936002)(316002)(54906003)(6486002)(66476007)(26005)(2616005)(6512007)(107886003)(1076003)(52116002)(41300700001)(2906002)(5660300002)(44832011)(4326008)(38350700005)(36756003)(66946007)(38100700002)(86362001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lGwMxFgNH96CtvxgmsApLroQ37m7zLgoDbza0Ny956f+dLZ9CSsI9z1jtgtgAfQakczpIYdHKpAteZAybAxMM8y1SgIZJ4nEwL0i5XbvjSkJMSvgCyQfm137JsSWB+MB44hsJueFGPQovlQXPmoINzb6rOpwDUYPz9np9czG6HNEpmA15suqr4/KA8h2iWn6dRthNdRaaxLNHJl3mTR5xQ5fsXJ/w3ajIM/gX91MSx53X41L649it1I/SPpZcf5Y1YQEM8/nTvfQeFjxxLICrh96jU88aKaj53r9+u6bLNhFy1l4V/1hxa+VCTAAsJyJBc0Im4FVThOD2EzHPuczNroQVaxduhxinpNSf/bSMWLvr9H23Ssx2RJ8VCDJCIxrX5Bbbq34id/L3dbQNifuthi4uzGJpiOzXt8egRyJoR8jGzAhZ4Hv5r/lifI2LZE/8BmQ30hLks6DPAJZgozPLtXuzIN7SJcM1TNVf9BhuYnMXIAhdGW6SjgOHl46IeTD8BtUvBYQ94C4OSy25FAOGq0LejqXr52k9Pj/ouMsBDeEASxZYWFhB3WnYnYGkkZLZ7R5fOr3DuFJlqi7kHJVHa2o5cqDSS7dwq83ptZjzWKIuLysM2EIqlrV/zGSoP7fL7aA8bbUjyj/u0+kTKdSwrFXnHDvMjZMGDCjtcORf9WqLfwXpI0/KXyjPJkii8wkjy8TYX2XjwTvvb89uaArlxiQ6VNG+P49PzgW1pVP6pKBLCIJySDtAa5aazVXx7jpo91g5nC1H9Ifp7rsnHlcRvQzBU+mbR322fTPVcDZfeF4SjIaFoC4KittuIe9dDQv9hyAE2p4dMr/4K2vCK2lGv/NTCB65rKeyp1CwJRb44ucUpyo6zIXJFIh/XEWz24n/DsqMVCJPM4q0+gBpw6nHgkEkxPzuc849jk57m4HTokw2AgKNxCGXRte73eEdTyBzFJyJsbaCIUcK0P2ctq1cf0F/RvhLd5oMaTZRP5L2ZCwRAnKnmjjEsdpyTFo503c5GvSFf4JdqH4dVGwpq8c6BBn6kaRazdjslgBYrWEzZpBzCamUc7J/Mu6Sby7mlU2oSF5o2ZMSsv02zgYkK9N/kKqIjMnef01siBjJR/TjT1kmCaJNxNcnvWWoittY5DFhRjj7tBaJVnfPUAoS6LBFN5IhhKxvPvlNcIIaibH/woWvlYjHdlo5xPz/OIy+/rU5Ony+7YKeuiAdoELFedKHgz5uKkP7/FKRENHJNGgEa0THw1nW8xSQKUtkQJPbV+EH+C1U9OIuueskICzFfcZv8Fnx0E/5XoAaAobp5ypvFix6APIcp1pAiJbFLfYWGcfRupuNxZT3L28lo8Z9iq9zkZX0BX94flB9uujod2Te1I/i03Ma6mAGe6b7GacX4yS+9fKcUbJyOujx+nL57XrD+xFr38+o4HBiDBBI1KwLm3gl7BeBwAW1iFQnnPUXl2UaNrBnLVkRPH10tG/1DZgQwWZPmAds7px5mkyo0h5a3k3HctQaBWYiv8tA/CaQg6iGs/IK8YMX7/59/XmSgmgg+6POT2DPB0//IN8tdzU9QVZa/VtONzTa/cBOmzsHvTdiBdIeb6rDyC85HU9DdRSEw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f247b5a-b541-4b1b-4a3b-08dc23e3646c X-MS-Exchange-CrossTenant-AuthSource: CH2PR13MB4411.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:37:53.3106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PWhiF3f5V9TFANRTFN0GkNk1MZPuMzqk5oI6SeDudWu7uVhXv52Go93PeLAyu+l29H2EK0c/xWyM9lInzoi0Aw8N/enwPBzHu3GynZcCEbo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3853 X-Patchwork-Delegate: kuba@kernel.org From: James Hershaw Enable previously excluded xdp feature flag for NFD3 devices. This feature flag is required in order to bind nfp interfaces to an xdp socket and the nfp driver does in fact support the feature. Fixes: 66c0e13ad236 ("drivers: net: turn on XDP features") Cc: stable@vger.kernel.org # 6.3+ Signed-off-by: James Hershaw Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 3b3210d823e8..f28e769e6fda 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -2776,6 +2776,7 @@ static void nfp_net_netdev_init(struct nfp_net *nn) case NFP_NFD_VER_NFD3: netdev->netdev_ops = &nfp_nfd3_netdev_ops; netdev->xdp_features |= NETDEV_XDP_ACT_XSK_ZEROCOPY; + netdev->xdp_features |= NETDEV_XDP_ACT_REDIRECT; break; case NFP_NFD_VER_NFDK: netdev->netdev_ops = &nfp_nfdk_netdev_ops;