From patchwork Fri Feb 2 16:15:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13543131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C05C4828F for ; Fri, 2 Feb 2024 16:16:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C9A36B0074; Fri, 2 Feb 2024 11:16:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ACCF6B0078; Fri, 2 Feb 2024 11:16:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E836D6B0075; Fri, 2 Feb 2024 11:16:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DA65E6B0072 for ; Fri, 2 Feb 2024 11:16:19 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 83080A162C for ; Fri, 2 Feb 2024 16:16:19 +0000 (UTC) X-FDA: 81747366078.22.DA63429 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf22.hostedemail.com (Postfix) with ESMTP id 68EBFC0029 for ; Fri, 2 Feb 2024 16:16:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=w9AwuLYZ; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=jITQjR9f; spf=pass (imf22.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706890577; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b0LGZXB2atC7cRDxeVKB29tfMJXHfhbupvuqzgL5H0w=; b=3o1r0H7HNihR/53eeFvXrNdaAGQ/fS6JwfxrJxK2z3eGaPKx72KyB0swuVuYWIgQHium+X HU6qeC1SuzNQYRGA8I2EbEjLz+OQSzNPoIXDZmT2Jz1yjRT/+4WVDcijGUI8WAZVG4y4aX +itcrxJwtnpuuQ/rUL+tmX8P4eerD/c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706890577; a=rsa-sha256; cv=none; b=Efd8BrGTeOIG4dQfIJ6p/9H5kQ2QS/LkeVEdwzPxhrbe1EoWduT8r2UzKgosdUR5QbHiS9 6WXsdUvGiQxFdXo7qgp84WDawuXF5dLyjYRkkQz8bFKg68toE0XgVyixv1dKGZJoVLd/R7 kx0exLZm6RC78ErA8VbzCVXRqbfyI7U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=w9AwuLYZ; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=jITQjR9f; spf=pass (imf22.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BE2FD5C0080; Fri, 2 Feb 2024 11:16:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 02 Feb 2024 11:16:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1706890576; x=1706976976; bh=b0LGZXB2atC7cRDxeVKB29tfMJXHfhbupvu qzgL5H0w=; b=w9AwuLYZjR/BP+cqnv3LMOCFQHBsCSwi895LQemcBc+Vo5ZToOt HCHtnMIu+rwnyKxCfClEPDT0/5F+CkwVbcGInCTjWeCWmRjStV7xls7XKOArtfsI w5V3vmmkw+KiHx2VdkyMZ0QacA6O+hqiEA/i4E9XOJ9z+Q/x3xQMDQ8arvA/lk0g BqHpu1wNeN9kn2L6C96cJ1thlhPyVv97m93rRRo8gewh7pXpNJHfVbnhc94d+/OT 8eny1dAyhp8oVMCHXdhdF/yxvyNKMP/6aOC8MZKzfU4jhN/6nuOWJw7hUSqswAT0 if8thmyelZ6EE/eBsHrgVEmiLME2G476qSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1706890576; x=1706976976; bh=b0LGZXB2atC7cRDxeVKB29tfMJXHfhbupvu qzgL5H0w=; b=jITQjR9fZ4vUH7jpIKUSGUf69CmGaNlTyKWC7zCok4dJZu5NM+M tfqbsksM2p0nTWynjXbTfU3uIPh+tzf0SEH3sdEbK6yLqYCUcsSri81slnPWg0Vl +tv7SmGQ6GXwLg/uEogMGAdWcRQ2uUpLFNRY5TeNJYaKuyqHrI9LDFZyoAHDTJrv laJlFvAREQb49Osr7ozT8+HHU7Do0nEFj3n2Ks80KnGAxDm5blkXMdpNaQpb5tkl znMVFC71CcxwrGQpSwLwE8Et4YppV1zGIp7VMnNW8+rHy1e+kLti4NGDKwzC/JLD oTrbPSupWq5z6Db9SfEWk+3EevvpLfpHAYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedugedgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Feb 2024 11:16:15 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v3 1/3] mm/compaction: enable compacting >0 order folios. Date: Fri, 2 Feb 2024 11:15:52 -0500 Message-ID: <20240202161554.565023-2-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240202161554.565023-1-zi.yan@sent.com> References: <20240202161554.565023-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: 68EBFC0029 X-Rspam-User: X-Stat-Signature: 67u18149jnghen93ddg1u8x5anqawt3b X-Rspamd-Server: rspam03 X-HE-Tag: 1706890577-231540 X-HE-Meta: U2FsdGVkX1/pi/ZZcPHMp7troicR2TTPfgB6877X79poFozGgSC4SHEOZXE6KuHY2dz8XZIWXNeR9C/Hc3+LmeXbM88Ss0nshvjGcXxCYZbjUN/x0dT19KdRAhyt+QwSp0E4kW2jGv27F0jTOUb8B8uVHBboS5vHKS9lcX2nIgpsEWNtnUekNdk45E5xoI9bUwVWqrzLMA1pS8Ppn8W8RlRBUwuv1vD/BiQvAyajKSc9BxBlh41Uk3/LSKEuWQ4zvSDu6lWVD45A7cOTYNU5L4HzGfNwupLJbxBL90JCzCHdNNp4tPo3Q77LGNni3PbMkpurorqsBR/GWKY3qRZmg06p/BOhLXShVnqGO8xV3qCB8+bFZGKmyYKw189o9EOPPMvyLM1E38LckcyI941b3EL2+uQG6kGVAzavoJmbCBtK1TdboEdXGfyC+8CGXdMHvr0VZ1T5rWvfc0OhuOfZV1ya2ifyfqHJsRAFSP+BZFzPMMR/S8iu6Ds7Z7It4JJFf1NcsQZQ6W9U5PytNC7r7uJLEVbaGiFRgpoYo/7xmQjL/dS5qxT3R5IJpqx/GtvlJQWQ7fxSTTDAJINpMTK4INI3p1gZazhqT2IsoSAcj5Kx0HLK43MHkt3OtpXiIYsbgUZjJaBeMRtfxGsoTjd71d1XgxDk5imOhaHyPnzAKy4JatnRe9qB1Lho7uEXZL75+0ErJSfKUNPqsLMQH/0uYXJlXK7O9Mvoy39b27YB/28M1hXVOPCZGj615TLhg23o2MqcTo1TzKfYO8/meQRlZVoVKdPV9ZeQsl56+aia63JvTsmuRY+S1s9nIZwimehcEPtVBEQ/uSRvhDIRVM47/vQlzmafY1GNIZcd9lhOwHrLbrN7Ce9LLGW9O6aDuPuLLgYCPXk3NXXd75G751vDFiW5dmLyBynMPwLWXajIqAxYnmQfaRnT0Nx/E79vjCbwGGwnFyATiSjwsyQAaJM Mq6uKDTl uwNwajxntoRsiHtOJSAxhtJ6TVz8PglywVQbXoZOLFGMtIKzs6pQ7D9qjFY83OyuB1CcUEsT/mxyYPuYV17tUKBWAs0jnX/QOAEFrjThyU7VWnRZUV2WDBnTYoj/VHj8tlp6WAByLCX5kcFqWelAEEKIEQN3scMMKKRXiW8LxmdDPm8HFP1D/OSo4xV2Ba3KQjm58WTq23EFYcFHz/4aksBeSNkoqqQAftorL7MaWf8BARiSLJ7CMrIx5o79Msblu/02/aETs8hDyqbjYUvEaoXorDkgKDxLuttdfxV/lPNUHy8tqYc4jMllOd3CIKb4CE2P36EiX53+37FjO3Izbu8ErsF5MCX21IsvBqfBWnBr1wRhe/0l8/HjaXtRJHNx1mYjU9TtJjYNIUqK35WC+qTAw4A3aOfypIQtd1VLyN8wtcGZzqG+WyMp12lsU6WGtsGeQgd1DiyUfA64JKNjoIPtbQK32N9L+dbvR9TSAnRg/SYjQNJJj6DzOJGq2zmNsy8R2JXjKLhi7CWYanBunOROPsaT0FCZxSLg1//efe451HDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan migrate_pages() supports >0 order folio migration and during compaction, even if compaction_alloc() cannot provide >0 order free pages, migrate_pages() can split the source page and try to migrate the base pages from the split. It can be a baseline and start point for adding support for compacting >0 order folios. Suggested-by: Huang Ying Signed-off-by: Zi Yan --- mm/compaction.c | 43 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 4add68d40e8d..e43e898d2c77 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_control *cc) return too_many; } +/* + * 1. if the page order is larger than or equal to target_order (i.e., + * cc->order and when it is not -1 for global compaction), skip it since + * target_order already indicates no free page with larger than target_order + * exists and later migrating it will most likely fail; + * + * 2. compacting > pageblock_order pages does not improve memory fragmentation, + * skip them; + */ +static bool skip_isolation_on_order(int order, int target_order) +{ + return (target_order != -1 && order >= target_order) || + order >= pageblock_order; +} + /** * isolate_migratepages_block() - isolate all migrate-able pages within * a single pageblock @@ -1010,7 +1025,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, /* * Regardless of being on LRU, compound pages such as THP and * hugetlbfs are not to be compacted unless we are attempting - * an allocation much larger than the huge page size (eg CMA). + * an allocation larger than the compound page size. * We can potentially save a lot of iterations if we skip them * at once. The check is racy, but we can consider only valid * values and the only danger is skipping too much. @@ -1018,11 +1033,18 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, if (PageCompound(page) && !cc->alloc_contig) { const unsigned int order = compound_order(page); - if (likely(order <= MAX_PAGE_ORDER)) { - low_pfn += (1UL << order) - 1; - nr_scanned += (1UL << order) - 1; + /* + * Skip based on page order and compaction target order + * and skip hugetlbfs pages. + */ + if (skip_isolation_on_order(order, cc->order) || + PageHuge(page)) { + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; } - goto isolate_fail; } /* @@ -1165,10 +1187,11 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * folio become large since the non-locked check, - * and it's on LRU. + * Check LRU folio order under the lock */ - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) { + if (unlikely(skip_isolation_on_order(folio_order(folio), + cc->order) && + !cc->alloc_contig)) { low_pfn += folio_nr_pages(folio) - 1; nr_scanned += folio_nr_pages(folio) - 1; folio_set_lru(folio); @@ -1786,6 +1809,10 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + /* this makes migrate_pages() split the source page and retry */ + if (folio_test_large(src) > 0) + return NULL; + if (list_empty(&cc->freepages)) { isolate_freepages(cc); From patchwork Fri Feb 2 16:15:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13543132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD69C48295 for ; Fri, 2 Feb 2024 16:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07F686B0075; Fri, 2 Feb 2024 11:16:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1FDF6B0078; Fri, 2 Feb 2024 11:16:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9A296B007B; Fri, 2 Feb 2024 11:16:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C6DB46B0075 for ; Fri, 2 Feb 2024 11:16:20 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8B5B91C1278 for ; Fri, 2 Feb 2024 16:16:20 +0000 (UTC) X-FDA: 81747366120.11.A7CB9C2 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf29.hostedemail.com (Postfix) with ESMTP id 74F21120021 for ; Fri, 2 Feb 2024 16:16:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=lhM618jh; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=e2ioDS5k; spf=pass (imf29.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706890578; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o4ZHby28qW9Br68l3xQuwrxRewdgnvINZod3R2hEUmA=; b=skZjweJd10UueR74iZKATfoBBPrYlnkiwbsahJhJAO0MreLeTFqFS0Hs/nJkxegjBpoMN6 djTsigwIEtgZ7OuZ5PPJ0SDgJotBo+tn+Cp9tGUtBxZJQoS9Tkbhpel4xztJ3qPRcFgKuZ htMZhjrIZpZcC4/8bFBE/VM3ZWgUUHA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706890578; a=rsa-sha256; cv=none; b=N7r6UrfMBvUyF40KzhJpNNgMrOqnKoVQGoIB8Kbx/s9XrxRkIOcj/AQge9l6cvkCOmZXwJ pV5jOSjms1v2GBF/+xA4/OvudkXAM1rslyHoIBVWNUTyu8zF+t4pTKMBmi5YuaZt3bSRS4 et68LStNpIKEvXA3ccJxuoDw6sYdfyU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=lhM618jh; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=e2ioDS5k; spf=pass (imf29.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id B700A5C0114; Fri, 2 Feb 2024 11:16:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 02 Feb 2024 11:16:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1706890577; x=1706976977; bh=o4ZHby28qW9Br68l3xQuwrxRewdgnvINZod 3R2hEUmA=; b=lhM618jhymHQnFbLbCt+r46OvZFgJtpfYZ3fhNFVgoCcA4vTC2Q g9EO99bpRcHozcg/vMH9orlQP8aHtaZAr1awhEGRIaaGXXum3Km9pmXcBTgGsY52 1+pPA9sAlyrIqoxDey32ZXg4Te+KQL5O/uZkHLWB94pDA83hfmCYeky2i9qPj3Zp WMpql6Wsmi1imreyNZj+Mh5pFKZpQm/1ReljfsaCG836ZR4guEdvx9M5cebwzNF8 uhvWaxD52rKjpnuRlOgbLwl39Bs9TS9DRB8Cv/1iCvbG+eKi6DMAy3xJDddtwfCr qs/j38QqYk4wIOjozpn7zpU7zgMjaS5Jcmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1706890577; x=1706976977; bh=o4ZHby28qW9Br68l3xQuwrxRewdgnvINZod 3R2hEUmA=; b=e2ioDS5kjM6BcqcbT+gOOout9yH+3tSdGcVMChoY906dfx34kLi fntipjO2M5+S3PYf6NMKP79nH3jLLlNdRr6CoO9t2SSVUTI44IXyoAwAi1H0gmQd f8PP9Mrt3TsZjBNxiE12j+RM92qYm8nAc9HQPAd6TjZbRvq91qVeBKBX+kZJRSzt o7S5ZP/yXjaKpX7x9YS3hoRJz53h3/KYIbGYWNAoFQ30QFYeDXzd7gyR3PLiIAo6 6kD5QOVLN3U05YnaR1bAlI8RLRUCbVWJQwPze6WZi8edqHXZiI1D4vih+Mfv77om MFBAAFlZK3FXyEcx9RJsr2R2ptDH/LMOYbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedugedgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Feb 2024 11:16:16 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v3 2/3] mm/compaction: add support for >0 order folio memory compaction. Date: Fri, 2 Feb 2024 11:15:53 -0500 Message-ID: <20240202161554.565023-3-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240202161554.565023-1-zi.yan@sent.com> References: <20240202161554.565023-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Stat-Signature: f4jtnqaa51kapyihb4k5a191h3srsiai X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 74F21120021 X-Rspam-User: X-HE-Tag: 1706890578-280352 X-HE-Meta: U2FsdGVkX1+s0ACURPqy5qLst7XC+vB881NN0MBPhriHyKumpW1hOfWyi3+C/UE5w2s1MVMPIiKHZ0Ptt1toqpxNGdNttIdWdMYteDDTw1WPlOjINsO4CB6hk7W9lNEXw2gi8Mojh8YByjWp7fbeBhlkHWuf54p8RSDgnO8fAdRBooi5pdz7qypF8Prk0iqPulXWtA3Hvf+G/PfSL8eGA7s7TXydYoaZ07E0ne56XwF280HObvf9g/rw3SMC5pvYxIXC2mvRDPjxeo+0pgeE5saPsT92q+6oehtjoCdgMfp6f/Q5Pz/23yXMifVIyRIIhoAq3DWKWynEcYd1+rLkQHykDqSRRwUxqGS8A5f0yAxwPA10EiUBFnBHYajHxiJm4/gT/gvjF+wur5XhIahm+bDFXcsAD9zH/eXeOBDo3XXMe/hx2KrNJg/KEVn7Nq6mZ6mvE+0D9eYn/SpEco90wh2MjMg6Cz6zFo5taj1m+zaWon29mT8+PX0/r5OaZCuHq1H4ByjQvPnUq69D4f+PCnPvShpSWw9D1nSY7dsCKE4NNErxxXReiaU5sD4I+oGdG+FU28SF/8t8MFEUH4JRikqN4sMNoO13Jo5FlS7JzLmR5Kzm+Cf2RWb37XKlOswq8TLhfcwOn0IRHSFtKivIal6xeUSnatxW484KB9aXPnI+N6DoPykcR+IhgQtPXcxFt4vYpB3981lt6aRedQY4Qdqjmzi5ooFDyvRR4M73GurA/orZJzkUuf2EDdqf0/C3AvlqLtn99gjoZ3DEG1nSf30igYV4cf40JWKEpLesKvOu33MrA/6pO9xm2Cvrj594qcAywB1vUDE6oQyMFVFl0aMJw3WT/ZfGT9/x6HvffOfqy7xB3jbovd9If7CImbfDkuxa7EEMCuK9uIl51nXTA+N749L0swSMzewU/qPyTEEEmJ8b5LZySY2NB8FLQJHbta7ibGB5zA6chxVCXJd hHCVvqzT YTSWIhznBjc1NVNsOLSgzDJWISaD/zIoyeXg00LQHxQzya2WMZOA+OaQmes7InoOU3d2gcguCj6g/1t/rl3iPY+Eid7XRSB7q+tihegGXtCK/xhusmRgAB8su5B8f1wFiPuyWmBOq9oIdK2Jl1Muu3TRzR/Dfq1+CsbR1WYDkDDOVTGis19T1am2p70YRQFmOF3CY/ACFSy2TRULGQRjonRT9Br3LzhRlHELOf/5JQF9bqn+34n8SnkdhiQWQNG2nyA1HGwoWPsrmP/haLdkOFqEkB7BjL09UKrDsNLqQyt0x/jUqpkS04sJz9GvlftjGQgTpWe3NaJTs2qdoS7egTwnFy8jcAG4XIg+RqExehghbFkWzq9+sn3BdJBfftM+5K0C+O4+43mAATqxijZaPqbCvYf0DxzSJIfvQPooUHgpFM0z9xylBuqY8F7v7aHTqACmR1H0/GqItT9HOUxi5qQcYOxic5I7oqnDB9MEquw2mIbMXU6r7LFaLzoMBGxQRgTJDGHyoMDx5Mek= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan Before last commit, memory compaction only migrates order-0 folios and skips >0 order folios. Last commit splits all >0 order folios during compaction. This commit migrates >0 order folios during compaction by keeping isolated free pages at their original size without splitting them into order-0 pages and using them directly during migration process. What is different from the prior implementation: 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page lists, where each page list stores free pages in the same order. 2. All free pages are not post_alloc_hook() processed nor buddy pages, although their orders are stored in first page's private like buddy pages. 3. During migration, in new page allocation time (i.e., in compaction_alloc()), free pages are then processed by post_alloc_hook(). When migration fails and a new page is returned (i.e., in compaction_free()), free pages are restored by reversing the post_alloc_hook() operations using newly added free_pages_prepare_fpi_none(). Step 3 is done for a latter optimization that splitting and/or merging free pages during compaction becomes easier. Note: without splitting free pages, compaction can end prematurely due to migration will return -ENOMEM even if there is free pages. This happens when no order-0 free page exist and compaction_alloc() return NULL. Signed-off-by: Zi Yan --- mm/compaction.c | 149 +++++++++++++++++++++++++++++------------------- mm/internal.h | 9 ++- mm/page_alloc.c | 6 ++ 3 files changed, 104 insertions(+), 60 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index e43e898d2c77..58a4e3fb72ec 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -66,45 +66,67 @@ static inline void count_compact_events(enum vm_event_item item, long delta) #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) #endif -static unsigned long release_freepages(struct list_head *freelist) +static void init_page_list(struct page_list *p) { - struct page *page, *next; - unsigned long high_pfn = 0; - - list_for_each_entry_safe(page, next, freelist, lru) { - unsigned long pfn = page_to_pfn(page); - list_del(&page->lru); - __free_page(page); - if (pfn > high_pfn) - high_pfn = pfn; - } - - return high_pfn; + INIT_LIST_HEAD(&p->pages); + p->nr_pages = 0; } -static void split_map_pages(struct list_head *list) +static void split_map_pages(struct page_list *freepages) { - unsigned int i, order, nr_pages; + unsigned int i, order, total_nr_pages; struct page *page, *next; LIST_HEAD(tmp_list); - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); + for (order = 0; order < NR_PAGE_ORDERS; order++) { + total_nr_pages = freepages[order].nr_pages * (1 << order); + freepages[order].nr_pages = 0; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned int nr_pages; + + list_del(&page->lru); - order = page_private(page); - nr_pages = 1 << order; + nr_pages = 1 << order; - post_alloc_hook(page, order, __GFP_MOVABLE); - if (order) - split_page(page, order); + post_alloc_hook(page, order, __GFP_MOVABLE); + if (order) + split_page(page, order); - for (i = 0; i < nr_pages; i++) { - list_add(&page->lru, &tmp_list); - page++; + for (i = 0; i < nr_pages; i++) { + list_add(&page->lru, &tmp_list); + page++; + } } + freepages[0].nr_pages += total_nr_pages; + list_splice_init(&tmp_list, &freepages[0].pages); } +} - list_splice(&tmp_list, list); +static unsigned long release_free_list(struct page_list *freepages) +{ + int order; + unsigned long high_pfn = 0; + + for (order = 0; order < NR_PAGE_ORDERS; order++) { + struct page *page, *next; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned long pfn = page_to_pfn(page); + + list_del(&page->lru); + /* + * Convert free pages into post allocation pages, so + * that we can free them via __free_page. + */ + post_alloc_hook(page, order, __GFP_MOVABLE); + __free_pages(page, order); + if (pfn > high_pfn) + high_pfn = pfn; + } + freepages[order].nr_pages = 0; + } + return high_pfn; } #ifdef CONFIG_COMPACTION @@ -583,7 +605,7 @@ static bool compact_unlock_should_abort(spinlock_t *lock, static unsigned long isolate_freepages_block(struct compact_control *cc, unsigned long *start_pfn, unsigned long end_pfn, - struct list_head *freelist, + struct page_list *freelist, unsigned int stride, bool strict) { @@ -657,7 +679,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, nr_scanned += isolated - 1; total_isolated += isolated; cc->nr_freepages += isolated; - list_add_tail(&page->lru, freelist); + list_add_tail(&page->lru, &freelist[order].pages); + freelist[order].nr_pages++; if (!strict && cc->nr_migratepages <= cc->nr_freepages) { blockpfn += isolated; @@ -722,7 +745,11 @@ isolate_freepages_range(struct compact_control *cc, unsigned long start_pfn, unsigned long end_pfn) { unsigned long isolated, pfn, block_start_pfn, block_end_pfn; - LIST_HEAD(freelist); + int order; + struct page_list tmp_freepages[NR_PAGE_ORDERS]; + + for (order = 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&tmp_freepages[order]); pfn = start_pfn; block_start_pfn = pageblock_start_pfn(pfn); @@ -753,7 +780,7 @@ isolate_freepages_range(struct compact_control *cc, break; isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, &freelist, 0, true); + block_end_pfn, tmp_freepages, 0, true); /* * In strict mode, isolate_freepages_block() returns 0 if @@ -770,15 +797,15 @@ isolate_freepages_range(struct compact_control *cc, */ } - /* __isolate_free_page() does not map the pages */ - split_map_pages(&freelist); - if (pfn < end_pfn) { /* Loop terminated early, cleanup. */ - release_freepages(&freelist); + release_free_list(tmp_freepages); return 0; } + /* __isolate_free_page() does not map the pages */ + split_map_pages(tmp_freepages); + /* We don't use freelists for anything. */ return pfn; } @@ -1481,7 +1508,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) if (!page) return; - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); + isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn == end_pfn && !cc->no_set_skip_hint) @@ -1610,7 +1637,8 @@ static void fast_isolate_freepages(struct compact_control *cc) nr_scanned += nr_isolated - 1; total_isolated += nr_isolated; cc->nr_freepages += nr_isolated; - list_add_tail(&page->lru, &cc->freepages); + list_add_tail(&page->lru, &cc->freepages[order].pages); + cc->freepages[order].nr_pages++; count_compact_events(COMPACTISOLATED, nr_isolated); } else { /* If isolation fails, abort the search */ @@ -1687,13 +1715,12 @@ static void isolate_freepages(struct compact_control *cc) unsigned long isolate_start_pfn; /* exact pfn we start at */ unsigned long block_end_pfn; /* end of current pageblock */ unsigned long low_pfn; /* lowest pfn scanner is able to scan */ - struct list_head *freelist = &cc->freepages; unsigned int stride; /* Try a small search of the free lists for a candidate */ fast_isolate_freepages(cc); if (cc->nr_freepages) - goto splitmap; + return; /* * Initialise the free scanner. The starting point is where we last @@ -1753,7 +1780,7 @@ static void isolate_freepages(struct compact_control *cc) /* Found a block suitable for isolating free pages from. */ nr_isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, freelist, stride, false); + block_end_pfn, cc->freepages, stride, false); /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn == block_end_pfn) @@ -1794,10 +1821,6 @@ static void isolate_freepages(struct compact_control *cc) * and the loop terminated due to isolate_start_pfn < low_pfn */ cc->free_pfn = isolate_start_pfn; - -splitmap: - /* __isolate_free_page() does not map the pages */ - split_map_pages(freelist); } /* @@ -1808,23 +1831,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + int order = folio_order(src); - /* this makes migrate_pages() split the source page and retry */ - if (folio_test_large(src) > 0) - return NULL; - - if (list_empty(&cc->freepages)) { + if (!cc->freepages[order].nr_pages) { isolate_freepages(cc); - - if (list_empty(&cc->freepages)) + if (!cc->freepages[order].nr_pages) return NULL; } - dst = list_entry(cc->freepages.next, struct folio, lru); + dst = list_first_entry(&cc->freepages[order].pages, struct folio, lru); + cc->freepages[order].nr_pages--; list_del(&dst->lru); - cc->nr_freepages--; - - return dst; + post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + if (order) + prep_compound_page(&dst->page, order); + cc->nr_freepages -= 1 << order; + return page_rmappable_folio(&dst->page); } /* @@ -1835,9 +1857,17 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) static void compaction_free(struct folio *dst, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; + int order = folio_order(dst); + struct page *page = &dst->page; + + folio_set_count(dst, 0); + free_pages_prepare_fpi_none(page, order); - list_add(&dst->lru, &cc->freepages); - cc->nr_freepages++; + INIT_LIST_HEAD(&dst->lru); + + list_add(&dst->lru, &cc->freepages[order].pages); + cc->freepages[order].nr_pages++; + cc->nr_freepages += 1 << order; } /* possible outcome of isolate_migratepages */ @@ -2461,6 +2491,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) const bool sync = cc->mode != MIGRATE_ASYNC; bool update_cached; unsigned int nr_succeeded = 0; + int order; /* * These counters track activities during zone compaction. Initialize @@ -2470,7 +2501,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) cc->total_free_scanned = 0; cc->nr_migratepages = 0; cc->nr_freepages = 0; - INIT_LIST_HEAD(&cc->freepages); + for (order = 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&cc->freepages[order]); INIT_LIST_HEAD(&cc->migratepages); cc->migratetype = gfp_migratetype(cc->gfp_mask); @@ -2656,7 +2688,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) * so we don't leave any returned pages behind in the next attempt. */ if (cc->nr_freepages > 0) { - unsigned long free_pfn = release_freepages(&cc->freepages); + unsigned long free_pfn = release_free_list(cc->freepages); cc->nr_freepages = 0; VM_BUG_ON(free_pfn == 0); @@ -2675,7 +2707,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) trace_mm_compaction_end(cc, start_pfn, end_pfn, sync, ret); - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); return ret; diff --git a/mm/internal.h b/mm/internal.h index 1e29c5821a1d..c6ea449c5353 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsigned int order); extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int order); + extern int user_min_free_kbytes; extern void free_unref_page(struct page *page, unsigned int order); @@ -473,6 +475,11 @@ int split_free_page(struct page *free_page, /* * in mm/compaction.c */ + +struct page_list { + struct list_head pages; + unsigned long nr_pages; +}; /* * compact_control is used to track pages being migrated and the free pages * they are being migrated to during memory compaction. The free_pfn starts @@ -481,7 +488,7 @@ int split_free_page(struct page *free_page, * completes when free_pfn <= migrate_pfn */ struct compact_control { - struct list_head freepages; /* List of free pages to migrate to */ + struct page_list freepages[NR_PAGE_ORDERS]; /* List of free pages to migrate to */ struct list_head migratepages; /* List of pages being migrated */ unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5be4cd8f6b5a..c7c135e6d5ee 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struct page *page, return true; } +__always_inline bool free_pages_prepare_fpi_none(struct page *page, + unsigned int order) +{ + return free_pages_prepare(page, order, FPI_NONE); +} + /* * Frees a number of pages from the PCP lists * Assumes all pages on list are in same zone. From patchwork Fri Feb 2 16:15:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13543134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28ACC4828F for ; Fri, 2 Feb 2024 16:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E2DC6B007B; Fri, 2 Feb 2024 11:16:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 890C06B007D; Fri, 2 Feb 2024 11:16:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695666B007E; Fri, 2 Feb 2024 11:16:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 54FC46B007B for ; Fri, 2 Feb 2024 11:16:22 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 21367160F8A for ; Fri, 2 Feb 2024 16:16:22 +0000 (UTC) X-FDA: 81747366204.27.D851BBC Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf09.hostedemail.com (Postfix) with ESMTP id EC1F614002C for ; Fri, 2 Feb 2024 16:16:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Q6BNiPci; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=w3EzSPMY; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf09.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706890580; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Srz2TBF5bSmmDzT+fRItHrkdBt/FNKVEiEoyh1M6V+0=; b=hkY1IeX+MKjjx3ryRSrm2+RjWeqf7K7rCDFJ45zUT4j6mW8bhApTzLK6LMscZsODbpiegt 2nXMSl6D13s2Ptst565rYn90escamo6coVtmAp0SOpCQ6ied+WH5QykYxd/8Jp3PA7OLww HcwQON0gXieHCh0UtDWVwAXrjybIz6A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Q6BNiPci; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=w3EzSPMY; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf09.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706890580; a=rsa-sha256; cv=none; b=RpsFYr2EP75SuIeLozCIKhz+MF/q0T2Q2hwVi8QX74yjzZfaemCGlqmCg3RgjyleKKYSzK ut/wTEXXthzRJZJZyoEeiBB+iAHvleNymZrrNnAd8vN0C0T61x3LZ7XvXmxknD3ZIV2cYS T0rtGCdWKNkgeRTavCng01O4OBTqmJc= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 450FD5C0108; Fri, 2 Feb 2024 11:16:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 02 Feb 2024 11:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1706890579; x=1706976979; bh=Srz2TBF5bSmmDzT+fRItHrkdBt/FNKVEiEo yh1M6V+0=; b=Q6BNiPcizadAd+EZgLpzobSWkpvEDzg+ntUAZW2HFba3/Lbpme2 O8sD/KsTLcClEooEDS+rgni1VKTOJVvjKG2BECTjNiNda9PMom5VpxTwxk+kmX9g 5SJAxrVHTNtZxoS5jAUi56r/D8XWcS0OJh2+HEwhuwHmt1t9F6ixsOpYuh0Z62lf jsolvlGzfHgQFVTRoeCZd2VaMnTaM1ocYqJaIOR1z9/NUXsfDnUeuUp37YoN3RGo h9R7gudHRW7KTw4tSyeCZ1fkU5pRSQ2k5vAl5Zfe3Gl+tFLgCwcmgP1//oQ2W0+0 ZAsBefLjP95IPfEJx9zsNtGrcaHxRnXII7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1706890579; x=1706976979; bh=Srz2TBF5bSmmDzT+fRItHrkdBt/FNKVEiEo yh1M6V+0=; b=w3EzSPMYiSxw7VrU6CcZVS7tnyWg0o5f4EO+FRuCOUgJup6WH3A gUN6QtlNYcx+Xn13uj0UTgRkf7/WGHrUMYbh0SZWawyQ1VsQMjqfWMGZIYZFIdqB TgfodME8fk/7pVIskKCsZPmLBTaZTRcAhff4gV09XWLcq2pcbc6xc//W7iVxO8y1 k6Mv24maaJmmjZhsBbAUxbjFqyQp+8mkxO3FQkx6tvJUlZgqg+MLuMvmItlouDmy QqdBcxCFwfun+0ZBRcIHVEJ2iA/lBy8U/xlgdDOcFYEGbzGP8Vtg7NECbWUCEn7U NABFdFaLw/It9y8LVlvkv8GiKqoNy+b8vYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedugedgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Feb 2024 11:16:17 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v3 3/3] mm/compaction: optimize >0 order folio compaction with free page split. Date: Fri, 2 Feb 2024 11:15:54 -0500 Message-ID: <20240202161554.565023-4-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240202161554.565023-1-zi.yan@sent.com> References: <20240202161554.565023-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: EC1F614002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ygwem5whu8n9scgp9aq3mutasdd5ho9p X-HE-Tag: 1706890579-988553 X-HE-Meta: U2FsdGVkX18F7G+fUlIqRXVk98+oUsk/LUZS4hzlJ3kxKANlS1CdLnNadqstw5rckGe5ilwwIb+0iwEYwvXFj8Pm0c3LxA/H8nGFHSKFlfN/bXPXolus01NhKdMhIvE+PcteX0eXQvWHTA1a5YaceJGmo/UrjoJWCNSKBigLUb6b5ld0UZyj8YfOJQHtgWlj5f8YLZXx0l48vlVpfEpRT/49d8ZUfEgzRfz6ROlL05xc+m8WvFyOdXqRPpDxZmFVjvnMC2hP92TfdT+eCgjeKxsorDlp2msCXmgfPZxbCv7pTGVwABdcGBLkiaNUhGQmpZ6iuhSipLRzPx0hbC8sRBuN1kMAoZrT78T1UQhPPwo7S92WzHrr88HoXKFADhnnrRICAy9oXU3It2CjeqOpz7bxO9EmmCK92ufWW5gugBwLPbdX4SN3HKiABzFZAc8O0/Ju2IfhN6g4UdKji7Am5gO3rPofjTnKsjNUiNUBL79yGY1oXXBO2juSAQQOpSX9NAj/skW//knZOBOSyUL+MvsezQUuZ+In/2zF3ny0uGMr6ZLV5vlLG7tMhX/SAaY7D+dUmE5Z3O/Xx/58DORbYa/u3y2iRogFmkR9lYU1KHKceO6NSGXYX8vHlPA0LJ33B9woLariGijdkOkoss4n4L3B5ebPFXBRkrS0JRVfMngya6cM+2thlXOAFPtmP07XLwTSjTZouUA9GqaitKUfcfFt65mlQ3LbZCRt6mFZ9pba3rfNIjAqGeSdmvlzF3eI79GFR/+06kaDEsldu39MQAXTTWRa32oy4uEfmGF1GgmUU7SBZGAFa8IwmkC5JtLwX7Iei08/Jt9sYzmda9p7/Mdc3kbhJ5hx98sKHIcH1O4ipDYUXft76pfdmCi1BACmtAZdx5Xze9ffLbL2Cd/o64MK1EEhSBK1Rf6X7O37NI8IBD443xC2+Q7jKCsBtQdfvFERyjuvmMmIX793JCK xgbCragq OuoI+5zxxYKyVacglIVk9j7K6HpVNR8iB4KHhKC8NGf+W2ORKCdmdH8gOMt2PAhbVjRW69qmNF8dcSSz/zMkEvoDHNae29VGid+OVPCKQo+EDHO7n+En/Umho/KnXEhGKPh3tR0tPTwAFg4r2Jhj6LwaWcoVDlyRAccShoW00rygUNXesK3NTNPA+VY6umLnHzuJQPoXAds8elPyU4dT+Ggh3Z2Xlvyk6ii1JxRse6uNgnbGpyFIRJ7neKB8Bbb40YMgsRj5Xu7qqFulavdyZLY4K+l2eawcJrkLI/dUfxFmVMPZr9S/zW41dua8ge8GxsatjELCENY+o/8di6apNw7vEu4/waYn+NCBjG1o1Nd4nTR1FKfv/GWfZcFkdr1ZQfYzSK5TAbB8k83nNAZHvg+xL9NNvRbnHwDjgkzDwsU2JMb3a/UYpOzal1bfHWuE+Kwfg8rrfYxWAF9vpU9ztakfTqo+aJRwP1N9aNA8MtOvSpvPQ9T8Kk0rErt1uJvUxFPRX9g5+6kJrFz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan During migration in a memory compaction, free pages are placed in an array of page lists based on their order. But the desired free page order (i.e., the order of a source page) might not be always present, thus leading to migration failures and premature compaction termination. Split a high order free pages when source migration page has a lower order to increase migration successful rate. Note: merging free pages when a migration fails and a lower order free page is returned via compaction_free() is possible, but there is too much work. Since the free pages are not buddy pages, it is hard to identify these free pages using existing PFN-based page merging algorithm. Signed-off-by: Zi Yan --- mm/compaction.c | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 58a4e3fb72ec..fa9993c8a389 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1832,9 +1832,43 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; int order = folio_order(src); + bool has_isolated_pages = false; +again: if (!cc->freepages[order].nr_pages) { - isolate_freepages(cc); + int i; + + for (i = order + 1; i < NR_PAGE_ORDERS; i++) { + if (cc->freepages[i].nr_pages) { + struct page *freepage = + list_first_entry(&cc->freepages[i].pages, + struct page, lru); + + int start_order = i; + unsigned long size = 1 << start_order; + + list_del(&freepage->lru); + cc->freepages[i].nr_pages--; + + while (start_order > order) { + start_order--; + size >>= 1; + + list_add(&freepage[size].lru, + &cc->freepages[start_order].pages); + cc->freepages[start_order].nr_pages++; + set_page_private(&freepage[size], start_order); + } + dst = (struct folio *)freepage; + goto done; + } + } + if (!has_isolated_pages) { + isolate_freepages(cc); + has_isolated_pages = true; + goto again; + } + if (!cc->freepages[order].nr_pages) return NULL; } @@ -1842,6 +1876,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) dst = list_first_entry(&cc->freepages[order].pages, struct folio, lru); cc->freepages[order].nr_pages--; list_del(&dst->lru); +done: post_alloc_hook(&dst->page, order, __GFP_MOVABLE); if (order) prep_compound_page(&dst->page, order);