From patchwork Mon Feb 5 12:44:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85EFEC48298 for ; Mon, 5 Feb 2024 12:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7GsrTe7psxd8eZteIVShDIlP5RapRit7lRvJod/H+hk=; b=MAUEMvjHOLB5rh q8I7egQk4tbQ9rg+6XAk72bAmRJCYkxpzryOxeUTTS+6mb6zPQem/SPQ0/cPjfD5FyjxnfW6TxZ++ HcaUXDZ9W6uYhW76+eVeyAt6gZJ8G+FUoxFETBEJd21ULWny5EKFTxxOSJm1cvlie6CU15coOZX/S +0M0heWh6Shjz+/L3+m85jU0uZ7Sh3gw5WgiSH7kkUqsxNeHBBFxiA2/IHEv9pYzfT3m+3VN5aMgX f+vW1QN9QCuq+ZMEbc91NCuzh5bP9bMroLBZEm+d1hG2g0tOhe3bN+w54YXZByPfafu5y0VRr54i/ TZKYeHwFDC8XN2NohNng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLk-00000003Fzq-3odQ; Mon, 05 Feb 2024 12:45:24 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLf-00000003Fwn-3gPL for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:21 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40fb804e330so39835575e9.0 for ; Mon, 05 Feb 2024 04:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137118; x=1707741918; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G5ZHz3RUkQzpbVKYtYrrDh0U5BmbIjj4KbeJaOU/Fns=; b=iEuiwoyWk+YAklUbWor2h0CinSwKGwHHdcGOXxuZ4rqLmMKMjQv6TjLC9NHK8O3mhU RhnPpuSr8yxxeZaP9SUCLTcCJ6US2QRDMQirMq5rJDGT3XVB3y/IVw1FlrxGAnc3hFi3 aDIuhZcIzutIoS0f4vjoXbX49LQELa98woZVmRxfCElImUX6xNStbguuctkWvYJgHw5n pbXdWqoH0xvfjHcxnGlTgT+aJpjJRIzm/ZnD1lOpAZRi+rLZwK14a4GXR25UJ9MeX+iZ le2JFBjiG+fy7FOlcNXTDLSX7gj2IaMiCsELtgdh7HPOCkGLO5puVZmVsu0df1MPUQft Idig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137118; x=1707741918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G5ZHz3RUkQzpbVKYtYrrDh0U5BmbIjj4KbeJaOU/Fns=; b=HKdv0WcqTd2lYN6tOkPvY5la8XP+G56G0SdrElm2OEynueqqPfFcdICNm9oIRFcGuK hAyxfflmfvekLFzHcrs3pJlkSitiEPGsC5iUvKvg4d0vKXMc9RM7Fq9AFfrkTyK0jtMJ exlKxfaBzEbMAzgXrnlDpAGV6aE2CAmoPNt2L+YVnPXAWiqs2gbifOm+Z8nsS8yHp1r8 2GP6H43V3Sf53pHFItlWfqM84Mm18+DPDYmGoKh3QlZE3Hlm9um5ij5x9F1G79ZB5bQG 8nmkJptfLgbe9nS4V2GMIG1IaOLZ7U/NkDlsN2iSZoqzfqt0IL7rIy2cK/IsjZZ2kevz hahw== X-Gm-Message-State: AOJu0YzkmbvEJnHGOxYNtSknmTx8budS+qRhtSHnp1iEGSFo9zTHjfx9 8eZBI/opsMJG4zalfOaBVFSCrg1SPQYcBVYfinbKCJiQkEyWYrH7XqBBTIbfdoU= X-Google-Smtp-Source: AGHT+IH2g+aR/d3Fae3kdapdUimxpiado+1l+RHT/8yqZSKFvLAV9z7ZolUfNyqRIwCk2qjcXVUgDw== X-Received: by 2002:adf:e5cf:0:b0:33b:271c:7816 with SMTP id a15-20020adfe5cf000000b0033b271c7816mr5677447wrn.34.1707137117995; Mon, 05 Feb 2024 04:45:17 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXtbBtwOp4puWrLL5c/VhRl/CPpo7l2wIBvMapxm89/G7uxlduwkxRUThQZ0QEbczFrOy48ou7ofI5BCEX40lsslzCFFjvWAjmuzT8DjVAW+riZ9tU5nE//rSfXikq78EmH1ppYoo96wXmU/vYmhOfuAEGjukCYaq+1IxulzaxLMtMl4koGrrABfSCPx1y73OJTy4thv/5CfAlkB6PpHktM7bLpjIcgTC+ms0jQsrpjKsj9eQwKOVq0sm7DJdOMsZb5s0mrIEMDqkFSI4+F7+Q6ZfhXh5Lrvc2+bBv2CzNSlKm8k8btEv14J1iv2H7Vq1pmzW9ipVGP8BFDGuKP8S0GQwg2uVB9LpURT2M7q9iuqF4qkZPx4OlNFnn9kqqrpwFtWe2qqbPhI5ju/hL9LSwSgZFo2z8/D82IwbTrrmKlgcSY9fveajc8V715ICpC2OfquSxvtrDUPp3Tj9qMg4DRZf1JBbDbcYaDoqzWM4SOw2SUaiu5kmkqiu5i1Q== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:17 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 01/16] spi: s3c64xx: explicitly include Date: Mon, 5 Feb 2024 12:44:58 +0000 Message-ID: <20240205124513.447875-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044519_936320_E3A5848C X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses readl() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") Signed-off-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7f7eb8f742e4..c1cbc4780a3b 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include From patchwork Mon Feb 5 12:44:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25017C4828D for ; Mon, 5 Feb 2024 12:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+SGi1jnkImE6IE+nu5fxhEDrTUwhB59Xch9BK86Lp/A=; b=BCi3TRw74G4l2M eTo7W3lmGz9UiGOHFdod+ai3W3T1N4mJjthotd43jZgdtFTkKe7XuH9rrOcXYfWOv2TcFHv00Dpmu aPBMIueoJcPQqeOnye7J001+w2YmV7YtYRl141LtYF2La/94AcaMf7esrrp7H4Xm2k854octqaM6f ZI5jSV8ZWA+NL2IsXXe5j3WZOI21b51a8TxRMLh56skIqftsQz1CZCzNi7fZBz2yC3u80w1EHDqYA 2p45nSi+/6ieZx2bUFEbLboejr/Zwqe0Cra/Pba+9UxPw7tK3CQBavDUlrIdxZp35QsB1p9QptKZR H8WHKPg2v9bUfXvOIEhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLl-00000003G0E-2hxm; Mon, 05 Feb 2024 12:45:25 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLg-00000003Fwo-1U7j for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:22 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40fdd65a9cfso4459835e9.3 for ; Mon, 05 Feb 2024 04:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137118; x=1707741918; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IzNCPI2uV4bVb56xzb5sANMJH8iS3z8IvBbUnLuAoXM=; b=l2uMZxFjJuWGW7qT13P1eqEGwsXvORhrsHi+NCDJyITpmCHmch4T/m+PFxsMBRkrvf TrIBvTeUUD7OLKj6tsHISYTlRH6r0SIUKQ9L0cvg/Ct3B6WZ5KW2hUaBietrdIH5z0V/ xhRwI37f8spZwJpI3qSC2a5M8cFBmjkzX0+cTMe+A41QKDTQmga3+/UIF0nAWAtYi/L6 LTgdY3jUh6miUPUqeg/ClznMkP3qfd9sUNvMxIspTJ/4nmWRzt2qtXEGhnEnirKQuIfl yvHnAizsEUOWYI4BAgZBtPk8ecJG8q0e0FuROajNshnr+/wB7higuj+HvLqXtrM+2Md8 RNkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137118; x=1707741918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IzNCPI2uV4bVb56xzb5sANMJH8iS3z8IvBbUnLuAoXM=; b=eY/9K0XVC67XmM/LnQjgG0JNVINmgL4TsvEL6MHvJviJHlcdSsNxfrH0lbjhIazTE+ j7kzSyB05QvPzegVTfKgtyOjtcyppb47wEXsN5UpSxdfHI8PTYdYRcib0R+xwqEre1Id iAPG1/bJYjvk5acoVjEf8I3vc9NIv71Q8YSOC0gAwUpR7NuJtRTd+TayYLxsWMSboEA9 FGjB6VuJKcgaLGxkgzYzpMYfebVT08ir1QRjy1Z+K/scUlJcbXgY6JggLzzbmFVg9ihU Q1cTTN1kLEoJrOr9MgGTW0h/LwDqoFMMMVN35DcQgMCG2mmrb4+9+xipv2ZhYqJmpSnc du7g== X-Gm-Message-State: AOJu0Yy2TMdfJNsMNRBbsboTZkQUMzmOifMMU3IUcIXLfh4NE3WSagXW +mj+kVwm1oxg+YcLMCg5UbSTg/PKz8agH1yhZsry2pRz4WnAgx+QSLDF5WG0PN8= X-Google-Smtp-Source: AGHT+IFm8XMhSyOEj6JXeYBZfyH+577pYvFMCZlW+Kw7nOs1uHReXIMhb9GkUoJmry5cYkJROtgeKA== X-Received: by 2002:a5d:6481:0:b0:33b:1b0b:9354 with SMTP id o1-20020a5d6481000000b0033b1b0b9354mr8296412wri.51.1707137118681; Mon, 05 Feb 2024 04:45:18 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWMNK1VDiEGqIAVNlJNMn+ZqV2UzxR+ZQy6PWi6/43efDeJOBNTObVEo1aWIqyi9Q2D3zrFK2uBuiC+kjoOMlWV8H6hFlFvBP6dnJmmkdiaojv1Ms9KR4sIp9xVR1Jg3+EpVR5ZulJUzrHeGoPBoPJQzlc7APQSdiPTy+WS1EkrHwkhLHmvUcasJMnakugFnt5ecVtBolqGBLuzMBIrmNxK91bzMWhX6CHRFyendF7RIEtH12rlYrgowJnLxYD955Pe2G6tzj2wH9FPT/BmD9dBD67Liy4u9JwFRfL/nDdHA7rxOgDtNzg0T7FS+/JTv6LoxCmYqSZm3BkxEapuwlE+CA+5tB87be+Av+GYBR+jWVinHLYtyL2NqyAZ0BvfCVa4FiihxgeVdQpPS3UZjjevD3B9mrOqL6t/A3nzgl0NjJwozlkShAjyHyLyZtc0qwrObZTSJ7LEUsejK5PVghUWfP3q6+6IuJfkCHfl7XUZAzypgZKwbUQ/zKuaUw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:18 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 02/16] spi: s3c64xx: explicitly include Date: Mon, 5 Feb 2024 12:44:59 +0000 Message-ID: <20240205124513.447875-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044520_411089_C7BC3728 X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses GENMASK() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA") Signed-off-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index c1cbc4780a3b..2b5bb7604526 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -3,6 +3,7 @@ // Copyright (c) 2009 Samsung Electronics Co., Ltd. // Jaswinder Singh +#include #include #include #include From patchwork Mon Feb 5 12:45:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F04AAC48295 for ; Mon, 5 Feb 2024 12:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1/KReMzwsYa8oCMyAtWBUVKfG+le/AUmLZIIgUQDeg=; b=3rUB4NNDtT/jKZ k7ae5dVp1/AmjiVFrpeEC5KoBcgObQEHl29BXL6vTFTPaJ9CGE6DLJm/tXX5dsnxqLQrPVsas6iTJ 7S0lCZX3jrv4i6rijhZ2bPvKFX16d9FxluCiF8Kyoq6O9zAiKByWij0xUtrJc/fuE/1VMop5G9VFY y2bnjDEAlifyLFLwq24Cav/2r05QNyVPddvqCrq4+JtbmWysd0WgJm/+9Jx/jhsskffpZtcEvha5v ExDXr36HSwTiSmjxxgoecSjySpxw7l6LJdML12dDywoQMAg5pBLbwxx485Dp1Ag6Rwzlml13aIt7k s/g3I8PFJ9kI93FgS3mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLm-00000003G0w-1q2l; Mon, 05 Feb 2024 12:45:26 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLh-00000003FxO-0pTP for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:22 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-33adec41b55so2777666f8f.0 for ; Mon, 05 Feb 2024 04:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137119; x=1707741919; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W0iJZWpnXVMwkvXpPgSJew7EEo1nTNBnfpPHvIQNpUQ=; b=yfluJ2YnwZhxU6wvr9UwZOC8NlrSSjUpSU1iWGtsTf5XdwP56FqY+KeyWBPi3ESl9i MkG8pS4tpsv5+FaXDci8/C8QOOcf2bL3Lb0JcBJm1bXIZ4IjDgqGorl0EIFT3MSOe+Sv u2CG4Ksrra4zd36u+gYlK/I0NIXBbx+y9Xmq8aGMNZzda61o5Ksq/i8WG9HiaZAsHFBm gkl0GQn8N7WDxp7uoBXcYHNnLiPCH+0vESXOkfOToTSJq6p9FIvGXg5rr6n3EsH951zH LNmRZyFrV/uOwPMMPxmFXB5/sDfjmk0nc+N+KJXfqssjRRg0rW7utADznTOBxxEh7Y73 C/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137119; x=1707741919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W0iJZWpnXVMwkvXpPgSJew7EEo1nTNBnfpPHvIQNpUQ=; b=qzy6ahGOcCMs1TK6Xw7Dq5p0LBOsN67q2bofU1Su4CBXR9T6zlFK8tJrdBGSp2FdTq SDje7P2ViEUfOd/shjXlns5ybgOB1v0G+c6c/Zn05NSbn7ObMJG7oJHA2T7xvd08KLU9 aA3AE+KN9qvI857eX9lhib0XjWcD5aZfDuo2+68yXWBB7WZRnxvJjswQUheDjfVoZkrA Wuy74iK9rtdvX2RgQ1eUJ3VpuNjogtUv9irHovdg66fwHH8Kz8j2zMvUfpYKsMlkn3Ob N0gYAVF27UZhkvHwyME0GYnS/tsG6OPfcEv8lSg7OGvox5CMQgsC4VV9Po7qOUfrTi37 Pf2g== X-Gm-Message-State: AOJu0YzixsvSzgN0T6VL7V2ulizeP1xbzeJCC93tmxCcZXrukllbVsk4 7xAgw+tAWywWbBUnhx77+7NAH3n3HXm9OsGXBQPgPY9zlumtxVAavL5KeuE6ei0= X-Google-Smtp-Source: AGHT+IEUTeDGMe9y9Io7d7vPFXq0/9oe6SH6ovhiw0963u3mRGK3Ub0ZC51fMHi6OyYN0hVu+gFbCg== X-Received: by 2002:a5d:5889:0:b0:33b:421d:bc01 with SMTP id n9-20020a5d5889000000b0033b421dbc01mr937267wrf.69.1707137119533; Mon, 05 Feb 2024 04:45:19 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUahAXSvTsGA1585DKwqXFbQPhNA509hGouEFV78sopzS6Q+jluFeON2uLS/6ymTrU4IdZf56owEpKf/7Xq5dTT2fQTav0F9l/XLuL2m55hmDV1Bo/H4owLu/xUAiXgKIHz3Sy+4cAr4wAKB4ie1RWdUAQC+Y6eTIluyUepqtaPTR5Ip6RuWjdCy5jzQSzEfHOIPPAOOal1XQzCPXaJbtH9N5geE7MB3mjL0MtAL8bNebGI6+HzhEFrAR9+IxbPlAGf78worWYfixaftWPQ+YUogMJy92aAqgos1bmCRmWeyCLrlcsoqr+J9zD62Z1fhET61waZ4kgPlJxq5c8Bl/6PlfsLSDSFnE85zeKOqCrlSbcUN+ztFYZOfid4qeWX9oW6jHVdO0AXMpEFlm/jmiU92IhIw/cwRAB5UXAa/SHFVGDfusu2ZEDM6/75bBZDG0js0t5focKja7CPw+6gyZP5TCdxUf0xszz7mnWypT5jC6PosY5XchFNLKmlUg== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:18 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 03/16] spi: s3c64xx: avoid possible negative array index Date: Mon, 5 Feb 2024 12:45:00 +0000 Message-ID: <20240205124513.447875-4-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044521_258174_80B15C97 X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The platform id is used as an index into the fifo_lvl_mask array. Platforms can come with a negative device ID, PLATFORM_DEVID_NONE (-1), thus we risked a negative array index. Catch such cases and fail to probe. Fixes: 2b90807549e5 ("spi: s3c64xx: add device tree support") Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/spi/spi-s3c64xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 2b5bb7604526..c3176a510643 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1189,6 +1189,9 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) "Failed to get alias id\n"); sdd->port_id = ret; } else { + if (pdev->id < 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Negative platform ID is not allowed\n"); sdd->port_id = pdev->id; } From patchwork Mon Feb 5 12:45:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5F13C48295 for ; Mon, 5 Feb 2024 12:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VJuommArxbFIRw7Yq6Biu5YWsWPz3WedrO8AJTckmOw=; b=KEqQgAetM14nRI OW/KGg9+oJbCzBT4eqTvjOqU9pkCcn9gwiQMNejXFAj6Qpi+KLRb6Q1rezRoxEpB9kr5h+t1DMwP/ iQuE7//pOL/Cov6nVtSK62AFfLZO6uyoABhHoAKkobp3H0st+2Qhgt8g0abNpLIRaARWekr9V8OXS 4JE6/KB+wlDG0lmyOB9aZe5SvSjOCgiR/MPRoKZzYfmrlwTaj2GfwjQI2GbfsodSTEnKnYGWKAxOZ CLxznPETyN/19Y1u9+Pz0FEq4/7RA/vIp7Q4N9PeF1onugaR1aNdBunw/M7KFtYIg48C02vNN5/W+ PsOC8GBnE6qjdOcgbglA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLn-00000003G1c-0yyL; Mon, 05 Feb 2024 12:45:27 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLi-00000003Fxs-0MOm for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:23 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-33b2fba3176so1095323f8f.0 for ; Mon, 05 Feb 2024 04:45:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137120; x=1707741920; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eOBjoaorUabw6V0kVhecCBVM+DqJR5V0WfMbUMGzKiM=; b=VsHaH6BU1H+AEW+qByu1JCP4a3F5QBKrZgRw8BdOgGvYTbzCbpKgOCqrdChFERF9RK yyYH6RiJgebZptN+S0wVGjXsnvYehuGlfVTYl1nSxWJ8hiOH0MXHHjwGKFyP/6HpUc2p M2csfMziwq+p9Qh94UXgrT0uTl2/qAC76QTBORUklAoekrfRw4de+RPicW2BJR+ZSjri Aw6ZKMtNax782HetMUQjAUNH6NF+DKcoPnC7OWmmXi7AmVzbpBac7LNtBIo3LYN9RtXj n1P0OIB/qA/CPIOy2HxGYXUYRXj9SDAeyk4MhHflgrL6fOt/Tm3Eq18CYKEc3G55IWl3 5alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137120; x=1707741920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eOBjoaorUabw6V0kVhecCBVM+DqJR5V0WfMbUMGzKiM=; b=IiARzBo+9joLwhc24UUKx7n6UbkOk3/YTWUnZgNOuSvXu5ibt9z670sVBx2ZlzXKm5 cpHsMAbzi3xbVqWW8Z55HrzwNas8JD4eZU60lYBdmczNfswOCxG7HPidRgeqiKlQEDdD XF6Oa2cfH8UzQMWChwhC8yKib+RuuAI3MvIW1NcCeUTGOnuKHGnoGigatT8FSLd25rkZ t9uBWqsqnAVP8cHP7hLDiVu910RNGTl3Pb+0fEEADp4B3ySEYvepAor8bNiALIUYkBtx ywTM/zOcijLnrQgzz6kf8a8n5Qths/bEXrPiHm2B6nR/JUQL6VnXhg9DqBWHlPvalXDx At6w== X-Gm-Message-State: AOJu0YwHw9sK6WZWjXHfKtLao/GDn9KFnNIXwRgqzpFXbPeqIS4QFMpx OV7kegIGmCiaMpLZ9ncIMwCKvyq9kZihWnm5VgNXOUaD4gkxF5+JABof3CiS8h0= X-Google-Smtp-Source: AGHT+IE/R//MpNPylh0UwnhF9YKZR3KGGY4fGA5i2/YHcwiL3Cuz8pM968aVwJ0sUeRb5fLUjg+zTw== X-Received: by 2002:a5d:64c8:0:b0:33b:3b96:87b4 with SMTP id f8-20020a5d64c8000000b0033b3b9687b4mr2800257wri.14.1707137120374; Mon, 05 Feb 2024 04:45:20 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVMfIKOUFnj98diFmwBJtthJx6XEcrlECRzI+G2PUYmp9a0qQk6FHpzoZ9Ia24ALKuUN657wE98H7tOGJZHXUA8msOETP4O6LwvEYPkhKFL0nxyBUrL5e2O8PpjE8+a4M9P11ukmFcNBgXZEa5aWKSANDzieilHAieWiKlkvLrl13nCFPWQDtoDpKen60XHXzT8GvyRKD0vD//k+Qg1LxdRN+OAWLXIj1JfNpuN7SLfryV6uFyeKnFgV3lAGAtE909omOuHJ5ZKKnCxJ33RwVeCOHVP1+ZoaQqjUzQ/CMVw80T4NvSdqgiC2OQow6M6qnGiei69Mp7y7alVSVZkJ1ldjTF35HcXRcoCWooaacUQTyzUzMuFslAV2REvXdO+IicsZi5ls10DblwKzyoM1PGP0iWzrmPzgE0Bol6vhVkkb80eWfLhYsJwxLAt+xlvddzVmWCt7BqPk4BIU9IpSbhTdg1EU/O/4BVSuH2MpZeYc7sOZdT093oW1fodyg== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:19 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 04/16] spi: s3c64xx: fix typo, s/configuartion/configuration Date: Mon, 5 Feb 2024 12:45:01 +0000 Message-ID: <20240205124513.447875-5-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044522_177035_36DB1705 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typo, s/configuartion/configuration. Fixes: 6b8d1e4739f4 ("spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'") Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index c3176a510643..3df4906bba34 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -180,7 +180,7 @@ struct s3c64xx_spi_port_config { * @cur_speed: Current clock speed * @rx_dma: Local receive DMA data (e.g. chan and direction) * @tx_dma: Local transmit DMA data (e.g. chan and direction) - * @port_conf: Local SPI port configuartion data + * @port_conf: Local SPI port configuration data * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { From patchwork Mon Feb 5 12:45:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 714B6C4828D for ; Mon, 5 Feb 2024 12:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3IEXjBJ3fyyqhEORaybHvSN9CQuBkBys2v+NNTJoTWo=; b=xoyxwkc8YTo5eq VSL4CVjAaRE69S8K6QllCL0Yx6tcMeN/vo/MbTw9JVPgiCSrBP52Wde5XCpbRAy3Wwr2fmqljufk/ eGuRrl09eldOHSLdDNuPw6DqsKqLJ0BiFuUdIpjulXqpspYXqfkLWiZ6eqrhiOKpFiWhYgGMsGUBm l/MDAHc5EHdpcsaGWcrzMRmpHdTv8CIRc60bliJwBqArTT/mYR6tRClAOlFCXQRZnFCd6RgwgL8nk hoe6DM0NkkRiUDTlSZsHB/B2pEkk+Lka/ueE6M+52hUY4VEf9Tu7HVUFQTLmhB1L1wqbI/S9HWTEW 7igF1trIsOaxDFqNwXEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLo-00000003G2C-11LE; Mon, 05 Feb 2024 12:45:28 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLi-00000003FyG-2hmc for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:23 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-33b0e5d1e89so3465657f8f.0 for ; Mon, 05 Feb 2024 04:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137121; x=1707741921; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K2PV+2xLiiEx0u7i0xiK8BO9Wv2wYApgzlDJ63/0dKw=; b=R6SlFo3LVK1zaAe6JIEwJQ+vlqhxArFvhqpYTl04ZT/oF18j5ABBNf2mUAe96JWRoe sCIN1f6vRWw/xk82tpDa2WitHveXx1BC25baA3XFHMh1DO8SIFtf7YyqJxVtCxHE2g15 CIswOq2YbNLs5y3J22Uykl4luGlth5ljeVXeE1eGP6viVAs2wBUbPqL9ZEaFDWXON2hW 11+Gl72clQgLSL0MZw3nco6Ze3rchhBUBrbHJwFAMXOCasfIeuioVYxpeG2cRrd1qjE4 ooAX0sAsHjXYMVFVoMeFYQreUrf272AOJp1wUnD3tFs2zH9H1wpLNTZX8vovKnAz+bia SzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137121; x=1707741921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K2PV+2xLiiEx0u7i0xiK8BO9Wv2wYApgzlDJ63/0dKw=; b=cRiseduwUuCrG+Q/WUoKaGOBYTN6lD46XHh39z1Fk5JdoweosBh2L2BzPpSRUF0IJW wIkqvdHinqC0NqMHBWiDCJ8boxe8Cwae5YKTCN/meNOUcK14oq46sm5PwPt0e6+qbJ79 GdjJnStAq70C8ygDRcgNHVyNCzkE8KNuevBlEmjwMQ7Ct1M6ZdggkXXeti72rvNm4Nm+ bYaHDsSPz4o5RjoI4IzgM1u5wauUeMMNLq4B9lG74tUwRH8/S17SBis2uDlGYawUim3+ sp8v1/Lc35VNR1Vo2n1VKOVJSRAKXAzkqB9MKgyvfJvlgOwybiO7MeMXeQaDrY5n21GM EDNg== X-Gm-Message-State: AOJu0YzZ2OL5KlAOoM/zlFaAlCnQaODgmCDb4bDOLACBzkGA/uzWNO4i zeNTwbsrC6U85nr6KR+YkKtG8QP7c7Wem+8Xd23UmCLcuALZhWNC31zsaLN9Cfo= X-Google-Smtp-Source: AGHT+IEuMR0ZRLWGw37NoH1Zqp3+O7Jprt6LM3gpDZR40q6RTfgnXr50yLqhP6tQPXGpkUFkUupYSg== X-Received: by 2002:a05:6000:118e:b0:33a:df1f:c18d with SMTP id g14-20020a056000118e00b0033adf1fc18dmr8072680wrx.50.1707137121436; Mon, 05 Feb 2024 04:45:21 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVGMfma0EN1z5FoQBginlFOPQ514vwJSuFrlUAxZpiJfgYEsovYbba6ktClwtxo6O8Ti9yHyvJrVMfsJzaqzlZ493BEMH8JCmzu96BVZAAEDexcHp4v3CTlBAQiz4HAPhrwfH8TNmt2RQRAIv+Mg4dmtZr6oDHNmrA79YVU/as54moz0bxiwlwaZ/zhga53Q/IcWvZkeSfsMsvcVhKBkrvJNNSzASvTE5rWWbjI4nEUpbKS5ySwnc8l+NGYSG5f5FHWMs+6/rt+sPPfP73Yuieaiv2z06VfdogYi33P1Y5AGos7EE7/CmZ1T+xkkXA2K1AzGCXXLG1IFH1qfN79h8eMs672K55Pcb5i6+JmJ6aR/Ww+JRIcnSgrRWVVwGua4NUxpUUpvo0Z4nAwEqR1gVkvTjTSqLqI8ZxzOskDbc0pVEXDlY8TCJMPmJfmTCyE8S7FJ3WzPg7uMO5HjZ3okLEpjvxuK76r7aQCMCatSIJCkzuYVH8eHtUZltL66g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:20 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 05/16] spi: s3c64xx: sort headers alphabetically Date: Mon, 5 Feb 2024 12:45:02 +0000 Message-ID: <20240205124513.447875-6-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044522_765261_7F093D34 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Reviewed-by: Andi Shyti Signed-off-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/spi/spi-s3c64xx.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 3df4906bba34..ccb700312d64 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -4,20 +4,19 @@ // Jaswinder Singh #include -#include -#include -#include -#include #include +#include #include #include +#include +#include #include +#include +#include +#include #include #include #include -#include - -#include #define MAX_SPI_PORTS 12 #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) From patchwork Mon Feb 5 12:45:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A483C48295 for ; Mon, 5 Feb 2024 12:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CTxj0wZeneOi7Gm9l7eeac3yuTtmbQ+nX6GLUeseQKY=; b=ioX/ACNquNSy3T b2R4Jv8RRdDMJawVnt5cAwdMW6IyqzbjpObIupqFpfEvkj9ZI26pus+HqXoe8uRGRP7JJU8iztcSt dEuwV/G1Vr9TqukDe7klbNDVMjhNFZAV0+wLNAfPw48VXZvd6+KcaFXUB/PGmVFSgIEye786EH14V 3SXQegbdS8Omt10Os4A/yBjv7UX61qTEVmEjo9vst2PxhjiEmslNHP3vIWr459d0w2HD0mMxQTQJr EDC0lx0j1cp/knoLc5WV07Rk47UblXxr4Z/vKukOQidP//WuXJWJjdEfvqp6mgIGMMonIMPHc9S5+ UR2Bh8UxFiQvCIDIfJoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G5H-2iMG; Mon, 05 Feb 2024 12:45:33 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLk-00000003Fz8-0k1F for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:25 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3394bec856fso3282614f8f.0 for ; Mon, 05 Feb 2024 04:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137122; x=1707741922; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dR8F8TtLujJzML+VHbYFd966gNYU8tLxVBTCD/Qpmho=; b=p7/JU8ywvc0xaQnkaRos1ST9I0uokNnOzWg8AV/3s4rjv5NEPXWDw4z5kHAGVw0oMB yPgErmG1KMG7rTbui430JUV8YWay2Tf9FggDV2/LVjHZHlh5YCnu+jRrefu4qZ/Jkf/+ gWBR/FqLfstuxyV5dlrX6QC+UbHPkKRv//obro2IVkpQFNxWFqzGLkfwwTdCc9EaQVNA 0M2erp/l/KACwyVqZV2FwXMyMNgCc0qqii8WorH6KHNXepOmpLeTUnj0fpQmbLE9RGs/ sWARV/LiZvO65bd/HwEp6B4A5B4s3RdAs+EYfQ7DN3XThf2LwvBVoz6/SoUr9cPRlJ7+ 4/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137122; x=1707741922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dR8F8TtLujJzML+VHbYFd966gNYU8tLxVBTCD/Qpmho=; b=drSArG0a9WewKVP4FYSTGw48T+7GRaM98PCYpW9RRURt0YhiNSd4iilWcGaSSqmG+4 iApFwkSp95xXrK2Jux9muYZaBf00oR6U4wUlt3ScjR+2T1+ogZkRiwFmuXLGsJksSqt0 XZipf0Kk97OmFSxhyOVNXKl/F1PB2eS3VtXfmcXdhXLLdTeGQjotLdrsOdekh1EF6NI1 bVQyv6SOhFhejKnV56aInFfwCfT6wAwgZZm/IV/oHrkf/wXoNhmYmK/LjOmLk9KmNpab eB0zL5erxVWOmQ7cqOGeuHz8v01KbBYQVo6R/ilS4/DdnF4lISzlec7dQpy3mYUoI7B4 jp+Q== X-Gm-Message-State: AOJu0YzcnTjEZNP+dB6ilYw0ZjDDeqFAduedArR+28zT8panKuFqNFgM yvDzyV1+4gIU5LHGlaIRloB2JcrDW2Zu3I9atsO6bioqIrSfr939TvbPefee7NU= X-Google-Smtp-Source: AGHT+IHCuUmi+aZgBfk65jmiz0AIwSuZ9vOXcT90pjJQzz+4Bn7QZ2XAsQmQC/0j7e9WxwoFjwSkYg== X-Received: by 2002:a5d:400c:0:b0:33a:ebf1:2bf9 with SMTP id n12-20020a5d400c000000b0033aebf12bf9mr3498784wrp.21.1707137122511; Mon, 05 Feb 2024 04:45:22 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXl4yO1d8qcT/Zxvb0lobqGRNH7mNE0zJaKCteLlrfEU+JyL5wm+nZfgc3HDif717jZhnK8AwmpbghCtGct+2Q4SODKEIqEnCEHt/sPiym8+bPgxcAfnqA02Ugtre04fhpiMpg0MNX1JE1IVOgtRrWroBjq7Qj5MjMpKpu5CcWwA592/JgYX3AAxwL9HXrQ/3vuohqfTyORMqCNSlS0EaxsQ0ciJKjXwAhR/1GhvyYKmmlVixm8B+MAFM43NEvIKPIHWZmO41pvSnas7pfGoocPlN2I1qUWwExsUfHAvRR3ae9tSP2+VDIAMWLD8UycDNRRe+qlsnzfMctaHdmcWLQzk+hkQuyveQHQiTQyRRNIXNFSquM7JhAeKRy5pezKZ5tuTkkvn8PAUinD4LHmMOmyuqwkknpYtNubu5rdUBAV7N3zU8BHQ6rn9wvXbctFHxNjvS3V2tmvud97IGGFNigC4qmZmRx+bda4Rdt3ZZrAKj0K3XNHhA3/liOBog== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:21 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 06/16] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Date: Mon, 5 Feb 2024 12:45:03 +0000 Message-ID: <20240205124513.447875-7-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044524_242097_7D8140B7 X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_device_id::data is an opaque pointer. No explicit cast is needed. Remove unneeded (void *) casts in of_match_table. Reviewed-by: Andi Shyti Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/spi/spi-s3c64xx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ccb700312d64..807270ec3c8a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1512,31 +1512,31 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = { static const struct of_device_id s3c64xx_spi_dt_match[] = { { .compatible = "samsung,s3c2443-spi", - .data = (void *)&s3c2443_spi_port_config, + .data = &s3c2443_spi_port_config, }, { .compatible = "samsung,s3c6410-spi", - .data = (void *)&s3c6410_spi_port_config, + .data = &s3c6410_spi_port_config, }, { .compatible = "samsung,s5pv210-spi", - .data = (void *)&s5pv210_spi_port_config, + .data = &s5pv210_spi_port_config, }, { .compatible = "samsung,exynos4210-spi", - .data = (void *)&exynos4_spi_port_config, + .data = &exynos4_spi_port_config, }, { .compatible = "samsung,exynos7-spi", - .data = (void *)&exynos7_spi_port_config, + .data = &exynos7_spi_port_config, }, { .compatible = "samsung,exynos5433-spi", - .data = (void *)&exynos5433_spi_port_config, + .data = &exynos5433_spi_port_config, }, { .compatible = "samsung,exynos850-spi", - .data = (void *)&exynos850_spi_port_config, + .data = &exynos850_spi_port_config, }, { .compatible = "samsung,exynosautov9-spi", - .data = (void *)&exynosautov9_spi_port_config, + .data = &exynosautov9_spi_port_config, }, { .compatible = "tesla,fsd-spi", - .data = (void *)&fsd_spi_port_config, + .data = &fsd_spi_port_config, }, { }, }; From patchwork Mon Feb 5 12:45:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545499 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 996B8C48295 for ; Mon, 5 Feb 2024 12:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZPUsUxOUCQWS0XXRElhINoh5jKn67rNhLfWgppB2hug=; b=J2K521mMnYrWW0 hUG0kEPVPTwF4mFq/brrOjIjxCk07zKPZbbTi+E0KFQ23vz2ETNT3OC/JL4I/1rCjo+H620NbHML0 70gokRb9TIfh9cvjtF8diEXj1OLY1CT4QyCK5LAfL2t9OgDAomO5kWaZSEVodsXAKpq41IMNDp/zn Y7oRmoc3z7m7tyZCpF9WQGI+P36+2hbQym5PCS1uj/QsBod5YJaPwHHfbXFAntw3tFFqXseBFVgfg MVNLq3i1x3/Z4hyPZaumeBGyBUmaRAftUtV16Sf84yV13kPj/lFtE2YCF9hUnLwLaLL3FX5uR3rii CkIikwfXKyv4B50RxvVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLw-00000003G8l-3zzn; Mon, 05 Feb 2024 12:45:36 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLl-00000003Fzb-26Yl for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:27 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40fd446d520so13883565e9.3 for ; Mon, 05 Feb 2024 04:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137123; x=1707741923; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6qx5Z9yzI7/GsBIXv5d4Hndyborn/ItKWNP+WpKBQHQ=; b=kAY10AJq3u9+Tcluj3yMz+Jk2DkHAI1R78VSuQIBmITOVtNxCg7SUOCrn0z1XFSinh BrVhA6760D5WFDJstT3H6XeMVaf32gJxfY5bpAMDhXlBTrMW0/Z8vYLK+hZpFivh4aiu DRjo+/E2+2OMX5ECh6z23G/a2Ljis5/ZNBpQXSVWZ4IZ0VxrJza93BAY9rqQCGnbM7YC DliV3ds9IG6jX+mesdhQvS04cxqrUIB9LRuJRuLTykUpQAShcHJ80o06BI7QIJQDwRW+ Vv+/qDXfzofxhiaJXRSvQOnqiGay3jCTS9xjmW4mVPL6cjS+DwYnijyX+StKi7D+VQYG D/RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137123; x=1707741923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qx5Z9yzI7/GsBIXv5d4Hndyborn/ItKWNP+WpKBQHQ=; b=SZU3SbxP9NpGJbGs40geV+iQaRMhrJsvZpHgYBxYClLn9aXiY5qhNGXf8ktIcXJrJV 4/BfNNX4ZEk0Kb23FhTQodGGaZpk+8TPDJz4MzNvWoibV6hEt0Ecu21Ttgqc+eBLixcD JZmick2q/9AZBESBv+1w/4KAoi4kYdg2bW+A0XT+CoqcSMZ5ttFdHjDsuCM9QPkyIMLI qc+0ZPVmqYQgs0QBfjA6wUx22xyypTqhI7uX+GxI3OBdbgFcfdEBKQ+HXyKUkdh9UcxL dnvlkrTh1UAhD0IzMUpHl0hX9O6G06xsSl93u1ZaoXzskagjN35KUi56TyvU05Sliexd dvqg== X-Gm-Message-State: AOJu0YywqpRLBxhZ3ExN8kRDl772FMU7UG23Y8MkLvOg1nNKhJ2bP11l Sso1Gc4mJs3DoMN1cRLnOO6Q6bS8tLNc3XB/apx+vsiEc2/8nI1wS1DHkIJWvPU= X-Google-Smtp-Source: AGHT+IENb5/+ooWzL3wKqSyw6CoPegzi2HvBdBv0v42N94vmcjqi0ERz9OUD0oC6LoHzUuwF08Ctew== X-Received: by 2002:adf:eb87:0:b0:33a:e76e:8b5c with SMTP id t7-20020adfeb87000000b0033ae76e8b5cmr8704510wrn.33.1707137123500; Mon, 05 Feb 2024 04:45:23 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXNyTz4l/uM3TNton705PQDnlbNrHzvQdIFoejDWZAaXz/PhUGIrVzx3X3u8Z6k7b5yAy2ikEcTLKhvJ2bwsyKAb+V6tWslcNkzaah0b0f4QIBD8FuFWARi8zqXG4RjvAltC+1j8ps0uo4Y3rDq0U4Bx9vKyPAcQolk9o4EmqMQgcyNBFBu8ThEi2IMmvcoc0oXr2zdvuezf9naLI2GxY1uH0GI44nB4TTtATOB1yKx0kLN3bcg5FTgG1nXHc+OgzVpVcgm/jLpsiE4oM1SkYfN2CRLpC+NoBUWFGi/bGYnQhiZ3BpIWrlj5QHb1LTZnomSGYmBoUaxklUvjmCPC/dEXbzUwFbLiYExkOHKyR2MtnHxHC2RQuToh1glcAKITUvDwzY0zO6NZn80VxOIDoj9pljSJ0VYjmuPUI3Eb+Tbu487QVGZDBOg4jzk5GQgFeycEXIpzsWBaSrt9kFGzfhR06VFEqPItaiR5iLwQLUAk2+9kqOmaTcto1lqiA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:22 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 07/16] spi: s3c64xx: remove else after return Date: Mon, 5 Feb 2024 12:45:04 +0000 Message-ID: <20240205124513.447875-8-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044525_576334_D5B454F1 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Else case is not needed after a return, remove it. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 807270ec3c8a..3139a703f942 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -407,12 +407,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host, { struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); - if (sdd->rx_dma.ch && sdd->tx_dma.ch) { + if (sdd->rx_dma.ch && sdd->tx_dma.ch) return xfer->len > FIFO_DEPTH(sdd); - } else { - return false; - } + return false; } static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd, From patchwork Mon Feb 5 12:45:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545500 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E8D2C48295 for ; Mon, 5 Feb 2024 12:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CHGFJejC7edArKhMy+WBiAOPr7CBu39XrnDYKsSGcbE=; b=3cShMBXBcT7Qcb BYgtZY9AJFLpKgG6CzLvaPXqyuoDxbw1g+QRsr2V8Yp/zz+wxlqD67IG7O5ni41jyGSrN5XDU9N1x MXu7/vwyjPHG/R3Que89+zVLNIrNoA78rl1W9Zl9bUvKSxdmIGiPwd7CsOyIrHfDEMt3O6e1otojN ugKViq/AJVmEbgORUU54KMPfjPPiOr90tUB6M22PHoH8Fuz0PTUU9fm0+u+SBShqhPC2Q2SZQ8Igg FmZV9ZoZF+qM34MFpImprYs9HbIk1oqc1fLdvYAdGcwkcgcSWM50qiuZ0lNFt/x6gwvzlV/WM/sx5 KuZpTCQ7EdDEZPkwGPEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyM0-00000003GBx-1Sw1; Mon, 05 Feb 2024 12:45:40 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLm-00000003G08-0nLS for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:27 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40fccd09082so19984985e9.2 for ; Mon, 05 Feb 2024 04:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137125; x=1707741925; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hl6pdkbEEgoE8D882wXKu1rMaFEwskiVorsz3uU2gaI=; b=hmrNyaKGsu3sAZXBvF/3gmu6ip+v4SPX1xdPqqrdt2zMaRAlI1jc9QkhrNjMPf5/rP ReNDqk0pXXKgYBCf5zn9sN65orQ13XwuOUE9jGBBtmITgkOrAHiDcWfzWTWlceLmLyYO 8S6fmvdwcRGeFq7wcFTL6dWDiHDf5ykFoGdP75GdzjLtUZhHFfUk8X2q+r7TgxfI6X8q ZPefhusXQ+BM6+Q18/cA0EKcDIcyjDEuypL/0lQ/hgpbeQIumNzsrJzb2d3qGvDpRX1k d6BjFn8+vDwWG2tlbtQMLxlxeZ+iM3CC7bxv255AHtj8L4SRwD6QTZGnBCcd7zh897Yb +mkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137125; x=1707741925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hl6pdkbEEgoE8D882wXKu1rMaFEwskiVorsz3uU2gaI=; b=d4kHu3z9oFX5eaLCmUHkUqirm5BT6UhxSXxcFZ3TfoTT94PQ66qTrrrIGzrEuJtSqm hjH18zFrJh0TP1ye3MuNkylMLrvyp+B5PG25GuGGNnBms6MzV/h4qxhCeZ2SDYfFqUJN 2dqFkXSJ03QEwJDYVrSag4ifN6gEkbUGU51ioH2Skn1ACcOaYqhLR0y6oyjIxz2vHHDB HBXUw9QbIEf9p5iNfvy6qfjeLdXTxmHL2Gh4F9XJdRpWKFW5oS+WhMfbAjF7FQS4BMrz fTT8PgbFScg7c8SAn35+RhjiPj1M02FTnB4qJu2J2lwolO0rum0pUH6i62UhQpjkgDZb dPAg== X-Gm-Message-State: AOJu0Yyddij/SKKvL30u3FJ7TKOQlVIBK3in/QY+p820ZMMM+mk/SJ9o 06qGijwTP5k27eK1jzGKN+UFyGOW62MrrF0zgyjlXU3xUnebGroaaKVoFwh9weY= X-Google-Smtp-Source: AGHT+IEDe7EYwBHsgvEhHYw624nCPgXWvF+fc6geJZnawHKlv5pvLV7pnjnL7oVE2MzVyCIouzoc7A== X-Received: by 2002:adf:ee8c:0:b0:33b:376d:6263 with SMTP id b12-20020adfee8c000000b0033b376d6263mr2789597wro.60.1707137125019; Mon, 05 Feb 2024 04:45:25 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVw4l7u+dPerpX2iIeIYeJpmDSZSVp/7atJ5rF2+W2qzeYzQ5703ZVXHX6x29RJ1tujigETMOU2yc6xB9Ao+8shHtUAdq0s5rzjd/tzE30Yb9S+frHisBdUz6J4HALhnWuytIGcGMaBb67tahDz/PicKwT47gy77pRuZdTEiNuaaUh5KBKMkZg6XI6XPftRYGE+Dvq9NCuIe+EVqKDF67OqHcGj1u4R70DsCpl1BYgbGaztewDF/cS49zmboaojgEHV0ULVsNyH63Bqr0FuFKIm3pVNFx/zkoaXqPRzEhGIE5hr51KE5BPnMbiO/yl7I/8iQ0y8Fvq+z5gMree7F2h4DSk6ZzMwscytFapnDl/E7Q1tG+d/k8YjshGcKs8xVlQN2i6z8q9RsIfyLpNLqlUCgXKTk7KD+GmpqvLYS2Xn7ZUZqjs+BOfnbyR6ryCAE/FYwoEr9+bokYIz5jAsqbpz9nqhiL/n22QPd50RgSvdv+LbvnYht5g7n2vgIw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:23 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 08/16] spi: s3c64xx: move common code outside if else Date: Mon, 5 Feb 2024 12:45:05 +0000 Message-ID: <20240205124513.447875-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044526_269361_3565BA29 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move common code outside if else to avoid code duplication. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 3139a703f942..fcc1f16d3ad1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -291,20 +291,18 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, if (dma->direction == DMA_DEV_TO_MEM) { sdd = container_of((void *)dma, struct s3c64xx_spi_driver_data, rx_dma); - config.direction = dma->direction; config.src_addr = sdd->sfr_start + S3C64XX_SPI_RX_DATA; config.src_addr_width = sdd->cur_bpw / 8; config.src_maxburst = 1; - dmaengine_slave_config(dma->ch, &config); } else { sdd = container_of((void *)dma, struct s3c64xx_spi_driver_data, tx_dma); - config.direction = dma->direction; config.dst_addr = sdd->sfr_start + S3C64XX_SPI_TX_DATA; config.dst_addr_width = sdd->cur_bpw / 8; config.dst_maxburst = 1; - dmaengine_slave_config(dma->ch, &config); } + config.direction = dma->direction; + dmaengine_slave_config(dma->ch, &config); desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); From patchwork Mon Feb 5 12:45:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545503 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B30E7C48295 for ; Mon, 5 Feb 2024 12:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ziw1uAK1JRcpJG9Lco52d1mLjgJZLPQVDM1kMhk9/fk=; b=45Em5hBPIrFHGk HZst/lInwSMYHsKk+vNbEwbJDVCSUeW2rqQx73bdGrcbPSpGNO1X33fpFkAnhre7q0w9sbTQj3qmH FkUlYnjzr8SVRk4e31E920b7JQx4K85DeXx6VyRYy+m2Ffwv/xUNdETheAXXfJLcGfUSP0A7rIKVA Q9NQIMTAbZdjeNTMD8WRAhINyD/9TKHjisFgmbjb9LF1AP4z3Yb0XmOMfMs1F0lsVTrZJPCbvKwvV M96/ZQ8fQZbxEibjflvKZycJWz3rv3Wh9SmrP7OMSsZ4R+SlKFLDHoPdZoY92mtUOVuXsGWrQQwSi xR79FWHvhUONUeo4cm+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMC-00000003GNa-3MtE; Mon, 05 Feb 2024 12:45:52 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLr-00000003G0x-38Ac for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:33 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40efcb37373so39948585e9.2 for ; Mon, 05 Feb 2024 04:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137126; x=1707741926; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ndgta4k+G5qoRIAYZxQhEjhM69MpnMv+KGVE1CZejWY=; b=QJssLfIiXq8fEcZYIHi12O6taXtAhF+3kPoO2OGdFMOXtQfQGqESl5Z3V+xBK8I7hM wB8qcjesikIk+trs+1eglqG6++JYM+Qaf1XyckRVW92gupV0YFIspdd9cQNlkULC1Od9 KZBzcn8/SPqbxRBUi/oq5uN9DeQQQzM5M7jExyIOi3xejdI1VzKHRNEFpxIm461MgMdl w4eXD8mP2LCHgeIUC0sOZx6H8NmagBBTipJkHLw0PwobhxKbRJqXkmsHOcorCXNs/TrO P0z9Qvht8wUC5NQEhE7ypIiIlptyzbxqed/LUYqZDz8LeF7sBht41SYOauDN2sXs9MQk nQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137126; x=1707741926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ndgta4k+G5qoRIAYZxQhEjhM69MpnMv+KGVE1CZejWY=; b=J+mGk54YrGlNwuE1AVeHGTAybynBrFID7N0iESXHWd6bTxzYn6lpGMsLaFZH4G0nvN 4NASxnsOF21LLNwiGBN3mY6jd9O5hWVK10BGPMjt5ydryyUBOxpmQjk2XwDs2DUXqvdI jQ9j6ed2UNAwRJgcDK0BweVGMN0YhcUXxy19Qo62xdO2Ko0lWumYqrKysxhFuPqgp77q hOr3LvIQRE/2IX0WBwDmscy3SV8/L16lWEzX5jT1y2KKx2qgI6Lu9VL4KBikDqaC2yXq gOWpQKHOK0rwGmwIOUo77SNSs9iKrRD+QGqQZQQ7MAi0W4A3duvUcK5omEc8JJzEy+tZ 2GqQ== X-Gm-Message-State: AOJu0YxgkizMkSwdM2inMJth1+wNeENcbUyz1RXg6pYJYA+9xZB6tEYy US71qtWkiuZp26ov+pUxTota1oMwmJlUJJgyDedsaB1PywxJ3zxUMYgxUZC6s/Q= X-Google-Smtp-Source: AGHT+IFfo3cQQL9/HnpiLvwbqAwEr44KXp0C33JXwRj/iVJj6s2NcvsGUE72XOVRphi8QHeffBQCgg== X-Received: by 2002:a5d:42c5:0:b0:33b:2464:9d8f with SMTP id t5-20020a5d42c5000000b0033b24649d8fmr5556272wrr.58.1707137125934; Mon, 05 Feb 2024 04:45:25 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX4JJNaf1yBR7JlAEEqs/vM1bpQHP5WCL3yheh+1Kk+jWGt1qmnjBQBaHyqiZZQd+WQry3owsObYdswipM/LUbjc4iKp+vCyWMu0+PIKN4x5dzcFLRn9rPoqXXdHAOzymMl/Hw5G6vuBwa3A47LFDQ6m4ja1R8p0RkwUW8INsVUpTDkDR9RIGLQvZOabOu9aLo3xeCQnh0ueBq9FZeUpz0utDS2DCj35GvobxhpwJynTO61ixqSBBVNmXKMduQdzModeSLGlpXGmpoucJ/zNDcIhTSlcBBc1oDAI6Lts550pcPIy+IjfeYN3PFOGRxW/n5it04PIzIwudWyr731/vX4KUoqEw/fZgK9qBzj3VEQ0gMVBD3aMort8hvdp3lMHB4ZXnc/0Jf1vo2ZutfSR6EvcGdXWmdxKaIwnhNBRn+YQnkf1fqlbluaeFnPujHNe6aHc8CCeZAWOzmN7fhVyk4dxIshW1N9XDtPm7D3jG0MOO3nO7VCbsXmybO+FA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:25 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 09/16] spi: s3c64xx: check return code of dmaengine_slave_config() Date: Mon, 5 Feb 2024 12:45:06 +0000 Message-ID: <20240205124513.447875-10-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044531_843632_657DCD21 X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Check the return code of dmaengine_slave_config(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index fcc1f16d3ad1..43b9792988b6 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -302,7 +302,9 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, config.dst_maxburst = 1; } config.direction = dma->direction; - dmaengine_slave_config(dma->ch, &config); + ret = dmaengine_slave_config(dma->ch, &config); + if (ret) + return ret; desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); From patchwork Mon Feb 5 12:45:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A35AC4829A for ; Mon, 5 Feb 2024 12:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Elu2tsBfZQ+p1pXuXTZalReAJCqhu7og9m9oLIf6fYQ=; b=hwjXyFtDS7p2SO FTr1g/wtPHQGaycsgxvwYRcMRNUNAXejFnMwarKldr0yDUdX+TuXSI+lROkWQRc+pX/Kn/oz/GuGG O4q6m6ghRqFK2ANnZRzfgnCR9OqLNlLr09x7klgAthJ3KXCzYUht1aQhhm0C2IwKgNvfYiRMGbOh7 HrzZctE50+2vNvx+m+ER2fgKZWysiY2d/uEFV49gepSuIFqNfYkbcobkkk5aPWPCG9osHFYnedc9H Ebuguf5p0BqJtsmBo7hucdUvmxRf+1dJsj8QumIqzKOc7JlDbyVhXjdnf6JTykVRrPlR33DTxB6IJ l/lXBXB0iEl+HqZHvP4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMF-00000003GQI-3m1I; Mon, 05 Feb 2024 12:45:55 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G1g-2DCU for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:35 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40fccd090c2so20495885e9.0 for ; Mon, 05 Feb 2024 04:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137127; x=1707741927; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JtonYnG1zvMSmP8RYe4qSrpkG7WWpwfs2mfkmLGPi30=; b=ee9US1D28SOT1Z+xroAVfzEwIQOMwcxQ/upn8rYBFEwwb5qtveCOXJ/G8kNTZBAJbG 4DrZTL+0BspWkLYbuiF5nw/U24V6x1yFl71bcJ39x0gLdgUKzGz8mZWYl2my8WBs3U0B Z8ThDFYSo2zlXuuE4LY9hwlX5b7fIlY3qtvWs2Bc2J8KTrqTm4trQn1YBJP0sc9E6oTz OfoV7b0uOLewMJ6s0JiGTDdpO9DOPoUip4aq6+YZaLHc1oRqxWLHQclQsSo0DPK0kkdO 1bbp4obJmwh2SBi/lQbcJnn1Kq9UD5piu7RFcisd/2eubEk+kj1tsMPOKAYbGH7MyPka wUuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137127; x=1707741927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JtonYnG1zvMSmP8RYe4qSrpkG7WWpwfs2mfkmLGPi30=; b=TYeVdOYQW6RSw2EJ6xMi837ODjSp5rR7NbQqhBe4sDh2pfCKpn8GMivrI860vSHXBT 3v5BK+3pwWZKxWicfoqLZFKJgnGg6oqVBtaX+u/AcqdZFciy/CuQj3qyFFniz1n9S+Q7 C3DwA5CMamwKQP6GOLBSU9nk9TLvUIZBlX0GHbHRtdADys2r1MXlzNHREdU0GPa38dwA dArO+YmcGAcL0MeV8y/cQbW5p6Yqi9/ahTAfQyHF0WVrLHOxuR9q09Mk8fLAGkWdyd8h qnYtCgMm8uDi0ytkY6BGwy6z/G+TP/c1zAqriVxW+9uSdfzbfU9iRqYE5taMpQBGLUFe tptg== X-Gm-Message-State: AOJu0YwLz6qCdZr4DBaW1CSrnJ2NkuwcExvY3Qwg4KccW4Bx7OjC+GP5 r/9/9fGHAoCEj0Kd8QUggMNpLjPNOz/As09keXcPrnls/53P9T5GzVDl7ILg0fg= X-Google-Smtp-Source: AGHT+IGvOiXo7HPcAuCueUfCXl+hW1dHjHJs0oFybOPNePVj78Eq7mqkrITmY1dHKEpvtlR/onCLSA== X-Received: by 2002:a5d:628e:0:b0:33b:1494:e4cd with SMTP id k14-20020a5d628e000000b0033b1494e4cdmr8738260wru.3.1707137126957; Mon, 05 Feb 2024 04:45:26 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUnB2TnwxP2m+P+k2osg80LUiFMk8AYW9KKJixyKCil1SFvymbNwDnyv5aGOLjkdFIIat4WmSO7a4JXLHXn3VISSvM+7RVQcg0Pc0Fb9CO2WjD9q2jAPVAk+Y81aHewTEE1IiAUbWO2KdsWTh+EVlqaA26G3INEN+MW5DD//ZHCIBgpkDe+Q1yXqKZwi7+TZV6oZgWxpLWtlnC/vbOnnxR5hsTMrwcDUDdAcOhChiLGv2Cy+Fee/HbCH/Faz0FVfeE/fIgfQU1IizkzZZUkIk8biLIW2rCUJFI6sj/09hijvYqXudHO+D77AWOHBK8Jgy5aZtvLBRys53v9c3/ru4AGJtK+iGd5tYVFx0GPzDwqTGRYDcIPSQkBIOWaeLWHB0eNBql9MhxloRoKEj+AwfvCosH7A5tKS0fuUekbdm/MbC19l3fiGQbqdyjkJ62nOFmMU5HkynyBAYQUxajpBYqcz0FL95kIBqlij49YqJmlZcSsEDOd9WIc6DBH3g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:26 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 10/16] spi: s3c64xx: propagate the dma_submit_error() error code Date: Mon, 5 Feb 2024 12:45:07 +0000 Message-ID: <20240205124513.447875-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044533_670537_C231AC18 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 43b9792988b6..7a37f5d0abd9 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -321,7 +321,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch); From patchwork Mon Feb 5 12:45:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 945E3C4828D for ; Mon, 5 Feb 2024 12:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pu6aKpqIlw3lhKD9YRmYiw5ahddLBSHeesDo4XaHmEo=; b=NW5K5vfJRqe06y 3H8SE9wePAwGKYnv5GoLG8avGJsJAtHhwusTedkiSMBKbPhaUEtbNmJFsB7g67By6ZJ83AH88EOTe SskTL3JywsHZYWA8aWJ8zPmDgOYsiv412ZIk2k3tsHLeeJxjnxouo6s3nUwuUsTghMPdH89Uci8B9 iVcCoMz+PGyrA08fy2jbYYWTwkpTxBwZMQHEHLNBw7ZHGzZvoS6JPv0NYFZlTaPtd3hLZsJmkXy88 kBEfwg/zL4L7a1tm0S2exMs0l/Xn/Ni0oVeuKhroThKh9WgUDOxxUn9eWikyfdVAra9EVoqWTr/Z5 CX85d0mhgJkFNC8/wE6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyM3-00000003GEK-0504; Mon, 05 Feb 2024 12:45:43 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLp-00000003G2q-2N5z for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:30 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40fc52c2ae4so28232635e9.3 for ; Mon, 05 Feb 2024 04:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137128; x=1707741928; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YZvfaKKEFRvfmSDe4W0tI5jmLTFflp/Gm8s0A/HkuUc=; b=Mfd/AcHdJm0wigt4L9awGMWIERajUO4PAt6ffMcfGLWQfWv9H6dliaCiSLSwNMu8aa I+LGPrU/n3WzRuv42PweP1Uj1fQJl0bi1SOIpQjO/D20NVG+P43HmxF1q32ivh/0bqS0 h6M0FDYv0Qu+NPy18VLoXHK9GS1qUngJ7oymmfN8ayn8vz2S/JQ0IPPun7wpD2FUnPWR 2HJeRQ3KFroO/GtzECf7KYTfa+GQmew6+Tg4Hdpr40Vx7dfzVb21m1nxhHmr5XvSFqh0 ITzXVOEuUieiBCtqcY5srrIkKFgD5HYhc6OXdCR68hl/wl2lBqcMlMuDGv5ZpZcM+Dvb JUXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137128; x=1707741928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YZvfaKKEFRvfmSDe4W0tI5jmLTFflp/Gm8s0A/HkuUc=; b=vYQ85A9J9fu4kD79AAEc+UjTrvP/WbkjtunmPs6XGBZNOJblTHPBJpIBjUcBYDIAlQ 8jqfRNKktBM4aCE0dmlVPybh3UkLdNM+bCDWRqD22PEjhbKaAt6Xr2TqplPsqO3QPDu2 /c3tenJLWvUpZM3RffOzn40IHnP51NskHKxUKrx4YwbtCilKX77VTVDwHLTF26ifWeaA APoAEKFBx3EVkGComIPBSDlXJ1TV1RpsfLca4ZF9mIr1PAKk1KafHWfYj5d+Y2ffK5Y7 jPG0hq82FoBBz0XXXT8efRMwKGrLPm8nzyymjvNd9OAYmpFjotE3ReWXonpRIYI/T7J8 AiFw== X-Gm-Message-State: AOJu0YyK84KFQAHWe2GAHUUmLzlFKfiDCpAvmTLTjdRL7ExTxBDmPgeI KEu3MahmdjeqUSl8i86l3TKVs5nVUYZGyRveMXdKkd6DtqXWVjfKBCzTGL7dqzuEfwIakPOPZdo SLU9ZfA== X-Google-Smtp-Source: AGHT+IGT76ECdpse5+FEjXiQNGRSUJHWZEYOj01Gi0tuS340doxMhwBI/+wWnW/4nShfRUwus4E5AA== X-Received: by 2002:a05:600c:20e:b0:40f:ccb1:7d90 with SMTP id 14-20020a05600c020e00b0040fccb17d90mr4588864wmi.12.1707137128331; Mon, 05 Feb 2024 04:45:28 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVjJyP66heDdgX7AE01HkbJQ2VlHEGVuAMdf000jcqKqKCWDD6ajy1vpmjw/HT/oqqSheMnqZWnlI5Gu24ypc3Yp3DrG9CDy6JsHFBo/vKGpeNyc2wue5+Bfq/2q9cpy5Zuorl9hvv9IUl4Jw+AbCdaW1uQqLmYL/oC5BMEgHZZb7issd5ZW9PoiXyPw540IjIfcCKS1e5gUveV6ldLB73NDUtg3wdMHuk9LQIhWpPmoKLlMJo3tYiUprmQSRWvzMfF8e5EvVKC+qK4dPkLSa/iSxhBPvBDsk/fEduAg+Xpic/b4n2DrcGi6Eyq/0VO5H3rgh/EluNQha1oMRL4N/V0v2tItrAnQeEcn1AgLJ9dKUziwskkr2KWb7YoOLaBJCHeI/7d/piTASe19rnKdL0ohVLrlMNZ4ZZA3b5rl3Y6pk6RugmAWUrsC09LT4hhoUDSqs9H+UziXCqkZeOvFNtk0bFHL0eUPbrVOr0PUBGOHy8360tuR6Fq5IBmgA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:27 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 11/16] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Date: Mon, 5 Feb 2024 12:45:08 +0000 Message-ID: <20240205124513.447875-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044529_680833_1BB43E8E X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Don't monopolize the name. Prepend the driver prefix to the function name. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7a37f5d0abd9..a51b5ff27d5a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -278,8 +278,8 @@ static void s3c64xx_spi_dmacb(void *data) spin_unlock_irqrestore(&sdd->lock, flags); } -static int prepare_dma(struct s3c64xx_spi_dma_data *dma, - struct sg_table *sgt) +static int s3c64xx_prepare_dma(struct s3c64xx_spi_dma_data *dma, + struct sg_table *sgt) { struct s3c64xx_spi_driver_data *sdd; struct dma_slave_config config; @@ -444,7 +444,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd, chcfg |= S3C64XX_SPI_CH_TXCH_ON; if (dma_mode) { modecfg |= S3C64XX_SPI_MODE_TXDMA_ON; - ret = prepare_dma(&sdd->tx_dma, &xfer->tx_sg); + ret = s3c64xx_prepare_dma(&sdd->tx_dma, &xfer->tx_sg); } else { switch (sdd->cur_bpw) { case 32: @@ -476,7 +476,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd, writel(((xfer->len * 8 / sdd->cur_bpw) & 0xffff) | S3C64XX_SPI_PACKET_CNT_EN, regs + S3C64XX_SPI_PACKET_CNT); - ret = prepare_dma(&sdd->rx_dma, &xfer->rx_sg); + ret = s3c64xx_prepare_dma(&sdd->rx_dma, &xfer->rx_sg); } } From patchwork Mon Feb 5 12:45:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 089E3C48298 for ; Mon, 5 Feb 2024 12:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kFK/vuPMA6hFkT4lafKsX2DitooWIcYJJDtwFCGuJnc=; b=HCjv2OEbg8YnxT SEGd8ptgV+cftlut0Bp8W/naiSU9BzqgcxeZaZqndTdoS8AwglriWu5uPlhQ5CzJHFtIDtOLsM7Kq 0RHEkakLlO2jaUHWH+loPmft0CED8L/AIa6TjewV8rL8eQ5sSkoMiZcYdePdPW9FifOAYc+JzLb5y rYfPXO2GYUw1hvs+vhLAyczIw2UnBOTcYlllJCCBCVJSa20GWc5mel2pkbRfl0KDNujBzurIeDGSu EjOGOEmn6wJjDBHtCHaHK7fCj5S5hZFDun1XWu0SLwdJjt5bqC/9+JUBlNtA0fqhN5ZOFoF5tnFCu r8Aoo3/OZUzXyDmYhS+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMH-00000003GRs-2u41; Mon, 05 Feb 2024 12:45:57 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G3X-2DnE for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:37 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5111e5e4e2bso6747466e87.3 for ; Mon, 05 Feb 2024 04:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137129; x=1707741929; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GeZOS2Z+VG4P/iRAp87EuShVVs7fGWt6JlzNyGBkAOc=; b=myvmnhunLwB+tBmWU5vLBuWP7uvNQ/vfy6iJgPxMd9ZbT/cuR09hk+ptsUKwir2bij JozqvbCwb8LxwlHLjW6TmwqA+DzV/uJqWDkgp/dKu2a3svNXtnjRGb0OVTLpDYe/sG3l nAea6+4d8ca99HgzTcffDiB+vYHcZy89LmFWDi4hr2koaobd1shGB2We8bFCW3GlVZ9e I9E7nJ9QbzaA7s0QfoGnaGnWdD9dFnwfMmOmlW2FphO3Dqw5/NPpKFYGluQBMBgDczwY MCU3R7/O1CYlz5JyPFZB4U8eo+05rO6uAVNY0Xi2eIUZ2Nqv9tWjqKiRDwnD+HrnmTv5 hzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137129; x=1707741929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GeZOS2Z+VG4P/iRAp87EuShVVs7fGWt6JlzNyGBkAOc=; b=iChoqzNUHj5pDtYqFxqkRgsdiAtm4FtAA6Lt931BpRwluLkjlYs7X2kCLhYpToACuY WKd2mT6GV7CWU31+Ijdl7YZ4GtSlg4VtWFEuYOZKoNFv+b2hPLV5w/VW07sDQ41+e+8l zl6qhMU+o0IonZ+ZcgGkqlAZQXxx3Rmzu/NpHfOZWvl6umH+QlZx9sJarIKHRnT0svj0 usIrGLhd6mCEN2dUlrOV2VDtzQ4+pEeesFnkQg/l+QyAxepP6s/OivZ0LpZQ+qX+lt03 KUzJI+oXdL603NUiaKlUTMoLRFywHnnhq0ujVXLNrc5wUMon+mkPZiy4KEOQAEv6pAcM 13UA== X-Gm-Message-State: AOJu0YyutzxEJUnPCFGDD0WTj70AqKJRJbLG8B8r1PFdA/p/MwmDBBMj i1KV+Dm0qCZ2QJadQ4bXVumMfsbvUo8bxhH/o2EI+xz4npbXaiN2HK48Rc8vmEw= X-Google-Smtp-Source: AGHT+IE1mZbxXVQps2jZE3OUPQWt1FaUJXLkEeIn02wh0XP0QYhwUFNqTyidAJP44tKJ7W72VSQ+Wg== X-Received: by 2002:a05:6512:b94:b0:511:5328:6f5b with SMTP id b20-20020a0565120b9400b0051153286f5bmr1349244lfv.53.1707137129604; Mon, 05 Feb 2024 04:45:29 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWxyPgcgxfiE+kR7RyEi6zp53fCuacTX2viE9B5R90V9SyGN/7KRwimz7oLuTFX224e0mH+u/tSXCoq1cSEwBorkzsCwd3cexHCa40WP3rZhgXKNoXdij2lelf9q97xuZbLOwIqGQfF50hoWChBZC+0w3RSFZRBR4hWRKaWnXaV9FU6UpnAWNBP+B1UO2RWHTFKKEGWS1P4LwMUvxD0Mzn0+YAk0Y1j2WIYdb5assLOxXZSG3XZ8e4WfSJ15Bwf606rnIZHDSuWbd8lBOH5RZTR/03gsZrnRNoPZHRrWU+iLqrDJXp26rLMeQ8jZOkFjHrK/dmz6ulOICea4Uc1AO0brJm9Z14E1i/x2lLtCOfeyMfWeQ9V+j1s2kCxHjUEETJG5KgDBJF+B5GswQnoet8g3nuQl6u3BU4TO/dzk3K0ttwfj5g01hfGBsyNYSSHHKUv37Rz0YA4zsxAZ1FodqoTnjX7LBdvADzuv6ZsGads7ThFJrj0kRRm7tQgFw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:28 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 12/16] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Date: Mon, 5 Feb 2024 12:45:09 +0000 Message-ID: <20240205124513.447875-13-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044533_702682_4F3037FF X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ETIMEDOUT is more specific than EIO, use it for wait_for_completion_timeout(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a51b5ff27d5a..fff430b9e849 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -526,7 +526,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, /* * If the previous xfer was completed within timeout, then - * proceed further else return -EIO. + * proceed further else return -ETIMEDOUT. * DmaTx returns after simply writing data in the FIFO, * w/o waiting for real transmission on the bus to finish. * DmaRx returns only after Dma read data from FIFO which @@ -547,7 +547,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, /* If timed out while checking rx/tx status return error */ if (!val) - return -EIO; + return -ETIMEDOUT; return 0; } @@ -577,7 +577,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, if (use_irq) { val = msecs_to_jiffies(ms); if (!wait_for_completion_timeout(&sdd->xfer_completion, val)) - return -EIO; + return -ETIMEDOUT; } val = msecs_to_loops(ms); From patchwork Mon Feb 5 12:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545502 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BEC1C4828D for ; Mon, 5 Feb 2024 12:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A2oijrD7bhgJmXR6Q8htOIeLfwQOWB19pmStMb05diI=; b=ZSw5jt95cEJ3Rn rVXNY5JLewEBHPHBpTqseH4crXdFp1uEnKuKMF5oX+YJJTUIPhHHGLB49xZsIK5HVA5eoxMCdksi3 VMV6eT051JahtsxrCV0azYFnBzq2FfouVqQpycfpt+gkxklZxuetr7Xge5+fhtHhYUF3oeoWAFmtD cuVX10lRCYdX2oBbpXclSI28+8c79HkocCM1qOBEAMd2klmazqSfSSZ8X9sCej+U3LFIiw5tM1I1r Tq+pGruDvfFAZcxxKtlMXXjcUfKB9R7pTu9V6UqpnMbtGBKlqrpt9bkP6wgUqaF4wFnyR5gECL6rB 0ptdTCEnxK3qOaelL3Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyME-00000003GPE-2Oe3; Mon, 05 Feb 2024 12:45:54 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G3f-2Ckb for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:35 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33929364bdaso2688889f8f.2 for ; Mon, 05 Feb 2024 04:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137130; x=1707741930; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pMdPKuCa+A0pku+lpKMRGIhG3kodHHE5iXFOt26r9zs=; b=OjLAVqVvPL4uuSk0Z7lFVcCX48EAnoI1ZbbB0igL3rkOLHLAkWhgZChFPJfz8dJiH+ gaAe/WBaebUJDaQiv0tzY77y3ZOTcK3B5JSXcEH6V+0Q/PfnBKEw8JhdxjJ8Fq2wr8t8 siWjDGKEW+Qu8Dt6OnOP7Bp9R4ZGgRTRWNkIzm4ScF09NixG0+5UPTZ7iKBiQGKUhAm3 kQnc5rXSdzUzxxGttdGB/qOx4DCjWWi5i++NF+e9D/TOXfzquOBXbM2TwFtibUFfuxMn Tw2/fI3IMy/4AKP59J0phqriTCwriuepGeUz2pVvBi46KvdUp9hTq2pcXvthkdHr9vOL SzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137130; x=1707741930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pMdPKuCa+A0pku+lpKMRGIhG3kodHHE5iXFOt26r9zs=; b=wqV6SDQ9/EP8hi/INC0zdbpRBtnu7vtKGguaMb3VW2cQZwoKWTJOMuqdk2p5RZHoyN kajP63YNv6d7c4Aaci1RQmacgXFs3RreiF6zhKOCyeaVhK9k8jbxwjLO0y75Au5hTmcZ O8DlOcv868VjOHAizlUUhyJkSrJXb1sXdLNIBSRzISbxKxjjWRwwh5bUrELMXmCkt7MF hp0CW+ZIInidruZ93eOotr+pvsZqRkspPNy8BfDtGDETlMXYtd2QhlNg1/gQ+tEBKx/G M+AgQyQIFlcRDodfukfyiU5b43kHeyfyuav+DwLJCUj5WKaiQurbL44ogrdJqrqiDj6A oyxw== X-Gm-Message-State: AOJu0Yyv7oQhfZ6HdqEqOZvzFfF69UFEgTVlwfAwOB+PqnMPGkOMSCC8 GKn0mHZeZe2zKZEBnmpiZ7Y6i+kFNs7bqwDoTad7Gzh5WR7EiHLW5TP1xOp2TGE= X-Google-Smtp-Source: AGHT+IGossleR/t3Dta3NCg2Z2WPIoqoJE6vcP3vID1Krxh75KjzP3TERTiV74XdiyGuaLtdV0xObw== X-Received: by 2002:a5d:608e:0:b0:33b:3d6f:7a2e with SMTP id w14-20020a5d608e000000b0033b3d6f7a2emr1870007wrt.49.1707137130247; Mon, 05 Feb 2024 04:45:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXg3qJOH3WJfmlDrm2ZHHrIR7JlWC3n66rAo3+txIBb+YdC1ewlKXR6QRNOinsD3/ORZJtHBzvEvZ/0t1Xnsi1Pc7WBZOViqG6TZhbIrRxPFDFOUWU6t2Aw6WbbTTLkpru1N5NQP1Jm0gPjsWkzx9ma/8bhKWO1YqaDBGuImg+p3Ve+if6M/tXtMWD1B9t1NcnrGaHpoyDuT47xg7eRyMnefKyv5gYPFUOcY6ypLx77FoIe9+ovMJMfwGhXT0rB04bv1GFTgcTlIOqrVbdHhRk1CiLtcQofE5Y6S1+sKak+XYw4qAw0Dj6Re0R1UniB77mBjiopJW8hEqafNZ1d4k0xSjQIRaGwT6g+0iHZZC8BcP/qxQyIFX+nSe/ts2IGcVeLhX0nWuvsQ6J6KgCPkWT8Df3lfnsPT7J5/qzXr56uwXt1/XD0WLlimQ4/XNgc1AwNjJvlRRcOCAlciIkOHFM+NA3Nbk+2bbFTkm6UybgsBtWaxiINQSu2XSz9Vw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:29 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 13/16] spi: s3c64xx: drop blank line between declarations Date: Mon, 5 Feb 2024 12:45:10 +0000 Message-ID: <20240205124513.447875-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044533_670285_64B5F311 X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop the blank line and move the logical operation in the body of the function rather than in initialization list. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index fff430b9e849..1b84f5fdebce 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1320,8 +1320,9 @@ static int s3c64xx_spi_suspend(struct device *dev) { struct spi_controller *host = dev_get_drvdata(dev); struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); + int ret; - int ret = spi_controller_suspend(host); + ret = spi_controller_suspend(host); if (ret) return ret; From patchwork Mon Feb 5 12:45:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5CC6C48295 for ; Mon, 5 Feb 2024 12:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z3cGaLUjjN8vEt0lGvGRJOP1IqGSvOiWlZPP223JVN0=; b=g3DON2BSipiJ4b gYCIM0FC3N8Px29Qcy7BsxDI1KKxKqXS/nQ3S39Qfp27Yx9b9v6APhD4xVH9lGGg1pMzSlqJ93r3h TftacigTV/zrC/tSbnc5hVgVoz2oVz8bXstF4NVqmD2Pwn8JksGj1UcImPHaSZz49a1JierQi/WM8 fgMS5+YeIqJt4J1j9n86OwmtMBlWcl/Nmko1WDOaQ1SnuYRqFYidchFOo/eaeZZBj1NXaBm9sLA4l XMO28uthgs/48w8TOujHTu6bYpHKaHnl1jB7IKNZdnEFriyNuykOaPQcX0V2QpuFXMkq/qQsEq6Co lPZPJPD9fyQV6MGtehyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMY-00000003Gia-1RQu; Mon, 05 Feb 2024 12:46:14 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLt-00000003G43-3Gt8 for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:38 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40fd280421aso15294095e9.3 for ; Mon, 05 Feb 2024 04:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137131; x=1707741931; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mnMYlR6fQ0mQVONi00LlSkAABzsjAbHvknmZ+n/K3Yg=; b=Yku0RdbRXyOD7+RVe7VooNQjj7/H5FUSBrlQfcKEDr145H8v2WQxCmyk57d+XQzIU3 JfKg8AftKVsw3wlnfsj4XWhP+g8DV1pW+2VwaRR6H9rzeFMrfABtZ5P/rCZn8nZBdTiM y7y88xBb6z45aDyyiPPEXbmYl+MxfjexP3eQMV83IXjBehIsm7yEgBOVHcgU9Ug4+VtX w7Wm64pK3eBexLGeIh5hO5MjeBDYHnE+RyiWD7nDgL+DOs8GIUUI/bhRJTncYwNdTjJ7 KRWRyQz2830gReTq67CEiGHiRBBQm7nI0L/ujg9mq2ogPircEjwgdtDY4p2/dLhZ9r+a tciQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137131; x=1707741931; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mnMYlR6fQ0mQVONi00LlSkAABzsjAbHvknmZ+n/K3Yg=; b=uv3gYapEjvqoZn5wxQh2/+D8/F+96ObLQ3pu/8Lov7b3y8OvuJDuTe5MOiyl0zK85e dQKvR/XUw4vJWNwz4dmSkStesjDQg7ggJ/BwABFozIR545n5R5VYkV1BK9I941rzZooS NuU9rjctG7rhPSB5l5uHhx+qQIKxHOf6W/xkehJuM5ONtKGc3uS2HOqwgFc0UKf0fzZr TnL3axelGjJPrFzKUIU9Cd2f10IdFlb+tm8qvo7Z1zptDHWnmXxX3Vd/hSQe3a+5ROqU wzC1bt0PCtgqH7eQB1lIT+civPnMyW3ueo51+N33DQ6vsMHXONFxMuH8m/G8XpNbfdzP tn5w== X-Gm-Message-State: AOJu0YxjhagtfR4otHndc2m4mMcUP1WNyqkhLHiswFU1vGMo2vyBKgA6 bYqAcdCCkuAsMijsqb0IRnR8/b0T+5Pl8zVEyUCsWt+3Sx+f2f5o8rYsc/KWWZE= X-Google-Smtp-Source: AGHT+IHh2/7KX6KKpvaNwnmk9gubBGVZ9ofeLerSnDyELk8DCSmaQzMWdOz1adXh+ZdWJvshWkpSGA== X-Received: by 2002:a05:600c:3585:b0:40f:c234:1fcc with SMTP id p5-20020a05600c358500b0040fc2341fccmr4358107wmq.29.1707137131112; Mon, 05 Feb 2024 04:45:31 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXcXFLJy6cfNdvSiZapC8x0gY2p2hCeIf/v6F/VZuAJu2HP1lwRIRqcyrhUsMDxQiJ9h10Rszuh0YKKJXHLP4Y4qai7EYJnqdHc2Kcm2fNELedi2qdVc2nSGdVppMbXle4S+bJysxUzFnWoRD5oVwNbG4ig02R4mPkWLoqpL6N0RawwU7U+oq70BZJleN5TCYzhoAeDdVexwYbEg6qh/pcIL1Euw4mYDTDOa1Q8kZcufSB7BPaVy4Dq+6pAzd9Hgmdfm2oxXmOmkYriteNl+xq6ahR75w1JqoOG/qmTLGQgW7NVtrT+tt+/ju8W7oh2U/ZqUjPtvVfQ4qzvuHCBxOWE8lTJIrPFt9leSmy29qKNjrkOmtKhPs9XH6UxdBnGzxezV4qEQXa4VBkQpJIDt8C+KKSCUelzDRdT4bFxW3TGnQZoq/W0h98avBuzO0krl7TZ1+F4Tei77sEFQaVpSWJPSQ5l3959S0B+NO+tMXQYS1FdoOo31JNjWysPSA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:30 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 14/16] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Date: Mon, 5 Feb 2024 12:45:11 +0000 Message-ID: <20240205124513.447875-15-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044534_047399_CD38D4E8 X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "samsung,spi-src-clk" and "num-cs" are optional dt properties. Downgrade the message from warning to debug message. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1b84f5fdebce..a103d9e125b1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1109,14 +1109,14 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) return ERR_PTR(-ENOMEM); if (of_property_read_u32(dev->of_node, "samsung,spi-src-clk", &temp)) { - dev_warn(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n"); + dev_dbg(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n"); sci->src_clk_nr = 0; } else { sci->src_clk_nr = temp; } if (of_property_read_u32(dev->of_node, "num-cs", &temp)) { - dev_warn(dev, "number of chip select lines not specified, assuming 1 chip select line\n"); + dev_dbg(dev, "number of chip select lines not specified, assuming 1 chip select line\n"); sci->num_cs = 1; } else { sci->num_cs = temp; From patchwork Mon Feb 5 12:45:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5270C4828D for ; Mon, 5 Feb 2024 12:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F9EQ0pNrj1g342ojTkKM0TdkXJI2NLxeysqbNFliaZQ=; b=Iuz6Q48DIlKTsR fYeh70hg9FWMrkB4Kusp/PyofE1KJAFLWQtQ4CJXfGtGVhcxsATx6R/cFp7SeD2A2LLgDlfO3VIxg bS7E2o+5+8F9/M2Yecj8jt8xjzMWf8TWZqSUpPJdW/lqXX3jJmRRA3RK/4svdYlAcbIyx16AkM6YL 8fuz9kajDbKUF4yT545mqEYCMHW03feNczN0FKaUYt0DsDjgc3C/NU0mY/1WahB+pTCLGuykCNyPP ioGOg7jvRvDIqQN/3GKugSwyvTHj2NreD+asaCITxLofkoHSRQhiTLXuBVRU2N731xKtfnUIe0+t4 kDM1C1ZG2UcVMCVFzUug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyML-00000003GVo-35uh; Mon, 05 Feb 2024 12:46:01 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLu-00000003G4u-2GED for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:38 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-33b18099411so730053f8f.0 for ; Mon, 05 Feb 2024 04:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137132; x=1707741932; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YQXkAU+74DrdhIBCBHKX2MNDRgI/UgoC8DKW9ZMunl8=; b=tMPBw0j79YBysjWwSJVLJiN0AqsHpWS9/JFiaU4xsYhX3KZSnNHUhkUnD/4BrPYB6Y jr8PpxMaFgRAZsJtNBDo/7DQ2a8PqrU228P62JF5mx6DS3kHxx0Dqtd+152vnRuGwjr6 mPaZhw5C3vqIEFv2nsE9nSx7BCUq3xoyaMLdEs5S1yD6m8EMrXriK4TjLJMqAmKfI3hx jpHIipPuKobqIIZrzO/6ANWxWtaecECw5lwikjs5l1A63tYq/b4G1kr6X7jPP+eu+0uj YQkMh2NwA4x6TQX9voB0CELZJIKGvgnliW+8UwedkYQEVmjy8Eu9O7JdfPmdqRaiR7kc d2zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137132; x=1707741932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQXkAU+74DrdhIBCBHKX2MNDRgI/UgoC8DKW9ZMunl8=; b=cotVVONaiAGYuKM3ANm608mxeMJ4O0l72UG45KD6R4vsFYYuSUSjbyd2tgt+Opdjil ybDPFgJZdi6fBtufeMc5Rwk5PuXEfqa4LTr3Ai98gaav7FFuXLLoNntmMvVKHW42xILe Janmg0ObSzgjXhaIxqfhRpV4NRipJbteKuns2ooenYGrM0roWFpIZ6hg2JVOv0R3g0Gg hnUysIvXgsow/Yx9udfd9OWyzps0XPAImWOJzOmGxD6+CQG3l08/wu5E245ffUgf69P5 yov75H5qmtcbZNv7T1a2LUGYFTt9uhYRl/457RylRgx5BXARkpk8tICdqMUgZ+6TxD0L +6hQ== X-Gm-Message-State: AOJu0Yx6ZqFfsY6fxYTzp478Mm74eoGzFbSFLju56BTDpCRHhPwnP0CZ 6bmcehHbU9NK0aLmQ0ON24/RLT2g7bOJtKA9rauLjwcHzCVf0EbnnVVrMSF9ihw= X-Google-Smtp-Source: AGHT+IF7w0SrhbwiPOGLZfv8BIa8of6H+8D1PRONLjMNE0XBKdpEovxHCLmvEEYujDtqITnemVr/hw== X-Received: by 2002:a05:6000:1ac8:b0:33b:376b:8127 with SMTP id i8-20020a0560001ac800b0033b376b8127mr3215935wry.54.1707137131953; Mon, 05 Feb 2024 04:45:31 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX2qttf9AlWRBYLbY1d8gb8YqqL+/qbSPDmU1x/m+yaCWDvy07L1ROL3wauST1rGVbRb66EjPIOtlB4n9urmuC6jc87wSzy520b53wDeu2QKN5XqjMaIu+PEGXEtn2PsEEzukAyU3GBbZ6Sh3d1fbai9c99q0GXpW16SJhUi83MA6NNr9cmF+rJT4XDUjW5qAFbK9R8q34VF+gfJsgg7eRJXfTPV1PUwy9A0lDg73R8jnORoZs/RgQ/isCVKdR5yhkorP8qgWX1fPZZns0wex1myEuPyXCjGY88FP1yYOXpvl61hB+5ajhvUFWloaH10FTY6sjpoBbeyXa9UIC1FFORmZLspdFVt5U5PcTM43LzYsuLRANG5F8KTV46cse58Gk5Es8sgGXJjzTw1u2dCU+r+KNu3FOyvQDYTy3HxeCFEIupExIgi3oKRP7Cb/h+ihjduDAV6bGa0+o0EHVLO9kjnYGia/OhRedv/6a3n4v0eIkr9EqK8B2OBiJUhQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:31 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 15/16] spi: s3c64xx: remove duplicated definition Date: Mon, 5 Feb 2024 12:45:12 +0000 Message-ID: <20240205124513.447875-16-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044534_801992_23452905 X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org S3C64XX_SPI_TRAILCNT brings no benefit in terms of name over S3C64XX_SPI_MAX_TRAILCNT. Remove the duplicated definition. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a103d9e125b1..ed0b5cf8fb4d 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -115,8 +115,6 @@ #define S3C64XX_SPI_MAX_TRAILCNT 0x3ff #define S3C64XX_SPI_TRAILCNT_OFF 19 -#define S3C64XX_SPI_TRAILCNT S3C64XX_SPI_MAX_TRAILCNT - #define S3C64XX_SPI_POLLING_SIZE 32 #define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t) @@ -1092,7 +1090,7 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_MODE_CFG); val &= ~S3C64XX_SPI_MODE_4BURST; val &= ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); - val |= (S3C64XX_SPI_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); + val |= (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG); s3c64xx_flush_fifo(sdd); From patchwork Mon Feb 5 12:45:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13545508 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33068C4828D for ; Mon, 5 Feb 2024 12:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kNhNm7xnuTQuf8w0LOId1d3WfsOny2yWBFQ9w7xpe/0=; b=gQUGUkuPL9iZ6H ANi2znlyZkdG+NDbHKzig6iIsI1ZgnSTPkkT8yFnWOhTBdNh2i8Cly1H5kpUDT+mE+G2Rk29uIrsX YQCVhh+PaOFzf/K7pkI6c6NwFzEBAyKQKlPpQN4WvLimw34unSasSG5TNRKPjzTrzZXx301gMmUss smzrIiVnuzCSVdwwdS1iuOE6sHzpMf/BKytiiNUH4DA1S0uc5IIJKJzygZbaZ9PjZa3UQMNezh+WS uEgIoetCJfASRcPnZWiI9yrVxtzIHZe0+YWSGzq4I3nlYrDAl+cAn/ZU7/lG49Tf29ujW25QVEmSB aPcRoZuDYw3QaPl6abzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyMe-00000003Gp5-1QCk; Mon, 05 Feb 2024 12:46:20 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWyLv-00000003G55-14sF for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 12:45:38 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40fd72f7125so10982555e9.1 for ; Mon, 05 Feb 2024 04:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707137132; x=1707741932; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bTE/0vC7WxQ0ABd9oJxLbbsyqbh1xb/MkKSY0UL7qyA=; b=m+u68USNwHZKM6ki5udCrWQZjYW3r9JN9ndkVo0Ax/nZHCoYnOS5blJWFNV7Q/Yddj oykNGm35Su2vOc0ccLZqMob7Ca0V6A9htWW4jfghZORg0OYmVFYRy/t20gnGo5EIHNFQ RVGwOXT5FJVMnKCB+LwBED9MqFcn5B29eW/K9BJO75VVbfaj6UnJv3UVak335jThkozA nGX8HU2c/XUhpdLQ+hPc+p9L/VsLrxMbdAVtj7X8ClltrDkZc3ZDUOM/yf7ulXa86lwn 3idMgyi0dkLs2igPFOmY37IWvGH9+Q/xyGN5CelFqVXHeVURYk4tP01vafqp57JihzG0 woJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137132; x=1707741932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bTE/0vC7WxQ0ABd9oJxLbbsyqbh1xb/MkKSY0UL7qyA=; b=b7kz69QYzNi3x0xTY7xn1xcVnkTqHCWxLvAJNRIJwjfy4TCx3ZRT6ykA1YcEl/rNTf 6whusOmT3hNnujeRHxX2GEuBJXAzxTK0TCr1WF9HjUINDPAS/+uaQShKIzGsgVU0Q6in hA3fKvAaBD76tbl13H9sBBmuaVxvloNBYUeLtVykK1m3iSBN0tcUFqrUSk6LVKSHVYV9 eQmdEjlQGICau43v7+t2OQdF2Ub+uk8rMpAP1ntVxXolYNHjfryLGZ3XjVCoOmZxb3kC SPibcTSO3Yih0d91y0F04+w3DrmwJgziihz0tVR4ApB1kne5tbs6fr3z8tnGmSzRvTaI 235g== X-Gm-Message-State: AOJu0YwmI1qRYQUVi5eZLHIdhBed7KK0pcxq/2FJb6fKjSjbW9mgpZJG BCAFF6XPqPoOn5n79xEv2Wc6GGL3EI8zQQL1M3z1jYIUqzm60vlhPtOb7PMC/B8= X-Google-Smtp-Source: AGHT+IHtAALc9fR7T8Hi/V4r24s8Ve4SlEF7nzbMB27mSpni9V8hYXrKvi9LtEVW3ATD0zbAXNwfUw== X-Received: by 2002:adf:f7d0:0:b0:33b:2200:a076 with SMTP id a16-20020adff7d0000000b0033b2200a076mr5180536wrq.8.1707137132629; Mon, 05 Feb 2024 04:45:32 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXhQbKNIMYyPNUUsGm6OpaKLjLncRljyTEjlpzOjoSmQIPeuwg/T4NPRLuMf6tpq1JIJbVpYxGfT1Q6bpi3ACI5BaL3xKWtECi+tnoRq9br8cJyaWXuFeha4+PIcXC7UqZGMM4j973PqaRzOVSfcW80PE0B+cg8VyBqLyvNcf38VkSZP40ORSRftYfyKPX+zOYiSjctdWrghn92yPmJBgdUcP7YIORCQs36bn0arczXNkLUMI8vtfp87jRkjjOVUDa9yNCU/BAV1p9om6oPPFrTJ1qmX/NDnf/1QTV01BP3vPaV0IqzUnJUs41U0VUWM5hzhkNflSAGocusT1q11OktudMn1GxYToMhFxIO7ZmKTOPvpbn+nFndcFhKUYJ4ecRRvTHdRZzOGjO8Ae3dEjFCJajPhsCJNY4g3muPmaTA54+OEZ8xLEbKN1xqlCG5ZmCm1RKQZ+cTeBewO6tff9YuYGQPhThYaNcfS2g6rbEUhK6TJog2V0Awhqdrag== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id n9-20020adff089000000b0033b35da384fsm3650812wro.33.2024.02.05.04.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:45:32 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v4 16/16] spi: s3c64xx: drop a superfluous bitwise NOT operation Date: Mon, 5 Feb 2024 12:45:13 +0000 Message-ID: <20240205124513.447875-17-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.594.gd9cf4e227d-goog In-Reply-To: <20240205124513.447875-1-tudor.ambarus@linaro.org> References: <20240205124513.447875-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_044535_555850_DCD8CDC6 X-CRM114-Status: UNSURE ( 8.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org val &= ~mask; val |= mask; is equivalent to: val |= mask; Drop the superfluous bitwise NOT operation. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ed0b5cf8fb4d..72c35dbe53b2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1089,7 +1089,6 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_MODE_CFG); val &= ~S3C64XX_SPI_MODE_4BURST; - val &= ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); val |= (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG);