From patchwork Wed Feb 7 03:36:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 13548082 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF25FC01; Wed, 7 Feb 2024 03:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277029; cv=none; b=NxwzWoh6li9d73Kcs43jCQyhdCwqJIzlm2fK5ySd/69QMSBRwsSPci94UGCR/fIEibkRgT+OoOCzpajlgGjKdMhIYGGdJYKHOQjADvvjm7J2WVVbsRWz86VW/UVws2zp9cFfyH0FeKh0oOx03qbHVkCLolL1IiUfUn5iTyCqZos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277029; c=relaxed/simple; bh=wozcyVvHzNR5E7VXBY2YzZhSgKWE1j9Dee975ulTgvY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=b2uXN3NzUXocGZSDPNmU3Y8jhhI1uPfY0vHs73HjYQ+KP3Ch7SGgsdgTtfJDGEf3WtLSdfnJxYIwbj6IXtBSSiUYG6utycizaOxqa8RVV/X1EpZxBh+s66d1u70xuQUEyGCjDE/pa5Xo/9Tb6HFLydUXriEEmSeQFMV96LeBpsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mXh5Pyp7; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mXh5Pyp7" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33b409fc4aeso135580f8f.1; Tue, 06 Feb 2024 19:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707277026; x=1707881826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K0oMvXuXT/Bmvr7nKfz+tfHKE7zRujYl4odDXMOJ8fY=; b=mXh5Pyp7dEVConkKN4fi+USUDQLNbA8E3PRXVsdkVH+VlGWQ9cDVwMM/F/tUebanw0 hU+6qSFcirzmTIG4wuvktwK+0Y9yyZGPlRK0WYCXlAAtU0RK+w36G+B/3WqC0GcP5LmU t5TWwHydoA3PzcxEZs/4ayTLHQZphbo+bxiKSfk+gCm9RkhoQYu3Fb7iR7XaEL1DHb5P 5y0dF+GQT4rJWx4C/NiYezarF7b1f2DZM4MAPC5CQAX8rQEbGUO3TIAP9XOs8T1QbFu+ o4Acd/EzXZUDC7NWxmFwseu0l6BS/kopijSFMRUuOrS9/10tBDmnwZO0k+5VCc75MrrG GkHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707277026; x=1707881826; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K0oMvXuXT/Bmvr7nKfz+tfHKE7zRujYl4odDXMOJ8fY=; b=BoD1pTmpgSs4E2gm4dwrHhcOJw0cQdwznsEh5DZCHWnqeeWRf4fQ1Im5joQKRAczOp wrKclLvIoHCyNWKzHX2iX/clszBuOJVh1U8+I/vMcvijF5w8fbbh/Qfkxoo6J7j8Pus2 yDkfLs9NSLwfDbmc2yzOPmh7xc37sC/3Urb1Ogl/i6R20K/boLNfQud4DKlSn1DKxmuf rxsQ2BUz/hfJO7NPmAECBtZCq1+J8q1U0/DeIcdVUPibfMIAcuFRclxmjllevBo9JWOk UvUP7D3sgMZCkG+EIkxmnP8ROOetFmpVRJSS83L7Q40M7KyY0feqeH9jy8wPzEq9Yj0O ShLw== X-Gm-Message-State: AOJu0YyJPn828ADuaKoqfHQQUkADdNd/r7KppuYzuH63Ri3EYFBAogpU I3UXmSZMyby/u2oHSYLrRtuVueSL2Ooc4JWKXO9aC2YDwY2YXHDN X-Google-Smtp-Source: AGHT+IEC6OTMVKiiwXaTRW+EcaHTMMylrzmtal242jiHjAS9EFELdo3ZaRubLUREoBU4Ip5csdvfzQ== X-Received: by 2002:a5d:460b:0:b0:33b:4ebd:1462 with SMTP id t11-20020a5d460b000000b0033b4ebd1462mr147974wrq.40.1707277025582; Tue, 06 Feb 2024 19:37:05 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUYQrgi4CPyFz0nIMqpFUYqmQ082XxzQPgdfQbNOWxnfpu2DyM35zyk5XvEXPVI7qgJHj5uTzqJXPfZb966sodUZNbN0qKR/TXaZWDo8iCVzhirdvZ8X/wBjb5lO2E7osceGmA5NLQkcKcB7TsBxpfaHIVq2r0uH370BoNdGhINB5iYE33oVtY+t8f3Zl9EwMPsmMG+Lp39x9FPp6mqIQm2Awq8dTtTfzlHrCxg26sN/M6W2KGib8vhsy2DzJp2R1xrmB0IBYs1f2kc Received: from demon-pc.localdomain ([188.24.52.65]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4e05000000b0033b422356fbsm373447wrt.80.2024.02.06.19.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 19:37:05 -0800 (PST) From: Cosmin Tanislav To: Cc: Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 1/2] iio: accel: adxl367: fix DEVID read after reset Date: Wed, 7 Feb 2024 05:36:50 +0200 Message-ID: <20240207033657.206171-1-demonsingur@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 regmap_read_poll_timeout() will not sleep before reading, causing the first read to return -ENXIO on I2C, since the chip does not respond to it while it is being reset. The datasheet specifies that a soft reset operation has a latency of 7.5ms. Add a 15ms sleep between reset and reading the DEVID register, and switch to a simple regmap_read() call. Signed-off-by: Cosmin Tanislav Reviewed-by: Nuno Sa --- drivers/iio/accel/adxl367.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c index 834ee6d63947..210228affb80 100644 --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -1368,9 +1368,11 @@ static int adxl367_verify_devid(struct adxl367_state *st) unsigned int val; int ret; - ret = regmap_read_poll_timeout(st->regmap, ADXL367_REG_DEVID, val, - val == ADXL367_DEVID_AD, 1000, 10000); + ret = regmap_read(st->regmap, ADXL367_REG_DEVID, &val); if (ret) + return dev_err_probe(st->dev, ret, "Failed to read dev id\n"); + + if (val != ADXL367_DEVID_AD) return dev_err_probe(st->dev, -ENODEV, "Invalid dev id 0x%02X, expected 0x%02X\n", val, ADXL367_DEVID_AD); @@ -1449,6 +1451,8 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops, if (ret) return ret; + fsleep(15000); + ret = adxl367_verify_devid(st); if (ret) return ret; From patchwork Wed Feb 7 03:36:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 13548083 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE9810A20; Wed, 7 Feb 2024 03:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277033; cv=none; b=sSyjrQpwv0nMGvxGzYyLkFlWCz0VS8ZQItsY9Hv8xjKmMNwD3XVFbAaNnNM+Wrh1ey7MMxW58xrCssBdJSHW5R3EBSbfI/Ml3t7XT4r6MntIkhFGPnm9GZy6rTRgUsvIwdqkxLESpUG1g+snPnke5+FevMQAahNVFQe6UpWRcwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707277033; c=relaxed/simple; bh=DzXdpNk0IldplWnZUSXf8zpiuY5OZq+4Qd+G8Yan964=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m8hYjYI55slJDDCmfh5lXGMitTtsOmKwS1WHS5PkB+3mMj1dC5CttMyedJsBk91/gS5Obaino8Ht5lAIQT2IaEcIEdV2XomNhDV1d8ZKU3bT45cTWnsW+V5/a3sRh2/du4cWkqdxOYCyYyuhz49K0QwmyDyaSvP71hZ7TF1qU3M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WqSEWnnw; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WqSEWnnw" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40ff802496cso1369385e9.3; Tue, 06 Feb 2024 19:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707277030; x=1707881830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jO4v0nbCePd1+AMeAWjbKpihfEE3SN8JiqCXFyWGK0Y=; b=WqSEWnnwTOD7Sz/aDQSa9U8I87Y5XN13cMnaeM1FHQz/bDyKZ1jpMMbrMq9UzBj9OF ZT/1TUqYae3+LvQyggFes/9WHmKS8V231SEfoX8LmoK8RV5JVGmLLMwisNwUqnhS5+YI 2MTUo0xMgtNVYYNDWyMFtKsiYrTMoH38UBR5b7uSWiydKE4iYmhQLKM6Y7094rDdMhqP niDwQ27XQNmhUXUedbAXXGwX6sv4qYBY55vQZVDhK6Li3jVTilHjSuSCkyK0m1obgsrL yK1RBdktf2a6gRCl/3zxRvsa6qnsffvt7wtO+chfvXLfff0A67Zvji0ZwN0iqbxeO94/ LTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707277030; x=1707881830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jO4v0nbCePd1+AMeAWjbKpihfEE3SN8JiqCXFyWGK0Y=; b=w2y4oIIIjr7I6IoZdETCD+VfliD6Fh8xwr9Agckgn5h9WrEnn/94uHY/AOn5V6hMB1 JHuw2T3MVfCfctxsq4D5M7SFpqkm5loZVaXA+ZNpHapE9OvW51tkgzvbGixMC7n/cAcx bCEzOJprgh2FNBIzTCH4EBp0iL7dkyz29UesDa0byMwTE/+n5V9cejrH3rY4ZAR6wqIp ygyS75CeDw+Sb9vQ8QFm5z8NGKZjTvzoCXdPSZGylMCBW6eEt6IqS3PiwKgX3ONtj1W/ M2OFtUvo7rnnAsjLG7g19BweYyc8/FY7TN+GMt3XQRXckcxiuu/3BdSsCeVkDmr4zbFL gAtg== X-Forwarded-Encrypted: i=1; AJvYcCUjgMbJh4IE2ByXlgwbN8wVTtCV867K5MTDV4EU6IgJsheQxvzm1Vt2SIkWvOmz/Q480/05edI1NKAMChCTzS7t8cMWuak0V0tc0gYnBga8O5BJ/ZFu6i8qtJJKkIovxO0Mmtu+4OHQ X-Gm-Message-State: AOJu0Yx0IkKR2jcZdYcwVQWh0/Ogs+3u/zq8vkUyZgtc5yb0pnLLfOPI a9vic4XkP3A02vOpbVUUv3JfE5WsJSSC3UkI8Y/oYec/bCFhGuco X-Google-Smtp-Source: AGHT+IFvuN46Yba6zvQUzA+PGsOaAcK3v+MuP3fOMQoVXxOcYEkz+hetsFuvi65WoeoI5+4gmpDMbw== X-Received: by 2002:a5d:59a1:0:b0:33b:48f2:13ee with SMTP id p1-20020a5d59a1000000b0033b48f213eemr3193489wrr.19.1707277030214; Tue, 06 Feb 2024 19:37:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXd3JgzV+wPPM5K2DxTTdIA3ceUB2hjcCuZgwd/YIgPq3/Iqwera8AB0fFGyAlFkn2E6t99T6G9yLQ9OBR7L2+/f/7p7RmsKF3vPezfL+3HoJJd6tg4KwwKsO6AmD3HlZkPqiAb4v84wVoFQy7prDLiJV8B8V6BscaUdMPITzbA6e2/3ki8YspigCLKA384hi1q/VhQcZl5HzwHcrM5l9zQm3GmXXHl9bL1RT/ArsaI8O4x2LruKOhjpZIYII5GQ563Utj4CPxS4KcZ Received: from demon-pc.localdomain ([188.24.52.65]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4e05000000b0033b422356fbsm373447wrt.80.2024.02.06.19.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 19:37:09 -0800 (PST) From: Cosmin Tanislav To: Cc: Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register Date: Wed, 7 Feb 2024 05:36:51 +0200 Message-ID: <20240207033657.206171-2-demonsingur@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240207033657.206171-1-demonsingur@gmail.com> References: <20240207033657.206171-1-demonsingur@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As specified in the datasheet, the I2C FIFO data register is 0x18, not 0x42. 0x42 was used by mistake when adapting the ADXL372 driver. Fix this mistake. Signed-off-by: Cosmin Tanislav Reviewed-by: Nuno Sa --- drivers/iio/accel/adxl367_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/adxl367_i2c.c b/drivers/iio/accel/adxl367_i2c.c index b595fe94f3a3..62c74bdc0d77 100644 --- a/drivers/iio/accel/adxl367_i2c.c +++ b/drivers/iio/accel/adxl367_i2c.c @@ -11,7 +11,7 @@ #include "adxl367.h" -#define ADXL367_I2C_FIFO_DATA 0x42 +#define ADXL367_I2C_FIFO_DATA 0x18 struct adxl367_i2c_state { struct regmap *regmap;