From patchwork Wed Feb 7 12:04:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C75C6C4828F for ; Wed, 7 Feb 2024 12:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EbrYv40I1y0OwOsVfVqkNCdX4e0OwzBdlkbsYTn4qvA=; b=2jyypwK35dnacq z4QqzU9wM1I9JrXX3GBmWIq9G39/hdmpzRh2V/ndp5/EJ+IiqxvpGho6QVrWq3fK0vouuIo6CZipi 57Xw6aeu5LIHyzMNXPGvg0rS72DwU/CHLpl8qd8ugCCowYX1awG7nTG7oDt1YSSI1s2JScfSF11DP 0lJ8iQrsU6K4/MvR7suFOOoXCUew4seIJPC67udf88+oyNWrFf2vrGJSnvMjFni27QZ2Gg1PQhuNI sYfd8lCQFQ14KmjTEmVfrd/9E4qv4i9g56BIPAh+ZNHnpUKrKM/UlF422JfJ+Lvha/2B3pFuicdsj KWWznwrSJ7eQUPk9wiFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfV-0000000AZB5-1VZ7; Wed, 07 Feb 2024 12:04:45 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfQ-0000000AZ8k-3GqM for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:42 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33b13332ca7so356786f8f.2 for ; Wed, 07 Feb 2024 04:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307477; x=1707912277; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3PkOeTiV9Vr1e3YEJjpMzE9wK8R9Udngne0PKYOLQyo=; b=Mae65Kfb+oShHAofLa9AX1c2cYVx1t3b11mZUIs19tcGvY4//ofKxzFexuRyeaJAuW 5DygEeRLAaSt5+PpQlsz3L+vzUVR63+4zCAROpIMfnhSXAYUepDqqq6Ah+82/T++efJz VJqwDrIxrSxrPzRnwHSt4mGnDB/FR+9UCQN7+NbGeCMYBEBCH8Y5BvLVLFF1x6rjbuvO YREKwYm76Q3TEClqBPsMqGkSroZIQ0mxi3cxTTq50HNFn4G4/SLZEBjyD5LemwLENzrB d3DpH9IZRs5METRmuxb1lU3mDlqFrCH/kR0fixfBGtZpC+i23xu3yWH1SAcJivjVKafQ FppA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307477; x=1707912277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PkOeTiV9Vr1e3YEJjpMzE9wK8R9Udngne0PKYOLQyo=; b=iRrTIN0SMjENbZ/PLgfzZBj5t+i/RwkL2H1PxCo35EYjtEYq/1VgcGqhprlyiFF8lK 8B5zeyJG+jYXi/hhty5bqQJigIPJ7Vra/bC+BrywleGcs6nMDytGLFKCsUhDmUmsyg7r cIQyTybjUzyDu/kHnhqrAEyLPRXbx2VLbRi2wQ9JvQ16g78SPt2u4bcwH+viIbPVVHiO siurKc4R5vjzVaojbywYCePnvwhjvm5zTSxiwkiW2SFpRgoPXAt/hgpRMRYgMqAuzRB1 3AjYIJJ5TvU8xIxRLgIsgA3TvFBnKM3PT4d4PuX5yS6h7RUQGBKrGzTiaYaZeYWAzk6l PCxQ== X-Forwarded-Encrypted: i=1; AJvYcCU0iii9wA10h0Y1kT3xzBOV5C2bhZaDFgbdNn20pvkTzxJMy5U210sk790mPcPPUHmOwBcsLptEsM8VLP+P0nFcncwcbFmChtDnjx497F6Tfxs59SM= X-Gm-Message-State: AOJu0Yz3DDOec6bK1bve7ekNY6FSGOEv2o0bRfdKq0VQQzifOFmAePfN ePrmBx2O5VcpMB1K5egHLzJTMgMjJzfm6Y1aWjEAogr+tpEStylb59I6V7/qXjU= X-Google-Smtp-Source: AGHT+IHizISQgkpwBJ/ZOu+j/DpNp3CwOOqT46l5+PQ6v2brq0tpCpNqXigNsovkUwiz2s1PwCsJrg== X-Received: by 2002:a5d:5051:0:b0:33a:ef65:172f with SMTP id h17-20020a5d5051000000b0033aef65172fmr3038397wrt.65.1707307477460; Wed, 07 Feb 2024 04:04:37 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWB+BM8Mhb8VFL2sq2sCoTDS49kqgPhevZMeajZjUn2tespElYOon/prHpdepPcDpw+LIoKsrMsDFOFqDCHkVQTsTXhzEoiUyQ2WfxV2qfJ/JLuHHNcAHOq28Nek8tLRyO7m1wpXRmV5aT9pPlCTw5/ZukkMFFG4geVBDz9+6I3C7KmZ+IJLE5mGpGesi1z197Z28tgdtovCzDxggqgJADb6iAfU3/xSI3HmMOqX2Dy+rufzbfkr4nuwpghpo10xMsNYwgT+x4skWwyPHM+T7gaC7f1+F9LzYUBBTKwRGNpxcaj6cnnZdey7tgd9T5rsumdp7Rr68J75Uy0tA0xkrOISXohHWkJb9Ky0fAV+08ClLRZEA+ORzczJej53bA8bfLq5fYYXFzysdkpoEyaYrBFa4zJxVPLiW/lWZVSNp521pGoPFLzYRp6veWfbtzoWAfnUlfFHIY2I6fk6Ix6flRg2wYMuu0ivMPlAf/aJ5cDQY+VNjov/F7BBwTa6g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:37 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 01/17] spi: s3c64xx: sort headers alphabetically Date: Wed, 7 Feb 2024 12:04:15 +0000 Message-ID: <20240207120431.2766269-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040440_851476_B4C3F4C6 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Reviewed-by: Andi Shyti Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 7ab3f3c2e9aa..1455cbd2fa8d 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -3,19 +3,18 @@ // Copyright (c) 2009 Samsung Electronics Co., Ltd. // Jaswinder Singh -#include -#include -#include -#include #include +#include #include #include +#include +#include +#include +#include +#include #include #include #include -#include - -#include #define MAX_SPI_PORTS 16 #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) From patchwork Wed Feb 7 12:04:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA007C4828D for ; Wed, 7 Feb 2024 12:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GPP86vMySesPep0JmvnOJZYIQifZGZW2Ff2Cd+FsWrM=; b=zdRF6I8lP+BFrU J0jSegoiEcwHm7ymdEqI+bfvuZbPneYf3VLcUr8AChPMeW8nu9KznmrmIhm2E4QvfoQ4wzXjmC1Mt T1R737/9bE6YZJQtmSXqie7enRHOCid3dbd9WYmgo9b3HMxYHNqOpIjCygal5YQ4Do2skp8dIjOlX RZ4Zvo666HNN+Dh6rRYnrazXUgqOuYDz5Js2y0xMpp3cmjO2t5ltKCk0hW6MdGnfKfuXQixgiShwW RA2gcV3Q1S7ZzvCXGR3pwJvse4Mx6tKrtyHRozxsFa6+F3UUV5CHfhCeygVBYiDx7rVqGZEuJfGqs db3yUWojRD4TPjdZ2nPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfW-0000000AZBi-0tID; Wed, 07 Feb 2024 12:04:46 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfR-0000000AZ8n-0cIE for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:42 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-33b0f36b808so411856f8f.3 for ; Wed, 07 Feb 2024 04:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307478; x=1707912278; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=souH4fszIHhl+7lfvTkAEtznZt5fFUz7qZaAcpHpDRU=; b=hKYvIVbW6XF2jTuDdpHLLc/ePVLv9Kk5fmK/4zgY7W1JT0RHs1k/62rwrx4R0jb/4w eDD/F0CDLJejNZRk52WYepY+JN2yoRg3mGANy4SeOQGv5NHsiIrefv3oazOCqvG+5DZg YUPta1Tn5kojPWjV+v4yu++3FJsH67X7rFFy6g9OeZFjCfvZTLjw9ewmYqJOGPWI1qiB wVXxEd9eQWI5NLAWyyLMMaT2bp4TUcvyR9r3rf2fTfrdAdK/Ug8bfHUFljvWZxCu7mNl R1w3euZJkuYLJnKSlfWuS388h/km2TKFM2s4k4aVJRIOoqPkQdLSBCvgUODbXTKhdDfJ Bzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307478; x=1707912278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=souH4fszIHhl+7lfvTkAEtznZt5fFUz7qZaAcpHpDRU=; b=uTWjiSaM5QGL5+NZGNT3Rgko/TPEMxkHHWbrvh6jsOtBIZBVN5BHp6AV9yYZyHsUdH vt/eamzS0Utja4XUrdnqGWbJDbcxgWvUMFXIh8lP6EUne9J1DNRS/wKJHwVSbR/GQnZY by0bQB05VnUg73TwZCMCNh2AuAySNCAo4z6+cLpk+myxbiyiwTsdT+LS1LUB63WoDAh3 1FrvEBFAViNw74A5Gm0N3kfqbthNmBciNjcVyOTItkykDgIfi5WW7lZmKQlkpl78j/xS qmgG7wT4MWY2aOGcx8Qi7e0EKKsw2R2VDwxa+ngk1zYUgI7Kn4ZcBkA/E2iVsFLrUXms fybQ== X-Gm-Message-State: AOJu0YygUPFpaokW9csmEfxm32oS3tSpij42zsEZabNHNYJn3vyFfzU2 n8AVccfwhiMAPboIhwJwpi9xMv/AtfBgwISuvQusLhd1Eg6caNgT6LFL6FwxI7c= X-Google-Smtp-Source: AGHT+IGFAtOw1qhjZckIfIOZZA6LDfXKXdro8MKlf13WGl1nFl3I1Ds/CFMhfACjQyDW7Ng2Q7vQpw== X-Received: by 2002:adf:e643:0:b0:33b:1c1e:3e5f with SMTP id b3-20020adfe643000000b0033b1c1e3e5fmr3850519wrn.16.1707307478768; Wed, 07 Feb 2024 04:04:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVEFqJKyWijUEzhbJRb74h2KdtPJux/+fuKK07LYNtY+mMmKVgLvpxl1mOnsS+0GP/LQ6RGT/rP/2ouqOYd8BDJu+w22E1Iit2rIBbvfJQ/RhXAgbVXTjlPGykU72wy5jfmLjQ1sohfh8T+OIM9iN5l6MugccbbO3fQdIi7WFk0E0wNy7U9clh3jFVG+iXZUqPeOjQxa/wKhx0pcf7INIk83Nq69iaw3Cr9FVjoHooq8vAYNs+uv0vPZZMPWOC/WGoDqL7dmagp4DgDvgaT0aP5hSUJ4tC377Tsj6vNpXwXoXCb1o+zA8wxYpZUgLV5R0fpqEQmU130/XHBiBhJd/kLsCjNRQ9InQJPvaidJKoyjMuh8ALsi2l7Q2008zppRfI8M8UQZlL4uKr37bM2e8uAEPL6zGy54VcOwutS0LlvrHGGS8XJ2A1pK9QwZmRtjFZdQZ+lorY/jFqFYQboJrsWRowKETmuzx14/k3mnPrHYyvz7QYTA3XvwL1AQQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:37 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 02/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:16 +0000 Message-ID: <20240207120431.2766269-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040441_207792_23D925FF X-CRM114-Status: UNSURE ( 9.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses readl() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1455cbd2fa8d..9882eb0f4bea 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include From patchwork Wed Feb 7 12:04:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9620C4829A for ; Wed, 7 Feb 2024 12:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGhOXIsRdFZep4CmO1/JOzvbMsFBXZCkghfC5MBrzGo=; b=tglzVipiC8Ah5F 20UN/wpgu2m7BawPovKGG5RWi5u5/s1m40HvTQeTYDkADUrxvj5aJHPThVxnxVgugQc/MdugJfI05 DOdbrl3qyx3Q2G5RPFNKVXhNqHSK9VaDP+ZF9Cb3uPKImz8OK6bcgRH5zjo97K/nsN9yUqyW0m1ry QTPahg43ExfRbz6vibGYig26VeZQjIAS9IOsbySnvphZ4sxAMG8u35rxZiNZ18CwAENAlFyjLf3EW fyswBqtARuwZsd0tvmdslPc1TUpzcUCYTVpbcPWpXlC9vvgV7cMHS0lD1OwYSKe+uyFE6Aw/r25dB G1MvncNYN3dYHSDQ3wtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfY-0000000AZDP-1RgM; Wed, 07 Feb 2024 12:04:48 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfS-0000000AZ92-1FxY for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:43 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-33b0f36b808so411864f8f.3 for ; Wed, 07 Feb 2024 04:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307480; x=1707912280; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LKeYZPmRarVNrSgEJ2RA2bfdFMbY5j4/f0z54RK04Ro=; b=emxlZ9yklYcLoUZ24wEw5CiDGBJSfKtLoGSI+qh1BR4NqgQmRIf9cq5cZoWTkQGr+k DrE/99PALIIvR+7NiTKHKTT44j7xNQ2CoIWVK3VxsujBHt8w8zgtsIu3TMo8iXLaYNNC /PtT3g6k4PFcbfYihN096gKg26yorkYWdcsRh6E7jIUmV0KDvtOQ8bZtNuKcomgmVslp +C3oDWT0DrLbBl4ASvFQQLsrFX4JWUFz8UROuCl6G2llP81Ofcq0vQ03nGJPL8E54tB8 WsiumJnrbIfBfhchE6NV0cESCuGEPCszrfsqo+E83H7antnTHmi9TVSNlkflaItpkqMs vM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307480; x=1707912280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LKeYZPmRarVNrSgEJ2RA2bfdFMbY5j4/f0z54RK04Ro=; b=VJyMjL++ddzUhXLOleeIUE5WLhi0wDj+Tw2CiQRG0hPWGjdX4YK3fERQp6TDPDlB4c zrwsUDHuKVnkgyoJZTOTHApAvzmDCTs+Fm72v9KvrOgkIpi4xF8a1sfGilKSW4KhMqKW +JIhki7kOOfseom3i/egOnBz37xmU5oJsRqlDUSZ08KQp0SAP8IqA3XMa5cHa0TBHzEK AGwiDXS7dmqsRiIuqeELXnU2whlvRUNpsSYzyi0EEjNLP5aFwqOcV98poT0zpVwLWotn kTZBVksuCNf7O8t3SP7J9uAQV8MFTnkUGOE/3hBkOsFQ06XCkui5piLTZ1s7B8pzAjbm 020g== X-Gm-Message-State: AOJu0YyZrz0kYF969Tjv1m1RQItRQ+rW9K/bqSafgal1kbAMi345bku7 0A1PKs7ufDIc2zfrkqzSRp7D9EOW2RAkOLJ1NuIxNXR3VY3DBys/wcl+bFyvut8= X-Google-Smtp-Source: AGHT+IG16uBtP/M/WcNTRS4NKYzE2Pqd80TW+6h6PqJHRZbcdctP+Xdid+Q2vkXyjtwIFRC0HIeXWw== X-Received: by 2002:a5d:4e85:0:b0:33b:21f9:cd9a with SMTP id e5-20020a5d4e85000000b0033b21f9cd9amr4166717wru.19.1707307479786; Wed, 07 Feb 2024 04:04:39 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWJZLqXZGprlWHssMRP5fdnmrfhy0M3YUKVltJCl9cXKPIU9OH+nkcpmuG08whVcjYfQ44PPKJAvTP8e+z3Yfas0wMg/pZWw2jt9F0DI1xNx4m1TV6VZp9pUzsU33UB1xX90TYpm3d5vaqja8oBWLprftGrR346L09q1s+DXi7RZ0UkD/cYVQTdgrMSZRYap048Tr8yqGKW2xY9rg/tWivX5UY4wS39DFTBeYCyl2anxhZ2SIEd8GOAw5lmj47RbUrPWaNBO00RZiGhoUJwI5pAeWXvWufKfTLeRAgqG7ces6Xna0W3ASwxZ34KILqu8swr8N3OE9AqcVOnjM/9JpJf6YI2oReXixhyeOBUMPnqY+LhglZrz6RsoKKCUUhiJkCLW1Q0lnRDjcQo+QMR0u1F+UvVe7PejgtSgaVrxhctqUqPH8kbwQvoXOZ0sqex/PLXYcY0lM6QhMBVA+1Yt5Xj9J211Olk05G+O5K+JDfR1msfhlCZD7q/+W4YXg== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:38 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 03/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:17 +0000 Message-ID: <20240207120431.2766269-4-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040442_386891_BA924CDD X-CRM114-Status: UNSURE ( 9.14 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses GENMASK() but does not include . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 9882eb0f4bea..b1564a447a6e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -3,6 +3,7 @@ // Copyright (c) 2009 Samsung Electronics Co., Ltd. // Jaswinder Singh +#include #include #include #include From patchwork Wed Feb 7 12:04:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E10BC4828F for ; Wed, 7 Feb 2024 12:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hta13bD0szTpwkzl+nIgSEPXdDlp2ZlsQ+nKDcd9fPI=; b=fSdOeso/VqNnhp UslHSJgNBuibLwtNt6xkakdm8yob/Gg52NlRGm0fdizIJ6smjAoooEoybv+RJ1ztGAUt3KTpAVsUg LIGWxhvbTdZvdqQvqUAlWMMdkd7/8ESm6rxK0Dy9KzY67V+CcVL0sfT8q6SP4nBzUK+5slyQg5Bb/ sw56TECfRFUKHOgL5XfC5EmZoZMryOBB6keEQaCi5tbKGN7PrXcvWojSHEDH+HrCrgXi7FwIAj1Ab OEOVravZ5s1VahuUZc5cPg8rWsIPPBAxA3UHyFSoNyB+CggK/26PHI4yq/exMTYlusRYK8OCseatk lw6hefwjEYYQcbTUf2MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfX-0000000AZCZ-0Mtv; Wed, 07 Feb 2024 12:04:47 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfR-0000000AZ9P-3yhd for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:43 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4101565d20bso3182005e9.2 for ; Wed, 07 Feb 2024 04:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307480; x=1707912280; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yI0XGnXFUeGyPrdGimOqJnqeOPorDQn4uPXnM/OBJYI=; b=WX7sC8qcwiRvZ6Nv5IbvZvvUjALED1kzxU4lNVSgs2kDikvRoUcZDiUawwmelEda6D jFgVFEnyNvbDY1M09WGVp1oDTAjZzsvaRWZe5GBMYWG9PeZqLOm/RIfRQkpfFbKM/1NT FlNHUOjqfg8SbvF9A1DOk1gQWR+mSYT/cIOng1kZxkO4f9s88zsnjDU36POrpIv3eLZc W5etAuQJY/prUuNCI7QHu2L+nDpIcOVPf3ao2iGXfg8pT1hyPKn37jOkERkQc+1Nff8T s4Juulwj5YZpLBAVJdAinoaxjj9q/BOuu0ep02NZ41D+UYJYTxgCJUADIjN1C1bh38gs imiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307480; x=1707912280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yI0XGnXFUeGyPrdGimOqJnqeOPorDQn4uPXnM/OBJYI=; b=Icd0hmK6vJDSJWE+uaGX1HpOWtfznB2pnzz8aIdDDmx47iowjmEWhniJRbGx5o9dio xETj0WLLAdzH5jD3bklzfYSjtAVq1L6jcAPMV48jH8rzFN3UvOFN2K8PThbMvY8MN0V4 vZbrGTSLWdgMK+XlVNYlzqm4Wu5zJtNHnhwJKxJm0txmMUh6A6qpyizcUMdabBUaElp/ 6bR7HMc6/idjcKy3HN8aSiK7Zet1oZ6ninBCNMC0al2/z1q/5FXX1B15g4NXlN/u6jO2 NK88kjwXKgk8JYCljhy8LxFFgal0h3ld7giuYSmuYNJBT3klHbiLT5wQBMYVb9behprt qeDg== X-Gm-Message-State: AOJu0YzLoTbWZ6fUiXl4UNZrW0YUir/c8BjB3RBBYRHO3qVVv/6DUZyj k36W2Ejf91uhav66Jo/mhcMJYTu1C+w3h1Ye9CWa6JG90dHWX9nhi5BCaUB/vu8= X-Google-Smtp-Source: AGHT+IEzOauR1QCen0vBXFzjms6qTiywBdD82cqpw42ffLN+8RpFlsZOmAUT0myNuGQ3y729cTXgng== X-Received: by 2002:a05:600c:510b:b0:40e:b9fb:103 with SMTP id o11-20020a05600c510b00b0040eb9fb0103mr3758517wms.23.1707307480664; Wed, 07 Feb 2024 04:04:40 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX2clzqkIRwq5SydoLx7yLk3NTnY9gMjjVS6k9FBDzOZEbGVRvMfarAx1a8KKhon8gTb10h2OH6QQPEQM7g4sSKFuXNcwt+2hOHEDl5CU/iR7VTDaOHDuWgGID7WmcCIj8Hd+9zYVdyzUIbWJ7pJo3IcyRM5CK9zQbs/SGukOsf+g5sBVYWK2Uu2CY9QTeg4Qurq/PdPhEt6zWJgCJNH193tyQRgBJCYysbHG6yVCtwoebNtpgaGSXUrVO9OwHjv57oWQOgRrhBRKVWTYu7M+6a/KxxErrp38jI5ebkS1qba/+aIrIYsVXVAagO49Mat8NdJkIDUJu4FmioLV7UkaUZbyPxhrbJ+0Q9dxoEb1A1RVWcuGOdjFj5v2zdkeD5mA7yGQwtRIjJk+FLwTVWHgHzEoeA+PHNKf7YFNVG4HZDkW2s/Qfj+k2fMAQrJzTN2uTeTh3OjPqfdFkIjagOh7KHPyw+aD7jrh6f6YW2bKM7/CaPl7lxV2uoGApXdA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:40 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 04/17] spi: s3c64xx: explicitly include Date: Wed, 7 Feb 2024 12:04:18 +0000 Message-ID: <20240207120431.2766269-5-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040442_011878_5CBA8CA5 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses u32 and relies on an implicit inclusion of . It is good practice to directly include all headers used, it avoids implicit dependencies and spurious breakage if someone rearranges headers and causes the implicit include to vanish. Include the missing header. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b1564a447a6e..0a30d034e288 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -17,6 +17,7 @@ #include #include #include +#include #define MAX_SPI_PORTS 16 #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) From patchwork Wed Feb 7 12:04:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4141BC4828F for ; Wed, 7 Feb 2024 12:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=px0ypbO1skfuA6/20m5t7LaxR4ipzw/MSgbD3hzcjKc=; b=VM994YPiL6Lapt 4JQEuS1ALS9Kv3rXdj/w3kHfNn9LQmpUQUSNIbnk4Rzn1APXX99jKpoCg8DAF9o8ZLZNkoUhLMVc0 KJa9xQJ/YKvwYWE0yZLGySuMmzhtsDSC7ptRV3yzCm738bh52y6/62w+r3x0ilSQmidFK1EUawhjR 9aykqtnjcB8jNffeJCuFIgiVMNqN7IXZcB+XRp5WkN+jJvzy4HBk62c+Sa5LjzHVRSygpfMky2/zf Svxx4fuPkjWGJhx2Ze5BQCpXanudjpmAf52sXFruZvh6aUvPH2kfI0xw5VtaFVeL5mWuLLBlQiri7 6YP+GrDit/PrDaTp9bUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfo-0000000AZQ0-0d7m; Wed, 07 Feb 2024 12:05:04 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfU-0000000AZAA-2WPJ for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:45 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-5101cd91017so678456e87.2 for ; Wed, 07 Feb 2024 04:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307482; x=1707912282; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Bzl1XVd4VG7OC9yiL2j94dw6vCN8qDUED8GxJICOsA=; b=LfdL9sL4SDKQ//sDo4Q30tWz5poTcBrNyBL6Y0ITHbX8D7lD8ErW+NV5+by7nDdVuH nsw/l4tCD+klZimP7zva2MbiM3b1qrvXuabwcRYA0PZpCeuenDN2/236K1L5UjnTP/Sr 4Gr46g9v25dHkfg0uRbFAgBccpYujNi2OnAPXJ3rsFWUcGMiZlOAss3n6M/Vk/VWfWof 3CYRgTqyN3Tx+ZbC2S05XHu3piF//z9Y+jlF9iy7QQEZnZ4YTYSU6fvD1QXKYhzCO77y zge7IWaEfk3FSDGAqtG+S3Z1LcOvDn09I6Hi/EEs2dO9A+x0+2KbRisC9NrmOAkBHRA+ aGww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307482; x=1707912282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Bzl1XVd4VG7OC9yiL2j94dw6vCN8qDUED8GxJICOsA=; b=ixp8q+FtHrDtH5/87yombEVlSoF77ZfYvx5z+52Ss2FGNzZH2D/jHdLOcP6c0I116p 0TwxZ7mnKxBOrwCzCQLyUiIvr5L+YqDgvil1GVZPktIYfMdnW9Nvw0C8um4Or1Ro60Bl E7xCedR/qG668hJ3QG8G2RvltT8sRDaSyWsENWiJgxa/sSQmRi3LsA3BF7U1yEg96FJJ yd3uchn9Lejzr+02ZIzOPfpnDE2naosAXLXCTfQx6mhL6dA2ETXVhsBFvh8I2VirCKyl ftTWye5m985Qz6ZuIbqNPL7UsBrW0zdKA1sFG1VaTlq2iNq0HekxWgR0ngnZ8fJBp/pH eVIQ== X-Forwarded-Encrypted: i=1; AJvYcCW5BVrYiHUjmWzlsntvcY+CbuBRmVaprOQ5/uycVC4oh/Ej0EyJeENvufI7jrfschS6sNW5P1U50vdTF/eztQgItTbBhP8CGeXpoypL8FdYGnKyJjQ= X-Gm-Message-State: AOJu0Yw12PZGXFDL8W2yLeCihcJtIL/VJmfXfUpwpl5UeryNNaYxYnWS OK27ttxcKt/jottOxlbyUh6Ta37sfL61gtf+7c7knPp9PXxv88emYpebMEPRFAk= X-Google-Smtp-Source: AGHT+IGcck/xmUicyK/uSuRdySCd6lMKVJAEjrg4NVjjnDTt9057DOq1RhPNTzrfhuYWeIgmMq9WnA== X-Received: by 2002:a05:6512:31c7:b0:511:4e64:fe09 with SMTP id j7-20020a05651231c700b005114e64fe09mr4393588lfe.43.1707307481710; Wed, 07 Feb 2024 04:04:41 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUQv6Y3rp8ha8/1pYWIrhm+SSEwXtyTCHxObJ+7Ec7urGBGiCErba4U9qGVl0fQMRgdootm7T/BpCm8MPhq9X3a1QZ2sw4/eiosfzFJsXtPDeLqGwIPX2yskvLe2RtPMU7yi/h+PWaU7yVpqnIIyBwGnOgrEYlXe9De1jQ/vWs6raG/hjYtUeofYZ4BQ2pY9Ks3MwWtmU976uew+KP7gBsqzCk1DuXFUlo60/csbqywTZcB7vBeJ2s8YXn0g8nIfphWKpuqkkbiI4UlK7D/A2TJX1KgsnaFpnGue9dXTTrLTRGX0Rt5LeQ5p1MMX7mbttA81TfmAsq8neWBmTI09soUUih5hy/fZWx8xN3N6y2vbCXQZ9ZGCbi8sofdpmry0WflT+B6QLaw250aN0bLXZTGjzdu6uYboFTjuTH5GJFrZ0ZsBA/ScVlfzAJnNpF4r/OF6RoRgbpbchVl/u4syxaWTf2Z3MWkjAadY3Z+xUVwoFpcRsjgm+z9t5T+VQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:40 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 05/17] spi: s3c64xx: avoid possible negative array index Date: Wed, 7 Feb 2024 12:04:19 +0000 Message-ID: <20240207120431.2766269-6-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040444_670599_9799DA0B X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The platform id is used as an index into the fifo_lvl_mask array. Platforms can come with a negative device ID, PLATFORM_DEVID_NONE (-1), thus we risked a negative array index. Catch such cases and fail to probe. Reviewed-by: Sam Protsenko Reviewed-by: Peter Griffin Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 0a30d034e288..dfe78ddfa233 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1228,6 +1228,9 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) "Failed to get alias id\n"); sdd->port_id = ret; } else { + if (pdev->id < 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Negative platform ID is not allowed\n"); sdd->port_id = pdev->id; } From patchwork Wed Feb 7 12:04:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548387 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6A31C4828F for ; Wed, 7 Feb 2024 12:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GXU89aW7lH+Xjz6Jt8h5liRgpHuSbpwfCffFl282L40=; b=07GZZGXO2bsHyp EHlTrMDnN3CdRBD+NWiX14z40OhSOF94rXO5O41JYIXEkPLoyP2Qhs1tj0BGn8hO7J+aXGjm4ONhy BG0Ko69kGm4ssBBuvzC5327OUd+AZOHFRalI/cnBempQRdlYvZ0YBadaMONkuyuWKG4A8bXqFPnoJ f5v5SYbn6N+ZBEoukpW3tnASKzbBUHjQUycrnxF5XDxfu16eUDZQiib5Gl2IxPpNWY2Lm5HXgrrFR sYSo9yHwiukDV6RXhUrPeMROYeAtQXCR43POb55+rWYAF3d1Ayyr4TlfAlfG9IDqd14CJhzQoqfkP kNvRd2ACCOKSRK3fEH3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfp-0000000AZR7-2a1w; Wed, 07 Feb 2024 12:05:05 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfV-0000000AZAY-2RSe for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:47 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3394bec856fso968123f8f.0 for ; Wed, 07 Feb 2024 04:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307483; x=1707912283; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1q8cSxh6TrpypO1wLgThCm1+mYzOLff+IUVZOlpZ3vk=; b=v1Vvit+XGNoh0PrrDk4HqrP2sTmYUCBxAENrKkoKwzkDbLu9ZXrMz9GT94EsTabN6b Xs5hShdzmdmsJPFKh3qrqAilvqtNda+pyURGemfkii0teVJ7mgRy7QmYQxy3bKk8mO58 SuBPc+IKaDEAM2RFgPwCXPi6oKR8OmT2URpYTzrk89AFKUPzf31SHheKAaayr+5yFZtB nv62IqosCaOZwxle+fJ0PPrJFRSGlLFwR5p1BDVp/PuTWDUmH3jn4OQn6JdoCCChGefj 49QOE/OX2sDME7vFdJIGXDjOpWWIJ46KX3KSj+xgGgBa0rM8JDcUmrFHSY+SBzIHVusb gdOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307483; x=1707912283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1q8cSxh6TrpypO1wLgThCm1+mYzOLff+IUVZOlpZ3vk=; b=nggLgIR0kVDXW/F08uOacmK7bSsUB9kCMlw/sD+DR+CiYsgB27hyd8LUq3TG02VC2D HpDxdkLFbdyG8WDN5oUP2KWupfBhLlgJ9tYi1kdb9/CGC90q8TkU7WpO1kNrGD4ED7n/ hFDOhYCg1Evjf7hXXOyTEIBYITeHO8Lic4yAA8RAi/54fpN1vthhXxf5UKgvesamCss6 wqlnyEa8QVU2t01F95nw1hY22EauZr9XJCHQvKxbtN/3TmgMLhjvHG3NrW5C96051feS M3Kqu4PmnctlqTMRJ4JU6S7VIZrZiXMB9XNL9e8h9N3bmEW4rDacZ3yr1fxhFb5mFJO8 KXSA== X-Gm-Message-State: AOJu0YzG4sErx5G+1EBWSJtFyLu6WNK9vfmN9+mX0nZ38mtnyIgT9w6p wsLC4gG7YdsQA2eJC5Xf1U9fjmuFkoF/TKhStI1DYfwZHWjbPfNcSvIQ+BOhF+I= X-Google-Smtp-Source: AGHT+IFVobAsTSE3Uc/CG+Ky2imtFMA2qH3wf0hCDIYvSbPcVABLR9T6lhsZJei1D7b2E4AFsxdrCg== X-Received: by 2002:a5d:668d:0:b0:33a:e9d5:a760 with SMTP id l13-20020a5d668d000000b0033ae9d5a760mr2947738wru.14.1707307482943; Wed, 07 Feb 2024 04:04:42 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUjUIH2HOb3+v7DmYuHoRwUvrh09L89YHciI+ZCWSLcJmGofKMWoB6zUYAffjtzi9pOI0QqS9UZIF9xFutPY+taQ2lbl4joIY6ZHMQCdAlF0BDoCoVAM706ao++eRucDEUupgSNrUMI6UkAKvOVJplYfzDgXoWBgzfpm+DQ8/LdBAbHPbLXCJKFZ3Vxjdqij7KcjbDqM1MR7I/JqElof1ZQ7vGf4U7aKJpqrfCchA6HQZhyO1oj+u2cEOXMPu6Xi8WHikMTL7KTPCgaFsW/mc99t5wMdAl1s14PVGotT6iziI24ONeTqX9cXgzr1YK1cDn/2GJWYfYf68OykP9Q/jc4E0bP8KeA6CFLrNZ30o2uVMNgwL7WkgBDxW0IHYzNmUIs9azXACpoVVqlQ1Eh6v6yoaxDjmTxM6cLD0WgjowwCqWVV7pI1bKvn36GrEeQ80BJGaLvdOiIA4m5GmXt6qGrvE+ONXgNyaNhTqzMepfr0i9nLAOpEjnwGpcX/g== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:42 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 06/17] spi: s3c64xx: fix typo, s/configuartion/configuration Date: Wed, 7 Feb 2024 12:04:20 +0000 Message-ID: <20240207120431.2766269-7-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040445_665615_DECECEAA X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix typo, s/configuartion/configuration. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index dfe78ddfa233..93d0e55e1249 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -182,7 +182,7 @@ struct s3c64xx_spi_port_config { * @cur_speed: Current clock speed * @rx_dma: Local receive DMA data (e.g. chan and direction) * @tx_dma: Local transmit DMA data (e.g. chan and direction) - * @port_conf: Local SPI port configuartion data + * @port_conf: Local SPI port configuration data * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { From patchwork Wed Feb 7 12:04:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E236C4828D for ; Wed, 7 Feb 2024 12:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iZ9ZeO3yTtYHmb28BuiFTd8JTP7wkPD2hIGJl+rUQAM=; b=vTxJWibn5J3H06 CYQaTi9+ttkEZfPJVx5ZhU5zxi7w06+goJFC17s7ZtDQHa4nO3ZGBfZy9QQ99GbtvtEkyo7xxACIw jgvZ//twDtsQbAtlwz9trbD0RbfhR4Jrm5ZyGkyaMoYjCk9XfPCiEbOJ4P9rsoUtZ3Z1lIwZAVis1 5+NHDojKNJ85YfkwLd55Zs1CNL41OnGMJTMX9ACfbZJ0D0ggKThbXoVhN01LBRKQMIPZ4YIHIMXgn YAC1BQxkOSZifv5AQbJU1Zthp4wnLmWRUl1W7LTl9v0fGv/3TuUxILkZbqSyYdGHX3fngHqi4f7Qg Ev00g4e5A5n/TOrixrtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfq-0000000AZRp-3UnK; Wed, 07 Feb 2024 12:05:06 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfW-0000000AZAh-0gGm for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:47 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-33aeb088324so390948f8f.2 for ; Wed, 07 Feb 2024 04:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307484; x=1707912284; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zo986RUHJCgw8tyGE74Q2IatMWC+g/lf4ayZlSvDSkw=; b=vnr6lnRXvNAnDALyBgWVjxqaiW6l2EPaUrM6jVDdMarwWRLRr2RIlYmp7tsHp5RK8r 0EPCgygjY/Did/mjK/uohnliQ2cEsFQQEegh3m3YQjlvurvK1rCklLZqWK/UT5XMLocm L11TcYRzDbBgBkoC09vpnSzkpQMbqGI3LTlsvKyXGv+5OSHnFbevbmgbqXnkCj42Mb7h V9sqDw9kAe+c3DsHhnL+bkfJvu53fOs0Bbk+qkiMDF+S8hkt8w+IAXMB8qlsiNJ6m6Gp RUWQXKUA8BQ3GRKHcvUWQlPMc/GtPdPAqPhdeOuqykqcI4Nh/nuxa8BIJaZcwZ5LRM9u KCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307484; x=1707912284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zo986RUHJCgw8tyGE74Q2IatMWC+g/lf4ayZlSvDSkw=; b=f1anY0yF+Pi0hH6WLV9KXN/G6s+TweoaNID8P+zPLKHD48q2SN28utjwDA/tUhAeYp LirOOkhzGGB30+o/vL3U8yo3mn/oO+5u8QfaNLr5fXBxYOUiQ2uhBt0d2JF0qGWGENSR QCOoeEIHgdP0ELYvjdt7YgVQvStBClQNIR+/2Bvl0Sq4DpvJnW1jk/u6ex+1Mq9ANMqs 6fywkZqUXCJCIwRUEjfh6SRskfJJTqNIjQWSiuw/HsOdwE7cP8kC1EDLKyA9y8HU3O+5 gINZC5S+HLaSVD9Ri8c+4o9gH05KXuqlTW5YO5Fm9aseScUmwovrW3r1FslwWPwSgB8o TZBQ== X-Gm-Message-State: AOJu0YwhT9XZvd2vhmbIv1XC6+9n0Qap7kmixueZK49gPlCaMGBMbyGy EeYsVrRh0rGH4Kmvn7OgECqWcYOARmTntXB8xjScH28R0UMqodupqFlWthc/TlA= X-Google-Smtp-Source: AGHT+IGWSum8JjV4ymxYiYXXEAM7kyACzbsi6K6VdwjjNADXGPscXXjdSHj+++738Z8/fcUVjpYPgA== X-Received: by 2002:adf:ea85:0:b0:33b:525a:8e11 with SMTP id s5-20020adfea85000000b0033b525a8e11mr130793wrm.5.1707307483927; Wed, 07 Feb 2024 04:04:43 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV9QS2v6p0kI4fnIqq9lhLW9G9N37bMjCl+FN9zcjTiKvKr9xC1kZOr24JeZVOt+8dloUI7MyxZa0M1CKuZLHj/o3/ZzYP1yEoRlbwXUZ0tV8Kzaf+mWVhbIaOV2V4MoLHNSM4bNa9vC4v4nhEF4RfpYrFpPJFMljwPi/uFIrQ54Gx1GJIiovTyOMp2F83PA6myulA7+gxulYdvscrd40y/bZbno+UMBIWFoMECoRJMuP37h1Z5XwDuejjiBNqsvCGPQX29xEwOIsxSBYuEOC8MAFGSSZFZV089G2oWelE3q6c6gxSFLIi2pxitiDnU+fCTxbBYFPtiLESIaaStNnm8WjZ0HlcZsS+Wc97kglcwv04vSR5X3gV8cKGaExSa9lI9zM6N7naWum9ufYVqNGcQPjp+o2s7uENXPgLs9aPUiVAXqV8daCAadneyMCI4uikqX0Tz5b48evSDNnuuQdLJOwo/PqBknRjvF3bR/tO2Y8HiN0UohR7fkVEI7A== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:43 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 07/17] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Date: Wed, 7 Feb 2024 12:04:21 +0000 Message-ID: <20240207120431.2766269-8-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040446_310721_9F9C6D2F X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_device_id::data is an opaque pointer. No explicit cast is needed. Remove unneeded (void *) casts in of_match_table. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 93d0e55e1249..e3e7d625f3fe 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1568,31 +1568,31 @@ static const struct of_device_id s3c64xx_spi_dt_match[] = { .data = &gs101_spi_port_config, }, { .compatible = "samsung,s3c2443-spi", - .data = (void *)&s3c2443_spi_port_config, + .data = &s3c2443_spi_port_config, }, { .compatible = "samsung,s3c6410-spi", - .data = (void *)&s3c6410_spi_port_config, + .data = &s3c6410_spi_port_config, }, { .compatible = "samsung,s5pv210-spi", - .data = (void *)&s5pv210_spi_port_config, + .data = &s5pv210_spi_port_config, }, { .compatible = "samsung,exynos4210-spi", - .data = (void *)&exynos4_spi_port_config, + .data = &exynos4_spi_port_config, }, { .compatible = "samsung,exynos7-spi", - .data = (void *)&exynos7_spi_port_config, + .data = &exynos7_spi_port_config, }, { .compatible = "samsung,exynos5433-spi", - .data = (void *)&exynos5433_spi_port_config, + .data = &exynos5433_spi_port_config, }, { .compatible = "samsung,exynos850-spi", - .data = (void *)&exynos850_spi_port_config, + .data = &exynos850_spi_port_config, }, { .compatible = "samsung,exynosautov9-spi", - .data = (void *)&exynosautov9_spi_port_config, + .data = &exynosautov9_spi_port_config, }, { .compatible = "tesla,fsd-spi", - .data = (void *)&fsd_spi_port_config, + .data = &fsd_spi_port_config, }, { }, }; From patchwork Wed Feb 7 12:04:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548388 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22D2AC4829A for ; Wed, 7 Feb 2024 12:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YkwrYy/BG0phdN4v49VBbgT9p9UWLFoWp7F6OOL47Zc=; b=hgPGMBNm9hNxOc XlQkffAzDbp42ytrugcPrx0Folo9LZAVpM8coxZ9+tXkGTq/jfHGUIsHMO9Mt+PC4qoGPtxLJ34aq Iix/NQ465Larh69tEpD9NQ56Ndyyr8Vs9XNlARYNnZMXUeFBOD+RoLsP0j9WxZ5E9Z70Be08o8QBA F79t7+nIrEdciqPdowXQG0DIUwRX5lIrJD/RysHeW053xYBv56ULLtwNTeSVt9JXJMzJSamyXY1Cd gNm7LvtU0t5eajR+aqqdJiZP596M+I4s90T9Rve5L+bSSaKoj7GJYqKtSOPb+gDVy5H6b47ARBGDC S1+1u6otBK0w9S2xxi8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfs-0000000AZSz-1ssG; Wed, 07 Feb 2024 12:05:08 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfW-0000000AZB8-33Xz for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:48 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33b189ae5e8so359736f8f.2 for ; Wed, 07 Feb 2024 04:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307485; x=1707912285; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=mt70LZX8uwzVB91L5u+dboZgVubNAp8oRfbWjRjz5k0V4mnwuld5kKJGKR98owxpN0 bhfQEC/7caMpTQ+Kz+PEw3eIZJevIVshoZQbvlRUYB5fk7ZDPFfJXSK9gj1yIyCDGlvx QV4SVmKrUMxhBpiflKglO/B7HzaiPBnPO9avFbTs8JCffUQs28nkyzKlC6grUiGMGx83 Mn+dP3VESvPwPJWFFjnOiVMkpetP8ZbKvlgXp4cwVWIF6UJ6q7JQW22umCt8JIYXutFn oQn9khFfAEO11YQ1XYO9qjVeFnouWYMoMZhbFzjKoAyPKgRCufyg+Hp42A4DEPtc6DFZ 8CZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307485; x=1707912285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FVi6POW2wsm4t/zvRlXFF0rH5aMJzAofhX+zIRsv7I8=; b=JQprjRu1PnQfpELv+hyvJOxQFNfRIQt1H486qjMsfnCLLGcgE1Jt/QfC686PQf/uJm AJAcPCC8KiR0WyDlKaiplMk21rS5SWqH39UiNKEf3oLod/tGw2AKDadbQwLePTQoH3XK GrTijw/Q5gEGeuLuOb6zM8kejFZc5sK5J9bVMzdi9CXvDH47oqSnFfgdlNn5+QCmQ7Qd VVPjnRJerJRWWHsNXrJhjxslhvVTQEWpS21rGlkzw5Y7B7cjirScd0uNLmbZTJMx3j5o ttWdDUwpEzMdhIQ1jnG1Wfuy4p5F5iZPQpt1HYIhoDwh3Qe/K+v8ZqhtdVFwMMOgLv9c FdGQ== X-Gm-Message-State: AOJu0Yzsw81fzqH1qVSbk+e4VVtsEFr3yKsK7nZalQQwCobul2s8xK+4 oSqO6nULzICC9zBhA6RfnV8NsmXtxXdTPJS+5QUSPXgfYoHBQaRgkDs32/6IpkA= X-Google-Smtp-Source: AGHT+IEiKXZUvH731o7GliloWXlxKgtG4B9CbYUf5uY0sP6JI94NUhDGFRu1cbzz0NaYABDxc/IaVA== X-Received: by 2002:a5d:4607:0:b0:33b:470b:a377 with SMTP id t7-20020a5d4607000000b0033b470ba377mr3299506wrq.14.1707307485006; Wed, 07 Feb 2024 04:04:45 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXi65c/JIRFTcB5no6O1BT/UfOn7r6G5SsTR4Z1TpJ0xLXYSEO2dQ8pmguXkT9/GofcRmzGYPdz0fLqHy9WI4a9XJLu3ZnH2Y9FhQi4PDPTefydw/FXp0JQtGr82udzshBWEwHTq/ukZqEGmTgQDxXgZKKcMQz4293qjEAvXeXRXEjw+2LJFJFzkMCAjUPIy2EwFnSSn1Rcf3TD4M9DSGgPluoqPt7AOM3bC8R3yqBTqe257ajA3dLN+Nb9xI1RvZ3e8jl5a0QbUHAU/4cqLTRo9wqmHEMMeE+sp293eRNHt+Pb26Q9/k8suUDvadfCyMwnnfIlezqEhf5mn+b0C9ciQO/h6jcD6zZICEw8NhICH3JYbAJvPF2oW3veyX2zvgE2xfCgHAsF58hu8iAECJH5ek3RQOAwpxUnoez02e0fHyx6RJVrC5Ol2XZ5DCo6HWiI/P7Q+Y7q+ObowYJyZv0UtKdvVf1kNWBr9zFS+g9ndwPxU+PgHm2AjDBBYQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:44 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 08/17] spi: s3c64xx: remove else after return Date: Wed, 7 Feb 2024 12:04:22 +0000 Message-ID: <20240207120431.2766269-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040446_810712_D0844DB7 X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Else case is not needed after a return, remove it. Reviewed-by: Andi Shyti Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index e3e7d625f3fe..0b42d28d2019 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -410,12 +410,10 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host, { struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); - if (sdd->rx_dma.ch && sdd->tx_dma.ch) { + if (sdd->rx_dma.ch && sdd->tx_dma.ch) return xfer->len > FIFO_DEPTH(sdd); - } else { - return false; - } + return false; } static void s3c64xx_iowrite8_32_rep(volatile void __iomem *addr, From patchwork Wed Feb 7 12:04:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548389 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D1BC4828D for ; Wed, 7 Feb 2024 12:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SAlzUCI7v4F8/erkgA0BeHTflsoMMJ5M1Uv07ONwbOQ=; b=wiDSAqJsvhM0Vc E6s3eXH7Ar8ItDkhuvS8S5itJcAHP+l8vTQ7ovgxZH4u50gE4J3m5SRWLHORL3R7D6LcXQ9a6SZGm S8PbEKrMVsAB00j87JYlWB6KmX3Lyf9qOevWfaagm03rncWUcm/8CgcTH4wjSduH89sfT8XPT4rSN shw3HPnJQrEqjv/I3m36o+n1dcFnlTY6xQll9Mc89XwLCF84nPvxf+a4henUF2gZt5ApSds2gaqRY mKFPdOK2AxdW1M+Gd6tqchgYdDueC5GZIB1v92UU6gbzONRztIJjFqf+lFRhP/lxvVgL5F7zMVdcB V85IxLcSLPgycwAC8TPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfu-0000000AZUC-0HW2; Wed, 07 Feb 2024 12:05:10 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfX-0000000AZCE-3hXH for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:49 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4101eb5a115so1123665e9.1 for ; Wed, 07 Feb 2024 04:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307486; x=1707912286; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AmZwPJi4/crk/e7JVHaewrMAfpkKxE489+JbcSaSVHE=; b=M7eSUZscq6MoTHkozZ2W79BxoYVC/PVGlfo/OrosXWHntkCQE7qGqBhuRtNsrUn78y JJ96Mw7L1DGo6LTuYdcUfH/2gsTckTRQoPy0OEOOb83c1+qVQox8KeHQJSTe91RM67rI p3t0y9EEPxBGj2tSNde0pYVlF0k2BJT0Aq7u3fusRBDsnHlYIDrWhQISBZD99NbE3k+7 nCev//ELtT2kZCeGvbNEMhdoRKgKGVVO1fmvMwLwjH7d80c/7wim2i+PUEZgsnF83M4m 3sjqWk9Dt4oiZ7XyC3cyvM2wVn2pqa5KCyBJS5Bjmc6ENDBONaK0vrvx5/wBhO0893Dl 8UhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307486; x=1707912286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AmZwPJi4/crk/e7JVHaewrMAfpkKxE489+JbcSaSVHE=; b=gfIbUJHv1b8Ji2XbHdJenXxCjF8h07/gRwIxnCS89383FKH2yIMhtJ0HDgT9XLQKsL j0S7haWHDforRTnrbTZF7J2vGLHGDWkGjMaG/CVqwO8bucX8nELzIB9V3wYZkQ7MZEA7 MPkz0/2VMy3P4StBA0IGFwLylz3RaIRuzCBsmr57la7au21gtHvD7YhPj3FPWk0f4qaN qjid1/APPM0xPnhbOiY0SHTRchN3tYUIegWAHCmT0UBiRNXkdjcCXro72FQINgvPTcQq fiFcrFixoQrn+Lv2BqasKc9B5PCP+q+nMsDXMXmj6W/UuCXZsTIqACu4Ju6tOp47o6qX Pj6w== X-Gm-Message-State: AOJu0Yw8O2PGlByoT0F3e0w8KSSE4L6KNNgpgo5XMA9KnZmctGt5hF2L RpLLn068z8nfgPB5+k6gYsVoHBaiVRzsJGgUX3boWFskk7OZhrVuat19tQKcLVldzwWuyu1oYM/ Pd/U= X-Google-Smtp-Source: AGHT+IHmmMpg7y1ljPpAMnyZ14o8FS7S/PH5KbVyCVDh5pUlgHetiQ6wRGO7fPXOnM8iUIbbDdGRFw== X-Received: by 2002:a5d:42cc:0:b0:33b:2fba:1ea8 with SMTP id t12-20020a5d42cc000000b0033b2fba1ea8mr3192011wrr.52.1707307486148; Wed, 07 Feb 2024 04:04:46 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVK4JPDc4iDMmGLIARBd4DhgeTGua/l6VbPFhSXw0UCakv/hGsahC4rjyeLrlUE1mLdXcbtM/+chMVezRIIXgxMl62fbmh9orhyACFJvEW25SZwyXuWDqbAmCNhAX2748XWiAkaVvdhH9DaHXDNvgG3ik6hEhlohBdQPJrCGmtC8pnEpH9AnH/b8ZgXhQjk41sThzoiUnjHEaPJA1pkh8/XGlJ7R3wWyfvugWeCgsA/rC9VONkWqcSEE/2C2HcBFfF/xRDy8P4pWXppH1pZ8GGKWPWpwM9trNTw/NGY6mHDFRaK4ne2a4F9b51Tj3FR88dYbmwVsu7x4QToJrKl+vGfsNK+zj9EgF9yjgIH/CH/SMz9IsqdUOpjQjD17fHWJpFkxlL24fj6RNpcaNc732qYzK0TPYGcCMMSdDDW5y9N9C9SQgNmyTuKH6sF8khgyB0xhKDi17at+bga1nNJ+Gg2vIT2fEUhO7og7b9BAT79VWcUfrGP2A7ezidzzQ== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:45 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 09/17] spi: s3c64xx: move common code outside if else Date: Wed, 7 Feb 2024 12:04:23 +0000 Message-ID: <20240207120431.2766269-10-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040447_970111_74C5C648 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move common code outside if else to avoid code duplication. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 0b42d28d2019..4ce6cb3b43f6 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -294,20 +294,18 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, if (dma->direction == DMA_DEV_TO_MEM) { sdd = container_of((void *)dma, struct s3c64xx_spi_driver_data, rx_dma); - config.direction = dma->direction; config.src_addr = sdd->sfr_start + S3C64XX_SPI_RX_DATA; config.src_addr_width = sdd->cur_bpw / 8; config.src_maxburst = 1; - dmaengine_slave_config(dma->ch, &config); } else { sdd = container_of((void *)dma, struct s3c64xx_spi_driver_data, tx_dma); - config.direction = dma->direction; config.dst_addr = sdd->sfr_start + S3C64XX_SPI_TX_DATA; config.dst_addr_width = sdd->cur_bpw / 8; config.dst_maxburst = 1; - dmaengine_slave_config(dma->ch, &config); } + config.direction = dma->direction; + dmaengine_slave_config(dma->ch, &config); desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); From patchwork Wed Feb 7 12:04:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7DD4C4828F for ; Wed, 7 Feb 2024 12:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=20SedW2tKQN7c080tXq6DznkbBu4fOzV10TrBbqwz0Y=; b=nTIvKJFRMUpTPa T9Fzw8hSFFR8zKxZXIuSjKuFJlgdb7YwyPQHAWR84srpLtbAdpq3X+EzMc2EfvIT6GD0+733m+T01 qFJSQW5CYEJ55T2wax2Gj/yk8Q25wW7BaVxaLI9CJ6SQ6zOYmPwBXeIB3e9GfL0hKTBlUU/C3ilO0 fSsrmZ8jAuYNeEBRafsBcEo3ut9duLqKXBOZU2mnQuTwMC1IbyFKIc4bBHJq3R5+DXaYSz6Hgkd+7 AkIMjgGHkf6mzbcb4Pi9ld+E4XqPbmqdzjb/QRoR81B+92NmVns8oc1O0Zy6hZkYBHnPwL6S9KnsB 7A0usdq8rdfVoGlSY8Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfv-0000000AZVP-2hdg; Wed, 07 Feb 2024 12:05:11 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfZ-0000000AZD9-0DWa for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:50 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-33aeb088324so390989f8f.2 for ; Wed, 07 Feb 2024 04:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307487; x=1707912287; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYOYbNjp8q3KZ9J1S3sEcmw6gmM/Szj8HuSkdRWXI4k=; b=HoHkkEYM7czZ1gv9JtWfDCvPlBw0nduYPYpLywWuCOwMC18dqg0gc56QlnuXH5WzEG tLdsp2IOL3Vhp63ngOf/OiLM1GnE79S6BGOhQRsMKpX7wmV67PmxqBlS/9uidSiyVoXD 9cktrTKteHIBi61K37yzW5IBe0vxJTsbPeBKDKWG/YEhUAPbOy7e5APIu8xBdmF4ebG8 gkO6AzyR9uZeRsZyhDpHFoz1I+uWrb3riBVerXiqBX+XgQTuQWH+cVi91otnTkwgLD+a lFO4YH917NH6MdcVhsNaNaaztMmYN2dMMDBKLCXkc729CXRmg7ZYWJMlHWq6CXFxg9rz mzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307487; x=1707912287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WYOYbNjp8q3KZ9J1S3sEcmw6gmM/Szj8HuSkdRWXI4k=; b=UtcfWPMX74UYJQu8SjzApklLcLBvi+mob2rl+jCKXUDXAR2/83QcgaGLbOZ15zaG0n t7ftSq10B46rJVBdCz80BHPTDojd/2TscSEIt7BMY4vTcY/4UFKJtoZK/vUzMRQUkil0 lQo8T2Wn+lX6/btI7lVvnowuTOtbc6Ca/Sz05a+nz9kEjXMCTYHpMo5S4lJHVunfnPU8 Tc1ccPx9UDDUturrXjNrtmS+SH8RURsLwebqfbYU0r4rz6ZuirnlY58+5EcMtJ/2X5xX RsqV5uCX7YBn21kui7MVN+DyCfBFq9ilSls3ULTlwAs/U221dvLGmv7YobX0zNtdhVh8 5Qjg== X-Gm-Message-State: AOJu0YwbnHThh21KcHkKa9WF6O0wXJCVJIRQcOj+K/I+2GwOv2T4n7aV T2/DYicSRUpHe0vys2CyZwI+WBpIcPwBTpXUmBn+DTx7mY030axsFSqqUGR09Tw= X-Google-Smtp-Source: AGHT+IHZddiwCD4E4fn4x0Ro9O6jst0BaUSZMFu9cJdM1Z4p21wwP8+SqVAjqMHPluqWfYL1ZsQ+pw== X-Received: by 2002:adf:e80a:0:b0:33b:10f6:151c with SMTP id o10-20020adfe80a000000b0033b10f6151cmr3549908wrm.53.1707307487237; Wed, 07 Feb 2024 04:04:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWtMozbSsRdSCEaMFMJZbFv9kuZr/hjz6zmp7GQ6L59dxFOzKCW8fwDm72xAABI7DneH2cyu5SCP8KdpzK7MmnD+C2LU9gIBj/b30sBsVUi35Mhhop51et2L6wzoyc9PsRyssPwwT2tWMe0jmMTA4WLGA0UGXuUK8YWr5U0O9cs3XwxCeoB1iWT/PdGaoju1pXkvQQDYrSQZb9132pT53pPbSeFnr3TNLdXBg+wUqgpPS5d422XU1cASprBkpP3mon6KuSs2TwqBbgXp05nG/BdHbQMuYJB3ClWthJ4xXE3sT0nYdUoN58Za5EJ2CRYBC7ABA+HQaGFCI7LYgtwRC9+t7thRx9+lYCeHef25wzQvInOf5lDECH3Mbzj9LlcT6nKgvnByzPdJMFQI9JBCo42f/XZuWzvcF/FTnWducUf7RjQkUpPXupwOKOMlKStpGULv2z/UEM3bvyZsghrkal9aJVmIl9s9mpsgvcim+95ZpFBQExi8Ouvt20VpA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:46 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 10/17] spi: s3c64xx: check return code of dmaengine_slave_config() Date: Wed, 7 Feb 2024 12:04:24 +0000 Message-ID: <20240207120431.2766269-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040449_190862_DC45AD4F X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Check the return code of dmaengine_slave_config(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 4ce6cb3b43f6..1f7356f6e5d2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -305,7 +305,9 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, config.dst_maxburst = 1; } config.direction = dma->direction; - dmaengine_slave_config(dma->ch, &config); + ret = dmaengine_slave_config(dma->ch, &config); + if (ret) + return ret; desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, dma->direction, DMA_PREP_INTERRUPT); From patchwork Wed Feb 7 12:04:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B58F9C4829A for ; Wed, 7 Feb 2024 12:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xu0HDdlU8HvywPQFqg5Ls7UBJKZk08fEf5QZb/uQvvQ=; b=dTS5qCPta/nPhi 9dldxpqt6CWM1OwewY0uThwf/JdBBOYpp3bQ0gR+e4WQjIE4Joz6/TLk6y9FL1tvcUY+BqIRw4jxl f3ElJr87PSIF8MyYAflpEF9pVn3E2iL9cAdmrnXy6evPp5hBNdvyN+FCPRLl2wTnkSNYajNw6P2hQ hr+ULdcDT5FOu+KqIcwt1NGQwK2b4INFBDCx85KYBK7Z2L8PSV35UIbIWC5rxGnTPZuwY2GT6pzeH M02Ltzvcs3A01o1RwAp1HwR5K+6MxdPuIu6DfebqzAH6m9YUC3uRctDyLCPfclZEGZ+N5/7IXog2O sH/zevVJUjM3WVNEoQGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfy-0000000AZXc-1sE5; Wed, 07 Feb 2024 12:05:14 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfa-0000000AZEU-3Js3 for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:52 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-33b4db36eb1so411415f8f.0 for ; Wed, 07 Feb 2024 04:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307489; x=1707912289; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=fIYF6D2/yGBxZlcxHNImDT1ngv/AFrQC8ETg1eE9A6uAOxbbaH+7elv1smu1vVqyOr JpmqQxqUMWHs+WJc6WgslrjNyB2cpZy2IucWx+umqzDJs7LURRlsNR0uqbVnY+8W3ToF OMV8ydlYrxZL/QwnwOHVGF9Sq8pedE3lcSR8PxmH36zWcreIeMiD/VheNFQufYlBJel+ 21gE/m4idZ8YH3yn4eFo372soJp6V1j46Ea/L+EVzZKOA0keCsa65xuX5KSq2dDbNUwO HWRujVaV7HTnUhj3K80wB13o37VrXFQhmJOY2SjQK8PvwJCCm0oDnhJFvD+dWoyZUYt0 siUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307489; x=1707912289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QyB/rIEWzg0qFsjqRP7XGwF0lM74d/iwYjphW748AMs=; b=jlSlo159qSH/3l1JJ0ezV9LrCZl64JYU4MNxeHNqaOqt9xp461htL2c9gzIS/lqjVP QvTkJzylJLbnuTUmdMaSVrGlDnqhrkjkRJhb/nK4bdIc4JoPHfosThGPhnhB17BWZmet czvTkypB7Bl7nH+JFinCsLNzWbdMY5zvVPvjAzmp5lTXvXw4+56G+mZwrdCcZ2djFvTS T9JZemYhR2mwI0m9WVH6pQpUoV3DJEjfPVpSREXOea1r6LXY4AjVMvSuoROR7nHb7FW/ FYp45ID+5MMWzYkPQDpedmlmRU5ztxW4xd7z5kJw2NCBp5H9osnhtigjfXyUS/LyJT4u /fWA== X-Forwarded-Encrypted: i=1; AJvYcCWkklh2pE55schd+nzwfhhWQ6p0q2LBinZFJGd7nVtkJ+c8ROMrYcOAhH5EMn9r5L5U/g5aoJGZPQjb5ed59HvBpDDG8br54k7FVIGBuqQgx5Qkm58= X-Gm-Message-State: AOJu0YxPBaPdbD/81RpWvHQmCjgBJKhR0KVfmAktIAPYudIiOrqNdDE4 jL/WFPy29pRIkddZ8xPZrV2rAwNABBLwAHZk+JQh2E9Wu2GsRGMnCckVLlwMz1A= X-Google-Smtp-Source: AGHT+IHLdYTOpuM6YVl5VQ8KSmozpR6YZJf1vCyR7Jm7pldciiKf3Zxcsp8BxcHt6HVkzpmmahJfLA== X-Received: by 2002:a5d:6989:0:b0:33b:1ae4:10be with SMTP id g9-20020a5d6989000000b0033b1ae410bemr3112553wru.46.1707307488917; Wed, 07 Feb 2024 04:04:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWPoi9waljrhcc9Du9f7ChdJiFb7bX6DdMzhB6TZiVx1S6gG/nPe729BwNqPKcVyZuuPdA0jWoPjSZwBlPwgoGv4/+7VcutaOWWT7HZ/3E8KzjuD0LOtpjL0KJJBvdcnNnl7DjKH9MgkFM+oOQxMagBpYbUSNp+A0jDqH8NN2oxDXjkv9Czp7X62NXW5WDOIraHpUkXlQrhFTumVMhvNi2/fuvQOmrhzuwXTN5b0Xg+BD8zux/iMilXXTbwuTHqAP03e4h0gtwf0TXw8YZnH5aDaUAcLltEVIOw3dI8iuambt30B7iLPUkTQcl5whcPC6+OBnzA0glExTxAon0OgcvfTnCNygZplHw+HOEJkdkfLPNEFmao4a8VIZQiPLVaARwFsy4ppTJHvaD9+xssFBf4zYZUcC60X4vqjIWfKWGON6SA6CBFPOQg56CTSps8XueWb71vVnuDitaohl0PNzBRtFUQfoQZtyrmFl5+hfaKawwtkHi2Hh19s739xw== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:47 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 11/17] spi: s3c64xx: propagate the dma_submit_error() error code Date: Wed, 7 Feb 2024 12:04:25 +0000 Message-ID: <20240207120431.2766269-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040451_036537_E813AED7 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DMA submit should just add the dma descriptor to a queue, without firing it. EIO is misleading and hides what happens in DMA. Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1f7356f6e5d2..ba17c5a04eef 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -324,7 +324,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch); From patchwork Wed Feb 7 12:04:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BB8CC4828F for ; Wed, 7 Feb 2024 12:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P7kD2Hpoqt3qJFJ1koYRdSYoQAqqQhNiaOkXTHH0O8w=; b=TFXBxBs2Qsr7Ms oEhyUETqT7/3tGJm0VXj8I3EcY5ff1gcAiEZdaOBj4yH23mv/I1RDXqujPX2bPmaa30+8GycsQhso Xy63+qoiQND/eWEOkvXOEyMjMxOD3lmnaTuF531K5L5AZOge89zuyGh2ucx6Z3pPUnAnIomiI1g00 vwYdVCznTu6lOtqrE0ABxprdjIiV3Irk5YjV4otl7zovSN7GQomzGeXx7g8G4yl0S5kWJ4qSp/a2G l9AoovTsK6hfv4JzLD7aQQEJ/KyalAW4l4vHG+YWbVVYOzDdSX3GO/xI8h0Nw+V/mT5dK+8pR+sDX fo9PEucwhFABvO9XtJiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgg1-0000000AZan-3JIa; Wed, 07 Feb 2024 12:05:17 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfb-0000000AZFK-14ZY for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:53 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-33b0ecb1965so420274f8f.1 for ; Wed, 07 Feb 2024 04:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307490; x=1707912290; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=txkWFjXph9hZknSg86bxlVXLA+ATzTdcjT+xz3ha6R8=; b=VSmB5DrbAHcPZkhl+H9/Bv6gah8bwvXqcPRLU0Y59bBt8CV1ta5ANcIVBq9edx18bn YRD0vI8Ti3mDenPIuLhzsGrcKz7WaRdLTVDPYu8BBmZrAzgtMRxU3MNr+MXp9hl3ynZS hgqT2vB4Mm527ZS6N2wyJWfM4eCwKdISF6eaTF994To62DJC5TyPCFuSmtlmZ50vgW3T CW9mQsV9/cysbNaxyRBHg+bOFtUkKvSX86mdLPJqONJ3jfN02D2ksO2ttLSx9QWBh5fS jqBMCN8hTo81blZKwYasbRSGgfDTN+/Q7Z2yj62e+mzvx+1Phi+WuEiwMbYmHxljt5L/ UZKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307490; x=1707912290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txkWFjXph9hZknSg86bxlVXLA+ATzTdcjT+xz3ha6R8=; b=XOG6wRY4ero/GK2kOBDe6MsjeUqdpZVUdMSypaQXyD1TdAwYm2oe5KpqY58vWH5S65 u95oQnJFC4oqagTQ4aIee5iBJyJz8+djl+zJGTLN13VeNSqDtID+5Q5x4fisXSHNSqSY TrT8LE0GW1NE95F8U+VBuMJRHfj6H4vsS1VUPUrxKanlKJscvTHvnvgDjUAno1eKUISF KmHmYJkPbNLMdRUQbBV+zWWlIA5xtg63pDlyE6Ap8JYuCRY6SJU0ko5FSprTRiXgpRod lKjAw3toAEQSGC+mbAkGXMlvHPrXoSkWGT6Rd5l4jttzgE8G1RGr3UJuhKpYRAWdT1AY QpQA== X-Gm-Message-State: AOJu0YyTFp9nh91cv0mo2d6CoKvkmCln8lQRbsRNvW3dSk1KMP88275H 4g2FzGhkbVI4ptuDCe3Z2YcxgApoxJwz1vHc0a4JBaI3R4U9lN/83npI0AT81co= X-Google-Smtp-Source: AGHT+IFeTN6wfhaVpSblA8kzgrtFG9R6BE/gQX+sizE+n5nfcFk6BEFcG9gAge0rSlWZksqj6bg/EQ== X-Received: by 2002:a5d:64eb:0:b0:33b:48f5:b5c7 with SMTP id g11-20020a5d64eb000000b0033b48f5b5c7mr4711508wri.11.1707307489970; Wed, 07 Feb 2024 04:04:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW0S+0NvDpeYaqtK0kX4HKNTyeuKIoCbhT9JX2zrhoZtTAFLxzrio96HJOnqS/xPkTRnyrxxlaximNFjgK0d5eoLo/TAsq6pAG7RPkopLgXTje2TNr5s0Qw9K/1iblYAJT/Nvul/kMncvzBRAeefTXyGaFlIUO5dopvRxyBlxo5pgvA6JsaD8NxCdiBmhy8xvaNRnXyTG5Dcrw1iavjn2VLscWZyMN7rqJ9Vv6aT4vh5WW6kSGU2Ts3zR/ECU8/6/q93PRn3jfUWHTSJm71953zzYld/METrS5ApsxPuxK9cxWLP73dzADRtRj0mn39jBRG6B7q7NUVouU0KHPok7gYmFZL+9urqZ9yJDk13hMoqMJWowfTiiywP1o9m595/rLEHzbOPvZG82mkUt0JzdAyKicjJW4WJimVp6IyU1qTIDAj8UHkD37w1C89HdLmYMuL0L36Ik68Pp+7F3dp2h0HL6tGPs9Nt9J97KDtlMOg4kgcS3IRUFKXRm769Q== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:49 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 12/17] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Date: Wed, 7 Feb 2024 12:04:26 +0000 Message-ID: <20240207120431.2766269-13-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040451_516501_1572A082 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Don't monopolize the name. Prepend the driver prefix to the function name. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ba17c5a04eef..4cafec877931 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -281,8 +281,8 @@ static void s3c64xx_spi_dmacb(void *data) spin_unlock_irqrestore(&sdd->lock, flags); } -static int prepare_dma(struct s3c64xx_spi_dma_data *dma, - struct sg_table *sgt) +static int s3c64xx_prepare_dma(struct s3c64xx_spi_dma_data *dma, + struct sg_table *sgt) { struct s3c64xx_spi_driver_data *sdd; struct dma_slave_config config; @@ -497,7 +497,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd, chcfg |= S3C64XX_SPI_CH_TXCH_ON; if (dma_mode) { modecfg |= S3C64XX_SPI_MODE_TXDMA_ON; - ret = prepare_dma(&sdd->tx_dma, &xfer->tx_sg); + ret = s3c64xx_prepare_dma(&sdd->tx_dma, &xfer->tx_sg); } else { s3c64xx_iowrite_rep(sdd, xfer); } @@ -516,7 +516,7 @@ static int s3c64xx_enable_datapath(struct s3c64xx_spi_driver_data *sdd, writel(((xfer->len * 8 / sdd->cur_bpw) & 0xffff) | S3C64XX_SPI_PACKET_CNT_EN, regs + S3C64XX_SPI_PACKET_CNT); - ret = prepare_dma(&sdd->rx_dma, &xfer->rx_sg); + ret = s3c64xx_prepare_dma(&sdd->rx_dma, &xfer->rx_sg); } } From patchwork Wed Feb 7 12:04:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A084C4828D for ; Wed, 7 Feb 2024 12:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rj4mES35XJKXuPC5ltpFL8TZFLgi9IrU+yU2Vjmld8E=; b=ndm1CSi4dzp+FC l+MBYDNlOH4fJlQci/QV323+SVVo2a60lyOstngFHs1xO4izkS0a9lEzw048XoWDWee8/KY0mhVV/ oO1WgqzVsxW73rhgrCwIuLFlBQd8WhjFbDEnBnxYfNRN+4VguIvni3qCDHWLKwoRUkyd0L2NsXyJv AreFKkOuaNRhxHcYprJwNmd+q62mbLAxJ3Zg4xXbuETjksDsnxNcE8LZ2qLC1Cy5rCaPSsAei4Gkp HFGrS783sn+xFb/DWSUGZKq5kB//RkXLA2fxgUoezt+0CAL+Te3lOt0heG/7C8KLrffuWtQ20Av5Z YVAODiRmqE5lAKa5Tb7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgg5-0000000AZeV-3NJh; Wed, 07 Feb 2024 12:05:21 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfc-0000000AZG3-2anR for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:54 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so414932f8f.1 for ; Wed, 07 Feb 2024 04:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307491; x=1707912291; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lw2MVCnXePoaGoFwhILfXnUXamqqjuyMAhC06ZDA+Mc=; b=I4BLandRbUt1G/C4SMLcwvqkbsQwUpiJgmscHaEGKj8pu4wIqz2zl3vQOrfP9b+UcJ d6XoUsvgCqPYZ1B01I4B4xrCHJDvzqTCm1YfK+/5iWd05IQrCPg/d4k6Vv471eYRNhf8 FgvVcbPjlRIUwdiE9hhqcBQlCKRwyHfdM1gHInOMciPymIU0Anv0WK4IOLJN+f3kqoi1 0T0tONx7FnQJS6BSh0yJDp0+1HQlZ2AXsw23pTH66pt6AinorxMPJB/mJyDvK3HB4zCT rv8SOqK9QJTp5SPYEaES51wzdTwsX9YNHnA71KjHqrJjxTcXY9bozy+tI0Ha91XkhIpL XAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307491; x=1707912291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lw2MVCnXePoaGoFwhILfXnUXamqqjuyMAhC06ZDA+Mc=; b=kzUvAYC2kP/gvV+9BlLiy1snvNFGvajXWWUisx1tW/wV25aYW/Icm8i7Stn5t2DM3k esvOoCR5Sjtt0tnL+vv90AptMhcTc93kRK9k6o7gsKYnfC6bftZ5mGa5HepfTzp0Ko/F qoShBWUT/MVCbgddFP00CWBmr2/wISgN7uBoIW+8fjBwLgpenvCihzLwD/0YE2MywK/F WikucNPt0948NY3HBWhWYVDQWk5lFUL796y33ZAQvPSbMqxF1ha3Ih0DS8PfUaFPP5Gp uDFsheAZCfe0PQhZZ8OFjqEevM/mj4DkNAw+8L/va2MpWnj5agFV5I5InMBzNEuDbN3g MddA== X-Gm-Message-State: AOJu0YzAS2TnhM3bPU8OyUwGUXUNCfURFvCGmBDbjFTOATkXy5PB1cgQ 3aYS5wBEK9w8P92C6TXrS4AXZmlbycEndbwVL3HhuF00F+uwcW4F9ukOA+XS8eE= X-Google-Smtp-Source: AGHT+IHAYlMgGVbJm1ulTdNKa/+d0RgWGvnEGEpkGS2NLVlo4ZSIijWb3cfglDfGFwxik/TiWE7lGQ== X-Received: by 2002:adf:9b88:0:b0:33b:216d:70bc with SMTP id d8-20020adf9b88000000b0033b216d70bcmr3033646wrc.42.1707307490826; Wed, 07 Feb 2024 04:04:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUAVMzVycVD1s6muTwkHOso64lMG/emDU5TiblalPWX7ZMHPJ5//3sDLDgEuNNZ2aejKW5KK9QN7rDbCTgQ2Wj/UBuVCg2IXUOVzlU5gB6mNN1onRg/Jsmvj9MNWKST7hrSIBv2qCpxV4AxqG6CDKNAZqjBq3PsymshtpNimVbZJPX4GC7xX/WWsSaTzZknsKwN1XOo5G8bnWTdaVmBfDL/TIeiHwE7NYFnJRI5RXe+k5TSIk4H33xzDkNeqod5v4+3vhsGtBzwrYiLOywBnRWzgl04dRvB5kwuD/+yuqmjC9UqOizl+brwqNY4GqGKADdhdSrMxTH01oc8sE5ntbRmHTtCKTLkl7joeouwRxmGAACiPA6Qq98RFng40UhReyhxs3JGqC4atlIgyOnV7ERYsOdt6gLbFhEJOucDrjhUWqPFNPIJjVRLs6ty16nLLqdFiX+paCeYJouUXhqtJtN8c0Y9l1OiQPYQyCkFWJocTIClBepJQa2sqjQceA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:50 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 13/17] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Date: Wed, 7 Feb 2024 12:04:27 +0000 Message-ID: <20240207120431.2766269-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040452_713922_806DDDA3 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ETIMEDOUT is more specific than EIO, use it for wait_for_completion_timeout(). Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 4cafec877931..bcc00cb5e0d1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -566,7 +566,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, /* * If the previous xfer was completed within timeout, then - * proceed further else return -EIO. + * proceed further else return -ETIMEDOUT. * DmaTx returns after simply writing data in the FIFO, * w/o waiting for real transmission on the bus to finish. * DmaRx returns only after Dma read data from FIFO which @@ -587,7 +587,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, /* If timed out while checking rx/tx status return error */ if (!val) - return -EIO; + return -ETIMEDOUT; return 0; } @@ -617,7 +617,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, if (use_irq) { val = msecs_to_jiffies(ms); if (!wait_for_completion_timeout(&sdd->xfer_completion, val)) - return -EIO; + return -ETIMEDOUT; } val = msecs_to_loops(ms); From patchwork Wed Feb 7 12:04:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548394 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AAE6C4828D for ; Wed, 7 Feb 2024 12:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vcedwWWoVlszy2NWvDl2h6+dkibDXdr3GdAUn7RGdvo=; b=wSVo/9TqLaBPL6 nxX6/0NcVViQtd/OedWMA1DxYDZ31V+Jkb4d/XtUVmYe4+ManEha6U2cRTaNAOnmAu1KEHLrD/T8f 9jet4wvP7926CMsQbFwF0QZcjCBEEYwNyRbm7+GZTyYnm1N6cCP4FreunIbinFKgSMU+JLcl9T3yX 0xNYKs5oh493bhPD4B0vtRzeaP8JvyY/Cgbd3nsaW0RXPEn+AP6DUGv+tKZ2E1LHlRkxiJ/K26xqB Bmm0hRWVYLaYlmm0c9VzKJvu40Ic59I4RSZN79TT9+YI5FDJ8j8o+MAauH2Gl8pGiNeSsr3/tFXZq 14xjaWcPtCw6ACoH5QZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXggD-0000000AZkz-07Ld; Wed, 07 Feb 2024 12:05:29 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfc-0000000AZGc-3StG for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:54 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33b2ee2d1d6so316392f8f.1 for ; Wed, 07 Feb 2024 04:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307491; x=1707912291; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F6pV2GvkwiGM8sZS3wOj9QdqoXevBRStq9r4pHeBHjM=; b=eLzP00UIUd7tgEgctSTrVnzQwcq+tPvA0emprx5qt7pAXIH+yJ7DHXdULE3CD3rjAt xy63zWMtInozYNgyb9n/6AJ17rke1S3GIHfPukAyfGx2dwOB2mbZ4lnouqs58eWeeaPN JiCtm5Ok+y6/iTYnejYBRIjmomjSwecV7LDY604q0OHxAucqrNi6ZGc3oKvRv0Nu5eF0 /ktZA6gT78mcVp1ZQgRD+cUtEzxYRMfFyx/SQv47jQa6GCF9W8Rwz7jtQhbMhvpB/nAb D5u9ZWzZFQghkusGYwY3AninHupA9EOKismCLdZ2qGW/MHxeT/jTFOVVcP4BB5d2D+j1 JQhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307491; x=1707912291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F6pV2GvkwiGM8sZS3wOj9QdqoXevBRStq9r4pHeBHjM=; b=d418pGK20Ox4Q4TwXym0IZZt4ojxcQj6fWHkMeo08lU2WDlpt5ePBw4gqI/csl1j6I +SknB0YaTnyl5ZWXpsrArMurNE06v/iuSdpEJVqrsTMBnfUUeYWfC1cJ9eohXIrJKqLJ 0Yipnyvt2VhNS2byguG/TABzWjjHwrxHgBsPofp/q5aopjIDPCCXhOWnPHgDhphNpi43 Yji6FmUuddvbcoE6uTfPCoEP9lL9vMbQZnRMT7nbjCjoYlapXPtAjqLL1WWI8pKuYZnL cgG94c8FhVywKryQE1AgPHAp8HxcftUIJWwFdJ6AdhUbvhtLXINktYwvNOsyLD9yHR44 lZzw== X-Gm-Message-State: AOJu0Yzk1r74wwDp8jPtDBA16YAiTDL6VkaexAkf/EoCFPl791Opqkfp uBhG86Q3LcyUljVK62jsRnkASt0sFUIGt8L6Kg5Dm523jfOn1kX4bMG2eeXyK9bjuVyNwDSLQa5 9PH8= X-Google-Smtp-Source: AGHT+IEdlw8JH/QSRtZd610quS8/RIT1PIG99ZFWjrLwu4MmQXZ8BT3xN451LK0X9PBzhn/DnxzkDw== X-Received: by 2002:adf:ffce:0:b0:33a:e9b5:b14d with SMTP id x14-20020adfffce000000b0033ae9b5b14dmr2977897wrs.65.1707307491634; Wed, 07 Feb 2024 04:04:51 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV9mcRhUWoZkdqVD1YlZ6mDdMCTzp1K/WKzzPN4YOBL5kh2SFeTNNxJZf1WDk1W6nxUSQmICF1O6KtpyZarM4cbiucm88AXeVYKYiuI+uqjA8Pp05Bpm64G2BCdofnYzEG6DmG4KqN191ATxgJWReswzMyc/nnJOCseTlvj5o1G73v8XSCr6Kx8veIaeF1Z+id3kC3qqBTdRl2yOfTQM1p94DZmpY3FQ9wcR/Y588JOHAwabMZL4posJJnzDTijw3mPQUcOkXyqiD7jO5vbiUIJBCa8kHXNZfsIVsmyvpmdoM3HTA74Vq42TkhtIfbdVfqqKjMsVLNyuap1GuNGx6TiXFGmZ5lRD89Bd5vXETxVKdGLQI1Vu5KPVRl4eZ76GKjumcZbNppknmACOU9ujo7bcbtowkHm5azyJVZeIaGECyW9I9fYYtiKufG6vZouxyW0geiFIuOBN1JW0rkOb90zn/G8qizQ5DO4UnNTzuQAHLQ3Jt7VwVy4cfR1yA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:51 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 14/17] spi: s3c64xx: drop blank line between declarations Date: Wed, 7 Feb 2024 12:04:28 +0000 Message-ID: <20240207120431.2766269-15-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040452_931606_3D679A62 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop the blank line and move the logical operation in the body of the function rather than in initialization list. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index bcc00cb5e0d1..d257c4f5623e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1360,8 +1360,9 @@ static int s3c64xx_spi_suspend(struct device *dev) { struct spi_controller *host = dev_get_drvdata(dev); struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); + int ret; - int ret = spi_controller_suspend(host); + ret = spi_controller_suspend(host); if (ret) return ret; From patchwork Wed Feb 7 12:04:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67FF5C4828F for ; Wed, 7 Feb 2024 12:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eg2f1q5aTwv06e+Hyf0kup+f7+XSRZ4/9ZeZ0nwWtHE=; b=1c+Uafd9ur3+Lj RWefiSu/4fvgBgPC9x6AElldPODH/QMvwn9/JRQIz2EJxfF2HX6piwlAyUVP9zDE6vCBkoLuwE3HW FTqcWV/Xwf0NgK68smlZpE8RG4udticVRHMxi4vJKbt2zlUopuX5sUXJRtKqzDVJoCfeRRM87SO1t KsXj45ofHE9oU3kVHH4IVkZe+arqaFded4Ue6KGy1CmKwD6Un1WrJ5Q9AowuImFAdacUCZ4qBL/Dh TIY2ThZ+o/5AfN8v5ttOqCVKmgdqZMsbOrso9mmuT047qSAQsppuyQPH7T6wa3g8m6yStOnFFXLan ybYGSm/WlRjKolFsNYow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXggI-0000000AZq4-2uK9; Wed, 07 Feb 2024 12:05:34 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfe-0000000AZHr-1HTv for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:56 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40fff96d5daso4607045e9.0 for ; Wed, 07 Feb 2024 04:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307493; x=1707912293; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=esOoTMwtz9mK2VZUJDBgnsqINevzj8Tua/LgvZgzfIE=; b=raY6N35FZjnh9PLfou+yLf039owR2ACIKGqg+J0xP9yeFKQ9cF7O+/h2teiBjCTIZJ AUUR2AweyfWNp6lZLoaLpZRx/B354HotOnddTIFmfS1uxUlQx7rMqYY4WeU37zRSkvYs 7Dx0j09U3tgSbcEH4N93NcJCrJc0bpG9tkYEGTQOdRHbAjPRUdXIUsZ6+m+9DDnf04fz Um2Ekn4gUEmVKBu9G4+39lkaNdVu9ZmeC50Ztg7bh3li6oCX6pUmIDmPsNghwr0Homgv o9CRDv2HsSoiblU8WuYgeMXac/ywsl+z4/zQchquGljatAsIQ9A27zKxrUNMLqsCfYse H/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307493; x=1707912293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=esOoTMwtz9mK2VZUJDBgnsqINevzj8Tua/LgvZgzfIE=; b=UoyPeTr3iqrVfsyMVMGuijlmbF3OU2bTa9p3XjLygOdESRBtqwzNnXVWz6I00vGcuV 8D0oP+EJCeuXQH48213jo3O3WvPE5/kbu6ObeUe0XTFqn/FoTjSbxlYpzigdnXN8HjqP FF0d77a3W+c/3QEHPzD2WgnKQq6xMSfieFtl/4THedYBHxj9cB8FO9nyJ+sWaLD64/Am NCSWRWzG+7hAiRA2PdvncNDI2GhLOdmZITTuuR0lmMb3FPcf/C5R/Thfq2LzNX4oObkY fG8bk+O4BcRBpIQTp9gEnaFPdkh5ER4nZm+P/VE0TKykP44xcWpzdHi03ds+m8H/CWta y8Yg== X-Gm-Message-State: AOJu0Yw13JEKQSFDgy676T9ObqqIwf7OD1jJ3TkrMdJvJ2+ueOc9Vaci h2ZheNynJwiqKux844m9ry0wS0WC7kzDz07E1uc7vq08ryD+sCBNv+Xs0Ekdksw= X-Google-Smtp-Source: AGHT+IHNYokoEWrUMav45IyumWp2ABhQV7nc/ooQblNWaAvOKDxW2vN6k5GYusoa1cL9/U7spakTgA== X-Received: by 2002:adf:f151:0:b0:33b:4020:8710 with SMTP id y17-20020adff151000000b0033b40208710mr3001464wro.61.1707307492917; Wed, 07 Feb 2024 04:04:52 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWaal8oeOj9vES+9cljMw75JIEHiHMH3H2LXvh2RoTFVHMIyKN9cv6Rx4JqYjLBbgr8zJ1fECV+9sBx5uJEneYgGhYxv+sP1lLP3Sv2/TK8eNZh/kPkCN7XVNJaVpIaZ/3DpmTdMDbkH+O3hjPUrnigL9fUh0+EewK4LyupWyhsgqttJgx2/abu2cLoz8kkkcHw8tjSw8AVFKij6m6P7c9UVgIilzmlrhMyQvHfDmetnxveqpn/PlnYPVLQeUtgUdMFH9NjLdxIcD+uwQr7ff3Unjl6CbqJ4ieTj34kZY/J2GKprMlYfXRZDH3bPw7sY+MVDxWnnWNUzB1oMDM45qMphfUf9iTlxHEWlCFPjP18iIeCQ9PdqjP3U2zLqhOKyV016trQ7AX6M3XWCLgr8tXo3hA9OaTCdWet8K4CNWomLFogCYdMOSZIAcxjxAOT57NppAnEcGxegzz1Dv7v3wEB40lJEL9F5qWia9kCfaUTJbk9QQIV98S9UAcX0A== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:51 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 15/17] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Date: Wed, 7 Feb 2024 12:04:29 +0000 Message-ID: <20240207120431.2766269-16-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040454_444338_622EE703 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "samsung,spi-src-clk" and "num-cs" are optional dt properties. Downgrade the message from warning to debug message. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index d257c4f5623e..8ad28ec3e6c1 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1149,14 +1149,14 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) return ERR_PTR(-ENOMEM); if (of_property_read_u32(dev->of_node, "samsung,spi-src-clk", &temp)) { - dev_warn(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n"); + dev_dbg(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n"); sci->src_clk_nr = 0; } else { sci->src_clk_nr = temp; } if (of_property_read_u32(dev->of_node, "num-cs", &temp)) { - dev_warn(dev, "number of chip select lines not specified, assuming 1 chip select line\n"); + dev_dbg(dev, "number of chip select lines not specified, assuming 1 chip select line\n"); sci->num_cs = 1; } else { sci->num_cs = temp; From patchwork Wed Feb 7 12:04:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548396 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CC84C4828F for ; Wed, 7 Feb 2024 12:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7VpcjUiJM1gw8Ov7CdaAdiGu5EV3lwtrUyZaSqnCL5M=; b=ZW5yocTi9b7/Yu ok8mg/ZTP8EeavpfSCtrpVcGKNtyIEQvWHJd4F9zS3tldefI2zNu7q9le2d1nACZx6aGzPlrWaXBz VsV8GDAMknKKnX91lVCo6BdsMoAdYTGTLCmts721bUZ1D4wADrsOsQ7XJi2/iE+zALQ3qDOBrbfYk qip7TSNsUC/McE2hJcU9XGdgkW5l+bbkbDfhIKQ2NhzQ2DC17iQ91ZEHNks+Pvrwm54MC8Cjh2Saq z+KfSGLO07ClnIMFYrI7k/FdG9oUvWok+akq/1SC3fn2XNxcjkPWKb99eSz2bn/CizJLbXjJ60Xgl eGa8Qf6bABOVkMMPpUnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXggN-0000000AZu3-1HKH; Wed, 07 Feb 2024 12:05:39 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgff-0000000AZIj-0x4w for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:56 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-33b45e8a670so325602f8f.3 for ; Wed, 07 Feb 2024 04:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307494; x=1707912294; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ufnZbtzqByKMCHA6c4FVXpl44oTWg4jCcYWjZ5sNSY=; b=W7T3W4uV6+ehpzmK6RHWV/7LjsqWycAWxZUsDiKxoe/dZ47NVblg9a2tfA6iYCVrEd JF7w3etycrKavCLqfRZT3BuNVOQ6jnUhSulzrBw0Gpy7VO2+LOsC5hrpEecPApbt7nP4 pKG6qNSPkOUJQkI38LQbDwUmLcCODNyoek1s+QCn4pJIUF7oZcZFFVN4tkzHUTygfZEG 6sav6HkqB5zTW0qF+fwjXhWB1Yhhixb44ra8KeKiVpYE+NbsYnyhvl4iqkNmjwEdcujm cgc0UwRfzO8IM+hsVdbegnm8A30mqmH8GjFpgyXtI+mEJnElF9gLxtSElPUpuuFJYYPf 9bOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307494; x=1707912294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ufnZbtzqByKMCHA6c4FVXpl44oTWg4jCcYWjZ5sNSY=; b=I6t4HivOA2LYw+Z377v0jXizVKJnrUPXWJY0aKuKkgBjxdZ+0IxGOfeZ3xPhW8JmfR VA8lR0v7AOfv1232UgrJs/JlP0fCoqVFZxwuKPP4e0PXrIBSs0eVlyEWRypyQyAd+u9h nc29psNCzOm139Ia2ADniI/ufMRBl8luY0swT2L6BCvXIKWoA9F1y7IqGJF195R/ZlAk IRW27Bk3XVH6KXNLTW/NCjC5vTVyeNW7Ly39gNBm1U/E4Smr4YxWA6+wxtm5RIhW9ghC 7Vv08cVUEn/gLHQi4xKqJG+xg32jEp6mOj2WQkDRtB0hJbNqd3XRrH/+ORyajWA8wlUX 2vPQ== X-Gm-Message-State: AOJu0Yzhe41tbE0FBZl/EurdGvHoUVoG4eXFLj3fYMrhXGSrrQz046cy nCHk0IkHMWAtQrxWOewZDXWbzEQu+CpdCYBXp7cBmOMR4AS9xvkof6YZzUldoJQ= X-Google-Smtp-Source: AGHT+IFZT5HUj9Ch4rJSbpsip/HdNmr4oB4W9qCQPJGoBiXBqnNcx3ls5M2NAsHLNwHzFc9V7e/f8g== X-Received: by 2002:a5d:678a:0:b0:33b:28ee:645d with SMTP id v10-20020a5d678a000000b0033b28ee645dmr3154982wru.68.1707307494003; Wed, 07 Feb 2024 04:04:54 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUNBdOIH9bdH2mdNGvnteDdhtUtg423gHhRiIU8EipuSYxB4Jnvvy22Q4JUM6af/vtArLs6sopAQyYgAGNfcDYmd53wkvBPISfzd0y2hz3Ek8HK82t5uw1PU2fLLv/hJBZQA8Qo5Qky9n2NsHsAM/yazfDafaDpQvIr1jQvtkxKDVthlEomBOD9wlt3mKqkNm7g/75X3+drUsCUY9qwQi9RwlE7kLFWk42CTQcAYtcv/18q11HfXqHNSzv4nIRR2QlRQXd421oB+UQl6aAhoQ0hVxnf0C4EhAROGBBr93NOlVU0PFQ0DF+cpJwm2ZKcGvzeZQxaJjAE9f6sVbg/OF17uJWCXSpTAK/PgprTd9oYC3hF70hM2Jc5SEgZESMTUQPv/657od8oQU7q0I2xQsbNP9V83hjk2ENO0fTTf+ZMuQKgJzvPG8P3BA71+veRH+i+KtJ0dPd1y+vLf+0/iHPVa2GL8hiJ+zr68QTWM+n69yK9iQiuHnnW9cir4Q== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:53 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 16/17] spi: s3c64xx: remove duplicated definition Date: Wed, 7 Feb 2024 12:04:30 +0000 Message-ID: <20240207120431.2766269-17-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040455_382137_DC953E5D X-CRM114-Status: UNSURE ( 8.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org S3C64XX_SPI_TRAILCNT brings no benefit in terms of name over S3C64XX_SPI_MAX_TRAILCNT. Remove the duplicated definition. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 8ad28ec3e6c1..b618efba0509 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -116,8 +116,6 @@ #define S3C64XX_SPI_MAX_TRAILCNT 0x3ff #define S3C64XX_SPI_TRAILCNT_OFF 19 -#define S3C64XX_SPI_TRAILCNT S3C64XX_SPI_MAX_TRAILCNT - #define S3C64XX_SPI_POLLING_SIZE 32 #define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t) @@ -1132,7 +1130,7 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_MODE_CFG); val &= ~S3C64XX_SPI_MODE_4BURST; val &= ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); - val |= (S3C64XX_SPI_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); + val |= (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG); s3c64xx_flush_fifo(sdd); From patchwork Wed Feb 7 12:04:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13548397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A804AC4828D for ; Wed, 7 Feb 2024 12:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TjeMGoUl8rbvz4yTY5MGsKfWOUgQeOTX2W0hl0fbjog=; b=oul4eE8rJQG3RU GOIIxRGp73fzJLiJ03IV4TjvElBlFjx96e1Qv8hYMIDnimaiwhIqwPKxWP7+XAdPzwklay9nVz4Pg tHlYeVR0SO5IJCRLMjNsN9vbSCNVD/YyTDaVfXzvYKo7mgKpcqO3gVOQ9NOmuNA/TcFsbQRh7B3/X 2LFbVvBP7/jpxAZ9h6zgvd1J9Er/fTYTJOV3mjs59GWxTWGGLI1iVyfMilIjWiyCCsT6jIVQfb4Ql 9hvKOnLO4buy4NSlpOxBpKvYeXpH+IEE/vDWtItkINneqLZBvFJRTZLvzF+4zsW0CUTiFtUbdle1H ufbsBgwNOG2XXN0mB9yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXggR-0000000AZxo-02E8; Wed, 07 Feb 2024 12:05:43 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXgfg-0000000AZJo-1eM4 for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2024 12:04:57 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so414961f8f.1 for ; Wed, 07 Feb 2024 04:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707307495; x=1707912295; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MUmZIG7rbdoejZJeYccC+uC3nddcIt5ul4UQ/BCMGCc=; b=mceC09gdKZhJ7atpu0K96kHrNGeCG3X83lQrqvLh23aZOTYqb+YSqJs0hMOZYeo8Wq 8hTJiWkEQO5wmzTNwq9QBhA8oO2f8oSbl+1qhfMK8Uyb++pQN6Mvy/elSEqNV3yVSRza HgtSe52rsgUJRtrZYsrwyqhch8mSw4bMkeZ6kFhuj01hD+dzcElcO/acgbfijY7Jb1Ix Gd5b5Yp1a1lXI2MWdmEtSLYoRA5NkpLWQeoB6ll2hce77oKFkLyqBL1XUmGCjM1mHtR7 /i2vXP09TJbJc0n6EX6DsFKkw8/+CiJct8/mNCG4iBnrxLLJDkI/YHB+Zpz5dn06M0U3 H9YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707307495; x=1707912295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MUmZIG7rbdoejZJeYccC+uC3nddcIt5ul4UQ/BCMGCc=; b=U0CwtOmZkE0vLNv/2Q4ZsQzi1rjdlihFs6romfauuHj9R2rUDVRVyhwpKWaEWYGNB7 wojCXb6FY3wmFG3eFmRUN8udJvd1YYGjmohsqbh7/TuEI3J96Y403e8RA2vowO0ck2Z2 6Kz1xHhIRd02coD0Usb2Bt9a0QJX/WEcudT4epLqFMl1w4M0v2a4XpkCFhG7bWZCAaPz XlO/VN9eveTAbGp9FM8/TNZaADSqzwEbeE0J9ycZ18AxbCrbNmAUhci6g12ifGoG0ycP KmvbUyAdn8kmyakGCTlhRTW2Y5gnAqY4pakawCKzm4W0Tu8MOEa6vhaIGmITERLh3phC RbRg== X-Forwarded-Encrypted: i=1; AJvYcCVaPpanbr2bHc+/5+RtW/AZuL8oE5e6X/GX2QRw8NzFbCpeWPsGO/yFvfMg//IDABBBa9ryww59x7uLfHJmhxcxQATk868lhQoDz3ohNzefzWD9fNM= X-Gm-Message-State: AOJu0YxDatcNRbIGZmqWdc3Flws0K6nGRNj2ZsmuGxngBz8NglzL7Ysh h9yirm6/d6E84KmoUJ1DWt8XP33Lr4jNEkPv5p9t+XBKqJHaukXYOn3+Nxw/wQs= X-Google-Smtp-Source: AGHT+IFD11KuiTyToxxU7V5ynwF5qtWYXKNpZ+ojCpcavXuhHfNCiW/EREgR8+OsmdJvTBADWjVmyQ== X-Received: by 2002:adf:ef04:0:b0:33a:ecd6:1c71 with SMTP id e4-20020adfef04000000b0033aecd61c71mr3025707wro.56.1707307495029; Wed, 07 Feb 2024 04:04:55 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVYQvziI5mjEusSUaPhP14qhlm9p6zZIwfAk9T60Ma8Qt9fo0WfkTkJE5aFzp5O0QnfJ9FsuPRg5L3EWDvoHxvS1u2LIHGmb9+GaXZGkalH96i1KuSzJ2PHrFzC1Z9ZSG7ULlemCcI4HWyUgGHyxfI3p31aAQqC4KUwNvA4YRmsxASse05A+LOIXIxFW4wCuE5svHwtKBbHzek3At+QYTTmMnk5w9CivZkq9eYHcGU6dz4YznaGGNPH2iqZUnhPV/9SUexh9ATwMobHeHQjWeF9zlVTKItiotmBwHDCmDLPO5JWYkbfXb3fBTuKNtqc+7cdVxKhtr7N3teqFKtgHMx3CGHIj9NE3WYL+3szXb0N16BXyfWYXWKfSOLdfklfCCoCvuHHNydQwU7AitaevZyAS6vS2Mi5M1rtscaMdFlZoFMcfQyBNq5YTx6/QNEqQ3EnUEkfNT8JRcSL6UZBlge+a104Zc/3rABjxGaZSyyqJ84lPqBhJRAU9D6BAA== Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id d15-20020a5d644f000000b0033b44a349e1sm1349967wrw.38.2024.02.07.04.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:04:54 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH v5 17/17] spi: s3c64xx: drop a superfluous bitwise NOT operation Date: Wed, 7 Feb 2024 12:04:31 +0000 Message-ID: <20240207120431.2766269-18-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240207120431.2766269-1-tudor.ambarus@linaro.org> References: <20240207120431.2766269-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_040456_547329_92F5480E X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org val &= ~mask; val |= mask; is equivalent to: val |= mask; Drop the superfluous bitwise NOT operation. Reviewed-by: Sam Protsenko Signed-off-by: Tudor Ambarus --- drivers/spi/spi-s3c64xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b618efba0509..6f29dca68491 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1129,7 +1129,6 @@ static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_MODE_CFG); val &= ~S3C64XX_SPI_MODE_4BURST; - val &= ~(S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); val |= (S3C64XX_SPI_MAX_TRAILCNT << S3C64XX_SPI_TRAILCNT_OFF); writel(val, regs + S3C64XX_SPI_MODE_CFG);