From patchwork Wed Feb 7 13:20:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 13548484 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00DF20B03; Wed, 7 Feb 2024 13:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312018; cv=none; b=SVrgKoyNdR52cou/cCdJk1xovYFYQceuvLtL0+ZohzeoARkfGIruc4epG2rIwjFHTGDZHB4MXTzkWNUfwf65Y6fdekns1WAoMQUDUyC7lA3wyO2C+FJa6z3YyzKLc3I850S1zna5easiG/wALu5n2TOGp5rfQaLvMg+iYBmXWRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312018; c=relaxed/simple; bh=S1fOPorZfTPT9eruGFGxWNWI93/Yt7GxUMA9bTf8aYo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CE/Px50AwPPa1SkXv4nmLQ3nU0yikyekpDoof/uNBWxSZGHDjJdDhn8CYC/0wFdKBAU+3A6hTIadTdnp3zpxcXBgEGfxDSOL/32xCdA7dJQxWQwV4qniRvqJrr2bRTJuqcB5wFYlY8S6k+RlaLvcpg9mRvUp/DhTyjXX9B5viG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CCOgnmD8; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CCOgnmD8" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-40f02b8d176so5135575e9.1; Wed, 07 Feb 2024 05:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707312015; x=1707916815; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XtAXcU/XCAZNdV3GEH8KX6/QmDDlUownJGCmq2AEj8c=; b=CCOgnmD8uBg8++Fjuh354EP+PeEhfVUOPTr1WQ3PSBR3es+R8gvRA/jxsRq4oZ5nTY 2aHqKFj9e8uwvYBoLZsskkhrFHJ6AsD/c40KjL2bPPrqwARsMK9oaDS2UEDPYRNmBbPq iU9XVTwVz164l9v4h+ZusmqrOEf6v5AuCx9fs/ipzsyaKOToiT/bOhf+vPqqycGJ+G+t j3xok28RFaOxLpNpWhqPqlpVGdGKwlcI9btvnjBdey2eeMFZShHchsSx1SQR3WzvHcJv SYGzyZbQMTsRtBYwzWWU+gP8MZZBrlhZG1rDVhZled2TiyThBnZ9mPFQMxUf7aZPyoVA toBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707312015; x=1707916815; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XtAXcU/XCAZNdV3GEH8KX6/QmDDlUownJGCmq2AEj8c=; b=B8r6md7kix+SpQgeywJx2OLz30slysYJuksuhIBzMrDGubJ2fcnheI7vz7z+ZFNVEN gjxMcaVmFElIWDtYbEx6AL9771Dkx+QezEhjdFrdcIQ7caC5oSyE8HfZdWV8IyvTA7vQ 8d3p4vQaAAUi0Iw0pd2KHZxdPZe2BDzrZYbBEsCChvuk5itg+fQMk3gbQySybhPI2no9 cHAg4mGYbXeHy7czjS0BJGtnVlivwoHmiPuxxvdAf6sleRPcVPAYd7pidXoj1AR+EIES pMmzCKnrLA6MHjUEhwKPdoDtd5o2L++U9kkLhGmztGsUbodX4jrQx3FRe/k9UiVLyU6Y NtRg== X-Forwarded-Encrypted: i=1; AJvYcCU7pqOvZlnv+P0mPezO3VS36n49hE54CTsa1d51P+s2H2/17quRQNFTT7YgfvO72bntCR23fwWY4Shc2eJW7L8zbkf+E9UtE1ahvozT/w/LMNtcL0Y5jWC9lzU/VD/why360Et+vjm0 X-Gm-Message-State: AOJu0YwkLdyDXb49yrEkO/Ms+lLEpZ3+NEg7Z0qjMHoh32Xfms+kImbh 8Zh6ROPy04aQ2d1juTyy4GTucBrka22MnL9qcNZIZ49zA2SH4lkd X-Google-Smtp-Source: AGHT+IFxMqMcwE1PmyIdZoioYqNY+TBc5P4Ddg8jsJbOpAOp8aUECawJxkkRzKIkKi7IX3dnijEZOA== X-Received: by 2002:a5d:598a:0:b0:33b:47cf:323b with SMTP id n10-20020a5d598a000000b0033b47cf323bmr4833990wri.9.1707312014866; Wed, 07 Feb 2024 05:20:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVF9gUdMloeTu0n0vmmkI6dI8+gIIsCG08YVphQ4d2cK8/7jloXuP2hSt+zJD+bkjCA7JP525A9o/tc+NWMW1+ssOgBEiq3sl5A9jOp3qd+7xQuFN7GYGKnjAr/1WJDjNF1pJmoq2o8c4hkXVUn9yLMlV/LKu1RJhKKZij36BugFp9HsV+GP4Wg1YGK0pmlNUvbXhEFp1u03wKkqzQsCyYS89/UCpDycoiFT0UaEMan1mhs6h+BqgDkrAMKgCZIt2YQBXRoPvYFAFitqhXxj9j2cD56DdGmv1QBWg== Received: from demon-pc.localdomain ([188.24.52.65]) by smtp.gmail.com with ESMTPSA id c5-20020a5d4f05000000b0033b1b1da2adsm1495764wru.99.2024.02.07.05.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:20:14 -0800 (PST) From: Cosmin Tanislav To: Cc: Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 1/2] iio: adc: ad4130: zero-initialize clock init data Date: Wed, 7 Feb 2024 15:20:05 +0200 Message-ID: <20240207132007.253768-1-demonsingur@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The clk_init_data struct does not have all its members initialized, causing issues when trying to expose the internal clock on the CLK pin. Fix this by zero-initializing the clk_init_data struct. Fixes: 62094060cf3a ("iio: adc: ad4130: add AD4130 driver") Signed-off-by: Cosmin Tanislav Reviewed-by: Nuno Sa --- drivers/iio/adc/ad4130.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c index 53e19a863198..c7df499f9775 100644 --- a/drivers/iio/adc/ad4130.c +++ b/drivers/iio/adc/ad4130.c @@ -1794,7 +1794,7 @@ static int ad4130_setup_int_clk(struct ad4130_state *st) { struct device *dev = &st->spi->dev; struct device_node *of_node = dev_of_node(dev); - struct clk_init_data init; + struct clk_init_data init = {}; const char *clk_name; int ret; From patchwork Wed Feb 7 13:20:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 13548485 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED83976C81; Wed, 7 Feb 2024 13:20:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312020; cv=none; b=TvnB3bsNQnjVHOXW+P9z/dW+CCVYbHPlglf4wfy7gu4JIjZQ13v66ZIhhNvrSCJSlVlrQ1TSCrA/SPIOR1DNRFfZHg8gCzJEAUq+MBPN0tsQjtHb2p9JCK0hrFLw4Fz3XnBD42U0tZM70yAYaqKHXV4Jpq2wOVoZuieNa0en9UI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312020; c=relaxed/simple; bh=0IeWIuV89GhyH6S9xNFkwCTY+H/TKB0wj2Cx7ah5+64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ldMx5scmbQ6WP2GuH62a8w6frcA2H8Hz7mFqzWxbFvbd6PuJgKNUkIU86svR5fuJCLhhVYE+MhrsBqxVW9QREpOLYGCVMQxCD9bpT00II6JReydSydHrES785QrxvoapFWf2PZah3Rvrl44XpULZDvaAOFCmzEmy1dfZf/NbU18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KVupF5ad; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KVupF5ad" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4101eb5a115so1853115e9.1; Wed, 07 Feb 2024 05:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707312017; x=1707916817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lrmsP2bX51lU6YyoXTaVoFbq35iYHP9ljJnfgckCYcc=; b=KVupF5adZFboZZMQnC8UEGBRGOYMT+cJOxrdKCcj0TEMZcSQhiVbJe54sgoRC5HwVK xearQLnh30TyJaaYDNn31/YjfbLBCkrmfyMD7HeIqj4o4ABOlwY7PWLC1NyhzCyxIVH9 df7J/RQbQt+HDef8pIrZN5UVY3tU3qMREn5GCxZg6cB7vg4tJTTgFl9Eh1Aa8b6k3J73 LMmAVaVUYJD81s45jaJ/gJZY4C9uQx+h7tBVpqKyLubiaqw4RdmtonsGWIk0eOCXsDJw lSGcUODpKrZLG8Jq6NzQ4ovfkHpoCQIQ07zGFSnS9vdBbn2ATYRUjul0Ys+BYI6OEOMr nGmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707312017; x=1707916817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lrmsP2bX51lU6YyoXTaVoFbq35iYHP9ljJnfgckCYcc=; b=wzWRi8mHNkzwY/WL3wrArc3vMKK7UZ6akUS5BhgIPEvPv2hy7f2ZOxuY4gw6woKrZA kvX5vsK9291slOkDwx+ahy75KsOp3UUcdCDom/At+nDlxYyEmn8geIxjl8Q8beiYCzu+ RdpGHVQiUb6sP+guMziBcphlLobhGO16+KjxCpUVDPdbspoV1F+QjV1yQb4w1ym0sv6C NAFciwdNaZALE0MFQc1vr3RGpkxKgCYLvMMAA/3M6+u0NH77IkEr1Bu5G6XO/qE4DQG8 1QAjkMkiRtoJc+pCPsJiWToBbKhbNQZ1ALD/boyDRf1AHoPkTQyniiSFUgO6Y8Wv2xwf ie7Q== X-Gm-Message-State: AOJu0YxPafmUWbw/YlDSd6dOKaDLN1lW8pvumJBQaWeLBWtf88sKxr16 UUgDsxd7FfehP6gk8zpHlM8UULjAB5W6QHW9K3yBuMX5zUzApXuW X-Google-Smtp-Source: AGHT+IHcCCSXdJpdXy18Oog6sr+qR7ui39IjPjZop7d67hoXMdgKrYjYhYQPCYuGjrvyFa4RaaxkQg== X-Received: by 2002:a05:600c:34c8:b0:410:44f:195b with SMTP id d8-20020a05600c34c800b00410044f195bmr1524639wmq.28.1707312017151; Wed, 07 Feb 2024 05:20:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWvqjaghWk+Kd7OSOeNRuWQoEQkxid/kvk/znCTaO+6H/n+2IRhNQgE08H89NVwOZ9a36K0nvttHKOWOCcLfj0R47bZ9DstRD0P/iXtfZsTpoBZ0hNTUHYBbFec8uQc/NqNJxetkrgPdj/MFh6MpSJXoVFQPODI1gICdIDW3fZqEzR/zfN51MugB43MdIZWtQRmv3GTjTchQJyL8pzunnALxcWqz2PTfBiblhiX2qDLEfYeEDWU2yfV6+zWV3aKgSpfw2ep6Jdr50M4IaXO2gKza5XGztpEoShzQw== Received: from demon-pc.localdomain ([188.24.52.65]) by smtp.gmail.com with ESMTPSA id c5-20020a5d4f05000000b0033b1b1da2adsm1495764wru.99.2024.02.07.05.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:20:16 -0800 (PST) From: Cosmin Tanislav To: Cc: Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 2/2] iio: adc: ad4130: only set GPIO_CTRL if pin is unused Date: Wed, 7 Feb 2024 15:20:06 +0200 Message-ID: <20240207132007.253768-2-demonsingur@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240207132007.253768-1-demonsingur@gmail.com> References: <20240207132007.253768-1-demonsingur@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Currently, GPIO_CTRL bits are set even if the pins are used for measurements. GPIO_CTRL bits should only be set if the pin is not used for other functionality. Fix this by only setting the GPIO_CTRL bits if the pin has no other function. Fixes: 62094060cf3a ("iio: adc: ad4130: add AD4130 driver") Signed-off-by: Cosmin Tanislav Reviewed-by: Nuno Sa --- drivers/iio/adc/ad4130.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c index c7df499f9775..febb64e67955 100644 --- a/drivers/iio/adc/ad4130.c +++ b/drivers/iio/adc/ad4130.c @@ -1864,10 +1864,14 @@ static int ad4130_setup(struct iio_dev *indio_dev) return ret; /* - * Configure all GPIOs for output. If configured, the interrupt function - * of P2 takes priority over the GPIO out function. + * Configure unused GPIOs for output. If configured, the interrupt + * function of P2 takes priority over the GPIO out function. */ - val = AD4130_IO_CONTROL_GPIO_CTRL_MASK; + val = 0; + for (i = 0; i < AD4130_MAX_GPIOS; i++) + if (st->pins_fn[i + AD4130_AIN2_P1] == AD4130_PIN_FN_NONE) + val |= FIELD_PREP(AD4130_IO_CONTROL_GPIO_CTRL_MASK, BIT(i)); + val |= FIELD_PREP(AD4130_IO_CONTROL_INT_PIN_SEL_MASK, st->int_pin_sel); ret = regmap_write(st->regmap, AD4130_IO_CONTROL_REG, val);