From patchwork Wed Feb 14 14:36:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuno Sa X-Patchwork-Id: 13556606 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 815B737164 for ; Wed, 14 Feb 2024 14:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921233; cv=none; b=JP9BdAn+lU3OjtNLjVXEH9dpPY+TF7QmORjzXp3PBdEV3uXSnNeWd7rAqvCmB6Rh1mulbYlwK+btvNUrLA6CZDATnu2cdNFrlcH9DkhqVee1tCJDyUBsC8wPLGCPDujh8BqQWc7HS85vDwTGuAQbNPFm1jXxXH9yvOBqNXA08os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921233; c=relaxed/simple; bh=x7OShTw2eoZWfTDmTXjvc6IJ8ZKOJjhW41AkwIQ+FcI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=AktKjdEopRLhC7DVL+8LaeeoEsg7J1oeDo8v7+wDq6mOeYxkljvWpUrv9ZrHjQjsbWytJfyM9o6qus2bXAtpstlV3Dx/LQZDWdyQJOk8E/b1aCs4cBWLLBRiOWwMVabzW9O3wiRELehZMfz6hZe1uw75iiYL1+e4kvgGsRDhDfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=WKK9A6rW; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="WKK9A6rW" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41E8dY2x030737; Wed, 14 Feb 2024 09:33:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=DKIM; bh=Cvd7tLXXML7bmmm8ZBtVd/pa3xN6L4fgcsZd9lqusFw=; b= WKK9A6rWMokm3Yu5qBD1w73Wg/5nfoA/+63/eOuekMsCVTMIf0dQPBt+/h7LWjNb YCWjRnw6UNHdMuYxHW+k/uckypJSc1sd5mPtWG2ro7LDAGlHsK5AzCBmWDX4C6lJ FOjWPXj/A89eQAztEf9AsI8iPOpZXDKYinMPDsKviim+YxXUdEoXSk8uFhHds9Pa z9TcsqOwwjKa/oQfaD+9WyaznKD5ArGIP6CRv/iMqt78O3ScZ+zP7lXSKjsWdm40 us7FPVivE9bZRfRyfYiMRgRMMozqs9Gidu8cWvNZ22ekFQHirUYW4k2zviLCDeB0 8hjq30nPvZoLvndQZGM04g== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3w6purdp6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Feb 2024 09:33:38 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 41EEXaGR018586 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 14 Feb 2024 09:33:36 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 14 Feb 2024 09:33:35 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 14 Feb 2024 09:33:35 -0500 Received: from [127.0.0.1] ([10.44.3.56]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 41EEXStE008866; Wed, 14 Feb 2024 09:33:33 -0500 From: Nuno Sa Date: Wed, 14 Feb 2024 15:36:43 +0100 Subject: [PATCH 1/3] hwmon: (axi-fan-control) Use device firmware agnostic API Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240214-axi-fan-control-no-of-v1-1-43ca656fe2e3@analog.com> References: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> In-Reply-To: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> To: CC: Jean Delvare , Guenter Roeck X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707921408; l=3704; i=nuno.sa@analog.com; s=20231116; h=from:subject:message-id; bh=x7OShTw2eoZWfTDmTXjvc6IJ8ZKOJjhW41AkwIQ+FcI=; b=8wUaoB6v1q4gxkfNEBwAKF8tEhQeEcPsKrJj/AHsefSeGs7TdEhO6L0Nsvcmcr+0135sFZicS fpowCuLgcp/D+P5hwwkgoikErGCZB8Bq18ZVM1N9ImUZ/Z+iKdoFZt/ X-Developer-Key: i=nuno.sa@analog.com; a=ed25519; pk=3NQwYA013OUYZsmDFBf8rmyyr5iQlxV/9H4/Df83o1E= X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: fiwUb2hwZmyGp9_21FGuxUJsaIUOvNb3 X-Proofpoint-ORIG-GUID: fiwUb2hwZmyGp9_21FGuxUJsaIUOvNb3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-14_07,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1011 phishscore=0 spamscore=0 mlxlogscore=647 suspectscore=0 priorityscore=1501 adultscore=0 impostorscore=0 mlxscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402140111 Don't directly use OF and use device property APIs. In addition, this makes the probe() code neater and also allow us to move the of_device_id table to it's natural place. While at it, make sure to explicitly include mod_devicetable.h for the of_device_id table. Signed-off-by: Nuno Sa --- drivers/hwmon/axi-fan-control.c | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c index 19b9bf3d75ef..8dfe3b6c5a17 100644 --- a/drivers/hwmon/axi-fan-control.c +++ b/drivers/hwmon/axi-fan-control.c @@ -13,8 +13,9 @@ #include #include #include -#include +#include #include +#include /* register map */ #define ADI_REG_RSTN 0x0080 @@ -368,12 +369,12 @@ static irqreturn_t axi_fan_control_irq_handler(int irq, void *data) } static int axi_fan_control_init(struct axi_fan_control_data *ctl, - const struct device_node *np) + const struct device *dev) { int ret; /* get fan pulses per revolution */ - ret = of_property_read_u32(np, "pulses-per-revolution", &ctl->ppr); + ret = device_property_read_u32(dev, "pulses-per-revolution", &ctl->ppr); if (ret) return ret; @@ -443,25 +444,16 @@ static struct attribute *axi_fan_control_attrs[] = { }; ATTRIBUTE_GROUPS(axi_fan_control); -static const u32 version_1_0_0 = ADI_AXI_PCORE_VER(1, 0, 'a'); - -static const struct of_device_id axi_fan_control_of_match[] = { - { .compatible = "adi,axi-fan-control-1.00.a", - .data = (void *)&version_1_0_0}, - {}, -}; -MODULE_DEVICE_TABLE(of, axi_fan_control_of_match); - static int axi_fan_control_probe(struct platform_device *pdev) { struct axi_fan_control_data *ctl; struct clk *clk; - const struct of_device_id *id; + const unsigned int *id; const char *name = "axi_fan_control"; u32 version; int ret; - id = of_match_node(axi_fan_control_of_match, pdev->dev.of_node); + id = device_get_match_data(&pdev->dev); if (!id) return -EINVAL; @@ -485,18 +477,18 @@ static int axi_fan_control_probe(struct platform_device *pdev) version = axi_ioread(ADI_AXI_REG_VERSION, ctl); if (ADI_AXI_PCORE_VER_MAJOR(version) != - ADI_AXI_PCORE_VER_MAJOR((*(u32 *)id->data))) { + ADI_AXI_PCORE_VER_MAJOR((*id))) { dev_err(&pdev->dev, "Major version mismatch. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n", - ADI_AXI_PCORE_VER_MAJOR((*(u32 *)id->data)), - ADI_AXI_PCORE_VER_MINOR((*(u32 *)id->data)), - ADI_AXI_PCORE_VER_PATCH((*(u32 *)id->data)), + ADI_AXI_PCORE_VER_MAJOR(*id), + ADI_AXI_PCORE_VER_MINOR(*id), + ADI_AXI_PCORE_VER_PATCH(*id), ADI_AXI_PCORE_VER_MAJOR(version), ADI_AXI_PCORE_VER_MINOR(version), ADI_AXI_PCORE_VER_PATCH(version)); return -ENODEV; } - ret = axi_fan_control_init(ctl, pdev->dev.of_node); + ret = axi_fan_control_init(ctl, &pdev->dev); if (ret) { dev_err(&pdev->dev, "Failed to initialize device\n"); return ret; @@ -527,6 +519,15 @@ static int axi_fan_control_probe(struct platform_device *pdev) return 0; } +static const u32 version_1_0_0 = ADI_AXI_PCORE_VER(1, 0, 'a'); + +static const struct of_device_id axi_fan_control_of_match[] = { + { .compatible = "adi,axi-fan-control-1.00.a", + .data = (void *)&version_1_0_0}, + {}, +}; +MODULE_DEVICE_TABLE(of, axi_fan_control_of_match); + static struct platform_driver axi_fan_control_driver = { .driver = { .name = "axi_fan_control_driver", From patchwork Wed Feb 14 14:36:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuno Sa X-Patchwork-Id: 13556605 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFF0A43157 for ; Wed, 14 Feb 2024 14:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921233; cv=none; b=nR8pGrj1McqMHHRxhbzhL42uGATAWumtr1lUCYPRmrwteXajNpvyFX7cRmmijBI9dTnB5Z1WC/n3WSnqyDUXbWTefkSaXjHjwO7Mmq2YfDJFFHVr84uzMCtt0wdCmzqzb1rMVRW0bJegYl/Js5+0WBmASVBJHwCHspSXPYN+hk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921233; c=relaxed/simple; bh=4MGkiItuCrCFaWwUsfLb7PKO5WkBMn5qZT3/u9YXAmk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=gdiBfT8C2lP15Oleb+8KH7ZrU/V0MwKoymW0AVXZ+7mqf1kEb/FP7PMoKWS6kkmhNuuOESK711lbErZnYlGzazQZ72otFFOGCs5WUstuZa0b7bAQYaufVLV1J3y/yezCBQGG/ygsi9uCBIfsHdhEz5j4zTmGVecl0wExPcN04fs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=VLhaYtjG; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="VLhaYtjG" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41EEUPhk029704; Wed, 14 Feb 2024 09:33:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=DKIM; bh=TEAHqUKLc3sXhaN83b6H8qJ7AiJPisH0ctOFGihlILs=; b= VLhaYtjGoY920WH1gCMPs3qD407en76WZN1olh71fhoRG2kj0V8Mj0UNU1GcqM4p YqlSmZtKkCSfZLZunAuTcWXxPx606q6lgGslIuPXut+oT2tTASXt0WqM4lNq162/ kskckbvv5bl7wpMZlfKtJWEyZug9Kt43yKTqiQIb2UpOk/TnR11qY1QF8NULLJTP NsMJ88zH7jk2ON5kLJ1AEEvd7OLSAc9mkBhdkw242urWhpBYcNHBkMx++Y6xU+Ik amz0HfqKP6xSc/akLlqy1VGdx9+vOsar9Ejv4zGO3PQ3TnpWyeBRx9WGPtCWOMw6 QudO4BiiLmuJtGX8MQ6BUw== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 3w8ybcg0fu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Feb 2024 09:33:38 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 41EEXb0r022801 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 14 Feb 2024 09:33:37 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 14 Feb 2024 09:33:36 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 14 Feb 2024 09:33:36 -0500 Received: from [127.0.0.1] ([10.44.3.56]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 41EEXStF008866; Wed, 14 Feb 2024 09:33:34 -0500 From: Nuno Sa Date: Wed, 14 Feb 2024 15:36:44 +0100 Subject: [PATCH 2/3] hwmon: (axi-fan-control) Make use of sysfs_emit() Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240214-axi-fan-control-no-of-v1-2-43ca656fe2e3@analog.com> References: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> In-Reply-To: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> To: CC: Jean Delvare , Guenter Roeck X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707921408; l=757; i=nuno.sa@analog.com; s=20231116; h=from:subject:message-id; bh=4MGkiItuCrCFaWwUsfLb7PKO5WkBMn5qZT3/u9YXAmk=; b=VNp33KHCKjhXm4ZqdEiFkctm0vadCz3qKlbdKXZ4BJlo1VrjwKkT2AZl9kam6dtxJUKL/MefT sauHQBQ4FHKCiBsmyhB3HU+I9gs8e7z7ApsxlqMy5AOWWiiouww9pny X-Developer-Key: i=nuno.sa@analog.com; a=ed25519; pk=3NQwYA013OUYZsmDFBf8rmyyr5iQlxV/9H4/Df83o1E= X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: xTswFxGE3BjwcXgyYrNu2Fc4ADjznsgy X-Proofpoint-ORIG-GUID: xTswFxGE3BjwcXgyYrNu2Fc4ADjznsgy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-14_07,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 clxscore=1015 mlxlogscore=623 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402140111 Use sysfs_emit() instead of directly call sprintf(). Signed-off-by: Nuno Sa --- drivers/hwmon/axi-fan-control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c index 8dfe3b6c5a17..efd42a4f5951 100644 --- a/drivers/hwmon/axi-fan-control.c +++ b/drivers/hwmon/axi-fan-control.c @@ -84,7 +84,7 @@ static ssize_t axi_fan_control_show(struct device *dev, struct device_attribute temp = DIV_ROUND_CLOSEST_ULL(temp * 509314ULL, 65535) - 280230; - return sprintf(buf, "%u\n", temp); + return sysfs_emit(buf, "%u\n", temp); } static ssize_t axi_fan_control_store(struct device *dev, struct device_attribute *da, From patchwork Wed Feb 14 14:36:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuno Sa X-Patchwork-Id: 13556608 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1733556762 for ; Wed, 14 Feb 2024 14:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921235; cv=none; b=RnFU3FWn2BTV1Swg7MVLSn+9fJTQmWJZYC8vp/8elgLw2Ad+bcON+k73qdwW9KsC/td7O0VeHiDsF6lVHx+RHe6VpS7In2WC8i65Wddljcu8rGwSCOplQkk2TXhK8eP9XPEWtLR/ab8zvRvvUJItiGUEz/OHDe6Y0ntMRei64I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707921235; c=relaxed/simple; bh=TDLKnlqgzdAJtOO0ShEHMeTqJtxDQcOeKmSlYXwguls=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mkrzDYBPgIepcrceB3Hab6wmwOf1Unll68Ecbu1a5TGjOMLA/kEsbPGmHKDbWk4ZZbhln3Stb0g2Ga6xDoI4prAQMyi0O7ftLBGUEHrhnFwlKHNaOLkXJSGUhiEofcERowASyBzgG3RAp8sbJloGEB4MlBaRpCZk9XbLZusyv/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=0MzlXEnj; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="0MzlXEnj" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41EEURfW029829; Wed, 14 Feb 2024 09:33:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=DKIM; bh=+XSWmumf+6nTIJRq5ZBYYG+3vXAfjgmOpCHseUaCVd4=; b= 0MzlXEnjM7TQtkcFV/Y5SvnKDp0si8FSv5Cc0f1L76GDSjMOeFh7mTWq5CuNmg+s VusPWMdmLrc87YYPsFXKy0vlj2+fcyuqDXwZZL1nYkMmaWps7IAONdoXGe4qTS/t lAjF7akKrLnuxvoXSuNl2sQCUKVusKV9cmO0BfzF4nYBNNxEkXDUxtBhG4IRl9cz pMcSPuayZSU57w0cWLFTjniWQWtMev3BWkV8gNObpWq4G10MEKXAvzaozdRv1hlb /LIYAxbHwzq/UpnZJleLxjbn70WxIvCEd0S2Qf9e06OqWCMVdVNTuaVo/dSUUDWB R4kh/ezXDMOKB93wcXpYig== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 3w8ybcg0fy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Feb 2024 09:33:41 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 41EEXeiN018594 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 14 Feb 2024 09:33:40 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 14 Feb 2024 09:33:39 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 14 Feb 2024 09:33:39 -0500 Received: from [127.0.0.1] ([10.44.3.56]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 41EEXStG008866; Wed, 14 Feb 2024 09:33:34 -0500 From: Nuno Sa Date: Wed, 14 Feb 2024 15:36:45 +0100 Subject: [PATCH 3/3] hwmon: (axi-fan-control) Make use of dev_err_probe() Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240214-axi-fan-control-no-of-v1-3-43ca656fe2e3@analog.com> References: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> In-Reply-To: <20240214-axi-fan-control-no-of-v1-0-43ca656fe2e3@analog.com> To: CC: Jean Delvare , Guenter Roeck X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707921408; l=2688; i=nuno.sa@analog.com; s=20231116; h=from:subject:message-id; bh=TDLKnlqgzdAJtOO0ShEHMeTqJtxDQcOeKmSlYXwguls=; b=qH/W/xJdtz7HLsJ8j4zJ9iylMYx664mbxXc/TrFuPWDuMCLUfYG0iM6W9KMsRIw+eTv0UNnrE IKYw45rfqQfBuMw+CMpoL1iRkXBIZdXKCXNgsat5TC2JmSHosKkgPGB X-Developer-Key: i=nuno.sa@analog.com; a=ed25519; pk=3NQwYA013OUYZsmDFBf8rmyyr5iQlxV/9H4/Df83o1E= X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: gG0dNLtM32hkE-OxsPylpbRlxOxJQDFF X-Proofpoint-ORIG-GUID: gG0dNLtM32hkE-OxsPylpbRlxOxJQDFF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-14_07,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 clxscore=1015 mlxlogscore=750 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402140111 Use dev_err_probe() to slightly simplify printing errors during probe. No functional changes intended. Signed-off-by: Nuno Sa --- drivers/hwmon/axi-fan-control.c | 40 ++++++++++++++++++---------------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c index efd42a4f5951..35c862eb158b 100644 --- a/drivers/hwmon/axi-fan-control.c +++ b/drivers/hwmon/axi-fan-control.c @@ -466,10 +466,9 @@ static int axi_fan_control_probe(struct platform_device *pdev) return PTR_ERR(ctl->base); clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "clk_get failed with %ld\n", PTR_ERR(clk)); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "clk_get failed\n"); ctl->clk_rate = clk_get_rate(clk); if (!ctl->clk_rate) @@ -477,22 +476,20 @@ static int axi_fan_control_probe(struct platform_device *pdev) version = axi_ioread(ADI_AXI_REG_VERSION, ctl); if (ADI_AXI_PCORE_VER_MAJOR(version) != - ADI_AXI_PCORE_VER_MAJOR((*id))) { - dev_err(&pdev->dev, "Major version mismatch. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n", - ADI_AXI_PCORE_VER_MAJOR(*id), - ADI_AXI_PCORE_VER_MINOR(*id), - ADI_AXI_PCORE_VER_PATCH(*id), - ADI_AXI_PCORE_VER_MAJOR(version), - ADI_AXI_PCORE_VER_MINOR(version), - ADI_AXI_PCORE_VER_PATCH(version)); - return -ENODEV; - } + ADI_AXI_PCORE_VER_MAJOR((*id))) + return dev_err_probe(&pdev->dev, -ENODEV, + "Major version mismatch. Expected %d.%.2d.%c, Reported %d.%.2d.%c\n", + ADI_AXI_PCORE_VER_MAJOR(*id), + ADI_AXI_PCORE_VER_MINOR(*id), + ADI_AXI_PCORE_VER_PATCH(*id), + ADI_AXI_PCORE_VER_MAJOR(version), + ADI_AXI_PCORE_VER_MINOR(version), + ADI_AXI_PCORE_VER_PATCH(version)); ret = axi_fan_control_init(ctl, &pdev->dev); - if (ret) { - dev_err(&pdev->dev, "Failed to initialize device\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to initialize device\n"); ctl->hdev = devm_hwmon_device_register_with_info(&pdev->dev, name, @@ -511,10 +508,9 @@ static int axi_fan_control_probe(struct platform_device *pdev) axi_fan_control_irq_handler, IRQF_ONESHOT | IRQF_TRIGGER_HIGH, pdev->driver_override, ctl); - if (ret) { - dev_err(&pdev->dev, "failed to request an irq, %d", ret); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to request an irq\n"); return 0; }