From patchwork Wed Feb 14 17:01:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E074C48BEC for ; Wed, 14 Feb 2024 17:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970A36B00A9; Wed, 14 Feb 2024 12:00:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91F936B00A7; Wed, 14 Feb 2024 12:00:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 798DF6B00A9; Wed, 14 Feb 2024 12:00:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 639976B00A6 for ; Wed, 14 Feb 2024 12:00:59 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2C90CA0D3F for ; Wed, 14 Feb 2024 17:00:59 +0000 (UTC) X-FDA: 81791024238.27.45715D3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 3A1EEC0009 for ; Wed, 14 Feb 2024 17:00:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WgbFMw8U; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NIO6dV5; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WgbFMw8U; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NIO6dV5; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930056; a=rsa-sha256; cv=none; b=2kOrLFSWiCWqxLChcD+mUmOSZqu9gTdrQJbJrq5s4KlbPoj5J2GK6Gu4k6mlO9eyudxv4a lprNaOzc+v8HS3e7rVZvR4ZSq5FZBmMh+1EtjtTh2iW73inpm13xOB06wfqPyXubxhp/0F K1qaxrbYgbzKqIBGsQBNO5rXXRh8sKA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WgbFMw8U; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NIO6dV5; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WgbFMw8U; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3NIO6dV5; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E2WS2tmMx6vkdBbq/BMMJO3YZaJfxmYDmOZxjs2QKsg=; b=mFu7W6/yQYvvuOt+evww/dxphn6iuBpxS8gaBl+AaRrKz5zaC8X1BpY4mZgJnOmZuSPUV1 EXe4FUtJjVbfqFEtnR5fbZYlDxwYoBakc6nxU3D2Um04qliaygF0SQ0OeVWL6TzK9EtXwt 2u83vXQ+6mDUMNbsfyaCSMJgIPodsVA= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AD36021DB7; Wed, 14 Feb 2024 17:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2WS2tmMx6vkdBbq/BMMJO3YZaJfxmYDmOZxjs2QKsg=; b=WgbFMw8UsrxLruEg33YDAuX/poRzXS7nr/9vF3IZg0N8OqlEAqb7r2DCmE0N9JdTTknD88 DhsNvOUBQ8CBs44LnciNfutYPQvJF13zuDOSlEDicZfn+5sGByZKxDnrkfmyYpO3nCt9Dr 38A7zFmce29vz6ugxWdMRaJYObdjThc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2WS2tmMx6vkdBbq/BMMJO3YZaJfxmYDmOZxjs2QKsg=; b=3NIO6dV59Z+blB81iT3AmWsJbD2s5OZgbH4nP7yaUkeuxuYpCyB++tHVB7ivqpi8wrlcf8 kaTsY4hiqApWLVAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2WS2tmMx6vkdBbq/BMMJO3YZaJfxmYDmOZxjs2QKsg=; b=WgbFMw8UsrxLruEg33YDAuX/poRzXS7nr/9vF3IZg0N8OqlEAqb7r2DCmE0N9JdTTknD88 DhsNvOUBQ8CBs44LnciNfutYPQvJF13zuDOSlEDicZfn+5sGByZKxDnrkfmyYpO3nCt9Dr 38A7zFmce29vz6ugxWdMRaJYObdjThc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2WS2tmMx6vkdBbq/BMMJO3YZaJfxmYDmOZxjs2QKsg=; b=3NIO6dV59Z+blB81iT3AmWsJbD2s5OZgbH4nP7yaUkeuxuYpCyB++tHVB7ivqpi8wrlcf8 kaTsY4hiqApWLVAg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 2C77413A0B; Wed, 14 Feb 2024 17:00:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id yAQrCMbxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:54 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 1/7] lib/stackdepot: Fix first entry having a 0-handle Date: Wed, 14 Feb 2024 18:01:51 +0100 Message-ID: <20240214170157.17530-2-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3A1EEC0009 X-Stat-Signature: ciqdx7i9k8a6siq9axp5eywx1hwtgxsq X-Rspam-User: X-HE-Tag: 1707930055-291161 X-HE-Meta: U2FsdGVkX19VQdIDlKt232Li5tUXMMeswk517UGhQ9XcPVuh37CNkJuG4LIIlN1uxibBcpTF87eUuNIfFBU84Y0eFQ5MHMmDJg1qN3RFR3cejw1SZrlsLSa5QTgWzv3HXTe0OQPFEHZJEkqqde9SGcbtIQqJwGb8r+H57bgjs8wu8zEoqgvCgHrovjO4llrenKqfQIHX7AAOimv2qSh9T/MVJLWkpH9Z45F8TWVwWWECPdh417N+XfSB2hmK1AMGWDBlqR9DUZrG049JyAJprpw09Up0HvqlE3YD02b/KWj/7agVYUxQx70arN+DlJYtL49VcP5XLDmGesmqkDkjWiWsM+dCzRONaLzPz2Q579lS6Hl7ob0BYkNF6ArjWyKqjVF8azMa+dQjqaB2xQH2N+z9dKh7JdT9jqehHbobpIjQJtbDlaCTuiJdfAfgCbfTR7fIe8PQRVj1EDkdBo5rh/vuOPblLp2hnOdykR3dQehwAa7xfrYC3CQf8omAz/ekXfWb58HcJ4/7ttnX285rBb9GL2nACNDAVk20fony1HQq4XyxG2Ke7sRewU1DF45W0rSRqha37WysotSQSVBMo+6vh3ThSsnUg2aBvOLV02VwFlEqW6YWnneYJSOghPO6AwH5kRpVA6PhHjYvRJHqM9so4zrGrdqYfNTvxdIrZ8A2Styc0ZfIwDP48Kec+IDTwoyF9IRN740EJuAa5FGLqxgk861Z4RUx4ixWCDqCc6ex3VYJxpoa+/3Uc0Km6AAWcLnDlIy+rtyUJs7NmMCNON4m7GqF78c/A9xS/t+D8zkzOpXnTgBXRzKU36uJ26SQv+q3YvqcgzXSfuYflk0Ku80vEH6saMgSDcTpiD/VP7vTNzWXguJFqZuXxXAGXCHw4aZU4uX16Mz/cU3yDVTa3Ft/X6RAi2sYSs+LaClrTPf7O1z/E/4EpmnX/PRK3UjTYiB2sW3SmOqqOFe1oP/ vk3aTdp7 rwIua1OhkEXwWijhmQ37iyWl75ZSjydzqncORVc55jAL52XPiNPnrIWJ68uVAsKjhDFSP4gbnypuqqMCrro3y/MTIR26/EkxFk7Nm6BTRhX08s2UX8ou/JptEwFVJnvJ/t4S/wdzjq6D5FFvUHbYPnYYDGSOZcxBQYbc7WfPZARr/0G0mT5GQax3FijkPXjSr9L4bQtHTcrSpFuUDjv50zIiudV6zSdS4RPdK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The very first entry of stack_record gets a handle of 0, but this is wrong because stackdepot treats a 0-handle as a non-valid one. E.g: See the check in stack_depot_fetch() Fix this by adding and offset of 1. This bug has been lurking since the very beginning of stackdepot, but no one really cared as it seems. Because of that I am not adding a Fixes tag. Co-developed-by: Marco Elver Signed-off-by: Marco Elver Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka --- lib/stackdepot.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 4a7055a63d9f..c043a4186bc5 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -45,15 +45,16 @@ #define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ STACK_DEPOT_EXTRA_BITS) #define DEPOT_POOLS_CAP 8192 +/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ #define DEPOT_MAX_POOLS \ - (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ - (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) + (((1LL << (DEPOT_POOL_INDEX_BITS)) - 1 < DEPOT_POOLS_CAP) ? \ + (1LL << (DEPOT_POOL_INDEX_BITS)) - 1 : DEPOT_POOLS_CAP) /* Compact structure that stores a reference to a stack. */ union handle_parts { depot_stack_handle_t handle; struct { - u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 pool_index : DEPOT_POOL_INDEX_BITS; /* pool_index is offset by 1 */ u32 offset : DEPOT_OFFSET_BITS; u32 extra : STACK_DEPOT_EXTRA_BITS; }; @@ -372,7 +373,7 @@ static struct stack_record *depot_pop_free_pool(void **prealloc, size_t size) stack = current_pool + pool_offset; /* Pre-initialize handle once. */ - stack->handle.pool_index = pool_index; + stack->handle.pool_index = pool_index + 1; stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN; stack->handle.extra = 0; INIT_LIST_HEAD(&stack->hash_list); @@ -483,18 +484,19 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle) const int pools_num_cached = READ_ONCE(pools_num); union handle_parts parts = { .handle = handle }; void *pool; + u32 pool_index = parts.pool_index - 1; size_t offset = parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; lockdep_assert_not_held(&pool_lock); - if (parts.pool_index > pools_num_cached) { + if (pool_index > pools_num_cached) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n", - parts.pool_index, pools_num_cached, handle); + pool_index, pools_num_cached, handle); return NULL; } - pool = stack_pools[parts.pool_index]; + pool = stack_pools[pool_index]; if (WARN_ON(!pool)) return NULL; From patchwork Wed Feb 14 17:01:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038C6C48BC1 for ; Wed, 14 Feb 2024 17:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D67986B00A6; Wed, 14 Feb 2024 12:01:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEFCF6B00A7; Wed, 14 Feb 2024 12:01:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACF166B00AA; Wed, 14 Feb 2024 12:01:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9EFA06B00A6 for ; Wed, 14 Feb 2024 12:01:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 647ED120D65 for ; Wed, 14 Feb 2024 17:01:00 +0000 (UTC) X-FDA: 81791024280.02.70E1C76 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 13357180038 for ; Wed, 14 Feb 2024 17:00:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OvZdWWwV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZCRlyNPp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SicvF/Zp"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Rz4F4l7O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930058; a=rsa-sha256; cv=none; b=w3WMCtm04Znf1iwIWG+w49PcrklJ5V92pQ+lwY//Idb8Y8Vpxt7ehdLm3CT7arx3VTQG7d LQozo5xC7wpKssiFsX7Yiqg3KgfEUV04gnFjzF2CkK9sFAamgv2N3vkYEu3QLy+pecDgKk ajOSlYeEU1Hz2CJ7f6kT6w8mGuUIAeg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OvZdWWwV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZCRlyNPp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="SicvF/Zp"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Rz4F4l7O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JA43trKKhKihZJJ9usT00f7GursSmzhg3mriwKaV7y0=; b=hBU0jCLYYUO9Ip1Ap6XLYZL0Dbug1LWfXfpjvG13GSvZ6s/x3BeyW33j2TLXt0Tj43dBfY Cd0lvkyQQXgl982zgE8jTBLMMS1V/fc3Puwny3TqQxce4YlXZM4wgJPhxeTrQMkdqx6r97 zTzQFcItOLAIiKAKoRQOm7wk4UTtp2I= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E039621D01; Wed, 14 Feb 2024 17:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JA43trKKhKihZJJ9usT00f7GursSmzhg3mriwKaV7y0=; b=OvZdWWwV7yZibleSQHB/hwhj/LiACYirr963CTUvEqVb3T5jJzTJmpg2W7xSR98m5zeMV7 eO3aovW54M5slj50hhrFydjo7qlyVJEok6/kbfVtBlLR2EHX4ovqUaX3rrEfdUDU7+Cei5 O3A1kisZ1+o1xuqtVch6RUJ8VEvoz5k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JA43trKKhKihZJJ9usT00f7GursSmzhg3mriwKaV7y0=; b=ZCRlyNPpofKtvTVeGkz8qfUJlaGaAFfvD5opse8XMjN20CftUZkgVcWFwwgCx3TmOBUSwH Wu30l+t5pBjEsNAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JA43trKKhKihZJJ9usT00f7GursSmzhg3mriwKaV7y0=; b=SicvF/Zpk33wVwxSTyfRK7tlNxMb2qyZMYq3qIi2J2hKZEnP6yZ5DVpq7oIHveC9uZP+vg wHLwe+yLrZQZt0ieY2KUaZiRGe3hqJ4jXf89KEDYXK6y+10VykJGGPrujOrA0mzz9lDi3L 06giLXCKHCkr0/DFMjmdCtAap6J/NZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JA43trKKhKihZJJ9usT00f7GursSmzhg3mriwKaV7y0=; b=Rz4F4l7Ovo8/4T70d83JG746eAdiF4zCQn1/+xsngvnA4gjUJscgUE9SwdzJkhV1NKc5g1 cpp19ge4u6YiZAAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 62E1D13A0B; Wed, 14 Feb 2024 17:00:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id UKuAFcfxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:55 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 2/7] lib/stackdepot: Move stack_record struct definition into the header Date: Wed, 14 Feb 2024 18:01:52 +0100 Message-ID: <20240214170157.17530-3-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 13357180038 X-Stat-Signature: whi6py3ieb19ruazwkurxmjgbrug48ot X-HE-Tag: 1707930057-299776 X-HE-Meta: U2FsdGVkX18KQf8MeetOgPR/wx+6O1EtCfL3A8eW41Ip1B455NjnUUdKnIN9PdqYoKGFcyhA/KwtaoTklPpIctDeY0WUll4WZ4YyeQjzED48qLhyOE2QkQGcwxNVffJcWHPtavyABrqJnAvK3TKdUQNi22N1GLJBkl+Le5HmrIM2LmhrQLe0QanNHyaIQjny+xKOkwptTzLd7Y+9+75eP9hsSX0X//Bu+OQzXcVxpKGGirlIpfQmQmEDnhLrT5dlWMVSGoVc14cYb89jbpMRBmsFD1xj93cYfhkCUmbNdlBXZ3grlBIv88/N/AiTCQ6yOqXmAS5A+U70kqf/GB9n5mvIZ6ETuBjmfzAanlarO8IRWeWiACxyXIO3divAHqcmryOSEtySvJeX2Us6KQOmgTUYKJcbLoUuHhxCg3iYxiRHj11a+DWgiE9BPZeTlFKU3Qg3ZqpUzcvyPDavRmYifV34iM2tXlGaKKxsgwxlhyM025tKZJfLD067UxRcQsony5Q+dgVUjxYQAUjQblxoO5R7pEOy+kO+0ZjyH3nLdEByNuXrcPJcD9TEr+eKKMpywO/0NDlSQkoPs/yJC59gRd+DzqAitBE7KW8aXJxcFUJ6+9mbNaeh+qn7gRDd6HSTL6BlOk1UJ6fxzgbVezjK4EV81Qn7Q0j8bSzp4QRpweY2bUGOY+O80Z8fSXQMnPrc00bV077sQFG/fEyJD2K1QT6Lx8jgZi2kHx7fr+cKh9tUOM9BRz8c0gCqA2zyqdvg8y1dObWsFRBVpvjg+9FMlhSYElGhPCTK12uF6e6dUYDDk1xPfVsypB9Ch52xruZ5g+BE7PDs+hG4h7UTQh7/Npo5f7HzZN1rZdUG3e3b2Z9fur4umcs0hgtfwGHy0Y/ZT4umPoPayj3o9sEz/caZwO+bkG5LMpe1QsEU3Zko+fLYD8viHbMZVu4Q3U3p6wdwavwkmu7T6RT9b6HxuI7 lgcesmK4 wgby5uiI5nyvxePHOok8DcezaV0aqpkWFa+3m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In order to move the heavy lifting into page_owner code, this one needs to have access to the stack_record structure, which right now sits in lib/stackdepot.c. Move it to the stackdepot.h header so page_owner can access stack_record's struct fields. Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver Reviewed-by: Vlastimil Babka --- include/linux/stackdepot.h | 47 ++++++++++++++++++++++++++++++++++++++ lib/stackdepot.c | 45 +----------------------------------- 2 files changed, 48 insertions(+), 44 deletions(-) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index adcbb8f23600..c4b5ad57c066 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -30,6 +30,53 @@ typedef u32 depot_stack_handle_t; */ #define STACK_DEPOT_EXTRA_BITS 5 +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) + +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) +#define DEPOT_STACK_ALIGN 4 +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ + STACK_DEPOT_EXTRA_BITS) + +#ifdef CONFIG_STACKDEPOT +/* Compact structure that stores a reference to a stack. */ +union handle_parts { + depot_stack_handle_t handle; + struct { + /* pool_index is offset by 1 */ + u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 offset : DEPOT_OFFSET_BITS; + u32 extra : STACK_DEPOT_EXTRA_BITS; + }; +}; + +struct stack_record { + struct list_head hash_list; /* Links in the hash table */ + u32 hash; /* Hash in hash table */ + u32 size; /* Number of stored frames */ + union handle_parts handle; /* Constant after initialization */ + refcount_t count; + union { + unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ + struct { + /* + * An important invariant of the implementation is to + * only place a stack record onto the freelist iff its + * refcount is zero. Because stack records with a zero + * refcount are never considered as valid, it is safe to + * union @entries and freelist management state below. + * Conversely, as soon as an entry is off the freelist + * and its refcount becomes non-zero, the below must not + * be accessed until being placed back on the freelist. + */ + struct list_head free_list; /* Links in the freelist */ + unsigned long rcu_state; /* RCU cookie */ + }; + }; +}; +#endif + typedef u32 depot_flags_t; /* diff --git a/lib/stackdepot.c b/lib/stackdepot.c index c043a4186bc5..4a661a6777da 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -36,55 +36,12 @@ #include #include -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) - -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) -#define DEPOT_STACK_ALIGN 4 -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ - STACK_DEPOT_EXTRA_BITS) #define DEPOT_POOLS_CAP 8192 -/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ +/* The pool_index is offset by 1 so the first record does not have a 0 handle */ #define DEPOT_MAX_POOLS \ (((1LL << (DEPOT_POOL_INDEX_BITS)) - 1 < DEPOT_POOLS_CAP) ? \ (1LL << (DEPOT_POOL_INDEX_BITS)) - 1 : DEPOT_POOLS_CAP) -/* Compact structure that stores a reference to a stack. */ -union handle_parts { - depot_stack_handle_t handle; - struct { - u32 pool_index : DEPOT_POOL_INDEX_BITS; /* pool_index is offset by 1 */ - u32 offset : DEPOT_OFFSET_BITS; - u32 extra : STACK_DEPOT_EXTRA_BITS; - }; -}; - -struct stack_record { - struct list_head hash_list; /* Links in the hash table */ - u32 hash; /* Hash in hash table */ - u32 size; /* Number of stored frames */ - union handle_parts handle; /* Constant after initialization */ - refcount_t count; - union { - unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ - struct { - /* - * An important invariant of the implementation is to - * only place a stack record onto the freelist iff its - * refcount is zero. Because stack records with a zero - * refcount are never considered as valid, it is safe to - * union @entries and freelist management state below. - * Conversely, as soon as an entry is off the freelist - * and its refcount becomes non-zero, the below must not - * be accessed until being placed back on the freelist. - */ - struct list_head free_list; /* Links in the freelist */ - unsigned long rcu_state; /* RCU cookie */ - }; - }; -}; - static bool stack_depot_disabled; static bool __stack_depot_early_init_requested __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); static bool __stack_depot_early_init_passed __initdata; From patchwork Wed Feb 14 17:01:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732C0C48BC3 for ; Wed, 14 Feb 2024 17:01:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2B6B6B00AA; Wed, 14 Feb 2024 12:01:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB4966B00AB; Wed, 14 Feb 2024 12:01:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2FEA6B00AC; Wed, 14 Feb 2024 12:01:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AFADE6B00AA for ; Wed, 14 Feb 2024 12:01:02 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 05DA31C105D for ; Wed, 14 Feb 2024 17:01:02 +0000 (UTC) X-FDA: 81791024364.23.AAF96C2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id A6A2D18002A for ; Wed, 14 Feb 2024 17:00:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QfUJWNsY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NqpFyR0W; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VG4Ut+Wj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="5/ZZStpO"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lC7K795PsIjvK78gQgEPDu4QR3bWLN1iZOc7KJySKTk=; b=CODC2SnYm6AiF6B+u7vnrAWFsQFPX1KjZdHYTOWDC5z0ewyXZjW1/SJCEH+oJ30Dix/Yr3 r8qePFrAjI6yFuIP0zIyRuaOQYB/s3vrpOgSnR6VsORTnIcD80pJoamCFbkJHTVlnpols8 NrdiyJwgCkJ1lNy7MMRs2M2MY5vpc9Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QfUJWNsY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NqpFyR0W; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VG4Ut+Wj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="5/ZZStpO"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930060; a=rsa-sha256; cv=none; b=h5fytV5So/QasUZ1T6pdxW3sAHWppD7caP5wn5Uumrt4q2xrl1WjBwPXCFgBZpcdI2uK/o GPpO0OIHwMv9GReT1J4zSTuj4uobX4nsXakSoRyO5l9FAxJap5v4WaBvfXdHxtTwQlfh3G Lq69fLTgNd2ykIWtXIXc99dNk22dW1w= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0273821E6C; Wed, 14 Feb 2024 17:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC7K795PsIjvK78gQgEPDu4QR3bWLN1iZOc7KJySKTk=; b=QfUJWNsYEg3KlDVV4k1fz2Z4FNC954z4a5oZO/EaiOe4OEj6AGeLZ61GNB09dj3pceDX8c 0BtvUmMAhKu/yWzZUG3a/wS3X+F8NJY6hs037IYw2koXF/aPCLWInIAGoRphwmoY12UB11 Z2BCiFPh5Jnm+Y4CfMVprTqhfrS8Ixk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC7K795PsIjvK78gQgEPDu4QR3bWLN1iZOc7KJySKTk=; b=NqpFyR0WyUs8K9/mIycrNliOlVlk7eBO/EXa3oGpB0KY3txNKQohc73oglNWyvPoIJf4g/ 02PyWQUa9ZfKYBCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC7K795PsIjvK78gQgEPDu4QR3bWLN1iZOc7KJySKTk=; b=VG4Ut+WjS+KyJLCfZj/q6vbCFpijr3XDjBFPP/vYWr5ln6qyC4WdmQCEymerlFrqoScGOM 50wbFytT5pPvEHlrxbA+M+5Y/ri/jdjU+Ja7qoRyJFJ6YtK5t70T3IbrPuaXtc+r18Jut+ DfBmKzP6ihTD9Wr2I2Efntylc3oEPU4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC7K795PsIjvK78gQgEPDu4QR3bWLN1iZOc7KJySKTk=; b=5/ZZStpOLmoNOFv6SW/+i2+fhk1okI4WDrzltPYDBfKZ81iuZWYRKl7N9yk2cbNYolWMR6 ad4u3zytC2E4YtAg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 6C8EF13A0B; Wed, 14 Feb 2024 17:00:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id WKXWF8jxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:56 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 3/7] mm,page_owner: Maintain own list of stack_records structs Date: Wed, 14 Feb 2024 18:01:53 +0100 Message-ID: <20240214170157.17530-4-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: A6A2D18002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dr4oeds763xbgtc8q53t9c4k4jpszdca X-HE-Tag: 1707930059-234081 X-HE-Meta: U2FsdGVkX19PZYx6iW/oJHXa/ZwvIZTKonRQWb+HuVPeAGnHsf4vbe+5+JDlQfyv6Lpf1VdwW0R4cRpDVPkzc1d/c6ItPRdgnH3lF45iTdC6Kol8xikkVnQG1i4KItRSrs4vE3zmTod4y4UDMQXI+k5d1AGri/e54AGKmt7g8EeURC5X9ZrqQWDZz4f/nSQcaV3sq2lzKFhUdEDq5XIyRqP6n0ZE5D1Vzm9VmKpk71U3n4Tmuh3Cw3PuQzgwp7VDU6eK9tuCDYGuH1Au7fGux/P8c4avu04F8EjFN1d+/OQopU7rNFm+sCIhY2bkUNzZcGV4j6jF1/V64IqX9N0A2DPdkKvqcGnEI58KCm70Cul1fJW7Mm+YKL10Xfl5CWROuZTfU2DRsJSWl1WbYxpqatHSUS65MPS2niK3h2m3wyqSV0dTonDCavJKCCY+PZYyqbObWXCszBkZkIgZukc4YopBKm6UJbqsiBVEw8ZdBkX8eGAbhC12hcTiEvI02OWVU8atspu3jCVjYsnjBZVWHcpAeVaOESbao98vRc7zG4efoOaYkXpgTbl1YvlRDXnc2s6aSVfAohFVkLCfYkiU5g3VOcHgk3WSLgn4VFhNdwQSC1MmRsEbF2mt3jaMRX48zCORePjsMGF7d0N3RaWkYywUwrNKBX0rmWhqXd6hTFhPvR8kBDulwAZ/BtdRUkmEnfk1Q0bEiMcsnlDPe4vgZBcos9tleUYo2dsFGTdGexLP00vORTD8jVo+1/rYWZ6OubK2tuukYIxWexQzGr9BMiQ+ahw1+Ss8uosbXbuhReajk/E4cXKEPSG1sYHnrSesxOlGpePcg2GAoaLU/nKTb8lBsrRaCaLx/2dzDWtGp9vgyL9MJomU18NsAaWaDCRJduQDugexamxDHtlmMXPOcpgyXAn6miqnXlefx8u1mm7RfYK+xQE6cKUlalH/cfMFjnH+GGoRPvt5TnfbQXH FlWEINdz qTpAmKZR39Yv69n246j2Ftje4XyaTZOFzczXf6oducVcJ0qZeUoZhDamD2pHJq+G2kZUI6MB0wVoK2f30nfwo68uqOjqzd5D6u/PV9go9KjUpDqjqoGmdZxukr1R0CEBRcAKJqPyTHekaXRhyzNzXGTJ9RnJQaY8m/AuAFiNZnXr0mYNiCzVRLQ8cQ4Hz/3LOnMdcBo/H5hnKVcR5zD4RivckZenPTvtdVPohOqSjnapKrzlL3XFzsi6fTLYm2wcC4UOMSQHNhoMrJ2JvR+kfokA+4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: page_owner needs to increment a stack_record refcount when a new allocation occurs, and decrement it on a free operation. In order to do that, we need to have a way to get a stack_record from a handle. Implement __stack_depot_get_stack_record() which just does that, and make it public so page_owner can use it. Also, traversing all stackdepot buckets comes with its own complexity, plus we would have to implement a way to mark only those stack_records that were originated from page_owner, as those are the ones we are interested in. For that reason, page_owner maintains its own list of stack_records, because traversing that list is faster than traversing all buckets while keeping at the same time a low complexity. For now, add to stack_list only the stack_records of dummy_handle and failure_handle, and set their refcount of 1. Further patches will add code to increment or decrement stack_records count on allocation and free operation. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Marco Elver --- include/linux/stackdepot.h | 11 +++++++++++ lib/stackdepot.c | 8 ++++++++ mm/page_owner.c | 15 +++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index c4b5ad57c066..3c6caa5abc7c 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -178,6 +178,17 @@ depot_stack_handle_t stack_depot_save_flags(unsigned long *entries, depot_stack_handle_t stack_depot_save(unsigned long *entries, unsigned int nr_entries, gfp_t gfp_flags); +/** + * __stack_depot_get_stack_record - Get a pointer to a stack_record struct + * + * @handle: Stack depot handle + * + * This function is only for internal purposes. + * + * Return: Returns a pointer to a stack_record struct + */ +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle); + /** * stack_depot_fetch - Fetch a stack trace from stack depot * diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 4a661a6777da..3da6d7cfcdfb 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -687,6 +687,14 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, } EXPORT_SYMBOL_GPL(stack_depot_save); +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle) +{ + if (!handle) + return NULL; + + return depot_fetch_stack(handle); +} + unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries) { diff --git a/mm/page_owner.c b/mm/page_owner.c index 5634e5d890f8..33e342b15d9b 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -36,6 +36,14 @@ struct page_owner { pid_t free_tgid; }; +struct stack { + struct stack_record *stack_record; + struct stack *next; +}; +static struct stack dummy_stack; +static struct stack failure_stack; +static struct stack *stack_list; + static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -95,6 +103,13 @@ static __init void init_page_owner(void) register_early_stack(); static_branch_enable(&page_owner_inited); init_early_allocated_pages(); + /* Initialize dummy and failure stacks and link them to stack_list */ + dummy_stack.stack_record = __stack_depot_get_stack_record(dummy_handle); + failure_stack.stack_record = __stack_depot_get_stack_record(failure_handle); + refcount_set(&dummy_stack.stack_record->count, 1); + refcount_set(&failure_stack.stack_record->count, 1); + dummy_stack.next = &failure_stack; + stack_list = &dummy_stack; } struct page_ext_operations page_owner_ops = { From patchwork Wed Feb 14 17:01:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556792 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098ABC48BC1 for ; Wed, 14 Feb 2024 17:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 468A56B00AB; Wed, 14 Feb 2024 12:01:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9726B00AC; Wed, 14 Feb 2024 12:01:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2427B6B00AD; Wed, 14 Feb 2024 12:01:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0434A6B00AC for ; Wed, 14 Feb 2024 12:01:03 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 30C32C0E06 for ; Wed, 14 Feb 2024 17:01:02 +0000 (UTC) X-FDA: 81791024364.26.B511502 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 7C02114003A for ; Wed, 14 Feb 2024 17:00:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EpHuBP6g; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fCmFCy05; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EpHuBP6g; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fCmFCy05; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UE3eKfl5kkI5fbvZQeYL5WioU57G5GzrnlK8ssFNQw4=; b=cNtGzwbJEwgPcHXkgeFGKo5izUGQZpxAbMXxRsewPHtxv1o+d0bTFD9QtWEyIF9YlYnbh2 5Luf7X+8lDUGxo447lY5UplNtKXTx8zBqK1wVJ0oG63gjJVf1wIJLC8u4juagYyLv59FpS sI5ef+Qc+ZUkGcJ/nMD0WejcX/iBUiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930059; a=rsa-sha256; cv=none; b=Zx27ZvywttaKe9uDR84Wb97pBpOTJsOyFfGCbkIdc+Hv4sW71jfHzOzwgK/Q4Aejtv5nrc +QOTBjZUbJ+dMPdOXGrq9Q7XcsEqB3Cx4lwCeMUzeyazi6ASAD01KEjhvKCx18VW1dZvkT 56h0s22oO/uTtTFzMYl1+kfIlO30cPM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EpHuBP6g; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fCmFCy05; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EpHuBP6g; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fCmFCy05; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 017141FD18; Wed, 14 Feb 2024 17:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE3eKfl5kkI5fbvZQeYL5WioU57G5GzrnlK8ssFNQw4=; b=EpHuBP6glUCfx3TEAZSizbmIf9MU6xfQbSgNaV2UwXijSOS5Fy1blUiRDza1eJ8xpVSHWh BiZep5YNbbJTsqIb2LNty3m3UVqH5Mm+AVyQFFLv9tsNNzNO4l3ppN0E47RDJxKsCr9zQz sBYq+LYB7AOCPmw5RW3vjSDTlt7M5/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE3eKfl5kkI5fbvZQeYL5WioU57G5GzrnlK8ssFNQw4=; b=fCmFCy055XA4DUwbrXzHieNWBb5QQ3ODxy9PZ+pFHq7/1ZcJULtxR7NF16xAmFkf4tCUdt pDnnoetfjziN4XBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE3eKfl5kkI5fbvZQeYL5WioU57G5GzrnlK8ssFNQw4=; b=EpHuBP6glUCfx3TEAZSizbmIf9MU6xfQbSgNaV2UwXijSOS5Fy1blUiRDza1eJ8xpVSHWh BiZep5YNbbJTsqIb2LNty3m3UVqH5Mm+AVyQFFLv9tsNNzNO4l3ppN0E47RDJxKsCr9zQz sBYq+LYB7AOCPmw5RW3vjSDTlt7M5/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UE3eKfl5kkI5fbvZQeYL5WioU57G5GzrnlK8ssFNQw4=; b=fCmFCy055XA4DUwbrXzHieNWBb5QQ3ODxy9PZ+pFHq7/1ZcJULtxR7NF16xAmFkf4tCUdt pDnnoetfjziN4XBw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 72D7F13A35; Wed, 14 Feb 2024 17:00:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id sIpWGcnxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:57 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 4/7] mm,page_owner: Implement the tracking of the stacks count Date: Wed, 14 Feb 2024 18:01:54 +0100 Message-ID: <20240214170157.17530-5-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 7C02114003A X-Rspam-User: X-Stat-Signature: ng9ycqfy9pok6nuxeeqtmyycwtyuyfad X-Rspamd-Server: rspam03 X-HE-Tag: 1707930059-661405 X-HE-Meta: U2FsdGVkX19cHEzxYNblcsRA18mlzOYX5QY1zvku9Mh10gyVJZBN9xDZH+i/n02kLtIKvHCe/qUHNWhlz9a1o2BkBsBR2fynwP7qnJxDogtVpSnR3z1suTe17mYdhrspQpObt+RX0pnGvNFNOF61u+FuHDJ6oPpb/9R++ASZEWrl4SwWpaoRf8yYUn/UGI9jYYoD3PyTe+w/epiWSaq7R+oDXA15fLuP7JrvqUT9R0wpMGkJvLoGxNVSlD7CiEFLZvhYBNm937vA1LNzTxlX/3WH64TIpEJXlQkoiIWjr9SpagRdN/CvPVOIWWKPTm64vfWeTGqFVEq5EPbq/mqakIXHifkeJS7MsXfgrHRcGTrH755AaH9faAIKd4OQynR9b+ALyHZq6T1KzHz+QmJJ5UOkoil1/83o6DhNw2d7zJiNqdez0IW6QfTWcCB0TeklFALVAnCg82M2d7hbSad2CMeT8mn0ntsnPHAjwhAKWmh6iDxJe64T1PXL14kWt965sUPjgSWTVufGSSTrbX3k7/49V+rPz3qEd9k2o+9Rc5/DCiL68K0p4efdrIOeCUj6T11nkzNdHmJnmgCJhdEkR++Be4gUMcT2rfSUYhdbqVWn2n34blP3onUkJjnQ53S066zQb2a+DyCwzObjBwjga1cISzEM9Dx1Jjduek3V3CThSVKr2KNGdByWOTz6Mz6AmVn6ztRym+jIvhXVCL7wOd/kYSblEQUweArX6Iom6Wfi24JNDSInCPUla47eYrkdtKkgi4FQo9PyYA8Xhhz7EmAizUlTkeYjzd1nSrBbI+OBIaDQP7EjLOEvPCdBpl++saSKxHjf7T8Np708mTwgj7jDapQnRhdyEFBPfkzPL9/CGILQhH9pVcMnHmB35fxoB8qxj1EH67QePAKRSeYJbYfyXEYay378X++ETMhMzVKu2DLs8/aOPb7L2rXM/x2O/TFUSR18BG7boMW2YMF vxd/ap9i XULCvdfqMABqGJz8kHPIzO2lRCsEdG0eRSNF4iwoxmTm1eZpO9P9klCQ+1shvVfK6dWaNvdWzN9EeSlxLj8aHE+9VCdKd+pAyazrhHNCJuBhDAVr6AI3QgJ/WEzPNbUy5Di9rZy0oTgGMA0CYFOCn8c69X/FDdAKXXZf/JdocngcDHJIAxKXIQ7SAHs8eyAaTKX9dogBkktoae8HKh2MKR92HjQiD6bmZD02nPJ+aN1WxZ9XRgVbFcrgvurPIcrGyul08VE+Oiow0EUstz02xzgurSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement {inc,dec}_stack_record_count() which increments or decrements on respective allocation and free operations, via __reset_page_owner() (free operation) and __set_page_owner() (alloc operation). Newly allocated stack_record structs will be added to the list stack_list via add_stack_record_to_list(). Modifications on the list are protected via a spinlock with irqs disabled, since this code can also be reached from IRQ context. Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 33e342b15d9b..df6a923af5de 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -43,6 +43,7 @@ struct stack { static struct stack dummy_stack; static struct stack failure_stack; static struct stack *stack_list; +static DEFINE_SPINLOCK(stack_list_lock); static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -150,11 +151,68 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags) return handle; } +static void add_stack_record_to_list(struct stack_record *stack_record, + gfp_t gfp_mask) +{ + unsigned long flags; + struct stack *stack; + + /* Filter gfp_mask the same way stackdepot does, for consistency */ + gfp_mask &= ~GFP_ZONEMASK; + gfp_mask &= (GFP_ATOMIC | GFP_KERNEL); + gfp_mask |= __GFP_NOWARN; + + stack = kmalloc(sizeof(*stack), gfp_mask); + if (!stack) + return; + + stack->stack_record = stack_record; + stack->next = NULL; + + spin_lock_irqsave(&stack_list_lock, flags); + stack->next = stack_list; + stack_list = stack; + spin_unlock_irqrestore(&stack_list_lock, flags); +} + +static void inc_stack_record_count(depot_stack_handle_t handle, gfp_t gfp_mask) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (!stack_record) + return; + + /* + * New stack_record's that do not use STACK_DEPOT_FLAG_GET start + * with REFCOUNT_SATURATED to catch spurious increments of their + * refcount. + * Since we do not use STACK_DEPOT_FLAG_GET API, let us + * set a refcount of 1 ourselves. + */ + if (refcount_read(&stack_record->count) == REFCOUNT_SATURATED) { + int old = REFCOUNT_SATURATED; + + if (atomic_try_cmpxchg_relaxed(&stack_record->count.refs, &old, 1)) + /* Add the new stack_record to our list */ + add_stack_record_to_list(stack_record, gfp_mask); + } + refcount_inc(&stack_record->count); +} + +static void dec_stack_record_count(depot_stack_handle_t handle) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (stack_record) + refcount_dec(&stack_record->count); +} + void __reset_page_owner(struct page *page, unsigned short order) { int i; struct page_ext *page_ext; depot_stack_handle_t handle; + depot_stack_handle_t alloc_handle; struct page_owner *page_owner; u64 free_ts_nsec = local_clock(); @@ -162,17 +220,29 @@ void __reset_page_owner(struct page *page, unsigned short order) if (unlikely(!page_ext)) return; + page_owner = get_page_owner(page_ext); + alloc_handle = page_owner->handle; + handle = save_stack(GFP_NOWAIT | __GFP_NOWARN); for (i = 0; i < (1 << order); i++) { __clear_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags); - page_owner = get_page_owner(page_ext); page_owner->free_handle = handle; page_owner->free_ts_nsec = free_ts_nsec; page_owner->free_pid = current->pid; page_owner->free_tgid = current->tgid; page_ext = page_ext_next(page_ext); + page_owner = get_page_owner(page_ext); } page_ext_put(page_ext); + if (alloc_handle != early_handle) + /* + * early_handle is being set as a handle for all those + * early allocated pages. See init_pages_in_zone(). + * Since their refcount is not being incremented because + * the machinery is not ready yet, we cannot decrement + * their refcount either. + */ + dec_stack_record_count(alloc_handle); } static inline void __set_page_owner_handle(struct page_ext *page_ext, @@ -214,6 +284,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order, return; __set_page_owner_handle(page_ext, handle, order, gfp_mask); page_ext_put(page_ext); + inc_stack_record_count(handle, gfp_mask); } void __set_page_owner_migrate_reason(struct page *page, int reason) From patchwork Wed Feb 14 17:01:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0574EC48BC1 for ; Wed, 14 Feb 2024 17:01:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C31A86B00AC; Wed, 14 Feb 2024 12:01:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB8016B00AD; Wed, 14 Feb 2024 12:01:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E2926B00AE; Wed, 14 Feb 2024 12:01:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 86C0A6B00AC for ; Wed, 14 Feb 2024 12:01:03 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D3B1160EA7 for ; Wed, 14 Feb 2024 17:01:03 +0000 (UTC) X-FDA: 81791024406.01.67E14DD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id CDA5CC003C for ; Wed, 14 Feb 2024 17:01:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpOOoFhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8mM7AYOV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpOOoFhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8mM7AYOV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XK6TmU+hXbwqsi+dsf3umxmeEe7QW0b6t55ktNSdV6M=; b=aE/CSFd5TN+2neRQLRB9yB8w29EuWUMYqYVDF5WZKj10bPc3WAIDLNiwgVXx0CIaqCsRIg S5d3oU2+6OTMDshFeJZqwd4lrTNoMuGvLkSIwLxRIGgBOeuKR9CBBo8lXwSQD4hPjjDpTT 86SPLADs+Bp4UrG//0CsXnYVW+cbCJM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpOOoFhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8mM7AYOV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KpOOoFhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8mM7AYOV; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930061; a=rsa-sha256; cv=none; b=vU3l59nPrFWsf7bTgGswz0nV0ajSdu02wBHCj6trpB50kpOw200XrsixiTrIzYczAFR+hN SAHMFi7HArubEdNZC7KID0/UCoa8lnPyswPTNfSFKfV1DVy1GQ8wHYzV0NzocLeq9+1Snf woka5842HFUfkV7585Z7neL0qIwobUM= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0E76C1FD19; Wed, 14 Feb 2024 17:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XK6TmU+hXbwqsi+dsf3umxmeEe7QW0b6t55ktNSdV6M=; b=KpOOoFhuvYfq+25Mh6bBdoeH7GvbWv8AgabL7VOc1wQmWvBRymwKSBbSQjDzDfRuc/Q9Mo txj5A0xrdL8pqoN64tArqndeTjo6g/lWUslv//Ks8seGJAO8qR3XoAqr7WCcCxdK/h85kU BcflLpVREbh9rlhp7M2Y3sP/YrHAf5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XK6TmU+hXbwqsi+dsf3umxmeEe7QW0b6t55ktNSdV6M=; b=8mM7AYOVWw6nRhbI0vrmeuOYM3JCnE5+Zjw2UKNfuIuXA1z8eD/LkAg2BJ6dK8RTTChnpc CCpaNpkuhk81GvCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XK6TmU+hXbwqsi+dsf3umxmeEe7QW0b6t55ktNSdV6M=; b=KpOOoFhuvYfq+25Mh6bBdoeH7GvbWv8AgabL7VOc1wQmWvBRymwKSBbSQjDzDfRuc/Q9Mo txj5A0xrdL8pqoN64tArqndeTjo6g/lWUslv//Ks8seGJAO8qR3XoAqr7WCcCxdK/h85kU BcflLpVREbh9rlhp7M2Y3sP/YrHAf5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XK6TmU+hXbwqsi+dsf3umxmeEe7QW0b6t55ktNSdV6M=; b=8mM7AYOVWw6nRhbI0vrmeuOYM3JCnE5+Zjw2UKNfuIuXA1z8eD/LkAg2BJ6dK8RTTChnpc CCpaNpkuhk81GvCQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 815BD13A0B; Wed, 14 Feb 2024 17:00:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id gMbiHMrxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:58 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 5/7] mm,page_owner: Display all stacks and their count Date: Wed, 14 Feb 2024 18:01:55 +0100 Message-ID: <20240214170157.17530-6-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CDA5CC003C X-Stat-Signature: jbijdax9kukhjbaffinxutrhqae6jdqu X-Rspam-User: X-HE-Tag: 1707930060-767021 X-HE-Meta: U2FsdGVkX1/LEMHxkoi3kfpV75YDVBufUFkR38e3PxQrlXr7KkHco3lRsZLDF7NiUpsAwi5xCoiHk5K3deHPXSLkC46VGjmt8Ba8CzbYJ1gWZc4Gawv+q0bWDL4IGL3vK0oOC9ukMvX5GorZJ2cn84560kfVoDKK8O5X1ZdleRyt/ZiAurXXgR+8Y7+8b983LzN/bfjoyevHToRvO3aB7JOUlVf91umVF6kfOkHUQ7Vl6ppnuivSRgmPinPBLwGln79n7jtp00tp9hfP3ev/vvmr8CM+2L120NFcgPVRtaO8TNu6Zva87Jldda9tBe5qLHjS8l4PLAiBuaU8zVJ81JurbC5n4vkw2j2nhqqBu7xHRgias1s4V52jQTiLbDKUWbho8kNJm6DSua30Qe7tifBbuN9RGDq0/Yov8+ZiWOe+E+nssKUHbJ/xdIWCb8lxjx5tjh76QqB8G9XzQkerMu6DF2ta/3mY+MLGMWprLMhTffjdRiHxWCldhhCO5FMp/VIeg3C82mzf0ldna4Ddgu920briEYXjrzq02qsJQXlBg7XCu6Ym9ZQwy9ApTPDcCoqBXOMNPvBoLPGseDo1MhznQ3cqO5E8HpFnZylWTd9zWooxb7aSt5vydCVetdbr2XcMVkeePpD6xm47BNfOcE6vIzV4Zez7NKsOTZAU01NS2mq99lrH624M3TxoKd5cAq7cPaeVCqyJ3VC29fhfiq4oQ+B0WSuGaY9csbM1OE84MtzIBw2T0uDhAWxYMsLUXnUDKW1rzGTeaoMG1Br7kDvHWBh7c1xChO/fOr1Nr+RQbnY/FhPtvhxZH4hS/Pos+Vhc4erYhfAULlSGo5kJ9qmEgOovCdn4GJ0ZS6kEaSWRJrHWL763wtxW5ad1XkIAfXaEO7VTiz3pOk1OeklTe3Pr1hC0rUaLp8fbzt41l2dZqFCIjobrPHvJzdZcp0RRqwdBUIsyR22GmOnVbT2 r7vN8gvE FXPMDnDY9H837ImSz1lA4GKFSKXfX8mKG/E2IY3WqSqHoE8ri0Jx/18hMWYGWKoXTOpMz7+SVfqODY6BLANlRRkNNq0bPDpnas3+UWHGltTtNn5+uPFYme5YbpWg06ayK6FTJ1nSPqARJOD/nrY4c1eUz3+2DL8m+/4bvjmQh5sZepyUnOYQCM7Opy7Ez8QJhFs/qR0bKvcqXDKBKChL/r5x8iNfhaOuXfuCKhk/ax0gX9twoSW5pYd43sjKV8CAcW2JPYRIgwtjYPB76SvCahSakjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch adds a new directory called 'page_owner_stacks' under /sys/kernel/debug/, with a file called 'show_stacks' in it. Reading from that file will show all stacks that were added by page_owner followed by their counting, giving us a clear overview of stack <-> count relationship. E.g: prep_new_page+0xa9/0x120 get_page_from_freelist+0x801/0x2210 __alloc_pages+0x18b/0x350 alloc_pages_mpol+0x91/0x1f0 folio_alloc+0x14/0x50 filemap_alloc_folio+0xb2/0x100 __filemap_get_folio+0x14a/0x490 ext4_write_begin+0xbd/0x4b0 [ext4] generic_perform_write+0xc1/0x1e0 ext4_buffered_write_iter+0x68/0xe0 [ext4] ext4_file_write_iter+0x70/0x740 [ext4] vfs_write+0x33d/0x420 ksys_write+0xa5/0xe0 do_syscall_64+0x80/0x160 entry_SYSCALL_64_after_hwframe+0x6e/0x76 stack_count: 4578 The seq stack_{start,next} functions will iterate through the list stack_list in order to print all stacks. Signed-off-by: Oscar Salvador Acked-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index df6a923af5de..5258a417f4d1 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -171,7 +171,13 @@ static void add_stack_record_to_list(struct stack_record *stack_record, spin_lock_irqsave(&stack_list_lock, flags); stack->next = stack_list; - stack_list = stack; + /* + * This pairs with smp_load_acquire() from function + * stack_start(). This guarantees that stack_start() + * will see an updated stack_list before starting to + * traverse the list. + */ + smp_store_release(&stack_list, stack); spin_unlock_irqrestore(&stack_list_lock, flags); } @@ -805,8 +811,90 @@ static const struct file_operations proc_page_owner_operations = { .llseek = lseek_page_owner, }; +static void *stack_start(struct seq_file *m, loff_t *ppos) +{ + struct stack *stack; + + if (*ppos == -1UL) + return NULL; + + if (!*ppos) { + /* + * This pairs with smp_store_release() from function + * add_stack_record_to_list(), so we get a consistent + * value of stack_list. + */ + stack = smp_load_acquire(&stack_list); + } else { + stack = m->private; + stack = stack->next; + } + + m->private = stack; + + return stack; +} + +static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) +{ + struct stack *stack = v; + + stack = stack->next; + *ppos = stack ? *ppos + 1 : -1UL; + m->private = stack; + + return stack; +} + +static int stack_print(struct seq_file *m, void *v) +{ + int i; + struct stack *stack = v; + unsigned long *entries; + unsigned long nr_entries; + struct stack_record *stack_record = stack->stack_record; + + nr_entries = stack_record->size; + entries = stack_record->entries; + + if (!nr_entries || nr_entries < 0 || + refcount_read(&stack_record->count) < 2) + return 0; + + for (i = 0; i < nr_entries; i++) + seq_printf(m, " %pS\n", (void *)entries[i]); + seq_printf(m, "stack_count: %d\n\n", refcount_read(&stack_record->count)); + + return 0; +} + +static void stack_stop(struct seq_file *m, void *v) +{ +} + +static const struct seq_operations page_owner_stack_op = { + .start = stack_start, + .next = stack_next, + .stop = stack_stop, + .show = stack_print +}; + +static int page_owner_stack_open(struct inode *inode, struct file *file) +{ + return seq_open_private(file, &page_owner_stack_op, 0); +} + +static const struct file_operations page_owner_stack_operations = { + .open = page_owner_stack_open, + .read = seq_read, + .llseek = seq_lseek, + .release = seq_release, +}; + static int __init pageowner_init(void) { + struct dentry *dir; + if (!static_branch_unlikely(&page_owner_inited)) { pr_info("page_owner is disabled\n"); return 0; @@ -814,6 +902,9 @@ static int __init pageowner_init(void) debugfs_create_file("page_owner", 0400, NULL, NULL, &proc_page_owner_operations); + dir = debugfs_create_dir("page_owner_stacks", NULL); + debugfs_create_file("show_stacks", 0400, dir, NULL, + &page_owner_stack_operations); return 0; } From patchwork Wed Feb 14 17:01:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EFCC48BC3 for ; Wed, 14 Feb 2024 17:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB5B46B00AD; Wed, 14 Feb 2024 12:01:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D41C36B00AE; Wed, 14 Feb 2024 12:01:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B915D6B00AF; Wed, 14 Feb 2024 12:01:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9C1246B00AD for ; Wed, 14 Feb 2024 12:01:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6386FC0DFD for ; Wed, 14 Feb 2024 17:01:04 +0000 (UTC) X-FDA: 81791024448.09.AD5A3F5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id CCE8A100016 for ; Wed, 14 Feb 2024 17:01:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zes+YGlv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=86Scdmj0; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zes+YGlv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=86Scdmj0; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930062; a=rsa-sha256; cv=none; b=JB+LIDO2fC1tUwnQ3xO32C/+3nRO0Ps4O0pQ7g6Z0W2FJxbbzvFVYAWgZeapB6WqaFNh3W ugTwJWLe6t5wpEzmyxqclGteGRoNmvs7pfaAALoVstJ7x4V7AH5fVRaKnDaShw5t0avxfF SEmV/w7mFhUWwUWNgMNcA7hOPj7tqF4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zes+YGlv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=86Scdmj0; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zes+YGlv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=86Scdmj0; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O95gSBj24arVN2KSdkLlOTusRHAm3etcuM3qAIyUVjc=; b=kAWZ0gEa8Xv/zKtpYHhNiDrjscvThI2S2Qp19IkT7ZjqXLgxijU61LbpWkMeySm2h/Bj7R 3RHYXZfCE1V6Dsm1YkThExHBMpRs9cf8l0do7Sn4dyGaOWNojfvm1K21EULYN744QvVW/J InWTCuOxE58PLYSF9U9C13L4kJQ7PCM= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 021331FD29; Wed, 14 Feb 2024 17:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O95gSBj24arVN2KSdkLlOTusRHAm3etcuM3qAIyUVjc=; b=zes+YGlvv/bao0zBIXw9Zxr3DdFVNNTRtDV+b2DD6ZqBt31dljhlZLxxPY6JnRnX/dH7Xv lEAx+JMFrM4BvoMIy5uOjmUu716LBBjYkxy3CFeOGWBCNZNDaErMrY7hpTM+OPtX0ZDRUY f2rmdN5751tBiBl7y/ifA6uZR7yZV0A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O95gSBj24arVN2KSdkLlOTusRHAm3etcuM3qAIyUVjc=; b=86Scdmj0zPg4HuR75wAYrOc+P1+yRbV5BQV4UvtPgV/1ChGWvJVWeFILHJ7iJDt92UFN0g gTkTbDvL+T/TvACA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O95gSBj24arVN2KSdkLlOTusRHAm3etcuM3qAIyUVjc=; b=zes+YGlvv/bao0zBIXw9Zxr3DdFVNNTRtDV+b2DD6ZqBt31dljhlZLxxPY6JnRnX/dH7Xv lEAx+JMFrM4BvoMIy5uOjmUu716LBBjYkxy3CFeOGWBCNZNDaErMrY7hpTM+OPtX0ZDRUY f2rmdN5751tBiBl7y/ifA6uZR7yZV0A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O95gSBj24arVN2KSdkLlOTusRHAm3etcuM3qAIyUVjc=; b=86Scdmj0zPg4HuR75wAYrOc+P1+yRbV5BQV4UvtPgV/1ChGWvJVWeFILHJ7iJDt92UFN0g gTkTbDvL+T/TvACA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7536B13A0B; Wed, 14 Feb 2024 17:00:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id MFb7GcvxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:00:59 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 6/7] mm,page_owner: Filter out stacks by a threshold Date: Wed, 14 Feb 2024 18:01:56 +0100 Message-ID: <20240214170157.17530-7-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CCE8A100016 X-Stat-Signature: frr15odwqawgmhxfkibs47jqshhhmhcf X-Rspam-User: X-HE-Tag: 1707930061-719050 X-HE-Meta: U2FsdGVkX183UC3dQJ8jQ2QV06mZ6H7IuXJTDZXXmko7Yjzezy2q8o/vsfFtjmCE90chiWJ4VWiLPuBfoKgr5UgxTy2oZApfUGQ7HeIHNUPGjkg/4gcCEu4BgXvvx5PUO5LkFOO08dPzBJ6Z4U3BW7e6HGggItIrqZROGS38+7yHwck8mdC7SFAmR1LG3GMxG97dgEto+BGiwyY3R29iB5atYCRkezs3P52FB0R+5yQ3nv83Ya67uyrgWbunBAjSfWNGR+vE91lh2rzusClTTSxwuDfOpQl3ipI3sU90xnXS7dDxDBGcjIQYsXvCoIJZKFx3mQLlZdLHy05HOqryxTbeO3a3uHIzrzHTHvbJBtN2GqddSo3RdDZ+UzmSg3pq8TadprE8x4miy5/fzRf2OCu4Fc4Bo4fe5zpHkgOH1qqCO9dfOwWXbyWQli/bTJQPXI0P0mnHapBJMZNski3zuLJEUFsZWIwxsuYKXPgDWQYqCgBghgMyjgEgNeekKJerrZtufi2wLjjBMAgmQdzyeMEUM0Y1Trz591YgI/nXmKEBo6KOT0Ei4yzBKwN5obMwr3Q1fT0RdC2zfE5RBmOCxuOiueHA8EbiZtGWTlNkUTdU4Pl5cOXNqieQ7MtMm9ARfChl51UMMqlPkXwjkRUYX6saWpZQ3Rjdi1iuCIBTULYendyIfWU2lnrXsUaobscU/qBESapq6qxyCvBE6l82o9xdBDHEU/7herIYhCC17JGaj+iX8fICmz4hBBd+mg+fVO8gUsgsXHbbEKwiXqiAIfcG1mhawzIRqXGOpzAeD/48nhoqZN4IsW4jlK9YObrhG8bVgXV6GhipwDJu+EhY8hTjuFdaQ1rkBSYa7jQZxfjhKhh24LyDlAcfqgpGZ5NAUf38FItokJugnHq9D5k/34dXDlOKFB5KbS0X2V8yrfOiWHPR+2JszrDDsLaoqjWsh1YHL6CqqL72a9MLop4 YdZx0Wqr hYVA6Tue7ZXNTKhV0Z+1pEFf4Vw3UJmr/hFFmF7JegQ9K6u3bhQKneKbHoXLLydXmbR/F+jkOxNbHWC7ykCa+I3rywqJ3soZKEJYdoePkp/b7eprqf67aztNMtQXPss4DzCjMpBkLyg4MLAluKcazwn1UDs0M9HWpVDNixVayk61s7xA/8ZZ3jhDjR78pWuOPtwpXx3NgdnB6xzgI6BEf1WrjbDeUWVSeUHJ7swVP0JeuAXgm+CVhlgBwll4mTap0N61T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We want to be able to filter out the stacks based on a threshold we can can tune. By writing to 'count_threshold' file, we can adjust the threshold value. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 5258a417f4d1..9b975f59b773 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -846,9 +846,11 @@ static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) return stack; } +static unsigned long page_owner_stack_threshold; + static int stack_print(struct seq_file *m, void *v) { - int i; + int i, stack_count; struct stack *stack = v; unsigned long *entries; unsigned long nr_entries; @@ -856,14 +858,15 @@ static int stack_print(struct seq_file *m, void *v) nr_entries = stack_record->size; entries = stack_record->entries; + stack_count = refcount_read(&stack_record->count); - if (!nr_entries || nr_entries < 0 || - refcount_read(&stack_record->count) < 2) + if (!nr_entries || nr_entries < 0 || stack_count < 2 || + stack_count < page_owner_stack_threshold) return 0; for (i = 0; i < nr_entries; i++) seq_printf(m, " %pS\n", (void *)entries[i]); - seq_printf(m, "stack_count: %d\n\n", refcount_read(&stack_record->count)); + seq_printf(m, "stack_count: %d\n\n", stack_count); return 0; } @@ -891,6 +894,22 @@ static const struct file_operations page_owner_stack_operations = { .release = seq_release, }; +static int page_owner_threshold_get(void *data, u64 *val) +{ + *val = READ_ONCE(page_owner_stack_threshold); + return 0; +} + +static int page_owner_threshold_set(void *data, u64 val) +{ + WRITE_ONCE(page_owner_stack_threshold, val); + return 0; +} + +DEFINE_SIMPLE_ATTRIBUTE(proc_page_owner_threshold, &page_owner_threshold_get, + &page_owner_threshold_set, "%llu"); + + static int __init pageowner_init(void) { struct dentry *dir; @@ -905,6 +924,8 @@ static int __init pageowner_init(void) dir = debugfs_create_dir("page_owner_stacks", NULL); debugfs_create_file("show_stacks", 0400, dir, NULL, &page_owner_stack_operations); + debugfs_create_file("count_threshold", 0600, dir, NULL, + &proc_page_owner_threshold); return 0; } From patchwork Wed Feb 14 17:01:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13556795 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30747C48BC1 for ; Wed, 14 Feb 2024 17:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070786B00AF; Wed, 14 Feb 2024 12:01:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01FFD6B00B0; Wed, 14 Feb 2024 12:01:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDC426B00B1; Wed, 14 Feb 2024 12:01:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C484B6B00AF for ; Wed, 14 Feb 2024 12:01:05 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9AF51120DDB for ; Wed, 14 Feb 2024 17:01:05 +0000 (UTC) X-FDA: 81791024490.18.FC5454A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 837D740006 for ; Wed, 14 Feb 2024 17:01:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="zNJ/cNYg"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u2iYDTK6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="zNJ/cNYg"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u2iYDTK6; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707930062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EpyTfdqNt961GvDxag5tkCXV2rpAMmweQFUyE+zT/FE=; b=T/oaG4XWozrVM+mTHVSNtevlQlx58KhwXx98WJGsa3oGtHYpdssEmAcOuM77UkKeVSV2si eDO2fv/gjs4Gjbq42GeOuKyBA7FAW1KYwVxmWluSWSsdmhnInurzLyLPx2AlIYBxpp6oCG SI3t0BwPNCuH/lKQZPKb821vhY3P/lo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="zNJ/cNYg"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u2iYDTK6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="zNJ/cNYg"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=u2iYDTK6; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707930062; a=rsa-sha256; cv=none; b=a34zor7LMfoThzlnKeVFJn+GvrrvhHKthlJ6ycXhQ8fRHnDbvu8o8AqWo3vxufGY5xYUdz fyJiJ20Jj4aQdE7L/ETY8X5kbHr0wxWuiWyQsTcawNUj8she5UgDUq58tuFHcANPr84lqb xGdrRUuCp7bIo2sCeBzgm69BVcyAIz4= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 03EC121CF4; Wed, 14 Feb 2024 17:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpyTfdqNt961GvDxag5tkCXV2rpAMmweQFUyE+zT/FE=; b=zNJ/cNYgtsmqdxiXVl4EEvvYJE01rr3DXmJEAFyXBFuryxV/fI/CpAwUdOPR0A3c+ePlXH Gr5YG/jRzuNLd9KXVxFAGtD4P68UnQTwP8bPU9luFYYY0hmh90Bu6V3tGWIzgSMoMDQnpF XRjlI1satOiBwJrojtWfY+ILrsMv2xA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpyTfdqNt961GvDxag5tkCXV2rpAMmweQFUyE+zT/FE=; b=u2iYDTK6LdrTuoQRSUXtbrkjlplp39PcCQL61pHF6at7ixPmEwh+ib2EiyT1tL4RhEC15r cnNxb18n0speCkCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707930061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpyTfdqNt961GvDxag5tkCXV2rpAMmweQFUyE+zT/FE=; b=zNJ/cNYgtsmqdxiXVl4EEvvYJE01rr3DXmJEAFyXBFuryxV/fI/CpAwUdOPR0A3c+ePlXH Gr5YG/jRzuNLd9KXVxFAGtD4P68UnQTwP8bPU9luFYYY0hmh90Bu6V3tGWIzgSMoMDQnpF XRjlI1satOiBwJrojtWfY+ILrsMv2xA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707930061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpyTfdqNt961GvDxag5tkCXV2rpAMmweQFUyE+zT/FE=; b=u2iYDTK6LdrTuoQRSUXtbrkjlplp39PcCQL61pHF6at7ixPmEwh+ib2EiyT1tL4RhEC15r cnNxb18n0speCkCQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 781EF13A0B; Wed, 14 Feb 2024 17:01:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id mA2kGszxzGUfMwAAn2gu4w (envelope-from ); Wed, 14 Feb 2024 17:01:00 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v9 7/7] mm,page_owner: Update Documentation regarding page_owner_stacks Date: Wed, 14 Feb 2024 18:01:57 +0100 Message-ID: <20240214170157.17530-8-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214170157.17530-1-osalvador@suse.de> References: <20240214170157.17530-1-osalvador@suse.de> MIME-Version: 1.0 X-Spamd-Bar: / X-Rspamd-Queue-Id: 837D740006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qprnpoij9g49r5h3u18yfd7q7bbixits X-HE-Tag: 1707930062-651735 X-HE-Meta: U2FsdGVkX18YrsMrRnY4wL/tEnSCw1P2ldqQoBMm8F0sIle8M/6XH7W1uEmCQn3/YmNNkjcKtfM+3kAQP3QuGHFlnIy0pKqKKTCEvrhxWjjoRomckJazxpLjZGy7LyIp1+NcHeuqw7DLrLb4+guYLZLgMt8mfL1ztXZp3ygx6AV9NpI5A8jo8fucIxtJteFwBRI8nETcplL3T4XOFy8P3aJQliaZSnlhnD3TVNuMyESCrpOqNKocdFbUyZ3LCbU4E2nj0UBnPglxeOOaRA1nLWyRkzekts0Vl/sN1iXpThq7VZ11hvOgFSPOxM+oQYc0Ct3lJvMhr6cNg+7mqVcsG+w6cHDPoLHXQu+4eInWODzVe4BYNz6cqCPoCH7P87D0gRbRBjNYeUysYVpJRnXa2Ckh1rMWr/S0yLSlcF1Z52lXgp5gLUFGu5+iVj1kV6mW73hTWhIATTA7xEo7rsoBJ9JkOCltBTnWEqiF3d9Ebs58NTsJVFoysmXptv1y2kfTs1Xltnd9Y4mXZajRLtSoAZ3pYe3E56O1aL7xVuKLRqto2xFcYLEpkikVRxKPp0HgVcGkkGwWonVgx2o1rtaKElyP19HJjDQqup1lVLkbTmVmwGq+syCho23dIVduZWeJoe9in4C6dQ9cfNI1t7KqgbN5PGh/LXVeL0lO+FFUuLA3clW604nFjIHYKOBwy//3pENo0qspeHzu1WEXSyKY25CUNqH3y7jIN6L4IurmxOdDVeqRNSZRWR6cEWSj3RMKg4bhFobpLmjAfvPwk9xERh8OsTRydtFQoBqGDNArUGBRumlPuEQ2ZOpQUm7Wb+rZ6Sg8g821NYlzMPETmFjjnfQgdSZojd/XgFkylHZN+u0TxQuhYrTOFBrfbYEQTjBl/wq5nbqn886bxAuyr7bUzl3tMi/bn5G/j7MqTL0yuA4P0sEs2ZUlhPU2Pq3cgMwRA8HILg3LYt7Fo8gfwHW HG+4w8Hn I305vCHjkmXxvn+T49zATXWS58r9YxdRta9Vuf5TFEjsCk9OggPIt1BaKQhESDvOtwngHlOEaxN+0EahqXiQmm7MvFcGbWUug6SJInEB6mQD8Y/5GhjYPG/7EgHqUWTCPr0H0CE3EWmp6XgZGwAkVyoPck0Aec/siWFwQc6US5Ud11mJDUHbKi4JAxzqTdOh+zaCJdDmMug7hVBWKQsqs7krdPQH37UptxFOT9nUOoXaO1RJieopnra4fBNAa1pDFQRmPstI1Y2a2hLrB+ogZavyd1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update page_owner documentation including the new page_owner_stacks feature to show how it can be used. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Marco Elver --- Documentation/mm/page_owner.rst | 45 +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst index 62e3f7ab23cc..0d0334cd5179 100644 --- a/Documentation/mm/page_owner.rst +++ b/Documentation/mm/page_owner.rst @@ -24,6 +24,11 @@ fragmentation statistics can be obtained through gfp flag information of each page. It is already implemented and activated if page owner is enabled. Other usages are more than welcome. +It can also be used to show all the stacks and their outstanding +allocations, which gives us a quick overview of where the memory is going +without the need to screen through all the pages and match the allocation +and free operation. + page owner is disabled by default. So, if you'd like to use it, you need to add "page_owner=on" to your boot cmdline. If the kernel is built with page owner and page owner is disabled in runtime due to not enabling @@ -68,6 +73,46 @@ Usage 4) Analyze information from page owner:: + cat /sys/kernel/debug/page_owner_stacks/show_stacks > stacks.txt + cat stacks.txt + prep_new_page+0xa9/0x120 + get_page_from_freelist+0x7e6/0x2140 + __alloc_pages+0x18a/0x370 + new_slab+0xc8/0x580 + ___slab_alloc+0x1f2/0xaf0 + __slab_alloc.isra.86+0x22/0x40 + kmem_cache_alloc+0x31b/0x350 + __khugepaged_enter+0x39/0x100 + dup_mmap+0x1c7/0x5ce + copy_process+0x1afe/0x1c90 + kernel_clone+0x9a/0x3c0 + __do_sys_clone+0x66/0x90 + do_syscall_64+0x7f/0x160 + entry_SYSCALL_64_after_hwframe+0x6c/0x74 + stack_count: 234 + ... + ... + echo 7000 > /sys/kernel/debug/page_owner_stacks/count_threshold + cat /sys/kernel/debug/page_owner_stacks/show_stacks> stacks_7000.txt + cat stacks_7000.txt + prep_new_page+0xa9/0x120 + get_page_from_freelist+0x7e6/0x2140 + __alloc_pages+0x18a/0x370 + alloc_pages_mpol+0xdf/0x1e0 + folio_alloc+0x14/0x50 + filemap_alloc_folio+0xb0/0x100 + page_cache_ra_unbounded+0x97/0x180 + filemap_fault+0x4b4/0x1200 + __do_fault+0x2d/0x110 + do_pte_missing+0x4b0/0xa30 + __handle_mm_fault+0x7fa/0xb70 + handle_mm_fault+0x125/0x300 + do_user_addr_fault+0x3c9/0x840 + exc_page_fault+0x68/0x150 + asm_exc_page_fault+0x22/0x30 + stack_count: 8248 + ... + cat /sys/kernel/debug/page_owner > page_owner_full.txt ./page_owner_sort page_owner_full.txt sorted_page_owner.txt