From patchwork Wed Feb 14 22:04:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13557107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA94CC48BEB for ; Wed, 14 Feb 2024 22:04:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE8CC8D0014; Wed, 14 Feb 2024 17:04:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C73278D0001; Wed, 14 Feb 2024 17:04:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B60728D0014; Wed, 14 Feb 2024 17:04:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AA2C38D0001 for ; Wed, 14 Feb 2024 17:04:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6966E40EE4 for ; Wed, 14 Feb 2024 22:04:39 +0000 (UTC) X-FDA: 81791789478.05.BE7A28B Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 2E1831C001C for ; Wed, 14 Feb 2024 22:04:36 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Sd+c9faY; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Xkqa1QfF; spf=pass (imf21.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707948277; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4ZJxJN83A=; b=7JJxIkxhV6Ztr+Mdhzx70dGAdjg6qPwbXJMmNPcOY71x89jQblLtk6+aGo9n6o4lFRxr2T sTr2N6SoxPqqpO7QhI7UwjB4ZhiAmzfDZZzEFItiAd0yDsTj8D3KZzC1hP7S/ZaAzXF9AE J51oGqWtP5md86sbwFxBkPrJLlcRQBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707948277; a=rsa-sha256; cv=none; b=rG+ZGf9IaJRFHZXuqMPlR3Z7/tTklZUJcHHuYRVzq5OXSWrPiAkhoBaiShV4pXKkTK3Kdn BRw19yFy7lZSalkfHPTAlmODAyAQ9emaHDb1YQIxBDVNyVikrYwKpUP9Xd2hufivB6YHsi N2mb8AdOInM3k4B47i+nTBSYhg0o7G4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Sd+c9faY; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Xkqa1QfF; spf=pass (imf21.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6DB7C5C0085; Wed, 14 Feb 2024 17:04:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Feb 2024 17:04:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948276; x=1708034676; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4 ZJxJN83A=; b=Sd+c9faYu7Kd229fSoKw0355HFCsVOXAmbPELIaKX/YxD+WxFDY vcGu+NgtgbpHDMFUrsbUSZUxVxKA8uI0/9CNsL0iziGpjnnv2gxQ7DXjjQN4ya4V 34KuyW0R91ZbLMbqMXQ0scp6jhEGZoha+V5eJkqGcjWOHmEXB3qtrgPl5Sb6BKzn Oqif52IBUC9w/4mZxLPB512uluRfD95IFp4J/Db8JJKKSEHbzuf8Jbo60T1kW2T9 TuQXp+qtRaWVixfnb1fRQYifBirC8HUdBkOF7NLqhN+2Nb/mY3ha6ovbk1oFJlSL GdOObLz0w9rXa3thQec+12QdRyBIAheVe2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948276; x=1708034676; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4 ZJxJN83A=; b=Xkqa1QfFUJAP2Oc2PqL9OOQdKTWF4TU8hECtytbueECS/aK02jW xQVPmuwXdxW4dQ8F5llHdSDxXHuTXjeG/UTWq0BOX66FyAc/DDPmuox7konafdnm 7U4YRpsJCBHKz567H7o514UxXn7E8ZCQtEx8p/QdWRnGK8zf5BLrU9zw4HLL+dkF qMuqV/fEm+gii2q0jN+utvOcl7cfBx83lwg99A6Ss7O8GO2Qy1PSozvGolw7Z5+n viw2oV8U/nMSuKkCHI7kYTiRpPKKaVURc819sW3+gb/kSIQAQonRnamZgUWpE6TY Ql7EgqEWwIvn9kDvQLB/jmeZz7a1BaiFgDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:35 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 1/3] mm/compaction: enable compacting >0 order folios. Date: Wed, 14 Feb 2024 17:04:18 -0500 Message-ID: <20240214220420.1229173-2-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: 2E1831C001C X-Rspam-User: X-Stat-Signature: xtbt788foi4iw7s6fk5nxzikc64eicyk X-Rspamd-Server: rspam03 X-HE-Tag: 1707948276-683264 X-HE-Meta: U2FsdGVkX1+DChFsinRut3Z2J4hFRGWDfOiGfDJlp2ciOTMNui1MFITliIp796XvfwUp2qF2lxKO5NXRvrvpaJUkkGLXrn4iNXiSHfz5TbfS0yGDiHoFQ8eij5S1W0DdlpZ0jRItTpOki9KmkkfPVmfWvWT/snXsvijd04iPp5Lldvio5v7EhUW36uNVY1IE5iYxZinrSyoEzDdZGbfXYbnmYEj8qMyax2GmIM0AfXJUlLGbXVWJMVBlkcAyfBAJ1s5MDC28odcVnwDiJhSPTykRrKiMrAa9o4YT88Y0TrAq6pw3qTKg3AVOywO5+l7BhVWOjmoEXjrINZy2Hejq/5qpf1xVMiqAoMKTrQLlCz7yySDu63pnh6UhBFHkxbwNDthKj42eSXlnotHYnsQG4QMVgTeo87gWpyMw4HdzYZshfRcSzzBPSS8hDC6ugj4gWmOBtH2oaLYq3YUKkBvRFyBMrDGcwMSEOLb6ZEOMF3bkjsoz2Hzq3Ey3IfRQz6CFpTgbfmA4rNruqFVkAPWDCpOV14vsmyF0JEnTfrP+KThmM90ndYCuPFHOh3KUMvssG3tk0/psrsp6Y9RDVgIUbRwZ/1Z0rGiaXe7Y9GSZ/zXSwbQPSxxNX/92ZVh/h5WttLGOm0Oh2UvMx/utHknWScnSn66GgbMNe7SPqkP26aY6GGnNQntruF1LGnPAEJUrpmfb4d6JT8szjBL6ALXkDDCr9nX7TnIMeIrzWNGajf8pSs2myjw2GDa2VkKjJ9KH/y0BUUKV0rVRgYyxF4SM8hK7oSNZSrT5RiQe24IZaUa1/XP+R/RgwMJ2abGom6VfgtPfSyWTqdmKYCSzU28LNCwnmRs6uOtynDZ5k385Ih6rsuBu/3Lcjdb+L1Z5CCBvedG3vpL1ZtO4tbrKsc3FvAivNyIkjCBvXYFcLTf18nugIeLNLUTs/LV1/WdXI/XoA1p2iiJtVYdB9GFQlwo AN9Ko36Z QKWNm7JZquo2902x1pdAQF6MtiBzd80JiWL0XJPQRyWbi2KnZ5MGBhpaL/6ap2SHNABCGPbm4Z0nvPJGDrs4SE5N1qJJC6C8ocs6oyk5oLtIWJsIAntK9yjZ6ytI+5VJZkfGAK1pcvwChAgOLc3JoTHW86qciZBj/OBFO87r7t6OY9GBMegQdltdlYIEJ7z7NgFhL2fZXsV1UGc9hfeJlgXH+mCH6YqZQOaONywLfu3M5iPQRiZVGwq1A2CPOdmHst7IMzt9M1mZfLcVLRm043Ak84BMebTW5c/3y/KKzPKLju2AOdQWb1Ili219UT+Bg4i+LKiD9okpVhVQvELdGWDS/M9ptWgbtfr6Jwvwf2pPuFY625C8wbQv0lL99Oni0BQacybPwHYPdD6ZC7glrFUmIpB8GbHQTwmvfImcPywk/tDDHIkuMSTECoxP1zI+zqnBt3ozQTF6jzBStLUBkPFusFw9dNdX8kLzVyBkeZkdqYHs4mjSA2TcEEn7ywMWmQPBIAasaSFsPJIj057AcVsF5DTIEAeb2RAzbnLwOkonJBLOJCXUSPHybvwiUCT7vSK8/5TmahrKYB11OR0wfC8DkQYm9a+kbvkKCrheKrB1GlDBGF8gMs000GverMAFq6UR8Lc9k8OCrNc0ktDgjQzjQAOz9LfEL4Bz3Yk7/8gJFezn23fiyHWnMLeVSWVnD2aUPzPBzVybNY926zYMA0JBvRSG8tYJun2tncJDgSrclTm7sRKIwV3KyfKRZpe+/lGEuUbUE659w7q09xKL/fN/sRH7R8xEEdxsroT2CljwzXAez5i/SCNO6umJtTnp64aMjPIYGN3U2X08wsVgGF+oQlRlukUjcbFHmUX2T4fIRVCXAvo19DodTsPISPTorxVW2QR0o23p7mpTbGnvVY/JNxvqmV1VLiMj7NTb1NGpQibBFuZAtOA4VwZVl9kpq73lpf4EOxbU+yTO9mqmWP7zGG0/a +ZnLROHF Eoi8tw0HIwWT3uHYKrR2HckT7PkhEwDLNDfeHIYHOac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan migrate_pages() supports >0 order folio migration and during compaction, even if compaction_alloc() cannot provide >0 order free pages, migrate_pages() can split the source page and try to migrate the base pages from the split. It can be a baseline and start point for adding support for compacting >0 order folios. Signed-off-by: Zi Yan Suggested-by: Huang Ying Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 66 ++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 52 insertions(+), 14 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index cc801ce099b4..aa6aad805c4d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_control *cc) return too_many; } +/* + * 1. if the page order is larger than or equal to target_order (i.e., + * cc->order and when it is not -1 for global compaction), skip it since + * target_order already indicates no free page with larger than target_order + * exists and later migrating it will most likely fail; + * + * 2. compacting > pageblock_order pages does not improve memory fragmentation, + * skip them; + */ +static bool skip_isolation_on_order(int order, int target_order) +{ + return (target_order != -1 && order >= target_order) || + order >= pageblock_order; +} + /** * isolate_migratepages_block() - isolate all migrate-able pages within * a single pageblock @@ -947,7 +962,22 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, valid_page = page; } - if (PageHuge(page) && cc->alloc_contig) { + if (PageHuge(page)) { + /* + * skip hugetlbfs if we are not compacting for pages + * bigger than its order. THPs and other compound pages + * are handled below. + */ + if (!cc->alloc_contig) { + const unsigned int order = compound_order(page); + + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; + } + /* for alloc_contig case */ if (locked) { unlock_page_lruvec_irqrestore(locked, flags); locked = NULL; @@ -1008,21 +1038,24 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * Regardless of being on LRU, compound pages such as THP and - * hugetlbfs are not to be compacted unless we are attempting - * an allocation much larger than the huge page size (eg CMA). - * We can potentially save a lot of iterations if we skip them - * at once. The check is racy, but we can consider only valid - * values and the only danger is skipping too much. + * Regardless of being on LRU, compound pages such as THP + * (hugetlbfs is handled above) are not to be compacted unless + * we are attempting an allocation larger than the compound + * page size. We can potentially save a lot of iterations if we + * skip them at once. The check is racy, but we can consider + * only valid values and the only danger is skipping too much. */ if (PageCompound(page) && !cc->alloc_contig) { const unsigned int order = compound_order(page); - if (likely(order <= MAX_PAGE_ORDER)) { - low_pfn += (1UL << order) - 1; - nr_scanned += (1UL << order) - 1; + /* Skip based on page order and compaction target order. */ + if (skip_isolation_on_order(order, cc->order)) { + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; } - goto isolate_fail; } /* @@ -1165,10 +1198,11 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * folio become large since the non-locked check, - * and it's on LRU. + * Check LRU folio order under the lock */ - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) { + if (unlikely(skip_isolation_on_order(folio_order(folio), + cc->order) && + !cc->alloc_contig)) { low_pfn += folio_nr_pages(folio) - 1; nr_scanned += folio_nr_pages(folio) - 1; folio_set_lru(folio); @@ -1788,6 +1822,10 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + /* this makes migrate_pages() split the source page and retry */ + if (folio_test_large(src) > 0) + return NULL; + if (list_empty(&cc->freepages)) { isolate_freepages(cc); From patchwork Wed Feb 14 22:04:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13557108 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4D7C48BC3 for ; Wed, 14 Feb 2024 22:04:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B62C18D0017; Wed, 14 Feb 2024 17:04:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B12738D0001; Wed, 14 Feb 2024 17:04:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C3B8D0017; Wed, 14 Feb 2024 17:04:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A5EC8D0001 for ; Wed, 14 Feb 2024 17:04:40 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5C1791404E9 for ; Wed, 14 Feb 2024 22:04:40 +0000 (UTC) X-FDA: 81791789520.23.6D2E1F2 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf09.hostedemail.com (Postfix) with ESMTP id 29C96140010 for ; Wed, 14 Feb 2024 22:04:37 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=JBDJWFY7; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Syr7Aizs; spf=pass (imf09.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707948278; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0yZlCI1Ab0=; b=I9BcirxXEVqixG0wPJ0FSNnvshm4W4lyadgzUuP7tpDBwa3g50MUbz8VMNkl1qQwp8BD31 fBUyCWdtj2/P8oZSEw8I8VDA+unHADMulTpC3I81RSrhOQbJJQQmCKpja5oU+uwU2n3Lwt Jtqg8kLNXOksFuVWcpLCFG2myXOdzHI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=JBDJWFY7; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Syr7Aizs; spf=pass (imf09.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707948278; a=rsa-sha256; cv=none; b=KEzNnmeL9+Ju8bMcSq+K9GaFxvTkke0ljXbkH5Te5rggXaebXO81mExhEYorSyHSCQFVN3 hh826hGE3MI7p3WhbjiHbwjgOW89Gkn1NGRBbp5vXgqmj5hj6FmOCoAHxhPhN+bDEtw6OC O737W9JCK/6UrFihhPwj8rawwfxuuDM= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 66C8C5C0087; Wed, 14 Feb 2024 17:04:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 14 Feb 2024 17:04:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948277; x=1708034677; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0y ZlCI1Ab0=; b=JBDJWFY7p7n/L8+ggyhC1OFPrK0sll4mus15uuuCFxLyN4x1dfS wT9D2uAhpYZkNA1h7pE7qSShC1dnX4ZXyANvl40VK6um7a2dItNOHdEo2sprHZje O6TbRba0xai5Ce/1rtfHLbCtN5XupC8OgpJiakkbyTqObcv8Jic/rIJUzkKP7mrN Ob19YIpwQ2pljVF7fjhYBBPPubTa2BuuMb8fD9rAoBDzgSjPhru2yhrJw9Bm+/m3 Z7wueGRCNrGWflCNlHlUMbvzpCY+Jig/4df8VYHIn4OPWtSMWDLp5Q3BcmqocXhE ObtoA27LX586bXn272J1HOhzAkzzT/yZVnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948277; x=1708034677; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0y ZlCI1Ab0=; b=Syr7AizsUQV8PlY0WaGklQNr48lOFnqElp1+dGba+UdIZvkXyYM 88NYt9kW0hRJb99t9LEuzhmY6ZeqxsiQp+CcOIlB9YgNOjxLYBmrJPfQPpj11HC4 +QmwtOuk2DOXRN+vegbCXpGUwwWFW9e7gNJu+ITTUoL11lfg4y780K1RzytuTZ/o k2H3GEKFC6/rtJ44RlGz+lQ0n7dVcMkV93GA2RG7alTr3QWyjdkeZ3+Hvrf7mJ3u 0P5Dut466Ks75wIuVhQv/eRIN06Tv+l5mdCrZe4RLa9zPnz2AlZZ9NMdN+56Mu0l g+8PA5W9vYgiVFV1WaX+1IUMfWM/4vGAUUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:36 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 2/3] mm/compaction: add support for >0 order folio memory compaction. Date: Wed, 14 Feb 2024 17:04:19 -0500 Message-ID: <20240214220420.1229173-3-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: 29C96140010 X-Rspam-User: X-Stat-Signature: g4mhtephzq73uq3p7mfea49mfs4d13sb X-Rspamd-Server: rspam01 X-HE-Tag: 1707948277-827667 X-HE-Meta: U2FsdGVkX1+EcCwY5s19NtrTAbeo7egM/HI+3HACKwqVknIG2L3am4POik5bB3ApbhX9in0zF+Q0LdRD+CUdrM2Y0O4MpFlW1yQ6+wRAmdWzRvzzmlQrc3wa4riFhodl+PHA5O0OzG55tDLaHBXG2k7jC6T68Khs/TjaBRCLHt9tAQumUHMDE9165jsXElqOJOoaLew8OF0YbQNbsXW12jOIb9H0K+IQ2nrKKQIHz/Hy7rbKdfJU+ccvaswmYHAKszhgK17yY1I8jTsVEEgTbpskA9lGyXJ/W+V/XKNIQ+LjayKr+Usej9vvgpQScJC3icrVgPdC2KzhdUiDZGkmLXwWxZzmdnxWG7Y6pncWr/DZE+mmUUgvqtfViHmcqeyKdXegILxYBXJZAx1V+8Y6KCeqg28+e0+L1r/pOBUMZLUNRnJ0JeYjui+VYxgWye4naMzKjdeW5ZP+MkbkkV5saFCVxJ/1iWVNWS6O6nHYGl55JzUHDLQjjLaDaVvHSBTKp71GCRSVVIwfe1SlWG+4pEy+DfO29IxFKGydHfUFp7b7k/aIKoDPSvTGn54JPvuTIUXBk4HG9fpfjMlK7gZk/ij4g/0Dz1ofIYIxWJSbP6tBITs+gl9hWe0CNBG+wdnBobgbOwbXwqaUrMYa7AYqqnLHY5m43DYSpfptlW1ruaPgWFWfQvywpSfLwze7W5HF4NXoFRR3iC7WP+FuW9CIyVoLEo8ZfE/cTVqNzsk9oShwac7CQdnJWooBRnMIR4v/Z/oIVzFbCVc+FfT7HhhdbOZb5TKut0jens2YzJLTw2amfuO0xFbPuQ8smEtx6FcEVyc5tmGOMpzqLI2XN38049qJxT3aarXOusaPXX7WPY4/l7SV1MNr5GIR2vlgc2/3QD/fLOo+QcdtOiYkYs9DbUpLYeWnP0phXOCjBeBp78x/edeFfF4aJ06N7g+QeoU/CnXLOoaxYA4+KZR2dhS x2EvNwHL 9H1fHHY2mSEXtXkL9b4mjey20WcQHsqDB8X34vej0ha3CRHvNDIst8aX3LVtuQfy8dNrM5dHTpyditMDg+dQ39yc5zOTPFzI6r4NXTVRUH7sKfli6dCQ/tPdrIz5AkdmFAKysCZ1u/8E6tFlnBN80lKoptRrTNnZ7gty4b2xc5+iGgRavc9CZoHDctW0N2SUqxb2bMANlHTr2QJ/LaQLQRHGbKK0fJzfYN8RF4Yr1ngMyAD9F+RG2Wegy/z7aZWl+TyU8Imq8+MWku3HdP3blSPo9NR8LP2j7FyxHldM6ydYjjqjiSGVV2xRGnI7/+gIOY1Zhpk1w4hkSKRKFiBmrHkAWOcNuYINNkLchREHNQIfx1BI2B+mlRF8vKI4DN7Jmo1zeU7jl3MP8MhhfgxP57NEGRS3eQ92QJIPAGj6EVBPv/zsITxwYKvX2ztS/d1ekho1oq8n+yAV89rjnPZ/V/SuLWGvvkklEH4ks4SAaGwvdwSmG1A/vQPwFSVSvNez2njhuksw+z5xMlQb/kz37sTm3N3uTxEKfpWRwidZIOoxJMPSYVjU9KyhkbLxZwsxgtEEBqpygRuvbEV4/mfz35532tKs+fEHy9dImhzkUUJJeOYAP9SOACizSeTD3MKPQB/q6qsNjZmr/5k6t/CalfBp6hF84YPSlLMWLtyEkdDGIFI3bNVnfiK69Vd66bkB8Ed6YivTGzBg+XEkoj77vrjrzbZvU8/3skhVx/PQCbw8m9ybpYRioYaw4qVyw4BJOZvuC43iC4HpWHC0z+p7rVUbxx8q4I5HV9f/stCQrVKnf+CViHs+kUi+XYEbRTWvWYAuIi0ObBq1cPhr5BvqT9UGDoGre2EO8MMScXxnh0m12zCY3oa/zT5FB6sIav4BDg+qdGDjWdfnFwKvl5ujQ5r6RMD2/f3+ZWewL04fbPmYgvgM1v4IYqaBwZEWWx7qtvwevchMx5/ZDIXj30mkB4PT+xhc+ ALHQTGG/ h/uFJAisV1KaVQuQgWDCJdm/Oe69jzO+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan Before last commit, memory compaction only migrates order-0 folios and skips >0 order folios. Last commit splits all >0 order folios during compaction. This commit migrates >0 order folios during compaction by keeping isolated free pages at their original size without splitting them into order-0 pages and using them directly during migration process. What is different from the prior implementation: 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page lists, where each page list stores free pages in the same order. 2. All free pages are not post_alloc_hook() processed nor buddy pages, although their orders are stored in first page's private like buddy pages. 3. During migration, in new page allocation time (i.e., in compaction_alloc()), free pages are then processed by post_alloc_hook(). When migration fails and a new page is returned (i.e., in compaction_free()), free pages are restored by reversing the post_alloc_hook() operations using newly added free_pages_prepare_fpi_none(). Step 3 is done for a latter optimization that splitting and/or merging free pages during compaction becomes easier. Note: without splitting free pages, compaction can end prematurely due to migration will return -ENOMEM even if there is free pages. This happens when no order-0 free page exist and compaction_alloc() return NULL. Signed-off-by: Zi Yan Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Huang Ying Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 143 +++++++++++++++++++++++++++--------------------- mm/internal.h | 4 +- mm/page_alloc.c | 6 ++ 3 files changed, 91 insertions(+), 62 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index aa6aad805c4d..d0a05a621b67 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -66,45 +66,56 @@ static inline void count_compact_events(enum vm_event_item item, long delta) #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) #endif -static unsigned long release_freepages(struct list_head *freelist) +static void split_map_pages(struct list_head *freepages) { + unsigned int i, order; struct page *page, *next; - unsigned long high_pfn = 0; + LIST_HEAD(tmp_list); - list_for_each_entry_safe(page, next, freelist, lru) { - unsigned long pfn = page_to_pfn(page); - list_del(&page->lru); - __free_page(page); - if (pfn > high_pfn) - high_pfn = pfn; - } + for (order = 0; order < NR_PAGE_ORDERS; order++) { + list_for_each_entry_safe(page, next, &freepages[order], lru) { + unsigned int nr_pages; - return high_pfn; + list_del(&page->lru); + + nr_pages = 1 << order; + + post_alloc_hook(page, order, __GFP_MOVABLE); + if (order) + split_page(page, order); + + for (i = 0; i < nr_pages; i++) { + list_add(&page->lru, &tmp_list); + page++; + } + } + list_splice_init(&tmp_list, &freepages[0]); + } } -static void split_map_pages(struct list_head *list) +static unsigned long release_free_list(struct list_head *freepages) { - unsigned int i, order, nr_pages; - struct page *page, *next; - LIST_HEAD(tmp_list); - - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); + int order; + unsigned long high_pfn = 0; - order = page_private(page); - nr_pages = 1 << order; + for (order = 0; order < NR_PAGE_ORDERS; order++) { + struct page *page, *next; - post_alloc_hook(page, order, __GFP_MOVABLE); - if (order) - split_page(page, order); + list_for_each_entry_safe(page, next, &freepages[order], lru) { + unsigned long pfn = page_to_pfn(page); - for (i = 0; i < nr_pages; i++) { - list_add(&page->lru, &tmp_list); - page++; + list_del(&page->lru); + /* + * Convert free pages into post allocation pages, so + * that we can free them via __free_page. + */ + post_alloc_hook(page, order, __GFP_MOVABLE); + __free_pages(page, order); + if (pfn > high_pfn) + high_pfn = pfn; } } - - list_splice(&tmp_list, list); + return high_pfn; } #ifdef CONFIG_COMPACTION @@ -657,7 +668,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, nr_scanned += isolated - 1; total_isolated += isolated; cc->nr_freepages += isolated; - list_add_tail(&page->lru, freelist); + list_add_tail(&page->lru, &freelist[order]); if (!strict && cc->nr_migratepages <= cc->nr_freepages) { blockpfn += isolated; @@ -722,7 +733,11 @@ isolate_freepages_range(struct compact_control *cc, unsigned long start_pfn, unsigned long end_pfn) { unsigned long isolated, pfn, block_start_pfn, block_end_pfn; - LIST_HEAD(freelist); + int order; + struct list_head tmp_freepages[NR_PAGE_ORDERS]; + + for (order = 0; order < NR_PAGE_ORDERS; order++) + INIT_LIST_HEAD(&tmp_freepages[order]); pfn = start_pfn; block_start_pfn = pageblock_start_pfn(pfn); @@ -753,7 +768,7 @@ isolate_freepages_range(struct compact_control *cc, break; isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, &freelist, 0, true); + block_end_pfn, tmp_freepages, 0, true); /* * In strict mode, isolate_freepages_block() returns 0 if @@ -770,15 +785,15 @@ isolate_freepages_range(struct compact_control *cc, */ } - /* __isolate_free_page() does not map the pages */ - split_map_pages(&freelist); - if (pfn < end_pfn) { /* Loop terminated early, cleanup. */ - release_freepages(&freelist); + release_free_list(tmp_freepages); return 0; } + /* __isolate_free_page() does not map the pages */ + split_map_pages(tmp_freepages); + /* We don't use freelists for anything. */ return pfn; } @@ -1494,7 +1509,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) if (!page) return; - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); + isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn == end_pfn && !cc->no_set_skip_hint) @@ -1623,7 +1638,7 @@ static void fast_isolate_freepages(struct compact_control *cc) nr_scanned += nr_isolated - 1; total_isolated += nr_isolated; cc->nr_freepages += nr_isolated; - list_add_tail(&page->lru, &cc->freepages); + list_add_tail(&page->lru, &cc->freepages[order]); count_compact_events(COMPACTISOLATED, nr_isolated); } else { /* If isolation fails, abort the search */ @@ -1700,13 +1715,12 @@ static void isolate_freepages(struct compact_control *cc) unsigned long isolate_start_pfn; /* exact pfn we start at */ unsigned long block_end_pfn; /* end of current pageblock */ unsigned long low_pfn; /* lowest pfn scanner is able to scan */ - struct list_head *freelist = &cc->freepages; unsigned int stride; /* Try a small search of the free lists for a candidate */ fast_isolate_freepages(cc); if (cc->nr_freepages) - goto splitmap; + return; /* * Initialise the free scanner. The starting point is where we last @@ -1766,7 +1780,7 @@ static void isolate_freepages(struct compact_control *cc) /* Found a block suitable for isolating free pages from. */ nr_isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, freelist, stride, false); + block_end_pfn, cc->freepages, stride, false); /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn == block_end_pfn) @@ -1807,10 +1821,6 @@ static void isolate_freepages(struct compact_control *cc) * and the loop terminated due to isolate_start_pfn < low_pfn */ cc->free_pfn = isolate_start_pfn; - -splitmap: - /* __isolate_free_page() does not map the pages */ - split_map_pages(freelist); } /* @@ -1821,24 +1831,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + int order = folio_order(src); - /* this makes migrate_pages() split the source page and retry */ - if (folio_test_large(src) > 0) - return NULL; - - if (list_empty(&cc->freepages)) { + if (list_empty(&cc->freepages[order])) { isolate_freepages(cc); - - if (list_empty(&cc->freepages)) + if (list_empty(&cc->freepages[order])) return NULL; } - dst = list_entry(cc->freepages.next, struct folio, lru); + dst = list_first_entry(&cc->freepages[order], struct folio, lru); list_del(&dst->lru); - cc->nr_freepages--; - cc->nr_migratepages -= 1 << folio_order(src); - - return dst; + post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + if (order) + prep_compound_page(&dst->page, order); + cc->nr_freepages -= 1 << order; + cc->nr_migratepages -= 1 << order; + return page_rmappable_folio(&dst->page); } /* @@ -1849,10 +1857,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) static void compaction_free(struct folio *dst, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; + int order = folio_order(dst); + struct page *page = &dst->page; + + if (folio_put_testzero(dst)) { + free_pages_prepare_fpi_none(page, order); + + INIT_LIST_HEAD(&dst->lru); - list_add(&dst->lru, &cc->freepages); - cc->nr_freepages++; - cc->nr_migratepages += 1 << folio_order(dst); + list_add(&dst->lru, &cc->freepages[order]); + cc->nr_freepages += 1 << order; + cc->nr_migratepages += 1 << order; + } + /* + * someone else has referenced the page, we cannot take it back to our + * free list. + */ } /* possible outcome of isolate_migratepages */ @@ -2476,6 +2496,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) const bool sync = cc->mode != MIGRATE_ASYNC; bool update_cached; unsigned int nr_succeeded = 0; + int order; /* * These counters track activities during zone compaction. Initialize @@ -2485,7 +2506,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) cc->total_free_scanned = 0; cc->nr_migratepages = 0; cc->nr_freepages = 0; - INIT_LIST_HEAD(&cc->freepages); + for (order = 0; order < NR_PAGE_ORDERS; order++) + INIT_LIST_HEAD(&cc->freepages[order]); INIT_LIST_HEAD(&cc->migratepages); cc->migratetype = gfp_migratetype(cc->gfp_mask); @@ -2671,7 +2693,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) * so we don't leave any returned pages behind in the next attempt. */ if (cc->nr_freepages > 0) { - unsigned long free_pfn = release_freepages(&cc->freepages); + unsigned long free_pfn = release_free_list(cc->freepages); cc->nr_freepages = 0; VM_BUG_ON(free_pfn == 0); @@ -2690,7 +2712,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) trace_mm_compaction_end(cc, start_pfn, end_pfn, sync, ret); - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); return ret; diff --git a/mm/internal.h b/mm/internal.h index 1e29c5821a1d..9925291e7704 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsigned int order); extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int order); + extern int user_min_free_kbytes; extern void free_unref_page(struct page *page, unsigned int order); @@ -481,7 +483,7 @@ int split_free_page(struct page *free_page, * completes when free_pfn <= migrate_pfn */ struct compact_control { - struct list_head freepages; /* List of free pages to migrate to */ + struct list_head freepages[NR_PAGE_ORDERS]; /* List of free pages to migrate to */ struct list_head migratepages; /* List of pages being migrated */ unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7ae4b74c9e5c..e6e2ac722a82 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struct page *page, return true; } +__always_inline bool free_pages_prepare_fpi_none(struct page *page, + unsigned int order) +{ + return free_pages_prepare(page, order, FPI_NONE); +} + /* * Frees a number of pages from the PCP lists * Assumes all pages on list are in same zone. From patchwork Wed Feb 14 22:04:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13557109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12ACEC48BEB for ; Wed, 14 Feb 2024 22:04:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129C38D0019; Wed, 14 Feb 2024 17:04:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DCBC8D0001; Wed, 14 Feb 2024 17:04:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94E28D0019; Wed, 14 Feb 2024 17:04:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB1428D0001 for ; Wed, 14 Feb 2024 17:04:41 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 827651A05D4 for ; Wed, 14 Feb 2024 22:04:41 +0000 (UTC) X-FDA: 81791789562.07.DA97078 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B8BA4001B for ; Wed, 14 Feb 2024 22:04:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=TYVPJiuB; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=HqHud2bg; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf12.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707948279; a=rsa-sha256; cv=none; b=edcThI2P/QxyshD2OMg5X4xFanHdWlqkju6uQkfpGy6xvZ0vXDPQ2hRpeBl3p0G1B8wEmA Dya3h7muPcztbGi0RtxMUsX1IlZCvWkrmTgIJkzvlTSP8Hzip+swPBtFI71wUEpuDWbQ6p /imO2xtNzwL424lmOZ/RPnSzAHhfKdM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=TYVPJiuB; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=HqHud2bg; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf12.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.28 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707948279; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx3jsjH0ns=; b=3EKsFKjcgwW8yxrtN5RbMr+52Xk9gXfKOh7YEJhKocwIoCHzJOzZvrVX6vrA+N+C8vu3zr 6Oml4MlBtXJzClIl9p6VaRtbHbpEOEb3A1Zb9pffxcl8n0XHhd6YCWx/aI03xuap0Rxk4C JL1g7Iji9Xj88oywgqBXtdFIKM/UZ/c= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A39FC5C0086; Wed, 14 Feb 2024 17:04:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 14 Feb 2024 17:04:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948278; x=1708034678; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx 3jsjH0ns=; b=TYVPJiuB1JXeQIw8A86L+E6UEI1u4J6XAa1bTxbdRDxlLKK6T9f 1SKgzazMOLcJAFUvzSSe18CwB8JAk2lGIinVMXUswOyaPYyU9MKcZ/0gUG64DlE+ iotkdloZi8W6SU2CDx3DdY7EyzM4xvyJVxZZXLb5ff1heJw+9iG2AHeNEz3Vm3lj KYJcFrSuBUbv53jyQs8E7fCmqs9LxBVjqDdldFm5CkZF1muz32jl8CoUn1UbTF70 Hpfr5MD9QtU/YpuKYeeNKkTfxw9sVc1pVyr+UFOYioNEyEBUrSfbC7kgo2FHy2eA O++9ITQ1VvlZC0PuQw3c7pKO3pQV4eCgbeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948278; x=1708034678; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx 3jsjH0ns=; b=HqHud2bgtxbuleg7JIQcX/6DijCsT84RWDVT6WNJueqIH8OoZz5 QHc0wZ5e0+c0P8e1gDZj/PLns77lLJU3OurXalw7lsCU4Ozff3kzIBlFICbROKz5 Wr63YF3Tp0rb5FvwOHBYA3QDMQpVhypJkSEx/uO5DTSDYRpsgdmNIP3pslQiQaDX R7ja2MceSRwLgMR0gMRqB/E973AYvLWD9U7gB4OECl3nI5kGjlQtFHMREofZCpAt fMzWhn4bnRDdT0k6lOwItkdiP264YIQXALVJgNDiwRHlAiyu1Ka+tknWutKzxjcG aEzhxaMbrq/v1MZr5B2/dFn5qCJbKuW35jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:37 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 3/3] mm/compaction: optimize >0 order folio compaction with free page split. Date: Wed, 14 Feb 2024 17:04:20 -0500 Message-ID: <20240214220420.1229173-4-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5B8BA4001B X-Stat-Signature: 4owi37f3oyu1jgk4wwkwmwxg66rgxx7q X-HE-Tag: 1707948279-304595 X-HE-Meta: U2FsdGVkX1+kvcmKEddJshSay4AVaKDOfxxnWrkOMfeezZBDErcdIQ28yhhJ0oOAuGEtsKrNRwHCjHaDh0FnGzIYjdsmTwGSQczff4VWD9Ab9pvbMIM2VfS8nee6yp5oydTBSpH7t4gkCbkP2o8Z8TcbnPEzLH+ljgrJvhIRLcCNz62x/TN8eL7QZxcw3GkCFdSH9UKtc11E9k3fleS/qLEx0W3cTuDI96xia+1UjiAuU1TkflgfGtC6UO3nRt4ixdZJKlruGFuQm3GZDL5UJcxJxRp8p/RLMEbLPbJune2jlmggAd+HNZjyJvkivTKDNZj3tnJUeldZcr5gYFpwebnYdvOYenXh5iJa0DT38h50VaYlEiEtjgKbHEHESfiFjbeZrQ0FhT+g8eJNeAlV7vwQRB9wK1eHFQ/huJu51NSG4z/Pysl1NHOLRy2RrfZAvY9nloGAMkxXxo0YBdC0motPycvSA3olo+qMnjfCMD1qWuTHGdH40ZVz16s50nLJwTJHi0xVDS981aEqKLeBgy5mOYWVbJxP5iBXPdRRxQeLykoYUn2+G6kwTeImaNToios9WCX0tCSrOIi0T67SbgKGdY09jwpCtLPmrUjoGYN+ru8gz/CkCex32ApPbeVnTqrPULRjt0+yZYL168yJSZObUycq8aDvrv95tMlJosgINUpBK6fI9aXzXQ+AS46WlhhtOVERNg/HhLUZTpia2nW4pdroR6mI1a85T2tv7+gOigqXs8MD41xKxZxNLRM2cpNEx1xN4XM6uTNyRR073oCKtxHLRcpDKEkSDHerk4BefXn3y9HOq4GZrRYPDR5XD2j3GPtGStrgTVWpbztg1o6lqSztiZ6cO5LNr/iMbcR2kScgWWTUUrgluAG8C9Ti3yQMKTEYziXWUMTEWNhEEiL1MBFr+DjtWkq0mhnxH6XRRINWLTkHFdZP5roU1d9TrHv/sI4iRl64rwVbRex LptNoGKJ moKtdR/kAkfqf2dh6n/lOBdaO8VoRJoq7O8KWZ3Pg8qgQcDb57VncXf8fBn5Oiau1tMPMOpOsHvsL1DxtlHiMBZFgdzWcJhEdpWFFTPB5XkPrr10dxrG0b60p8HATmOXvJ/Cx9Aag9txPKCtF3mkySLheMJtdKGdZ3oRRxWcdmUQmHt4BD3nqbMkYhHwh3oSt8JJKj/o4jhdGwWeYDQ8cvZxdZlvQ5DdxkktjO0Aeu/Tr7CWef9k7G9Hu/Ac7DQTPKG8ucuV3O4FOVuJcsIC5dUFJxaArcigDyu4n1sGlr7SHAxGRTqtHdMSaoOL9/i8QJ8aRzHxl2GqKV3K6jeM3Izxi2Ji56QLpeDXoL5iEo0T96gUEi8Snqzry7bMU64g+PceVpeiOMj5jplfEMN8x0MJo08ckDcIagnD7mEP0GpIlH/y9sSc2N+VTyPkXd157Y1KqkK9z41BdrmLDYxAd5JaFRuT8RRuW+G+ZVA5buoJBmCR8/N1+lc0hG25J+Y4e4jDOPL1vQNG7l596y+Kmi9ldoNaFA7xGqAdbBwpGc2+nwdlsrBRFZQVZEZgm4h0CD4YujwcFqSeJ7e3gGBCe3dOS0JBcmkhI47vnTNxMwPhhWQ9Q3zpvFti0d/Ok+wyGRlFHqAwEMStIAsdmm/IclmksxKPi9M63SMK4GtUPQqO6XiGhc5C7kXROauznKWUD9hKW+uxTzDp2ffO2AxgzIaETPu2yw42QDFmO+665OsGIp34LWRV0hdPu8RdkK8KQebLU/THZVTWGsjTjlHU6sNShsk/NkadmtyA1k5YBD670tUHEzwQYkEIpNX9Ma5sQfXKgPgzdM9i9IjkBONJ5d2b5mso0uTISpefrQmCnn/TaO15ZjvSdP9QLlM32HBdfn3NW65jtErP918NVZT1O5nRdt6z0/5IfFOSjuVI9MAcoKQJT6N+Z3IMEeqgFavl7QJVIAwb4/MsZokNjTYVrl+nYt1SD 4cStNqwu 8LlY2NyoLGAtSCimsVLTS5hBt8rPHb1D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan During migration in a memory compaction, free pages are placed in an array of page lists based on their order. But the desired free page order (i.e., the order of a source page) might not be always present, thus leading to migration failures and premature compaction termination. Split a high order free pages when source migration page has a lower order to increase migration successful rate. Note: merging free pages when a migration fails and a lower order free page is returned via compaction_free() is possible, but there is too much work. Since the free pages are not buddy pages, it is hard to identify these free pages using existing PFN-based page merging algorithm. Signed-off-by: Zi Yan Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Huang Ying Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index d0a05a621b67..b261c5f13bef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1832,15 +1832,40 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; int order = folio_order(src); + bool has_isolated_pages = false; + int start_order; + struct page *freepage; + unsigned long size; + +again: + for (start_order = order; start_order < NR_PAGE_ORDERS; start_order++) + if (!list_empty(&cc->freepages[start_order])) + break; - if (list_empty(&cc->freepages[order])) { - isolate_freepages(cc); - if (list_empty(&cc->freepages[order])) + /* no free pages in the list */ + if (start_order == NR_PAGE_ORDERS) { + if (has_isolated_pages) return NULL; + isolate_freepages(cc); + has_isolated_pages = true; + goto again; + } + + freepage = list_first_entry(&cc->freepages[start_order], struct page, + lru); + size = 1 << start_order; + + list_del(&freepage->lru); + + while (start_order > order) { + start_order--; + size >>= 1; + + list_add(&freepage[size].lru, &cc->freepages[start_order]); + set_page_private(&freepage[size], start_order); } + dst = (struct folio *)freepage; - dst = list_first_entry(&cc->freepages[order], struct folio, lru); - list_del(&dst->lru); post_alloc_hook(&dst->page, order, __GFP_MOVABLE); if (order) prep_compound_page(&dst->page, order);