From patchwork Thu Feb 15 22:52:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moritz C. Weber" X-Patchwork-Id: 13559231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92105C4829E for ; Thu, 15 Feb 2024 22:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2fjmFfErQT4+Sr5BPWDAlgdbGLYadeRATTZI286ZKaA=; b=ou9/1J4w6cc2FJ IfdiL70hVaQ/WGftc329deEnlK6D0ps9uB8wM7c4HJmk4r/lhF56G7Ovi4w6QALuKa8EQTt3+SM8d u5jm9IwUmFfzudBMpow/bKA52MOG/aMBYXYfcMvYLYcxbYtkuFReQ8t0fztGmIdnAYoKoP3V1WEGg JBSjNocrNnHpK5SfJwvj+sE5RrEHjWP10t5/TrYTi+fmRWc+s4undW1iEujH8V/BcJ6gcK2ZlfI7t wY3TJeR9KPqfxAE7n0wAYz3ryYD3y2Vq60Pdw2MPO0jWbO7SfQkc1nb5LEv6f02PJ1dHuETqG3+GU DElyqzgG8gDYHLDbSUHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rakbT-00000000OA3-2rIh; Thu, 15 Feb 2024 22:53:15 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rakbQ-00000000O87-0tLd; Thu, 15 Feb 2024 22:53:13 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a2d7e2e7fe0so266283466b.1; Thu, 15 Feb 2024 14:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708037590; x=1708642390; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dM/iULill3Uj1lqLW3ClBj2hmpKY1OGRqTHuq9SM0pI=; b=WxFen6UKAjOAWIabPdlGH2VF64CfjyjdDElyYCAezMXLCBYYGuGGzr7IP1yNsDlYuX pSl4Gp/XiVmURool66HrdB2IQv6tX0/Uyutan/3DIVCOGwyp0NbrmNFyeJafJywx380S w+tbxURzrGNZ3A+ykK4UEsNQy3QqnI/O7D0IknCeySIX9Ib6lYcrhEEzy6K1QHWYFbS0 90V42V2+Q1thVT8q/1NGxKpzm/Fv+vgBWKtAoC89NdyEnxIpteHu/2OmsRIkqQ3CtOyv LRasufQM/+DxuILAq/Lkg79OYoFxPFvJFggRRbTFtyCwUBlh134TR06CThD2VLgI4Y+k l0Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708037590; x=1708642390; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dM/iULill3Uj1lqLW3ClBj2hmpKY1OGRqTHuq9SM0pI=; b=BUMW2Z6me8FHNEdGWblLMIAyxjn6hqvNvm9Ac/LrwNoeifR22pcyHCZ034RzXqvaXk Nw8NtsurbZTjkYW5twAWtI25ZSqbMPrmW8K+tqLRgGu9XZ59+l+Glq9ht6jcwTgYDgvi b5cBn1VZSBHwbFFmfvj7s6LgcfjYp+Ojo3Dd399CgWbESExOZ7x0O7VkarqDiPvOeZ/9 WYV240SxFOdm1W6UJUeJYpd+984tDR/gL+vLmncqWakJShaCux7Uufl5wLv1b8GKbVCG eg19THHExdEOclsF4ofY2ldnDwWvbhfpDq0UhyAeWrKZIJ81WfHlkNSRZqpWEo6jFlMn WB4g== X-Forwarded-Encrypted: i=1; AJvYcCXovnnfiJ24kH6u/VAIiscgrHaVITGqoRfz0md9bmVHI4X2EPcLGgsR0L+b2BEOj/9DoTetpIxmURELHpFwqBhoSo4xkfLUEotRQStqV7ufZ9223PX7Jc5ykKAy9YfwSy43gDjrH8wQunTMsAe9AT3FVatDxTuuym5nNw== X-Gm-Message-State: AOJu0YxAtFcqps4pX2jFii5M09YET66ZTpYxWNAUQAN8mrPAAIwcpu7b m9TTyRZX8WKdV+eLfJr60vJ7HD88p+295llttUyJ6zcVkpjB6Jzs X-Google-Smtp-Source: AGHT+IHhX9TEWUB84SFRhuZNXr7KhVPFBUH31IMkj66V/NmQ7Seh5e4nlfDjHV17LK9b77QMCKR7cQ== X-Received: by 2002:a17:907:86a4:b0:a3b:ad02:98b1 with SMTP id qa36-20020a17090786a400b00a3bad0298b1mr6506310ejc.10.1708037590040; Thu, 15 Feb 2024 14:53:10 -0800 (PST) Received: from pinguine.lan (ip-176-198-146-182.um43.pools.vodafone-ip.de. [176.198.146.182]) by smtp.gmail.com with ESMTPSA id s6-20020a17090699c600b00a3d88bdf5aasm966467ejn.103.2024.02.15.14.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 14:53:09 -0800 (PST) From: "Moritz C. Weber" To: florian.fainelli@broadcom.com Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Moritz C. Weber" Subject: [PATCH 2/3] Staging: vc04_services: bcm2835-camera: fixed several brace coding style checks Date: Thu, 15 Feb 2024 23:52:49 +0100 Message-Id: <20240215225249.11010-1-mo.c.weber@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_145312_276215_E941BC21 X-CRM114-Status: UNSURE ( 8.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixed coding style checks raised by checkpatch Signed-off-by: Moritz C. Weber --- .../vc04_services/bcm2835-camera/controls.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index 6bce45925..e670226f1 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev, control = &dev->component[COMP_CAMERA]->control; - ret = vchiq_mmal_port_parameter_set( - dev->instance, control, - MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS, - &imagefx, sizeof(imagefx)); + ret = vchiq_mmal_port_parameter_set(dev->instance, control, + MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS, + &imagefx, sizeof(imagefx)); if (ret) goto exit; - ret = vchiq_mmal_port_parameter_set( - dev->instance, control, - MMAL_PARAMETER_COLOUR_EFFECT, - &dev->colourfx, sizeof(dev->colourfx)); + ret = vchiq_mmal_port_parameter_set(dev->instance, control, + MMAL_PARAMETER_COLOUR_EFFECT, + &dev->colourfx, sizeof(dev->colourfx)); } exit: From patchwork Thu Feb 15 22:53:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moritz C. Weber" X-Patchwork-Id: 13559239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25D2DC4829E for ; Thu, 15 Feb 2024 22:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=U8xhYvSOzTpZ7nRfZ3MMJE+0QI6rpKpYX4ebaDy7Ixs=; b=FyPQqQGizL8T+B Czrt9zByRWkBAGYrTnWcfZdS04FE27aYH0crTa/q7TuLDd+UNMyD5b2vvRFSadObYNJ7qdsWrU/NS 1jligEFyd9saELUucsYvAc/XVLngerjh6G/QRh1oxqtG5vvB3q8Nm4DtA3WxgwlTI0P6cpFAPMkqN 8XbdQeKIy0U4DA1eLp/bQeJnDwIoIGLIiCE7zsVq/7hGaoO1O2nbPS4DbXpCkhi3EZKUwOwFZZiv4 N9N0NG+OTAwX+rkBsq9ReIZWyOdGHd2c/eazW67a1Bm9Qp64bN71ld9QrkdHQSeU1guEKdnY1bAjC YyVMH51kd3cx3XhdF59g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rakcA-00000000OTY-49DM; Thu, 15 Feb 2024 22:53:59 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rakc6-00000000OPK-0AQ7; Thu, 15 Feb 2024 22:53:56 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5600c43caddso1699088a12.2; Thu, 15 Feb 2024 14:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708037632; x=1708642432; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B8uMPEt1VqqPCM4teLHLJiETOk2ZEgqVh3I3k6LiZj8=; b=P0Hi9rDKn+is0i4EgwshKKZKt0OhbLzXiH1seEYiY81+jiFNDbcMva3cRrZbmz8sGa qoGF/mCceREKb2QshihyCSE+8aTent8Nf5dublroUpUc3ACNR2zSiz/JMO+71o1J8MXb +qpb+LHyfaBkOyWNrbfQM3CY8lSDykmk+mEzpOJZqDOmXyLLF0Z4ZVTzhFMdFyHkFDME 1Jdp5V0raLDJ9V3oP1AFLLDlehBps/ftZ+/pw8U99gqLyWh7sia9cLaggMqvgBXRrU/3 z9Sau27X6ATSof4ysZ+DOfgdIyspGsV1tCkBYwxylpHarwWOGA5BsJJhnan9I6UChg7j RZvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708037632; x=1708642432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B8uMPEt1VqqPCM4teLHLJiETOk2ZEgqVh3I3k6LiZj8=; b=LF/Zg61sbfnSHYl22IvLXki9jrOJoMpSdEPVhLBJFYOqOtnMmEBannk32IjyWk6vGI 7conSTjJ7DXqXsqqzz/kqnLi4oqzYPmhAsxcMKZfcyiGtPoq5cSQHVjz52cFE/A/rXK3 SUwVEx0sJaycOb64RyuMPYByz5Ck6kWGn02vUwH9ol3rsHD0Av27QiEP9hGOzeGAvHGi rZ6qL0e9uPgk6bsqwr4fCU7zNzWoaG5YwUAvhvKVne8jYNJHu9BK13Abj9FbOEW6Bj9g K2vjvZEQNQU76ox1v/lLRF9EGgmOneZdkzu3NF/a5QmC6Gf2ixpnjxAFFaBxfJuHJAKj T8gA== X-Forwarded-Encrypted: i=1; AJvYcCVv1rzrI7TyJzRDLZwVu1J7XJqnXojbBKVV4DK8LnYRfyWu+AnLZXdbSKO1etMXsmw4qs3HMsm4fohFIyPtIADd2d1REl+//H8o4BHuvmROsic3hXME+PENoyCradpNYrpU1fygMgN4NBzaA3vdZFpCQE/mj1yJ+LyGyg== X-Gm-Message-State: AOJu0YwEFVI2QfNKn/QqqR57nc244fPvIuHhFsbFHIoTmqiT0hAB5GlZ qJsQ2fKTmlY3xFM73p+R5Xd2BvWLTs02n1iWGSAI1XjSerRmMKzr X-Google-Smtp-Source: AGHT+IFlo2ZFjZKkscUV0bL+SgznBaVctw2W1+GyDMpwF9cTad8lPj/HYGbYR4mHHuMLUSHvASiJHw== X-Received: by 2002:aa7:c149:0:b0:563:d042:4bdf with SMTP id r9-20020aa7c149000000b00563d0424bdfmr1041581edp.0.1708037631968; Thu, 15 Feb 2024 14:53:51 -0800 (PST) Received: from pinguine.lan (ip-176-198-146-182.um43.pools.vodafone-ip.de. [176.198.146.182]) by smtp.gmail.com with ESMTPSA id p3-20020a05640243c300b00563c22abac2sm650782edc.61.2024.02.15.14.53.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 14:53:51 -0800 (PST) From: "Moritz C. Weber" To: florian.fainelli@broadcom.com Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Moritz C. Weber" Subject: [PATCH 3/3] Staging: vc04_services: interface: vchiq_arm: fixed several brace coding style checks/warnings Date: Thu, 15 Feb 2024 23:53:28 +0100 Message-Id: <20240215225328.11141-1-mo.c.weber@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_145354_128113_35A55518 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixed code style checks raised by checkpatch Signed-off-by: Moritz C. Weber --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++--- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 1579bd4e5..c59bea191 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -432,9 +432,9 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel head_bytes = actual; memcpy_to_page(pages[0], - pagelist->offset, - fragments, - head_bytes); + pagelist->offset, + fragments, + head_bytes); } if ((actual >= 0) && (head_bytes < actual) && (tail_bytes != 0)) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 76c277781..5213f7c55 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -230,6 +230,7 @@ struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne return rcu_dereference(instance->state->services[idx]); } + struct vchiq_service * find_service_by_handle(struct vchiq_instance *instance, unsigned int handle) { @@ -1192,7 +1193,6 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service, header->size = size; header->msgid = msgid; - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); @@ -1618,7 +1618,6 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); @@ -1842,8 +1841,8 @@ parse_rx_slots(struct vchiq_state *state) int rx_index; WARN_ON(state->rx_pos & VCHIQ_SLOT_MASK); - rx_index = remote->slot_queue[ - SLOT_QUEUE_INDEX_FROM_POS_MASKED(state->rx_pos)]; + rx_index = + remote->slot_queue[SLOT_QUEUE_INDEX_FROM_POS_MASKED(state->rx_pos)]; state->rx_data = (char *)SLOT_DATA_FROM_INDEX(state, rx_index); state->rx_info = SLOT_INFO_FROM_INDEX(state, rx_index); @@ -2177,6 +2176,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s for (i = 0; i < VCHIQ_MAX_SERVICES; i++) { struct vchiq_service_quota *quota = &state->service_quotas[i]; + init_completion("a->quota_event); }