From patchwork Sun Feb 18 13:56:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13561859 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDEE86BFAA for ; Sun, 18 Feb 2024 13:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264600; cv=none; b=Ebp+7jOeAS98QWClW+Ir0TyEjWVvWRtCLvTw9E09P+Zqr/j9SKHG7MEvVatU8y4NlKdC9yzXu2XDmVCUEmKduvnnbZdDz0ShuthR34/rboyWO08yawLXDpKqDKV7wczAP+hb0C5kNdGp4WI0swPImwhQ5ySpNj2Z/XbeFI4cuF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264600; c=relaxed/simple; bh=OUfLfMEset8o73Jx8kovtS30aE9Ds0RnhHYqCvWeuGM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KkW+0H5Kp6KbOpgZUwj1YD1gCweApoV/oRvRNX/c7D2NIknJBO+tnK9ztsGvKBYgSqZFyIbEb1P9Y9TWItQzHF5uPsKsOta1gPIzx+8TMjp/Yp3WJ1PUeUgW8aeFwA0MosqqbX1JMof/Slq0+oTmuFfLbvPy8yQKY4rLpgC0etY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=POrB4Alt; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="POrB4Alt" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5120ecfd75cso4917029e87.0 for ; Sun, 18 Feb 2024 05:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708264597; x=1708869397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uqRBeYbyylaZ7PDbJp+J91shmKsfLHhb9CuS8+GePNY=; b=POrB4Alt2S7Nm6gPxRow50gBD1HhpA7OzlFHlnsVhdhu0WKogXw2lz3/oOX461Lqr3 vepWyjwS7SqKwXRJPkKkiSs85DUoCDhLzdzltvNCz4k8zCpY8DiEz96Z6+t3qRunvAAY 3BubE2oAipfymPxIMlvEU90vvTb6IncsFlL/aWReM9dEF6ME4ndKYPEXuZ1MricQUgdW pK4yT4CXgiW4gyFtJ02tGGnYoXP/XQIeqGC524EeUK9+LSm9IelOkTvsifp/9lVndiBa dPcU0EHnYIeTNxxSwiza5V7QUOGr2FeKQdIiZ8QB80F19B1SViTIn3ImYIn+xNYtdHGD vFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708264597; x=1708869397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uqRBeYbyylaZ7PDbJp+J91shmKsfLHhb9CuS8+GePNY=; b=HNWxus8oRAVipumyf6TqkB4WwMmhNn5Iu0eEmpgC2r8lgSSaGAexq4lcMXFNyKzKm0 skJhn7SbZ8Jjz8FAiL4OKWj4n4MWxqCpI/OYG/iOz6DyNYEaB4VLxTSyNtsO7oOPAg3O JlawgliDEzstMHW8xl9JJsEqk2srvjAvuMJ0FyBj0rxU3u0DPqPdIcgi5u9gtDGSraLB RVyG9MizcAkw7Zj4khIhkkxFhOS77so05ukpzefRtvqRbAwsq9icV7gDL10zCjEdQ2aF WUpaEmrIJsdRKDon29TYD7fFIJvosDr0f/RUlRvl5sT0UV91f9YV9NJl9ZEhF6BRjpR0 1cHA== X-Gm-Message-State: AOJu0Yy+BmUtUR7qXLyCcSyNRhrCQsyRD+Le0yxYpm4mDszWPJw4FRGA 2RqK9rZNYDHokxPWW651jwU3Zp1DBW7zPiruBe2PSMCBQI3bEOuWT5lCf9xkV/k= X-Google-Smtp-Source: AGHT+IE+9ai+sqmSXR524ojQE/qJ7MOmjZNCjx1zJdt2Hd5IfCQSnKtzmwZqN/NGnKcZio4CJw2Q2A== X-Received: by 2002:a19:654c:0:b0:512:b0c1:3bb1 with SMTP id c12-20020a19654c000000b00512b0c13bb1mr670853lfj.26.1708264596986; Sun, 18 Feb 2024 05:56:36 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b005119fdbac87sm548698lfq.289.2024.02.18.05.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:56:36 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 18 Feb 2024 15:56:34 +0200 Subject: [PATCH v3 1/5] scsi: ufs: qcom: provide default cycles_in_1us value Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240218-msm8996-fix-ufs-v3-1-40aab49899a3@linaro.org> References: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> In-Reply-To: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov , stable@vger.kernel.org X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1456; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=OUfLfMEset8o73Jx8kovtS30aE9Ds0RnhHYqCvWeuGM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl0gySSREozfep8A7NrOOtVqd0iLHfccL9+OfKE H4Q5SQktQ6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdIMkgAKCRCLPIo+Aiko 1T1YB/9wENGUoows5oM6gUElMB5NjuHyVhs1Lb20K9p55z9PfjygLHv4YnsyAMxcz/ncCvyvfiU uh15MvcBJ5RJeyLiC0ZU1PEegXMZ9TfqAuGrfpjPZmd1FtvLbvX5ezoEXhxgSVuEjVlA3/Adaws 9xO76cX4GLEagx2v2FJjftPXj1lR7ngVaf4m1ZgMJMBC1iSycp9dwdIv3N9f+4BiToEuhqVn83b fkRUNFJr19qXyUrttfhSDjBqUc98zn5UIfp307pABRrdLqy8z9PLjQpDJNlV/wdksEtDB0zGpmu gE+gJwCJNvAsZqDUInCigGW67H7AcqEVhG6iWmHL52i7owAv X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The MSM8996 DT doesn't provide frequency limits for the core_clk_unipro clock, which results in miscalculation of the cycles_in_1us value. Provide the backwards-compatible default to support existing MSM8996 DT files. Fixes: b4e13e1ae95e ("scsi: ufs: qcom: Add multiple frequency support for MAX_CORE_CLK_1US_CYCLES") Cc: Nitin Rawat Cc: # 6.7.x Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- drivers/ufs/host/ufs-qcom.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 0aeaee1c564c..79f8cb377710 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1210,8 +1210,10 @@ static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up) list_for_each_entry(clki, head, list) { if (!IS_ERR_OR_NULL(clki->clk) && - !strcmp(clki->name, "core_clk_unipro")) { - if (is_scale_up) + !strcmp(clki->name, "core_clk_unipro")) { + if (!clki->max_freq) + cycles_in_1us = 150; /* default for backwards compatibility */ + else if (is_scale_up) cycles_in_1us = ceil(clki->max_freq, (1000 * 1000)); else cycles_in_1us = ceil(clk_get_rate(clki->clk), (1000 * 1000)); From patchwork Sun Feb 18 13:56:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13561860 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A84A6BB44 for ; Sun, 18 Feb 2024 13:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264601; cv=none; b=WQNbzs/b3BYLR3E6HdqgwfnLU31ZScrm5gdLpgy1rIRe2pgtktUAKzkUmQ6kJK/1W8BiIXDvC16psTMNV70n+NwOTVqZGfvUdO/NC2xiKDPplZGym1vsNgE8Q49eqk7K7sYVtKUMD/DemqJVs4YO2IAhga5ZepzueqejU9o32VM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264601; c=relaxed/simple; bh=8Jw52K/qybWNDYMmkfmKEVECM6bSjDnqNRJimByERIo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lMW7AbFDCFTazc/T63uz/S2GDnqblh8IkEsV5Zoa5g/fCihr7APeEfc6oEa/yYGZo0AB4eQd8VGh4ym+WVX7Lq5CR8jv9jxdIPHeb63M/FIkWIkYIqX+tBr6b7g6T6fVuoR/sCZ0moCd5jQNQn9oeaH3oK761xOoUFU+R4ml4F8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V24Z44xY; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V24Z44xY" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-512acc1a881so494103e87.3 for ; Sun, 18 Feb 2024 05:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708264597; x=1708869397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j/wysQ9aXGGhXLcp2eBZzGgvMjVSvkeyoH1wNdoYdsI=; b=V24Z44xY8YZqIrtvw+e88MvHzo+IFvkAv4kzi2w2hWegT8jSZj+xPcQoq9jwaGyyMy gP+4kaPrK7zs/YfCkpt11ZmEf8+rGK34vzkwHheRHKQxjL/9T1DlVRaFyROHDGqp+Oer 26Mp9E6HAEyqfxqQ0x6Lh21AGeyzngE7JUXqLVqKp6xohEkQ/nDR55hQAIGrZF8ZaVSp mbTxAmz/dchQXlTTCnAtmLgM3GMl1fZBC0q8qRBruzOJQCXedGT4D/tDRTmE4ks31TVx s0eoos+AC3pwGlNc3Sv4cp0pIl6ry2aoEOEE2jdDFirDQ+WJ7lie7WPjlgXoxDyCucCC buBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708264597; x=1708869397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/wysQ9aXGGhXLcp2eBZzGgvMjVSvkeyoH1wNdoYdsI=; b=uKeXcP1LrAtYkAsy1Au+yTjYV3GCEvCmzL0x3t3sJVNBDOiW34R8fbXCQA6Oc2LAlU cDi7DQByEC2zx8hV6aiyAw31KKTV+1/WGB0YH6HtIQcOxd3GAk0GNgwXoUD4bL1yjms8 JiLd4Pe9UUiM0pjL15V9WMjOg6lfCOcxPB/vrIpcsjF6qPPrOvnX1F3TjqjJbvlfTkM8 mUr+2rgCD/HcaRZ4jpbxelsKPG4mdMOGlRoP5bkRfTECt78mrHjIGt9J++hCU+CJsWmp BGYSgyRSTFal8OV9U+ZCp4KCV/0v8xa/XJ0WiTa3zkA56deITIWmSpjgFXZC6BxtvZQV LA2g== X-Gm-Message-State: AOJu0Yzezq6O4Ov3vjxfyerkoi9R47Cvl3zv+I6+cDDqMjfjr0OewxvP Wv76JzXAR6J0edvWj56wIv2Adk2n63BUrVUhjlw7CQJqB/zbBvp6ThELu+2SMls= X-Google-Smtp-Source: AGHT+IFL5RmXbxgZsZdS/aW5kG9euoaEuFb5V08Lnqfuv5FdgBlWBEWZtRRP9J5to5emztf4vaYPDA== X-Received: by 2002:a05:6512:220d:b0:512:ac4c:abf7 with SMTP id h13-20020a056512220d00b00512ac4cabf7mr1276217lfu.65.1708264597654; Sun, 18 Feb 2024 05:56:37 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b005119fdbac87sm548698lfq.289.2024.02.18.05.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:56:37 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 18 Feb 2024 15:56:35 +0200 Subject: [PATCH v3 2/5] arm64: dts: qcom: msm8996: specify UFS core_clk frequencies Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240218-msm8996-fix-ufs-v3-2-40aab49899a3@linaro.org> References: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> In-Reply-To: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1101; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=8Jw52K/qybWNDYMmkfmKEVECM6bSjDnqNRJimByERIo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl0gySFeeR8Nqww3tj/VSGTJTNnyikgeG2I7SyZ nNXRvBa+i6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdIMkgAKCRCLPIo+Aiko 1agICACMPq45pXJ2FruwpBy6twqsBFRy9Y0zr0Gwe0U2kTtQ+uzvScPfqTrP1YHBZh5MvwylSWd qHM8jpr/LVUAqqwFc9WtFPG+kC4eFdHHj3dxjw5eh80S5PS8dZoHE898Dk3c0h+BVm4CY/QD894 Y8184PCxoytoLP4mmFX7jvk2cAnoV6RK6CpqRHhbkYhk+Ztb1Sqia0YfSjDB5nPJuqKFsOTCIk4 0PRzx39Vx9n7aTOPwp5fKv7/Qlp8qCEyat4aSdkBbCGw0qApwitzCRUAdxVioVV/zeli3fugrE6 HLKByBugfx3unbAO52L9mCTYcV12wipnd4jazSgrAr9jaxf6 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Follow the example of other platforms and specify core_clk frequencies in the frequency table in addition to the core_clk_src frequencies. The driver should be setting the leaf frequency instead of some interim clock freq. Suggested-by: Nitin Rawat Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 80d83e01bb4d..401c6cce9fec 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <0 0>, + <100000000 200000000>, <0 0>, <0 0>, <0 0>, From patchwork Sun Feb 18 13:56:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13561861 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 415836BFC2 for ; Sun, 18 Feb 2024 13:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264602; cv=none; b=A7RhUO9xrb8pm5M/6y0072ZK/zGsBC0LSr3P9T/8yKG1yLHytQxR5Yie3d45FyGrmbQ80wacZ1Aas22rTMNNg3Sb2ymrzIWVxMhBNdzsZHRm4/SJwYLzoCUVcWtOZsYhNL9DDUjX94lRxhb3S0fdklbR5ycH+uFbNrZiwVMVJHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264602; c=relaxed/simple; bh=qjeaOhaCrY4VcmImvKR8DYCqB4V+aBVBAJGTPiEhh3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qCAqemgK/ulrjqbgWIuuv0cNoaxDSxs83Qsn9qMJV1NQnENSiYAh6mQhozNnJAXm5jJxi3khi0uH0ks2Ezc2wzPamPaKGrJkwdG9xyjLbpZcccvaWw3hx6/n/a1zhp7L2gBjoqvqoGATM5WYE1FGF6X47h/+KSkXualHQs7322w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VAejksZq; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VAejksZq" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-51178bbb5d9so2458711e87.2 for ; Sun, 18 Feb 2024 05:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708264598; x=1708869398; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=p9uxpSXtWjR5vbZkonahao8rqtm4NaLba001ReJHo9w=; b=VAejksZqpPsqFVEASFewlrdJdlSIPsGS5NTRKHkRaMRzWsssoqCZuM419JjrvWclLC 550blbTsotsh7ZPTzYLyl8mna83/KNkFiUWG1xGB89Y/ftwY/Lfxd0xy9yR7vQFPLm+J 17eHu9cGyG1HRPb4x4TECO4GSieM58XdwDP3zUB25Z14DCJnc8Pq8Hdr77dD4yPCgbUT wPy4kjJBYA7g+eT+5Gi7pDt/Bo7h/jxYHrPiOr+7gXPTjpYfiR1H5DqZEbJPqK2J0UaB WBdWa2XzbdDr5vi7N9MqXPiJLBctddKbl5aPmKm6jyxT5ClXGPXuK8nH3K77gfBdku3e ybLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708264598; x=1708869398; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p9uxpSXtWjR5vbZkonahao8rqtm4NaLba001ReJHo9w=; b=bZmzppMVXmbdQ/y9VB5JLqzmTWeuv1/I/wgaWRnibj+dz1Bf6LhHWtjjX0K0qi4pS7 EEYhd8g3We1xUvjyLNiTgvwsIxQKyCW4Zok4w4tF5JeLsCkrzuTOU/O6bBIQ+NXN5hI/ WFeRtjsRbFdS1sdJ/E+8nvq+h1tGsqnnPlDowW0sQN+8mVnhRBOl+fg5d7uyp3bTDii/ PkG/rthXV8QDN8KRIaLh+spAxgAGNlncxgqnMqpFD2guCGPZEOAnRZmiGEbvrndfLPHt pwHrs8IOxW9L0uLDLiSgzHfyUIcXreX5CRBxH7i8rYTcVDDagrcrYeV97c7uMazmxXZQ Piiw== X-Gm-Message-State: AOJu0YzGGVXAR1DaK4MV3OSyxQaoPZrg4aKVy4jkQp4WmP6o8sgnRY73 k1HTyq6C5Og1XO8s4yiRQD63APKrFGPxXK00SyDRXuBmyHVYm/aBNiRAbKhpAW0= X-Google-Smtp-Source: AGHT+IG3o8o/a4+lttK6f9vGAipl3Rr4H/zqGBtpaamLytI2dyMtTrm//xygZ83Nh1MHwPq+Dvj1eg== X-Received: by 2002:a05:6512:358b:b0:512:ab03:1b with SMTP id m11-20020a056512358b00b00512ab03001bmr1277442lfr.53.1708264598338; Sun, 18 Feb 2024 05:56:38 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b005119fdbac87sm548698lfq.289.2024.02.18.05.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:56:37 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 18 Feb 2024 15:56:36 +0200 Subject: [PATCH v3 3/5] arm64: dts: qcom: msm8996: set GCC_UFS_ICE_CORE_CLK freq directly Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240218-msm8996-fix-ufs-v3-3-40aab49899a3@linaro.org> References: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> In-Reply-To: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=930; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=qjeaOhaCrY4VcmImvKR8DYCqB4V+aBVBAJGTPiEhh3o=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl0gyTvsrx5bGHb1ytmU2tJaqUSojI5Rdb4BQFM VzRV8pyBdSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdIMkwAKCRCLPIo+Aiko 1bhFCACSfsRIe8ROLD7IVDgsrBnAdV5w1za3tCYtlJuN3c/l8kg5s0wBD0dvtYpzbf7/nGe9YwW 9RbcQ23zHcSZt7y7BOt4C9LsWC9AlHuKh8R0hmdEE+OeoVVZC9O7ckvaq9jP+ODA/PmFVHzih3r h/adx6BnUk0T+2u1bykv/2jvtx/j8s8gENDKNY86o6UvX3J6XZTIqH/8o2mI7m4Gpwh8Vw2V58r ysWqR6Bu1VHHXzZnuqSAML3sbJZ8OInzzGzwW8778dyDmfI/YsXE9nwwoxu4AwFfSCRAACohsGI c0JR9q7tRydt/ThSpwX1YaTVCN38kZmoH/yS82DaPi/SDlou X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Instead of setting the frequency of the interim UFS_ICE_CORE_CLK_SRC clock, set the frequency of the leaf GCC_UFS_ICE_CORE_CLK clock directly. Reviewed-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 401c6cce9fec..ce94e2af6bc5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2076,9 +2076,9 @@ ufshc: ufshc@624000 { <0 0>, <0 0>, <0 0>, - <150000000 300000000>, - <75000000 150000000>, <0 0>, + <75000000 150000000>, + <150000000 300000000>, <0 0>, <0 0>, <0 0>; From patchwork Sun Feb 18 13:56:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13561862 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21A56BFD0 for ; Sun, 18 Feb 2024 13:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264602; cv=none; b=CV0IGxVh90IR8/HrSnq04lY6T7cpC8iBTZuvru1Mam7Cpn00EiqzJ0uqxQriDrz/eDA5GD5Gkx61e8GSBsMD6TiqjHZIR3q+ztDjSegFccb5/QXE/R1lWJEAG96SFv5/LREc/bqD7NQirJxVlu9Wg9mT2kFiBmVAwluGg6RowJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264602; c=relaxed/simple; bh=JUhIMc4iUWCBq7eLRAz88cgUjHbGVlb137bI76g/gfY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XglxVuLbdiqUOdBCBbhO0dbxeeqm6Js/LIVitpbcbEnidmEKC0uND+R2KxIo9YsER/byMJRk1fKCPVTal22s2V+gDKN+T3hbw+42U3zSvRpGZt453VAzpXwSYGreHwZooHcgq1KE+VgzsbBe3zHO+rNgBL7oV6kPSSjq1r9yC7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S4Ho5yFn; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S4Ho5yFn" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5101cd91017so4653811e87.2 for ; Sun, 18 Feb 2024 05:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708264599; x=1708869399; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jQM6AXrvF9wLpeD8ke2H3OmUga9j9iyxSldR7lmW6eU=; b=S4Ho5yFnYu59FVtIKm66CTOsrrN3Gf0wJwxATJCHPtL1rLCluk6UlNN5t3zz93rxNK ULBIDohQ97LU5ESlzt06L3PK2/11UfOf31oOJrawofF5WiVBjSaSwJPXepwRUm84EZfT s5NjpJhr6aom25QF5yPeQBZuI3txgEaiPbfjN6luECyeJ12d3eY2fmzyArK/sNnw7hZY G0Mj9DSAMoTUxgmOSYG+RMd5kaKYJROHrFUG0i1tKpvfm7GRQ1yMmG9IpH2h8iN97V8N rHnXriCuqLEU+zBKWzNrbhzvKXariPUSWX9SA0FgdewhygIVXP2F9X8i399WiC2CRava zEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708264599; x=1708869399; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jQM6AXrvF9wLpeD8ke2H3OmUga9j9iyxSldR7lmW6eU=; b=U1mlztXBKqBOjiQyAlL941xnz823XqIXdVjcM9eLYq9NgHHjPexgi5vxEZ7OxxzuSl VSW55HhxakWz3Qqpq9RCQwSyno1aTzKqcqp9OpyVPKmrtJuT6IGyxRxc+BDKzzMCvyh5 Bv8ixrI1SVX4Yk2RpeRi5yEvgPPwLZKD5AnxJGrkHic8elVjEBjR+noay7Y1USEyN2tq c/Er4rHDAQxwblIB0JEzI2+3nvCURt9HYMBkAnSlUA/yNt64gce63OgNXnu/saBNOpXh Tc+JNia8/b2qDOCQ6vTXMnbF/Syos0QszH3e2tG3esueRii1KSIIF48LCHyAjKAxtnHI ksoQ== X-Gm-Message-State: AOJu0Yye1uX2jhXxZMjBfWzzYaimy/yIfOmYm0d02lhTjKxw/whJ8GyH MkjuDMNroyEZY0KhaNO0qWu9FAbhe8/43CkMeQltLtz6JFUNBJEXFlgXXg8J3zc= X-Google-Smtp-Source: AGHT+IEUZxDPf+24gy+QliHdxVhWdtAonWuTcXc4/EdW6yU8DebUvnBO9gH4P2wEp23duPuKOHEepw== X-Received: by 2002:a05:6512:11c5:b0:511:9008:7266 with SMTP id h5-20020a05651211c500b0051190087266mr6220198lfr.6.1708264599082; Sun, 18 Feb 2024 05:56:39 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b005119fdbac87sm548698lfq.289.2024.02.18.05.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:56:38 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 18 Feb 2024 15:56:37 +0200 Subject: [PATCH v3 4/5] dt-bindings: ufs: qcom,ufs: drop source clock entries Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240218-msm8996-fix-ufs-v3-4-40aab49899a3@linaro.org> References: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> In-Reply-To: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1735; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=JUhIMc4iUWCBq7eLRAz88cgUjHbGVlb137bI76g/gfY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl0gyT2lAaUPeO/yx9AQILQ3YhbffBLLjp6lDEJ lSsHvt+kxyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdIMkwAKCRCLPIo+Aiko 1Vr7CACVyOcblvX7/JOS1/9ki3KiVYu+sutex45YESPJcD2apP8o1PDAWDGn/+4jWq8c7Nr2qvi qItPlrqUeHEkG71ehu9hDBNsTFyHPge6fi86RhLIIhXh1KUCy08tT+L5fZGUhiTqnJI6akGyLX1 VAC3gfiJPNDFRyu/e3z1cl4gh/1eoogreJqZTCD2P0it6120kEIUum5+dWyqdDeTpLE35GoRVMK DSqK74MD9N8DZDyKyVIZPSMORO+35+FiK0OBjOctZ4LVZki1caYc/gT3TVl3KcQnPdSvwd9jq45 X9hLGeEEzn7ktT7zooJ7oZRo4YBMHZuEWvJDMNXgl8ht9qX8 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A There is no need to mention and/or to touch in any way the intermediate (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow the example lead by all other platforms. Reviewed-by: Krzysztof Kozlowski Acked-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..a6b11fdb39ab 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -43,11 +43,11 @@ properties: clocks: minItems: 8 - maxItems: 11 + maxItems: 9 clock-names: minItems: 8 - maxItems: 11 + maxItems: 9 dma-coherent: true @@ -188,16 +188,14 @@ allOf: then: properties: clocks: - minItems: 11 - maxItems: 11 + minItems: 9 + maxItems: 9 clock-names: items: - - const: core_clk_src - const: core_clk - const: bus_clk - const: bus_aggr_clk - const: iface_clk - - const: core_clk_unipro_src - const: core_clk_unipro - const: core_clk_ice - const: ref_clk @@ -257,7 +255,7 @@ allOf: maxItems: 2 clocks: minItems: 8 - maxItems: 11 + maxItems: 9 unevaluatedProperties: false From patchwork Sun Feb 18 13:56:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13561863 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 728B96BFDA for ; Sun, 18 Feb 2024 13:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264603; cv=none; b=X7kpHzax9/nmiKPpo/eaPonJkr5gO7v/ZD6yYkJdZo9hdsfNQ/Cgx0+LvpkhIu72UUSB978wskRQP/RuYaw1TyyRzKI+HYlsg2fyv2iglfVMiaSzIzk4FNPXa9ySL4sH0EIxI4dZK3xCyWlPQEBGLn1CSyh5hejcCF8q/+EDMwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708264603; c=relaxed/simple; bh=5/2tUPFDY8rn6BKKryQEGZNAdZyZ7qK6H/ztEl0/dfM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sJu6+ZXFkXfwf1Dz2x30kZywEL6itdTtunbGLJSZL1gWNox+4AX0U7wW+1rOacJ+GVWLq0frlw2faxxb4n7cIMgDWTcrtlAwcO0K2Wnhw5lcYOSzkjvqps9xwUM2CWL2EWR02IZ/P93DMs2knq0dbupOfwdkQMV2ofFpGX6Dqb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BKPiNtPd; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BKPiNtPd" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-51299e0cb8fso2372182e87.1 for ; Sun, 18 Feb 2024 05:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708264599; x=1708869399; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qVoA1ANzdbe0FJlv0J4O2Wqp7VzCUhtM15EgEKGlLeo=; b=BKPiNtPdHraV9Ffm4LdMVta+tmdDUyrqZvBgDqrR/wK6hh4sAg0Pc5pkeY030ulvHW CfvvOr9P9g1pHV9g9SoT2RrcHMGwKVSBKlvwrtu/rePNY7/iLFUGCyR0soivkbKqtllD E96sGsmClE5DW0Ry6HnooBBd0QuoFVlcOvO7eLkAywboXBWlLhw9FzSO6cckxAjCzmIN WegSKj7u3Gy8cuenExYEsbUcxjRNYDYYeSYtIe/SfS4yj7+veB6aNrQmG08g40SzrzHl /SRPEyl7x5nHg2BWqSAi8IB8yekQP5eU9ghZEGo6s3FMjZt+dVLB3cBTf3UUnm/gRj00 RP3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708264599; x=1708869399; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qVoA1ANzdbe0FJlv0J4O2Wqp7VzCUhtM15EgEKGlLeo=; b=FN25/V4IA5iVWrffF08ljB9/q99tr5VNiIxmzSRsu2Q+EzQEhWUmPATv27haOLemRR WeJWnKc/vFOcWlI666wZD8lMpTYf6aHKq3iJRBY+BunCs8vJlBI4DhxMPc75O3caePR5 +1abBBta78cFyvNVuLjdFuBIu5RbpO6Z4ZzRo8Rm042In37X8qQxq+kGn7Vgn3/rjccT KKDFkLpLu42YTNHHKiLHTQr+yf5tJqUJEyQPOXWGEs1sRBw2J5lPunxpw9G1Mp2/RVFT V4VB8TE93AeKhOPUlaw7r+O1babTg5t6uD+jULK6ysRyMeuseBJ9RnYb3wPwYUhfj7xZ KNdg== X-Gm-Message-State: AOJu0YyBVCTS4ogCWoAmzr9u2EV0Bl7S0xYevK8IRQeDzsHNjSn/xdJw jXJ8n2CH+gN/4G4OMcvPF5MtERuh+iREHrhLCCpKWG8br121IfXt+Um6d+G0wmw= X-Google-Smtp-Source: AGHT+IHlNOGJwWnLzPunxcunoXNUiKAL4QraL+pMHJvkl+d6rEs5Suy6efn7K6MOWQsV9Cwe+MbokQ== X-Received: by 2002:a05:6512:3485:b0:512:b2ff:aaa5 with SMTP id v5-20020a056512348500b00512b2ffaaa5mr294158lfr.20.1708264599751; Sun, 18 Feb 2024 05:56:39 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id w9-20020a05651204c900b005119fdbac87sm548698lfq.289.2024.02.18.05.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:56:39 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 18 Feb 2024 15:56:38 +0200 Subject: [PATCH v3 5/5] arm64: dts: qcom: msm8996: drop source clock entries from the UFS node Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240218-msm8996-fix-ufs-v3-5-40aab49899a3@linaro.org> References: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> In-Reply-To: <20240218-msm8996-fix-ufs-v3-0-40aab49899a3@linaro.org> To: Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , Nitin Rawat , Can Guo , Naveen Kumar Goud Arepalli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1595; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=5/2tUPFDY8rn6BKKryQEGZNAdZyZ7qK6H/ztEl0/dfM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl0gyT5VUkDlw8c6k5qZmwVfZjWiSZypdHWwl+v X7gZ/C9q+OJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdIMkwAKCRCLPIo+Aiko 1Z7vB/9sWdR56Hve+vaWP2jvHtgdAf5iIaAwRBMU8brmRi0Hg/Z38UWqHf2hhu/kgMc7lQdb9eR dGCJs8fFsoyOSVqpW1ps9fxTqujpVSNqCzZDW/s5w2cnHHMhTiFN03/iuJ7mN9McCoe+1WYpiw5 ST1otAxFE+J7gF1/Qb0Y//ol0yXnzUxF2IKeN/xu5zvDerbQLnFStjBV0wKMUR075hn/LSSHsSS p6agOKhlF4U0RgFLDFKX9CFcODQRi+1oqdedAJs7ENH5R8udTaxKRCJAzTje948LXOSwHXbCVlY y+n/BmS2VkkqSScP6aVyXKX1isLB0fwPZyqqZ9UGG5+CGKwm X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A There is no need to mention and/or to touch in any way the intermediate (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow the example lead by all other platforms. Reviewed-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index ce94e2af6bc5..f18d80a97bbf 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2047,24 +2047,20 @@ ufshc: ufshc@624000 { power-domains = <&gcc UFS_GDSC>; clock-names = - "core_clk_src", "core_clk", "bus_clk", "bus_aggr_clk", "iface_clk", - "core_clk_unipro_src", "core_clk_unipro", "core_clk_ice", "ref_clk", "tx_lane0_sync_clk", "rx_lane0_sync_clk"; clocks = - <&gcc UFS_AXI_CLK_SRC>, <&gcc GCC_UFS_AXI_CLK>, <&gcc GCC_SYS_NOC_UFS_AXI_CLK>, <&gcc GCC_AGGRE2_UFS_AXI_CLK>, <&gcc GCC_UFS_AHB_CLK>, - <&gcc UFS_ICE_CORE_CLK_SRC>, <&gcc GCC_UFS_UNIPRO_CORE_CLK>, <&gcc GCC_UFS_ICE_CORE_CLK>, <&rpmcc RPM_SMD_LN_BB_CLK>, @@ -2072,8 +2068,6 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <100000000 200000000>, - <0 0>, <0 0>, <0 0>, <0 0>,