From patchwork Tue Feb 20 05:45:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 13563408 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A879482D1; Tue, 20 Feb 2024 05:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407932; cv=none; b=EFEJrTWBja/jcHayO8TO22IiPipTJPdkeaas/8FU82XwjEJ8m+sNalgQpp0iC5Z+ReSw1WL8buNbhY4xtip/yE1SDvIo6S8XDTAqayChFnBDOr7kOP3U+HytaoVmqzL1mgptvxwMOA/YOGzlJAD+wc8VqycmBNEhg5Q4W7UgXXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407932; c=relaxed/simple; bh=wMCc8J1PCY8KB0C8TU2S2VGitU5uhYxb7pS5TWKpv/4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WrJPQK97MRcTy7si0GL3euoPhM6IagOueej1cEolk+d9R9CkESvwVqGh7GPNtZwH3YGfv8IDIYTNGLv6G6H0D2I+dSKZVzbjDCR8wfhCi5nv9xWU8mFgSrSW4o6bxGNOT3GMS1IhjlSFoMwz9rLMj62Och2BsKyQqIFATKh0h7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=aLitBPO/; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="aLitBPO/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708407918; x=1709012718; i=w_armin@gmx.de; bh=wMCc8J1PCY8KB0C8TU2S2VGitU5uhYxb7pS5TWKpv/4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=aLitBPO/PNEumsiFTO5LEBWzlUKDQCkasQdR5ZDmIVTh5+SAzGljSZSIhp8HaAAy /S0+l2BeiOpPSg271uN0IR8lTSgalXntcxvjTuZl9p+EQtcPzs7u8itXLB4+59drz EY7ccLY319/767ZqQZpyVGMSAqm8PWIzbBvauVjYWaFSIO8LcigRy6kpdCv1wmpZu 6A4xZVmYzOAlbCNVU5CT+sCHTg6nkFAKp/X27sM2QnLuEh9oa4u6HKxqT/ymyHVOt 23jvgAiAxi2PuLZPViBM8fwOvl1NPaop6Xr5hSiVEZpKb8I0RdYzyG6VEKS7VVgmd 9p/h/4Q3crejPt+iTw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M9Wyy-1rWmdN3pp6-005cp5; Tue, 20 Feb 2024 06:45:18 +0100 From: Armin Wolf To: Shyam-sundar.S-k@amd.com, mika.westerberg@linux.intel.com Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base Date: Tue, 20 Feb 2024 06:45:11 +0100 Message-Id: <20240220054513.2832-1-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:Ozzk3tnKBJ32+TPnyj6okQniSEs5v+d+xylq2BPWyiH69B9isX1 ihj78sqcgowFCHaFxcvQZhSsKIHqKnVaKKpMWgjbB60ayJnv6x2pKMjJW3UcgPKK0Jl1dpn XEyk36rVvykCSjFPGGMBfjvatk/HWpKDsRrNXKDpidRYZFSXDLjAZnoCOThZMNyOR/WgO8c WlM8rxOUGSf/S6urDAl0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:uyGY52FymLM=;UIsQXfUcdN2wYpy9mdDmqgdB6/z pl5xRbfE7qMdUWUo91GRlRQIgqf1HlnQL+o6Um2hpvDWFo5AS+vPAArIaeWM21pOnNUJtHTKq XmCVwcYGWGDgj5d3aVyOLSvrzdZr2ifU5wP8i2hQ81SPtZrCsExEqQeTfAYGqB4WoW6BJfVfo 7XR3szR12LONsZcV068Fb90TFZ/YtkSgIe+Hgf80SeVc5eUiiHTcBafq0c6vf9vuYIHaMn0b3 3Emrpzwam+yus7T8HQK7pEHv6naNscqM23y72WH4JiQEzUHA51h5FXBfECf1Wx6+IaNu2rzVE yy0jtsru76GvpUaULsRHWE5q45qOb33LL3UPVZ4DNWBWL63C7uCkH95yuDqlMyzyIo1dViqe4 YQf4brQV7X+IlUZAfOqPr2J6njg98m1/EOpHRjjLSp4+D1HVuTSavWvyl7vgUKYZfPKPeWvIF o7fakstS/KAZyNgDTDjtuuqV9XyxHQ9Fnh8+JFrSrZqMujgju0ugdWq9q8wyLAaZaEgx3gXkO VUIXEUZvtEGaQaaMKVYRUcD0UDWXUIiaBlEtDUylhlneg6HQMmey/syc8nhtbTxA8ADz8+iob roHMSJKgZBGN443CFuhnqHKxHW6Igub+E50iFhI4MjfQSkifITQy+yVPz9ATqyp2R8UfDsAUO 6lCINWE0bLDPhruqCNNy6ZedbReFjfkPPv0V8T6nsK+D5pTmZ/T+wPLHLJaJ4Q/98VB4vA3ae YsQiYvP5auEeZOQXlu0L/3E3JRHvSLuLMVc+s6R63wjf2vlI+z8QNnhHUgS0msFUmUnr0Mi+T uhegh0HkId82pLSb005B862OWh/ZBeFNVmAFFDzsUisJE= The value of policy_base is the return value of a devm_ioremap call, which returns a __iomem pointer instead of an regular pointer. Add the missing __iomem attribute. Compile-tested only. Signed-off-by: Armin Wolf --- drivers/platform/x86/amd/pmf/pmf.h | 2 +- drivers/platform/x86/amd/pmf/tee-if.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h index 16999c5b334f..bcf777a5659a 100644 --- a/drivers/platform/x86/amd/pmf/pmf.h +++ b/drivers/platform/x86/amd/pmf/pmf.h @@ -229,7 +229,7 @@ struct amd_pmf_dev { struct delayed_work pb_work; struct pmf_action_table *prev_data; u64 policy_addr; - void *policy_base; + void __iomem *policy_base; bool smart_pc_enabled; }; diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index f8c0177afb0d..16973bebf55f 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers/platform/x86/amd/pmf/tee-if.c @@ -346,7 +346,7 @@ static int amd_pmf_get_bios_buffer(struct amd_pmf_dev *dev) if (!dev->policy_base) return -ENOMEM; - memcpy(dev->policy_buf, dev->policy_base, dev->policy_sz); + memcpy_fromio(dev->policy_buf, dev->policy_base, dev->policy_sz); amd_pmf_hex_dump_pb(dev); if (pb_side_load) From patchwork Tue Feb 20 05:45:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 13563410 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2FE456B9C; Tue, 20 Feb 2024 05:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407935; cv=none; b=lXop87aWgSfs4LDCCFwi76BUN/F27/CUv9z/ev9dGGq2/yE6cR4JKUuXczyPSnyFpRN5dw7Jm1y2VwFoR6h4NjSbEUdNWKy5w/nzapW7f29wFvo6Mr4XQUR44ndGOLnjAOrNeebWg1FA0NmjpVheDiPAFAP5yUCutdYQWzJb5Xk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407935; c=relaxed/simple; bh=EOUDer5qk9/zoxzi1igP61wAaiJrJ+Ygu/OKnKKEOVI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WDL446HPRX3NHbwAOvphh8SvlnEr56WKJwcDvyqMtI2WprlZsAcbR/KEsRXPuDkgR/FgoegQbl2Vd3QEIVN/kBT8UMI45eGztNGwcxcH4Z1qmKWsdyG3T4JAAEf3Y7yQeFP5GkPRHFUk4N86rHfjpWCUOJn2i35BM6I7f0KuQQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=TrwHiWqO; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="TrwHiWqO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708407920; x=1709012720; i=w_armin@gmx.de; bh=EOUDer5qk9/zoxzi1igP61wAaiJrJ+Ygu/OKnKKEOVI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=TrwHiWqOqX2cpbBaE+ZAsxJrN/YGkjBLqcGVYKuAn+x13lFKmt/E7v74QpyGFX++ x+4iASOJnblW/nWYXSrLKrLHEGuXGlEq3f/r8tRikhUCTndXE4ufWO05Mtj9pHd/5 v5dlHWfCDK1aZyNiCf9NICFi8E2cOng0nLI7cZvqnnB5Cp8grLDfAS2oKhGcJiyv5 VhEFxxwIdJTKRgyqyJcxXWjsJcsPuXicf4nFGgbbIheleOvcMLUJpEVYU0TblJRWy N9wyLTzxVUzvj0JxsUtvKcbtky2CFy473MuqZL0dKC79+S2XYBngPFoziD9i5Eqlx dNjnoVohUcI/c9cPFQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MOREi-1rHzpu2uMw-00Putm; Tue, 20 Feb 2024 06:45:20 +0100 From: Armin Wolf To: Shyam-sundar.S-k@amd.com, mika.westerberg@linux.intel.com Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] platform/x86/amd/pmf: Do not use readl() for policy buffer access Date: Tue, 20 Feb 2024 06:45:12 +0100 Message-Id: <20240220054513.2832-2-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240220054513.2832-1-W_Armin@gmx.de> References: <20240220054513.2832-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:SyimU/oU4LVCuHbt58JTQgUNmqeE86uN4FHY9gZeuyC1388IYJf F42AV8S3/ztnTnQ3LUomiqNKoGgY30JN4zSZTvq3yvUmKmPARltjba8fJ4s2FDwLjneDnqW IkVb/J51EOBlsKE1Jv3BUpQghL08Zrj93S8bb32yrNWQwoo5QGF9OCQzN4yD+u/y2W0iJ50 6zZtNfUwIg++lWY9RYQjw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9mDdGKpSQWw=;FZUCS8i+sySI+qn939HZXC7F9jt XQZ/HXICIrSQYIQpfT4EounJf+Sa/W3Ql0bp4L+s7vUiuSAgmT0Lpt2dHFsulOul3bohA6uln t+WPZOLoSTFR8Lu/cJgikCh+OWF2G7K2HFy71sRhYJ/Fb9dC/tBV7DZp7iVGykkqfyPRDHxvK 2/YWQ/GAMOB1Sx/K9VwGklT+3qyMDJtsxbH3uNX3O+KyxWrnClh7rhymditKgnnIsGYQBxNER +LuibJqnhiJQy9z4pgR2/ODmSEZYkJYNXEaccIe3Q7yN0Daz3YxdyUuCZWLNh9ZBwSQ+wACf4 OSCK9RvJiVmOuDgZdCHd2+gu/1z4kPxP4j1O5+GxUheS4vi1U1kPsB9LE5WgvNypCpE/9QB7S K4zvYBwB+LKNNjGaVBHsqNFblgv3OFSBRnRrh3RT8kuK2RXbJbSoGH9xztnws/t3s5r4mut7P OrdZQ8jRqCYAH39i6BlT4/5Z+D/MvuBSJkw1V3SiS08SweyEchMbvtubPSM34Cu+uozYE5Apq fi9ivaW1ewcueyJ9zv7t/YZnlLnQYjpGY3lisfSYXDfjfJcGT3EQUuZp6ljbYrQqceGIz42BF NxUZEVD6pyBjgAQfDdLz/VUzDEH4RBUXSqPTsiwAJUs+IuDFSI9f6r6AyugZLJuNLfsTnJwEO Hv36fnd8Ahkt80VPylRCgMue67f16SKLaDfDOyW3DYmX8SfB59731gqBilvNoYA4LuweHxi46 usNrzRDrTCIva8wSsMk0V/sQ7f+UUl4pNA5jYalmDAc4hHuQAQ4DNN8aUMc7X7I4s4Op48FHg 1WFAd+ip1tVR2m4fD/xcnqx9Y4xk7/U0sglXU7+k9F0SY= The policy buffer is allocated using normal memory allocation functions, so readl() should not be used on it. Use get_unaligned_le32() instead. Compile-tested only. Signed-off-by: Armin Wolf --- drivers/platform/x86/amd/pmf/tee-if.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 16973bebf55f..3220b6580270 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers/platform/x86/amd/pmf/tee-if.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "pmf.h" #define MAX_TEE_PARAM 4 @@ -249,8 +250,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) u32 cookie, length; int res; - cookie = readl(dev->policy_buf + POLICY_COOKIE_OFFSET); - length = readl(dev->policy_buf + POLICY_COOKIE_LEN); + cookie = get_unaligned_le32(dev->policy_buf + POLICY_COOKIE_OFFSET); + length = get_unaligned_le32(dev->policy_buf + POLICY_COOKIE_LEN); if (cookie != POLICY_SIGN_COOKIE || !length) return -EINVAL; From patchwork Tue Feb 20 05:45:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 13563409 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B7556B9F; Tue, 20 Feb 2024 05:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407935; cv=none; b=p31RYLJZvFyEiLlfd8sZyKcsR+DBTEkO+PKVqZish/qXPNdrNoPcoGh+yPjzYrvFiPtigMcfvNT0KOmQ1jF0opQNijOlF9Re/YdJeiX5INPjLumz0nh3W8OoxWpyY0ojCOjjc4tF9CJRaqs3Tz9SVEDG9ddN08wAKlDQF1X6xD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708407935; c=relaxed/simple; bh=eobAWH/CQ74AbdBposfF5jZqxo/Sl7vEIa1ZDCK8rNs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XyMVNfDXPHbNePhMPu1GFbCboZD1r9a5ib0Vpb3IwQ01pCNI3vTV/XadlB6HAPZ7K8Y6oqixLE2XDFKDJbRHLZEJTRRfde03vVrqMS60FJXz5VJKQOUk3ByJFxXSrGgSxNN1e9kY4EIbLYBhzzENdMsang3W0AMGfHTSRqDmpEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=mJ5GA+eF; arc=none smtp.client-ip=212.227.15.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="mJ5GA+eF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708407924; x=1709012724; i=w_armin@gmx.de; bh=eobAWH/CQ74AbdBposfF5jZqxo/Sl7vEIa1ZDCK8rNs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=mJ5GA+eF/fBfSmgGh86TH5ksk1Z8QTD3RXe+4w7OBQDUAxtTlHuk6/cYhkNQgXYW 6QDhUOAT3uz735VMktpWMiPpGQyQZeIaAvu8ummMh0FpW81xxsQ+TKeagq/TFcX3Z pIBcDKq/78AFxwqtkTSECjUpzqq2ILa817bM+5AAVh4GXTBwnp3N1ckoPTjn5zi3b QAdgff7W/+3ytQqQXl8mJFzN2cR1PaBAXu4pJRqsQMeBe1kDqqyAj+jbC2qUOCQXf sirIrnuH+J3JOkps5xU+kMmr3Da21sVCEWxaMrcU+lnRVQ1C2XlvH+MqulPBMz6UB +GLWVX5YrHYkSbApSg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgNh7-1r0k8K3i07-00hufC; Tue, 20 Feb 2024 06:45:24 +0100 From: Armin Wolf To: Shyam-sundar.S-k@amd.com, mika.westerberg@linux.intel.com Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] platform/x86: intel_scu_ipcutil: Make scu static Date: Tue, 20 Feb 2024 06:45:13 +0100 Message-Id: <20240220054513.2832-3-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240220054513.2832-1-W_Armin@gmx.de> References: <20240220054513.2832-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:FwrNV4oltVweFu4+1d1wzAEeqcmQk3qU4JgmxxNMCO1FmdRCMJH r09Jvi1qYGSmYgjMZLI+LFflr7cdKwr6vWJj+eH/KL3XRxGsS/0F4X2Yy0Gxp3frwKdoUNz KHpwI8yCydJrLP0workv4liQEphTqGvTBi9T3suF9G+PJu+B31zsWTgNUPFI8N/6soKU0jE cqMQXrQssdM4iY3OMpl0Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bPiltYbMaEg=;lauq3K32ajcbpBIZwGnp6fPdrV7 wtjwCCLm9ahVxJu++i8v7yF2PiJ/pmLfI43WM8JGkXVHvw5Z8GyT0MEZHU4Vxb7a3g0IKq53o JSi+sR68UqYqqTuFNnWLSYsBDcoUSBnO50GLz1SvFZEi4OjpyJ/bMwkkktZR38XObI3se18V9 7PFu6GDkH1yphdput7n/gNVOtg7Xf/4UtVFVul3dlRUt+R1OvGrnCAlWjHCB/nKTzhsBl78lW D7v53XLf/2iXzBAxzi7aJst2BPCC4xd7/l//ruocgU+S8lPAf9euELTsjYMOdLjtde8WU8ZBd BUT56sQKa0gzBNeQPT9QZPohJQ5DZODdHlqJa0AyuNTTzPXJFvkgU+VQGxjOwrozUWWco/nt6 WUlV3FN2HNkmNzGjedxOAf5SiLdwTrUgDuPrmCKhYSLn8g3hp3b6CsWMLogwTajR44DB4AmDP Zb0dACgA4XbKp3ON0qsw7ytFtNuZbXSo1hNc7CUGwENHjwBDKuBCshxDMg/S9+jCjjhc9jMwJ vLmWmdwTRVgGIttfQ7x2WCtPJCo9o5JUSQSB8hMJXZSpE4K8LRPIHdxmY+9zJsm6jDvDMtIf9 YvOEnL6VQc6v6HlxR9EY0DOIUk7uKSPbUD46hVBmgqrL3Wgh0TzX6OHU9GXebyxuDiXldr/qV gVF6YOAPToqkWEtkJU6BJ0RDdIi6PjDUoaUuwQuSifX4wi5QMEvcSVk6/O1IojP3HvR4op6XM i5lB32vx/mq3EWU1r9p373mKUywRZqxOPLCt+zwuSOfYWxoH5nYkuyyWSD9VcvaNBGqB1SHPM hlB+mDhLWtfF1hP42/fsEQ1y5Csbr9N5ggdMH/onN+ccU= The variable is only used internally and has no external users, so it should me made static. Compile-tested only. Fixes: 663cc18861a0 ("platform/x86: intel_scu_ipcutil: Convert to use new SCU IPC API") Signed-off-by: Armin Wolf Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/intel_scu_ipcutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.2 diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index b7c10c15a3d6..7d87cbd4b9c6 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -22,7 +22,7 @@ static int major; -struct intel_scu_ipc_dev *scu; +static struct intel_scu_ipc_dev *scu; static DEFINE_MUTEX(scu_lock); /* IOCTL commands */