From patchwork Tue Feb 20 13:59:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Nyman X-Patchwork-Id: 13564040 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4D56A325 for ; Tue, 20 Feb 2024 13:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437494; cv=none; b=IOrCJA5jSv+DqrPHprJJRhygZg8YQmB85fykxlt+4xMwUXGylR6mud7TMjZb7+a3YkyyObsWzCgIUEnX3+Ns3lMBu8MgXTfIRAv1xXNMpPkQKnNGfL4rx/NmCxu1ss0h4UEiowrjhGX6U5K38l5kV46ybGJ4eIijuPUmlzQc+rs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437494; c=relaxed/simple; bh=bZCZrEhU/27eTVCDMht+oOX2C5y+x6hbEejfrQ2Q0NI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ue48sJdKYwBqxWbTSKrtNzXS4gmNRbOw1Lpzf4h0XzDE2fGvUZAFtHBL8lfXY1vxNmQ8l/1WZ3uq0wOCpBeQVWa6Jj53jZ7EsmP1sT5Fbtz0rVuySUXTmRuHnzcH+7jbfAVDEDgigWAP6gRk+0JIrV6bEuovB5T/LyjG60uuQhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GLj/Va3E; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GLj/Va3E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708437493; x=1739973493; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bZCZrEhU/27eTVCDMht+oOX2C5y+x6hbEejfrQ2Q0NI=; b=GLj/Va3E0dKFPHOlqyItqgXeURxw8ZHKL/JHvLpLQ9Qwyf+Km7t+rvwa uNeWsPJGJVKD6UKVoa3j87u8N19aei4+3pX2Kn0aYSthtW4YyCEhMwbOK gwXvWcf5Azi7h2+ztywEIPuUiRjX958gCF0iUYJgWY5Q91XeYMeq8JFjz p3U8xPOOfwjG8bPRWMrJv7GI/I65zW6qDW9VluegaG9PJ43d/2CFasz3x 930/+1Qk+7FlpXumtxD9w+D0nqlvZ53kspuPt/uvHj00U9ltTrvKxTBF3 2HGHCy8uCt0xyEk+uvmT6jPaSOTL93oRjvL6Kkvu5TXowjnvkipCCdEYj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2664421" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="2664421" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 05:58:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936455740" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="936455740" Received: from mattu-haswell.fi.intel.com ([10.237.72.199]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2024 05:58:09 -0800 From: Mathias Nyman To: pmenzel@molgen.mpg.de Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, aros@gmx.com, , Mathias Nyman Subject: [RFT PATCH v2 1/2] usb: usb-acpi: Set port connect type of not connectable ports correctly Date: Tue, 20 Feb 2024 15:59:45 +0200 Message-Id: <20240220135946.4028553-1-mathias.nyman@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1075b61e-d380-8e45-61e2-33d181444594@linux.intel.com> References: <1075b61e-d380-8e45-61e2-33d181444594@linux.intel.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ports with _UPC (USB Port Capability) ACPI objects stating they are "not connectable" are not wired to any connector or internal device. They only exists inside the host controller. These ports may not have a ACPI _PLD (Physical Location of Device) object Rework the code so that _UPC is read even if _PLD does not exist, and make sure the port->connect_type is set to "USB_PORT_NOT_USED" instead of "USB_PORT_CONNECT_TYPE_UNKNOWN". Signed-off-by: Mathias Nyman --- v1 -> v2 no change drivers/usb/core/usb-acpi.c | 46 ++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c index a34b22537d7c..f250dfc3b14d 100644 --- a/drivers/usb/core/usb-acpi.c +++ b/drivers/usb/core/usb-acpi.c @@ -142,12 +142,19 @@ int usb_acpi_set_power_state(struct usb_device *hdev, int index, bool enable) } EXPORT_SYMBOL_GPL(usb_acpi_set_power_state); -static enum usb_port_connect_type usb_acpi_get_connect_type(acpi_handle handle, - struct acpi_pld_info *pld) +/* + * Private to usb-acpi, all the core needs to know is that + * port_dev->location is non-zero when it has been set by the firmware. + */ +#define USB_ACPI_LOCATION_VALID (1 << 31) + +static void +usb_acpi_get_connect_type(struct usb_port *port_dev, acpi_handle *handle) { enum usb_port_connect_type connect_type = USB_PORT_CONNECT_TYPE_UNKNOWN; struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; union acpi_object *upc = NULL; + struct acpi_pld_info *pld; acpi_status status; /* @@ -158,6 +165,12 @@ static enum usb_port_connect_type usb_acpi_get_connect_type(acpi_handle handle, * a usb device is directly hard-wired to the port. If no visible and * no connectable, the port would be not used. */ + + status = acpi_get_physical_device_location(handle, &pld); + if (ACPI_SUCCESS(status) && pld) + port_dev->location = USB_ACPI_LOCATION_VALID | + pld->group_token << 8 | pld->group_position; + status = acpi_evaluate_object(handle, "_UPC", NULL, &buffer); if (ACPI_FAILURE(status)) goto out; @@ -166,25 +179,22 @@ static enum usb_port_connect_type usb_acpi_get_connect_type(acpi_handle handle, if (!upc || (upc->type != ACPI_TYPE_PACKAGE) || upc->package.count != 4) goto out; + /* UPC states port is connectable */ if (upc->package.elements[0].integer.value) - if (pld->user_visible) + if (!pld) + ; /* keep connect_type as unknown */ + else if (pld->user_visible) connect_type = USB_PORT_CONNECT_TYPE_HOT_PLUG; else connect_type = USB_PORT_CONNECT_TYPE_HARD_WIRED; - else if (!pld->user_visible) + else connect_type = USB_PORT_NOT_USED; out: + port_dev->connect_type = connect_type; kfree(upc); - return connect_type; + ACPI_FREE(pld); } - -/* - * Private to usb-acpi, all the core needs to know is that - * port_dev->location is non-zero when it has been set by the firmware. - */ -#define USB_ACPI_LOCATION_VALID (1 << 31) - static struct acpi_device * usb_acpi_get_companion_for_port(struct usb_port *port_dev) { @@ -222,22 +232,12 @@ static struct acpi_device * usb_acpi_find_companion_for_port(struct usb_port *port_dev) { struct acpi_device *adev; - struct acpi_pld_info *pld; - acpi_handle *handle; - acpi_status status; adev = usb_acpi_get_companion_for_port(port_dev); if (!adev) return NULL; - handle = adev->handle; - status = acpi_get_physical_device_location(handle, &pld); - if (ACPI_SUCCESS(status) && pld) { - port_dev->location = USB_ACPI_LOCATION_VALID - | pld->group_token << 8 | pld->group_position; - port_dev->connect_type = usb_acpi_get_connect_type(handle, pld); - ACPI_FREE(pld); - } + usb_acpi_get_connect_type(port_dev, adev->handle); return adev; } From patchwork Tue Feb 20 13:59:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Nyman X-Patchwork-Id: 13564041 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D6E65BD9 for ; Tue, 20 Feb 2024 13:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437495; cv=none; b=urE1Io/z0AJ3GZOSRQW3C08oJcyJXuaoVMg1Q5RWOv8dMogZDDlhknA89VPvvzRQsWxcEy0OcOML177XNv/gwSslVrQwAdPsSbXfIGYPETTPlsgdYp5Vm9Wd9NZNp82Ko7oIT0hpAWT+6DL9d10/x6sL4vTUoKgSsYvCAnceoZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437495; c=relaxed/simple; bh=QdGpsTdKJUfM48znH89n8Ns6XitLS6UEngRa+Cqz/Wc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ScDCexk62pzeWK3FlIyrNtKn8xpDfXbYhfoUpXJf4mDjfSiZYUh4PukkfohdvHvhLuyFmt8e2bowAwqKCXCZou2WrwCQzr8viurs69xMKYapbnck50SQfTSNAIpk8cMXM1ADzKaxb45+lGaXFd+lmtmjfKiNw38ACyDAtAL1obg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DXiZth1t; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DXiZth1t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708437494; x=1739973494; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QdGpsTdKJUfM48znH89n8Ns6XitLS6UEngRa+Cqz/Wc=; b=DXiZth1t/+4gGxfaY8GMlHJOMb274+KgdVKnwU2uhZQGTwBDJIwZ3Y8v XTpJUzu9ipEbbWy3Ijn6n/M6/7ZcPNHGl/cgQD2Rk/44TQml0B7D9S3bl oQDzLLvkqsaAfq64jVgqtH0BFgw0OeTGASo0PaXWhkWiydzZrRQs9ujCd BUyjfuTDTISm6dZq966s8cspH2droD5LRv/UdphxwBJUekeaif1LaPgzD 2btDeaLF7IL/DXui+CHP5st6LCRZfDuC85gO5GCQFmWrFjcifi2k9Ctxq mmJMfmaaDZfzVppBwo8CWRpwFjgGmceu3iz/zM4NheClleM0WuFOcbTwe g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2664424" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="2664424" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 05:58:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936455741" X-IronPort-AV: E=Sophos;i="6.06,172,1705392000"; d="scan'208";a="936455741" Received: from mattu-haswell.fi.intel.com ([10.237.72.199]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2024 05:58:11 -0800 From: Mathias Nyman To: pmenzel@molgen.mpg.de Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, aros@gmx.com, , Mathias Nyman Subject: [RFT PATCH v2 2/2] usb: port: Don't try to peer unused USB ports based on location Date: Tue, 20 Feb 2024 15:59:46 +0200 Message-Id: <20240220135946.4028553-2-mathias.nyman@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240220135946.4028553-1-mathias.nyman@linux.intel.com> References: <1075b61e-d380-8e45-61e2-33d181444594@linux.intel.com> <20240220135946.4028553-1-mathias.nyman@linux.intel.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Unused USB ports may have bogus location data in ACPI PLD tables. This causes port peering failures as these unused USB2 and USB3 ports location may match. This is seen on DELL systems where all unused ports return zeroed location data. Don't try to peer or match ports that have connect type set to USB_PORT_NOT_USED. Signed-off-by: Mathias Nyman --- v1 -> v2 Don't try to peer unused ports instead of reacting to failed peering drivers/usb/core/port.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index c628c1abc907..4d63496f98b6 100644 --- a/drivers/usb/core/port.c +++ b/drivers/usb/core/port.c @@ -573,7 +573,7 @@ static int match_location(struct usb_device *peer_hdev, void *p) struct usb_hub *peer_hub = usb_hub_to_struct_hub(peer_hdev); struct usb_device *hdev = to_usb_device(port_dev->dev.parent->parent); - if (!peer_hub) + if (!peer_hub || port_dev->connect_type == USB_PORT_NOT_USED) return 0; hcd = bus_to_hcd(hdev->bus); @@ -584,7 +584,8 @@ static int match_location(struct usb_device *peer_hdev, void *p) for (port1 = 1; port1 <= peer_hdev->maxchild; port1++) { peer = peer_hub->ports[port1 - 1]; - if (peer && peer->location == port_dev->location) { + if (peer && peer->connect_type != USB_PORT_NOT_USED && + peer->location == port_dev->location) { link_peers_report(port_dev, peer); return 1; /* done */ }