From patchwork Tue Feb 20 23:22:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 13564757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA8E0C54764 for ; Tue, 20 Feb 2024 23:23:09 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rcZS6-0000kv-TN; Tue, 20 Feb 2024 23:23:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rcZS5-0000ko-UA for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qDyBaqIzeX83wC9UkXq7TkJ2CnOp3HTLCwXxLLTxCy0=; b=VV7kSXoTlthn908WQNc1tXkcNy gvkijYo4dJt8YLhnMkExV9OQ6OL4tI6MvJ7udLlOxVI+7hnz24zy2NXdU7a9Lqu9fstk3tduX0lh0 Sw4at3GYmqCvIYlW/DHpoNjek30WcExlRwa598JvJ/mT61djt1isdlvVP8/cGJ7zkyIM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=qDyBaqIzeX83wC9UkXq7TkJ2CnOp3HTLCwXxLLTxCy0=; b=O aDV9TDZmEKp0ZXnqDtXyYAfY3suTs0aQmjks1ESPOOHUIn1iK4as1opS1ZMnQXefpo2WuGjWt8e4d zxkz+7olSHdflHZRhjdSP6OkrOZNHw1lQKlo2xkumeywb9UE9CgjKNQaOLm6i9zcVEwrx3lSn1viO Mub2EWGjmgKRJ2ks=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rcZS0-0001OJ-Uf for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5E393CE1A9D for ; Tue, 20 Feb 2024 23:22:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D29EC433C7; Tue, 20 Feb 2024 23:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708471369; bh=CBp5JjqsLlKrQ4BNGdzZd5rg9Xdr48xFXWUha9mjqMk=; h=From:To:Cc:Subject:Date:From; b=JCURf4g0DN9i5rfqoTbGnrdxhM3Icz9HiY+JaPFhD/Vy00aaUyiSlcDK+qhCKRHe4 Ho23d5Tk0ARSTuOyIiXNl1w3y7WD7MxcbgvuUrvpLJGQ1LnK8nMWpX+g3GxQNyXSBL 6lqJqOHjTWb0jWAnfk0Btwya+uHHAZpXGFNcVBKoX2w9ADVxVyLfvgBV7piMPa3vi2 LlQFJ/qCULU8kupAvJvCWxJs3lSey6emyWkv8NnNU1Nq6lT4RRkxBsN8XwAcAER0+6 oU8yqP8oNSNUb92exDuKtvR2ojnkhNf0eQmslQ8PHsD7TmRQla/mcX5711a0g49pIM BygBxghqVqC7A== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Tue, 20 Feb 2024 15:22:45 -0800 Message-ID: <20240220232247.2856-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog MIME-Version: 1.0 X-Headers-End: 1rcZS0-0001OJ-Uf Subject: [f2fs-dev] [PATCH 1/3] f2fs: check number of blocks in a current section X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net In cfd66bb715fd ("f2fs: fix deadloop in foreground GC"), we needed to check the number of blocks in a section instead of the segment. Fixes: cfd66bb715fd ("f2fs: fix deadloop in foreground GC") Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 63f278210654..9fe5ec619456 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -560,16 +560,16 @@ static inline bool has_curseg_enough_space(struct f2fs_sb_info *sbi, /* check current node segment */ for (i = CURSEG_HOT_NODE; i <= CURSEG_COLD_NODE; i++) { segno = CURSEG_I(sbi, i)->segno; - left_blocks = BLKS_PER_SEG(sbi) - - get_seg_entry(sbi, segno)->ckpt_valid_blocks; + left_blocks = BLKS_PER_SEC(sbi) - + get_ckpt_valid_blocks(sbi, segno, true); if (node_blocks > left_blocks) return false; } /* check current data segment */ segno = CURSEG_I(sbi, CURSEG_HOT_DATA)->segno; - left_blocks = BLKS_PER_SEG(sbi) - - get_seg_entry(sbi, segno)->ckpt_valid_blocks; + left_blocks = BLKS_PER_SEC(sbi) - + get_ckpt_valid_blocks(sbi, segno, true); if (dent_blocks > left_blocks) return false; return true; From patchwork Tue Feb 20 23:22:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 13564755 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C787FC48BC3 for ; Tue, 20 Feb 2024 23:23:08 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rcZS7-00089n-On; Tue, 20 Feb 2024 23:23:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rcZS4-00089P-AI for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bw6TXE4X6gm7laWa6Ql8TTJbzqDkDWGSGsqct2muGr8=; b=M7SLOSZOnYDAdIICafc3BekbWq kghyCHKJzFFzPG4csQ7biKQq7XwsnkObFbJaGM8uuPzqmKlIXk/ecC1lgVvBJPs/UQEkUmdPaUCNR CrQ26ty7tYQ4ZtJc/Hgn3dCI/efmyRfCEMXqrWZjjDyQ6TuHt9l6dweFSkWm0YLs6Flc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bw6TXE4X6gm7laWa6Ql8TTJbzqDkDWGSGsqct2muGr8=; b=Ma2Iw0UwxY3KLeK4otlxmNrAEP CxC/BGrr9U0ZZ4j53K94byHBFUlLBlfgiLAz0Yx0AyqhUut+3toHwTvisLIHAwSPlR7aVXyfOrB0A XnBrS0CcLKw4Q5Zm37SKmWUOdPQquGjST7vLWkefAadmh89Lz6ojNN/tenlqR/5au9WI=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rcZS1-0001OK-Ho for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 31108CE1B6D for ; Tue, 20 Feb 2024 23:22:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E07C43394; Tue, 20 Feb 2024 23:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708471370; bh=0ms7KVh+AOl9a1lPdIN8NKPVq4XoHxB9aa6kRs4XqG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PddiNl/YazsPYFCCCjB+VXg4HrEqsF7rDKgVkEQBMXqz3QOyKp7+JcTchUDPadrVJ sBPHoSAazM9M5b42J1PYokXzdRadn/GAY+o2pM5zQ2U6t28Ia+EXANZiED5Tc4IRGU SqazlN0wiIcQ03GmdNbMLCY8xG6xwH6rsmG07nEbAc6Re2iwFjaEQ3j82NdR3RPucs Bu01oyqgONjUN9qpLJa8iTidhvtlHaKNBKxWX1Qu1UufjtIP5qg6nY62bUeVPqsXUD LsUea/GcH2yUOs9FoSpsU8+qNp/F3SNhPe2i4GZK8F2UneJzyiVdU6wsL7y5cLIM3Y tuavq7QtWfgfQ== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Tue, 20 Feb 2024 15:22:46 -0800 Message-ID: <20240220232247.2856-2-jaegeuk@kernel.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240220232247.2856-1-jaegeuk@kernel.org> References: <20240220232247.2856-1-jaegeuk@kernel.org> MIME-Version: 1.0 X-Headers-End: 1rcZS1-0001OK-Ho Subject: [f2fs-dev] [PATCH 2/3] f2fs: prevent an f2fs_gc loop during disable_checkpoint X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Don't get stuck in the f2fs_gc loop while disabling checkpoint. Instead, we have a time-based management. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index ad80cd38f3a4..9de467a28fd3 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2190,6 +2190,7 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi) .init_gc_type = FG_GC, .should_migrate_blocks = false, .err_gc_skipped = true, + .no_bg_gc = true, .nr_free_secs = 1 }; f2fs_down_write(&sbi->gc_lock); From patchwork Tue Feb 20 23:22:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 13564756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48472C48BC4 for ; Tue, 20 Feb 2024 23:23:09 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rcZS8-0008A4-CA; Tue, 20 Feb 2024 23:23:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rcZS7-00089e-3e for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FNDCuo8gHnBbIjxMwuCG5lt2/Tx9DQTXvuJq2wdjm8A=; b=TPMyBOLUmXk3mL0rNFrqXy/af2 fJnPj6BuNw4vbzn4MpFPQM0R+okwvbkKtPo0ymo/ihfxVHfnJgYvYtlA09NCoAuo60GizK2eFRQ6R lT/rVh15AzCCnEhhKGIdKSIRnT3eeUtwmp4fcgY4aZmeIF2SRnSiLxhS5aVF9yoI9Tro=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FNDCuo8gHnBbIjxMwuCG5lt2/Tx9DQTXvuJq2wdjm8A=; b=OmDRqM01rpjscHEII1xYxihxDV Xuq4YmJz/uz/7AMl1RljVCYqZE+Mis5YOjUwYeEAxJahVCZoW0nqUmuZYaiauRDcwkOKIqBNDamkH lELXQ9UNwxOI9qhUDqyUUTZ+U9Y2oORkETlqOOtN/Hr/Nrjt+Ja04kTPSRD2FzYtm6Mk=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rcZS2-0001OM-EP for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Feb 2024 23:23:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 17017CE1BA7 for ; Tue, 20 Feb 2024 23:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ED1AC433C7; Tue, 20 Feb 2024 23:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708471371; bh=5v8IyxsitkSm3E3j6jmhK8UZ0QzoeYM3vh4aMTemJxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iv1tVKuuuawAQ4p0vuYR2M1J3RtyHIFgum41/L2Nj8QM8V5PaPq16Vr8Xp65hE3I3 lYD9JRyweKzVeViTscez6aZeJBPFUZbwGLlNH4E/3C9Rmx0YBSwG0LzTUNvf4ol2xM gReZWW3xDHZ9YuDSbU/BCCVs4vjdG9SvDdNXNYbvYSGYuJMWYp8ndIlhifp/jJkWXB N4uLFbA/XMnkpx8bEvbAiTBsLXkYcgdi2L0lUqBYX5h/sS8lpGJf3n7orGlPzZ1Y4J OAQ3ybQC7f4pK1Zzl2wMaXunMQAZ3wx4TSweW3tCgFhuGpfj9b6ruhf8aYwUcKszIH 7hiNSkeXnNJCg== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Tue, 20 Feb 2024 15:22:47 -0800 Message-ID: <20240220232247.2856-3-jaegeuk@kernel.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240220232247.2856-1-jaegeuk@kernel.org> References: <20240220232247.2856-1-jaegeuk@kernel.org> MIME-Version: 1.0 X-Headers-End: 1rcZS2-0001OM-EP Subject: [f2fs-dev] [PATCH 3/3] f2fs: allow to mount if cap is 100 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Don't block mounting the partition, if cap is 100%. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 160ee550cbfe..56927b097e30 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -894,6 +894,9 @@ int f2fs_disable_cp_again(struct f2fs_sb_info *sbi, block_t unusable) { int ovp_hole_segs = (overprovision_segments(sbi) - reserved_segments(sbi)); + + if (F2FS_OPTION(sbi).unusable_cap_perc == 100) + return 0; if (unusable > F2FS_OPTION(sbi).unusable_cap) return -EAGAIN; if (is_sbi_flag_set(sbi, SBI_CP_DISABLED_QUICK) &&