From patchwork Wed Feb 21 09:17:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565157 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9163F8E6 for ; Wed, 21 Feb 2024 09:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.132 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507114; cv=none; b=NdSJsKDUku3ch9HGQgHBOLcq2+s10whWrArKZhXz3A3TWXIDAJNNFDN4Tlfh+dGDzp2iRQFROW8Q8TkGGvKEkSb9qNwWbfF2u04DLnqIzWYCLMuWNCDYtTj8TVgJRQS4kIqAonWcb7PcThw2+UNWtCS0ZKKpwtuyvHF5QSgl2zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507114; c=relaxed/simple; bh=s5Ar4vI5lLQtBQqGzgo6ThJUBQ344s5u3LIjan6VKCM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TKJU7mZeBgWPeQd938NzDxOux4QZ10VYCJLISYOobznz8OFQy2ECzeZVahfeBd3zl0yhu7kyeBnZWvdDqi8VsjPldQ2bRj9ErkeIVQQgZNoqXX/6Y18+/6bpwidLfKi0WxXU4NxmAiA1HG7xZ/CqERu6c47eHHjI/AC7CGygSmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=UGGDDMcT; arc=none smtp.client-ip=115.124.30.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="UGGDDMcT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507104; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=aWlWYGeIVfNjQJkD0X6fpox0R6hzsKqtP6ziZ2TScy8=; b=UGGDDMcTEXf5zNgOecyuPf4oXWbZrE6ci991Q47NiNmhinQwNCsnuzdVYZ/XnFiKX5ZGfGunC2JvPVc0FVC1A11m8a8ot6yQ27K9k2t5Z6ssebnZgE3W/sg3A5FYHQ6gZlWdL1jnZYKyOVoMOq/2zDYP0+fg2H0q7lvI3TpOruY= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zUqTx_1708507102; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zUqTx_1708507102) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:23 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 1/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:31 +0800 Message-Id: <20240221091731.7007-8-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/vdo.c:276: warning: expecting prototype for vdo_read_geometry_block(). Prototype was for read_geometry_block() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8273 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/vdo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/vdo.c b/drivers/md/dm-vdo/vdo.c index 23a4f1d1b6dc..411c58341173 100644 --- a/drivers/md/dm-vdo/vdo.c +++ b/drivers/md/dm-vdo/vdo.c @@ -266,7 +266,7 @@ static int __must_check initialize_thread_config(struct thread_count_config coun } /** - * vdo_read_geometry_block() - Synchronously read the geometry block from a vdo's underlying block + * read_geometry_block() - Synchronously read the geometry block from a vdo's underlying block * device. * @vdo: The vdo whose geometry is to be read. * From patchwork Wed Feb 21 09:17:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565156 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FFF83D39F for ; Wed, 21 Feb 2024 09:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507104; cv=none; b=NmlLa+NpBxUyzrdPeUpHPJc4G6DqnE3RtEc3fYvjH3BwvimRJ8omzLIrawziiF+k2gDguQOImx/7htytd6Wzs/UPyOXCDR2BtxV0mYOyTdVOR9xawKfyczxaZpDhqvnzChcmh3cglz0MBssq/8k+skJt3uDKj5WhO2MZ+ESLpCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507104; c=relaxed/simple; bh=DjgY7bAZ9T8xEy3KDoP6aacTCgTCIWYCv072iKBc3EM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZVmZU05OdQx2BzvAMUT8Ek/oUU/fDJCqfd5XkD5O6Rd+ux22/nestY41HaQjGH66/cDzvvAmqAHP4/uVgDq5H4vIVcQRhjBhXq+DuAxLUbtKean+A3r7DVYji4MSvBZFwfVLClhoKTXmC1k48dQAa97YCZg84EVrwaeslmeaos8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=kGS90Qyc; arc=none smtp.client-ip=115.124.30.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="kGS90Qyc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507100; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=H+yXYdlmM2cTVEG8BEGhhGpI8kjP2TWp0saBUxSR6gg=; b=kGS90QycrCo1qr4Qzh95aVh0fgyszTYUCBdZxhfhYcFDDvcVFoQ6yF64mKFdfbJ+8AwmFYFk4TxP2sg6ipvga/DE/9WpxCw5zMNPZwcU9x7FKrlVV1vRXFfAcmWzyBnnd4Tcr/YSUipdUmBofHxNoelCWkNTf65bGddQGQkXD4I= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R891e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zOZwD_1708507098; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zOZwD_1708507098) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:20 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 2/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:30 +0800 Message-Id: <20240221091731.7007-7-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/slab-depot.c:2042: warning: expecting prototype for vdo_find_free_block(). Prototype was for find_free_block() instead. drivers/md/dm-vdo/slab-depot.c:5036: warning: expecting prototype for get_depot_slab_journal_statistics(). Prototype was for get_slab_journal_statistics() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8274 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/slab-depot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c index b11972a8a08b..a85d2983800d 100644 --- a/drivers/md/dm-vdo/slab-depot.c +++ b/drivers/md/dm-vdo/slab-depot.c @@ -2029,7 +2029,7 @@ static inline slab_block_number find_zero_byte_in_word(const u8 *word_ptr, } /** - * vdo_find_free_block() - Find the first block with a reference count of zero in the specified + * find_free_block() - Find the first block with a reference count of zero in the specified * range of reference counter indexes. * @slab: The slab counters to scan. * @index_ptr: A pointer to hold the array index of the free block. @@ -5026,7 +5026,7 @@ get_ref_counts_statistics(const struct slab_depot *depot) } /** - * get_depot_slab_journal_statistics() - Get the aggregated slab journal statistics for the depot. + * get_slab_journal_statistics() - Get the aggregated slab journal statistics for the depot. * @depot: The slab depot. * * Return: The aggregated statistics for all slab journals in the depot. From patchwork Wed Feb 21 09:17:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565154 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251153D54C for ; Wed, 21 Feb 2024 09:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507101; cv=none; b=cDNc+KjH1i9yjybrLulbhryrh6An1dXskpW0POEWggJ7mm5/tr8iCYAtXYu5sqFbyOGv6RpfJEDOKdkm2Wx2RHpvacwTCQ0TZ3Re8kG4V0lUme7viJGPYWAxlHiCf230mWG1VXCc3jx3QSCILEgQFeCoDuPbjJz1CoOYEEaj2aU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507101; c=relaxed/simple; bh=H60LSo+ZBPcO6OqcwW9qvKbRC/ecwKW5PD9SHfJakOU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HBxhqdVIAIl8BmsNr+PrZjD4jBrojjwlbjZqXDIHl0XHFpKhZfS33T9NHPCNHITK9InoaBK9r4TK1L58KA7wSD+461veRAEO1Nn25CETkQnfUKfqVp63QAzArcjKKrX2kBVqELpPaqltmUEBsKyvqXKWnNj7pUj5nyzQHIm9Y8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=FnOUId1D; arc=none smtp.client-ip=115.124.30.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="FnOUId1D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507097; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=jhEIWtVJuyuBjNM1WD3786nYKFFH4yuhOqLm6acwxvk=; b=FnOUId1D9ww83/hto0eRtxel3UULUflKpRg42/JWng/6qx7nrQmdT2psSfmHhUHZcQP00q+R1vAdhRnChCK+0+8GEWh7qVjDz7YgWSZZ6RtETFUlZ5Uml+JVLpEw16whwuKudJEFUYxPsOMp2a9fpxcIo1mIyq0yBD5lYTkLQc4= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R681e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zMlgV_1708507094; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zMlgV_1708507094) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:16 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 3/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:29 +0800 Message-Id: <20240221091731.7007-6-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/physical-zone.c:268: warning: expecting prototype for vdo_free_pbn_lock_pool(). Prototype was for free_pbn_lock_pool() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8275 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/physical-zone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/physical-zone.c b/drivers/md/dm-vdo/physical-zone.c index b80c4d3a9bde..14d502ea77c9 100644 --- a/drivers/md/dm-vdo/physical-zone.c +++ b/drivers/md/dm-vdo/physical-zone.c @@ -258,7 +258,7 @@ static int make_pbn_lock_pool(size_t capacity, struct pbn_lock_pool **pool_ptr) } /** - * vdo_free_pbn_lock_pool() - Free a PBN lock pool. + * free_pbn_lock_pool() - Free a PBN lock pool. * @pool: The lock pool to free. * * This also frees all the PBN locks it allocated, so the caller must ensure that all locks have From patchwork Wed Feb 21 09:17:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565155 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E53553DB86 for ; Wed, 21 Feb 2024 09:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507101; cv=none; b=UX9p3wOVAn2H0LG01pQOycEDOR5pQ2DlnE65iN7HS0hwflPD2sLXUyrh+jQbLEdbCbA9biIeqbbeDjE/rE+gESze7f11Wrk/LYxP+NktfjqGZlXLMKIRpYj9nDzpc45G8gaWV6XHfLaN0OfEQ3ERBKsHhz937L92+8K+Njb2JwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507101; c=relaxed/simple; bh=3KXb9nXpObxqm6iBD7n6ssU5Vsa79GNEX+w8fQbJzKY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cA2F3BR3Yteh5o3Iy8Fx7HomUq/nKiBHtSnzXdFqawvyls/zegnS0y+hz2fIU47+fgf63seMZ7bonFW9etR4TVTXmROezsN6+gk4Z+2pTsJnxGk43nqCeMmGSvucdxljRkWqBuXftxcqzADmq5sP4Ec06a5tCZh+wOrYbBqVr6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=Hja2l3Tc; arc=none smtp.client-ip=115.124.30.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="Hja2l3Tc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507092; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=hCL7kDhpLqny3OO9KnxYcH7qd7yJnytkUmwgoFbh7d0=; b=Hja2l3Tc24Dh7ZXHxNuhOx8dRPj2Lu7Dq77PoYXK8P5UCovcQzEWW3xEoP7GOcQOWph5Sz8JZ4Wczrxx6JSAZQEvH1DpJ8spj1jjzy6w57iDJaIO0xrviiVru7/wPPa1hhrIazOkNUNO/9EVcL/uA771ntuFWYHADJzUeo90j1w= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zPi4s_1708507089; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zPi4s_1708507089) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:11 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 4/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:28 +0800 Message-Id: <20240221091731.7007-5-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/logical-zone.c:303: warning: expecting prototype for void attempt_generation_complete_notification()(). Prototype was for attempt_generation_complete_notification() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8276 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/logical-zone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/logical-zone.c b/drivers/md/dm-vdo/logical-zone.c index a040fe9c0779..131161e0c152 100644 --- a/drivers/md/dm-vdo/logical-zone.c +++ b/drivers/md/dm-vdo/logical-zone.c @@ -295,7 +295,7 @@ static void notify_flusher(struct vdo_completion *completion) } /** - * void attempt_generation_complete_notification() - Notify the flusher if some generation no + * attempt_generation_complete_notification() - Notify the flusher if some generation no * longer has active VIOs. * @completion: The zone completion. */ From patchwork Wed Feb 21 09:17:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565152 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0CCF3D555 for ; Wed, 21 Feb 2024 09:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507092; cv=none; b=uI8BWYARxOT4tOxiBNKy15ELNjWF9ykcSMo8WhNKvM9Lrgi1IO4MVDpE5fSLU36ZwJZwvZrV7yCTpL8vT+X/ris5MbP+jVKSs70xnyze1NdHs/mC057oZTiQ9TzQLAgVC3YQwtwYt67Mb+AeTUo0WXslW2a11HwZ/nFfmpUPX/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507092; c=relaxed/simple; bh=5Lxs48T8AxpFP98KzY19UdH25ICYzMJoceSfQD6LMiI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=crWa50ASQBeuF3ayhuNj19qeA1SpVKHvRkmlKBt6Sd6t7DfvciDrqbNq1SBDd55NjLHYwErofi0T9kYdG5f/3tQOUDW3roCvxkbfYn6BnpWkBUK1cbywnYvcXqKKoDS1W2o971TU9GdXlaZwIGlZIfYZvoPTmr+YpFN4I7ZyI+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=AlLDZCrU; arc=none smtp.client-ip=115.124.30.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="AlLDZCrU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507086; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=hXTbZ/tv0rwC9GbkQStp8PP86sctTo9nhY1TiyFUbq4=; b=AlLDZCrUz7ZWNqnrRKr7QhYKZAilz7LWir1dUESAEE95MbLNW9NnDWUK6sYOCvwLIgMEuY/n4ACW/MKvwxfXTlAi248XVmR+If8+AxSvElK1KvfnxH8SoWk3IUKY0B/Hdybbn2vywsFe+f11DZbThouM2GrZQYreRPLarRm+fuQ= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zPi2h_1708507083; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zPi2h_1708507083) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:05 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 5/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:27 +0800 Message-Id: <20240221091731.7007-4-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/encodings.c:1178: warning: expecting prototype for vdo_decode_component(). Prototype was for decode_vdo_component() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8277 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/encodings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/encodings.c b/drivers/md/dm-vdo/encodings.c index 42ffd793deeb..f4fee2c1d656 100644 --- a/drivers/md/dm-vdo/encodings.c +++ b/drivers/md/dm-vdo/encodings.c @@ -1170,7 +1170,7 @@ static struct vdo_component unpack_vdo_component_41_0(struct packed_vdo_componen } /** - * vdo_decode_component() - Decode the component data for the vdo itself out of the super block. + * decode_vdo_component() - Decode the component data for the vdo itself out of the super block. * * Return: VDO_SUCCESS or an error. */ From patchwork Wed Feb 21 09:17:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565153 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A523D54C for ; Wed, 21 Feb 2024 09:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.113 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507092; cv=none; b=hhGc4es5Q9m7PA8bEXGjyGelIi5e70cRc+SOrpuO6ZkqLg/CzhLY+kmaW0t85p7sCB9OjADOQ7kVYHsjusGFbOUF7Jpf3UVRkQ4Jdlciucr0VMHE5boFRy6ay7+nrHBM6uoeHC58px/wVD8X8oY37a/26Qnm70Um4R4Sgd7lQXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507092; c=relaxed/simple; bh=Ro149mtR33sBAX78qfBcjmuA+prlryiG9GLzx79kIRk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eeVkCweSouSwkS948w8iu8CfGjwXhdv506+vwGwAhDCN9ZOBEu5w9XytynZ5OnNuz8YE0eQvr251Hfv7gGahT4M8oaRikAHwNQ/330FyEfrEmTHJCJd4cFO85uS+YmzZhAyG8HyFFPOKuJAOLzr8WtWzUWRQchFmI8PFrDBZOPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=IQd1Nuev; arc=none smtp.client-ip=115.124.30.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="IQd1Nuev" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507082; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=110m7iZc1QLgWsXce59I4X/s2/RhnD8RnHOHhZoz85g=; b=IQd1NuevHtDTaw39RcHDYewFAw57AJXzkpS2QqKJz+60rla7WEinc7zy79Sp7R2JvXXCjb2KRELXyxTG/SB2lcP16lAw80IDsHZ/e+6OD+zfKpu723DiWxde9Ur1VZbTcTcR1HOBfHMWaSumLt9Ip/KIaiJgxwD+WKnxk15Ncm0= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zSe40_1708507080; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zSe40_1708507080) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:18:02 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 6/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:26 +0800 Message-Id: <20240221091731.7007-3-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/flush.c:97: warning: expecting prototype for waiter_as_flush(). Prototype was for vdo_waiter_as_flush() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8278 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/flush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/flush.c b/drivers/md/dm-vdo/flush.c index e4be450aa12c..57e87f0d7069 100644 --- a/drivers/md/dm-vdo/flush.c +++ b/drivers/md/dm-vdo/flush.c @@ -88,7 +88,7 @@ static inline struct vdo_flush *completion_as_vdo_flush(struct vdo_completion *c } /** - * waiter_as_flush() - Convert a vdo_flush's generic wait queue entry back to the vdo_flush. + * vdo_waiter_as_flush() - Convert a vdo_flush's generic wait queue entry back to the vdo_flush. * @waiter: The wait queue entry to convert. * * Return: The wait queue entry as a vdo_flush. From patchwork Wed Feb 21 09:17:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565151 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BECA3D39A for ; Wed, 21 Feb 2024 09:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.118 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507083; cv=none; b=ei5ImQD5hSsmu+Sfu2xcbKkUPyRBBj+Pp1UjpYZAgotvrlauoKw9FCv3iQs+qBYIDSOX0ST1NNsp8Q+aVImcH09/CfEW34SNvmML3IvBY7R7DnK67yzF7ZEWASGNgx7midczgG9pFid4CkXgvr3qEdj+5tITd3OZYJPEP/fWFzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507083; c=relaxed/simple; bh=wAQj5nvfCIOH1JW9X4ndLX9htm/n/DPR7gaftd4bR28=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uwBoGySKifXFAaJtfM0clpc7oLysEDgDweFeH8t6n74YOSzkvSMw4fFEgggpYep1GT7Oo56reIQxlT9IDOiQHR9AxIJi4cCrVizA4vVqkVzMsG9XwNoKdtn/SHB6lhp7y3Z4vBoKVYrRY5zvuqcvwNGZbJw9DTGaBQaytWrTZkE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=bwpzQIri; arc=none smtp.client-ip=115.124.30.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="bwpzQIri" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507072; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=vb2IT9WftsLMsivtOiIkK93g1bjf2OnNq4gtLguxxug=; b=bwpzQIrihbiGrIlF+xLcpm7X9capHY+FkTxLDtyGiUvm2O/nUtj448zqMZxZhCogvOwEGSDbHmkrk1Uv+dJ6umxxN1wOJiZj8/p1XEZo/YqmKbfVZ2n7SLEUswEDo19QEw+TzMlQg/EaMq5xvXzKmYpxQs0YudrTj01pAYdcYVU= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zR752_1708507069; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zR752_1708507069) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:17:52 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 7/8] dm vdo dedupe: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:25 +0800 Message-Id: <20240221091731.7007-2-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> References: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/dedupe.c:2792: warning: expecting prototype for vdo_dump_hash_zone(). Prototype was for dump_hash_zone() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8279 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/dedupe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c index a9b189395592..a2535e909a80 100644 --- a/drivers/md/dm-vdo/dedupe.c +++ b/drivers/md/dm-vdo/dedupe.c @@ -2785,7 +2785,7 @@ static const char *index_state_to_string(struct hash_zones *zones, } /** - * vdo_dump_hash_zone() - Dump information about a hash zone to the log for debugging. + * dump_hash_zone() - Dump information about a hash zone to the log for debugging. * @zone: The zone to dump. */ static void dump_hash_zone(const struct hash_zone *zone) From patchwork Wed Feb 21 09:17:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 13565150 X-Patchwork-Delegate: snitzer@redhat.com Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B32F53C6BA for ; Wed, 21 Feb 2024 09:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507078; cv=none; b=VcvJU9ec8LARk5/jYAxxf60rhlxHoomlEGbYWCAVSQonfQDnNyAPZG6Ag+PRCCsjCZQ/ga/4oSpEYvUAup4BrJ5uAyZUxiSkCVfauU1gmTSMqgJjRWT5Mhp1ceYE8qKZaDrayBSatNt1FjwED9xvDTNGh56EU40sKOYxXliTSCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708507078; c=relaxed/simple; bh=G2NE9a3jMDn12v81Nz9NQjkLjoIDixLqd4nghLAIyiE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pHCTr1CJT/HcRdqJSNvgn5Lq8qVxnXiepXWLotPNJS/FVGd2Vm/bLp3oUZZi97Jab1L61vFx/F4K+Fhyw8VOj/wdSktpdh1GwImQTqYvHpgzf9D7SXX0IVDQr2iCiu0Au7B5P8LWUlUkrmoTLkjh4ZTVhyS8ibTJZPyPlkosAYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=rXkE1wVI; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="rXkE1wVI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708507067; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=TQpuyVvZ75dhIqkp8INYA616KkgNbSy6gSD3mv59K00=; b=rXkE1wVIFIkHfKvDlgkBbxKqG/Ngp9XGI0UJmlBTEPRbjBKcgVQ5C6D1kKw3PyGuEYms1v20KHKh3lsg8H/nkNX5tHE21FE4iAteuH6Ap8Wl77QbAXQ9lpfO948CKnUuT30PPAQdtrIK2ZjL4A8ovaswm/PyRudaGSSiKf0kU9c= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R321e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W0zPhvC_1708507063; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W0zPhvC_1708507063) by smtp.aliyun-inc.com; Wed, 21 Feb 2024 17:17:45 +0800 From: Jiapeng Chong To: msakai@redhat.com Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 8/8] dm vdo: Modify mismatched function name Date: Wed, 21 Feb 2024 17:17:24 +0800 Message-Id: <20240221091731.7007-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No functional modification involved. drivers/md/dm-vdo/admin-state.c:310: warning: expecting prototype for vdo_drain_operation(). Prototype was for assert_vdo_drain_operation() instead. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8280 Signed-off-by: Jiapeng Chong --- drivers/md/dm-vdo/admin-state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/admin-state.c b/drivers/md/dm-vdo/admin-state.c index 8663c1e91616..3f9dba525154 100644 --- a/drivers/md/dm-vdo/admin-state.c +++ b/drivers/md/dm-vdo/admin-state.c @@ -300,7 +300,7 @@ static bool check_code(bool valid, const struct admin_state_code *code, const ch } /** - * vdo_drain_operation() - Check that an operation is a drain. + * assert_vdo_drain_operation() - Check that an operation is a drain. * @waiter The completion to finish with an error if the operation is not a drain. * * Return: true if the specified operation is a drain.