From patchwork Wed Feb 21 09:53:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13565370 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A9CDC48BF6 for ; Wed, 21 Feb 2024 09:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUuIh1z8nT8ocBt5HjdEbc3gUuENTfblQ7HlZ+Fqz6Q=; b=aPAStWapy9IW83 7NmNFILodBpOmXKq2BjxwarSPm7RcuWwGt/AlEv4tYxQ0Z1dXohuxMfeN/TqPWEsuEKNY+Ud/vMAr tF1OzH85TTzAKTFuD+sNhn/DQri2PU+DIThh35YJDc9Go74Ss5id1yc+S0/3f1A5v7GBakL1QV2Gt mWKhKdGHA1oxDkox+/fzj2Og5cF7pHpHAgN7Q/cARkS3nUvky16YQ0ZwII3cNoCyUJNvHNcBrLDZ0 Io0AtLmBgHzO5vHnjD7Wt9RWV04xRqcC2jLVSirl80vh0YVnhp6hMcCWmP25ADvaCMkgqtwOk40/u E1tFi6GfSOKHgYtlWwWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjJ3-00000000Mtf-3X0G; Wed, 21 Feb 2024 09:54:25 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjIx-00000000Moi-0s1I for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 09:54:20 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcjIp-0007GU-44; Wed, 21 Feb 2024 10:54:11 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcjIo-0020pL-Cd; Wed, 21 Feb 2024 10:54:10 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rcjIo-008mZ5-0z; Wed, 21 Feb 2024 10:54:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH 01/11] misc: atmel-ssc: Convert to platform remove callback returning void Date: Wed, 21 Feb 2024 10:53:45 +0100 Message-ID: <45719fc31bb893bb9ab1450057e9cb7f399e9ee2.1708508896.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Y12US4C+WpRtTcOYvQXBN1eT1BAAVd09UhWYjrdPEuA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl1cgr2tbo0Q/3qRAJuARuaXItbnWGugcp9POOK W5AvGtmhbqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdXIKwAKCRCPgPtYfRL+ TnN6CACloQR+H7u0kOPEPLRucMXlrOPNZwitEdE/qVCXMT1E8X6LEmDLkoSUCW4dkuX33c1t/4Q GxSJ57XRUTivvl07ita9G85rDW/qdzXeDRA2WVdfn7002TSZUb91TjSfA7Zb23aC0l0QBp/e36v LxM6TnMFGa14GmvuKdIwDACXLr8D3qchqvdHF0an1Ze2Y9Ad26MOgSZejPYfNi2YxEGB1y+TgwA GL270oYjPgPziv9fTufK7RcDRSYEDOOatU6p57nVJ9qmaKJI5AOgoXcwWRmhZN6We/owjE8GcCH ueBVQCjvLGLnQy8HLnbUaq4W4eCtpqmlE/Tno3azHtM1YwI9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_015419_405359_280D217F X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Claudiu Beznea , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Nicolas Ferre --- drivers/misc/atmel-ssc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index ee590c4a1537..6eac0f335915 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -251,7 +251,7 @@ static int ssc_probe(struct platform_device *pdev) return 0; } -static int ssc_remove(struct platform_device *pdev) +static void ssc_remove(struct platform_device *pdev) { struct ssc_device *ssc = platform_get_drvdata(pdev); @@ -260,8 +260,6 @@ static int ssc_remove(struct platform_device *pdev) mutex_lock(&user_lock); list_del(&ssc->list); mutex_unlock(&user_lock); - - return 0; } static struct platform_driver ssc_driver = { @@ -271,7 +269,7 @@ static struct platform_driver ssc_driver = { }, .id_table = atmel_ssc_devtypes, .probe = ssc_probe, - .remove = ssc_remove, + .remove_new = ssc_remove, }; module_platform_driver(ssc_driver); From patchwork Wed Feb 21 09:53:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13565368 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7229BC48BC3 for ; Wed, 21 Feb 2024 09:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9U+hW60EyRRhFPRQzMBflM797gVyoVGXWcYuQH+s85M=; b=Q4wQF0Ye/JW1bs U9LbH01jYtZ5pvRH+W6diUwQFLwMDDJ/GtXLcgBsTZr6h+ATsikuBPF4Nkx+PVm6HuWtkvRIAuxI0 yh81KvHq3gZRkGV8FKGs5u5v2A8MWr4CbrUsJnsfenth/xq157jnljOItkpw1lH1OuYHU7Rio3LxS ftzOhCqUmYJpny56ClO/65dGcsW6cUueP9LhCf6u0JeaqfKFq4fQKBpWQYC59fFAD5ReBKg9puoIA w0BKl2rU61jBXi4c40EbVd2jGEKK3wuFXg7xkKAoG0C33E+q4XZ76XjYNksolENm7LmhaSHG5E6GL zUb8mAVvXxpYOsiBhFpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjJ2-00000000MsK-00xi; Wed, 21 Feb 2024 09:54:24 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjIx-00000000Moy-0wnp for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 09:54:20 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcjIq-0007IJ-7A; Wed, 21 Feb 2024 10:54:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcjIp-0020ps-OU; Wed, 21 Feb 2024 10:54:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rcjIp-008mZl-2B; Wed, 21 Feb 2024 10:54:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: kernel@pengutronix.de, Derek Kiernan , Dragan Cvetic , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] misc: xilinx_sdfec: Convert to platform remove callback returning void Date: Wed, 21 Feb 2024 10:53:54 +0100 Message-ID: <705b89c3cd7c0a42ce3f482f202204f5e3377aa2.1708508896.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1818; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=VxfuHppooGvLYcqyujJixgDeq0NOYDY6Z9s4et8wZLo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl1cg2clFZNoEecENcB6Zbo4fh4KajT1/bgMUhP rY2buIYSW+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdXINgAKCRCPgPtYfRL+ Tv/BB/91akfTAn2h0Yk5ZAIm5zYDFPx58IDzHHkvqb5tNofqwSlKI1M8QJS5qBt9Cp2oJAEFBHo Iz8fJy0AFPsz6NXCijBB67WKMgP1QM6fDWp7VhbvrdxfAmvg3BYZdfsli2k9C6VLiUz6HV5ik2r vzaZXcvbn6IfsZgq2QbqN6cuzIw6o3JZnAWNCtD1Qbc5pCqtihs/tb4e9xH3g8o0qk828mEPdl4 ig5tVjYbZmDyI0RiNJH971F9zREqpBmCMnrDU1bdCcfTAK04gj2kq9/piSa+sQC9nvd3IuvOTTX Lbb8JXa7zmKluQXUKCIzc6HCoeUNWi62SFiPldsWqOiP3MeN X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_015419_422651_377374F6 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/misc/xilinx_sdfec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c index 94a0ee19bf20..ea433695f4c4 100644 --- a/drivers/misc/xilinx_sdfec.c +++ b/drivers/misc/xilinx_sdfec.c @@ -1420,7 +1420,7 @@ static int xsdfec_probe(struct platform_device *pdev) return err; } -static int xsdfec_remove(struct platform_device *pdev) +static void xsdfec_remove(struct platform_device *pdev) { struct xsdfec_dev *xsdfec; @@ -1428,7 +1428,6 @@ static int xsdfec_remove(struct platform_device *pdev) misc_deregister(&xsdfec->miscdev); ida_free(&dev_nrs, xsdfec->dev_id); xsdfec_disable_all_clks(&xsdfec->clks); - return 0; } static const struct of_device_id xsdfec_of_match[] = { @@ -1445,7 +1444,7 @@ static struct platform_driver xsdfec_driver = { .of_match_table = xsdfec_of_match, }, .probe = xsdfec_probe, - .remove = xsdfec_remove, + .remove_new = xsdfec_remove, }; module_platform_driver(xsdfec_driver); From patchwork Wed Feb 21 09:53:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13565371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E17B2C54764 for ; Wed, 21 Feb 2024 09:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NdPWq6jTL6DC9d5ErQcKhFiVrPl3PPA87ODlvCic+c4=; b=3qbo45UVmHVfpQ PKxpRUlQKll8CmMZELJpjOaDy02fMLUNvbReqgbdfTzN5+F2LDoacyCt4eaYpuTjDb42vQgE3QB+m y8HUU4l7iNuX2Bw5kkd+9xsSEx6v14vuN24qwDf5KG374m0ZSt0PM08HlNaiFnnd6mX/J4KS0Ou/Q 9tz7A/Xa2rXUVFERW0ddWk5z4JFybBnUz2LwFMfgJvAIIqTerB9Gvyz3ctfKvYZUhbI9zcGx+auSx TN0hobaD8u4wAzWbAQardqiypaBykJgjgIY74mW7YIJOqRhiKRraCUv/PmsEj05jqkiOCHINFocmE ZwtJTX1AHie3Sf81CP9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjJ2-00000000Mt4-42bM; Wed, 21 Feb 2024 09:54:24 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcjIx-00000000Mog-0rSe for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 09:54:20 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcjIq-0007Ik-Ec; Wed, 21 Feb 2024 10:54:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcjIp-0020pw-TW; Wed, 21 Feb 2024 10:54:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rcjIp-008mZp-2h; Wed, 21 Feb 2024 10:54:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Arnd Bergmann , Greg Kroah-Hartman Cc: kernel@pengutronix.de, Appana Durga Kedareswara rao , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] misc: xilinx_tmr_inject: Convert to platform remove callback returning void Date: Wed, 21 Feb 2024 10:53:55 +0100 Message-ID: <198112757eac0fc004677a4757ce48ae7c7194ab.1708508896.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=aVX7CawhH3qa0cDrgvRo+u3JaL3iPMKiw1wYFuGdRaA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl1cg3i12P3AFF5hN9xxxKjObFB8Opb/S6JiL7Y QyrNxpImmuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdXINwAKCRCPgPtYfRL+ TkIDB/40DS+jNpK7mW/zj5sYEayFRQSSPz+4UZyoeR+sn9fVwBQa7GRLchbqI+O0PU72agCU/sa ifrDHoMM3ErDbjQ4wP5m3ABLfT96BtYkAtvMdSCi3k/TuVIKWklzZF4jvnv4IZ23xO1wih3Ibcn 55Rt3k928CsxAY1O3rwc8ajXJ3juNX/zQ/M6iQg2vkLPKaNa62+9abmBwiayzX5XmAk0F8z/sPy 3sHR2OjHxZNP3ia5S664f/Z5qBBtz8dVEMHGTj0HRN7toPOKK9z2YhQfoqT+CeQvQvc2wy4k1D6 /rBQuL7EvJ3qe5zU2KbqjGVu1YPvHG6Q5fLYQC22gi2Q8a9u X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_015419_377603_3DF24A9E X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/misc/xilinx_tmr_inject.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/xilinx_tmr_inject.c b/drivers/misc/xilinx_tmr_inject.c index 9fc5835bfebc..73c6da7d0963 100644 --- a/drivers/misc/xilinx_tmr_inject.c +++ b/drivers/misc/xilinx_tmr_inject.c @@ -143,11 +143,10 @@ static int xtmr_inject_probe(struct platform_device *pdev) return 0; } -static int xtmr_inject_remove(struct platform_device *pdev) +static void xtmr_inject_remove(struct platform_device *pdev) { debugfs_remove_recursive(dbgfs_root); dbgfs_root = NULL; - return 0; } static const struct of_device_id xtmr_inject_of_match[] = { @@ -164,7 +163,7 @@ static struct platform_driver xtmr_inject_driver = { .of_match_table = xtmr_inject_of_match, }, .probe = xtmr_inject_probe, - .remove = xtmr_inject_remove, + .remove_new = xtmr_inject_remove, }; module_platform_driver(xtmr_inject_driver); MODULE_AUTHOR("Advanced Micro Devices, Inc");