From patchwork Thu Feb 22 10:02:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13567002 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EAF538FB9; Thu, 22 Feb 2024 10:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708596212; cv=none; b=gLDYlF4AcYqhyIp2R7ZrOa3Evko6Edll514Sz0vIYpXU8dZEFdvnifI+MtlYTShDUQ2pBiX8SxJcag26w8wHcylwFEO38eJaXBA3A3BwyYg+YBmDTgBEKb6YXAC+AlECD1njGzUe7fYswWnh/FchBremZ1V1+i1+RmXWEgX9fY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708596212; c=relaxed/simple; bh=0AggU31CGt9Ylb7dMMATQT5arx+9ift1Y5YR/y3R+MU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HVA2/o63OWHAkc/V253Ee6ziw6SMBdcVL9/FT3++ZLrU4V6XpfSw0M+g2TmCg4/unAqW7yRW53x+bFWykaUIsEWAK7MO+2Wt9FdERifXdyupyLPP4YKu+HIgOMgjJ4idxxF6CdcpEPOOLg+4xtr3XoIpUdjw5mwrTA/Uv+SkQno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M6Fe4TK8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M6Fe4TK8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A975C433F1; Thu, 22 Feb 2024 10:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708596211; bh=0AggU31CGt9Ylb7dMMATQT5arx+9ift1Y5YR/y3R+MU=; h=From:To:Cc:Subject:Date:From; b=M6Fe4TK8tyMXPrN5n3UA3CMidv/F0/zv9WlgWVDiLyjsRIvkZDgUECgErqur0N4/d BEpUb6hdqeYViHQjlHxqcFvFJFlQUOZKDI44b3/cKgAIZL1F/wooyjj9ABOEOu9p5Y 1277HuwsBDyZrDwlOY77ie08vHxOXchwQ6pmHGZjWQzOfZ6947Rte+CCDWLgxHBQmS XtenB0iA0TJlpvSv5CKPxN/aYbDQhVfv4iYUKnENXlCLFwBwYO5mtI56klb44M0XhB SclZjstRT4iLXKZGNMIrScxEAacBniTrTWufVS32T1dd7aKO8kjYQKxFNb/IlmUxcF keHbag2tHwuZQ== From: Arnd Bergmann To: Jesse Brandeburg , Tony Nguyen Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] igc: fix LEDS_CLASS dependency Date: Thu, 22 Feb 2024 11:02:13 +0100 Message-Id: <20240222100324.453272-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann When IGC is built-in but LEDS_CLASS is a loadable module, there is a link failure: x86_64-linux-ld: drivers/net/ethernet/intel/igc/igc_leds.o: in function `igc_led_setup': igc_leds.c:(.text+0x75c): undefined reference to `devm_led_classdev_register_ext' Add another dependency that prevents this combination. Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226") Signed-off-by: Arnd Bergmann Reviewed-by: Kurt Kanzenbach --- drivers/net/ethernet/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig index af7fa6856707..6e7901e12699 100644 --- a/drivers/net/ethernet/intel/Kconfig +++ b/drivers/net/ethernet/intel/Kconfig @@ -372,6 +372,7 @@ config IGC config IGC_LEDS def_bool LEDS_TRIGGER_NETDEV depends on IGC && LEDS_CLASS + depends on LEDS_CLASS=y || IGC=m help Optional support for controlling the NIC LED's with the netdev LED trigger.