From patchwork Thu Feb 22 17:06:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 13567611 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEE28153BC9 for ; Thu, 22 Feb 2024 17:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621558; cv=none; b=mFp2ivs/zqU86k0NtsCgplpmz0dHXmhiHeHarSUHU+PyCObTsWkX6b8T9gsppFtciou2Caq9tVY3IdL1MIa3vCB10kHmtlZKwSZX2MIsHci7pZRS0hyElpGwg8Xx8wy/pH8q98Va4LR6Yi0N4vrkjnYkK8x6LYU38iCPFEuApS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621558; c=relaxed/simple; bh=FgvZABVdcDQjiW6UTsk7+nZcUDYDiqk6G+wQrxlYAhY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VBMz3VQTB8WWlCn0b8YbIdukGcqjFbm9HntS4fnHx6BhzHtBnR+ACzRa8f+qJSAFlfIbQEyXyBvFQU9nRsYLXGgmJrEV4aFqe0vSpanoYgi1Egj5hW5FTn9Kt5ezTRC/KoEy9ae1TAmc/CCTJtYmRUkx8LLnGNOTFq0w4Z61vzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D9dQ2xmh; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D9dQ2xmh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708621557; x=1740157557; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FgvZABVdcDQjiW6UTsk7+nZcUDYDiqk6G+wQrxlYAhY=; b=D9dQ2xmhwYkOOLaoGW7TwX6k5WBRvNf/AmBs8VF/OpUA4kmOr+cHasN6 XHCSYR0YcnT8hOKC+6JC1V/uM40g9qIMBg7LUjWQ17ffnab632bHm1x3X +5B5oECP0QqDxfTcuSIRPDlrMgb8hDQ3DZrZ2f8C5bWqetnTMJzDGIXyi g4Th/s4p8xA+YdizT9Vxdm4x2K4ArvYI/2930qLnPvdBX84C+AYLfXYI/ YgJqQuOB/KNqjfwvjZVgA/Kp+7mcfVWTzSvwr/GARJQDg7vUWabcnigYb 2nBIM4KI+XNdaJCihVl3+VHP5Di0kSfl6jiVptv3VV/3449pUlK+am3M0 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="20299201" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="20299201" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 09:04:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="827575236" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="827575236" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by orsmga001.jf.intel.com with ESMTP; 22 Feb 2024 09:04:53 -0800 From: Cezary Rojewski To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, Cezary Rojewski Subject: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms Date: Thu, 22 Feb 2024 18:06:11 +0100 Message-Id: <20240222170614.884413-2-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240222170614.884413-1-cezary.rojewski@intel.com> References: <20240222170614.884413-1-cezary.rojewski@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as valid candidates for i915 binding. Update query mechanism to reflect changes made in drm tree. At the same time, i915 support for LKF-based platforms has not been provided so remove them from valid binding candidates. Link: https://lore.kernel.org/all/20210728215946.1573015-1-lucas.demarchi@intel.com/ Signed-off-by: Cezary Rojewski --- include/drm/i915_pciids.h | 4 ++++ sound/hda/hdac_i915.c | 18 +++++++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index fcf1849aa47c..04172b541ee7 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -582,6 +582,10 @@ INTEL_VGA_DEVICE(0x8A51, info), \ INTEL_VGA_DEVICE(0x8A5D, info) +/* LKF */ +#define INTEL_LKF_IDS(info) \ + INTEL_VGA_DEVICE(0x9840, info) + /* EHL */ #define INTEL_EHL_IDS(info) \ INTEL_VGA_DEVICE(0x4541, info), \ diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 365c36fdf205..07861f9fc491 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -127,15 +128,26 @@ static int i915_component_master_match(struct device *dev, int subcomponent, /* check whether Intel graphics is present and reachable */ static int i915_gfx_present(struct pci_dev *hdac_pci) { + /* List of known platforms with no i915 support. */ + static struct pci_device_id denylist[] = { + INTEL_CNL_IDS(NULL), + INTEL_LKF_IDS(NULL), + { 0 } + }; struct pci_dev *display_dev = NULL; if (!gpu_bind || (gpu_bind < 0 && video_firmware_drivers_only())) return false; for_each_pci_dev(display_dev) { - if (display_dev->vendor == PCI_VENDOR_ID_INTEL && - (display_dev->class >> 16) == PCI_BASE_CLASS_DISPLAY && - connectivity_check(display_dev, hdac_pci)) { + if (display_dev->vendor != PCI_VENDOR_ID_INTEL || + (display_dev->class >> 16) != PCI_BASE_CLASS_DISPLAY) + continue; + + if (pci_match_id(denylist, display_dev)) + continue; + + if (connectivity_check(display_dev, hdac_pci)) { pci_dev_put(display_dev); return true; } From patchwork Thu Feb 22 17:06:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 13567612 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0045A153BF8 for ; Thu, 22 Feb 2024 17:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621560; cv=none; b=AuZpm/41H5YLSF5jvhYyB6OUwFghB2uchB/MmlwRsscOlcc02mBK+9Zza/n8Eb6WEictBiMRhA+ldZM7LMuusVkPSF63RCMSOeVPQBWM/EiNt+8ys1O6Kilj76hSV0aH+zLqsbF4rIbaGdesREcZJlmiIm9EKgLDTGbtoTmPVqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621560; c=relaxed/simple; bh=ZmPygFGWtyXY/k7V0UYpP1keYvjjSFA7st8mQ7lnUbE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tKk0cSlPVh7VUp7xjX9xeYitw0zh3biGBuUrugTfxXRRqrOFLC8cajgy91dM82pVpvNHEL16p2BMeyPkMZhLm7n1seS0zWG1/bg4Ki7xpWjvQJcI9rIYEC1jsGri+nQbb6ZNxxM/GuYHyw3CN9+bd8pdynTu+j3avEgR4DnRDn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eOlnkJit; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eOlnkJit" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708621559; x=1740157559; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZmPygFGWtyXY/k7V0UYpP1keYvjjSFA7st8mQ7lnUbE=; b=eOlnkJitqLGp2BjwCDaLJpQ2hQZDvLP10XgMKIYwsgokYfAOLnBkP1su iHbv4hjcc4Rb7G8DIIQMamsDRh95VYlFRHWwjA2R6m0g+telbTE+w1KHl 73VMBVSDvujQn6s/t41Q9pzLhmwUGtTFVgTREJU/O7Yj5eW3Hp0WiapgE QZmi4wNmgd/3T+o/TSOTkIyv49Lag2v2wc4DdD1T6xxTE8ymWzZtgPpLe OpOUNyoMoCb9NrgQL0JPZ9j5AoG7bvpeHX/g1mOuhm7d5zjX6AWsb/uE8 w3pqu5ywR/3oJSPtYRVs/+UbxkC9RLuudz7ZZfOcSN/WlCpaDfW6QOvVd A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="20299225" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="20299225" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 09:05:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="827575240" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="827575240" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by orsmga001.jf.intel.com with ESMTP; 22 Feb 2024 09:04:57 -0800 From: Cezary Rojewski To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, Cezary Rojewski Subject: [PATCH 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing Date: Thu, 22 Feb 2024 18:06:12 +0100 Message-Id: <20240222170614.884413-3-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240222170614.884413-1-cezary.rojewski@intel.com> References: <20240222170614.884413-1-cezary.rojewski@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If i915 does not support given platform but the hardware i.e.: HDAudio codec is still there, the codec-probing procedure will succeed for such device but the follow up initialization will always end up with -ENODEV. While bus could filter out address '2' which Intel's HDMI/DP codecs always enumerate on, more robust approach is to check for i915 presence before registering display codecs. Signed-off-by: Cezary Rojewski --- sound/soc/codecs/hda.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c index d2117e36ddd1..d9e7cd8aada2 100644 --- a/sound/soc/codecs/hda.c +++ b/sound/soc/codecs/hda.c @@ -350,6 +350,11 @@ static int hda_hdev_attach(struct hdac_device *hdev) struct hda_codec *codec = dev_to_hda_codec(&hdev->dev); struct snd_soc_component_driver *comp_drv; + if (hda_codec_is_display(codec) && !hdev->bus->audio_component) { + dev_dbg(&hdev->dev, "no i915, skip registration for 0x%08x\n", hdev->vendor_id); + return 0; + } + comp_drv = devm_kzalloc(&hdev->dev, sizeof(*comp_drv), GFP_KERNEL); if (!comp_drv) return -ENOMEM; From patchwork Thu Feb 22 17:06:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 13567613 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6342918657 for ; Thu, 22 Feb 2024 17:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621562; cv=none; b=sinI22ywlDVTMGTrYemzLyXl1Lyq9YgHhKzwl8QhxKX5DJRB4e77F2WKbmQMBvSbbM3H3HaxziLFHClGv6LhVjAS0c60ZmflOVjh8LYb/1ibZFijk/QLqzibv4qhD3vRMWDLsaet6U0qyaP+ct8VFCo1vV8/j15DaMmmBx7Q0qU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621562; c=relaxed/simple; bh=qOmiPs34pCUiDLhuSNi0Chuyh6/urNG1iNBP3mIBQVU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YXQKNYUhdF+SA08+7ZilW+yqYB6efIUcGoOWT6X9K4RiMhKO+SoFZjGNZZN97wJgQxs5rKvVbluz7pWgWnNz4hSDdhtw3IP1zm0smBFdyunQZ6ICeQst74tcSxZV5T516p304NFt2tCLYPUpvJJFJdIRTfJw+a6GYzQsdZEHX2U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lvIjSAcB; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lvIjSAcB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708621561; x=1740157561; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qOmiPs34pCUiDLhuSNi0Chuyh6/urNG1iNBP3mIBQVU=; b=lvIjSAcBk4/NOiPGe/gPKxEQh/QIaYHPoQBRihTLHHOWdU5+xddzZy2g zvBr8OZQNqqZt8ebvB74d/WwVNb7Mc6dgql6hQ1rM/sPnng49SQBdeWBZ 1G2jvZLP4ui95ck7rY0paameT3Yufxi4Gxuf8kSx/LWsff2jNHHF66rLi U1J8j1/QE0VNx119LVvmIQb0C/K9C9adSHBBw3NPxjL/nVt861kmYerq4 gCJ1b34QAgM38xpLQpuwXN4hoXj5EKgtm5rJkuytG4L756RtD59i7pnti F81oExLWYHx2/nQGT+8y5Cs8eHhVjOrAaUFmmDRDLNcW6N8vha9LUSQpC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="20299250" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="20299250" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 09:05:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="827575245" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="827575245" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by orsmga001.jf.intel.com with ESMTP; 22 Feb 2024 09:05:01 -0800 From: Cezary Rojewski To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, Cezary Rojewski Subject: [PATCH 3/4] ASoC: codecs: hda: Cleanup error messages Date: Thu, 22 Feb 2024 18:06:13 +0100 Message-Id: <20240222170614.884413-4-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240222170614.884413-1-cezary.rojewski@intel.com> References: <20240222170614.884413-1-cezary.rojewski@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Be cohesive and use same pattern in each error message. Signed-off-by: Cezary Rojewski --- sound/soc/codecs/hda.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c index d9e7cd8aada2..8a9d0674555e 100644 --- a/sound/soc/codecs/hda.c +++ b/sound/soc/codecs/hda.c @@ -198,19 +198,19 @@ static int hda_codec_probe(struct snd_soc_component *component) ret = snd_hda_codec_device_new(codec->bus, component->card->snd_card, hdev->addr, codec, false); if (ret < 0) { - dev_err(&hdev->dev, "create hda codec failed: %d\n", ret); + dev_err(&hdev->dev, "codec create failed: %d\n", ret); goto device_new_err; } ret = snd_hda_codec_set_name(codec, codec->preset->name); if (ret < 0) { - dev_err(&hdev->dev, "name failed %s\n", codec->preset->name); + dev_err(&hdev->dev, "set name: %s failed: %d\n", codec->preset->name, ret); goto err; } ret = snd_hdac_regmap_init(&codec->core); if (ret < 0) { - dev_err(&hdev->dev, "regmap init failed\n"); + dev_err(&hdev->dev, "regmap init failed: %d\n", ret); goto err; } @@ -223,13 +223,13 @@ static int hda_codec_probe(struct snd_soc_component *component) ret = patch(codec); if (ret < 0) { - dev_err(&hdev->dev, "patch failed %d\n", ret); + dev_err(&hdev->dev, "codec init failed: %d\n", ret); goto err; } ret = snd_hda_codec_parse_pcms(codec); if (ret < 0) { - dev_err(&hdev->dev, "unable to map pcms to dai %d\n", ret); + dev_err(&hdev->dev, "unable to map pcms to dai: %d\n", ret); goto parse_pcms_err; } From patchwork Thu Feb 22 17:06:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cezary Rojewski X-Patchwork-Id: 13567614 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19697153BF8 for ; Thu, 22 Feb 2024 17:06:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621564; cv=none; b=qUl6TyQCrzUgzkymwS0lRe2DHtXHcKaQ8R4yGw2aA1vgMG/OWIULLIbLhCAgDvU9cuNEuJrOyUWs0sB1mMGQqaLqd/VXdCOP7BFN74PTzV1mbRmM5j5PrOU0dso0TULdrsSTZ0TL/D2+jBC7EU78sAfkM5GqCkh9ji23RV62RXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708621564; c=relaxed/simple; bh=cewHMOUP9XE8f1iBRQp0XY/AtymJk2wyw8t26geqAWQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MMKtTAkrHn4JL25xP+92RWY3otKdp32pF20R0n4vCi27se3ThoiXHnU0SnAjFIdXzFFG/va+S0SNe/ti/fI4Qx8BCrDFr5gt/aPtQlpGJA5QjRD0MpaDLaoN9VPOwlgEBbC+sZY2ayiHBqv/01z1S/XXhfRIKhMu3dju7tEfWVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=G3cNQjlp; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="G3cNQjlp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708621563; x=1740157563; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cewHMOUP9XE8f1iBRQp0XY/AtymJk2wyw8t26geqAWQ=; b=G3cNQjlp70Qf9DjjsH+7ivoIhCC+Oh6O6p4NDVR/0OR3jtXqrxsJqZ2k Eb2eYsfVKPDNqAVoegEs2OJnzCulAvli1Fgvar3/s/fCwRtX+1/3CC9yM x4E23gvZ8oEIRSOplAXp7/Zf11O+5QGIPC09tZbt44YjjohDKezNv37HC D27TLTLUQmWHgMHmkbx8JO6q7AXn3ejW598Qbfjy8quKd6sKIlHAaqbEQ 7K6BDPX4gMZzmLQ2ge16uHTcO+RWi6zp4SuNmYeB9zwy5RaZx8YrKPrP8 eiT/MUkoRZ4Hdh+biYn/kO77yuvImZj+sgN8ZhkRUW4OdEdCWkMtchi9K A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="20299271" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="20299271" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 09:05:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="827575250" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="827575250" Received: from crojewsk-ctrl.igk.intel.com ([10.102.9.28]) by orsmga001.jf.intel.com with ESMTP; 22 Feb 2024 09:05:04 -0800 From: Cezary Rojewski To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, Cezary Rojewski Subject: [PATCH 4/4] ALSA: hda: Reuse for_each_pcm_streams() Date: Thu, 22 Feb 2024 18:06:14 +0100 Message-Id: <20240222170614.884413-5-cezary.rojewski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240222170614.884413-1-cezary.rojewski@intel.com> References: <20240222170614.884413-1-cezary.rojewski@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use the macro to improve readability. Signed-off-by: Cezary Rojewski --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 12f02cdc9659..2cac337f5263 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3313,7 +3313,7 @@ int snd_hda_codec_parse_pcms(struct hda_codec *codec) list_for_each_entry(cpcm, &codec->pcm_list_head, list) { int stream; - for (stream = 0; stream < 2; stream++) { + for_each_pcm_streams(stream) { struct hda_pcm_stream *info = &cpcm->stream[stream]; if (!info->substreams)