From patchwork Tue Feb 27 03:00:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13573217 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E331DC48BF6 for ; Tue, 27 Feb 2024 03:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D2EA4401E1; Mon, 26 Feb 2024 22:01:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55CD144017F; Mon, 26 Feb 2024 22:01:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424534401E1; Mon, 26 Feb 2024 22:01:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2948644017F for ; Mon, 26 Feb 2024 22:01:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0155EC03FC for ; Tue, 27 Feb 2024 03:01:01 +0000 (UTC) X-FDA: 81836081964.22.3BD7FCE Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 4F3E216000E for ; Tue, 27 Feb 2024 03:01:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rdcCuWxN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709002860; a=rsa-sha256; cv=none; b=xCMdv+NrTyGouLej8H0tpy21k3V/cuzQ6BDNtPk0L5E39OFdLzccc0czm0k7DcH0eCgoAA F9alw7y8J42PJ3EP7XNOCngbCKB3LCcn4fLQTZcmsvwA0p3SmwBfKIPM+Tt3FqmmUm1KZs 4q8QymagA2hU1exJ8W4U7OLPTX/BMVA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rdcCuWxN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709002860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=xeQWaahmZnWCMBq0OUjMZaQ1ukelciifHqNoME1DLpU=; b=ASAhSCXwzXdpRMUZ5leA2Yr01OheYeKs3mCFvq7j+NkjScAVGx3FKDEbU/Pk1obtUc5GzS EkScAtUdwFHruutG6Iv/Zyfb6L/CGwNobP9Punos7RxqOsLtoFTqFL9CTrekoAWY3G4G6c /7WzpHus9HRWBhKYxSNW9ZwZGghDSZE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709002857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xeQWaahmZnWCMBq0OUjMZaQ1ukelciifHqNoME1DLpU=; b=rdcCuWxN+7eDOuR8InRBPhUFUUrein7N1DNL9bQLa97q2as9+CeTi5nqK462eIHVqlOpUJ DE0f8LQ8fdhx+dI+6x/6UCExMbuVB3JMsKt7mypwkmqm700CvAimAF/yYzvB+IbiOpxKK/ l321fRfhM+btqf5QRTQctXh1OyKoTv0= From: chengming.zhou@linux.dev To: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org Cc: hannes@cmpxchg.org, nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [PATCH] mm/zsmalloc: don't need to save tag bit in handle Date: Tue, 27 Feb 2024 03:00:45 +0000 Message-Id: <20240227030045.3443702-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4F3E216000E X-Stat-Signature: cjp5wc6iz1ke7pho4md5ngxmehiap7m3 X-HE-Tag: 1709002860-949538 X-HE-Meta: U2FsdGVkX1/69veSnicR8ARlOJBavak+I0mWgeOpEBni2blKIfbdMTfRv/9HLFUN4H2TLRSFg93dKJW1uJtqAyIEGEGpm8nRXnLHrOhCfBmAUoH6olMUhQ8Wo0NzbEKMHNzQRbYPkRCZyZEe6165Kx+vgsXc6bghWa0ifN+RbSFSH4KDwbmQW45vBzvN76tq/nDNbWZgQZfxfXz2J58DOmz6v7UBriTsMEdTTI0zVlzbtcgF+jePI4l+6YuN580ZDtjSQ4o1ekwbe5rLkZ9jKKpKvs3pdltPQuaJ6gnBcx/rSoq2oT8ySPAP+GDv42dEyZRJky8WRb8rq2QcNXp6aTQXDpXsuWQqb4BMC8sO4E2VOHN/yQqI9CssUQRyOvpFG79wK33+eWNM9yjaEXwm06vM+l0zGVeO3Pk34GSW6JYyojvkfYOdL9LJEku8dJ8qMGs3E1P+oWdzinWb/KDq2FEJOUmtXEWQf/0+IlbNR7WzoNPMWm4e+omYPCkMbfXnpC5rqfwWKyIUufKJ1wc32v5JYhcoKfOfQeHmf6JO9SZVUB3HytNFK6O/rLL8UoTdeHPuNbHOXDqpJAPWrdiLeYpNyn29ebxOSttbJL5j15uhxfQcPbeYXujaoD4/ciAGmPyGHWJbCjW/ZxlsT9JseTGo45aIe25R3ArLE0o4K35Hc18L/QAfmkgSr2pS0rr/VJX0qv8JbKOmGzids1BVQEwgccO9WqTJsACrMxUNaJ/lZ/CJMIVzXbjU0hAMMlIXMZVmkOurEQ3bgz1UbFe0eu+88IDi4gD+tmYw3oFmjObz/zXyasHGUPhRBX7ThU6cvOhwp0PYDkPkBDlL7t4biQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chengming Zhou We only need to save the position (pfn + obj_idx) in the handle, don't need to save tag bit in handle. So one more bit can be used as obj_idx. Actually, the tag bit is only useful in zspage's memory space, to tell if an object is allocated or not. Signed-off-by: Chengming Zhou --- mm/zsmalloc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 63ec385cd670..7d7cb3eaabe0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -110,7 +110,7 @@ #define OBJ_TAG_BITS 1 #define OBJ_TAG_MASK OBJ_ALLOCATED_TAG -#define OBJ_INDEX_BITS (BITS_PER_LONG - _PFN_BITS - OBJ_TAG_BITS) +#define OBJ_INDEX_BITS (BITS_PER_LONG - _PFN_BITS) #define OBJ_INDEX_MASK ((_AC(1, UL) << OBJ_INDEX_BITS) - 1) #define HUGE_BITS 1 @@ -737,14 +737,12 @@ static struct page *get_next_page(struct page *page) static void obj_to_location(unsigned long obj, struct page **page, unsigned int *obj_idx) { - obj >>= OBJ_TAG_BITS; *page = pfn_to_page(obj >> OBJ_INDEX_BITS); *obj_idx = (obj & OBJ_INDEX_MASK); } static void obj_to_page(unsigned long obj, struct page **page) { - obj >>= OBJ_TAG_BITS; *page = pfn_to_page(obj >> OBJ_INDEX_BITS); } @@ -759,7 +757,6 @@ static unsigned long location_to_obj(struct page *page, unsigned int obj_idx) obj = page_to_pfn(page) << OBJ_INDEX_BITS; obj |= obj_idx & OBJ_INDEX_MASK; - obj <<= OBJ_TAG_BITS; return obj; }