From patchwork Fri Mar 1 14:37:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yazen Ghannam X-Patchwork-Id: 13578532 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2077.outbound.protection.outlook.com [40.107.102.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 047D11FDD; Fri, 1 Mar 2024 14:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303888; cv=fail; b=H1y7LWfLoxXYyK2xtECOmuWyq7ZsI/Bj7/gvbdNWlCrsN5um7Vq7Nmmbpq/DrIl7wdhzo1xf/9Fajn1/F7IqzXMJA+BIEsyF3myDpvO0nZ52zmAgFhOhDYGM2LYETYKZopt3S0YDefIVe2H3DDRMMwdU7pW8rTXQttQi+YoePSw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303888; c=relaxed/simple; bh=xv/CdOab1e9dWOCTvgOA3GJTjc4b4HVPqbW/o/wrRL8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S0dFKzIytzKkVm8UCzw0J7cmM6tvalE73uVztP0NNbgODy1Ky0LuY/UfGm6ymMhjHYfVR51PaxzLNcZXzwSeBO799eqFO1RLR34GHGLIferM7Npwh+RfeTLVdjowNUw6q1mo8W+UW4QYVAI43khwl4rz1L/6c/jUl8SwQ7GFzPo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lZA3Lzqd; arc=fail smtp.client-ip=40.107.102.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lZA3Lzqd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BttJcVstw5DVlagofriT3itYjNzVR0kLp/rnWnOVf1wdOkbEf6wBe+L+zLPccLFUK+N/fI9OEezpYkPsmkHYmoJzbG2T/kKvBQhHslE+l+mJkFDcasymEzzviN2+ySHC2a3J2vrybsF3VkAG5H7PxQmR6BG9Tdr+GOooZB69QqC/VnBvFIQ4kNUJ5hUG81nlvSnTfTacg9CPAQq+VtttmRM2mBWrP8mHkqPhTgoxxh+iyxP+8oQaaTXUDVInCpnFi7VRcGI378HoKauEWhrfw7iOR+jcMAIz7CPEtSpCCG/vY4GHM1pSohELTdDMEgbjWciCQZBWc94DE7kOWflXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0aZEPY3ieSA1Tv7iGt29eYe7UpRQpivq7wBuJUC6kVU=; b=bWeyQDo7Q5ku5oj5i9NofjMl3DZqWpKxeFWloOJ2xs3oN47KHVlCfR/UCir7/giG5xoiuRB6f7ipdXmB+35akr5HpTTlObgiXW4VKR6A7aMLzq+zQT7mCkduKmr6ixr7NrMVlD7M6Cz9sVQMcAY3b63hYIkZ+HHywzXlzas1lL95hzyzwNuvTRCWpbTtHa2+WY4I8VXvk+3kpn2pXE/GeLiGyGS0nVTXG1vcMhrdvcmAJ+OM5vs774Lzpqh40Xnfo4lDCoESW0TAXgHNXl4chFGC0WAcSy2CTtIDm/2PJDOJ6asYXS+Wm6sSlLEOriVRDFSA5VsvBQoWIw3XE++nzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0aZEPY3ieSA1Tv7iGt29eYe7UpRQpivq7wBuJUC6kVU=; b=lZA3LzqdsNX7+k1WZ/XDQ4CzAhcXeuQSKAMATh0kMrG05DfF/EWgcPc66AWUFY3EylqETkAc6ZKjmUNdWpVU4hryZpg6pzhqFvdqWpsdE3ts1mAm+aYLZjWB0nTSmdpSbL51AWhg4qxQKnfjQvx2L9RQLw7WR4+9ZNyy6hxnA1M= Received: from SN1PR12CA0043.namprd12.prod.outlook.com (2603:10b6:802:20::14) by BL1PR12MB5874.namprd12.prod.outlook.com (2603:10b6:208:396::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Fri, 1 Mar 2024 14:38:04 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:802:20:cafe::8f) by SN1PR12CA0043.outlook.office365.com (2603:10b6:802:20::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.34 via Frontend Transport; Fri, 1 Mar 2024 14:38:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Fri, 1 Mar 2024 14:38:04 +0000 Received: from quartz-7b1chost.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 08:37:58 -0600 From: Yazen Ghannam To: , , CC: , , , , , , Yazen Ghannam Subject: [PATCH v2 1/3] RAS: Export helper to get ras_debugfs_dir Date: Fri, 1 Mar 2024 08:37:46 -0600 Message-ID: <20240301143748.854090-2-yazen.ghannam@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240301143748.854090-1-yazen.ghannam@amd.com> References: <20240301143748.854090-1-yazen.ghannam@amd.com> Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|BL1PR12MB5874:EE_ X-MS-Office365-Filtering-Correlation-Id: 898bbab4-69e7-4393-73ec-08dc39fd343d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vAxkTZf/bg1QyYWRE9o1Ie8qnFwsyjN72Fp1DQibS+W1G4TjjVR6WAjk+Qiotb8IuoFFVzgqa5c4PTDdw1+ago2/L24civ2J7FtpgYThOAxARlmFo+NACLGKkN7//GAzSB8FZ9S5sRL5JgR7hP8CPxHQwqS82tRJXYrYZ3s1OWExoI2Wxh/rAcicMAyjrpBzqJr9wfzRUxJn7/3J8rQAxRtv5BGxxGE5m8MPpi1BXRK9y4BRgcM8Ku+yQDnogj87JhbKXI4XvBT9PyuYG0NG3C34pdNWARp2ziJfWgE0VMF0P6Ff1RbxfKkGDqwYCnPf0qxjZtYh/QkitV0gW0WrKid2htnSBNbgDZj49kgnJzyUq10RLyJuXzOhbe2O+tN1JQSXt6QJrafXijDLQmZKh6pvcsYPMzUxozd4WVDkAI7NCgtJ8SL9yov2RRLJjzOOJXE1bZ7KIRd2lo0F82ValwM+qBpLh6iy8JE406hWzChOggYrH3T8UqEQRxa7QyDlQKIkDWAkaWJWQfTzJITV+7sdkX7WYwJ+9JjygZi9kIL7r00MD4StQeHk4aCjKP8jUiyTH6gL+LxpROEyEnjcSR9zRjYh/sbgJ2iXnBdV0lAFyRSaVd0WJ0qNunudbIt+59Rf/P+DLkCpaLBOkWjIwWiBaG5mgI/EUxB98Oo2mLIDfxbt6Pudo0FGhXM4FhRYSndGw4yBSVcgY+ZQRyr+4A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(82310400014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:38:04.5094 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 898bbab4-69e7-4393-73ec-08dc39fd343d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5874 From: "Borislav Petkov (AMD)" ...so that RAS modules can use it. Signed-off-by: Borislav Petkov (AMD) Signed-off-by: Yazen Ghannam --- Link: https://lore.kernel.org/r/20240226152941.2615007-2-yazen.ghannam@amd.com v1->v2: * Replace with patch from Boris to export a function. * Added commit message and authorship to patch from Boris. drivers/ras/cec.c | 10 ++++++++-- drivers/ras/debugfs.c | 8 +++++++- drivers/ras/debugfs.h | 2 +- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index 321af498ee11..e440b15fbabc 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -480,9 +480,15 @@ DEFINE_SHOW_ATTRIBUTE(array); static int __init create_debugfs_nodes(void) { - struct dentry *d, *pfn, *decay, *count, *array; + struct dentry *d, *pfn, *decay, *count, *array, *dfs; - d = debugfs_create_dir("cec", ras_debugfs_dir); + dfs = ras_get_debugfs_root(); + if (!dfs) { + pr_warn("Error getting RAS debugfs root!\n"); + return -1; + } + + d = debugfs_create_dir("cec", dfs); if (!d) { pr_warn("Error creating cec debugfs node!\n"); return -1; diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c index ffb973c328e3..42afd3de68b2 100644 --- a/drivers/ras/debugfs.c +++ b/drivers/ras/debugfs.c @@ -3,10 +3,16 @@ #include #include "debugfs.h" -struct dentry *ras_debugfs_dir; +static struct dentry *ras_debugfs_dir; static atomic_t trace_count = ATOMIC_INIT(0); +struct dentry *ras_get_debugfs_root(void) +{ + return ras_debugfs_dir; +} +EXPORT_SYMBOL_GPL(ras_get_debugfs_root); + int ras_userspace_consumers(void) { return atomic_read(&trace_count); diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h index c07443b462ad..4749ccdeeba1 100644 --- a/drivers/ras/debugfs.h +++ b/drivers/ras/debugfs.h @@ -4,6 +4,6 @@ #include -extern struct dentry *ras_debugfs_dir; +struct dentry *ras_get_debugfs_root(void); #endif /* __RAS_DEBUGFS_H__ */ From patchwork Fri Mar 1 14:37:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yazen Ghannam X-Patchwork-Id: 13578534 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1835C3A8E8; Fri, 1 Mar 2024 14:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303892; cv=fail; b=ejdrpeOeHbbhTJfNhcQumzF/uANI7oF64JtsLZshoYHztmp0WL3Ip6SpTHQT8kHu3jIAh0w63pq4SHWQ7rqjrV2yo7SJBpr1ZDbZLBfO67GUl5zvegmwj3y1fTnxcoKGwv610k3HZ12gntDNXaVe2Y4RxlfG4K4+v5X0a8hC+8I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303892; c=relaxed/simple; bh=mkew6BgxINgrP+SrOug7QFgSoXrMDkXyQzPM/4XRYvQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mCgpKt9Zcdf13HW4dgzhvvQugRhTQdUu8yLAWgmByM5GPa6Fg8RbAhbXl7/ouKuJh0l3kjy8e51/RMoLBcTLiFAfrzdLoM5Hm0UTneuZ7XmI6HHd9I94aHOiwo2q3kQE9bV8VXdQ/JIFE/zb7pQlChy+yTCQ/JQ8eIASHOIZWdQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=by6/6/8V; arc=fail smtp.client-ip=40.107.236.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="by6/6/8V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRFzbZOhSOpaNJqFpKdqeICvpjkrOLasM95+JNnly5eqvUkAHtNHGLzrPXCJ0t8U+tbIb+33tbbS5amCq9x2BdAtEUt42KA598EdF1F7kZUH/ZMxkhCU/HRiN80XRxuFk9muVny/G2cC9/Q0Q2eDvCWEtsSzwdSD3e2wjd8c2j5G3kdEvAMw73ckDEwZcKNAHGJPK+e0UPT6NNLIJ3W3dzpZYjUYFal7cjskupJyn8p/ldjvaQWV76gcaK398333h1/tNLZKf/79T6KLzqtm6lYIzMGc0lyYzHcn3Fgd0DOusQ9fH7cBdajUFVCHnCn/rbUz7W88edYbu5E4BmtVDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MQDlZU/CCXiCX74FYVwpVtLyq9aqakrmIEie4cQYDj0=; b=FIYwyfC0iejtie6s5aM/hM1MaUlbDvdz/FoydnMVfbVMi70FxeBADWB4e/0jpdIXahpdwhMuOObLW7M6MGsunrUnUGVxMdABP9XPpDYTzIkjg7OE7+VutOdaN/GmnFEAw5XiWInV2qddX3Vik3GvIvkqIh92tvIPd+OvhTxTTM+zLKoTvAP5ClE5fdzDUF35OyyZOb4hc05BVjNPQHBeZbiPtRqFbk2Ce+MVe4VwTlnRhUb1up1MZIEWayBL7ns3LAYLHpwrk/Qvhk09HG2IWVTj8vXMioGFmJRTVpLRIbBKprtEb8bfkDUeFUNHPwIH3/7s4YuD+ttTWKO/dCw9zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQDlZU/CCXiCX74FYVwpVtLyq9aqakrmIEie4cQYDj0=; b=by6/6/8VxgbmYrRzlEWIkso1Txrv7ngke7iaYH1n5HFzTZIdiBLYkSF+z6ISrxDpMVt/iBFsvazB9gje8vwotI4LzaGTRvwUoQIIUvVTg1KF1NfcL9WoPhFAOE5MnOMdw1HGilu5rqIKthiLQzNLWT+fOvgnjr9+uB0M1v0DKwE= Received: from SN1PR12CA0058.namprd12.prod.outlook.com (2603:10b6:802:20::29) by DM4PR12MB6639.namprd12.prod.outlook.com (2603:10b6:8:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Fri, 1 Mar 2024 14:38:05 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:802:20:cafe::c7) by SN1PR12CA0058.outlook.office365.com (2603:10b6:802:20::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32 via Frontend Transport; Fri, 1 Mar 2024 14:38:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Fri, 1 Mar 2024 14:38:04 +0000 Received: from quartz-7b1chost.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 08:37:59 -0600 From: Yazen Ghannam To: , , CC: , , , , , , Yazen Ghannam Subject: [PATCH v2 2/3] RAS/AMD/FMPM: Save SPA values Date: Fri, 1 Mar 2024 08:37:47 -0600 Message-ID: <20240301143748.854090-3-yazen.ghannam@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240301143748.854090-1-yazen.ghannam@amd.com> References: <20240301143748.854090-1-yazen.ghannam@amd.com> Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|DM4PR12MB6639:EE_ X-MS-Office365-Filtering-Correlation-Id: 993f285e-dbe7-4e7d-abb0-08dc39fd3476 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1hHDxRehyIU/ZawTVBEUnUuXLy9byyToZElLVlSXYUzYnMFYSvqaixoCLH6FabI7Y3VnHyoInWp/DPwkm8mBRO66C0y3gkw+GWlHlp6oJp6VKfx+e/+fB/5FZLCQ8y0UUovEJS2l9T4cdXd7W27DMqQ1GQY6lxCNXlVdFV7zB2o3pDwMQuf1EWUSKsE8+znAysicR87cH+2SBICdz9ufsGTcDmX6yvHn58Mesit2JtpFB0B8+S9GK+C2y/2MmFlfFmWCCD4fqDXfxRmEFOJODMywZyXpiPUZBHU3AoazVVKygPS0P+yK85U8WQIMhsecD+mCT5dh2hCcPxP7sAimFI9WsomV6/OQs8Io4C9RK1ETrjJZ924okyIenwPGthUqfG7zCZLSCwrArUIfMyX60ofsSjtpkaggsFhkidmq8v2fRzhi4AHdCGpyzT0n/xbFHugs+ARmJq/z0F8K+kvtj9I5/OEHMd/VjRO3W9ttSU1hVTL6xjheEhh6hsYcUNRd/tHooRuohMJkvOqinDpVPuLPAEoLN1OmIc0Z+2h3pl1evQBjNWhyy4FyoOpQDiGQmeTi50CaCg9phT0k5OXf0Gz8+EPI6kGpZRIE5Fxr+KaSrtGPpMKGSi7VGe2tj3oBtmRfZaPGAF0fTLMR04IRcPk9E9QzugsgyxPpBUnMvBP5cQFCo7YuJpbMfH1mZBHgwg/8dQpyynIiqeQ2YFSXEQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:38:04.8844 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 993f285e-dbe7-4e7d-abb0-08dc39fd3476 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6639 The system physical address (SPA) of an error is not a stable value. It will change depending on the location of the memory: parts can be swapped. And it will change depending on memory topology: NUMA nodes and/or interleaving can be adjusted. Therefore, the SPA value is not part of the "FRU Memory Poison" record format. And it will not be saved to persistent storage. However, the SPA values can be helpful during debug and for system admins during run time. Save the SPA values in a separate structure. This is updated when records are restored and when new errors are saved. Signed-off-by: Yazen Ghannam --- Link: https://lore.kernel.org/r/20240226152941.2615007-3-yazen.ghannam@amd.com v1->v2: * Changed variable names to remove "sys_" prefix. (Boris) * Used "spa_" prefix to highlight that these are for SPA values. (Yazen) * Added warning to "index out-of-bound" condition. (Boris) * Reworked save_spa() flow to get a valid array position before saving SPA value (Yazen). drivers/ras/amd/fmpm.c | 68 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c index 80dd112b720a..a7bb36eb60cb 100644 --- a/drivers/ras/amd/fmpm.c +++ b/drivers/ras/amd/fmpm.c @@ -111,6 +111,11 @@ struct fru_rec { */ static struct fru_rec **fru_records; +/* system physical addresses array */ +static u64 *spa_entries; + +#define INVALID_SPA ~0ULL + #define CPER_CREATOR_FMP \ GUID_INIT(0xcd5c2993, 0xf4b2, 0x41b2, 0xb5, 0xd4, 0xf9, 0xc3, \ 0xa0, 0x33, 0x08, 0x75) @@ -140,6 +145,9 @@ static unsigned int max_nr_fru; /* Total length of record including headers and list of descriptor entries. */ static size_t max_rec_len; +/* Total number of SPA entries across all FRUs. */ +static unsigned int spa_nr_entries; + /* * Protect the local records cache in fru_records and prevent concurrent * writes to storage. This is only needed after init once notifier block @@ -269,6 +277,52 @@ static bool rec_has_fpd(struct fru_rec *rec, struct cper_fru_poison_desc *fpd) return false; } +static void save_spa(struct fru_rec *rec, unsigned int entry, + u64 addr, u64 id, unsigned int cpu) +{ + unsigned int i, fru_idx, spa_entry; + struct atl_err a_err; + unsigned long spa; + + if (entry >= max_nr_entries) { + pr_warn_once("entry out-of-bounds\n"); + return; + } + + for (i = 0; i < spa_nr_entries; i += max_nr_entries) { + fru_idx = i / max_nr_entries; + if (fru_records[fru_idx] == rec) + break; + } + + if (i >= spa_nr_entries) { + pr_warn_once("record not found"); + return; + } + + spa_entry = i + entry; + if (spa_entry >= spa_nr_entries) { + pr_warn_once("spa_entries[] index out-of-bounds\n"); + return; + } + + memset(&a_err, 0, sizeof(struct atl_err)); + + a_err.addr = addr; + a_err.ipid = id; + a_err.cpu = cpu; + + spa = amd_convert_umc_mca_addr_to_sys_addr(&a_err); + if (IS_ERR_VALUE(spa)) { + pr_debug("Failed to get system address\n"); + return; + } + + spa_entries[spa_entry] = spa; + pr_debug("fru_idx: %u, entry: %u, spa_entry: %u, spa: 0x%016llx\n", + fru_idx, entry, spa_entry, spa_entries[spa_entry]); +} + static void update_fru_record(struct fru_rec *rec, struct mce *m) { struct cper_sec_fru_mem_poison *fmp = &rec->fmp; @@ -301,6 +355,7 @@ static void update_fru_record(struct fru_rec *rec, struct mce *m) entry = fmp->nr_entries; save_fpd: + save_spa(rec, entry, m->addr, m->ipid, m->extcpu); fpd_dest = &rec->entries[entry]; memcpy(fpd_dest, &fpd, sizeof(struct cper_fru_poison_desc)); @@ -385,6 +440,7 @@ static void retire_mem_fmp(struct fru_rec *rec) continue; retire_dram_row(fpd->addr, fpd->hw_id, err_cpu); + save_spa(rec, i, fpd->addr, fpd->hw_id, err_cpu); } } @@ -696,6 +752,8 @@ static int get_system_info(void) if (!max_nr_entries) max_nr_entries = FMPM_DEFAULT_MAX_NR_ENTRIES; + spa_nr_entries = max_nr_fru * max_nr_entries; + max_rec_len = sizeof(struct fru_rec); max_rec_len += sizeof(struct cper_fru_poison_desc) * max_nr_entries; @@ -714,6 +772,7 @@ static void free_records(void) kfree(rec); kfree(fru_records); + kfree(spa_entries); } static int allocate_records(void) @@ -734,6 +793,15 @@ static int allocate_records(void) } } + spa_entries = kcalloc(spa_nr_entries, sizeof(u64), GFP_KERNEL); + if (!spa_entries) { + ret = -ENOMEM; + goto out_free; + } + + for (i = 0; i < spa_nr_entries; i++) + spa_entries[i] = INVALID_SPA; + return ret; out_free: From patchwork Fri Mar 1 14:37:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yazen Ghannam X-Patchwork-Id: 13578533 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2057.outbound.protection.outlook.com [40.107.101.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2102209F; Fri, 1 Mar 2024 14:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303889; cv=fail; b=CYQEXtgI8mGYa2iVCM6HLClmVsGefb9wupN9K3kavUsw1DHtqKPk97t/DdFbl2LN7Fy/W8cQW8GVRxMXzJVxu+l0IdvPFglQ0nmJXqqkrjdrTr6BMphlbtb6AZaqE7BAWQidoJurZwM3BmQyiCEAhPc9Tc1F1KDMlpsVYdtyUwY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709303889; c=relaxed/simple; bh=jawXv2OGl20dD+3vtBqQub2qeJPQXmWeI81g9vZupOI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=szyWlUX128fKnX6NiCIhufpxxh9jAnipeqFJLOXUGeD36iOs71yXyF/l0PKrtZCCdkrkJqENXQLcoLK5tM5gZhuLHKJx9pr/OQ+w1c5rngkDMoerqYcND3UurHinecYls7o6q/aeQFz2zWj/98noJEMk/B8DbkEF9iOC1oclGC8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iZj4Ph1w; arc=fail smtp.client-ip=40.107.101.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iZj4Ph1w" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iffV8Wb3chfUfffhW1Zmj1U+eYP5SnqRcqjESsxN21b50G7aASRBOV2XENfMvITQmCygCjrp1O+OQRT9XdbzuUuEKOiust9hZNYWmahhFQYTRE0YzYyIHxhNRJlRVsyc2trtz+gG1WzA5Zfc3cGrvYJqtr5H4eEcOtpalzAnYDyDcrnOVLN3Jl3hmtLn/vopsH3zL3xs83IBmU/fRyYhrm9CFrdVLkGKQdqal2TVuDrGxXHlZ1g5GAe6NvLyCsiGkD+FHJsukiVYo9tBQMYvZNJQ3rTB4Rq5Tl7kSgfMqvULX5lrVJsiLNUoZWKAW2+1EOqSO3/7cydkqq3p+cpwog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5MjkK1O1gP6wxjQjLWTe3gtWuOp2U7TuEzh0A2PE0Hs=; b=Y+PbF9wQthWPzUTiiQyHiB0wdXvGvyNV08SE2cd86wayv80C0LNT7RA85SYcPF9QzNfqfHStgXI7O8Hc9+aV97fTbt+PInS5tUjppNBC/kByr4a1Jx1p3HtK/Vs2Q7mSwVPAnRXHgAV806AOrZjQQ5IYuv5QrJzzKo5zXLU9Lqr4T7L16nxE9tGT3FxNFtby3Pue9V3F1yac9jmInUCSmhIRi+BsJTkTtCLK4gHE4+8MzBB5dStSwptqkcB+TzA8YYeihqUr90znaU1710meUX33lEC+BA61cfilnzZlGLHR4n2kpMszYPGLylOnUClbmyPu8yIi1QcwH9tIShW1fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5MjkK1O1gP6wxjQjLWTe3gtWuOp2U7TuEzh0A2PE0Hs=; b=iZj4Ph1wAJjcQcOmeOV6wtWbVTASX0/YS/ZZPtW3uVME3YEP0YHu8KysJqJO9rO+lgSLeBH7KMDO8tCo7axvvGLQPzX+MutEsYItC4qrC1evEUauw4dTn2KJR2n9vGDDDKi9nDkXXy0bG1JgX8Xo3qClOv8nHrkOiWFruqf6vnk= Received: from SN1PR12CA0049.namprd12.prod.outlook.com (2603:10b6:802:20::20) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.34; Fri, 1 Mar 2024 14:38:05 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:802:20:cafe::58) by SN1PR12CA0049.outlook.office365.com (2603:10b6:802:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32 via Frontend Transport; Fri, 1 Mar 2024 14:38:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Fri, 1 Mar 2024 14:38:05 +0000 Received: from quartz-7b1chost.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 1 Mar 2024 08:37:59 -0600 From: Yazen Ghannam To: , , CC: , , , , , , Yazen Ghannam Subject: [PATCH v2 3/3] RAS/AMD/FMPM: Add debugfs interface to print record entries Date: Fri, 1 Mar 2024 08:37:48 -0600 Message-ID: <20240301143748.854090-4-yazen.ghannam@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240301143748.854090-1-yazen.ghannam@amd.com> References: <20240301143748.854090-1-yazen.ghannam@amd.com> Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: eddf2e3f-145e-417e-4520-08dc39fd34d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: coiHbPDx0T08ZOB0TlQje2sIWto3cORLlkoJMaQE+L6+TKw7HOztdsTHQKp501z+Uwf8HPpINydUmNnP+Scp6NxhxwgUVpg1ggM2Ggnc1zIPMnHRnrX2CyZMR6ELR6LkFYogBc+WO5coFIMY7SlWklulFpwwsMWH7wb8eEsQmG1tujtGMINXx/v0bxZBBDABqPOMmtvkGm0L2SWks9f/opXTrkJCQSxUQQ8/I1CpHT01ptDHqRUC849kaZR90E6fYuTBIM1ivLHkcb2chwIS8bTwzCgKJobBNs/i/xkNeZKevALa+jXFaFhe9nbSbtYkEkh4a/q0sHXkhSI8wHqcf4uYCwuCjDCBkjo94BS01WQvrV/5a/ytzn2shHCeNbs9OAlALPHU3l6OrDeSpm7UbsmGoMyuPZEUV1LKVsDr6gSMluI3CMX2AC+zw6LO7qTC/K/9ctmQ5725O9A4pPUEuWrxbdeNdX/zzlg0Gr4Mb5OyuMknOdhLROIq7a5wafq7vzciRDeThykv5AqW2NRwx+QzKmeKrxYnmz5QpCZ3E4uJzpgMm3lI05sCJV9JnuN1fouwUhwAccC0tc4wEsBAzp5OeTAXnAFG8ZFVZAuaAmxjVK8JltPOuLiqAcblod+ZfgXH1VvElMjZa+V7Y7EYEjoZ2UvDFfzzxdHNG1zFMl6WEsgfhQdjm97NiT29A28on6Srqnx0DdLbxbyYR1yL1g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 14:38:05.4781 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eddf2e3f-145e-417e-4520-08dc39fd34d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 It is helpful to see the saved record entries during run time in human-readable format. This is useful for testing during module development. And it can be used by system admins to quickly and easily see the state of the system. Provide a sequential file in debugfs to print fields of interest from the FRU records and their entries. Don't fail to load the module if the debugfs interface is not available. This is a convenience feature which does not affect other module functionality. The new interface reads the record entries and should hold the mutex. Expand the mutex code comment to clarify when it should be held. Signed-off-by: Yazen Ghannam --- Link: https://lore.kernel.org/r/20240226152941.2615007-4-yazen.ghannam@amd.com v1->v2: * Update based on patch 1 and 2 changes. drivers/ras/amd/fmpm.c | 131 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+) diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c index a7bb36eb60cb..d670aa11aef4 100644 --- a/drivers/ras/amd/fmpm.c +++ b/drivers/ras/amd/fmpm.c @@ -54,6 +54,8 @@ #include #include +#include "../debugfs.h" + #define INVALID_CPU UINT_MAX /* Validation Bits */ @@ -116,6 +118,9 @@ static u64 *spa_entries; #define INVALID_SPA ~0ULL +static struct dentry *fmpm_dfs_dir; +static struct dentry *fmpm_dfs_entries; + #define CPER_CREATOR_FMP \ GUID_INIT(0xcd5c2993, 0xf4b2, 0x41b2, 0xb5, 0xd4, 0xf9, 0xc3, \ 0xa0, 0x33, 0x08, 0x75) @@ -152,6 +157,11 @@ static unsigned int spa_nr_entries; * Protect the local records cache in fru_records and prevent concurrent * writes to storage. This is only needed after init once notifier block * registration is done. + * + * The majority of a record is fixed at module init and will not change + * during run time. The entries within a record will be updated as new + * errors are reported. The mutex should be held whenever the entries are + * accessed during run time. */ static DEFINE_MUTEX(fmpm_update_mutex); @@ -813,6 +823,124 @@ static int allocate_records(void) return ret; } +static void *fmpm_start(struct seq_file *f, loff_t *pos) +{ + if (*pos >= (spa_nr_entries + 1)) + return NULL; + return pos; +} + +static void *fmpm_next(struct seq_file *f, void *data, loff_t *pos) +{ + if (++(*pos) >= (spa_nr_entries + 1)) + return NULL; + return pos; +} + +static void fmpm_stop(struct seq_file *f, void *data) +{ +} + +#define SHORT_WIDTH 8 +#define U64_WIDTH 18 +#define TIMESTAMP_WIDTH 19 +#define LONG_WIDTH 24 +#define U64_PAD (LONG_WIDTH - U64_WIDTH) +#define TS_PAD (LONG_WIDTH - TIMESTAMP_WIDTH) +static int fmpm_show(struct seq_file *f, void *data) +{ + unsigned int fru_idx, entry, spa_entry, line; + struct cper_fru_poison_desc *fpd; + struct fru_rec *rec; + + line = *(loff_t *)data; + if (line == 0) { + seq_printf(f, "%-*s", SHORT_WIDTH, "fru_idx"); + seq_printf(f, "%-*s", LONG_WIDTH, "fru_id"); + seq_printf(f, "%-*s", SHORT_WIDTH, "entry"); + seq_printf(f, "%-*s", LONG_WIDTH, "timestamp"); + seq_printf(f, "%-*s", LONG_WIDTH, "hw_id"); + seq_printf(f, "%-*s", LONG_WIDTH, "addr"); + seq_printf(f, "%-*s", LONG_WIDTH, "spa"); + goto out_newline; + } + + spa_entry = line - 1; + fru_idx = spa_entry / max_nr_entries; + entry = spa_entry % max_nr_entries; + + rec = fru_records[fru_idx]; + if (!rec) + goto out; + + seq_printf(f, "%-*u", SHORT_WIDTH, fru_idx); + seq_printf(f, "0x%016llx%-*s", rec->fmp.fru_id, U64_PAD, ""); + seq_printf(f, "%-*u", SHORT_WIDTH, entry); + + mutex_lock(&fmpm_update_mutex); + + if (entry >= rec->fmp.nr_entries) { + seq_printf(f, "%-*s", LONG_WIDTH, "*"); + seq_printf(f, "%-*s", LONG_WIDTH, "*"); + seq_printf(f, "%-*s", LONG_WIDTH, "*"); + seq_printf(f, "%-*s", LONG_WIDTH, "*"); + goto out_unlock; + } + + fpd = &rec->entries[entry]; + + seq_printf(f, "%ptT%-*s", &fpd->timestamp, TS_PAD, ""); + seq_printf(f, "0x%016llx%-*s", fpd->hw_id, U64_PAD, ""); + seq_printf(f, "0x%016llx%-*s", fpd->addr, U64_PAD, ""); + + if (spa_entries[spa_entry] == INVALID_SPA) + seq_printf(f, "%-*s", LONG_WIDTH, "*"); + else + seq_printf(f, "0x%016llx%-*s", spa_entries[spa_entry], U64_PAD, ""); + +out_unlock: + mutex_unlock(&fmpm_update_mutex); +out_newline: + seq_putc(f, '\n'); +out: + return 0; +} + +static const struct seq_operations fmpm_seq_ops = { + .start = fmpm_start, + .next = fmpm_next, + .stop = fmpm_stop, + .show = fmpm_show, +}; + +static int fmpm_open(struct inode *inode, struct file *file) +{ + return seq_open(file, &fmpm_seq_ops); +} + +static const struct file_operations fmpm_fops = { + .open = fmpm_open, + .release = seq_release, + .read = seq_read, + .llseek = seq_lseek, +}; + +static void setup_debugfs(void) +{ + struct dentry *dfs = ras_get_debugfs_root(); + + if (!dfs) + return; + + fmpm_dfs_dir = debugfs_create_dir("fmpm", dfs); + if (!fmpm_dfs_dir) + return; + + fmpm_dfs_entries = debugfs_create_file("entries", 0400, fmpm_dfs_dir, NULL, &fmpm_fops); + if (!fmpm_dfs_entries) + debugfs_remove(fmpm_dfs_dir); +} + static const struct x86_cpu_id fmpm_cpuids[] = { X86_MATCH_VENDOR_FAM(AMD, 0x19, NULL), { } @@ -854,6 +982,8 @@ static int __init fru_mem_poison_init(void) if (ret) goto out_free; + setup_debugfs(); + retire_mem_records(); mce_register_decode_chain(&fru_mem_poison_nb); @@ -870,6 +1000,7 @@ static int __init fru_mem_poison_init(void) static void __exit fru_mem_poison_exit(void) { mce_unregister_decode_chain(&fru_mem_poison_nb); + debugfs_remove(fmpm_dfs_dir); free_records(); }