From patchwork Sun Mar 3 19:20:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579878 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F239679DB0; Sun, 3 Mar 2024 19:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493658; cv=none; b=HQo5AU6dTVv4k0lUF8+swAwIsIVLirkzY3d901/UNAYqPT/+GiYvM9nupLxdFxOA4VIIuTYPaC9LSiXKRq8zURDErNtW/e6aoTHGWuQp/e90D9FPl/5Vp0bUSfIk5vaJvRmTNHmL96A3g/Fx7ryV2LPb7H7yh1iCuaRyNSB+ns8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493658; c=relaxed/simple; bh=e3jkG39/MQTGX4+KXnyNp32ca12vDfkXIz0Uhjzrt4w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hXiuX3mxHpAIr9T62dPCrHC5kNyDmUUUZq302WxHLxx9eXRlLifWasWl7LJAW/tm+fdz/EnpRFoJwdqYdQN78ZBiE05ehHmg2BjDD8EomJ/cRbiLcgDE7V189NA+fJvWDqlsX+baVZ17hia4Kxrs4X6osOLa7sRUq8nrqWSeXeY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MhRN/cHQ; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MhRN/cHQ" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d382a78c38so10937281fa.1; Sun, 03 Mar 2024 11:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493655; x=1710098455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UtWCQrC9j37ooCM7Gh68I6DWbQnrPcqv9tFDtfEFLtM=; b=MhRN/cHQgjItArs7bmAIxwbUIZNXigYC/AJ4HvzChLlW2hnooFp+yrdHarcgBtOv90 pt26ysUULgUp8eyBB1e+03K+JOLMaZmREibKJAp7MQ605wshyIYNo71Wo/ZtlJI1o9fe yfXhwphu1aFIcPHbO9H9jL9wGQaw2IVv8DR+qLitf03bM9zNpexEBwQ3r0YLsrNujhxp +O+6sI6QcbrCvsrVCn04/2lT7q/m6cvKem5Jqp26q+7khOn9kSOM7plcd4RzLx4ZbmRF CdeVQV0OC3NMIOGJSdndDHIWDc0YfzmJRquI8LAc5+K5h8zfuJ07mE3OiJzaI5WFSz5g RR9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493655; x=1710098455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UtWCQrC9j37ooCM7Gh68I6DWbQnrPcqv9tFDtfEFLtM=; b=ST7pKBcDLDwa8MU+4MySWucLPZ+vlF0IArWrR2Rc8uDRpRQVsyL4cUZConm07Elo2y HXHJLBzVbNaACCj1foOvhcluUchWHjgyku77psOpyD8+0RyA/xj/gxJf77B201o8PQ9P +y/z7WT1bLPhsjzTIHNw1GuWjCp56CAKQO5Vt4Hb3oXIk6flf1WW0EM09AyNBdai/zob yqA1tVEwxyZzx/fy9xIls7hpzh4WH9Zulu+/T2D6DD12QXynb1wwSwCPxGGpuy8vifZZ J5P78QF9DElF7jCzjKdys5aWy6iPzR228lO+M9vO5pSeryRxQSmMitgPh7tZ9MlFgCZy mn3Q== X-Forwarded-Encrypted: i=1; AJvYcCUm6kZGQFnPEI5jUGaBBVC+Bp9mBLAZ2ocHoZ+RUoD/A5AiBoSPCvMIxwbZRKHwhyqAm4JMC/XYDPSnHNh/ZFiqaUquQ/BkBXx1FwtWHza5eemiuOJ+r/oFjcrqwMMNrDWWF5VZa2kHW/0= X-Gm-Message-State: AOJu0YybFJhWpNEshgCTLDhspNIgyrx8U6iU1k8w0SxOkIbzv7u7SQfH vChZMYuI7jucno2oMRSYjoFPOTX5+UBN76IzbgUSd8Joe8ZEaMJ5 X-Google-Smtp-Source: AGHT+IEUZlhp9TKb+6k0Am/Sy+zZ2uIxRoBnY61fu9pVrtqAb2D5S1+DDQO5q6cO14Jzpc8DVbZbHw== X-Received: by 2002:a2e:7801:0:b0:2d2:ccb0:c6c7 with SMTP id t1-20020a2e7801000000b002d2ccb0c6c7mr4914035ljc.8.1709493654953; Sun, 03 Mar 2024 11:20:54 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:20:54 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 1/9] staging: media: av7110: Fix formatting problem where trailing statements should be on a new line Date: Sun, 3 Mar 2024 20:20:32 +0100 Message-Id: <20240303192040.8116-2-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch makes the following change: * Ensures trailing statements are always on a new line as per kernel code style guidelines Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index abf5c72607b6..83685443976d 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -248,7 +248,8 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe) // set tuner parameters if (fe->ops.tuner_ops.set_params) { fe->ops.tuner_ops.set_params(fe); - if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 0); + if (fe->ops.i2c_gate_ctrl) + fe->ops.i2c_gate_ctrl(fe, 0); } // sample rate correction bit [23..17] @@ -296,7 +297,8 @@ static int sp8870_init (struct dvb_frontend* fe) const struct firmware *fw = NULL; sp8870_wake_up(state); - if (state->initialised) return 0; + if (state->initialised) + return 0; state->initialised = 1; dprintk ("%s\n", __func__); @@ -549,7 +551,8 @@ struct dvb_frontend* sp8870_attach(const struct sp8870_config* config, /* allocate memory for the internal state */ state = kzalloc(sizeof(struct sp8870_state), GFP_KERNEL); - if (state == NULL) goto error; + if (state == NULL) + goto error; /* setup the state */ state->config = config; @@ -557,7 +560,8 @@ struct dvb_frontend* sp8870_attach(const struct sp8870_config* config, state->initialised = 0; /* check if the demod is there */ - if (sp8870_readreg(state, 0x0200) < 0) goto error; + if (sp8870_readreg(state, 0x0200) < 0) + goto error; /* create dvb_frontend */ memcpy(&state->frontend.ops, &sp8870_ops, sizeof(struct dvb_frontend_ops)); From patchwork Sun Mar 3 19:20:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579879 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA14779DCD; Sun, 3 Mar 2024 19:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493660; cv=none; b=VLN6ZKZruhfH92yUNdc/Au/0V0NQyxJcFjrJMu8P4g8IR+3pEvWsxbIOeIE7z7rhuYcmWIXoGxLdR53LqllgF/xEM/xtli9eOFZpZepz0oZeaJX9JqLwVO0u3ettMpq00bMChvGrAxhBnpKpo3gk8vU8VTDQaq6rrOnDu3Dteyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493660; c=relaxed/simple; bh=ZgYDrj0YYvD+dXTAAy8LDU2DHLTSdomYNZmOn8qNHto=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=a9Bn04GESpcveOrfTkrGWEfuWdUcs/pR3NCTSMWsttc70ivfOaVr1CTa7xAd/1svuA6h48TewFYdlxyG9IvY+r5Jk0iKapMzg+N9osrEQameOXNpn5Gh2XLFVCnoeu1zfZsLgrXS8niBwxJtXXBJgl9CCoRs+dYronR1AFj3Pcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mn12UnbD; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mn12UnbD" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d2991e8c12so37475391fa.0; Sun, 03 Mar 2024 11:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493657; x=1710098457; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=acUUqPyDOG3LFbF39uA3RbQi0wyLKzhv/SV7pzsE7a4=; b=Mn12UnbDjOiyJymPzVsOC4nTFVAZ2B0yqu79QmWKB3Y/EDHEC8+MAqBwC+K80VNrdC EyxzzV2Vx82CZeoz/uRcwp3YvuNA+P/cktJ+kyXgvVnV3sjTqIk8AaPF7qAHZdarxJ4C Kt0XWfsCgPKljwQRQ+lC9fvIDAFL0O9ody5q2zMoF55GYqydNC8fR1VTXW08PwK9nCgd F3f+RRvMdJjGzSArPig2Q2jpVub0aCJ8D2Xq1P93JGaeBBldSNacjXqdqaC98nxs02d2 BSGWnHxsIRXuTfi0Nbemr8rFw8yLf/NLdxJniBQEjBZB18Fwtkxag//dtInr4oAElahS OdyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493657; x=1710098457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acUUqPyDOG3LFbF39uA3RbQi0wyLKzhv/SV7pzsE7a4=; b=OMJ2TOvpDZwf/28nw8to9Abd1VSuJOrXcaF9s5Iod49WVlEWpow9Dxgl8Yv7PeK3tp Zjg9gzUd1hfYVTfXFwdArMLdjVdaESp/57yyT4DPlve8SCKsdLIOUnN8Wpdt9Nypkxtz e/4vNod+T2N84hsMYLnL9XbekzwKK4WwW3pZtO87KdFRxFTCGWv3nGdOtKlnWvPEoBAa 849IH2F95i1ZpcgFx8IDIHlTurUdV+JjkpFwH0KSsBVk5gyq1WuU+tCt4tMJmUYDiMbD ahZeX7Ws6WVDO62PZKrhRbAiNM8STuaJW4f0pCmFz9p2iv47/qC3sHDkC7R5SvUqj3Ce HEfQ== X-Forwarded-Encrypted: i=1; AJvYcCXrNtFiqluj4gGerruZKOAHx7agH+bWFlfLyb7REFv0c9ue5vUfTBJkxSmEznd6O+h7LVp4tqI3ziTv8mET3O1Q59cdxzEpjV4JfJPE8qNK6/Pv6WML2DTgtwn7MR48G2Hrx4oFsadl1Tc= X-Gm-Message-State: AOJu0YxuGz2hLM3HATrDsAiB2XP3daovu4RIqo25wy1DO9QE310mcBug rRXT8NcR3VoTVewmgUYYLFJ0cMeXCfcMR/dzc0d/pPyPNVqSZq4eJKqdtjpb7I5zig== X-Google-Smtp-Source: AGHT+IFEkey3XDjrh3yGBXOYsA99qGQ33aOIkyZKj28WKcllyhS3hRxdC3Vn8Kz4k3cdTgqQz1Qnbw== X-Received: by 2002:a2e:b0f0:0:b0:2d0:af40:7058 with SMTP id h16-20020a2eb0f0000000b002d0af407058mr2952956ljl.14.1709493656728; Sun, 03 Mar 2024 11:20:56 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:20:56 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 2/9] staging: media: av7110: Remove braces for single line statement blocks Date: Sun, 3 Mar 2024 20:20:33 +0100 Message-Id: <20240303192040.8116-3-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch fixes the following issues: * Removes braces for single statement conditional code blocks Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 83685443976d..2c30582191d4 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -529,11 +529,10 @@ static int sp8870_i2c_gate_ctrl(struct dvb_frontend* fe, int enable) { struct sp8870_state* state = fe->demodulator_priv; - if (enable) { + if (enable) return sp8870_writereg(state, 0x206, 0x001); - } else { + else return sp8870_writereg(state, 0x206, 0x000); - } } static void sp8870_release(struct dvb_frontend* fe) From patchwork Sun Mar 3 19:20:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579880 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A42C7A151; Sun, 3 Mar 2024 19:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493662; cv=none; b=s1NvV1wExTa7aCB/F8vYogKG7dX5CF7kL7L1OiU+5sVTFU/FxZB3cwaNeBo86pLSZWE+uGQjuHPPOUkUy0OgHExLx5xSGZNdFHp0JElPlIqru7AfYZFr0aLhqulO99smXh8R1BvWXrfamq1C8m9CVE1YPjg4frhphk56kCiYJGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493662; c=relaxed/simple; bh=fjLJl3cqq864oDm5SBt+fAr/J7DCTIM94MhguqKr5vM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U0B8aPZkxU1tF3Y1GhRoIDB+B7m3w+pmHaaueuJOF9UZWnnLvSE8l96KvejTGqkAcGBt2gQi1xYuJ/LmeDtGHLhLEy1aQHmWQZRzBI3vqmxzvF/DAYOm7fT3pCd1HU+6AJy7qAEwbF+P8u3tpTjCwGu7h0RJy6HN8n5UUkwhriw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WNQVyipj; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WNQVyipj" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2d311081954so41257911fa.2; Sun, 03 Mar 2024 11:21:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493659; x=1710098459; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BSWMAFm7064NyBCt1jab/mHpp/0m7wJq3xMDyIcOz9U=; b=WNQVyipj02/0C4kruJ0rbShXdrOo3bQK6w28HrqwrrBw5dUt1obNUqj7Xz7mVla0PX 6EWRt1fru2xdBAe93N7HxaH7X8NjWsZaO+WAvdu0IhVG6FbK7/gYFhw/VWUrjTrjpeCE Cjn1VQFCqLc3CejOLG0uZBwLzl/Q3WMUdjXZ3Gcz1++zJZBO7oOhJdYdZ7u2/PvFed3e 7H/JFYfyKG2g5Xuoqb/x44xgIIO/S0GkJkPF6ZRbX5Y34wkVlq8U8y8uWyqKap34FaE8 0J+6UJ2cJUqCWMonyn6GBqo7v5xNLzm7yyjrR2pQx/CD0set5lQo89oG2ZfQKa1vMT0x Kt7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493659; x=1710098459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSWMAFm7064NyBCt1jab/mHpp/0m7wJq3xMDyIcOz9U=; b=gGabu4YsmcK3B7Tvx9R2RaGK1mYH6QodITg6ZKb3xai/t+x4XWjiBtlGuLk1yE8ycp Jy6hiYklW4Dk60Xe0X5H3GWaAtgowdUB+H+5lVoYCROKjUZ2hbF8idtLjpO/NhDhnMEz yv2MpkTt1JSvJyXGgZ4rSspik0LHtwAGTLgrLsjVEIfkDHBnHN+F1BRi/YhPIUKgxzty aucqxp2dUNssqfAyb5Ulk32pcRSr7oyrNdewW4oDJw3IYqgAOcFIXdoLd2zXuG9pTPmp sreyBF02kNYR5xeRMBmBCP7jW89Tz1De1zJLEdcKBFnl2Lb17RJftwvi8EFkCksQ1tGd XdVw== X-Forwarded-Encrypted: i=1; AJvYcCXljUpM/kkceODB3BoId/zLghtmXJvAbnhdx2ufyYmyamuTmo1EB2AqVgRRqpon4kZnrAkGvaUVLHaCu5IkbirzApQ/g2dBTMYPPTal7YRGCChv69sA8Z3HzhdwAHpSkL0jGLi6CHx3itg= X-Gm-Message-State: AOJu0YyTxv07G6Pi9LQdhDK6+4tU9C5qsHoCUwlzjf/LD9V8arGu2VgP hLfRH975YNp85zJnOHQQxlOrATOuhVkgkLCpcWw6pYWuDIhSeUC7EGuz0YnYpMQI4Q== X-Google-Smtp-Source: AGHT+IHVxS+jGoxEdSVRi/KH7vQrwqm/vM05EU+EXeHogp8bytWihDhpCfUFzbKDVNGOr78j+i/Rwg== X-Received: by 2002:a2e:3a10:0:b0:2d2:a7af:f017 with SMTP id h16-20020a2e3a10000000b002d2a7aff017mr4835156lja.49.1709493658514; Sun, 03 Mar 2024 11:20:58 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:20:58 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 3/9] staging: media: av7110: Remove spaces between function name and opening parenthesis Date: Sun, 3 Mar 2024 20:20:34 +0100 Message-Id: <20240303192040.8116-4-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch fixes the following code formatting issue: * Removes extra whitespace between function name and opening parenthesis Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 42 +++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 2c30582191d4..1f6c02744b6c 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -50,21 +50,21 @@ static int debug; /* starting point for firmware in file 'Sc_main.mc' */ #define SP8870_FIRMWARE_OFFSET 0x0A -static int sp8870_writereg (struct sp8870_state* state, u16 reg, u16 data) +static int sp8870_writereg(struct sp8870_state* state, u16 reg, u16 data) { u8 buf [] = { reg >> 8, reg & 0xff, data >> 8, data & 0xff }; struct i2c_msg msg = { .addr = state->config->demod_address, .flags = 0, .buf = buf, .len = 4 }; int err; - if ((err = i2c_transfer (state->i2c, &msg, 1)) != 1) { - dprintk ("%s: writereg error (err == %i, reg == 0x%02x, data == 0x%02x)\n", __func__, err, reg, data); + if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) { + dprintk("%s: writereg error (err == %i, reg == 0x%02x, data == 0x%02x)\n", __func__, err, reg, data); return -EREMOTEIO; } return 0; } -static int sp8870_readreg (struct sp8870_state* state, u16 reg) +static int sp8870_readreg(struct sp8870_state* state, u16 reg) { int ret; u8 b0 [] = { reg >> 8 , reg & 0xff }; @@ -72,7 +72,7 @@ static int sp8870_readreg (struct sp8870_state* state, u16 reg) struct i2c_msg msg [] = { { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 2 }, { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 2 } }; - ret = i2c_transfer (state->i2c, msg, 2); + ret = i2c_transfer(state->i2c, msg, 2); if (ret != 2) { dprintk("%s: readreg error (ret == %i)\n", __func__, ret); @@ -82,7 +82,7 @@ static int sp8870_readreg (struct sp8870_state* state, u16 reg) return (b1[0] << 8 | b1[1]); } -static int sp8870_firmware_upload (struct sp8870_state* state, const struct firmware *fw) +static int sp8870_firmware_upload(struct sp8870_state* state, const struct firmware *fw) { struct i2c_msg msg; const char *fw_buf = fw->data; @@ -91,7 +91,7 @@ static int sp8870_firmware_upload (struct sp8870_state* state, const struct firm int tx_len; int err = 0; - dprintk ("%s: ...\n", __func__); + dprintk("%s: ...\n", __func__); if (fw->size < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) return -EINVAL; @@ -117,19 +117,19 @@ static int sp8870_firmware_upload (struct sp8870_state* state, const struct firm msg.flags = 0; msg.buf = tx_buf; msg.len = tx_len + 2; - if ((err = i2c_transfer (state->i2c, &msg, 1)) != 1) { + if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) { printk("%s: firmware upload failed!\n", __func__); - printk ("%s: i2c error (err == %i)\n", __func__, err); + printk("%s: i2c error (err == %i)\n", __func__, err); return err; } fw_pos += tx_len; } - dprintk ("%s: done!\n", __func__); + dprintk("%s: done!\n", __func__); return 0; }; -static void sp8870_microcontroller_stop (struct sp8870_state* state) +static void sp8870_microcontroller_stop(struct sp8870_state* state) { sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); @@ -138,7 +138,7 @@ static void sp8870_microcontroller_stop (struct sp8870_state* state) sp8870_writereg(state, 0x0F00, 0x000); } -static void sp8870_microcontroller_start (struct sp8870_state* state) +static void sp8870_microcontroller_start(struct sp8870_state* state) { sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); @@ -155,7 +155,7 @@ static int sp8870_read_data_valid_signal(struct sp8870_state* state) return (sp8870_readreg(state, 0x0D02) > 0); } -static int configure_reg0xc05 (struct dtv_frontend_properties *p, u16 *reg0xc05) +static int configure_reg0xc05(struct dtv_frontend_properties *p, u16 *reg0xc05) { int known_parameters = 1; @@ -291,7 +291,7 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe) return 0; } -static int sp8870_init (struct dvb_frontend* fe) +static int sp8870_init(struct dvb_frontend* fe) { struct sp8870_state* state = fe->demodulator_priv; const struct firmware *fw = NULL; @@ -301,7 +301,7 @@ static int sp8870_init (struct dvb_frontend* fe) return 0; state->initialised = 1; - dprintk ("%s\n", __func__); + dprintk("%s\n", __func__); /* request the firmware, this will block until someone uploads it */ @@ -350,11 +350,11 @@ static int sp8870_read_status(struct dvb_frontend *fe, *fe_status = 0; - status = sp8870_readreg (state, 0x0200); + status = sp8870_readreg(state, 0x0200); if (status < 0) return -EIO; - signal = sp8870_readreg (state, 0x0303); + signal = sp8870_readreg(state, 0x0303); if (signal < 0) return -EIO; @@ -368,7 +368,7 @@ static int sp8870_read_status(struct dvb_frontend *fe, return 0; } -static int sp8870_read_ber (struct dvb_frontend* fe, u32 * ber) +static int sp8870_read_ber(struct dvb_frontend* fe, u32 * ber) { struct sp8870_state* state = fe->demodulator_priv; int ret; @@ -403,13 +403,13 @@ static int sp8870_read_signal_strength(struct dvb_frontend* fe, u16 * signal) *signal = 0; - ret = sp8870_readreg (state, 0x306); + ret = sp8870_readreg(state, 0x306); if (ret < 0) return -EIO; tmp = ret << 8; - ret = sp8870_readreg (state, 0x303); + ret = sp8870_readreg(state, 0x303); if (ret < 0) return -EIO; @@ -421,7 +421,7 @@ static int sp8870_read_signal_strength(struct dvb_frontend* fe, u16 * signal) return 0; } -static int sp8870_read_uncorrected_blocks (struct dvb_frontend* fe, u32* ublocks) +static int sp8870_read_uncorrected_blocks(struct dvb_frontend* fe, u32* ublocks) { struct sp8870_state* state = fe->demodulator_priv; int ret; From patchwork Sun Mar 3 19:20:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579881 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1496D7A725; Sun, 3 Mar 2024 19:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493664; cv=none; b=gBAf5ZUHZm9MoOjidNVAsQBqm/mF3fH7D+3WcjS2uRaBUi25bqHI1TJUD5Udyg2h7inJBhViFs4ftPNdoXufskQG+tiRFdAnCtlntnzWzzNnYXlq7c36Qu3bO2b0OW4u0QY2IZT4FGFpEqIDMThrQUZIibExJfD1lEg/YHGrAUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493664; c=relaxed/simple; bh=+pDeDqWYQHPbRMFnvRN1azOZl2OlaoukQDC/kgYafw0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t1kxnxeKCBDH38CtzVVPW0OER8sbFJ4XsusCo5/bXBxFhAhPgzLM5rXSTIw8kdFiEM82L1jCV410qgcwyzEPmiRbptWi796Co1kZI6r+Ga1AXJdTxVgzSXh5DWpvBq7aCYBx7HvwsI7gVvK0Dc6s1l6MGw3L/bu0zUQrfu9GsCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NAwSjRjf; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NAwSjRjf" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d094bc2244so54199501fa.1; Sun, 03 Mar 2024 11:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493660; x=1710098460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DrOvp9WwUThyk7z9CwJba4kk8ujpOBp1PFvZQuMIxGQ=; b=NAwSjRjfi9txCTPaY72l84eGXKOEF+eKGW39nlk2HpPpCEdYyYhw/tHRSDw4QUZUoO bG/OuEmFKc/yBh+gtbb+11RyDVcHaPO3vNc280nw21DltTO33BAMn9fzWTD4WxMgXVVg RE2bCGD6oDeaudqeL+IanSP3rfclB7xhj23WsFBy+eUyHsXRhcBDgN/D05Cx+Rn7LKJl UK2OYeV8sArMqr09kU9WrbZrNtSdH39LvWXryrae7Ok7IfAo1uVdsHFPOAyKy/X4F43A 7YukIgwckRK+boudyTtBFBadHl0SyseMm7HEldiBwkF3coIJ2rTedGNXR5Hzh7xcHa9u mzAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493660; x=1710098460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DrOvp9WwUThyk7z9CwJba4kk8ujpOBp1PFvZQuMIxGQ=; b=DbA2k92KhhX+AdRhlxSSHHka7dOiSRWYI+ZxOUE7leH/2Iifxs5pqsSh/XrLwmT5qg 5Ydy7UPMGqi4DTPuITJTz+qjhqahK6tQ1ezxSMM0wjKsPexVc1MpPngPkOJ6Q7r/UttO CWGm3GjiHhw3y/jiRKo3ZWgCtGVuJPxuRdUn3fCHKEzzfEKPVKwuaapwF7Mn+lHQ0nRV vKo+oOjw1Zemks0XrV35O6sN55+5LJLRrcizySB+U2hH1I8O+QK3LAUEB01kIarhFC3f dEolEPkrB534NVRusvYPs8HLiriPh2Ef8Y5JOsEQGj9uzN+XjDF5vYCOyf4z+TrDYLKv 6Nbw== X-Forwarded-Encrypted: i=1; AJvYcCW2RGnCQb98zXRI0z5RP4oWDuHQLqNlOHCXtJtB5Ia/NnwaeHSybsvp1a6pDqd2bH5DoADc0cO9DVrefLgq/1d6asMI/DNNOIh0kNK9ncwlDt7WjMm1o1LhDvxhl2BuGaoe2yAHKhvlycg= X-Gm-Message-State: AOJu0Yx8RqMx1M8wma4ugmEQ5yRSsXrupQ8P3tF3/Hyu7tgTuibNS9hh YY87qQAvXGDDqwTgY5aWrJeAolgdCq+8ntsKMT70RUXZR8amtNn0 X-Google-Smtp-Source: AGHT+IGF9mbC5mPOBm2/SqbbaP7RNhqhC3ZmYgIGgjkAU2iMJDswrQDjFOPQblr5EODidg2vVntQ2Q== X-Received: by 2002:a2e:88d6:0:b0:2d2:3e88:7c4f with SMTP id a22-20020a2e88d6000000b002d23e887c4fmr4853130ljk.43.1709493660194; Sun, 03 Mar 2024 11:21:00 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:20:59 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 4/9] staging: media: av7110: Fix formatting of pointers to meet coding style guidelines Date: Sun, 3 Mar 2024 20:20:35 +0100 Message-Id: <20240303192040.8116-5-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch fixes the following code formatting issue: * Ensure "foo* bar" is formatted as "foo *bar" as per code style rules Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 60 +++++++++++++-------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 1f6c02744b6c..5857fc8b0962 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -28,9 +28,9 @@ struct sp8870_state { - struct i2c_adapter* i2c; + struct i2c_adapter *i2c; - const struct sp8870_config* config; + const struct sp8870_config *config; struct dvb_frontend frontend; @@ -50,7 +50,7 @@ static int debug; /* starting point for firmware in file 'Sc_main.mc' */ #define SP8870_FIRMWARE_OFFSET 0x0A -static int sp8870_writereg(struct sp8870_state* state, u16 reg, u16 data) +static int sp8870_writereg(struct sp8870_state *state, u16 reg, u16 data) { u8 buf [] = { reg >> 8, reg & 0xff, data >> 8, data & 0xff }; struct i2c_msg msg = { .addr = state->config->demod_address, .flags = 0, .buf = buf, .len = 4 }; @@ -64,7 +64,7 @@ static int sp8870_writereg(struct sp8870_state* state, u16 reg, u16 data) return 0; } -static int sp8870_readreg(struct sp8870_state* state, u16 reg) +static int sp8870_readreg(struct sp8870_state *state, u16 reg) { int ret; u8 b0 [] = { reg >> 8 , reg & 0xff }; @@ -82,7 +82,7 @@ static int sp8870_readreg(struct sp8870_state* state, u16 reg) return (b1[0] << 8 | b1[1]); } -static int sp8870_firmware_upload(struct sp8870_state* state, const struct firmware *fw) +static int sp8870_firmware_upload(struct sp8870_state *state, const struct firmware *fw) { struct i2c_msg msg; const char *fw_buf = fw->data; @@ -129,7 +129,7 @@ static int sp8870_firmware_upload(struct sp8870_state* state, const struct firmw return 0; }; -static void sp8870_microcontroller_stop(struct sp8870_state* state) +static void sp8870_microcontroller_stop(struct sp8870_state *state) { sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); @@ -138,7 +138,7 @@ static void sp8870_microcontroller_stop(struct sp8870_state* state) sp8870_writereg(state, 0x0F00, 0x000); } -static void sp8870_microcontroller_start(struct sp8870_state* state) +static void sp8870_microcontroller_start(struct sp8870_state *state) { sp8870_writereg(state, 0x0F08, 0x000); sp8870_writereg(state, 0x0F09, 0x000); @@ -150,7 +150,7 @@ static void sp8870_microcontroller_start(struct sp8870_state* state) sp8870_readreg(state, 0x0D01); } -static int sp8870_read_data_valid_signal(struct sp8870_state* state) +static int sp8870_read_data_valid_signal(struct sp8870_state *state) { return (sp8870_readreg(state, 0x0D02) > 0); } @@ -226,7 +226,7 @@ static int configure_reg0xc05(struct dtv_frontend_properties *p, u16 *reg0xc05) return 0; } -static int sp8870_wake_up(struct sp8870_state* state) +static int sp8870_wake_up(struct sp8870_state *state) { // enable TS output and interface pins return sp8870_writereg(state, 0xC18, 0x00D); @@ -235,7 +235,7 @@ static int sp8870_wake_up(struct sp8870_state* state) static int sp8870_set_frontend_parameters(struct dvb_frontend *fe) { struct dtv_frontend_properties *p = &fe->dtv_property_cache; - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; int err; u16 reg0xc05; @@ -291,9 +291,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe) return 0; } -static int sp8870_init(struct dvb_frontend* fe) +static int sp8870_init(struct dvb_frontend *fe) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; const struct firmware *fw = NULL; sp8870_wake_up(state); @@ -344,7 +344,7 @@ static int sp8870_init(struct dvb_frontend* fe) static int sp8870_read_status(struct dvb_frontend *fe, enum fe_status *fe_status) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; int status; int signal; @@ -368,9 +368,9 @@ static int sp8870_read_status(struct dvb_frontend *fe, return 0; } -static int sp8870_read_ber(struct dvb_frontend* fe, u32 * ber) +static int sp8870_read_ber(struct dvb_frontend *fe, u32 *ber) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; int ret; u32 tmp; @@ -395,9 +395,9 @@ static int sp8870_read_ber(struct dvb_frontend* fe, u32 * ber) return 0; } -static int sp8870_read_signal_strength(struct dvb_frontend* fe, u16 * signal) +static int sp8870_read_signal_strength(struct dvb_frontend *fe, u16 *signal) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; int ret; u16 tmp; @@ -421,9 +421,9 @@ static int sp8870_read_signal_strength(struct dvb_frontend* fe, u16 * signal) return 0; } -static int sp8870_read_uncorrected_blocks(struct dvb_frontend* fe, u32* ublocks) +static int sp8870_read_uncorrected_blocks(struct dvb_frontend *fe, u32 *ublocks) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; int ret; *ublocks = 0; @@ -453,7 +453,7 @@ static int switches; static int sp8870_set_frontend(struct dvb_frontend *fe) { struct dtv_frontend_properties *p = &fe->dtv_property_cache; - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; /* The firmware of the sp8870 sometimes locks up after setting frontend parameters. @@ -509,15 +509,15 @@ static int sp8870_set_frontend(struct dvb_frontend *fe) return 0; } -static int sp8870_sleep(struct dvb_frontend* fe) +static int sp8870_sleep(struct dvb_frontend *fe) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; // tristate TS output and disable interface pins return sp8870_writereg(state, 0xC18, 0x000); } -static int sp8870_get_tune_settings(struct dvb_frontend* fe, struct dvb_frontend_tune_settings* fesettings) +static int sp8870_get_tune_settings(struct dvb_frontend *fe, struct dvb_frontend_tune_settings *fesettings) { fesettings->min_delay_ms = 350; fesettings->step_size = 0; @@ -525,9 +525,9 @@ static int sp8870_get_tune_settings(struct dvb_frontend* fe, struct dvb_frontend return 0; } -static int sp8870_i2c_gate_ctrl(struct dvb_frontend* fe, int enable) +static int sp8870_i2c_gate_ctrl(struct dvb_frontend *fe, int enable) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; if (enable) return sp8870_writereg(state, 0x206, 0x001); @@ -535,18 +535,18 @@ static int sp8870_i2c_gate_ctrl(struct dvb_frontend* fe, int enable) return sp8870_writereg(state, 0x206, 0x000); } -static void sp8870_release(struct dvb_frontend* fe) +static void sp8870_release(struct dvb_frontend *fe) { - struct sp8870_state* state = fe->demodulator_priv; + struct sp8870_state *state = fe->demodulator_priv; kfree(state); } static const struct dvb_frontend_ops sp8870_ops; -struct dvb_frontend* sp8870_attach(const struct sp8870_config* config, - struct i2c_adapter* i2c) +struct dvb_frontend *sp8870_attach(const struct sp8870_config *config, + struct i2c_adapter *i2c) { - struct sp8870_state* state = NULL; + struct sp8870_state *state = NULL; /* allocate memory for the internal state */ state = kzalloc(sizeof(struct sp8870_state), GFP_KERNEL); From patchwork Sun Mar 3 19:20:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579882 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBE979DCD; Sun, 3 Mar 2024 19:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493665; cv=none; b=GNF2O0ah0SAvG67frVYFzf9TMGtyaOVOe1y20OZSsHZFoNVACNKWtmFvnEa4SkbUMfSgOKeqRBMaNCvtwy/nDAVP9+Ef1aG9vBbmFhqONM0rjM8RLVt9uZ+889gcfP/GF8HtUzPgciVVAQJs+e6giAkt8LEYk+Pn3zvIr0jniw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493665; c=relaxed/simple; bh=B7ddWFTd53goqpQQb2J/wqa+ZBWBK1KkrYMV21UOh/Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RIsQjP8oKN/0e/3PDkTN1aAzLoTtAefIies361F5BklQTBYZ/ONTHYcoPPN16w+oyawJ2XDADA3fPrD7YHwJNUXSeg8WufUQ3ZVTX8SlMe1/oXcT6HyCR3yO83eFbFAOEnn1ogxPEkAuJ5xliEWbT1E0ZDpaULdK7QhgKKFOC2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nmq9tsWK; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nmq9tsWK" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d2305589a2so55277061fa.1; Sun, 03 Mar 2024 11:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493662; x=1710098462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XBTeI5LwyRNmwz0HTOBaEkUs0RB1H06fQtRx1M+6JPA=; b=Nmq9tsWKD9PfeAqK54Nz7SI8DULnhbIXgfisMk+v1ynBHN+b1OJmKghSUYa+1TyoAz BnwoLRRt+WIoHmI4HUg8+tZKxfAtGwXlxvwNB1TAz+wOb19PfvdvZ9mkZC5dr1CbRgi1 Er452y9zYSuXP/Kpc2HT0VohHqZRgm7QgkR4Yx3aRZWjKrn312mbJ1+IGwnCpZhu+MTu /Yg8Xo5C2KGbCiXftNK3nrHRYvrwVCOlpXCtzfjAcJwzkwvL1H2hTcLC2ltyoTXzgmrz NmOdSXy69hrPsUe9EOwF/aFqzFbEER/Gdtzuu3+OeZT0V8WTgmSCl5XWg6IHSxG186rc L7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493662; x=1710098462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XBTeI5LwyRNmwz0HTOBaEkUs0RB1H06fQtRx1M+6JPA=; b=eXHXqp2i6BAqYSdQPFKPjXlR/E68GsifulEk/KrahY1ZFlVFfX/UsWM5aeMUTlSOv9 VCXqbqCs8a8V4fo13MbZqvNLxts35wiHYgoBKQMMUWpZxyKftUz3MbORa5NOw1RoeJts DknP0teyQxMhZZN8z0jMHLUqpMwEHLbEHJ/nv9PQBVFtnDfiK6+Us4wX74oceAyFgArS /7/cJHUEa5D3j+85JwvwBc31vUz2trFZg8ku+tP2W4P6xuRH5Mbf6oJch5Bfpn2iKoSr n0icnp+DQB6aFGnswnXMQKFndB3isORPJI1lZFK4dk6aKlDAEbS6lFMaEUFEzLkO+VgJ 78jQ== X-Forwarded-Encrypted: i=1; AJvYcCUPxDbAw16kBPoCKhm9sB14ZAp+EbzT1Bd5B7S/Xqw1XED9aJUV25jFpDGXNh+jg91OB38UCRE8ULlxqASnRl3Ie3f1D9ekystm7suupXYA4Ou1ecyitkoLfICZ9JJXdNeKb+tqmK3g8Ko= X-Gm-Message-State: AOJu0YykUailKVstQCWke2Uw2WZ7KcYqvzYAR9cQtd4lc+0/w74m3ftu ccFeW9xoC76qdSP5g4UKRLmUlJqXWObfus3AIwpQXv6OncKbuzBh X-Google-Smtp-Source: AGHT+IEtASUJLCUkIEQR8OZE+pwKH8QFdqX2jr5mv9lbn5Jg9d0L9aVjqOsTz2uyTv0fWEP2ZqgJLQ== X-Received: by 2002:a2e:92d0:0:b0:2d3:93dd:c54b with SMTP id k16-20020a2e92d0000000b002d393ddc54bmr1556767ljh.25.1709493661940; Sun, 03 Mar 2024 11:21:01 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:21:01 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 5/9] staging: media: av7110: Fix block comments to meet code style guidelines Date: Sun, 3 Mar 2024 20:20:36 +0100 Message-Id: <20240303192040.8116-6-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch does the following things: * Ensure * for block comments are aligned Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 5857fc8b0962..65795c5a01f9 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -1,11 +1,11 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - Driver for Spase SP8870 demodulator - - Copyright (C) 1999 Juergen Peitz - - -*/ + * Driver for Spase SP8870 demodulator + * + * Copyright (C) 1999 Juergen Peitz + * + * + */ /* * This driver needs external firmware. Please use the command * "/scripts/get_dvb_firmware alps_tdlb7" to @@ -456,11 +456,11 @@ static int sp8870_set_frontend(struct dvb_frontend *fe) struct sp8870_state *state = fe->demodulator_priv; /* - The firmware of the sp8870 sometimes locks up after setting frontend parameters. - We try to detect this by checking the data valid signal. - If it is not set after MAXCHECKS we try to recover the lockup by setting - the frontend parameters again. - */ + * The firmware of the sp8870 sometimes locks up after setting frontend parameters. + * We try to detect this by checking the data valid signal. + * If it is not set after MAXCHECKS we try to recover the lockup by setting + * the frontend parameters again. + */ int err = 0; int valid = 0; From patchwork Sun Mar 3 19:20:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579883 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7045479DAE; Sun, 3 Mar 2024 19:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493667; cv=none; b=tAgiEUJnMlvjIj+C4Ti1g8HpFrThvVM8yfvXILCDI2QOGdIQOCqrdaob+fVA6rG460Q1mMOCRjR6Wu8J4DujhNYk73Bpntfh/1OF6mpfgxHTTvNaTv5ufgTltsIH4khe0y5m96YI4ynw2ZaLxLrhIrAl1fgfi+W4S45ImA3/YNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493667; c=relaxed/simple; bh=X0Khxf5YaXVdMDDwmG/XUxfZfA8wZ8bFlA2x/Ormcsg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KbLdRL3hT5iQXsidgjRlBPzF1JFCs65JE+RG508Z4zp5uhtdWqEYaWJoc/03GzDpgJLncMuUfOMleWhtGpcN+hJodx8uX4EV7r7VnRwY5yvxry+QxLfWbNAWFaE2uEVsTHi1+AZCtnOYZ+slO2vz9BEY0QGqJXgS5exIV53ACLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=henVKb4W; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="henVKb4W" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d220e39907so56273641fa.1; Sun, 03 Mar 2024 11:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493664; x=1710098464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hLhDnHzoGb7/T0BKuqDuN942/r+L3umotAQ2YW7CFP0=; b=henVKb4WqN1AupcCcZCPVQnB3IDRx2v3sryBbLPz7DJwAgBZmLyI47ew6RPC7u7AFY +5N6QsrsV8QDn+hoBSjp65fYYDFnkwz+5cJbLCRmXpqBG3imEw04lPc2vRlTGJ6sEqKE ptpRx4Kh6Hsz2JYfMsakvhq2hGIa923cccPm6UHjbk5spOLUlz9Ls2uKDB8fXjkzZVD/ ybEmo6R6UoQz1+yv1qBYR2Zm//AAxUSX1JynMuzA64bmG7v/cVnUaiUD5LXu8g9hKSdY U+gi48uOyP4eJN5+wZQpxc8JvPGL2X9ieM2EBLcR91/pmX6PHL68JIhjpaSchLZd3owE zFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493664; x=1710098464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hLhDnHzoGb7/T0BKuqDuN942/r+L3umotAQ2YW7CFP0=; b=wRLkkGpV62I5zwatEnQ3Tflw0PbmTR3GK1XUcxkHz5fQpaXHPzm9vQrIDrPsVeRX4T ohuDEPbQqjqvz58E3V5Xy+s8gu2bB5WRFmZWPz9HDMw7Exx7zhBtQ1mR3EywiNWaUP2Q oIBkQec1XuD7GSec1+LhDqicCVbrqFtwAe+tTZQSE1g5yTiInPveOWfxYyAe8OidxPPZ KGwBnCUIwha0osjI6uulfhE8gtJmarsZTl4dzM9UhaanoHLEbdv5J2AeBBv68oBwvSyn 2FuUxGCk70kwmczchR8KqfzvZTF3vq1sRrOyuLU3XdE+m3dpPmhj6GGnGKWvVwcUW9xM RW+A== X-Forwarded-Encrypted: i=1; AJvYcCWkUluA5AGGoVjmIgSF8c3+79ADxZjxO4/o7ylfmdM8/P1bOVYUmNPmxLyQSQaGE4XYr1XbVHplrdbFNiA1q6lpNpKQwgU1w29Y6d9lpivTgFD4KANF359M2jCYkdSSAFDw/Tvf6VY4wmI= X-Gm-Message-State: AOJu0YyQSqKIlSC0l+Uy4YNi3jmvxCpG2kOkNBh1rQbbFAiVodTf5D94 Fd7mtCNWvW+ylnKqD9bVabVfl/p/PRRwYL6bVgYstEUm47kW/oJ8 X-Google-Smtp-Source: AGHT+IFBf0Wq4/vZycQOinhrIN/UFAicT5Yw1wgHBZJXk2ZLA4m6+2eQzssMdxkFqUu2ScAsvykm+g== X-Received: by 2002:a2e:b0eb:0:b0:2d3:56df:ea4b with SMTP id h11-20020a2eb0eb000000b002d356dfea4bmr4129844ljl.41.1709493663618; Sun, 03 Mar 2024 11:21:03 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:21:03 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 6/9] staging: media: av7110: Remove extra whitespace before opening '['s Date: Sun, 3 Mar 2024 20:20:37 +0100 Message-Id: <20240303192040.8116-7-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch makes the following change: * Removes extra whitespace before opening square brackets '[' Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 65795c5a01f9..a5a652c0b363 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -52,7 +52,7 @@ static int debug; static int sp8870_writereg(struct sp8870_state *state, u16 reg, u16 data) { - u8 buf [] = { reg >> 8, reg & 0xff, data >> 8, data & 0xff }; + u8 buf[] = { reg >> 8, reg & 0xff, data >> 8, data & 0xff }; struct i2c_msg msg = { .addr = state->config->demod_address, .flags = 0, .buf = buf, .len = 4 }; int err; @@ -67,9 +67,9 @@ static int sp8870_writereg(struct sp8870_state *state, u16 reg, u16 data) static int sp8870_readreg(struct sp8870_state *state, u16 reg) { int ret; - u8 b0 [] = { reg >> 8 , reg & 0xff }; - u8 b1 [] = { 0, 0 }; - struct i2c_msg msg [] = { { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 2 }, + u8 b0[] = { reg >> 8 , reg & 0xff }; + u8 b1[] = { 0, 0 }; + struct i2c_msg msg[] = { { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 2 }, { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 2 } }; ret = i2c_transfer(state->i2c, msg, 2); From patchwork Sun Mar 3 19:20:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579884 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D68D7BAEE; Sun, 3 Mar 2024 19:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493668; cv=none; b=uOi9Bt/mjKyDkejS46H3ew2XH6aLhkmpkj24ESBr6c6J0p8/bC1VRvRCg17i3ZV4HsWXHG+IQMiuB78Vsd+NN+ykl85yzGywYL/d552u/+im+JQ3WgyOomjziPe9sIkjzTmyH2pTDA3OgIAGo64dThe+pT3dubOkF2zUGSuvM0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493668; c=relaxed/simple; bh=zDiok/ntB/JOcjhEI7yW0JyPvlcBaaiS3RcM2NlU7p4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ox9qBYI+HxtN2JpKdRBz4oiqHsRUsALKn6YqxE7JUnV1cE6MztG3fvEkpVYzwsUY8n4dNsc/uiWZOQhmyoa9aodoQnJMrGYEvxr1Za/qXgRyefTTeH4YUWKXyJqdDSqIiA2tobMif0e0MYJokGziVszgghFma2OKNfMg3nbRGAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BpMQKHrW; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BpMQKHrW" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d29111272eso58721531fa.0; Sun, 03 Mar 2024 11:21:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493665; x=1710098465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wRnBtGKy4pYvIH9MCoR04B6/MZ+fpULUo8TNXf7ZwKo=; b=BpMQKHrWOc0bC7fyz3feZ9uiPw+GD6hzGUZYlyGwhsc/IqBkeVb1DeWX7kWcW3uIvu 0tXZISE26x47CbuaSnsPpp98pGyM+vnlBWrVc6sWcCyDzFkZLFDY3YcoTlEYVoM7jqBn r6kcKWJV2DW88C7e1TawOqjm2VHxpE7r6NZR5LSAKjC1LSsqGbTUwX5Ih6BQcLwyOlVW u0DIGuSqKjFL+1HqTPRCtWyGcQwXdi7SsZ6zJRfYmLhZXAjGLofAFLgjeYYrlrWCQsoQ hr3/v+EvQMelDyaUSKjzx/wUK9U9QyvLORldFNP+OLhajhypo/pdsh4xTfLIM/XhfMS/ jMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493665; x=1710098465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wRnBtGKy4pYvIH9MCoR04B6/MZ+fpULUo8TNXf7ZwKo=; b=HGL/uRWEZx3dvf7ife1kAtkwOovPY9rCN0W4/gvqBb42i1pwAXkZ5r8Ld+604Hlbrj fNP1ZlgG33Y+M/wuBdB+22eRffwKuUOoE58YYrMhOFVQFS7vLLaRCnVBqqQjO24gFBfu AyYD9ateFP5XCSVX/VnIaF6pUUPWz4hz+txrzyQDh+ggvcsqzFMnxQdQbBgHXPwpuhVp 3OHVIz2RiBGHICwMSxUC/RtZCMZ/pLMj9YFUDddz5xWhjqt/pi5MNda6E/eeyVICtDSk 8oP417DJUZhJdZLF4qgMy0aSfLLR/J1MmrOBP/sshvocmwt0RtqOi3oIQddlE3g6S7el WnSQ== X-Forwarded-Encrypted: i=1; AJvYcCWKtUHlQSxSpg+I9CAtACQ7b1m+GI9wLdv6Sr7bajDsXbNZcfe1KND5sp9HOJ5IiRuqwktQ8Y9x0BDzUEwJsKMcvRtPEWhAsH4PP8b7CQGgf7qPuOrJMbIPDJvRAvW8iVmZiyRgKO7g+nY= X-Gm-Message-State: AOJu0YyWqS+b2uRAhd6FZF06zTxjEDVeG5+vLYEHJnLsq5onZQyXzldS mNK6D3eWiW9+BZagXAB7hHu14Q+LPItxl/AcL4qbKH8GzkXULel8 X-Google-Smtp-Source: AGHT+IGotyxZDKaHw9Su+5u5K69zrdBaB+cftkhkl91JEmoQdP9wxH+33rEZTClqQ3TZdmOCOIcAxg== X-Received: by 2002:a05:651c:1043:b0:2d2:a440:d704 with SMTP id x3-20020a05651c104300b002d2a440d704mr4921495ljm.24.1709493665209; Sun, 03 Mar 2024 11:21:05 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:21:04 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 7/9] staging: media: av7110: Remove extra whitespace before ',' Date: Sun, 3 Mar 2024 20:20:38 +0100 Message-Id: <20240303192040.8116-8-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch fixes the following code style issue: * Removes extra whitespace before comma ',' in parameter list Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index a5a652c0b363..8afddf61e52b 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -67,7 +67,7 @@ static int sp8870_writereg(struct sp8870_state *state, u16 reg, u16 data) static int sp8870_readreg(struct sp8870_state *state, u16 reg) { int ret; - u8 b0[] = { reg >> 8 , reg & 0xff }; + u8 b0[] = { reg >> 8, reg & 0xff }; u8 b1[] = { 0, 0 }; struct i2c_msg msg[] = { { .addr = state->config->demod_address, .flags = 0, .buf = b0, .len = 2 }, { .addr = state->config->demod_address, .flags = I2C_M_RD, .buf = b1, .len = 2 } }; From patchwork Sun Mar 3 19:20:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579885 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99D4E7BB0F; Sun, 3 Mar 2024 19:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493670; cv=none; b=cCKHt5N9F3bENIphAGDePxDe6qEtTSOIrcjTKzJlaLS1oX/iK4RstuqSnaohe1ViOmzYvr6qZGU9EHUwYviIJhX3lO7S7g2DNRCUCqi34w2ylv4AsAknZ4TYJiKmNfKO255sh6Dx0/i0dHbgZO8KKWcX6rdfpCx5tv1Z4eT1nrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493670; c=relaxed/simple; bh=HXXGYpJ2R5e+79N0pwn2xJeIEF177FohfLn8yHJouxw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PpSVqPKHq/WWS0CMQmmDba8t7cjW7w8OjCIZtpcg2ouU1lEPPk0LyNI4Q16JWaiEhzfnEDymePaZlBMlc1fNZqQqM9gwncPLIlRkJ/paB4F1d7QBgUuOa7Zq6prqwyjzshfmUFpZKIF9alQDnbzRRSMLxn+oDixqQXT+Bt/x4Zk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMCDnVW3; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMCDnVW3" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d2509c66daso46918601fa.3; Sun, 03 Mar 2024 11:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493667; x=1710098467; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aV7WL2VyqwjcPUAOHZGvSrsENXpgeqqeSjEPfrb9SVc=; b=FMCDnVW3zGoktWTrSMIU3sNej10OUIEN6Y7wFD4YXAQw5HqyIrxsp2PZGbD/7aFOP0 iEYN7zoy56eS7Zzzuz/rhrlwQgHuFlMo3eiTZm9YesSQaZSj3v65RdBbCugvMR1ExF2b 2TGFemHNaH70pPx51FPfTfCO6Eq580S5lqEnNP5RcvXiba4yrPam72VyY6VPM+/DOAx8 s5+T3Mham6R/fO0HASImWfqBZVUIoWJ3XFgrxk6LRudW9P+DT78l8g8Vhng09GB+JHOY N4uV+7ZymU0b+fc5MLJKEjTCmFQm/x8Sx6dCXKs0UyV90MfaWC1W09w5B0kfrS4bPA6R EGVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493667; x=1710098467; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aV7WL2VyqwjcPUAOHZGvSrsENXpgeqqeSjEPfrb9SVc=; b=u3a7kxMgKseFZ9sAecIkF37Oz7EP2D09+f+9odPI6mJpbK13Jej+8+lCqqdElhgRag Co4X96JadsjUMB1gZ6aSkntJAoNom7zvmQIIdZfSh9yb11yOtM4whqaH8GpjlopKUzre gaS3Yuo4taZx1IxejXST0F6bkBV66/TXXx5E3O89JbnwL3wouyn3RlX6+9hYli9tU5HY IpRLi/McJ1ur60nlNworFPLpKd1gK+B4uKKuSkT88YC9fMSgjU8pS7fO3c/j7l09oc9A P1cwPIc1pE6KIH8TtnaGfFFIEg2Ic0zD6jZxZN7AXdzh4OdRPZPzyfTRYNWVgLqvmHmF HaQg== X-Forwarded-Encrypted: i=1; AJvYcCVcsdZLsUPw9e4wq+BKT5KKbsZyKUvbn9mF4U/Ypj5L4nHkojltSuJvWUGw0ey2v/rsITmLhoIQXeQZFZNCTeiwoWZ1Jh5tzJfeYorPesbffORInbNtjtfTiPeqeNw4V8Sna4g+GXbtLqU= X-Gm-Message-State: AOJu0YzrzUs8Ql4+nIQbjuJ0KUhmQuEOUx/VIri+wdneAGwmV2h6neRs L2mg9hVi2ohlsvZw0VK3DphmfM1Xteppc/9WKmg7WaLjgApbdeUO+Kd//w4+4hTh4A== X-Google-Smtp-Source: AGHT+IFYrK6BFXMxgBtOI5e0v7ag4D6ZxuchnvKaXkTkh3l4iybNsnEO87VMKw9Q9i7M4HIfhfeXLg== X-Received: by 2002:a2e:989a:0:b0:2d2:e9f7:6753 with SMTP id b26-20020a2e989a000000b002d2e9f76753mr5063879ljj.39.1709493666778; Sun, 03 Mar 2024 11:21:06 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:21:06 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 8/9] staging: media: av7110: Ensure whitespace ahead of opening brace '{' Date: Sun, 3 Mar 2024 20:20:39 +0100 Message-Id: <20240303192040.8116-9-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch addresses the following code style issue: * Ensure a single whitespace ahead of an opening brace '{' Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 8afddf61e52b..a3c7660c5092 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -107,7 +107,7 @@ static int sp8870_firmware_upload(struct sp8870_state *state, const struct firmw // do firmware upload fw_pos = SP8870_FIRMWARE_OFFSET; - while (fw_pos < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET){ + while (fw_pos < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) { tx_len = (fw_pos <= SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - 252) ? 252 : SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - fw_pos; // write register 0xCF0A tx_buf[0] = 0xCF; From patchwork Sun Mar 3 19:20:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 13579886 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3A87C094; Sun, 3 Mar 2024 19:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493671; cv=none; b=rBy3I1tOKNt52eMeO/ugDJBsFIw3h2usmBrwE6AW3zXZ7biPu28pDcCz9vQ0ad0G9Jj0kAjM872Oo7DsP233KIjPhetBtqjGA1Wcb9rEyV11WV8E6PiEM7yWNDDSjk5yjrS64zdVwCSnMtyceVMsUThIbGSSHSIXftr//GuyYgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709493671; c=relaxed/simple; bh=HbF8PhOHWXzQebb+281vK8rEhxcXGPsG5YmKmH9qB48=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kpmbW2vfqprzhI6Qh6rZCeCQI/TWto3eaSVLWd89DyIo8+hMDQbIee9xBcuN4RvOhYrgIMuw7Eetzb3M6flSdFvuUuY9LwKEl0ANFBGh402JV3wYU0dWnbu19OOwWjwBTGc2UjuXOTEu3goX2yJWqnk0fuFDAsfCNijtP+NsZLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z1UTb49q; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z1UTb49q" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d269dc3575so32378001fa.1; Sun, 03 Mar 2024 11:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709493668; x=1710098468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D1NBB/w/tNKdMZAaK5g6A1PLO2nptHAk6enBO1WBgZQ=; b=Z1UTb49qL2HPpX8fTLsSPTPP52LQOr0MG+0ThTcwSfgl4MCQkf7+P3rMNsKMz9HlkV uRSVz7sgEoFFF2IiPpo2uXb3EwSPnq8O7nfdmfyhzBYkxs2j7SXRLHWMlR7RVLMMQqbR yShwR1QpwlWWLFeIvTCJx+rT/J9uq5/JfwsOo0noCSmcckohxNVTBbn0F3ZXTXZnA13l 2yemL47JudLkzv6IMuMLHLhELXVrr15uK69lcs1W7N6qCooPiNZKY3ZWYz0+Ql7cnRGb 3ghRrZiNYAMJpNAZuevgWSgGz069tprc7iksDJ2e7kR/8gu+aJbEQt1Dbr61CJlHN+cA 730A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709493668; x=1710098468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D1NBB/w/tNKdMZAaK5g6A1PLO2nptHAk6enBO1WBgZQ=; b=ICnAJglU8MDIISoPmNlD4Vr2ICmwse1ISEHrHEauD4B0562Us4PZabo/Qme74oS8P8 fV52m1YPvvy2w+a/lfjQOYvak7k7v4Xul4IY+YhQmxp2Rh3PKhyqsfFigIxy8kMYbos5 gVxrBwmF4dKngzWqnETRSMsRNQxqFJF1no7xv1CYmAVctYRCuSFLRG+17VJPjr0M5896 mj9yUgMN6lPoW2jWF77xX/5eQ3cnhC22RiFhQJaUJgrExr/lu76h4zpBEaVuT8Mo+H5U sXo0f8fs5bMWIjsVgL52PgHdnYVwF7xUSGVQd9HN6bU+jnikMuRVsGRBLJ5XtnhmfqFw UruQ== X-Forwarded-Encrypted: i=1; AJvYcCWldB7eH3N4Z0V6sIkzgv4MY/r6gBWUyl2/A9UFevnQJr+c0HbZSBiLJ6yN7W1gIfJ/dn38gDdhb7mSe+rCxi6tZ4j9rbgALBjySRkIZYdZV9/n2LdTidq2maxayTaFTGzd1zlNjwvVhy4= X-Gm-Message-State: AOJu0YxKl66us2qO85+wzOxEDBi2TvlLEgCOGTmgrmm27Mdipu7cOhxA r/8NA3/rgYdpRKV/JVgyvXUVTNAG/5HGei9cehn805KxC0Wqzpzd X-Google-Smtp-Source: AGHT+IFCdKjU0W9mTDjumHrBpz5piviPHr5+0eVAzAPOVxFlUryE4CqRsVq+4HKGKE9pwhUuQH//Jg== X-Received: by 2002:a2e:b602:0:b0:2d2:864c:8467 with SMTP id r2-20020a2eb602000000b002d2864c8467mr3020394ljn.20.1709493668462; Sun, 03 Mar 2024 11:21:08 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id y10-20020a2e9d4a000000b002d3c466adc7sm68438ljj.15.2024.03.03.11.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 11:21:08 -0800 (PST) From: Jonathan Bergh To: mchehab@kernel.org Cc: mcgrof@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 9/9] staging: media: av7110: Ensure newline after variable declarations Date: Sun, 3 Mar 2024 20:20:40 +0100 Message-Id: <20240303192040.8116-10-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com> References: <20240303192040.8116-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch makes the following change: * Ensure a newline after variable declarations Signed-off-by: Jonathan Bergh --- drivers/staging/media/av7110/sp8870.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index a3c7660c5092..f652c8d7d2ee 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -538,6 +538,7 @@ static int sp8870_i2c_gate_ctrl(struct dvb_frontend *fe, int enable) static void sp8870_release(struct dvb_frontend *fe) { struct sp8870_state *state = fe->demodulator_priv; + kfree(state); }