From patchwork Mon Mar 4 16:48:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13580911 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101591E487 for ; Mon, 4 Mar 2024 16:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570936; cv=none; b=mkAHup2w0a5knMOxJlgaHzJHkmXfFiVY6cFpUqnS83D7NcDJ3icDE+buSzSi1KHxSyjd/zTDf2aTgjGtE1rhyGAJ9YUGdCGUdKwltK6cVfgYo9jKU37fIB+WFMWoX/DFKRm1O8txlC6/Y00B3Fr5xIh2MlomhIq0xCkTEMRapSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570936; c=relaxed/simple; bh=nZpVwVH0BR3YhEBXu280vi0WI9FThxj+xd+dr4gRZSY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MY6XNMz2RkvWRRXanyvXn7kHn5C/gc9p8Bp7ZhmaB+cF3cudZVK/R7sSHf6xXs0ekp+T/Ftb3zL551X6BSVN70YUVRIErfITjbSfA4km+ydkaI9PBFVcj+67ZVZgeTxPO2DHhZfruzeaNjEs94nJYhp7zEJ2wIKyXb51bKGqL30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ce8nPGCn; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ce8nPGCn" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-68fb3a3f1c5so25664196d6.3 for ; Mon, 04 Mar 2024 08:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709570934; x=1710175734; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y6c4ULGYfSqW+RPKDMPo8yq9tibiiE2qSK9J63ajOtY=; b=Ce8nPGCnRVfieK0860agbRtx0qXoAsx5Y79OOHf+4E3sxV/90rkl2/bw1nfLRQo0TQ 2VN4RxMFxEbOOseyQMdltJ6ngsACQPLwkHNPoPoyRSU2/Z8EpyAn5Wxb6u6/ykIb5ItC HSzOXUjMLlrFBSNha7apS6C1sdp/RJJUrAkEV58h2cZ1iWrBInR/8qXMrsu2Bv3uLHEL lTr5jQEAIXUHir5R94qrb0mZc0hyQWMIyioPG2n6yRFETP+3yHLxRTuJmkfNUBClUkUh Hzri59+e71dQCU6FW2O+DiBvktbN7Nway7lZUzf7uqzXsJK6swWo+A03Y/63+gaKFYmw /dWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709570934; x=1710175734; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y6c4ULGYfSqW+RPKDMPo8yq9tibiiE2qSK9J63ajOtY=; b=H9eABtfCDJYFFhNS/zHbHAyjoE4SNM/ifgwNBM+VFxVXH5/tHTL7IzfuEPiXGXUpk5 ZX5Hkl9ButKZZnH/XxMeEUlzw4mimHIA0/fYQFBu2hrdL67QuLSs/ULub/W+yQHWB7qV Ml2+GaiVvRzXnFP1F7gJXn9y86X+1Ob99cvUj6jayt95XMn7qTRxcJIgeO+qLMcvISoi snq2kyxn1ikm+xUOg2vdD/r1CV56uJZeqZqFGqUKULXKaOovGlgFA77wIDySV5t16yDp 1NUQgLTloYPovlRWGqN7f3aypuH5z9ST/t3CMYUEOBTsfLV9SfEtWIRMAfssoK3cac4I ADLA== X-Gm-Message-State: AOJu0YzMAkVrSKeRJCUMa2wG+eR4Not/5oYrZA7g5PlJfTyPHOyEJvhP ahRDnR2tRq8/lzYgEjGBQrw/uFAdE4TlBqE2/tp+ZklGp8qTIVFNXTPKMKNh X-Google-Smtp-Source: AGHT+IHRM/GkUq1Vr+0XfqX9ruRsxNkSJBz4dCsX+shgVddlPCNnmICzOgxSesLOOqq12ieuSq2wzg== X-Received: by 2002:a05:6214:a4a:b0:690:59a9:2704 with SMTP id ee10-20020a0562140a4a00b0069059a92704mr8724899qvb.20.1709570933637; Mon, 04 Mar 2024 08:48:53 -0800 (PST) Received: from LOCLAP699.rst-02.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id qq1-20020a0562142c0100b0068fdc55ec7dsm3858466qvb.68.2024.03.04.08.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:48:53 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 1/5] client: remove unneeded initialization Date: Mon, 4 Mar 2024 08:48:42 -0800 Message-Id: <20240304164846.1783148-1-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- client/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/display.c b/client/display.c index 83214c86..f0f3282a 100644 --- a/client/display.c +++ b/client/display.c @@ -194,7 +194,7 @@ void display_refresh_set_cmd(const char *family, const char *entity, for (i = 0; i < argc; i++) { bool needs_quotes = false; - char *p = argv[i]; + char *p; for (p = argv[i]; *p != '\0'; p++) { if (*p != ' ') From patchwork Mon Mar 4 16:48:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13580915 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B6D20323 for ; Mon, 4 Mar 2024 16:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570958; cv=none; b=BeQHlfq2jR2+YnJlSjp0DXwl/VOlA71c8yAesXqNXPCupAv31Y4R1BysXKc9bvfd4TYugd0yT/HU++Ae0giJJYrXKUnWMPVak1/XSAc8kRdsEK92Oi6SChQJa4PQbKMBl8zQdTayK5Z4Co/1KkXPo+Cpjf1YZvO5cIS5dFwL+6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570958; c=relaxed/simple; bh=DoDbaFq/tRaaRrzbG/D5UYTxQx9yveG5Zb+1OZEcJJQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DZoxdrMGwuciOcwSCZ5AsyVg4wGh8+CSs90HfpimaoQMTmKnfsyQACibytMeMFA5TEglzN5y/d3Y1NWTv6YtZSFbNOn/Oc3aRLqO+saot/YqJnobbGauuB8LJGyhwKIsju90fSNk6f4ks+E1OlGqwfo/1hEcLeDsbrDN8yG8ia4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W3xKJiwi; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W3xKJiwi" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so4202012a12.1 for ; Mon, 04 Mar 2024 08:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709570956; x=1710175756; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=my3yXByJ/TUzRz7KNXfNC3XtRu9W2osDqJMyGwNvrFg=; b=W3xKJiwi34Wj9JkXcBdRJY/wMwbkU8mC2952cPxTvETAI8UEu+PQ0dLump5FNTir4Z ryIrUf7vvA3ymiB+b+sDfud/5NQw5eJcCtfCPL0lRXwFmLDMOJCq42sYnL+wvzngGPcs LkIo9IdpsWjEZQ1tmw2nnkmCldV8oslcwFpcg61W5jRVmgPtl7ETmVYehmiiLZpEWIuz wkP015yeyBasuxY7mBkXjiw9haFVs7AKU27p9zW+7tvUuuE8iJTo0tIjBID18VgahwzX 4yqEkwASkQaLSJ8+5gBxDk556NBlOZXEkLYy4NWn1p6OHC0l98jRSvQ4ENctGNcNL62Z xABQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709570956; x=1710175756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=my3yXByJ/TUzRz7KNXfNC3XtRu9W2osDqJMyGwNvrFg=; b=DBo8aavf4M5TPcoqAfIPsQgMrkhvtDaSaXLAwTwhJNVgU8XMiwygjv1hUPv1lKYVyM Id86OuLQjR5Nhl6GZUBFp1fxHPbMKQeRRd4zdq32/F5IpuL3k4R4PjntKR7Tv20NXoFG dvn1Wad13894pJ061yVlXzwuehktbL6umrD1U2Ho6b6vASVpwbw8VaDdQueQl8cKYb/c IkVOIURJqpLnND0KQLphkJj1OTgyiZ1QyBY/ubPSVtVX6XSa+BFc5E83npxKR8k4RzUO sg2fWXop4EjrnOvDGrDmHtmZmexvnrCkgu9XAgFq8Lz3z6HJZekcS/qJJM9EpvBSL6Ox Lfrw== X-Gm-Message-State: AOJu0YwINRPLNjNF1SfXHZiUzP3LkF7f35jwJZ8/1QHt8xNIeNIEhV8I Y/V9iZM14ybqnPIyFTRgvPXjk4560XLmUzxrlUi/7XwIOUr4+tIpwHIse3ni X-Google-Smtp-Source: AGHT+IGBdJL9evt/3LqscKdalTwqDpLGD1gew3p6cnJPHq4mj64FGR82w8YyvMsYwAkQBWvLAEewYA== X-Received: by 2002:a0c:eb06:0:b0:690:5cf1:e14f with SMTP id j6-20020a0ceb06000000b006905cf1e14fmr7938867qvp.44.1709570934819; Mon, 04 Mar 2024 08:48:54 -0800 (PST) Received: from LOCLAP699.rst-02.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id qq1-20020a0562142c0100b0068fdc55ec7dsm3858466qvb.68.2024.03.04.08.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:48:54 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 2/5] ie: remove unneeded initialization Date: Mon, 4 Mar 2024 08:48:43 -0800 Message-Id: <20240304164846.1783148-2-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240304164846.1783148-1-prestwoj@gmail.com> References: <20240304164846.1783148-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/ie.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ie.c b/src/ie.c index a51724aa..86f33f2a 100644 --- a/src/ie.c +++ b/src/ie.c @@ -1178,9 +1178,6 @@ static int build_ciphers_common(const struct ie_rsn_info *info, uint8_t *to, countptr = to + pos; pos += 2; - akm_suite = IE_RSN_AKM_SUITE_8021X; - count = 0; - for (count = 0, akm_suite = IE_RSN_AKM_SUITE_8021X; akm_suite <= IE_RSN_AKM_SUITE_OSEN; akm_suite <<= 1) { From patchwork Mon Mar 4 16:48:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13580912 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58CC61E487 for ; Mon, 4 Mar 2024 16:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570938; cv=none; b=pPyrIJIKWLgpXxBYeo4+5MbuSJSi12PRdORGny5wImeOuYQX78mehvtoahMdyhOUtbc3RXIppCEWM43ijYQnMAJNFzvoIiEnC1GgpMmtp/1hTgSrygfhbqMP0yXognNZWG4CNgJiWbJcfLrsipXH4LNwelf6WnoSLglQ3pmLp7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570938; c=relaxed/simple; bh=WPk6C1WQKKhbC/aSnDJhUxOCr/Yc+AE5hYHG6HWAPyU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=arJCo0+ExkVYqtx/8UttjRH61qvb/yai9rbuo6g1hqBsjhx2JJJeNy2EH3nSzNEpSaKu0pYeQHVInMIjss42a9j/See72xjM528IuyTtyX3Q4Kk2jc/iXvXhCK1oENQ0/RMTU3jO9ql1j3C02uRlS48O15GkfZeuV05DGY/UQEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hSRz08+F; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hSRz08+F" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-68ffddd89d1so17719406d6.0 for ; Mon, 04 Mar 2024 08:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709570936; x=1710175736; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XNLrofK26lIEsZuiCmRsSvu92wvxeyXHsAzSraLT2rk=; b=hSRz08+FsHBq8AuZ5KDixUxKwiuAfFS47KpollJ6bCnqYDo0eejER0rIM6Azgfn50z nCLP913+SDBrsVdZIgAq8Pfi49Go1tUJd87WPvmpX9SYN555EyPsmzaYe3QkGnDk8w4+ EwXOdCsLIUd1UCido9ZbzovYIjQayTa1N9vwezI+cvSFPFWtZDLPx605bA0adsy80370 8SGri3VQ0tAdzkKFtYNGkiyVgRezb6QTtCYn7QSOmOMmgTpIesgZgSFxe2TbGricmj4g ed6fb8FPXW2EnMBXZeqKvZaI/Ky64ooqKTeIE5s/l77eFJaACm3D/uor1A1nPfMHAiUN aLUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709570936; x=1710175736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNLrofK26lIEsZuiCmRsSvu92wvxeyXHsAzSraLT2rk=; b=iSStdujPmOvlvpT0jR3sniLB5Ucu5rpzWSZaAXzBsdd/cplB4ao4CsQCLHkZKnDRmz 3oRtNJspRSk4pu8xNENNEqRbGSmdJ8cvdGpgmszS8wkiAF6qhLWILpTp+o6p/jzrlSYe fBNgVmeJqfV3IWql8Fdacbf1WQllmtRNaIXai178MeSKsAA7iDZSKEib/Y299F8c6R23 i/VszX940ImljcT27E/VI0ajmzRuRiAc0T1IzAIxYHsGhE3AtWTfYqi0pxRdC29G0y3z iHfiFQn9xyHa4UPqPR5FdVoZNNljMIPn2UePk8aKV4tb/X58+pd/6vcMhyGoBki5D/Pa GeHQ== X-Gm-Message-State: AOJu0YwS8lusDfm6aL5P5oNZtu3Lwwkr9uDqDwBG1tX6m0Fk7LHn2oPd aC+EuPbUXVy3VVpiddSGftxgPM5ui8oqn/mtmcF9YU71MjXyhmfovlO3p/w3 X-Google-Smtp-Source: AGHT+IEICwi3R4MVA9CYcch3PdMPWuk5EXeOG4VlwQH15r8w9TbrXXGXiAdPTigwj1KSgK5dIx5dtQ== X-Received: by 2002:a0c:bf09:0:b0:68f:6f92:d291 with SMTP id m9-20020a0cbf09000000b0068f6f92d291mr10356457qvi.4.1709570935946; Mon, 04 Mar 2024 08:48:55 -0800 (PST) Received: from LOCLAP699.rst-02.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id qq1-20020a0562142c0100b0068fdc55ec7dsm3858466qvb.68.2024.03.04.08.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:48:55 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 3/5] files: remove unneeded initialization Date: Mon, 4 Mar 2024 08:48:44 -0800 Message-Id: <20240304164846.1783148-3-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240304164846.1783148-1-prestwoj@gmail.com> References: <20240304164846.1783148-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/fils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fils.c b/src/fils.c index f876e7e5..ff8c1d6c 100644 --- a/src/fils.c +++ b/src/fils.c @@ -489,7 +489,7 @@ static int fils_rx_associate(struct auth_proto *driver, const uint8_t *frame, bool sha384 = (fils->hs->akm_suite & (IE_RSN_AKM_SUITE_FILS_SHA384 | IE_RSN_AKM_SUITE_FT_OVER_FILS_SHA384)); uint8_t data[44]; - uint8_t *ptr = data; + uint8_t *ptr; if (assoc->status_code != 0) return L_CPU_TO_LE16(assoc->status_code); From patchwork Mon Mar 4 16:48:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13580913 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4520B4D59E for ; Mon, 4 Mar 2024 16:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570939; cv=none; b=fv2Dw5/CsqqShRHS6dTi7j1ePtOLKgdPrqj4k0dXAZew1s8bN1SjG4YwFtSmQG8bXA/BOdkW3kRc11K6ec+8l7dAl5w40+Ntlw3BlWMLlIbaHLsd64vCR6dqrtZGh4OS+YVzAmx7reLzy/DqALjUFtAqkny8bGxqbnbctzHEKG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570939; c=relaxed/simple; bh=VEvOBUqruPw2DvsnsRYoLXSnsIfFLZ8Br9zg6mTJQ14=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HS/vXNIbyih1UAF4BqsAKNS8ETO8fBAJ+FyK8o9jRFPcCvHmNgtxXogZdUHBUoJwwejV5UYyWkN1JeI1Krr4vShpIzTWxmc2tCuJ8zoCLC1GAMj1UxglNd3eUTxUXe3sQrpElrVh7rTbnfQc9SmtUyHkR5NAj+6qthfUS5naQW0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V96z5vh7; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V96z5vh7" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6901a6dca63so31106846d6.0 for ; Mon, 04 Mar 2024 08:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709570937; x=1710175737; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7MMpzS9Ww4qrITHPPtRCX4gVxqp3MLaYXAD2gO4wlBo=; b=V96z5vh79OySioxsbzxQYKNjBmpJazso6JHMDO5EhYtYY0dy0nghrxZTG4eoi30z5M DFsht8+p0DlNXktmS5aOgZtK5vhbv/mgOBct9xHFC8fKmkYl/ITT4yP1197qXAMEY4ql HoOt0Ceuv5gWf7MaHMwKdCggKeG3ABmXFXApnWB92ycs2iI94dogut8P2PJuokvWWLhl CIz0XwJZIq9VAYlNlQfNH9Enf3PRaaCEckIpYuEov00g5MTRr1QzY/CUj+L9lb69cFhu QI2MWcQhOhAzp3mpkZFyz7VmJkxLz5qgoZIYNyFRvh9X3YA2n4FIYOsWAsPEiIGABr8G gkXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709570937; x=1710175737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7MMpzS9Ww4qrITHPPtRCX4gVxqp3MLaYXAD2gO4wlBo=; b=qlrQF3ZoF/ZDKzNZEayjFiQtz2ba5yWzFP51E/iOyphFyy79nFB1i5wkEYdKREwKDX zK0nQS3I7vc/byitdV1DYGiJm1OCLlY05WAajzbgCmkwySaEO7iYlNjIgpbr8UzElBYP lhACwlw1KYDg/JyBGxF4cMsqMxt12p3w3uPvM2TwSKGb+777fVm9GWEZAqKGamV0rIRj LwquhwPXAiDPrDwLW1gplovAtLYtiT3uPe+alM/sLWi0edHVFAbZxg2QyXuSlypqSJyg 4+JAYLlWchKZSyu0wncEImAFclm1AHbO0Wqh7lukgNXu+sAIVtMyo13NBZnmyQrgnSE1 dgCA== X-Gm-Message-State: AOJu0YzZ1nOx/s0iYWHtVB9xjMBs4tbyyIa2W7WGR4jkdhrpZ2UFC3H6 lhlfEl/OvzdLSOokII++Md1wWSnO6/1bmTe0sZ5PrioPkUbJEgYsrgcHJ6bq X-Google-Smtp-Source: AGHT+IHxSbfY6jzeZG4nU2I8Xk0XV0npsK5qJC4VD/IxWSfOhhtZmAbNnOrCbDfDVcPc78C1HQOQ1A== X-Received: by 2002:a0c:d60c:0:b0:690:4947:c2d6 with SMTP id c12-20020a0cd60c000000b006904947c2d6mr10116413qvj.47.1709570937000; Mon, 04 Mar 2024 08:48:57 -0800 (PST) Received: from LOCLAP699.rst-02.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id qq1-20020a0562142c0100b0068fdc55ec7dsm3858466qvb.68.2024.03.04.08.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:48:56 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 4/5] eap-mschapv2: remove unneeded initialization Date: Mon, 4 Mar 2024 08:48:45 -0800 Message-Id: <20240304164846.1783148-4-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240304164846.1783148-1-prestwoj@gmail.com> References: <20240304164846.1783148-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/eap-mschapv2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/eap-mschapv2.c b/src/eap-mschapv2.c index 7f71cc82..1639f578 100644 --- a/src/eap-mschapv2.c +++ b/src/eap-mschapv2.c @@ -445,7 +445,6 @@ static int eap_mschapv2_check_settings(struct l_settings *settings, if (!identity) { secret = l_queue_find(secrets, eap_secret_info_match, setting); if (secret) { - identity = l_strdup(secret->value); password = l_strdup(secret->value + strlen(secret->value) + 1); From patchwork Mon Mar 4 16:48:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Prestwood X-Patchwork-Id: 13580914 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C23D1E487 for ; Mon, 4 Mar 2024 16:48:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570940; cv=none; b=X9V2L30gDYUewuOlumXCJQC9BCvyA+D7nGNfsWeukaOnJ4xeNGMXpob7PcVUeAXJnAjO7Dni4ioIAruzH8qUrBiu/tM6/ErauGXveRqb68XRoU2GjxxFyPOh6rb8Lx/jfxLX+R1CtpIba2YHFQIgyGefelkCIHdtmKbrwIaxq4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570940; c=relaxed/simple; bh=z2Gg3/01yO10btu0wXhGJepCAFdiYgl6D83ut+VGLno=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ssFuMC/PwDvMAxAgfkTy7+0mPEu5ew76sGReE4FHF43u9ty1Z/u3EvdjA4SkcuPonOAQinBOX3iMwc7UjUIit9QEd//lVDkn9Q2NiVoHvkqpJ0uavWjL+rssYSGb1Dz82Td62Y+NneM5Y5dIbN4L4FouwPWCCEkBEFl0YrwWg1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ARKEthsO; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ARKEthsO" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6900f479e3cso51392956d6.0 for ; Mon, 04 Mar 2024 08:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709570938; x=1710175738; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kg4GLwXGvC4XTbfcRqXTaEr5hWMmSsjASYeBFKRX6Do=; b=ARKEthsOrwOjIpvttdI6dxa9Z7vtaHF/v1GYOGc0xlulByPB+OZQzOst55+WodrzZ7 xEJ1caVBFiKFgmh5EMWAWjgk1B2sHGyFEZG+VuDia5gjpFRPnuNa9tGi3sa04Pwy7Cg4 4nLcyJWDR/JGq4O59ejNQUV606piQu9sQrRNREYQxxjbbMq43F9WYs8TcF3rii1Hdlea qHYj+Hm8QFH+Dll580w6D6bOXDNFjkdj7ytCNOc1oELlKy1V4h7IRnvzxeoJvXCOR8I+ TT+pCPlGAkiPxs2nrfKA5u185BL5m11yhjBo0oi88MRZqqLuvG1hRjtq4xX/bvIDj6Nx u2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709570938; x=1710175738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kg4GLwXGvC4XTbfcRqXTaEr5hWMmSsjASYeBFKRX6Do=; b=Q3hIFriitRrT9aa/R7vq2KJcFVGNxVWOcbToWu+d+Rlj0GPGcYtVzo7gn4VP0aeUx9 61MyrpO40UThf9meKE6TYDhDHra/9kGY3IzW5fBeQYYy6QkNaHZ0+UCBf8XhDR/2vfFS j2N3xiQytsw9kiDSbQEcRXdd56SOeOtKy44EMsgvYEKyfAL3A6+sha5gH2KYXbsw/geQ FlJ51axz70EYTYJZQCYYkJ2XTtGUXTKij1KiQwEoMfcZj6scFrCSU5eZCWlEO1Fq64+x HhNs4WyLM0I2ubi09eom7fmLZdcotsAdAhXHANTvoYdBUW6Ms1p074mYyZ15z+nwlSpb Zb3w== X-Gm-Message-State: AOJu0YwbqsSxB5HgVJzC8jCxQpKaz07PxDldsOrC5ZbCGcKhpMAX8EIC tEsfcE5M18k6b3+bEL4NsvQHI07qlg/c+O08IHgPxyPp6ddresAN5vfRKLjH X-Google-Smtp-Source: AGHT+IHatfjV3QalIJy4sBl4wFf72ZTHOx5a9lkZ4JkYlsaiE1fFF/cv8EhJsnqGcSz7PzzF2QeXSA== X-Received: by 2002:a05:6214:4a4a:b0:690:50af:f5a1 with SMTP id ph10-20020a0562144a4a00b0069050aff5a1mr9741986qvb.27.1709570938010; Mon, 04 Mar 2024 08:48:58 -0800 (PST) Received: from LOCLAP699.rst-02.locus ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id qq1-20020a0562142c0100b0068fdc55ec7dsm3858466qvb.68.2024.03.04.08.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:48:57 -0800 (PST) From: James Prestwood To: iwd@lists.linux.dev Cc: James Prestwood Subject: [PATCH 5/5] dpp: check wrapped data exists in authenticate response Date: Mon, 4 Mar 2024 08:48:46 -0800 Message-Id: <20240304164846.1783148-5-prestwoj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240304164846.1783148-1-prestwoj@gmail.com> References: <20240304164846.1783148-1-prestwoj@gmail.com> Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- src/dpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dpp.c b/src/dpp.c index 74b4c2bc..567fe8d2 100644 --- a/src/dpp.c +++ b/src/dpp.c @@ -2368,7 +2368,7 @@ static void authenticate_response(struct dpp_sm *dpp, const uint8_t *from, } } - if (status != DPP_STATUS_OK || !r_boot_hash || !r_proto ) { + if (status != DPP_STATUS_OK || !r_boot_hash || !r_proto || !wrapped) { l_debug("Auth response bad status or missing attributes"); return; }