From patchwork Thu Feb 21 10:01:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 10823451 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E24101390 for ; Thu, 21 Feb 2019 10:01:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD16B301AD for ; Thu, 21 Feb 2019 10:01:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB06C3001B; Thu, 21 Feb 2019 10:01:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 47884304AB for ; Thu, 21 Feb 2019 10:01:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48771893C0; Thu, 21 Feb 2019 10:01:26 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12B308936E; Thu, 21 Feb 2019 10:01:23 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 15651074-1500050 for multiple; Thu, 21 Feb 2019 10:01:13 +0000 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Thu, 21 Feb 2019 10:01:07 +0000 Message-Id: <20190221100107.16789-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Not everyone actually has contexts X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Eek, I assumed the 'banned' subtest only applied to context platforms, ti doesn't. The basic test works for all, checking whether a second context works after the first is banned however only applies to platforms with contexts! Signed-off-by: Chris Wilson --- tests/i915/gem_eio.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c index c5fd07585..3f941071d 100644 --- a/tests/i915/gem_eio.c +++ b/tests/i915/gem_eio.c @@ -334,13 +334,13 @@ static void __test_banned(int fd) /* Only this context, not the file, should be banned */ igt_assert_neq(__gem_context_create(fd, &ctx), -EIO); - igt_assert_neq(ctx, 0); - - /* And check it actually works! */ - execbuf.rsvd1 = ctx; - gem_execbuf(fd, &execbuf); + if (ctx) { /* remember the contextless! */ + /* And check it actually works! */ + execbuf.rsvd1 = ctx; + gem_execbuf(fd, &execbuf); - gem_context_destroy(fd, ctx); + gem_context_destroy(fd, ctx); + } return; }