From patchwork Wed Mar 6 10:38:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13583852 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CB25FDDC for ; Wed, 6 Mar 2024 10:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721559; cv=none; b=ms/eFZKLj1LLEldG8/Ua1Oflg6xeQ9HMwKltHR+jDFRhz+P/nkMjfLU1dVygl6VAdOUhHf5NJW97xUHN/DDsBzUeSXAWM954xoa7xrf7uY/ToGXydLuxhMIEbxHNAmk/zXzyjpkJttbfTXrp3uE2juxfDF8gfvP+ZAbN73RXpEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721559; c=relaxed/simple; bh=vIc6TdPhXd1kX/avPbpFDWQrNdFePTX5Ajo4Bc1oq64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GHRiJsEIXYZcPDyz6/T340laqmgbMq+72M3SzBQLPwzjeYd+64ZTCdNPGErlK6R6Ykt3k/nXVSoJtq7Jr70Ae1CB7iZlRPB0VFz/vvItqfeAlRfh9ND63/4AnaNBSmMR7jfIS/upTG09/Rjxb5vJwVTZxnfF+EymG6245rej2nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhofu-0000m9-9m; Wed, 06 Mar 2024 11:39:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhoft-004jAh-Ii; Wed, 06 Mar 2024 11:39:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhoft-000d42-1a; Wed, 06 Mar 2024 11:39:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Turquette , Stephen Boyd Cc: Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] clk: imx: imx8-acm: Convert to platform remove callback returning void Date: Wed, 6 Mar 2024 11:38:55 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1805; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=vIc6TdPhXd1kX/avPbpFDWQrNdFePTX5Ajo4Bc1oq64=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl6EfAOvpBlrvFECH1JzFiP1N0VpY0xgRwInvbt Ky7mUAAf6CJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZehHwAAKCRCPgPtYfRL+ TvilB/9gBR815Rxi7A/nCY8oDjbfnbNuJ1Hbhr8cx9RgEV3Qeatz27NpWV2tdt16eDSM3zNz1/8 eXgoIm4WmUhLy5cKW9suL3QlFo7LBFsfbxEmcO1USVwadnEUxtjL45kng7KcvQKoelJm710VnMW NCXF1QUAIYK74Bj+EKGh3wWrXdX0i1kEKYCUKdKgYJKAKjdM4HmZMSMjJgpYqzSRUdUUL+7ylR2 5U13vuctxl50juoIb6HaGD9SfNGCzaIltGrM3NY0xzzW0aHvMGr4b8n1lgL5GqnHhTAzYfT8HTE WmhteIlvfeyffO3yugNZi0iuh8ApQwErO0/NygI3KoXncy7R X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/clk/imx/clk-imx8-acm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c index f68877eef873..1bdb480cc96c 100644 --- a/drivers/clk/imx/clk-imx8-acm.c +++ b/drivers/clk/imx/clk-imx8-acm.c @@ -394,15 +394,13 @@ static int imx8_acm_clk_probe(struct platform_device *pdev) return ret; } -static int imx8_acm_clk_remove(struct platform_device *pdev) +static void imx8_acm_clk_remove(struct platform_device *pdev) { struct imx8_acm_priv *priv = dev_get_drvdata(&pdev->dev); pm_runtime_disable(&pdev->dev); clk_imx_acm_detach_pm_domains(&pdev->dev, &priv->dev_pm); - - return 0; } static const struct imx8_acm_soc_data imx8qm_acm_data = { @@ -470,7 +468,7 @@ static struct platform_driver imx8_acm_clk_driver = { .pm = &imx8_acm_pm_ops, }, .probe = imx8_acm_clk_probe, - .remove = imx8_acm_clk_remove, + .remove_new = imx8_acm_clk_remove, }; module_platform_driver(imx8_acm_clk_driver); From patchwork Wed Mar 6 10:38:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13583853 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29745FDDC for ; Wed, 6 Mar 2024 10:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721561; cv=none; b=kqCoVdRYuhGPzRsNfjrasUdekw/8vFkrVts1le4raDhuI69coLudg2eC/bUslX4dxa6N8adotQqXZWvZiqV4hj9y7ixy5NJ+v9BCg41Xk1YVsc2tZiCrSHCzWjIGzZP+HYKnAf3UHjnW339kaEht2MeIk2o0im/p5+fOKuVUapU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721561; c=relaxed/simple; bh=3dfa49T7l/SF5Cv9Z/URZaYPBAyz7zkTwvP0cnLLOTc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R+DfsfvBLj/m5h2r2JHbQTx41wVVEqz7P+QDyLzCFjhYKe4g5lDqYn2jBG0seeyOx2VwSsUxMpXYI+Ao+6OAm58wV4OZ1uzToTtbodt//3WhKVkYmYotlnyUGzMjTf6Gf8c8j0K2H2y+xtMAksRVUnJbDQVm9SYMn0Bpz1+91jw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhofz-0000mm-RD; Wed, 06 Mar 2024 11:39:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhoft-004jAk-Ny; Wed, 06 Mar 2024 11:39:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhoft-000d47-27; Wed, 06 Mar 2024 11:39:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Turquette , Stephen Boyd Cc: Emil Renner Berthing , Hal Feng , linux-clk@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH 2/3] clk: starfive: jh7110-isp: Convert to platform remove callback returning void Date: Wed, 6 Mar 2024 11:38:56 +0100 Message-ID: <312ec7052c4e327c0b365e167a8e86b406cb7dfa.1709721042.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1860; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=3dfa49T7l/SF5Cv9Z/URZaYPBAyz7zkTwvP0cnLLOTc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl6EfBzDxtkqOLVTFV2lFqNC9g6s0GNlylfccvl vEDSsMMV+WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZehHwQAKCRCPgPtYfRL+ ThUCB/4k6opepzFimPswkLyiEaSLo6wdceKCNFbzDl5fBv3g0uFb34KvuwjLD3krGWKseLsJ+FV pVhX1w3ZdMU1BBhpm/C/LE9ZC+7HF0FSiF2kpI3Q9ZUfhH8NSXZ2VD0o8iamwkj45uvkyhuw+DU FDUPt44R1DM4L2rFFgK2yyET2GE/+KZOGyjop1Yy3flq1SjLTXhtniaOmpFwSZ/+3sZO+SYXzo6 DVJfCaKTb6caB3ZI6EtUKXZTg2qpL9anZ+kt5v9NZlDnVHHRPdEGnlFZktugxP4G4qczqk5e7Y5 gMxw7JBnbORpGPUt61T0jXQ+AqWTv2ZjLIFw4av/zcuhewX+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Hal Feng --- drivers/clk/starfive/clk-starfive-jh7110-isp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/starfive/clk-starfive-jh7110-isp.c b/drivers/clk/starfive/clk-starfive-jh7110-isp.c index 929b8788279e..d3c85421f948 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-isp.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-isp.c @@ -202,12 +202,10 @@ static int jh7110_ispcrg_probe(struct platform_device *pdev) return ret; } -static int jh7110_ispcrg_remove(struct platform_device *pdev) +static void jh7110_ispcrg_remove(struct platform_device *pdev) { pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id jh7110_ispcrg_match[] = { @@ -218,7 +216,7 @@ MODULE_DEVICE_TABLE(of, jh7110_ispcrg_match); static struct platform_driver jh7110_ispcrg_driver = { .probe = jh7110_ispcrg_probe, - .remove = jh7110_ispcrg_remove, + .remove_new = jh7110_ispcrg_remove, .driver = { .name = "clk-starfive-jh7110-isp", .of_match_table = jh7110_ispcrg_match, From patchwork Wed Mar 6 10:38:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13583854 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B933605A6 for ; Wed, 6 Mar 2024 10:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721561; cv=none; b=G8RqceWvjZPC2SGXrzwZiLQ/9auh6YCiNw8MyZPnJvkQOjjDzTnJh53Yer70bCDq1TN5RULGFmD1iPCDbfLA/3X1TLKT6Sr6aBqmPV/MmeNf8knuQVBXtLsqugl25mCtJGnKS4WKwibmqIGIoq3QBJvWlsyYo0Pco799UQ1+dd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709721561; c=relaxed/simple; bh=Qnrjahv5xmhVg8n/jVKNRCAVuhxoW//KNtqg8n0T+zc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gKhjrM2UZBWihAOwhIWyA3SWBiZ1olrzC5Ohf7Z+eRrMD28SrK6cF1wrWAFb3CPBS6R8oK4sjAE9keIdlHxafeD1YUVTuMDy/Th4IWkTK3ArwdWetvk9QRYHKia2dK5xmZOUi+HmnVvBx9kopYtVsKeL1VVaIt0ebPLKB+qDhDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhofz-0000mn-RC; Wed, 06 Mar 2024 11:39:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhoft-004jAn-T6; Wed, 06 Mar 2024 11:39:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhoft-000d4B-2e; Wed, 06 Mar 2024 11:39:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Turquette , Stephen Boyd Cc: Emil Renner Berthing , Hal Feng , linux-clk@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH 3/3] clk: starfive: jh7110-vout: Convert to platform remove callback returning void Date: Wed, 6 Mar 2024 11:38:57 +0100 Message-ID: <90054b8b2e118bc04ec37e044d0ac518bb177cf4.1709721042.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1876; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Qnrjahv5xmhVg8n/jVKNRCAVuhxoW//KNtqg8n0T+zc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl6EfCuqqQ5M5EsjPFrmLCliz15fMDBSgIAs5f6 X5kA5gE16yJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZehHwgAKCRCPgPtYfRL+ ThbcB/43VLahv6W4Ck6Zqw1jwc667mfinoZG2swiGLkyyTGKLe4ZtnoBm8c9cMUNCDahVz5zo5c o2abaQo7Z4kPPY2wtd+L8lt3rCc52sx+KuQ3jtNWJex5GST3QlQJgiuFFTyYaFwOYYKBXXfaasu Cd5B7ikMEPUB+CT4HskfFJ648EcKbYircNhYZjeL7ByNN08NXCZZFnwUGgZ8wzM8sTYEYNFx/Kg 4lsvsdAbKUWysCQ2xDPxaXua3CNCdkuoTJ3SMi6zwnbpQbI8BbEItILLItmOzPRG+G4PrODyZQ3 u5cziQr0Wlo7MP6ZzgufY4cWqqgaRC+26qqEcGGVTrPrGp2o X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Hal Feng --- drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c index 10cc1ec43925..53f7af234cc2 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c @@ -209,12 +209,10 @@ static int jh7110_voutcrg_probe(struct platform_device *pdev) return ret; } -static int jh7110_voutcrg_remove(struct platform_device *pdev) +static void jh7110_voutcrg_remove(struct platform_device *pdev) { pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id jh7110_voutcrg_match[] = { @@ -225,7 +223,7 @@ MODULE_DEVICE_TABLE(of, jh7110_voutcrg_match); static struct platform_driver jh7110_voutcrg_driver = { .probe = jh7110_voutcrg_probe, - .remove = jh7110_voutcrg_remove, + .remove_new = jh7110_voutcrg_remove, .driver = { .name = "clk-starfive-jh7110-vout", .of_match_table = jh7110_voutcrg_match,