From patchwork Thu Feb 21 15:59:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10824279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 745CC139A for ; Thu, 21 Feb 2019 16:00:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60C6A31778 for ; Thu, 21 Feb 2019 16:00:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5236631781; Thu, 21 Feb 2019 16:00:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 03CCE31778 for ; Thu, 21 Feb 2019 16:00:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1799389755; Thu, 21 Feb 2019 16:00:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A15D89755 for ; Thu, 21 Feb 2019 15:59:58 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id m12so23558018edv.4 for ; Thu, 21 Feb 2019 07:59:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XR6ZBCWgK5wboQt0iQNXa8mMwBSvMUFgihwssVG9NGQ=; b=QqyHNy75dGwyotB+m6QQfKVWi76K2hReKVX9r1lG15Drn0mfh9ih0GqIgUrGasMcKM pHiDqSBCJQpSKQoTSkyEwd6NNbz651NmwTfMmiR8Lp2pmlGqgdT1J/xgBKhn/X8HyA9m /LXXI5wDtEBcHjY6iVEdIJETLbHwMCWh7QEXMrWMpcxKr0Fkz4iabrIs29LrnBZ6+1Sc VAFPRR2K4AsoF7+oQ6AW63nDho/BSfKrDIVWcs1Ph5FjuJcfqBuGgaA3EZSNbg5s0fXw rvQV770aY0XIoMmlhHBiSO0/8fMTtxmUxa2cPd6DmzFejGom5aEnkdDjhQBXRIHnhl6e N0aw== X-Gm-Message-State: AHQUAuaCV4rp0IBi+sahcnQKd73OEqKdaf8hEIkofDga682/tOIJsg3A T1rJHwGM+C3IJKGMYK7tB7rdi8zNFjU3Ng== X-Google-Smtp-Source: AHgI3IZuw0fRc5rZo+bNAEhk/0ngtKG8sWBPSl5ErLvb/cx9p2T2kwK2dERicKMnKHpLSsaOebCoMw== X-Received: by 2002:a17:906:68f:: with SMTP id u15mr27391171ejb.147.1550764796630; Thu, 21 Feb 2019 07:59:56 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id p30sm6488346edd.85.2019.02.21.07.59.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 07:59:55 -0800 (PST) From: Daniel Vetter To: DRI Development , LKML Subject: [PATCH] staging/vboxvideo: Another FIXME item Date: Thu, 21 Feb 2019 16:59:51 +0100 Message-Id: <20190221155951.19855-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XR6ZBCWgK5wboQt0iQNXa8mMwBSvMUFgihwssVG9NGQ=; b=FKi6+dNc9MA+1XPGc67AB3vw8XMAeDh1hPXxVNfV4PfLLEypi68wsXXGX403hXicyv Nbakar0SnJILgqEB7A/ScmOsY5h//IW65fSiLoE5iie1we+X+2BwBx1nkW9QQXPYpRCM exZhyDVaooCXagZgmOqKefblESTq/qceeVrCc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Liviu Dudau , Sam Ravnborg , Greg Kroah-Hartman , Hans de Goede Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Found while grepping around. Signed-off-by: Daniel Vetter Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Liviu Dudau Reviewed-by: Greg Kroah-Hartman --- drivers/staging/vboxvideo/vbox_irq.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c index 195484713365..89944134ea86 100644 --- a/drivers/staging/vboxvideo/vbox_irq.c +++ b/drivers/staging/vboxvideo/vbox_irq.c @@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox) validate_or_set_position_hints(vbox); drm_modeset_lock_all(dev); + /* + * FIXME: this needs to use drm_connector_list_iter and some real + * locking for the actual data it changes, not the deprecated + * drm_modeset_lock_all() shotgun approach. + */ list_for_each_entry(connector, &dev->mode_config.connector_list, head) { vbox_conn = to_vbox_connector(connector);