From patchwork Tue Aug 14 12:53:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 10566341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74E0D13B4 for ; Wed, 15 Aug 2018 07:29:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61B7429F80 for ; Wed, 15 Aug 2018 07:29:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55FCD29FCA; Wed, 15 Aug 2018 07:29:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D40E22A035 for ; Wed, 15 Aug 2018 07:29:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 654C16E314; Wed, 15 Aug 2018 07:29:41 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.perfora.net (mout.perfora.net [74.208.4.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47C2C6E25F for ; Tue, 14 Aug 2018 12:54:16 +0000 (UTC) Received: from localhost.localdomain.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPA (Nemesis) id 0M2exP-1g8Kho3fkL-00sRHh; Tue, 14 Aug 2018 14:54:02 +0200 From: Marcel Ziswiler To: linux-tegra@vger.kernel.org Subject: [PATCH v2] drm/tegra: hdmi: probe deferral error reporting Date: Tue, 14 Aug 2018 14:53:54 +0200 Message-Id: <20180814125355.29293-1-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.4 X-Provags-ID: V03:K1:UwypYPOkSU0UORiPmTcL3TdIbomB2VnM0EWl2QauHTjCx/xqNOj fjGZ3P6a8XUmrxpdZh+L3d9zrwRMszdqqIff2xACR3SENsbF8i7pIFhqTmKj3xFPFYXWPWe xhY+3obDVnV2RXpWNLix705YjIrIAnsCXFiaMqSxUM3uP+DifIyMUifUTwO8froxOQumn9y dqr68wGFLI3UuGyRcOuog== X-UI-Out-Filterresults: notjunk:1;V01:K0:yia1fQ2YtoY=:K36yW73Z3pTIBvX4JneVk0 EiGcAyntzNj3CqO/M0iLHqdVVcH1Wem/bemMG6TxogarGk14P5hEwcZKLph6tdg/q4I3Y5ndw Qlzoc0QiyXn3xzyMYROX/YqAoqr/OQ/0SY2prb4fne1O0Ng+M9Cxj9dSyIMa623ZHebwP4DHU JSUWwBW27vpffJ4uK1ca9kHmpOyBG8sZIHOxJnSuU6H2JVTfT3QTPXEON2lRObwACoM4Lsf6c 9XXub4z3homS37OoXXBXM+V2t8Day6/volrVAd4+fynyFMCUqjzzg+PzHoqQNc6/p0azd3vv6 Vtujj5jpCiNZFRSPWNoAvKVVx+vFi78gTSCiOF5UFAVJfYSy5HC17hQTvg2eya8xCeoLV/+bI BarqPBKTVNHjSe4r80r3uu+al7yivlm/eP/fniI4ScQcVXE3IybmGSTnh7StCBu2eWv5FoVIM rryLUwgMIBmW4FtzmdjXbFOFWHosx/v4KjHnAtf3ryxvAkxaw9bP4D12gxFtbByB9TNfevgVg p5j2ud29QyRtU38MnlXkG+CdJu14dS1Q9VzmNfpCSwlNydykNJnZQQ47rMRhAkDtYMzQPTtCD W8czntk52yOaAR9a+3Cn5A5A9kPQpkFLo/RncRsjgFMtIsanPd/NgJ6Z7QBvVv6Lm2eh/c0Od 39a6SzyE0XFEnBJJEJnCnxRJWZ3Ee7AgFblJEJI6xkwPVFn+N1HXe/jFAcwkQZl4BVpM= X-Mailman-Approved-At: Wed, 15 Aug 2018 07:29:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Ziswiler , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonathan Hunter , David Airlie , Thierry Reding MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Marcel Ziswiler Actually report the error code from devm_regulator_get() unless it is just a probe deferral. Signed-off-by: Marcel Ziswiler --- Changes in v2: - Silence probe deferral as suggested by Lucas. - Fix line over 80 characters as reported by checkpatch. drivers/gpu/drm/tegra/hdmi.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 0082468f703c..073d54b7225e 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1693,14 +1693,22 @@ static int tegra_hdmi_probe(struct platform_device *pdev) hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi"); if (IS_ERR(hdmi->hdmi)) { - dev_err(&pdev->dev, "failed to get HDMI regulator\n"); - return PTR_ERR(hdmi->hdmi); + err = PTR_ERR(hdmi->hdmi); + if (err != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", + err); + + return err; } hdmi->pll = devm_regulator_get(&pdev->dev, "pll"); if (IS_ERR(hdmi->pll)) { - dev_err(&pdev->dev, "failed to get PLL regulator\n"); - return PTR_ERR(hdmi->pll); + err = PTR_ERR(hdmi->pll); + if (err != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", + err); + + return err; } hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");