From patchwork Thu Feb 21 20:19:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Francis, David" X-Patchwork-Id: 10824723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15AD2180E for ; Thu, 21 Feb 2019 20:20:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0699332480 for ; Thu, 21 Feb 2019 20:20:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 04AFF324B3; Thu, 21 Feb 2019 20:20:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5829D3251D for ; Thu, 21 Feb 2019 20:20:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A081893D0; Thu, 21 Feb 2019 20:20:16 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690062.outbound.protection.outlook.com [40.107.69.62]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16DE78933E; Thu, 21 Feb 2019 20:20:09 +0000 (UTC) Received: from CY4PR12CA0035.namprd12.prod.outlook.com (2603:10b6:903:129::21) by BYAPR12MB2965.namprd12.prod.outlook.com (2603:10b6:a03:d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Thu, 21 Feb 2019 20:20:07 +0000 Received: from CO1NAM03FT023.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::201) by CY4PR12CA0035.outlook.office365.com (2603:10b6:903:129::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15 via Frontend Transport; Thu, 21 Feb 2019 20:20:07 +0000 Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXCHOV02.amd.com (165.204.84.17) by CO1NAM03FT023.mail.protection.outlook.com (10.152.80.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1643.13 via Frontend Transport; Thu, 21 Feb 2019 20:20:06 +0000 Received: from localhost.localdomain (10.180.168.240) by SATLEXCHOV02.amd.com (10.181.40.72) with Microsoft SMTP Server id 14.3.389.1; Thu, 21 Feb 2019 14:20:06 -0600 From: David Francis To: Date: Thu, 21 Feb 2019 15:19:59 -0500 Message-ID: <20190221202001.28430-2-David.Francis@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190221202001.28430-1-David.Francis@amd.com> References: <20190221202001.28430-1-David.Francis@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(39860400002)(136003)(2980300002)(428003)(189003)(199004)(105586002)(2351001)(305945005)(486006)(36756003)(72206003)(51416003)(48376002)(2906002)(47776003)(50466002)(106466001)(76176011)(6666004)(8936002)(68736007)(8676002)(81166006)(81156014)(356004)(11346002)(86362001)(126002)(26005)(478600001)(6916009)(77096007)(54906003)(186003)(49486002)(30864003)(2616005)(446003)(336012)(4326008)(476003)(1076003)(53936002)(316002)(5660300002)(16586007)(97736004)(50226002)(426003)(104016004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB2965; H:SATLEXCHOV02.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9819685-9bab-467c-8988-08d69839f89c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060); SRVR:BYAPR12MB2965; X-MS-TrafficTypeDiagnostic: BYAPR12MB2965: X-Microsoft-Exchange-Diagnostics: 1; BYAPR12MB2965; 20:5m5RSzQNx4obG0yLTzrAtUAC3U9sXSYfiLTuVgfmKjsQy6NeLp+L48FzpFpgCPB3rtLrDLfAWTjFZ8H/l3smrImMAY1sf18MdsmADUOtHY8adLnYXn6NAH6Pv/9BmkMR1Neq0m6lDxBXlZa+w13btpazaTRpJlMFQUX2dQJ1hGxF2OwUXil2zPMHn/la0hlD0+j7Cqo12jXXubr5Xn3jYFjOBAh3WYLqZu/qoO+GEaqdZFxbEAm+9BwUz4CgxqggK7bjM/IZAR2+hDxlXyXMs5nPdAkZoKRe6A/nMjMllUl7xzdstj8w4kUk1rufXC/bqPy3okQfCVJxXHddtzwJfr7LvirYjx3x7BmIU4mcV0k7ZeJuZ+NTkfwO38kpyo3c9jC94YrT32r2TMpIFDrX7Hp7MZirs8uNTWFJm3Y4c8Sm/LKlL4pk87rBG8Nhmhhqlhg9i82F2HOMAN9GIdmzlHdxwooM0hAi2g29LTCxr3oRQyg7IitZVessvrB/B45Y X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09555FB1AD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR12MB2965; 23:B1KF6lKO3kUOpKw0fQW12WLuM37CDv72NoWMKtltK?= x+l20pguZdE2N3QBimb9HU5jV/WsJ8BoB0JRXDKv5gC0hUr7yREss3PXbTODIzGTBRx5yxyBw17QMU/myGA1X8iMrAGRrkWfPGc4yjyaIfy/GT3pG4WD195HjmVaYjlDasNacKTPD17MDRmDYFuevP4dbas3BBa3lifjmAXQVMxGbXJj9XigM5+rB5CdPu39oMw0St4QE+JJKfyXzhx6jEI35F/db6w0eYZuXz9Ur3vztpWjL7Iff/Go9nBzx1UNtO/+VMBGjVkFJJVGw4th6DaWvxQ57zm5D91PxpB4XfL66zdYQI34CgK+AbEO+cjYMuq2hGd3qllQO5wZKs7/1DWsX8MODvvNsSl5eeJ0DgMP+RXY0c3S6MxvVxbHNZv8A61xHXF3TQiJvw1OUTVrl1FhbnwdVErlx17wOKA3oBx90yfr71A5oK+LlDjx4i76aQPOb6UhhGamsNCZWh3NSDqYX0KOmYphLIGU2G2BXQ6Yar2FFc6RKQsoEDownhhzKwkfxxTnZH8VSMceNUhYpCC3JWmrwcogvS7nphRfSpVYJhcY3YD88bKEVqVhkLjI5R37qLhJYl/YFq+zdH83DPynGxWXkmcOOO42QkWM2rP2Z3UN/FS8+8TybcFYgtgA11owT2SqjnpmY54AJ2Mde/78MbkE1Fbdtuuud0+bhyeFhzUpY14BdBbzWwJRgQiy6PoAM3GsK4Ndbs2Ipq5lcMynhLMK7VIpjCyHBBZ5X0dfwWKb30WSh20PJVVrIK9qzvKkkFdFPzOcNZxeSHGJn+gNjhI/3VAHqD1QK9KoB8f43j7VoQ50K6imQYvKmZQBqblIYiw6PgPis2ByRlZ93LJm5Cq8XZj0cmf48Ugu1uOPv0zuenYiD2Hu7G65B/Wf1BcISycI9oL9Z/z3ZLuW4VyH03I2ZDutMFoDZFRPgMBs6fhSZryZ33ghc87iCBOj1cI8cSxU0zeLB6jmVxhbMYsX/SdftFO37W/Q73qWHCHlq55sm65aMh88g7bdA3G3AHDVRskJ+HOwK2iGk6U5R8b2E67qJljSOkWaxwHSs7E1CU5C+/si66stPEHOehyXdCQ9f001ERdM+QWE+bh2O09mUWiii9fBEe6F8Z2nsuk1X37bLLK/aRf0G6r+0Hqw94= X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 7KA7bhCtKfPGJ5lSbj+438sBBfkEWagMLKnUIhyL+zFZ9HqmrMh6mdvbyXdHL4UWevU37de58W7mr2Zl7GLl92G3g5tANY/zTYKrDChWATf8Vy+fTDlRkEf7N6nVfhiiKY0XxwgChMAFDM6o5fYwrUdQc9nTC5uSoy6tlHOhXQwjdE2hpCMxgMRV55aVat3H3ccNXUttg6CO9Wr7DRK7bFSl6Mu793dmnpSWJbVYQphSSVNdBt9V/Yu9yj/Cw5mM6der269hB3OBXgF/CIDVqzftdDE9Cqufa1YUZ5o2tqM43QBEnlIDPC/JrcYXgKzYxPOoHbaV1l39cZs98p+vGOplDBknmkKNqwqF+doVU3UObNhHaK83p4bYn2zMXSc+IGUD0qGI6IoHS1ITMxO7hbeKnv4UA9YLPXiBI3Iki9I= X-Microsoft-Exchange-Diagnostics: 1; BYAPR12MB2965; 20:eqIgMd3KZqyb4nMlDl7dpX673nu0qxnqxbO3GETCmoXq7Yu4D0S4bmn31jGpih82m7g3sHqRrnATTJowp6hcAGFmEjkwdALVacxuWLy/Gq13ipL3knuQpwvOlFxlhPezimKlbuCNqLNxPTtUzqjc+fbTaYKtjObEvHEqPXAhQUuprjw+31F9J+6lkYNLv7uFv0a9I6OS5FOTfj7U0OFDiYjshW9bzBTL7QUusvuu965GHuPFYhZzRuiAzOb9fSwv X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2019 20:20:06.8207 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9819685-9bab-467c-8988-08d69839f89c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2965 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmxanRlWkXIHQDWjJdPcBhmzgqVF74izC6t71zTL2/A=; b=KzhUrBhnAVtpUgfLqU0aGKLuQ8yGlriBTbJuYgtV9ng6PGi/fu6OVWk7gLsi3uR9P3bd+J3vewKnTqc/1d0vz+hMh/9Dv23BEBLZxxEXIZTISPaJ5lkYLt7fkqNKfaIzL2rpsJqjhbUM6U+lza+l07zfM17M8RTWtTlKksRoybg= X-Mailman-Original-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=permerror action=none header.from=amd.com; Subject: [Intel-gfx] [PATCH v2 1/3] drm/i915: Move dsc rate params compute into drm X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, nikola.cornij@amd.com, harry.wentland@amd.com, David Francis Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The function intel_compute_rc_parameters is part of the dsc spec and is not driver-specific. Other drm drivers might like to use it. The function is not changed; just moved and renamed. Reviewed-by: Harry Wentland Signed-off-by: David Francis --- drivers/gpu/drm/drm_dsc.c | 135 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_vdsc.c | 125 +-------------------------- include/drm/drm_dsc.h | 1 + 3 files changed, 137 insertions(+), 124 deletions(-) diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c index bce99f95c1a3..b7f1903508a4 100644 --- a/drivers/gpu/drm/drm_dsc.c +++ b/drivers/gpu/drm/drm_dsc.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -244,3 +245,137 @@ void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, /* PPS 94 - 127 are O */ } EXPORT_SYMBOL(drm_dsc_pps_infoframe_pack); + +/** + * drm_dsc_compute_rc_parameters() - Write rate control + * parameters to the dsc configuration defined in + * &struct drm_dsc_config in accordance with the DSC 1.1 + * specification. Some configuration fields must be present + * beforehand. + * + * @vdsc_cfg: + * DSC Configuration data partially filled by driver + */ +int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg) +{ + unsigned long groups_per_line = 0; + unsigned long groups_total = 0; + unsigned long num_extra_mux_bits = 0; + unsigned long slice_bits = 0; + unsigned long hrd_delay = 0; + unsigned long final_scale = 0; + unsigned long rbs_min = 0; + + /* Number of groups used to code each line of a slice */ + groups_per_line = DIV_ROUND_UP(vdsc_cfg->slice_width, + DSC_RC_PIXELS_PER_GROUP); + + /* chunksize in Bytes */ + vdsc_cfg->slice_chunk_size = DIV_ROUND_UP(vdsc_cfg->slice_width * + vdsc_cfg->bits_per_pixel, + (8 * 16)); + + if (vdsc_cfg->convert_rgb) + num_extra_mux_bits = 3 * (vdsc_cfg->mux_word_size + + (4 * vdsc_cfg->bits_per_component + 4) + - 2); + else + num_extra_mux_bits = 3 * vdsc_cfg->mux_word_size + + (4 * vdsc_cfg->bits_per_component + 4) + + 2 * (4 * vdsc_cfg->bits_per_component) - 2; + /* Number of bits in one Slice */ + slice_bits = 8 * vdsc_cfg->slice_chunk_size * vdsc_cfg->slice_height; + + while ((num_extra_mux_bits > 0) && + ((slice_bits - num_extra_mux_bits) % vdsc_cfg->mux_word_size)) + num_extra_mux_bits--; + + if (groups_per_line < vdsc_cfg->initial_scale_value - 8) + vdsc_cfg->initial_scale_value = groups_per_line + 8; + + /* scale_decrement_interval calculation according to DSC spec 1.11 */ + if (vdsc_cfg->initial_scale_value > 8) + vdsc_cfg->scale_decrement_interval = groups_per_line / + (vdsc_cfg->initial_scale_value - 8); + else + vdsc_cfg->scale_decrement_interval = DSC_SCALE_DECREMENT_INTERVAL_MAX; + + vdsc_cfg->final_offset = vdsc_cfg->rc_model_size - + (vdsc_cfg->initial_xmit_delay * + vdsc_cfg->bits_per_pixel + 8) / 16 + num_extra_mux_bits; + + if (vdsc_cfg->final_offset >= vdsc_cfg->rc_model_size) { + DRM_DEBUG_KMS("FinalOfs < RcModelSze for this InitialXmitDelay\n"); + return -ERANGE; + } + + final_scale = (vdsc_cfg->rc_model_size * 8) / + (vdsc_cfg->rc_model_size - vdsc_cfg->final_offset); + if (vdsc_cfg->slice_height > 1) + /* + * NflBpgOffset is 16 bit value with 11 fractional bits + * hence we multiply by 2^11 for preserving the + * fractional part + */ + vdsc_cfg->nfl_bpg_offset = DIV_ROUND_UP((vdsc_cfg->first_line_bpg_offset << 11), + (vdsc_cfg->slice_height - 1)); + else + vdsc_cfg->nfl_bpg_offset = 0; + + /* 2^16 - 1 */ + if (vdsc_cfg->nfl_bpg_offset > 65535) { + DRM_DEBUG_KMS("NflBpgOffset is too large for this slice height\n"); + return -ERANGE; + } + + /* Number of groups used to code the entire slice */ + groups_total = groups_per_line * vdsc_cfg->slice_height; + + /* slice_bpg_offset is 16 bit value with 11 fractional bits */ + vdsc_cfg->slice_bpg_offset = DIV_ROUND_UP(((vdsc_cfg->rc_model_size - + vdsc_cfg->initial_offset + + num_extra_mux_bits) << 11), + groups_total); + + if (final_scale > 9) { + /* + * ScaleIncrementInterval = + * finaloffset/((NflBpgOffset + SliceBpgOffset)*8(finalscale - 1.125)) + * as (NflBpgOffset + SliceBpgOffset) has 11 bit fractional value, + * we need divide by 2^11 from pstDscCfg values + */ + vdsc_cfg->scale_increment_interval = + (vdsc_cfg->final_offset * (1 << 11)) / + ((vdsc_cfg->nfl_bpg_offset + + vdsc_cfg->slice_bpg_offset) * + (final_scale - 9)); + } else { + /* + * If finalScaleValue is less than or equal to 9, a value of 0 should + * be used to disable the scale increment at the end of the slice + */ + vdsc_cfg->scale_increment_interval = 0; + } + + if (vdsc_cfg->scale_increment_interval > 65535) { + DRM_DEBUG_KMS("ScaleIncrementInterval is large for slice height\n"); + return -ERANGE; + } + + /* + * DSC spec mentions that bits_per_pixel specifies the target + * bits/pixel (bpp) rate that is used by the encoder, + * in steps of 1/16 of a bit per pixel + */ + rbs_min = vdsc_cfg->rc_model_size - vdsc_cfg->initial_offset + + DIV_ROUND_UP(vdsc_cfg->initial_xmit_delay * + vdsc_cfg->bits_per_pixel, 16) + + groups_per_line * vdsc_cfg->first_line_bpg_offset; + + hrd_delay = DIV_ROUND_UP((rbs_min * 16), vdsc_cfg->bits_per_pixel); + vdsc_cfg->rc_bits = (hrd_delay * vdsc_cfg->bits_per_pixel) / 16; + vdsc_cfg->initial_dec_delay = hrd_delay - vdsc_cfg->initial_xmit_delay; + + return 0; +} +EXPORT_SYMBOL(drm_dsc_compute_rc_parameters); diff --git a/drivers/gpu/drm/i915/intel_vdsc.c b/drivers/gpu/drm/i915/intel_vdsc.c index 23abf03736e7..2d059ebc9bd0 100644 --- a/drivers/gpu/drm/i915/intel_vdsc.c +++ b/drivers/gpu/drm/i915/intel_vdsc.c @@ -317,129 +317,6 @@ static int get_column_index_for_rc_params(u8 bits_per_component) } } -static int intel_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg) -{ - unsigned long groups_per_line = 0; - unsigned long groups_total = 0; - unsigned long num_extra_mux_bits = 0; - unsigned long slice_bits = 0; - unsigned long hrd_delay = 0; - unsigned long final_scale = 0; - unsigned long rbs_min = 0; - - /* Number of groups used to code each line of a slice */ - groups_per_line = DIV_ROUND_UP(vdsc_cfg->slice_width, - DSC_RC_PIXELS_PER_GROUP); - - /* chunksize in Bytes */ - vdsc_cfg->slice_chunk_size = DIV_ROUND_UP(vdsc_cfg->slice_width * - vdsc_cfg->bits_per_pixel, - (8 * 16)); - - if (vdsc_cfg->convert_rgb) - num_extra_mux_bits = 3 * (vdsc_cfg->mux_word_size + - (4 * vdsc_cfg->bits_per_component + 4) - - 2); - else - num_extra_mux_bits = 3 * vdsc_cfg->mux_word_size + - (4 * vdsc_cfg->bits_per_component + 4) + - 2 * (4 * vdsc_cfg->bits_per_component) - 2; - /* Number of bits in one Slice */ - slice_bits = 8 * vdsc_cfg->slice_chunk_size * vdsc_cfg->slice_height; - - while ((num_extra_mux_bits > 0) && - ((slice_bits - num_extra_mux_bits) % vdsc_cfg->mux_word_size)) - num_extra_mux_bits--; - - if (groups_per_line < vdsc_cfg->initial_scale_value - 8) - vdsc_cfg->initial_scale_value = groups_per_line + 8; - - /* scale_decrement_interval calculation according to DSC spec 1.11 */ - if (vdsc_cfg->initial_scale_value > 8) - vdsc_cfg->scale_decrement_interval = groups_per_line / - (vdsc_cfg->initial_scale_value - 8); - else - vdsc_cfg->scale_decrement_interval = DSC_SCALE_DECREMENT_INTERVAL_MAX; - - vdsc_cfg->final_offset = vdsc_cfg->rc_model_size - - (vdsc_cfg->initial_xmit_delay * - vdsc_cfg->bits_per_pixel + 8) / 16 + num_extra_mux_bits; - - if (vdsc_cfg->final_offset >= vdsc_cfg->rc_model_size) { - DRM_DEBUG_KMS("FinalOfs < RcModelSze for this InitialXmitDelay\n"); - return -ERANGE; - } - - final_scale = (vdsc_cfg->rc_model_size * 8) / - (vdsc_cfg->rc_model_size - vdsc_cfg->final_offset); - if (vdsc_cfg->slice_height > 1) - /* - * NflBpgOffset is 16 bit value with 11 fractional bits - * hence we multiply by 2^11 for preserving the - * fractional part - */ - vdsc_cfg->nfl_bpg_offset = DIV_ROUND_UP((vdsc_cfg->first_line_bpg_offset << 11), - (vdsc_cfg->slice_height - 1)); - else - vdsc_cfg->nfl_bpg_offset = 0; - - /* 2^16 - 1 */ - if (vdsc_cfg->nfl_bpg_offset > 65535) { - DRM_DEBUG_KMS("NflBpgOffset is too large for this slice height\n"); - return -ERANGE; - } - - /* Number of groups used to code the entire slice */ - groups_total = groups_per_line * vdsc_cfg->slice_height; - - /* slice_bpg_offset is 16 bit value with 11 fractional bits */ - vdsc_cfg->slice_bpg_offset = DIV_ROUND_UP(((vdsc_cfg->rc_model_size - - vdsc_cfg->initial_offset + - num_extra_mux_bits) << 11), - groups_total); - - if (final_scale > 9) { - /* - * ScaleIncrementInterval = - * finaloffset/((NflBpgOffset + SliceBpgOffset)*8(finalscale - 1.125)) - * as (NflBpgOffset + SliceBpgOffset) has 11 bit fractional value, - * we need divide by 2^11 from pstDscCfg values - */ - vdsc_cfg->scale_increment_interval = - (vdsc_cfg->final_offset * (1 << 11)) / - ((vdsc_cfg->nfl_bpg_offset + - vdsc_cfg->slice_bpg_offset) * - (final_scale - 9)); - } else { - /* - * If finalScaleValue is less than or equal to 9, a value of 0 should - * be used to disable the scale increment at the end of the slice - */ - vdsc_cfg->scale_increment_interval = 0; - } - - if (vdsc_cfg->scale_increment_interval > 65535) { - DRM_DEBUG_KMS("ScaleIncrementInterval is large for slice height\n"); - return -ERANGE; - } - - /* - * DSC spec mentions that bits_per_pixel specifies the target - * bits/pixel (bpp) rate that is used by the encoder, - * in steps of 1/16 of a bit per pixel - */ - rbs_min = vdsc_cfg->rc_model_size - vdsc_cfg->initial_offset + - DIV_ROUND_UP(vdsc_cfg->initial_xmit_delay * - vdsc_cfg->bits_per_pixel, 16) + - groups_per_line * vdsc_cfg->first_line_bpg_offset; - - hrd_delay = DIV_ROUND_UP((rbs_min * 16), vdsc_cfg->bits_per_pixel); - vdsc_cfg->rc_bits = (hrd_delay * vdsc_cfg->bits_per_pixel) / 16; - vdsc_cfg->initial_dec_delay = hrd_delay - vdsc_cfg->initial_xmit_delay; - - return 0; -} - int intel_dp_compute_dsc_params(struct intel_dp *intel_dp, struct intel_crtc_state *pipe_config) { @@ -574,7 +451,7 @@ int intel_dp_compute_dsc_params(struct intel_dp *intel_dp, vdsc_cfg->initial_scale_value = (vdsc_cfg->rc_model_size << 3) / (vdsc_cfg->rc_model_size - vdsc_cfg->initial_offset); - return intel_compute_rc_parameters(vdsc_cfg); + return drm_dsc_compute_rc_parameters(vdsc_cfg); } enum intel_display_power_domain diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h index 9c26f083c70f..5a98b8dfdf43 100644 --- a/include/drm/drm_dsc.h +++ b/include/drm/drm_dsc.h @@ -604,5 +604,6 @@ struct drm_dsc_pps_infoframe { void drm_dsc_dp_pps_header_init(struct drm_dsc_pps_infoframe *pps_sdp); void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, const struct drm_dsc_config *dsc_cfg); +int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg); #endif /* _DRM_DSC_H_ */ From patchwork Thu Feb 21 20:20:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Francis, David" X-Patchwork-Id: 10824721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7314184E for ; Thu, 21 Feb 2019 20:20:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8EF232388 for ; Thu, 21 Feb 2019 20:20:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C904324B3; Thu, 21 Feb 2019 20:20:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3596D3248E for ; Thu, 21 Feb 2019 20:20:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1308893CD; Thu, 21 Feb 2019 20:20:14 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780050.outbound.protection.outlook.com [40.107.78.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9660E89359; Thu, 21 Feb 2019 20:20:12 +0000 (UTC) Received: from CY4PR12CA0047.namprd12.prod.outlook.com (2603:10b6:903:129::33) by MN2PR12MB2974.namprd12.prod.outlook.com (2603:10b6:208:c2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Thu, 21 Feb 2019 20:20:10 +0000 Received: from CO1NAM03FT023.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::202) by CY4PR12CA0047.outlook.office365.com (2603:10b6:903:129::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.16 via Frontend Transport; Thu, 21 Feb 2019 20:20:09 +0000 Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXCHOV02.amd.com (165.204.84.17) by CO1NAM03FT023.mail.protection.outlook.com (10.152.80.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1643.13 via Frontend Transport; Thu, 21 Feb 2019 20:20:09 +0000 Received: from localhost.localdomain (10.180.168.240) by SATLEXCHOV02.amd.com (10.181.40.72) with Microsoft SMTP Server id 14.3.389.1; Thu, 21 Feb 2019 14:20:07 -0600 From: David Francis To: Date: Thu, 21 Feb 2019 15:20:00 -0500 Message-ID: <20190221202001.28430-3-David.Francis@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190221202001.28430-1-David.Francis@amd.com> References: <20190221202001.28430-1-David.Francis@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(136003)(346002)(2980300002)(428003)(199004)(189003)(6916009)(5660300002)(68736007)(106466001)(105586002)(72206003)(54906003)(4326008)(97736004)(305945005)(47776003)(49486002)(2351001)(8936002)(1076003)(316002)(16586007)(50226002)(336012)(48376002)(426003)(186003)(8676002)(81156014)(50466002)(356004)(446003)(26005)(77096007)(81166006)(53936002)(478600001)(11346002)(104016004)(2616005)(126002)(476003)(6666004)(76176011)(2906002)(36756003)(51416003)(86362001)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR12MB2974; H:SATLEXCHOV02.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ce357ba-a054-4019-5ec1-08d69839fa3c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060); SRVR:MN2PR12MB2974; X-MS-TrafficTypeDiagnostic: MN2PR12MB2974: X-Microsoft-Exchange-Diagnostics: 1; MN2PR12MB2974; 20:Abz+kRtInXwdDG4smPYEMkKmDWj55ajwB57pYCDh9P4I31FIASFqP0QqHv+hwusYHmGfb6f8R4ZoShBnNoXH0jD4htld8Ko7Gly34ephugptTc8TetPCmU+0xKmiINBityUChqkx6DFisNxHqeO6soOI74Bba/DnmsZigFQH9RhvbRGnJimyxJDm9Y1TIsJI8M5kxqjKZXXIhxFeH2VeIycUDdc4M1SmR4evvA6DBSIvJodom461rC9Qaz0YMvGs9TDHEbvsi+I4MPgGywHbcugb9q4EpQFV46yIr5Y+s+0dh3Arsve6H39HfwWrD/iVa0jn0FAMK/Q8sE14D0dKPEUHSpboQvUe6p6yKYaoDyc+c9hxgRZ28l4rVxPSbCzaTKOmWdtFqTOQMukl1o2KLsw0Gcpnd5/acen3Iqug5xDWBh+hFbPpb6YiOegLR6hgcGKrwLjchBjJWmbCQ+do6xLsjtF2YahPPBNdUugJ/a+RGUdnSpplKB9SpVdthIx8 X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09555FB1AD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MN2PR12MB2974; 23:PW4IVwLeOMOo/2MGm6xwZzKxbZ32ufaHJzKM3w9lo?= HChfjYy00R46eQdeoV3ns40mSh/QbJ91tmxMIuEMNY3JMzgH0sCo22DTvvEzju59SRpnRvFEUGHom10V9A7ey4TbSRnZd2RAwTs+PKEpF4RaKRlk6kAw4FOE2gHaAMPCGHDdT11C6xSU3GaKihFea9khrCiUa19wEaYd8n1bs+N63Ua70WN5UoFALIms949SRdZo0+bUJ+sMv+yBbOZDu2hwizPBBIS4I2ayHU8g8T42nuVIl39daULT0N+Pgc62OXG342FV8DhxHBdU+UDOa5thyyXbAWiT4aA/TkkBDz8wvqurE+f3pZhyI+CXMg3ywyKBygCvy2crcOGC7xMmc4/yh3W9Km9HqIUOIaegH5LFK0sahEcqqovo1QWbZC5oF1Coqau+PO0ubgrfWrMVglNpVLNG2kh09X1h/JBqL0M+cKmB1b1s2n7QiLv+goru+k3Etxper9ZMfsSKtCBVqrWiGnxzAaEnJYniEwpROL9t2Twq7JjsVF4KiR8orRiwKjBu1RqzrqbVIT85B1zcVpkmdtfGP6//1CkrzOLxICK9C83vjE2M5s+nUvzbT46kUiFKoJoyfz077rSGHjqTff3WJTVhxMwXHgdaaFoBw24TZbsdxLbRrvCBd0u5GQHRPfBMR4F2OyXWyBrCOoVsznCYHQXGgk3XEwx4KNseN/v2WvgONGwvxGKQq9T5ctg2xbvYmjlsKWNd19j8hsVNXalr8087BNdwupBpwt1s10Yg0hvKucwIsea6/3aIxrqCfAImCBJbI4FgwYGUmUH4eZT5MIZ5znlybSqnAnEoRCEijU8NoY8UF2Lj3gJgnSoM0oTUJ+b5ehvmdzyZOaHnAaVhFPu6xkqG7OKr9/Mkm75BGskCZxpxll9uQ8LYR9kugXTRbYPzpqJ//txObOTbGuKw5pxui8xyUtC+V8KcPmc04QnoPULfyZe0XRGrn6dPsgvi5m1DOdHTmbZGYlyOoIpvCsI2MM+qOQ8mjwSdKIVWjCB4NmuSw1n22rP9g583Nd0OsIGxpAASVUTc06yxB+QvmyF5QeAxtOO8ihpAAjxEdDhMlLBzS1skA5QdDl1cgyhmh2t8Dq/skZykRCBl/XywMCVk0pL4DBRqZ2gtvHfxw== X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: erv7dlfbyiHBiUlbazZeaGqhIloPZyaiJJ2OqO8WsPpugbyZB4CYcuqZqaLgRj596X81uTtjIIg0vi91us43w53OWs4xhCopKy3pNsAYYRvPkhQ5uCYE/O8IU9xACPxutlx+wIuTsk9PzL4GO2qjyftknlIEqColiU1Qd4rwNEvwO82Z/8wfRc/X8NOvneP7jVeqSOOFEiR+cboO4WXb4zz3Wory31B4xaEcDtU3CVdWIsIOqDMqldyDT7E0xZwwZEF3/vIA5Nygdozwjf8V+cWbSu8vjuCzABy5TuN8VAZW3afofQlqQOfuZgY57BJbVlKozYJNQCNSFoKCOG0gBwiW9T2BG94rI6LzNv+LxwXfyFQEVBf+ci9VJl5hQuz0fra/drEDI4q4e5YBH8lh9SObC/k2r7opG0aUpGWKWlw= X-Microsoft-Exchange-Diagnostics: 1; MN2PR12MB2974; 20:cZubPXowPqbdxABOj8BSWjogpA/i1kPJ9235621uZJHT/th12CQYfmf3zkZj0JkuNb4+NmZ0R4SFXQPowENlj6O3rzLAFA97ZiFMIKW0YFYyegdVlllPK71smC9ROT6SYkLMs8TUSygfR3nACpHoQKYhXZRoiWRKMch1Aw41J1FlVdCu0L7I0ioJ8PbCw0Kt4N6NLnNR0vuokM6ZVOHfFrXdOE9RGIpCsMxB3MtojGnAn35MItLXYUB8x9EiHMZM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2019 20:20:09.6310 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce357ba-a054-4019-5ec1-08d69839fa3c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2974 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b94qTedU2KyA5pT4sp4ZOLc99UP8m1fG4tVQEyVV9kY=; b=HsaBAHK4fSP62dONDv16eTX2x7VuBUCHXGRslqjYTDAmEGLhBcgvaDSR++ZihsyEG/3REIwzzmqp7DuWaCFWfcnqIdfsGuoy57qYwDP9N/ZjbueH5VGp8X1IVP5ZeSvH3Li3Do8cs4F4RjlNga39LXRkAeTpqQtVUEBz2Vrv/wc= X-Mailman-Original-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=permerror action=none header.from=amd.com; Subject: [Intel-gfx] [PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, nikola.cornij@amd.com, harry.wentland@amd.com, David Francis Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Native 420 and 422 transfer modes are new in DSC1.2 In these modes, each two pixels of a slice are treated as one pixel, so the slice width is half as large (round down) for the purposes of calucating the groups per line and chunk size in bytes In native 422 mode, each pixel has four components, so the mux component of a group is larger by one additional mux word and one additional component Now that there is native 422 support, the configuration option previously called enable422 is renamed to simple_422 to avoid confusion Acked-by: Jani Nikula Reviewed-by: Manasi Navare Reviewed-by: Harry Wentland Signed-off-by: David Francis --- drivers/gpu/drm/drm_dsc.c | 33 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_vdsc.c | 4 ++-- include/drm/drm_dsc.h | 4 ++-- 3 files changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c index b7f1903508a4..d77570bf6ac4 100644 --- a/drivers/gpu/drm/drm_dsc.c +++ b/drivers/gpu/drm/drm_dsc.c @@ -95,7 +95,7 @@ void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, ((dsc_cfg->bits_per_pixel & DSC_PPS_BPP_HIGH_MASK) >> DSC_PPS_MSB_SHIFT) | dsc_cfg->vbr_enable << DSC_PPS_VBR_EN_SHIFT | - dsc_cfg->enable422 << DSC_PPS_SIMPLE422_SHIFT | + dsc_cfg->simple_422 << DSC_PPS_SIMPLE422_SHIFT | dsc_cfg->convert_rgb << DSC_PPS_CONVERT_RGB_SHIFT | dsc_cfg->block_pred_enable << DSC_PPS_BLOCK_PRED_EN_SHIFT; @@ -249,7 +249,7 @@ EXPORT_SYMBOL(drm_dsc_pps_infoframe_pack); /** * drm_dsc_compute_rc_parameters() - Write rate control * parameters to the dsc configuration defined in - * &struct drm_dsc_config in accordance with the DSC 1.1 + * &struct drm_dsc_config in accordance with the DSC 1.2 * specification. Some configuration fields must be present * beforehand. * @@ -266,19 +266,34 @@ int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg) unsigned long final_scale = 0; unsigned long rbs_min = 0; - /* Number of groups used to code each line of a slice */ - groups_per_line = DIV_ROUND_UP(vdsc_cfg->slice_width, - DSC_RC_PIXELS_PER_GROUP); + if (vdsc_cfg->native_420 || vdsc_cfg->native_422) { + /* Number of groups used to code each line of a slice */ + groups_per_line = DIV_ROUND_UP(vdsc_cfg->slice_width / 2, + DSC_RC_PIXELS_PER_GROUP); - /* chunksize in Bytes */ - vdsc_cfg->slice_chunk_size = DIV_ROUND_UP(vdsc_cfg->slice_width * - vdsc_cfg->bits_per_pixel, - (8 * 16)); + /* chunksize in Bytes */ + vdsc_cfg->slice_chunk_size = DIV_ROUND_UP(vdsc_cfg->slice_width / 2 * + vdsc_cfg->bits_per_pixel, + (8 * 16)); + } else { + /* Number of groups used to code each line of a slice */ + groups_per_line = DIV_ROUND_UP(vdsc_cfg->slice_width, + DSC_RC_PIXELS_PER_GROUP); + + /* chunksize in Bytes */ + vdsc_cfg->slice_chunk_size = DIV_ROUND_UP(vdsc_cfg->slice_width * + vdsc_cfg->bits_per_pixel, + (8 * 16)); + } if (vdsc_cfg->convert_rgb) num_extra_mux_bits = 3 * (vdsc_cfg->mux_word_size + (4 * vdsc_cfg->bits_per_component + 4) - 2); + else if (vdsc_cfg->native_422) + num_extra_mux_bits = 4 * vdsc_cfg->mux_word_size + + (4 * vdsc_cfg->bits_per_component + 4) + + 3 * (4 * vdsc_cfg->bits_per_component) - 2; else num_extra_mux_bits = 3 * vdsc_cfg->mux_word_size + (4 * vdsc_cfg->bits_per_component + 4) + diff --git a/drivers/gpu/drm/i915/intel_vdsc.c b/drivers/gpu/drm/i915/intel_vdsc.c index 2d059ebc9bd0..8c8d96157333 100644 --- a/drivers/gpu/drm/i915/intel_vdsc.c +++ b/drivers/gpu/drm/i915/intel_vdsc.c @@ -368,7 +368,7 @@ int intel_dp_compute_dsc_params(struct intel_dp *intel_dp, DSC_1_1_MAX_LINEBUF_DEPTH_BITS : line_buf_depth; /* Gen 11 does not support YCbCr */ - vdsc_cfg->enable422 = false; + vdsc_cfg->simple_422 = false; /* Gen 11 does not support VBR */ vdsc_cfg->vbr_enable = false; vdsc_cfg->block_pred_enable = @@ -495,7 +495,7 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder, pps_val |= DSC_BLOCK_PREDICTION; if (vdsc_cfg->convert_rgb) pps_val |= DSC_COLOR_SPACE_CONVERSION; - if (vdsc_cfg->enable422) + if (vdsc_cfg->simple_422) pps_val |= DSC_422_ENABLE; if (vdsc_cfg->vbr_enable) pps_val |= DSC_VBR_ENABLE; diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h index 5a98b8dfdf43..f26a89e1b68a 100644 --- a/include/drm/drm_dsc.h +++ b/include/drm/drm_dsc.h @@ -101,9 +101,9 @@ struct drm_dsc_config { */ u16 slice_height; /** - * @enable422: True for 4_2_2 sampling, false for 4_4_4 sampling + * @simple_422: True if simple 4_2_2 mode is enabled else False */ - bool enable422; + bool simple_422; /** * @pic_width: Width of the input display frame in pixels */ From patchwork Thu Feb 21 20:20:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Francis, David" X-Patchwork-Id: 10824725 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E80515AC for ; Thu, 21 Feb 2019 20:20:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D9A83245B for ; Thu, 21 Feb 2019 20:20:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BF6E32480; Thu, 21 Feb 2019 20:20:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 916D83245B for ; Thu, 21 Feb 2019 20:20:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FCC4893A7; Thu, 21 Feb 2019 20:20:17 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-eopbgr810057.outbound.protection.outlook.com [40.107.81.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id A274C89359; Thu, 21 Feb 2019 20:20:14 +0000 (UTC) Received: from CY4PR12CA0047.namprd12.prod.outlook.com (2603:10b6:903:129::33) by MN2PR12MB3472.namprd12.prod.outlook.com (2603:10b6:208:d2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Thu, 21 Feb 2019 20:20:11 +0000 Received: from CO1NAM03FT023.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::202) by CY4PR12CA0047.outlook.office365.com (2603:10b6:903:129::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.16 via Frontend Transport; Thu, 21 Feb 2019 20:20:11 +0000 Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXCHOV02.amd.com (165.204.84.17) by CO1NAM03FT023.mail.protection.outlook.com (10.152.80.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1643.13 via Frontend Transport; Thu, 21 Feb 2019 20:20:11 +0000 Received: from localhost.localdomain (10.180.168.240) by SATLEXCHOV02.amd.com (10.181.40.72) with Microsoft SMTP Server id 14.3.389.1; Thu, 21 Feb 2019 14:20:08 -0600 From: David Francis To: Date: Thu, 21 Feb 2019 15:20:01 -0500 Message-ID: <20190221202001.28430-4-David.Francis@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190221202001.28430-1-David.Francis@amd.com> References: <20190221202001.28430-1-David.Francis@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(346002)(39860400002)(136003)(376002)(396003)(2980300002)(428003)(189003)(199004)(104016004)(36756003)(68736007)(86362001)(106466001)(2351001)(105586002)(478600001)(356004)(72206003)(6666004)(49486002)(76176011)(51416003)(486006)(77096007)(426003)(476003)(186003)(305945005)(2616005)(2906002)(54906003)(47776003)(316002)(16586007)(4326008)(11346002)(446003)(14444005)(97736004)(126002)(26005)(336012)(5660300002)(50466002)(6916009)(8676002)(81156014)(48376002)(50226002)(53936002)(81166006)(30864003)(1076003)(8936002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR12MB3472; H:SATLEXCHOV02.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5269e9ce-7259-4229-44f3-08d69839fb23 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(2017052603328)(7153060); SRVR:MN2PR12MB3472; X-MS-TrafficTypeDiagnostic: MN2PR12MB3472: X-Microsoft-Exchange-Diagnostics: 1; MN2PR12MB3472; 20:8/mqO1gFGwThL5++FTofTskry8RiLNJE1VvJwp+q1ACMV4DKmzVIZbO40qsK/k+P6frAV9ffhovBivTulLQZ6uq1SpxSeMY0kHkzoclp5F3BXBbfbxSw1hV2oLY806Yj25pM1xNxa2h0pavFN5hOIKOeR241xCk5uX9AArZruhFAL25vVOUUK7PDSCM0SHVWGIBtcirkPGcpckROzWE/be35fpRn5RsPhZro2LGJP4C9tyoW1nPv3ihcpTvzIY/iq8tKftRjoi4hHNwPtyhlm5NHdZpAyCFNFEzD0DHumEPDrNxiDuJq4dg7e7Vc5xZoymdi+ZM0o0i+nXP6FR+AaQEsWP3MRtjRVGTqsbiGP5BvGK7VMo/xY29Al1rkpRqmfDvz4qx7qaXAwI4MPpNTTU/UiADpiLKG5Ubt5olpnwnqconJeIgkOyDme+aVklmS3MRVUtSR97CQ0PQwXlKY9yU3Ja9utx9LT0OF3cW9aH0S25D32UCjDbwyDtTY9Urr X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09555FB1AD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MN2PR12MB3472; 23:RjgwT83V0x4O5e4oAATVvP+dVE/ipy7mDUjrxqCYv?= KfS47xqaXT2mrLzLLpTr/m6gIUf02kDIylOa+RQEBvKrHXf/6BzAw5SOS+qd3VNVZ8RTq16+AbMCMeSlxRRNMCVngef0rZfYQRnAy4yreiSwRQy/TfEA0B6GGtXEzijEprhgbcRnimKpGnD2rTvssHguCI1LjNSlbVjPKjx4YMhQTewHrdmaXYYAcLj1tdt8DJXsVVPr+ohx1Ue5WRW4XGYpAozIfrOJOIxPZNpEkTPA4fnODuOqx22U70rD1Y9LMY+WJN5PI3gBbOVI6laIuL01bHIDfzAkWeajPnA5qsxCAIc6hherdXxrS6rB/ZXHqzaCiB+19SDm3HGTPSwKrH7irTdTv8YSe7fYYSQ8vHFMDX092W9zh+4bFXsdhqYAcBlBFYV8Jf30Bv18DgNC1s1VOUgrzJscl57eZ3i/GrIpumjz+LO1Yj0arTs9qhxsm9CbDiSAx/53nGIr/a60LHhCgDTkvmOuqbDabcnmX77Ro9QnVC8eEooGQsUcGTCpF7lWzWEGvTnfzRPDd0BbdzjvAxkBow5T5v6fkeyihKLsAY+9QaLiHqIZ4/dMP/mQHt8bAcq/aNP/2Z63L8t08+RqutaZISi0Xgx2eP76K4Sq1/Ig20ahxiEj7Jt8oPwtmW1EMk9WLpJQytzKQ0+HIKH6fDCFqvx1sPUvMnSGSzmnDsV42Sl/gvnXJfm4LjR0yYZTtkl7iDxgyJ+12Hj1OUnv5pcd80GljF1qASYr2GjAwftOWzaPZTHpjqCdnJE4guWkuroAWq9gsJQKPMFgVl4a70PPBaeZ0eBOsZcPI+XXO4zMguL/qYvNDTRrh/7khF/tcRAP+VR3Sn4g6zZGI7rWtpOD8EJU1gtPEcMCBor1vrxwq1gVGmKKmAwV2UA6HEiB0YU+U0m4ZdbyF9BaaLeI7vbAqLCDsDgsKl9T4HoHumGfP0vbpxC0QHSPA0YAKoKMQiWCXqrkM25J8cyO4b9iEAhkCPBaGhuDHmAKleTqtXDdJj0RVRqy8b88eFIvaZ5eixA7gdpDIFpCeO153pPlruW8u8h3gVQKHWZjElHqQFhyVryuFaMe0aR5VJjZ1Mjlra+ThtfHkeHz2orOZhw9rl4DLGW0AaqLLi0eRGFoPO2Ecp+yV6JCyq2MvD52VbZglnNtkFSTI9WOYFLN+YjpxxgH+IBLf13I7mkcB3B8bEay5mYB0FGi8i/O1vEhD0oERBPuCapxQ+BAgNCxNAic1ZXBUl7Y8pfeO7NLgoXPExwavkJYb4GWv70vYrqIrk= X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: ONMwiwqTVc/0KDYFcYhGNSo+O0CjUhictIREVwaQbfwFCbvnk9udzgZv2z49Mqg/k1O2dQ8DzL7ODtgjIfaF+fyrVhS7KyBHC8YyK2LrsGaX9EgWkgSIlUs0QFHjNERxBMYH3uUqeBl7c3yUy1sx533f6tg7xCeVSqsbfa5YKXs3DFUrDL8ixbL7Mkepp6gAED2n2uiD9PspkOev72hd2VgqDePVyeEupUQaRN9NCOBUaurBjswlXAJaSx+pCxN8Pq0OcJEIYlRH3dRp7SxOH7RvrmgKxVzbkX/kXn/4XQOIG6T9I58JXOXlUYgiMlDEIVOzeNdnLRx5dDXvtDN4F2kfjEdx7Ai9CJhSuwXE3j7MA5m505qcGZI7D9Crn0V6KTG45aezy6ZpPRSA+GJxQrHgWO+XK9toGaBkQAnNN0c= X-Microsoft-Exchange-Diagnostics: 1; MN2PR12MB3472; 20:sAhnpe1iY9EGZK893QbBEfuP8BCkMWX5ZcXEvqdzUAuSDOerCVBGg/CW0a1iQn08eg6Hmh4r2+GVDaVB4brmNHsiT56nDp7e+0QkBfYmTTLL/gFqgG/lcviBdsN+VcYdUkyRO6RjPoylLCZbxtjLD9ZoEeCzwrbHJ7SQCFAc2GhQ/Yb8bbF18rYzvFUe0cMql5EPJyc8AC5UaDNce0tEw2qnsw/VtGtoMHIW83C/OFjUi+fD3jZ+de0oTVb9ThtN X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2019 20:20:11.1232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5269e9ce-7259-4229-44f3-08d69839fb23 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3472 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IM/udZc0PqXkrtaDd8shAB9DaJ7Lkd+4OUxrIs9ukn4=; b=g7VlxWSlyewN45qOqw7JDeP0Gvf3RXc02pjGlGWqg/X3zm8WZ04pedQ+R4XA8EhVAkIktPaRq2bJdqxXGDba5+c7XLgN9rMTtgOiEUrI5br1AqqYhnVLb4y9wDsboA4UC1UiNIA0F9e6JwAP6UbYsCmS4kaTaEz7qUFoAq0WGHY= X-Mailman-Original-Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=permerror action=none header.from=amd.com; Subject: [Intel-gfx] [PATCH v2 3/3] drm/dsc: Split DSC PPS and SDP header initialisations X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, nikola.cornij@amd.com, harry.wentland@amd.com, David Francis Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The DP 1.4 spec defines the SDP header and SDP contents for a Picture Parameter Set (PPS) that must be sent in advance of DSC transmission to define the encoding characteristics. This was done in one struct, drm_dsc_pps_infoframe, which conatined the SDP header and PPS. Because the PPS is a property of DSC over any connector, not just DP, and because drm drivers may have their own SDP structs they wish to use, make the functions that initialise SDP and PPS headers take the components they operate on, not drm_dsc_pps_infoframe, Signed-off-by: David Francis Reviewed-by: Manasi Navare --- drivers/gpu/drm/drm_dsc.c | 117 +++++++++++++++--------------- drivers/gpu/drm/i915/intel_vdsc.c | 4 +- include/drm/drm_dsc.h | 4 +- 3 files changed, 62 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c index d77570bf6ac4..77f4e5ae4197 100644 --- a/drivers/gpu/drm/drm_dsc.c +++ b/drivers/gpu/drm/drm_dsc.c @@ -32,66 +32,65 @@ /** * drm_dsc_dp_pps_header_init() - Initializes the PPS Header * for DisplayPort as per the DP 1.4 spec. - * @pps_sdp: Secondary data packet for DSC Picture Parameter Set - * as defined in &struct drm_dsc_pps_infoframe + * @pps_header: Secondary data packet header for DSC Picture + * Parameter Set as defined in &struct dp_sdp_header * * DP 1.4 spec defines the secondary data packet for sending the * picture parameter infoframes from the source to the sink. - * This function populates the pps header defined in - * &struct drm_dsc_pps_infoframe as per the header bytes defined - * in &struct dp_sdp_header. + * This function populates the SDP header defined in + * &struct dp_sdp_header. */ -void drm_dsc_dp_pps_header_init(struct drm_dsc_pps_infoframe *pps_sdp) +void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header) { - memset(&pps_sdp->pps_header, 0, sizeof(pps_sdp->pps_header)); + memset(pps_header, 0, sizeof(*pps_header)); - pps_sdp->pps_header.HB1 = DP_SDP_PPS; - pps_sdp->pps_header.HB2 = DP_SDP_PPS_HEADER_PAYLOAD_BYTES_MINUS_1; + pps_header->HB1 = DP_SDP_PPS; + pps_header->HB2 = DP_SDP_PPS_HEADER_PAYLOAD_BYTES_MINUS_1; } EXPORT_SYMBOL(drm_dsc_dp_pps_header_init); /** - * drm_dsc_pps_infoframe_pack() - Populates the DSC PPS infoframe + * drm_dsc_pps_payload_pack() - Populates the DSC PPS * - * @pps_sdp: - * Secondary data packet for DSC Picture Parameter Set. This is defined - * by &struct drm_dsc_pps_infoframe + * @pps_payload: + * Bitwise struct for DSC Picture Parameter Set. This is defined + * by &struct drm_dsc_picture_parameter_set * @dsc_cfg: * DSC Configuration data filled by driver as defined by * &struct drm_dsc_config * - * DSC source device sends a secondary data packet filled with all the - * picture parameter set (PPS) information required by the sink to decode - * the compressed frame. Driver populates the dsC PPS infoframe using the DSC - * configuration parameters in the order expected by the DSC Display Sink - * device. For the DSC, the sink device expects the PPS payload in the big - * endian format for the fields that span more than 1 byte. + * DSC source device sends a picture parameter set (PPS) containing the + * information required by the sink to decode the compressed frame. Driver + * populates the DSC PPS struct using the DSC configuration parameters in + * the order expected by the DSC Display Sink device. For the DSC, the sink + * device expects the PPS payload in big endian format for fields + * that span more than 1 byte. */ -void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, +void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_payload, const struct drm_dsc_config *dsc_cfg) { int i; /* Protect against someone accidently changing struct size */ - BUILD_BUG_ON(sizeof(pps_sdp->pps_payload) != + BUILD_BUG_ON(sizeof(*pps_payload) != DP_SDP_PPS_HEADER_PAYLOAD_BYTES_MINUS_1 + 1); - memset(&pps_sdp->pps_payload, 0, sizeof(pps_sdp->pps_payload)); + memset(pps_payload, 0, sizeof(*pps_payload)); /* PPS 0 */ - pps_sdp->pps_payload.dsc_version = + pps_payload->dsc_version = dsc_cfg->dsc_version_minor | dsc_cfg->dsc_version_major << DSC_PPS_VERSION_MAJOR_SHIFT; /* PPS 1, 2 is 0 */ /* PPS 3 */ - pps_sdp->pps_payload.pps_3 = + pps_payload->pps_3 = dsc_cfg->line_buf_depth | dsc_cfg->bits_per_component << DSC_PPS_BPC_SHIFT; /* PPS 4 */ - pps_sdp->pps_payload.pps_4 = + pps_payload->pps_4 = ((dsc_cfg->bits_per_pixel & DSC_PPS_BPP_HIGH_MASK) >> DSC_PPS_MSB_SHIFT) | dsc_cfg->vbr_enable << DSC_PPS_VBR_EN_SHIFT | @@ -100,7 +99,7 @@ void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, dsc_cfg->block_pred_enable << DSC_PPS_BLOCK_PRED_EN_SHIFT; /* PPS 5 */ - pps_sdp->pps_payload.bits_per_pixel_low = + pps_payload->bits_per_pixel_low = (dsc_cfg->bits_per_pixel & DSC_PPS_LSB_MASK); /* @@ -111,103 +110,103 @@ void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, */ /* PPS 6, 7 */ - pps_sdp->pps_payload.pic_height = cpu_to_be16(dsc_cfg->pic_height); + pps_payload->pic_height = cpu_to_be16(dsc_cfg->pic_height); /* PPS 8, 9 */ - pps_sdp->pps_payload.pic_width = cpu_to_be16(dsc_cfg->pic_width); + pps_payload->pic_width = cpu_to_be16(dsc_cfg->pic_width); /* PPS 10, 11 */ - pps_sdp->pps_payload.slice_height = cpu_to_be16(dsc_cfg->slice_height); + pps_payload->slice_height = cpu_to_be16(dsc_cfg->slice_height); /* PPS 12, 13 */ - pps_sdp->pps_payload.slice_width = cpu_to_be16(dsc_cfg->slice_width); + pps_payload->slice_width = cpu_to_be16(dsc_cfg->slice_width); /* PPS 14, 15 */ - pps_sdp->pps_payload.chunk_size = cpu_to_be16(dsc_cfg->slice_chunk_size); + pps_payload->chunk_size = cpu_to_be16(dsc_cfg->slice_chunk_size); /* PPS 16 */ - pps_sdp->pps_payload.initial_xmit_delay_high = + pps_payload->initial_xmit_delay_high = ((dsc_cfg->initial_xmit_delay & DSC_PPS_INIT_XMIT_DELAY_HIGH_MASK) >> DSC_PPS_MSB_SHIFT); /* PPS 17 */ - pps_sdp->pps_payload.initial_xmit_delay_low = + pps_payload->initial_xmit_delay_low = (dsc_cfg->initial_xmit_delay & DSC_PPS_LSB_MASK); /* PPS 18, 19 */ - pps_sdp->pps_payload.initial_dec_delay = + pps_payload->initial_dec_delay = cpu_to_be16(dsc_cfg->initial_dec_delay); /* PPS 20 is 0 */ /* PPS 21 */ - pps_sdp->pps_payload.initial_scale_value = + pps_payload->initial_scale_value = dsc_cfg->initial_scale_value; /* PPS 22, 23 */ - pps_sdp->pps_payload.scale_increment_interval = + pps_payload->scale_increment_interval = cpu_to_be16(dsc_cfg->scale_increment_interval); /* PPS 24 */ - pps_sdp->pps_payload.scale_decrement_interval_high = + pps_payload->scale_decrement_interval_high = ((dsc_cfg->scale_decrement_interval & DSC_PPS_SCALE_DEC_INT_HIGH_MASK) >> DSC_PPS_MSB_SHIFT); /* PPS 25 */ - pps_sdp->pps_payload.scale_decrement_interval_low = + pps_payload->scale_decrement_interval_low = (dsc_cfg->scale_decrement_interval & DSC_PPS_LSB_MASK); /* PPS 26[7:0], PPS 27[7:5] RESERVED */ /* PPS 27 */ - pps_sdp->pps_payload.first_line_bpg_offset = + pps_payload->first_line_bpg_offset = dsc_cfg->first_line_bpg_offset; /* PPS 28, 29 */ - pps_sdp->pps_payload.nfl_bpg_offset = + pps_payload->nfl_bpg_offset = cpu_to_be16(dsc_cfg->nfl_bpg_offset); /* PPS 30, 31 */ - pps_sdp->pps_payload.slice_bpg_offset = + pps_payload->slice_bpg_offset = cpu_to_be16(dsc_cfg->slice_bpg_offset); /* PPS 32, 33 */ - pps_sdp->pps_payload.initial_offset = + pps_payload->initial_offset = cpu_to_be16(dsc_cfg->initial_offset); /* PPS 34, 35 */ - pps_sdp->pps_payload.final_offset = cpu_to_be16(dsc_cfg->final_offset); + pps_payload->final_offset = cpu_to_be16(dsc_cfg->final_offset); /* PPS 36 */ - pps_sdp->pps_payload.flatness_min_qp = dsc_cfg->flatness_min_qp; + pps_payload->flatness_min_qp = dsc_cfg->flatness_min_qp; /* PPS 37 */ - pps_sdp->pps_payload.flatness_max_qp = dsc_cfg->flatness_max_qp; + pps_payload->flatness_max_qp = dsc_cfg->flatness_max_qp; /* PPS 38, 39 */ - pps_sdp->pps_payload.rc_model_size = + pps_payload->rc_model_size = cpu_to_be16(DSC_RC_MODEL_SIZE_CONST); /* PPS 40 */ - pps_sdp->pps_payload.rc_edge_factor = DSC_RC_EDGE_FACTOR_CONST; + pps_payload->rc_edge_factor = DSC_RC_EDGE_FACTOR_CONST; /* PPS 41 */ - pps_sdp->pps_payload.rc_quant_incr_limit0 = + pps_payload->rc_quant_incr_limit0 = dsc_cfg->rc_quant_incr_limit0; /* PPS 42 */ - pps_sdp->pps_payload.rc_quant_incr_limit1 = + pps_payload->rc_quant_incr_limit1 = dsc_cfg->rc_quant_incr_limit1; /* PPS 43 */ - pps_sdp->pps_payload.rc_tgt_offset = DSC_RC_TGT_OFFSET_LO_CONST | + pps_payload->rc_tgt_offset = DSC_RC_TGT_OFFSET_LO_CONST | DSC_RC_TGT_OFFSET_HI_CONST << DSC_PPS_RC_TGT_OFFSET_HI_SHIFT; /* PPS 44 - 57 */ for (i = 0; i < DSC_NUM_BUF_RANGES - 1; i++) - pps_sdp->pps_payload.rc_buf_thresh[i] = + pps_payload->rc_buf_thresh[i] = dsc_cfg->rc_buf_thresh[i]; /* PPS 58 - 87 */ @@ -216,35 +215,35 @@ void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, * are as follows: Min_qp[15:11], max_qp[10:6], offset[5:0] */ for (i = 0; i < DSC_NUM_BUF_RANGES; i++) { - pps_sdp->pps_payload.rc_range_parameters[i] = + pps_payload->rc_range_parameters[i] = ((dsc_cfg->rc_range_params[i].range_min_qp << DSC_PPS_RC_RANGE_MINQP_SHIFT) | (dsc_cfg->rc_range_params[i].range_max_qp << DSC_PPS_RC_RANGE_MAXQP_SHIFT) | (dsc_cfg->rc_range_params[i].range_bpg_offset)); - pps_sdp->pps_payload.rc_range_parameters[i] = - cpu_to_be16(pps_sdp->pps_payload.rc_range_parameters[i]); + pps_payload->rc_range_parameters[i] = + cpu_to_be16(pps_payload->rc_range_parameters[i]); } /* PPS 88 */ - pps_sdp->pps_payload.native_422_420 = dsc_cfg->native_422 | + pps_payload->native_422_420 = dsc_cfg->native_422 | dsc_cfg->native_420 << DSC_PPS_NATIVE_420_SHIFT; /* PPS 89 */ - pps_sdp->pps_payload.second_line_bpg_offset = + pps_payload->second_line_bpg_offset = dsc_cfg->second_line_bpg_offset; /* PPS 90, 91 */ - pps_sdp->pps_payload.nsl_bpg_offset = + pps_payload->nsl_bpg_offset = cpu_to_be16(dsc_cfg->nsl_bpg_offset); /* PPS 92, 93 */ - pps_sdp->pps_payload.second_line_offset_adj = + pps_payload->second_line_offset_adj = cpu_to_be16(dsc_cfg->second_line_offset_adj); /* PPS 94 - 127 are O */ } -EXPORT_SYMBOL(drm_dsc_pps_infoframe_pack); +EXPORT_SYMBOL(drm_dsc_pps_payload_pack); /** * drm_dsc_compute_rc_parameters() - Write rate control diff --git a/drivers/gpu/drm/i915/intel_vdsc.c b/drivers/gpu/drm/i915/intel_vdsc.c index 8c8d96157333..3f9921ba4a76 100644 --- a/drivers/gpu/drm/i915/intel_vdsc.c +++ b/drivers/gpu/drm/i915/intel_vdsc.c @@ -881,10 +881,10 @@ static void intel_dp_write_dsc_pps_sdp(struct intel_encoder *encoder, struct drm_dsc_pps_infoframe dp_dsc_pps_sdp; /* Prepare DP SDP PPS header as per DP 1.4 spec, Table 2-123 */ - drm_dsc_dp_pps_header_init(&dp_dsc_pps_sdp); + drm_dsc_dp_pps_header_init(&dp_dsc_pps_sdp.pps_header); /* Fill the PPS payload bytes as per DSC spec 1.2 Table 4-1 */ - drm_dsc_pps_infoframe_pack(&dp_dsc_pps_sdp, vdsc_cfg); + drm_dsc_pps_payload_pack(&dp_dsc_pps_sdp.pps_payload, vdsc_cfg); intel_dig_port->write_infoframe(encoder, crtc_state, DP_SDP_PPS, &dp_dsc_pps_sdp, diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h index f26a89e1b68a..887954cbfc60 100644 --- a/include/drm/drm_dsc.h +++ b/include/drm/drm_dsc.h @@ -601,8 +601,8 @@ struct drm_dsc_pps_infoframe { struct drm_dsc_picture_parameter_set pps_payload; } __packed; -void drm_dsc_dp_pps_header_init(struct drm_dsc_pps_infoframe *pps_sdp); -void drm_dsc_pps_infoframe_pack(struct drm_dsc_pps_infoframe *pps_sdp, +void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header); +void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_sdp, const struct drm_dsc_config *dsc_cfg); int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg);