From patchwork Mon Mar 18 11:19:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13595272 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D716E3612C; Mon, 18 Mar 2024 11:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760805; cv=none; b=akRV5v3SSvHAIVoNKFS8NINnPh2jfd9eAu/v9la1h99blw2xU+iD55d8HrNiwgJ/EA7EatZKYu6jQtcK7MagbY1gZf9kI9B+ZecrNiiC8rduCqyfowIiO5s1utKPSkOvVJdMy+E19+oP7O00/BhiQfWeZcMWLWnLf6zrlNSBDPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760805; c=relaxed/simple; bh=jCMlUD363vKn0zpjdZVsYHL06TzEt3kc0rtURswgGdY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f/49qRn9JTHCLbh0dWZiyEYfOEdUKK8LFvHbSOOAK06qMMWPLsz//dGUu7og7TZWXWPaKdayRvKHklk/KKPawLg0yP/Fw6rymndzsnfYTNwVSLx+2WFKvcv5AdfIKjareu+04FjB0WdSb8XO8GT71go85FpSP1awB+1uiP++Ky4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=duIiUsqf; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="duIiUsqf" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-34173b6b985so623305f8f.1; Mon, 18 Mar 2024 04:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710760802; x=1711365602; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V3r3uArMSydiicjQk9mYV5YzMaVndZLKq/8gP3JJ/JE=; b=duIiUsqffiU6JuvsBKJvOCZIc/9HroEbQ1XF/12a0bhP+lOLHuwLw+71ohu8hw2EIg wYid4JBL97ArO21T2EmeozajvaD1iaboJLwvy2wloBm5jM/tNwNJ2MrMr45PsZLf3BnA Mbt0WN9rkhVReb0FzBS3wssHU9kkTappqPjKXl+GL5ZwIe04jvm13E7PGBctf6/MvMYs qtvvEFysYzeSAfPkbooC8TueP10qTepfkX7ckNk6OnFVuy/mpDfirE6oCzXwvkJNEfRU lz7tYtZ834eI1Y0E5V88oyZkxuyIum9Jp9K3HmqOwuN22jLP07lw6Srs5gzKjEvPHr06 vdCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710760802; x=1711365602; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V3r3uArMSydiicjQk9mYV5YzMaVndZLKq/8gP3JJ/JE=; b=BmiTL9Nvg5/R3m7iSWc6EmYr0F1vNMAy7pjiiqJ6kTWtIBmb3dK+siv9TqsFWMsaBX +nXV2YhbMwNKoK9y0ylB5boIUqer+r/dSU7hbCt8GB/4hgDGooOUcaS7IqzT0KJ7ZP86 EvUl3TPV0sf80fMEzA44VwZZH/YYoKBlj1Qqtxm3ppBRNd6oph0mrcHUbvUjLU3Vx7Kk ZyEkEOUC9mZwUOsSXJvqfCFGJHLsBdo8CwRTd0USx8vHl6LoJ7TPN6l7ehjK/4pqzOzf 0JwkegOwj6lwIzGNeufoGUJlZXnYVZKNOkt36rqtnQP4vP5MfmwHXjJGwNcYJGho1+B2 nLUg== X-Forwarded-Encrypted: i=1; AJvYcCWFHfATjncLO3IPvfS8rAfv7yjKi6Bam5DiSuup68Dw+2N6nJC/WzGG+qmybLbIoP55TfvLtskH0YfVTcMVtNuTwrqZwTsw8xfDQf+R+Jx1NvetMB+aTu4BVqYUDTo3IL9HAKFh4vkI X-Gm-Message-State: AOJu0Yyw0FOvsPHZS6kabc2WWGgcnX72wvJAp2FtDOOjFMSjlYmAQ10V OoKOLGSY2de59gGxASb5gGFMztzKkxwEjHaKe5FUALvzWaGeEEo3 X-Google-Smtp-Source: AGHT+IG88dAqHC3lFegUtZWffLsyW7CFuwEhcCai/p4DpoxNEGzGMi1dFtmwOT500PpQkK6ryoYWWA== X-Received: by 2002:a5d:468e:0:b0:33e:8b95:b350 with SMTP id u14-20020a5d468e000000b0033e8b95b350mr5808943wrq.7.1710760802241; Mon, 18 Mar 2024 04:20:02 -0700 (PDT) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id az1-20020adfe181000000b0033ed7181fd1sm6650421wrb.62.2024.03.18.04.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 04:20:01 -0700 (PDT) From: Gabor Juhos Date: Mon, 18 Mar 2024 12:19:55 +0100 Subject: [PATCH 1/5] clk: qcom: apss-ipq-pll: reuse Stromer reg offsets from 'clk_alpha_pll_regs' Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240318-apss-ipq-pll-cleanup-v1-1-52f795429d5d@gmail.com> References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> In-Reply-To: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> To: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.12.3 The register offset array defined locally for the CLK_ALPHA_PLL_TYPE_STROMER_PLUS is the same as the entry defined for CLK_ALPHA_PLL_TYPE_STROMER in the 'clk_alpha_pll_regs' array. To avoid code duplication, remove the local definition and use the global one instead. No functional changes. Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- Depends on the following patches: - "clk: qcom: apss-ipq-pll: use stromer ops for IPQ5018 to fix boot failure" Link: https://lore.kernel.org/r/20240315-apss-ipq-pll-ipq5018-hang-v2-1-6fe30ada2009@gmail.com - "clk: qcom: clk-alpha-pll: Stromer register cleanup" Link: https://lore.kernel.org/r/20240311-alpha-pll-stromer-cleanup-v1-0-f7c0c5607cca@gmail.com --- drivers/clk/qcom/apss-ipq-pll.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index dfffec2f06ae7..ed3e6405f99cb 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -24,17 +24,6 @@ static const u8 ipq_pll_offsets[][PLL_OFF_MAX_REGS] = { [PLL_OFF_TEST_CTL] = 0x30, [PLL_OFF_TEST_CTL_U] = 0x34, }, - [CLK_ALPHA_PLL_TYPE_STROMER_PLUS] = { - [PLL_OFF_L_VAL] = 0x08, - [PLL_OFF_ALPHA_VAL] = 0x10, - [PLL_OFF_ALPHA_VAL_U] = 0x14, - [PLL_OFF_USER_CTL] = 0x18, - [PLL_OFF_USER_CTL_U] = 0x1c, - [PLL_OFF_CONFIG_CTL] = 0x20, - [PLL_OFF_STATUS] = 0x28, - [PLL_OFF_TEST_CTL] = 0x30, - [PLL_OFF_TEST_CTL_U] = 0x34, - }, }; static struct clk_alpha_pll ipq_pll_huayra = { @@ -57,12 +46,7 @@ static struct clk_alpha_pll ipq_pll_huayra = { static struct clk_alpha_pll ipq_pll_stromer = { .offset = 0x0, - /* - * Reuse CLK_ALPHA_PLL_TYPE_STROMER_PLUS register offsets. - * Although this is a bit confusing, but the offset values - * are correct nevertheless. - */ - .regs = ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_STROMER_PLUS], + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER], .flags = SUPPORTS_DYNAMIC_UPDATE, .clkr = { .enable_reg = 0x0, @@ -80,7 +64,11 @@ static struct clk_alpha_pll ipq_pll_stromer = { static struct clk_alpha_pll ipq_pll_stromer_plus = { .offset = 0x0, - .regs = ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_STROMER_PLUS], + /* + * The register offsets of the Stromer Plus PLL used in IPQ5332 + * are the same as the Stromer PLL's offsets. + */ + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER], .flags = SUPPORTS_DYNAMIC_UPDATE, .clkr = { .enable_reg = 0x0, From patchwork Mon Mar 18 11:19:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13595273 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C78364BA; Mon, 18 Mar 2024 11:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760806; cv=none; b=nvLwDNY9XTrv63oYwg/noAS+4BETIR6hN5YPLpt3eO0xK50xEaf1EAWj8cmyt8/qnkgSGHeqPbi1Npn2br3qUJqIew1JrK9qo1QxhLCMYg9AFNQV7FxYRxMapmKa/F14JupSca/VuWinL807XlK8phjIrNKJAMEXrBr6uawgO6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760806; c=relaxed/simple; bh=O6HxZDdhxKhcpMpgS7Eo6/JYG3XMRSAnE9PVhV+ItNg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WnwZvJ/kGeOqAdx8zyfHGzA976Q5/p1w+tAa0jaboWVbaxQVkdVqADOam/Y/2dt3mgmEISzPpKLAr5FebtiiVR1UzlSUh8gCLhFey+4K+dkOTzI0mCK9GcXJgpHyLTaj9ECS6eEa5m8P2Wjxf1uzQvdA5OKMKKJQf9YEB0fwFwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j55I04ma; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j55I04ma" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-413f4cb646dso26382695e9.1; Mon, 18 Mar 2024 04:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710760803; x=1711365603; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VLFOLb3TX+tmTty9pVbOBLP2wGa5npaJQBpBbAbldYg=; b=j55I04maIfz5QyPcyZ+uNNa7LVzXNFhCU9I2mCGZV/38+LxMtOjELixkW+MlwnPSNf 2z3u5PktSKi/B51JjTgLSRPaxYYx/OnhfPg2PHLdcHgOZF7VyHPXDrqi9Hah0TkwOGH1 skVEfT/GmhPfRkhsUfnlCUovhU6FFJeVu0KpA8YcJbxFg4f8GjMEUib52h+xHxcFCUdc Ypj1Wz1CJXx2MAYdDbbDw9IbeXw1vgJI0bnipch+7IWQnfSYRYKXY+2ksqwxhSGj55WR KOCz3SgtcKrEIKivSvfg+ihb2xfWGL+DoeF8pU7N4ZH2a8XQ/nVcc9db3f3NQ6ANsjJx vAOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710760803; x=1711365603; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VLFOLb3TX+tmTty9pVbOBLP2wGa5npaJQBpBbAbldYg=; b=p6hgYjK+oxY9CjTH+Kqi5OBPoVEQqxVC8sUfbG17s+2vSP6W9CVRzKskQO42GE6/96 AuYDv2VEdGOT5l5rWjGAro0YRE33eg/HaB8U4LOfkk117oNLpUyWi699kwwc3SPOL+lE uybbQdMs/JDWoID/q2NsGFpBJkvMgoplKX2TzzaJHglJR68t+HPC4doTvZtqcinCt0F2 TYTMNlY66wdH6A13lYrwsRCXo6MX0S5Q8Ip92O7DLuxQcCUxgAFh3lq6aoFyzlSMVJa7 WLpt4F6f+TE47ncLfXez7p+kfyBaLOpVg/TIGNUxAZ+kEtoJCMvYESJlhCS1Ng6KOiJd ZylQ== X-Forwarded-Encrypted: i=1; AJvYcCX4CngivYw8IplKFzBiXdW2zNgbEQGxzMlTDG8R3jvkoe16ElU0VCuxLaZPDznk4Paelk19eqFbIOdjIiusNFpFB7QfnWDGmBCsFf4Ol9znlm01P9hW1iP1DOpHpu2VrSlJqO/VO6MK X-Gm-Message-State: AOJu0YxjgdvsA4vbs49s1YhjP6AQKzLejd2OHLhDlMAEv+wVPnc5p0un 4ojJJo+gcpFugH/2XWaYOdbIZQeKniFpDbU4ZuXaJSZ3tX3ll5AG X-Google-Smtp-Source: AGHT+IE60u97Ahd+O/QJ907yAAsdejUCQpurbXQ9rWkEcjmkTWP5TE+9NxXK8gl6H4wC2BUvYbKjXQ== X-Received: by 2002:adf:b184:0:b0:33e:96ba:2d48 with SMTP id q4-20020adfb184000000b0033e96ba2d48mr8533833wra.57.1710760803457; Mon, 18 Mar 2024 04:20:03 -0700 (PDT) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id az1-20020adfe181000000b0033ed7181fd1sm6650421wrb.62.2024.03.18.04.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 04:20:03 -0700 (PDT) From: Gabor Juhos Date: Mon, 18 Mar 2024 12:19:56 +0100 Subject: [PATCH 2/5] clk: qcom: apss-ipq-pll: use an 1-D array for Huayra pll register offsets Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240318-apss-ipq-pll-cleanup-v1-2-52f795429d5d@gmail.com> References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> In-Reply-To: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> To: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.12.3 The 'ipq_pll_offsets' is defined as a two-dimensional array, but it contains a sole element only so convert it to an one-dimensional array. Also, rename the variable to better reflect that it is used for the Huayra PLLs. No functional changes. Signed-off-by: Gabor Juhos --- drivers/clk/qcom/apss-ipq-pll.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index ed3e6405f99cb..f5c7eaf8db374 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -13,22 +13,20 @@ * are different from the one mentioned in the clk-alpha-pll.c, since the * PLL is specific to APSS, so lets the define the same. */ -static const u8 ipq_pll_offsets[][PLL_OFF_MAX_REGS] = { - [CLK_ALPHA_PLL_TYPE_HUAYRA] = { - [PLL_OFF_L_VAL] = 0x08, - [PLL_OFF_ALPHA_VAL] = 0x10, - [PLL_OFF_USER_CTL] = 0x18, - [PLL_OFF_CONFIG_CTL] = 0x20, - [PLL_OFF_CONFIG_CTL_U] = 0x24, - [PLL_OFF_STATUS] = 0x28, - [PLL_OFF_TEST_CTL] = 0x30, - [PLL_OFF_TEST_CTL_U] = 0x34, - }, +static const u8 ipq_pll_huayra_regs[PLL_OFF_MAX_REGS] = { + [PLL_OFF_L_VAL] = 0x08, + [PLL_OFF_ALPHA_VAL] = 0x10, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_CONFIG_CTL_U] = 0x24, + [PLL_OFF_STATUS] = 0x28, + [PLL_OFF_TEST_CTL] = 0x30, + [PLL_OFF_TEST_CTL_U] = 0x34, }; static struct clk_alpha_pll ipq_pll_huayra = { .offset = 0x0, - .regs = ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_HUAYRA], + .regs = ipq_pll_huayra_regs, .flags = SUPPORTS_DYNAMIC_UPDATE, .clkr = { .enable_reg = 0x0, From patchwork Mon Mar 18 11:19:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13595274 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8D137162; Mon, 18 Mar 2024 11:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760807; cv=none; b=TvHamWlrqXcAGPXzKKy6kPUgGdOPEJfvhlQM2zri7RJRgCVXpqZ3y93X7akzowQyVzURritHfCZnA0PaWE07Q390Ndn/en2I5YY00ow49mgArOgTNkciJ8vuvNdm7jXLkfO0lXXopGy+8e8dkO+eSdKRB0AR9hoUM48m8qSO+Yk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760807; c=relaxed/simple; bh=V5o57Z5lkXjFzPIoDm+QJbV84snZtFSjhMmyvJm0U+I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rbl9eEN/n+oc7hkNcYMR5t62GX+dxXYSMqG5AxKgzUVpHCeiZju4OppgE6qOX2nTP6D6BvYM2LqZizrs0XQD8/NJMVglp7YsGnnMczv2DP+A62cbRSs4Ob8IHGTbqwh6fAxigWku7OKyfM2L/lwNJ/gL/e/MIxejUpfJ3eFqqFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TD3LulJu; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TD3LulJu" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-33ed6078884so1379841f8f.1; Mon, 18 Mar 2024 04:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710760804; x=1711365604; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oOOkoScv5oPGpoZyfbHf5LnUoWuaxfdY11LbzZmpRD4=; b=TD3LulJun0Z1MnmmE6t4lF3WOZsZN795gAqMckoLFkbMLTvF2x5zV9SCE+WjK/yf0l pE/vggrIvwcjtdnIsa8g3mbxUU7PHE/mEgzqn+ci1tbf6voDNEl8Kz1UYvUOEPS+eNFg mTvoxm1urD9X0zmUfo2GQiM6fn+3lVVwlWEeFg/8ylgs6irCG3NUqp5ElErlrDUXulkV ZlM7T9podYFm6hBlX8pTYw5Eadtg3H78ZapbuQZOab6wD8aqYiHU3JfMxxskv2Br2WaR ovyovFW8Z8TqdDzsZN+bv33v0l5mNQBHZcpaHi/8D9IKoBmXLVntqXaaTjnYMX1kx4tO ifTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710760804; x=1711365604; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oOOkoScv5oPGpoZyfbHf5LnUoWuaxfdY11LbzZmpRD4=; b=ARA/Id+kj4nRpTFwThW4Gz4WNuEl9q0REvp49pTikkPbTiJBENGsFirqcpA/ml6Aph nboFCPIhbuSQfRutPH/xobPapYu+Dv5S3eHQUnFupuwANlAua7RHug//JQyT/XK0MwwK ys+TgB6EDeET8gD+DCN2yzEP2DTs+GEI+Rd8u3l71l48Qd9tdHpDDGqTHUdgsJSGny0v krvwBWd8vOQ9pc56KYQxLdHa9gL0cjqbsLckskLtzu9ShJpPFxFy0emyt124vZ3TEMiG Ye3P6P1yqBKHZZ1vpujuyagR2ZFa2LGspJT+uG3+SC6iKGl5BUetQJ3y/0oo66oa+WuL 9Z1g== X-Forwarded-Encrypted: i=1; AJvYcCVfTE6FQGb3VUTh1wqjyW65xYz9RRxWpHQ/L044MdIxqyKJtKdotbafdoTgolaTs/QI1K81Yn/iLeXmnL1Rb8whiNN9UqOK4xirDuZ4SjZa6noqKGqlMnelWgcidny/fjOB+fkJZMiA X-Gm-Message-State: AOJu0YyCTMykgfgw4wqq3JriakxlBwYigk0h6oOLUtXxgli9GHOE/3sE Iw/6t12KUxsFMoPQcTybAjycNYPzBXysAxJVCqVVru+2symODRkI X-Google-Smtp-Source: AGHT+IEyHElyuXDvojQ4vmy1EfZn7cim0AYIcSvMOovEKsxIxyP24FMUAVQ2jM84AAla9drSGE53Eg== X-Received: by 2002:a5d:5741:0:b0:341:6b9e:4ff2 with SMTP id q1-20020a5d5741000000b003416b9e4ff2mr3175809wrw.14.1710760804494; Mon, 18 Mar 2024 04:20:04 -0700 (PDT) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id az1-20020adfe181000000b0033ed7181fd1sm6650421wrb.62.2024.03.18.04.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 04:20:04 -0700 (PDT) From: Gabor Juhos Date: Mon, 18 Mar 2024 12:19:57 +0100 Subject: [PATCH 3/5] clk: qcom: apss-ipq-pll: remove 'pll_type' field from struct 'apss_pll_data' Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240318-apss-ipq-pll-cleanup-v1-3-52f795429d5d@gmail.com> References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> In-Reply-To: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> To: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.12.3 The value of the 'pll_type' field of 'struct apps_pll_data' is used only by the probe function to decide which config function should be called for the actual PLL. However this can be derived also from the 'pll' field which makes the 'pll_type' field redundant. Additionally, the CLK_ALPHA_PLL_TYPE_* enumeration values are meant to be used as indices to the 'clk_alpha_pll_regs' array so using those to define the pll type in this driver is misleading anyway. Change the probe function to use the 'pll' field to determine the configuration function to be used, and remove the 'pll_type' field to simplify the code. No functional changes. Signed-off-by: Gabor Juhos --- drivers/clk/qcom/apss-ipq-pll.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index f5c7eaf8db374..fb015385dae4b 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -147,37 +147,31 @@ static const struct alpha_pll_config ipq9574_pll_config = { }; struct apss_pll_data { - int pll_type; struct clk_alpha_pll *pll; const struct alpha_pll_config *pll_config; }; static const struct apss_pll_data ipq5018_pll_data = { - .pll_type = CLK_ALPHA_PLL_TYPE_STROMER, .pll = &ipq_pll_stromer, .pll_config = &ipq5018_pll_config, }; static struct apss_pll_data ipq5332_pll_data = { - .pll_type = CLK_ALPHA_PLL_TYPE_STROMER_PLUS, .pll = &ipq_pll_stromer_plus, .pll_config = &ipq5332_pll_config, }; static struct apss_pll_data ipq8074_pll_data = { - .pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA, .pll = &ipq_pll_huayra, .pll_config = &ipq8074_pll_config, }; static struct apss_pll_data ipq6018_pll_data = { - .pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA, .pll = &ipq_pll_huayra, .pll_config = &ipq6018_pll_config, }; static struct apss_pll_data ipq9574_pll_data = { - .pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA, .pll = &ipq_pll_huayra, .pll_config = &ipq9574_pll_config, }; @@ -210,10 +204,10 @@ static int apss_ipq_pll_probe(struct platform_device *pdev) if (!data) return -ENODEV; - if (data->pll_type == CLK_ALPHA_PLL_TYPE_HUAYRA) + if (data->pll == &ipq_pll_huayra) clk_alpha_pll_configure(data->pll, regmap, data->pll_config); - else if (data->pll_type == CLK_ALPHA_PLL_TYPE_STROMER || - data->pll_type == CLK_ALPHA_PLL_TYPE_STROMER_PLUS) + else if (data->pll == &ipq_pll_stromer || + data->pll == &ipq_pll_stromer_plus) clk_stromer_pll_configure(data->pll, regmap, data->pll_config); ret = devm_clk_register_regmap(dev, &data->pll->clkr); From patchwork Mon Mar 18 11:19:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13595275 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0475B376E6; Mon, 18 Mar 2024 11:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760808; cv=none; b=COvpoM5AfQlG8VgdxoDfakyhTtpn3mMSx2lXU3YJNplJLxifTayCrTGYhQFsG7gQrnVznf2DHWj+hc+6PxLhIRchleFAruEuQ4/HXhrfls9gwa4tWUNQPhl2ZDmNg5r54anAKekyfmC46IkYhJ14dDn6D/hfEPkSfJo6zqJJvYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760808; c=relaxed/simple; bh=h168MlEyYXbWqKmcr3c1QrEYW+OujZ+/o9TumUSwsqE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PB23//lSNdKOcNV4BeabupYHFVYQ3fIIvjufdTvI93A2/G7dxwyVHJh0HJSk21vQjCPRpK2eI5IYpMQIUdo4iza6U0cEivZQPdGAIOKQkkDcGsxNBjFc7wptmOOcqymMb2S4K0WjG5E9T0/3cpDLsx/Imxt2OtnQINDfqgVvZHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JzbMFTFj; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JzbMFTFj" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-33ed5b6bf59so1580283f8f.0; Mon, 18 Mar 2024 04:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710760805; x=1711365605; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=11SsO5DV2l7dsIFWxNjWwkgefIRCA6N+9rlBR7yanMQ=; b=JzbMFTFj4fia25eKpEJv6uw2fj8RkPSoMynJ0cH8dNVrW3EbWUQmXF44zVWQkxSmK9 Ks2Zns/Mrzj8PXoarOI4SrH+asH4pQvF9MnVnj4+ihMNMaw+aUfUVWC6Quw7CnGMWa/4 DXWUl3HW6LGFKbi1gJAPC5Mg9PVroHKAlxFAbTFn6L1NXmgopsGC5n+UIrvtZoJPXt35 h8qtLwC2QtdgFmlfdt3s0iJwqFeelPJEHjMZoGWkSGlCYGjKGU5lrKsDiJ383FMLlKh/ uvoWMBtyoFhNaLI0gO3bbQUAZDMtWwrbwz9Hl+AeUEsvD1D/A3hchZ4yRQ/HvwHHREAk cTXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710760805; x=1711365605; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=11SsO5DV2l7dsIFWxNjWwkgefIRCA6N+9rlBR7yanMQ=; b=fBtBRwv1CwFExKtO16r8utY8KTZNZreH1D9kOuKMf/Yh9vU9QpK6NdcuDwyln3NXCB h8ze9Jnbdqu4/G/6BAo798/HAqdmskgodw3i5iiUC8koH94lkMFf1UfQ0RwFn+FfEm21 gQjRR6KBs0S4qdguuYRz00N57mT+C2FrRAovMq4DVlCLQzu1QLuLBtWm1VOx5LNDdDWf Y6ah8oOMonqDwHi5rBptXtDIHU0HDcvCWVswKYTdbvZmJTcx2cE5eb+Yamo6X/zZy8jc HFxpCvIHzcTEzR/b7ZBmokrl4jQwquheaT0yOfjtVgJO6swdXuU7HCkHYB/WCNOQSMsY +Shg== X-Forwarded-Encrypted: i=1; AJvYcCXI+f4l/it+sy17ZZStWJusIQp1C1y99pnamqpw1YfIQfBqve0cIQgc6OJ3NeHob8W8eQEPXP2lctKZ+Fjrxg4OgigyZBdh9t7UBUYAz66ylBx0X6uRGsKZxbAbPVAEyO2dhCJ71FI7 X-Gm-Message-State: AOJu0YyUjt9akZiBFw4LltIVqhgvVfQ6IK4wrxsZOEg0enzXwhxaVnXx 0judxcpITq4433MVQGwpiZZq3sgav/7Gg2Cw54wA7CX0eyHyHQdL X-Google-Smtp-Source: AGHT+IF1iA9ClBNXylPILCeU6z/kdkk5Wq6SsBi8DFFYlfdUtVuSO9CFxxDAlvi5/JImnCrciAqbgg== X-Received: by 2002:a5d:6a04:0:b0:33e:79d3:2cb with SMTP id m4-20020a5d6a04000000b0033e79d302cbmr7448322wru.38.1710760805376; Mon, 18 Mar 2024 04:20:05 -0700 (PDT) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id az1-20020adfe181000000b0033ed7181fd1sm6650421wrb.62.2024.03.18.04.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 04:20:05 -0700 (PDT) From: Gabor Juhos Date: Mon, 18 Mar 2024 12:19:58 +0100 Subject: [PATCH 4/5] clk: qcom: apss-ipq-pll: constify match data structures Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240318-apss-ipq-pll-cleanup-v1-4-52f795429d5d@gmail.com> References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> In-Reply-To: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> To: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.12.3 The match data structures are used only by the apss_ipq_pll_probe() function and are never modified so mark those as constant. No functional changes. Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/apss-ipq-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index fb015385dae4b..6ee71ed6baed1 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -156,22 +156,22 @@ static const struct apss_pll_data ipq5018_pll_data = { .pll_config = &ipq5018_pll_config, }; -static struct apss_pll_data ipq5332_pll_data = { +static const struct apss_pll_data ipq5332_pll_data = { .pll = &ipq_pll_stromer_plus, .pll_config = &ipq5332_pll_config, }; -static struct apss_pll_data ipq8074_pll_data = { +static const struct apss_pll_data ipq8074_pll_data = { .pll = &ipq_pll_huayra, .pll_config = &ipq8074_pll_config, }; -static struct apss_pll_data ipq6018_pll_data = { +static const struct apss_pll_data ipq6018_pll_data = { .pll = &ipq_pll_huayra, .pll_config = &ipq6018_pll_config, }; -static struct apss_pll_data ipq9574_pll_data = { +static const struct apss_pll_data ipq9574_pll_data = { .pll = &ipq_pll_huayra, .pll_config = &ipq9574_pll_config, }; From patchwork Mon Mar 18 11:19:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13595276 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01116381C5; Mon, 18 Mar 2024 11:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760809; cv=none; b=j2xbN9/1zwQkkUd2inKrTYkWSrlMKl85cjfCdF1rG7isrNv6f6IuGK1OU/TUOmo0Euk+zeLlXsjGELvDBjM3ND8c8gbQ3BlgyvvO/IlPKStIHtnVD1VLP+hcqdNuydv0qmWg/i3ndw7i3B/Umi2xAAuoH5dNueXTpyNrEuIOgyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760809; c=relaxed/simple; bh=VeSHBpyUKXYt/Yh7tQKPCVQRJ1T9+Llp9DI0p6yKfjs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y0Uh+9Rn8TDYc/NGHFiyngczZqQKTCMPmKK2hS+K4SDHVPmpxlecRfkvWD8A3y9/L1Tiyb0/aol1S4qHWSRyh07I9CRXqN8F1xKmXEfSVqNujnxR4plVvhxAmzCXtLyf8hMzcMLx4MELzqoYJXgsG8JEWwbKBNme3b06MNr46S4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=De65PA0O; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="De65PA0O" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3416df43cabso609038f8f.3; Mon, 18 Mar 2024 04:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710760806; x=1711365606; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kPuoOY9/Q98dbqm96E10istRwlwF4G6fYLA56NqAfeQ=; b=De65PA0O4Po2tbxqrs5PcqG1HaTvAxUKwY/T3t2GdDzw7o+XXgXrL8Bz2QoUo6a1Ib Ug6/9UDwxE2EstIp4sGIRE8+JfInpB2Jt+KycdOOVCKdBzeOK8ZRg1CPgupR4769sRO+ TqXOp4NJ9c7opnkbw7K6yJXYKl8Kv4We0fqsDJdABhNseyMKJbxOJregN5Ib2SGLbCys eu4yiCskFyJtE5FyERYGaEhRkA/hKTvVfFZAVJI/PAIixtiC/GdvoKeqfarIek6FQUZ3 TxmSokl9SyKcmIN/zbf5Wai5AbCIUty81yIySCijHY/SX4VEI8hyQA+ZoXmbGkGyFvEe 1hzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710760806; x=1711365606; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kPuoOY9/Q98dbqm96E10istRwlwF4G6fYLA56NqAfeQ=; b=mUrFyIqWRmqIvMOhGTZPIQ9we+TzqhxbmXI1mVilJGbGkYu6ymOZ+hgz8S1pbL8ogr UScamhNaPDbpmazOQbT2LjDIXOcGX+MtqgtorO0NcwN+bUwQd0Fkjvi3GVaWqBnfFCHr xT6l0GyKzkiW+jkAazw3u+FrMzcOEJX6tDJPUfZaHtpQ0OhQl9/tQbS4IK9+vrBQoxl8 VT1v51cVRuLWCNhr/oX4szBEloHN2lKgall4t5TPOf9lyW83ZGd1/lEs8nG6R/5IyND7 AopUwpuJRJ7I/xCwvLn8owQyud8wLXEHXomAkfUDRgV4YsRSTdHtRWXd8oVFocxF6CCy mFXQ== X-Forwarded-Encrypted: i=1; AJvYcCVZbHBIRyqzOautmQUmf86VfJcfyrqN2+yAgQdgXSFy6z1xsfNMtkRDy+Yyi6BppRMIzHA5VVHcCsTxrGN4ohy3k28lHmsrmmlu0G+zPqfu6d8SSIaDJklkLKGXrLeB2FxN1vqSLGnb X-Gm-Message-State: AOJu0Yw9Z/uqEGvWlKvO+Trh10yRTNSS0LNNzEph8wTnrvgY6XAdwGCh 0AN7N7LxRI/NL4/u+ijMSv7RA23ZGMtPL1xCJtG5KDfkRjCrGIrT X-Google-Smtp-Source: AGHT+IFqSLqH86uUqVcWskOa3664WxrdQZUIeDK6MH78X1d6f5pdQ6F6vPZNrjt0NUgpe+kOIlGqiw== X-Received: by 2002:adf:eb11:0:b0:33d:2472:eb8c with SMTP id s17-20020adfeb11000000b0033d2472eb8cmr7350002wrn.19.1710760806267; Mon, 18 Mar 2024 04:20:06 -0700 (PDT) Received: from [192.168.20.102] (57657817.catv.pool.telekom.hu. [87.101.120.23]) by smtp.googlemail.com with ESMTPSA id az1-20020adfe181000000b0033ed7181fd1sm6650421wrb.62.2024.03.18.04.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 04:20:05 -0700 (PDT) From: Gabor Juhos Date: Mon, 18 Mar 2024 12:19:59 +0100 Subject: [PATCH 5/5] clk: qcom: apss-ipq-pll: constify clk_init_data structures Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240318-apss-ipq-pll-cleanup-v1-5-52f795429d5d@gmail.com> References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> In-Reply-To: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com> To: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.12.3 The clk_init_data structures are never modified, so add const qualifier to the ones where it is missing. No functional changes. Signed-off-by: Gabor Juhos --- drivers/clk/qcom/apss-ipq-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index 6ee71ed6baed1..6cf093f7f91eb 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -31,7 +31,7 @@ static struct clk_alpha_pll ipq_pll_huayra = { .clkr = { .enable_reg = 0x0, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data) { .name = "a53pll", .parent_data = &(const struct clk_parent_data) { .fw_name = "xo", @@ -71,7 +71,7 @@ static struct clk_alpha_pll ipq_pll_stromer_plus = { .clkr = { .enable_reg = 0x0, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data) { .name = "a53pll", .parent_data = &(const struct clk_parent_data) { .fw_name = "xo",