From patchwork Thu Mar 21 16:18:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13599092 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E064C54E68 for ; Thu, 21 Mar 2024 16:18:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A90210EE56; Thu, 21 Mar 2024 16:18:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fyn42lPK"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE26310ED9E for ; Thu, 21 Mar 2024 16:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037893; x=1742573893; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=Y36C7/58MD7q4/SrJgzqEeuSoeCGRVEeaVETCAHRorg=; b=fyn42lPKaVKPzH2I3vcGReMg/4bVMBZYB83y9MZlSFsfjOWZmrM4IE7g WOwZugqJur+IhuFHlBwS+H5nxdYehqG8w8iv0Myz/+HcIJxfOW7yKxQAH jAKu+SMClXYKDqOoCrpr6CI4eP2J1+ajW3zpqUAZxoy7B1Q40jsFm4n04 NS7KjN2hON3SgDgixXd3WI8CN0CYSvDWruPhBf+PJzoDi1okl/Xjfojbv q6qPdZGbkFY7o1CeTaT8OuSN0KwbMYOkp2Fqb+X8F3S/9PnzGElS8QV59 ZL84KOaS8zt6hBfvYEVOjtNkkAGklrDnIWI+coeSGa4yQqCPXzIF20Kas A==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="5894180" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="5894180" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:18:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="827783098" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="827783098" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 21 Mar 2024 09:18:10 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 21 Mar 2024 18:18:09 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH 1/5] drm/i915/bios: s/dpfs/dfps/ Date: Thu, 21 Mar 2024 18:18:02 +0200 Message-ID: <20240321161806.31714-2-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240321161806.31714-1-ville.syrjala@linux.intel.com> References: <20240321161806.31714-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä We've misspelled the VBT DFPS (dynamic frames per second) field as DPFS. Fix it. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index 648934fcd123..f2506b0be790 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -614,7 +614,7 @@ struct bdb_driver_features { u16 tbt_enabled:1; /* 165+ */ u16 psr_enabled:1; /* 165-227 */ u16 ips_enabled:1; /* 165+ */ - u16 dpfs_enabled:1; /* 165+ */ + u16 dfps_enabled:1; /* 165+ */ u16 dmrrs_enabled:1; /* 174-227 */ u16 adt_enabled:1; /* ???-228 */ u16 hpd_wake:1; /* 201-240 */ From patchwork Thu Mar 21 16:18:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13599093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FD2ECD11C2 for ; Thu, 21 Mar 2024 16:18:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87C0510ED9E; Thu, 21 Mar 2024 16:18:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="TLL9Gatf"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 696E910ED9E for ; Thu, 21 Mar 2024 16:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037896; x=1742573896; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=/vCuy5tXaGNo6FstSJofvi7PjLaxusKPqF6CC0wN9+I=; b=TLL9GatfhPXni0IHlp1U9t7KhzfXEBOaRIyH+iSu/skp63z2Rc4xUbGM 94gqiMYQOqJE57JbXPTkg8pgnPRt+0GJvbSgqSIQLzA3nHd2B2KKMyg5j bprv+QRs64Af71As21wDlqy63IcQ6rPeL5Nx19vwKdR2F5aIE/6f+o/AT p++E5eN8PfJor2g7CRMUQphhReExCP0Ht9pzl5AZ+hACfvK1OJR9EugI7 J/VQa669sVm8WkeBSJ1fC3g/yrgqPHCU4OCuqIYIEoecO5JeFHiXtdXx1 HPKZma1mqIUmV+MBTC4Jm9qGwLLiVveIlgL+3HaCexCBtz4Y9HRp51o5S w==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="5894186" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="5894186" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:18:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="827783099" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="827783099" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 21 Mar 2024 09:18:13 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 21 Mar 2024 18:18:12 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH 2/5] drm/i915/bios: Update VBT driver feature block version numbers Date: Thu, 21 Mar 2024 18:18:03 +0200 Message-ID: <20240321161806.31714-3-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240321161806.31714-1-ville.syrjala@linux.intel.com> References: <20240321161806.31714-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä While the spec does claim that most of the driver feature flags start from BDB version 165, reality and some VBIOS code disagrees. The VBIOS code says it sart from version 159, and my ILK with version 162 definitely has these things already in its VBT. Update the version number comments to say 159+ for all the bits that seem relevant for pre-hsw hardware. Signed-off-by: Ville Syrjälä Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index f2506b0be790..24583b455f2d 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -603,22 +603,22 @@ struct bdb_driver_features { u8 custom_vbt_version; /* 155+ */ /* Driver Feature Flags */ - u16 rmpm_enabled:1; /* 165+ */ - u16 s2ddt_enabled:1; /* 165+ */ - u16 dpst_enabled:1; /* 165-227 */ - u16 bltclt_enabled:1; /* 165+ */ - u16 adb_enabled:1; /* 165-227 */ - u16 drrs_enabled:1; /* 165-227 */ - u16 grs_enabled:1; /* 165+ */ - u16 gpmt_enabled:1; /* 165+ */ - u16 tbt_enabled:1; /* 165+ */ + u16 rmpm_enabled:1; /* 159+ */ + u16 s2ddt_enabled:1; /* 159+ */ + u16 dpst_enabled:1; /* 159-227 */ + u16 bltclt_enabled:1; /* 159+ */ + u16 adb_enabled:1; /* 159-227 */ + u16 drrs_enabled:1; /* 159-227 */ + u16 grs_enabled:1; /* 159+ */ + u16 gpmt_enabled:1; /* 159+ */ + u16 tbt_enabled:1; /* 159+ */ u16 psr_enabled:1; /* 165-227 */ u16 ips_enabled:1; /* 165+ */ u16 dfps_enabled:1; /* 165+ */ u16 dmrrs_enabled:1; /* 174-227 */ u16 adt_enabled:1; /* ???-228 */ u16 hpd_wake:1; /* 201-240 */ - u16 pc_feature_valid:1; + u16 pc_feature_valid:1; /* 159+ */ } __packed; /* From patchwork Thu Mar 21 16:18:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13599094 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B26CEC54E68 for ; Thu, 21 Mar 2024 16:18:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2704E10EEBF; Thu, 21 Mar 2024 16:18:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ssu3hIPw"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C72110EEBF for ; Thu, 21 Mar 2024 16:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037899; x=1742573899; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=9q/8ZAdF6KLTibSag4WtdJgHWzEParhSBNya/WXfPKw=; b=Ssu3hIPwPh+ezV2XhgxEuZcYdAo65kB45B9nODeRAQqDvDTZ/1u/HPEJ BHGYl/LijcLjKlIh2j+2bsJ9oJb+tdzCQUf/TQiO4pyhdHfk8bRjkEFac 2Vc7yusSyaKWfmowGHZreSAVqs+tBmdHVjiuyLcW0lcvtcvHERCH/7qw/ iOqYHnnV+YsLCgbKLHhFGsMDoA5xorjWixq+hJWxAljxeUl2z0lfFqM7E GRAROk3cRcVJa8zlCBZQgnZVNfyTuTLp0THicVvePyQXtVKjeztinyZ5z XAnE57cXdIUfy5TvTYQ5w8mDadKmwfdC2eAtOPTjeiTuHBADx3TTMJRIj A==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="5894193" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="5894193" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:18:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="827783100" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="827783100" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 21 Mar 2024 09:18:16 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 21 Mar 2024 18:18:15 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH 3/5] drm/i915/bios: Add the old DPST field into VBT LFP power block Date: Thu, 21 Mar 2024 18:18:04 +0200 Message-ID: <20240321161806.31714-4-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240321161806.31714-1-ville.syrjala@linux.intel.com> References: <20240321161806.31714-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä According to some VBIOS sources the LFP power block used to have a single bit for DPST support. In version 159 that bit got moved into the driver features block, and then in version 228 back into the LFP power block (but this time as a per-panel thing). We have definitions for the last two, but not the original bit. Define it as well. Signed-off-by: Ville Syrjälä Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index 24583b455f2d..5da8ae407dfd 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -918,7 +918,7 @@ struct bdb_lfp_backlight_data { * Block 44 - LFP Power Conservation Features Block */ struct lfp_power_features { - u8 reserved1:1; + u8 dpst_support:1; /* ???-159 */ u8 power_conservation_pref:3; u8 reserved2:1; u8 lace_enabled_status:1; /* 210+ */ From patchwork Thu Mar 21 16:18:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13599095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32871C54E68 for ; Thu, 21 Mar 2024 16:18:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9842110EECF; Thu, 21 Mar 2024 16:18:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DSg7oult"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C2A210EEEF for ; Thu, 21 Mar 2024 16:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037901; x=1742573901; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=MPIVk89hhJHrgmeGD8PN5wYGpcN/5pm+LzWoDcyRVso=; b=DSg7oultxaWhpOxEsnabXseNMWVbsJyX22QOP0kppQeAQm0OhefKn+EM caZOsvajU2EksX3wtbmlWdnH+beSeDFbF3YHggMkHaCEkMLapkVC5LTgY P4yu3x+EzhTT3zCpvwI0FHTI9Dwh/L5xoPPOEMsERUhKnXhMWwdRx9u42 1NopbRV9niBFIcgZC6smSRTCFop4jflI6DHXl/vRR1s4MbHrvmRFEVyPZ r55pQIqVucouEwtv+oCFjeESU1zUNw/PKK/K6GkkxcH42Po8xPgPsQqIc 1f+fClP6rL5dq6D7C6MkMFlQXXXaOAFRztVPNy1HGL1cpKIAggjNH70Ah g==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="5894195" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="5894195" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:18:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="827783101" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="827783101" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 21 Mar 2024 09:18:19 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 21 Mar 2024 18:18:18 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH 4/5] drm/i915/bios: Define the (obsolete) backlight i2c VBT stuff Date: Thu, 21 Mar 2024 18:18:05 +0200 Message-ID: <20240321161806.31714-5-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240321161806.31714-1-ville.syrjala@linux.intel.com> References: <20240321161806.31714-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä The VBT backlight entries include various fields for i2c controlled backlights. These have been obsoleted at some unknown point in time, but let's define them anyway so that we have a full picture of what has been in there. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index 5da8ae407dfd..bcd1b239eb65 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -881,11 +881,12 @@ struct bdb_lvds_lfp_data_tail { struct lfp_backlight_data_entry { u8 type:2; u8 active_low_pwm:1; - u8 obsolete1:5; + u8 i2c_pin:3; /* obsolete since ? */ + u8 i2c_speed:2; /* obsolete since ? */ u16 pwm_freq_hz; u8 min_brightness; /* ???-233 */ - u8 obsolete2; - u8 obsolete3; + u8 i2c_address; /* obsolete since ? */ + u8 i2c_command; /* obsolete since ? */ } __packed; struct lfp_backlight_control_method { From patchwork Thu Mar 21 16:18:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13599096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5D64CD11C2 for ; Thu, 21 Mar 2024 16:18:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 39FF310EEEA; Thu, 21 Mar 2024 16:18:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="N62GKI/z"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33C1410EECF for ; Thu, 21 Mar 2024 16:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711037904; x=1742573904; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=/qQUj26Uo4AzzP6UULxfVxQqCNFGNDw2eSXTW22+pik=; b=N62GKI/zXyUJ0F55EkJhQbWXnemCF8eE+4n0v6Tq+2kmSpThEs4LIf1k Q5b8oNSp3ye1jf6ZwYkTmBbRwCtr/dGHz+TX6RTCtGhbuXF7+oPD4Aryx outCehaPBplQbcCxGA79PMvA0t2V3r8tqUwHBfP62hEugWRTeA0dqMof3 RcgNffmGcRisEEKQCYkkWd0EMWlr8remPls4HS83jCpAI0i1Bw9MjDPUT GcC2/8DDbH7ipTptqh2Nl5qDhNYQH2laocI2RBiLdVdCSCoSa7UF8uLZr up01Jx+p7g4TVMO7FMDIMRAJxvek00JJA2FQIfgt0rl2Db0Z0YZ6q6m60 g==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="5894201" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="5894201" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 09:18:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="827783102" X-IronPort-AV: E=Sophos;i="6.07,143,1708416000"; d="scan'208";a="827783102" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 21 Mar 2024 09:18:21 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 21 Mar 2024 18:18:21 +0200 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Subject: [PATCH 5/5] drm/i915/bios: Pimp the VBT backlight data BDB version comments Date: Thu, 21 Mar 2024 18:18:06 +0200 Message-ID: <20240321161806.31714-6-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240321161806.31714-1-ville.syrjala@linux.intel.com> References: <20240321161806.31714-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Add the missing BDB version number information for some of the backlight fields in VBT. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index bcd1b239eb65..3815aa21d19f 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -907,8 +907,8 @@ struct lfp_brightness_level { struct bdb_lfp_backlight_data { u8 entry_size; struct lfp_backlight_data_entry data[16]; - u8 level[16]; /* ???-233 */ - struct lfp_backlight_control_method backlight_control[16]; + u8 level[16]; /* 162-233 */ + struct lfp_backlight_control_method backlight_control[16]; /* 191+ */ struct lfp_brightness_level brightness_level[16]; /* 234+ */ struct lfp_brightness_level brightness_min_level[16]; /* 234+ */ u8 brightness_precision_bits[16]; /* 236+ */