From patchwork Sun Mar 31 22:20:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dragan Simic X-Patchwork-Id: 13612318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7E70CD128A for ; Sun, 31 Mar 2024 22:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=DNo28VqZWjdJRsn4kv1Eho3ClhPJrHNTNZ7zuWkEYOY=; b=JCrtR19o/B7Qqn TlInh5bkIKhPQkZqIBb62q92dlzbUxnvIZQOkB2gRsXJ3h+FGckoyMH2LuYAfgE3vUF6xwiDKh9dd 35ccUgHfT1BXM47OughYt5bVCiLeO6DVOpYtaV3m+5cVWFGjWHAdoswTwHkPS6pxunmT10pIQID8E 3G7bba6Sg/XaTDmakU3GWRt5/+B8a8cM0V1iOjyay2qtut7mV8SemuVqyIoZghwsQWhPQebZyB8Pr tfVMp4zh2nrzJFlZDHxnha8veL2s1Tx3oTqvwpiCdOIiNHPDTu4D1LnKUWjwtjsId49fkzId3+XOi fcE8xyr3STZ16I7LPM0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr3Y7-00000006Oyy-0W64; Sun, 31 Mar 2024 22:21:11 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr3Xz-00000006OyB-2WyT; Sun, 31 Mar 2024 22:21:08 +0000 From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1711923660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UcTQxLJRrCmCev8Rrf+Wteer/pHxBoVYDfU24cKirEE=; b=gRw5hUAwXLn5VB+YC3u9DcN6qmeH11vXyTDWAzX2JEtiggaokVWTt1EJqA4J82s3MBicML hm0FVw8e44piWUE0Uwn6m6CiR/0CGUqVuj1cwoHQ4+t8zogu4v5i6CtzFBs8z6/DcuJUbM A3yZnsSCINwMYOpCuIAuvICAikfJvQnjYpk/eri5Yiym5zUkZD5UXIRIYJGSPCe5ZaoQ33 cTPRjIfKnhtKcCsWIrFEwdcHIMhD7EmNSq0dXJPUKp2IzieBhO8WxeWG4q+ZoU866ki/ZE E1ImfVKhe/WBbDOV4gWU8UBqBtiZX8ZGYDYgWF5neEzgFFmuUkk/4X9SCRPszQ== To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Subject: [PATCH] arm64: dts: rockchip: Remove unsupported node from the Pinebook Pro dts Date: Mon, 1 Apr 2024 00:20:56 +0200 Message-Id: <0f82c3f97cb798d012270d13b34d8d15305ef293.1711923520.git.dsimic@manjaro.org> MIME-Version: 1.0 Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_152104_002620_C3140E3D X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Remove a redundant node from the Pine64 Pinebook Pro dts, which is intended to provide a value for the delay in PCI Express enumeration, but that isn't supported without additional out-of-tree kernel patches. There were already efforts to upstream those kernel patches, because they reportedly make some PCI Express cards (such as LSI SAS HBAs) usable in Pine64 RockPro64 (which is also based on the RK3399); otherwise, those PCI Express cards fail to enumerate. However, providing the required background and explanations proved to be a tough nut to crack, which is the reason why those patches remain outside of the kernel mainline for now. If those out-of-tree patches eventually become upstreamed, the resulting device-tree changes will almost surely belong to the RK3399 SoC dtsi. Also, the above-mentioned unusable-without-out-of-tree-patches PCI Express devices are in all fairness not usable in a Pinebook Pro without some extensive hardware modifications, which is another reason to delete this redundant node. When it comes to the Pinebook Pro, only M.2 NVMe SSDs can be installed out of the box (using an additional passive adapter PCB sold separately by Pine64), which reportedly works fine with no additional patches. Fixes: 5a65505a6988 ("arm64: dts: rockchip: Add initial support for Pinebook Pro") Signed-off-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts index 054c6a4d1a45..294eb2de263d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts @@ -779,7 +779,6 @@ &pcie_phy { }; &pcie0 { - bus-scan-delay-ms = <1000>; ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; num-lanes = <4>; pinctrl-names = "default";