From patchwork Mon Apr 1 15:37:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612880 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25414CD1288 for ; Mon, 1 Apr 2024 16:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6ULOA/fs/QP/6tplZJu0B/LKIFGaW/2rFMS2+ZUrFd4=; b=XSENUFz7KIxGD9 H25qwo2fsdBKCwlCiEoV2n4G3IZY2MaObgK3ACSNbnlq92ju7YUV/GoUD4qw/3cHUc/bSHUmEgGyo WfmQb5o1fVsbN7l5phcXmuugfJfa6B3NYCXRKg6sUCo7CmoW5tymLzMsdLjdpPIoMknJaTUFi5e2R ZtQ54UDSFC+JruCZadSsugE175Wknl80EA4DY5IdD2+7Rk8p77tttOCddI6pwQDTaWfhb3CpW2DVP Yl41tadML6OOkydscmDfzulliXf9Q93zIhrXHOpvRfjyGiFNog7QuE6iHG3xXRAiEIO8uArPtZ9y/ Z2zJ/idfNlcIwrWnE0IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrKp4-00000008NOX-42vp; Mon, 01 Apr 2024 16:47:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjK-00000008Cn1-0kOU for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:37:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7578160D37; Mon, 1 Apr 2024 15:37:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D723C433F1; Mon, 1 Apr 2024 15:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985869; bh=TWR2R9S8+YN5+h3vNn0SS/MXsQWwKa64KB0+vUd7Ous=; h=From:To:Cc:Subject:Date:From; b=Du60WaCvSlza/o1nfoaVwJ7uL4uMUa5xPlBqYRuLjDxl+NvPqsrllTs/78eCFL4zJ vGXDS3cbpmTgrYbQyfXj4vgMFmiKjamez+pEUBT5kG/gexrtzjUV7QqkS7h/rLwpOj jBT44BNTqympo1j+fSJET/euA1EKeBvCh+FQNzrdc95oGVQXhdMlfOUO4DX/Gq04FU pUaPJRBKyfqp6HzlyxVG5dkMkRjsK8ZywLuGHQX15mUmtqLXskEkSdU/Gdq7A+TCMM Psx7axzokNcvpG6NdFJsprYcZ1WuocRFZ87VbcnY57mnpt+GeMCu8YVBbAJygPaDRB O/ClEeZ1kriUQ== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 01/10] arm64: dts: microchip: sparx5: fix mdio reg Date: Mon, 1 Apr 2024 17:37:31 +0200 Message-Id: <20240401153740.123978-1-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083750_288347_6716F818 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct the reg address of mdio node to match unit address. Assume the reg is not correct and unit address was correct, because there is alerady node using the existing reg 0x110102d4. sparx5.dtsi:443.25-451.5: Warning (simple_bus_reg): /axi@600000000/mdio@6110102f8: simple-bus unit address format error, expected "6110102d4" Fixes: d0f482bb06f9 ("arm64: dts: sparx5: Add the Sparx5 switch node") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Horatiu Vultur Reviewed-by: Steen Hegelund --- Not tested on hardware --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 24075cd91420..5d820da8c69d 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -447,7 +447,7 @@ mdio2: mdio@6110102f8 { pinctrl-names = "default"; #address-cells = <1>; #size-cells = <0>; - reg = <0x6 0x110102d4 0x24>; + reg = <0x6 0x110102f8 0x24>; }; mdio3: mdio@61101031c { From patchwork Mon Apr 1 15:37:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75BCDCD1288 for ; Mon, 1 Apr 2024 15:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rr6MGwSWSCIfopEojPsg2dKYXusW+nv4esd7t6Sf6Gc=; b=Dsvy2j+Cn2aD9F ZEdBVBeAm4ycWw0aWzqo4SwEZIFgpAaM/uKeW6SP0lEFTa/VKcQouSM1r28q84aFmNOEZIX8xTyDI 4nZdfQFTuaKyghOvgvxaEpTRYbaaQSZrPckZNdSl+24O7mCIe97J7ed+LqaE8F7+GuvhXJu1VYyrA fPBhnT8U+OwS8/m8oXKAkUAxQ7ZyrmXj//09Hr9HxdqXtOLZ5HFFUps58CRKDHyWAw/fYFd5bsXVw dPMOtHQJLhYe+9ueI7AVbKR/ObfhcthuDh+CYPP1SzS9DnfsfDich051xenb7XxjN4CVW5cI2Li87 ItyewdO250d8Ql0oLoKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjV-00000008CqY-3C1d; Mon, 01 Apr 2024 15:38:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjT-00000008Cq3-44MV for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Apr 2024 15:38:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=gIEnP1kWiJcKS1R8k21tWDhUz6GwkbyBZZ5kr5J6C3g=; b=LFC4cYqVScvpRM/mj8BnMzw+cd X2m9moN/eRXaDp/PG9nwRMz71yxYJGV744EImMTe+oylrrjiC17QWx/X5x4h5fh3w8H0jbKZE1ph3 x6L4917rKqRN8mMzyomNvVYUZ1NUvMzVnrgA6Xu3VoiCyap6hAeXLNIcQfAnMm77W2fMmk2ExvVF1 um4rLFgcQytwkBp/0A6M3PVPIz+JmyrpiQxc8KwyC4rs0ZUf7ItAx+l0OdTcSEzF10dEBsohgk6PH 3757DgyAgYGC573/mMUXZqex/6+/sQmwRUZ3lnACH2mYcMJJPx+Xqzp7OLM87dSmdxkUePXEnYMg/ moeqrKWA==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjQ-000000038nF-38pC for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:37:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D5C3760CEE; Mon, 1 Apr 2024 15:37:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91426C433A6; Mon, 1 Apr 2024 15:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985874; bh=AhhaYocEjIqO9rdjPoZ6SpcUsTizNmG30kjKObWFbDs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F5pisUfHcX8D272f5z+7o5XoAc/4pYmHWE6UeQJZvBFMfsnlVijZ8xY9y6WOjubuN Zc6Hyhv46ZrZ1JkAqMxSd6sARsGT052kiWfF+XppKcwFeMpyaNFviH/KisrmFr6kNk Y1jB3Yj2B4FbWLjB3XVf1xCcMdnPrTB6idGbGIn4JBBePCurbDwCzCk8Wtt3GpwEw2 JivZJivyda7nvS7W7k+l+e5S9JzF+F70Xe9w32KyApc4PyaoFL2/tp0zYWtJm6vOwE owNFtO+kb26BrgXOeoyNuu830zFVw1bhn+/b5eTOZRE9oYYf85JCGWNSCfqkrJsuJZ MjwEtMJamx+Cw== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/10] arm64: dts: microchip: sparx5: correct serdes unit address Date: Mon, 1 Apr 2024 17:37:32 +0200 Message-Id: <20240401153740.123978-2-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_163757_226352_D67139E4 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Unit address should match "reg" property, as reported by dtc W=1 warnings: sparx5.dtsi:463.27-468.5: Warning (simple_bus_reg): /axi@600000000/serdes@10808000: simple-bus unit address format error, expected "610808000" Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 5d820da8c69d..c3029e0abacc 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -460,7 +460,7 @@ mdio3: mdio@61101031c { reg = <0x6 0x1101031c 0x24>; }; - serdes: serdes@10808000 { + serdes: serdes@610808000 { compatible = "microchip,sparx5-serdes"; #phy-cells = <1>; clocks = <&sys_clk>; From patchwork Mon Apr 1 15:37:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3763DCD128D for ; Mon, 1 Apr 2024 15:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2zZibFP3BQWTIqw5Cr0dW66zHa2QWpZOpaWLa6GJxS0=; b=EsJc6WkEWGAJ1P YXnz4EvKQQFBi71c5fDGTtK/7Ce+t0SspIqY2/Sg19qohQuirIrqLhqjmPPM4tYyYEfXGPoFNSuOi 4k5Zt/GiLFwAJ+VcczLGdXSgXR4QioI43cAEWAFu50Kw1EoeFJAKC5lgGJwt+TOL83OlzBh50zz9S 7ekr0poRZyYQGodS9wbSnMdmj3d4gw5a9ORpFNMnm1Ny0xCm5+jZLD3l/dMaDVQEUPZP+ucZNnux/ Lkj/1nVUo9CmDWMbL8w2IWifaFQW9qpH/Tt+zIGPMJMYPM3zJQpFGYth2hFe4wTqsXyuOpIa04vs8 si6jZIni1LzNLcVEWe9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjZ-00000008Cs5-20Db; Mon, 01 Apr 2024 15:38:05 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjW-00000008CqV-1p15 for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42867CE12A4; Mon, 1 Apr 2024 15:38:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40E78C433F1; Mon, 1 Apr 2024 15:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985879; bh=2dxQqozF58q05bPixhJfo04L2CdUFTnvt6KKOQGg51s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=COPEnmppa5euyg4K3SJ2tAh0X2rEaMRzxTCogjOdAP/L5oiI0qUwTE40u6WQ3zxpt LnRowOnBmanYHw/pp+AQUILVpbmROJBOkwC35uwwbDWNRPVAQk0T2PH4V1P8P4FTEr LWnbHnruJSoaoIZD7/vLQhK8O8/vbNjlXzFx3a2B31Ag9FAG8xwiiIc5I/AANjz5lz SPnYD6E+6pQw69RFXHzfW78a3V2pkHntZWCB21M/ILAoVf0daci8IW5ky7wmLaPT/v Tjygq8pC5MfRQ8o8kISoIrMnFPQCLaiNeLUnzSLn1fmUNb7azO69Dd0bU8OEOcnyk7 52XTYGLsEEYmA== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/10] arm64: dts: microchip: sparx5_pcb134: add missing I2C mux unit addresses Date: Mon, 1 Apr 2024 17:37:33 +0200 Message-Id: <20240401153740.123978-3-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083802_851169_FF86149A X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The children of I2C mux should be named "i2c", according to DT schema and bindings, and they should have unit address. This fixes dtbs_check warnings like: sparx5_pcb134_emmc.dtb: i2c0-imux@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c_sfp1', ... and dtc W=1 warnings: sparx5_pcb134_board.dtsi:548.23-555.4: Warning (simple_bus_reg): /axi@600000000/sfp-eth12: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski --- .../dts/microchip/sparx5_pcb134_board.dtsi | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index f3e226de5e5e..e816e6e9d62d 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -427,62 +427,62 @@ &i2c0_imux { pinctrl-10 = <&i2cmux_10>; pinctrl-11 = <&i2cmux_11>; pinctrl-12 = <&i2cmux_pins_i>; - i2c_sfp1: i2c_sfp1 { + i2c_sfp1: i2c@0 { reg = <0x0>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp2: i2c_sfp2 { + i2c_sfp2: i2c@1 { reg = <0x1>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp3: i2c_sfp3 { + i2c_sfp3: i2c@2 { reg = <0x2>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp4: i2c_sfp4 { + i2c_sfp4: i2c@3 { reg = <0x3>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp5: i2c_sfp5 { + i2c_sfp5: i2c@4 { reg = <0x4>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp6: i2c_sfp6 { + i2c_sfp6: i2c@5 { reg = <0x5>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp7: i2c_sfp7 { + i2c_sfp7: i2c@6 { reg = <0x6>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp8: i2c_sfp8 { + i2c_sfp8: i2c@7 { reg = <0x7>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp9: i2c_sfp9 { + i2c_sfp9: i2c@8 { reg = <0x8>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp10: i2c_sfp10 { + i2c_sfp10: i2c@9 { reg = <0x9>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp11: i2c_sfp11 { + i2c_sfp11: i2c@a { reg = <0xa>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp12: i2c_sfp12 { + i2c_sfp12: i2c@b { reg = <0xb>; #address-cells = <1>; #size-cells = <0>; @@ -495,42 +495,42 @@ &gpio 60 GPIO_ACTIVE_HIGH &gpio 61 GPIO_ACTIVE_HIGH &gpio 54 GPIO_ACTIVE_HIGH>; idle-state = <0x8>; - i2c_sfp13: i2c_sfp13 { + i2c_sfp13: i2c@0 { reg = <0x0>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp14: i2c_sfp14 { + i2c_sfp14: i2c@1 { reg = <0x1>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp15: i2c_sfp15 { + i2c_sfp15: i2c@2 { reg = <0x2>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp16: i2c_sfp16 { + i2c_sfp16: i2c@3 { reg = <0x3>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp17: i2c_sfp17 { + i2c_sfp17: i2c@4 { reg = <0x4>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp18: i2c_sfp18 { + i2c_sfp18: i2c@5 { reg = <0x5>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp19: i2c_sfp19 { + i2c_sfp19: i2c@6 { reg = <0x6>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp20: i2c_sfp20 { + i2c_sfp20: i2c@7 { reg = <0x7>; #address-cells = <1>; #size-cells = <0>; From patchwork Mon Apr 1 15:37:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 835BDCD128D for ; Mon, 1 Apr 2024 15:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gmdmhw8b6y+Y6QiWoryUMUGOoMUlBj6hL/DTBqNt2Bo=; b=WNz/wdMsF3UnXU Ag4hVylFDuGm7tAW7RIe2GhzrvHMp9+lXjDXNrZnhIPBMmdWgIN8D/lTJ7s7wWOsMI+7TcPPt+nYs 1l3VeShmywW50oVN+MQdFyZqTaIGwnXHMSj6dXqJM+dO3YhfXR8NruRgOS8mpVQwZ3zhk4F7L+Wmw UyhuEWjoEW0QLtxtFuoeFuIun95ggYWToYEtQhHGPUiFuadYoIX4Fe9vfHTSaMLpIl7MY/cqLjjJF E6lirOud6G06QTzj1PwyH796ViyvF9zzd7gfrC1sNwFwaCidMLrIOhT3/ge3xrI3+w9KynwDhBbUX je0aJ6lObeMjdnK+QTZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjd-00000008Ctn-1Dae; Mon, 01 Apr 2024 15:38:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjZ-00000008CrK-019k for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 29A3360D2F; Mon, 1 Apr 2024 15:38:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B917C43390; Mon, 1 Apr 2024 15:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985883; bh=7q2xemqspPBXGqChYMZhCMJo+TfcjIhLABlWs+4+z6c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m/7RV7tnvuRxXD/7aC0U0dHeA3MOsEZGaehhbvz8of2m2cvadYZRe6b2NkUEk1iLz dMUcov0ZQG5B0J9/VTBI7cPuzWfsx5QxkS9I+EdJsYhWFx/38rZIeKcbHf07RbGjqN GCmzV8xW8cyo8xw/3UyDdwvc5iVzG3JkilY4VOT0oiNoJHZ1BIHkYp/40RLPi/ZyD6 CeczHEIedCrwO7nZ5NM0RMz499G+B+RFOeai7MOLp9H4yFlhmiTIhSU5NrDFmfe1rj P0oH4V7EbQC1JInpiGDJea7H6M8EalyPR3hQiK5E7ggWIkC27aHYabK2zQX+maSczt x89CId9+14dGw== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/10] arm64: dts: microchip: sparx5_pcb135: add missing I2C mux unit addresses Date: Mon, 1 Apr 2024 17:37:34 +0200 Message-Id: <20240401153740.123978-4-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083805_130064_FE4CDBB5 X-CRM114-Status: GOOD ( 10.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The children of I2C mux should be named "i2c", according to DT schema and bindings, and they should have unit address. This fixes dtbs_check warnings like: sparx5_pcb135.dtb: i2c0-imux@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c_sfp1', 'i2c_sfp2', 'i2c_sfp3', 'i2c_sfp4' were unexpected) and dtc W=1 warnings: sparx5_pcb135_board.dtsi:172.23-180.4: Warning (simple_bus_reg): /axi@600000000/sfp-eth60: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index 82ce007d9959..bf51a6e11cf1 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -146,22 +146,22 @@ &i2c0_imux { pinctrl-2 = <&i2cmux_s31>; pinctrl-3 = <&i2cmux_s32>; pinctrl-4 = <&i2cmux_pins_i>; - i2c_sfp1: i2c_sfp1 { + i2c_sfp1: i2c@0 { reg = <0x0>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp2: i2c_sfp2 { + i2c_sfp2: i2c@1 { reg = <0x1>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp3: i2c_sfp3 { + i2c_sfp3: i2c@2 { reg = <0x2>; #address-cells = <1>; #size-cells = <0>; }; - i2c_sfp4: i2c_sfp4 { + i2c_sfp4: i2c@3 { reg = <0x3>; #address-cells = <1>; #size-cells = <0>; From patchwork Mon Apr 1 15:37:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1381CD128D for ; Mon, 1 Apr 2024 15:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OU5tw+MzT/rAiv9gCObAUeMA5QYuvRX17fc/QVa4NmE=; b=PiFULlABw/1srX VapxSUDpwXhWNP7xiRdKW0Jo8mk3NKL2o1RLEo1Jiu+KjQnYjflK6UM2VB8nsLsjQwma/cLsn2Bcg jbQ+jJqofWhe/swntfjJeEL6HYRwi0JDNa21xi5fuAghz9rldSu4o9cBfYnJ79Jcsr7DOWBi1BSOJ U1rQLLenfu3Yd5TBQQYc+eZe/bO7tYuQeZLqVZbmI7foAmAROkPSvYuqdnY/xIwOj444RMBFDYfAP LSDEBitq8m8Hm5PX7WdtvVHDhJB8lojqcX9yo2iAXwbvzjXnVV2l9JHprOy9rp69c7kPdkS09+Fzw Fy+qRw7mWbH64tx2qCLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjk-00000008Cy1-2e1s; Mon, 01 Apr 2024 15:38:16 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJje-00000008Ctu-3sim for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14277CE12D7; Mon, 1 Apr 2024 15:38:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43C82C433C7; Mon, 1 Apr 2024 15:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985888; bh=1zF10p+hIOOzeGD/w2eifp2BzHYMkKJyko8PrOd/szw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GFRKQa4Iy1sbx3ViCQAhaFMKGofoa6+TvIEnAgQixYAsBa3o3lLfERIpvzN1M/j2U hHzws3RAYU0QPpKLDLfy+tL2ImIaQNqKH7LzrYnFbhgP5yFSgoDvf33gKPJWHQiZXE Pwd8fVW4G93VFw0h8wNmXNbkwZZ9/1Yx9DHUMEZuEu+uLyxWGaj9pujbaOu08cpm4f 7RBevZ72M6Pyj3Hqr7p1416ZHnXLquTLYu7k2cytMxvxIIZF7Uu/B6MI+IemI2XOxB +e/3SsOZtqeuhyqM4DDTiEIkLXVU+9ISvZvJJpqLz30QRy2P7X6U1BGtsrgKBQjapx XjvsK5ixJXNeg== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C mux node name with bindings Date: Mon, 1 Apr 2024 17:37:35 +0200 Message-Id: <20240401153740.123978-5-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083812_920313_515C675F X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DT schema expects node names to match certain. This fixes dtbs_check warnings like: sparx5_pcb134_emmc.dtb: i2c0-emux@0: $nodename:0: 'i2c0-emux@0' does not match '^(i2c-?)?mux' and dtc W=1 warnings: sparx5_pcb134_board.dtsi:398.25-403.4: Warning (unique_unit_address_if_enabled): /axi@600000000/i2c0-imux@0: duplicate unit-address (also used in node /axi@600000000/i2c0-emux@0) Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index e816e6e9d62d..cafec6ef0d0f 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -395,13 +395,13 @@ i2cmux_11: i2cmux-11-pins { }; &axi { - i2c0_imux: i2c0-imux@0 { + i2c0_imux: i2c-mux-0 { compatible = "i2c-mux-pinctrl"; #address-cells = <1>; #size-cells = <0>; i2c-parent = <&i2c0>; }; - i2c0_emux: i2c0-emux@0 { + i2c0_emux: i2c-mux-1 { compatible = "i2c-mux-gpio"; #address-cells = <1>; #size-cells = <0>; From patchwork Mon Apr 1 15:37:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE021CD1288 for ; Mon, 1 Apr 2024 15:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EhUyQb8H8zl1m24dsXgPCib01z/2TIP82wuAEmi/9+k=; b=0iVGxhDBbX8iv+ VilSahiQMHA+vjauLVGRcHiLWEUJpoMBLfLNl+iyuke9fFK5p6CmvAZVeXiwmR/LJWR7dZgKOatWm La+0rNeTmDo1bRBHFs8CuI2S2//cXrl9qWOA2wLIs5vSHLeMEGFoNcLQysaTtC/WiVcW3autRKzoX zkjlWAM6tbhjS2S6Yea9vEzScvzgSKf8Zc55deeMqQJioBtoYTfia9kCvYpWPwnLeT89LNno0lGCN GmGDXiy12tMZg859F2rBAPK3K0MvQz3/o6SkGGtNogruoHJG7ZQU72EcsJBhotbX+w4Bi0FL16oh3 /NXWw1/KqisYZs5TO6PA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjl-00000008Cys-2G3z; Mon, 01 Apr 2024 15:38:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjh-00000008CwE-3ciU for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4485360D2B; Mon, 1 Apr 2024 15:38:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2531C43394; Mon, 1 Apr 2024 15:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985892; bh=e40uKtgwHOMJ0qXjF39L3KNX2tZQf8rMLmYjexZGlmw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W/4h5berDLFQhREHk0G1pfczxuCosz+Caikz+K/Lfgm13EOqeHocM14udPObtukXs 0XqUyaGqREgDrnaVMIMeg7fQ5a8IRooGglnxgEf+xB6gBFsXiFHXdk8VqtLMNTkPrr Q7/H5BLHpgFY+CP952O1SfjBT14TbRMgEEDoB31Qvt8WJzQTZB8eTnH1meUZvRL9I3 dZqIyyV695SGkWCoQCUAQJqlsGGXT9AuOjlPbKovHoMfNnBVOyGCy7ZbzBoF7/UQXY 4NQ+n+FOdYY+IsdDEhBp8oUK3HodwhBmhn1Kp+KHKT7NgJI/ReUFTq0xB8gPQpvhc+ Z7624yzBr6LzA== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/10] arm64: dts: microchip: sparx5_pcb135: align I2C mux node name with bindings Date: Mon, 1 Apr 2024 17:37:36 +0200 Message-Id: <20240401153740.123978-6-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083813_971193_D4333F22 X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DT schema expects node names to match certain. This fixes dtbs_check warnings like: sparx5_pcb135_emmc.dtb: i2c0-imux@0: $nodename:0: 'i2c0-imux@0' does not match '^(i2c-?)?mux' and dtc W=1 warnings: sparx5_pcb135_board.dtsi:132.25-137.4: Warning (simple_bus_reg): /axi@600000000/i2c0-imux@0: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index bf51a6e11cf1..860975ffe0a1 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -129,7 +129,7 @@ &sgpio2 { }; &axi { - i2c0_imux: i2c0-imux@0 { + i2c0_imux: i2c-mux { compatible = "i2c-mux-pinctrl"; #address-cells = <1>; #size-cells = <0>; From patchwork Mon Apr 1 15:37:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5421ECD1288 for ; Mon, 1 Apr 2024 15:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fvk23AUQweQPCE8mvOqc7D2kdsTdn+XeGIs5BXIwgCw=; b=UxtMW7elGwUJEx gBWo8/5Dn0Xg8jsuY7E4RxkAmIYXFPNf7ONFztRC4/MbqI1KS6tqWdqETUzg2ocNClSbaBSyaiI81 Eg2r/eEXBQCQALrYYXa+0t4+C0OMPJ6apP0v3E2+AmCi90JVhKtzmWX/ZzqTvHWr41hu3wwn1mSGr x5NMhpuGAA7OtZ55BHLY/S6D53spSX3o4/H4s5o2grMSNqUKB1WxjOWwdXy15XOKDkuUGwbmFIt5Y yCNTXiXU8On3peakl43cHyb45bl1ZKbcyZRlQllG9I4dStT259P7bTqM/r1GlyfSoNn9iWSzsnSa5 rRJRwZ/zzSn4AHry/GLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjr-00000008D3y-1tGF; Mon, 01 Apr 2024 15:38:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjo-00000008D0S-0XWi for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B602C60D38; Mon, 1 Apr 2024 15:38:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6050EC43330; Mon, 1 Apr 2024 15:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985898; bh=bFekDkMdo5A/5uBEI0URtEounaYqxTaB5l4vU4Q1/ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=funiyn1hYmQMS8dfm1Ls9rGjlEceKFrx+AC7UVx+tWvmfXOSL11/P3OdrrjVCgHwc 3dNnl3cIrD8dk2ymWnTbFAXSlrWNY1lNBv1T8CuJguMYQt7sNP+mU2hxDAGI2Yxqtr oHkwet2aUFtJUUOZJRGrej/5QmSxdpqBGfxCiKm8iUUWRoU+ro6cemS5TmJcewjcQv XwanzGtCra6GNPILVLzKM5JEQBq4JyKtmIOKUqBc9MrtpOkCcPBMQluNxShG6okBzO EvvEbqJSor1o6IFtjNo0VEmUFMt7Atv30alU/TXcGVl6vD/i9Ol/5J3aldjfVMpBpo fhDStO7WMcksQ== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 07/10] arm64: dts: microchip: sparx5_pcb134: drop LED unit addresses Date: Mon, 1 Apr 2024 17:37:37 +0200 Message-Id: <20240401153740.123978-7-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083820_358164_572B9108 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GPIO leds should not have unit addresses (no "reg" property), as reported by dtc W=1 warnings: sparx5_pcb134_board.dtsi:18.9-21.5: Warning (unit_address_vs_reg): /leds/led@0: node has a unit name, but no reg or ranges property Signed-off-by: Krzysztof Kozlowski --- .../dts/microchip/sparx5_pcb134_board.dtsi | 96 +++++++++---------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index cafec6ef0d0f..f165a409bc1d 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -15,234 +15,234 @@ gpio-restart { leds { compatible = "gpio-leds"; - led@0 { + led-0 { label = "twr0:green"; gpios = <&sgpio_out0 8 0 GPIO_ACTIVE_LOW>; }; - led@1 { + led-1 { label = "twr0:yellow"; gpios = <&sgpio_out0 8 1 GPIO_ACTIVE_LOW>; }; - led@2 { + led-2 { label = "twr1:green"; gpios = <&sgpio_out0 9 0 GPIO_ACTIVE_LOW>; }; - led@3 { + led-3 { label = "twr1:yellow"; gpios = <&sgpio_out0 9 1 GPIO_ACTIVE_LOW>; }; - led@4 { + led-4 { label = "twr2:green"; gpios = <&sgpio_out0 10 0 GPIO_ACTIVE_LOW>; }; - led@5 { + led-5 { label = "twr2:yellow"; gpios = <&sgpio_out0 10 1 GPIO_ACTIVE_LOW>; }; - led@6 { + led-6 { label = "twr3:green"; gpios = <&sgpio_out0 11 0 GPIO_ACTIVE_LOW>; }; - led@7 { + led-7 { label = "twr3:yellow"; gpios = <&sgpio_out0 11 1 GPIO_ACTIVE_LOW>; }; - led@8 { + led-8 { label = "eth12:green"; gpios = <&sgpio_out0 12 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@9 { + led-9 { label = "eth12:yellow"; gpios = <&sgpio_out0 12 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@10 { + led-10 { label = "eth13:green"; gpios = <&sgpio_out0 13 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@11 { + led-11 { label = "eth13:yellow"; gpios = <&sgpio_out0 13 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@12 { + led-12 { label = "eth14:green"; gpios = <&sgpio_out0 14 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@13 { + led-13 { label = "eth14:yellow"; gpios = <&sgpio_out0 14 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@14 { + led-14 { label = "eth15:green"; gpios = <&sgpio_out0 15 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@15 { + led-15 { label = "eth15:yellow"; gpios = <&sgpio_out0 15 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@16 { + led-16 { label = "eth48:green"; gpios = <&sgpio_out1 16 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@17 { + led-17 { label = "eth48:yellow"; gpios = <&sgpio_out1 16 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@18 { + led-18 { label = "eth49:green"; gpios = <&sgpio_out1 17 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@19 { + led-19 { label = "eth49:yellow"; gpios = <&sgpio_out1 17 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@20 { + led-20 { label = "eth50:green"; gpios = <&sgpio_out1 18 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@21 { + led-21 { label = "eth50:yellow"; gpios = <&sgpio_out1 18 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@22 { + led-22 { label = "eth51:green"; gpios = <&sgpio_out1 19 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@23 { + led-23 { label = "eth51:yellow"; gpios = <&sgpio_out1 19 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@24 { + led-24 { label = "eth52:green"; gpios = <&sgpio_out1 20 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@25 { + led-25 { label = "eth52:yellow"; gpios = <&sgpio_out1 20 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@26 { + led-26 { label = "eth53:green"; gpios = <&sgpio_out1 21 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@27 { + led-27 { label = "eth53:yellow"; gpios = <&sgpio_out1 21 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@28 { + led-28 { label = "eth54:green"; gpios = <&sgpio_out1 22 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@29 { + led-29 { label = "eth54:yellow"; gpios = <&sgpio_out1 22 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@30 { + led-30 { label = "eth55:green"; gpios = <&sgpio_out1 23 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@31 { + led-31 { label = "eth55:yellow"; gpios = <&sgpio_out1 23 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@32 { + led-32 { label = "eth56:green"; gpios = <&sgpio_out1 24 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@33 { + led-33 { label = "eth56:yellow"; gpios = <&sgpio_out1 24 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@34 { + led-34 { label = "eth57:green"; gpios = <&sgpio_out1 25 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@35 { + led-35 { label = "eth57:yellow"; gpios = <&sgpio_out1 25 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@36 { + led-36 { label = "eth58:green"; gpios = <&sgpio_out1 26 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@37 { + led-37 { label = "eth58:yellow"; gpios = <&sgpio_out1 26 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@38 { + led-38 { label = "eth59:green"; gpios = <&sgpio_out1 27 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@39 { + led-39 { label = "eth59:yellow"; gpios = <&sgpio_out1 27 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@40 { + led-40 { label = "eth60:green"; gpios = <&sgpio_out1 28 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@41 { + led-41 { label = "eth60:yellow"; gpios = <&sgpio_out1 28 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@42 { + led-42 { label = "eth61:green"; gpios = <&sgpio_out1 29 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@43 { + led-43 { label = "eth61:yellow"; gpios = <&sgpio_out1 29 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@44 { + led-44 { label = "eth62:green"; gpios = <&sgpio_out1 30 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@45 { + led-45 { label = "eth62:yellow"; gpios = <&sgpio_out1 30 1 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@46 { + led-46 { label = "eth63:green"; gpios = <&sgpio_out1 31 0 GPIO_ACTIVE_HIGH>; default-state = "off"; }; - led@47 { + led-47 { label = "eth63:yellow"; gpios = <&sgpio_out1 31 1 GPIO_ACTIVE_HIGH>; default-state = "off"; From patchwork Mon Apr 1 15:37:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612853 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52622CD1288 for ; Mon, 1 Apr 2024 15:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wqLu0fChWZpgp5yU8LgBRIVH8jJ9dJrYc09rn25qhMg=; b=ZUkjcNeTN0M7N7 9K28bVDRITFgxOjRSsAZYISKJk1auE0YwLr05l/WEr2vOfxQRkZDWeFq5HcV/Tf3WuRJnST3QDgLS 7fsAfb97Pgc6em7SV/xVrJ+OPtXDywdmJY29C1iotpTfDQIacL5zBKrTLBnOK1wc5cj5bK2cCdJkQ uK007N9ZKGWZDZKG/YPjkYAnInGUnljeXXIRs2ATXAU1/1fhl1EiYfOlkI2PHjy/Th8ULgubSMs1o AxjJmPBLYGKf7dga80RWorZSN4gNzfXEmlzU0y1wv5qNo4oClCG62Ko4WLhNqJ+nSeuFIKbw7W0+g k4VMV2Talu/a8WHhOKRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJjw-00000008D8T-3plo; Mon, 01 Apr 2024 15:38:30 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJju-00000008D5l-1Tgq for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9D3A2CE12C9; Mon, 1 Apr 2024 15:38:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0807CC433C7; Mon, 1 Apr 2024 15:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985903; bh=aRw2iio3uiL4eDYVF2hmmTE3SOu9WI8o8O9ayQO3YVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o1hBbmB2kd+CsaCj2u+Mwi7lwFvMT3EwrQGoCICZ7z51Dap/xipIGqlpdmQ46hcPO 8Mpd7T5zehelMiO5cmFR0tjU4MGMm/N/8KmjwWsgOv2b42LmC65jXtNNSw/i7v+qXT oHN9AOSGPIGL10V79IoaTZZWL5Jc/Gduue9l370W/2Sb0H2YrFdSUKmieTjt5LoOMl krkUSKxPzictiJxThP8qTJlCM0CA/JX5+cq1QfRNzG5UCp1visoEPvQR34PwYxQNZl RRcdlqUtvlWzwkpIWIRAPK5HlR0fuAqwcFZYBca0kKttpN2gTBSoPaZXNeLoFd82K1 s1H3A//wntwhQ== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 08/10] arm64: dts: microchip: sparx5_pcb135: drop LED unit addresses Date: Mon, 1 Apr 2024 17:37:38 +0200 Message-Id: <20240401153740.123978-8-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083826_667925_FBE099F1 X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GPIO leds should not have unit addresses (no "reg" property), as reported by dtc W=1 warnings: sparx5_pcb135_board.dtsi:18.9-22.5: Warning (unit_address_vs_reg): /leds/led@0: node has a unit name, but no reg or ranges property Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/microchip/sparx5_pcb135_board.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index 860975ffe0a1..20016efb3656 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -15,42 +15,42 @@ gpio-restart { leds { compatible = "gpio-leds"; - led@0 { + led-0 { label = "eth60:yellow"; gpios = <&sgpio_out1 28 0 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@1 { + led-1 { label = "eth60:green"; gpios = <&sgpio_out1 28 1 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@2 { + led-2 { label = "eth61:yellow"; gpios = <&sgpio_out1 29 0 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@3 { + led-3 { label = "eth61:green"; gpios = <&sgpio_out1 29 1 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@4 { + led-4 { label = "eth62:yellow"; gpios = <&sgpio_out1 30 0 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@5 { + led-5 { label = "eth62:green"; gpios = <&sgpio_out1 30 1 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@6 { + led-6 { label = "eth63:yellow"; gpios = <&sgpio_out1 31 0 GPIO_ACTIVE_LOW>; default-state = "off"; }; - led@7 { + led-7 { label = "eth63:green"; gpios = <&sgpio_out1 31 1 GPIO_ACTIVE_LOW>; default-state = "off"; From patchwork Mon Apr 1 15:37:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612854 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C274ECD128D for ; Mon, 1 Apr 2024 15:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ujoDERPKpzMAM0MwchO4xF3yf3y/W6H3wv1gCTJaEE=; b=nvqb1ILoHzLIIr JdygP+qRUwkgf6omm8K5pNlK+yq7b/HNJcwEJjWTOIfJIAmKQSTbTl5qDRKvobHNT5eVqwV2V1uEI 4lWWHPkZSQYbxEa+FTdvipF/JOiBiYReGkGxxEP7y1NBZajfGBJRWmszekfCNaTDX49RCQ/dYKFFu sbmujWqEfmuGb8Htv1jeIhPPIS8FQAzEjSVXPqBi6vVsrz+NRhj3cULm98Un/WmS6KN1BsieiAcrR 8X0BBb54KJ3tp+VYuyqUje/RjQRZAqambSYOcjGRuTGpJkWR1UxhZIvJ/B/AB8fkCvp6tIUOaLyIH h06Lkge39/xRxGJNkZvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk7-00000008DEz-0LRA; Mon, 01 Apr 2024 15:38:39 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk5-00000008DDK-46sE for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Apr 2024 15:38:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=IJCsqArQ3YGdCuCDuTH+/jxUleXNfjHN49mfTD+G/zY=; b=Av2EoeideP/oqqFw4Myyr2YDZC 6zru0R6PZDKGV4EuDmCL4swyoTMkWgdW+WJBF1M3BUnekPsrYyvP9hMJBhSea/Qt2+VdTA9KxWdO7 +cU5gfmbgBltLr2GsdLS4WzSRHGt9AOwZ2aDOzdgY4xABhLIKktOXrbUdc4URoT1Rz4redPPf1XY1 wrLuSq0Hcos8wnhDtnJbXQrV8wrNTgJxE7AWMRyWVR6Bqlr1thbWx+83nJyBhnK2xd5aPqQHLO3Y0 QdskxFtt3iTZSMRM1v3vxe3iTl0KOwxlYpU0A2G9PVa/ewSA0qae7/U64p6t0UkLvAzSHbGunH16c SeSUYlXg==; Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk2-000000038q9-1e7d for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BEF1ACE0EB9; Mon, 1 Apr 2024 15:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 733B5C433A6; Mon, 1 Apr 2024 15:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985910; bh=aCit6vORDAYB870bYOiXT5ndGlqhSP/fqB0fbs8e4P8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nvCtQKXE8ZHNsVUuGOJRaM7sOvx5VVg+yyHmMZ9kkhIWh1IWHq5UKrBdigG6sks2X WLH60WjmwVHrb3BUQnmySGAHzuDBNG6Pl9bIFZDmc5H2D4XBenV68YNIk2y32z2lZQ DhI2or0xTlJXdD73Uv4/Rs4LlwzCz0dd/xjH185pmsBk90Zaw/+Eo7MYoDYmTUt4vY BI4gobZV/Jvhei8xhYYoAqK3AD/+JIL065ZlkUqaE6ohq+CLA3PGa8hDxjd83PJ/Pm N+rEAUUlPQS6ObspFYY6K5ztxZnAGboevD75NJQj/hlMTSjw/jWlTAW2mwzfvL0wC2 4jccThBFhXA1A== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 09/10] arm64: dts: microchip: sparx5_pcb134: drop duplicated NOR flash Date: Mon, 1 Apr 2024 17:37:39 +0200 Message-Id: <20240401153740.123978-9-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_163834_965445_6CC71943 X-CRM114-Status: GOOD ( 10.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Without checking in datasheet, assume device has only one SPI NOR flash, so code was duplicated. Fixes dtc W=1 warnings: sparx5_pcb134_board.dtsi:277.10-281.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware --- .../boot/dts/microchip/sparx5_pcb134_board.dtsi | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi index f165a409bc1d..dc7b59dfcb40 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi @@ -281,22 +281,6 @@ flash@0 { }; }; -&spi0 { - status = "okay"; - spi@0 { - compatible = "spi-mux"; - mux-controls = <&mux>; - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; /* CS0 */ - flash@9 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0x9>; /* SPI */ - }; - }; -}; - &sgpio0 { status = "okay"; microchip,sgpio-port-ranges = <8 15>; From patchwork Mon Apr 1 15:37:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13612855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04CCFCD128D for ; Mon, 1 Apr 2024 15:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PdcCSB0H9j9Qbu5PnN129eZwBjR6OAtU5zEWje89hW0=; b=tGXbTFUied4yY/ xqZcM5pDnBsMv58cxKWjBjB1VkaxZDvDx9Os4EYMb30MI24o79G97dl/2kXRMElJCLvkNmSQQXJJR dm70qMFOdFmH0W1TqDXdpamYcfaG3NEm0vE7CC7C8FAYuzCRQUo9QI8aZuGGkEz578rQ2Euq/nwt3 EJ4K7J969P7zwYkDDSwuXrNFy72AdHh7alv1vEJBALPXJkH+/NX4BvDO7kzOPrMJYSfchKnVO6m9/ W5HnVs6HXYNZdRVBPiaLEMzKBhLTyvTrvSHq6IoXx0BJ9jgyChegmpPW+8xIvNn0kejtsIj2o3cle gGiAAlySQOUyIkbfPSeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk8-00000008DFv-1b7B; Mon, 01 Apr 2024 15:38:40 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrJk5-00000008DCa-0wgi for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 15:38:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F6CCCE12C8; Mon, 1 Apr 2024 15:38:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81A64C433F1; Mon, 1 Apr 2024 15:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711985914; bh=JgLPnjcMi+cgOhiaoTMdhKoBzbHBbs/okfQQvGNTcdo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CjVuAT65buqs99kvAaD4vV94P1Z5W+QmUpw+nssp3dWlIHCTFraFjdqPWWxVQRGw3 m3lUXSpzMVIk6ozny/7UwF2viG+zgGQtd+fGPLA4vaqg1C+8iVV+7wt5MofHNXZwW4 CoL6sFuScW9fV+I+45WhBZ/yg3rRAjXCHJvyajrbeOtHlmFwdouhYy1fqGwDq8iTsW 7WBET5EkFWOoZujUtfi0s4NpRcp5vk93+WdHm443aqw0rK7OU1bS8fbman6M4eOc36 pp7Dp6yOI1+ieVWPUXOj4hAvphsLiK/zsHx34SDS2WWQNAE0WWu6EJk+ynNlsteIH1 jX7CX5Zq5WG6g== From: Krzysztof Kozlowski To: Conor Dooley , Nicolas Ferre , Claudiu Beznea , Rob Herring , Krzysztof Kozlowski , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Bjarni Jonasson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 10/10] arm64: dts: microchip: sparx5_pcb135: drop duplicated NOR flash Date: Mon, 1 Apr 2024 17:37:40 +0200 Message-Id: <20240401153740.123978-10-krzk@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240401153740.123978-1-krzk@kernel.org> References: <20240401153740.123978-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_083837_508116_47F5C360 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since beginning the DTS extended the SPI0 in two places adding two SPI muxes, each with same SPI NOR flash. Both used exactly the same chip-selects, so this was clearly buggy code. Without checking in datasheet, assume device has only one SPI NOR flash, so code was duplicated. Fixes dtc W=1 warnings: sparx5_pcb135_board.dtsi:92.10-96.4: Warning (unique_unit_address_if_enabled): /axi@600000000/spi@600104000/flash@0: duplicate unit-address (also used in node /axi@600000000/spi@600104000/spi@0) Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware --- .../boot/dts/microchip/sparx5_pcb135_board.dtsi | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi index 20016efb3656..d64e642e3873 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi @@ -96,22 +96,6 @@ flash@0 { }; }; -&spi0 { - status = "okay"; - spi@0 { - compatible = "spi-mux"; - mux-controls = <&mux>; - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; /* CS0 */ - flash@9 { - compatible = "jedec,spi-nor"; - spi-max-frequency = <8000000>; - reg = <0x9>; /* SPI */ - }; - }; -}; - &sgpio1 { status = "okay"; microchip,sgpio-port-ranges = <24 31>;