From patchwork Mon Apr 1 22:25:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B7E1CD128A for ; Mon, 1 Apr 2024 22:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UITZmahNhtKM1A4zLuVUbK9n8arbbfDbI3CPlQAEEkQ=; b=yKYiNJNddNj7kGbWbM3n+qsuf8 ZZYmGix/3/r0RqLCdL/zerwpabvtHoto6vIRZQVr5hoUCMRIvhr4G9A8T1xBoCH+6HV3UwiU0ACIB 32E64kZoHB5m4Nj43PqOKu8AEcQyJC2OiqxpO+J7nr2dME8H9DN+9r2aO93dun0V/KdYY2VTA1QLh W5agt6WLFJKxyWlH+UbHT8yoicQAFGGdCMWCuhI2lDiF3h9RKPGeRqUQgQzBtrvri/PQxFtOor37C /B24HqixyeFxHhZsDW2Sw3G7b6mS2un3e4WvRlt4PfMz6FHVu3ZHhnyabUs+j49jD/o6Mk3tZR/7P EcY5ukqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKm-000000091wf-0xLC; Mon, 01 Apr 2024 22:40:56 +0000 Received: from mail-dbaeur03on20701.outbound.protection.outlook.com ([2a01:111:f403:260d::701] helo=EUR03-DBA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKi-000000091uh-454M for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:40:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPsT9cS8Fx5z5udGF4N4FbvCCNV0FQg1oNDE8r7yxDJFp7GV6tqbkpipL+3alJ/ZM/0XBKbik2Thl2gqg9nk21rEMtZnIVZC+5Zfeu2N8/vmF0nU6Ujb7WqP9csTASH6MLct9wtgyx51DvDsgSR0IVa1GzHotGovPA7Qnh+k3vMyhLvqJoW/5G6dAA9hRWSOiTgQ960xS23S+tZM9ZiDrqF10cvsHgNVotzJXXWIlXmycdBbeI0XEXI249rAVH2fR7qor3LIQdfAUdiMIaDLiFmPwiHHYrYJ0MuYyzB+Ntv7ITdiAXj5Xk1eBJTDxXsIddbR+3zf/V1Z9aTfxM1bVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R53HfYRzJhX3GkT5gsG/BDOMnsWSRBgL276IoWfmll8=; b=l5AeCaLsa0Fpke3lI61oz8WJnnm/oAkzo3lV4AuNxq0dZYOUVf8fSAr6pyWPv8YFBLM9xYjLjpPwpKNXwiGR9zujlxKD/fOrRly/XXvqUuQAiyZBMiJhJwXW7OCjxvrbcFxGVri0WUkvNu2NSyPv8QrxQgwGoLWuxRRRANi7Y7zYVFZfyQlQsQimULfyK/7GzpGvhcjhiMtfNi2wX2jlUS8gtT7nQbddTzdiXyMCNHu++mV8u4Mpmqovl1Pb8YDiKZTddw6/vRJvtaf1/Ok/oWvCTB7SjOhwbdkEoNg1MklEGhq6OWk8QDraYtIy8mhTD3lHh/QCdefb+TQBzWH5hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R53HfYRzJhX3GkT5gsG/BDOMnsWSRBgL276IoWfmll8=; b=TMaUFGRfrGeQqmN8ln3q/TkfLIr8SO2T1eMERVhXxkAXqfcz8mFxqzV1FC8V+9o0usuWCau/oV9EBpUDL2ArvAy8l8ZYrdFN2ZIMPpSZuRuhw5yMBdLgsf9LUxU3THG1NqkeqKU9EyYUBDeoWOMdo5CrWEFS1N1vle6Yr3xwGhs= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:39 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:39 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:03 -0400 Subject: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices Message-Id: <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=3222; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=x/POWQ0U8GrRyPnu2nIcIHKAzPh8JAVtPHA132rEFXk=; b=AzmAY3DZfuLNjebMscfEXDcTc747tITTcwb6PKjovwlB6FEUmTl9R8dcnDfxoj1uscznH/Fu3 R17n9BWyN5TA6ZTNPqO0B6Z1Bst+MGGaVWpcC1h/MO3vFW9imQTizVG X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1FQiqhhMhNjpN1Q7lqAjrgR3hiUJw/S8LXIw0EbbABOMJQzSehEdjm0TNkzyMiAUoSarPJcTKPiH+dA+qrSjp6a3IIdhN37Y90DAiuFzHEc41c/EtwBetirk2BdDo37jpaop9SeYhUoqToDqtGibS33IJJb4XkC0XKty1nXJQgX0U+cp7/az1RUMvoIhl/nHSzfzalvtvUKBwcvwHFTunsxVD3qhDt0WBE/26vuvt6S+KL9ruTt0YvFRDqgOWrIOD89zLkN6sS1cq1cD9di/UhOk8zKdfUBXVbgbhgOHfvwaEjcgNrQK732l29yFN4o1lSDUqJTQ8Z08HYlu39MEydJ4YKF4wytupT36W8BDjJCfPtVqDRKh73OROqLqIWHY9vIa+APxrGT1APrpafIz4ba8kLYs23TUvCNupolvP9FS4drmCSwK3ulfPf/ntui+1CRhKFHaUOwKj+X5fziI0YHWIr8k5QqpT/5jG3w2j37ASiQiRAFMA1wQegEiY/UBVBHEA8cwbJVJnyvPDg+9lx5FxXq1GvXcWZjQneb0WQwg7RvsI9IIIHJCgomh7Z1SQ6UuSj1WcWEhYbIdtKFZn+U8nBCc3fmiScK6aKLFNSEvOWX8pp0UwtVVgZ9MelatKSW1A5bPf2wP2/HIep3jyd+FE1gGvzzgaPWxt2D3w+xWLKWN4pYhXsRRUvUslTLQix6wgq2g0vwhHVkckGGQFJDfAeYzS6SKXvJRUWQSDjs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?exAsPjv0nvhOQKCmTrSPZmXQzrE6?= =?utf-8?q?PL7AoWv0HAkGiEgD5fn+tdO3ZcTvgAh8gxcUSQX1DHzzVTetUqhsNaxwfIZEKIXII?= =?utf-8?q?QM45a3sZbrGPOLfXsoj7bsNtx86CMzU9/jEaYSLeOXkp9ixSDlQrQpKqov3GNH//4?= =?utf-8?q?3NID+sjwqQqrWfs9HAxZhw0liKaR2ZTOUDAsCWCYlx23/+iiWJ73AJlEb3w5NadZW?= =?utf-8?q?MZ9eoh8koAtDCKpNDQto3NtKXygcNyAbDXB9B7nlxhsGfXms4D/is/JGMZKRcoFQv?= =?utf-8?q?gYoTxbhrEG8rfPw5hXeJ/Nz2OVeuU8XIEjTuZB40vb9YmIgjHRPX/PsuzBdlI7TDF?= =?utf-8?q?U17yRK7TiUqJGAQ9YwnXcDR8h96RSOsnLaCyXJ5kRBrXcRaNIbEyJUAQAHDyqefMa?= =?utf-8?q?eQLQvUJNz/Dtmpv00VT5ZIDKpKOvtPq4Ko66w2xZiV/zZgvoeUckbeaVN5mhAZPF0?= =?utf-8?q?wJ0GflAYifta6lHDr53KqUtW8bmtTAap9SeG0oBqQlC27xs+4UXN5oySRzJ7UDI3H?= =?utf-8?q?K0xQCxOYNE6QdFGP84o1ai/BGj6HjebsBYXHRHvFSYteJOA+a3PH09Y8+TgxWrTLp?= =?utf-8?q?NIloURzlK3N5Ja/NDG1NthtamFC8nBL8/Vm/Lzj/XpZjrbaQGqEoPTpiebNeMTzVR?= =?utf-8?q?FZPwzXuGeipvqOSxoQUkVfhWfTazpdGrkPTBtkJrL5vfWxsTmo2UClQmJ3S7saFVq?= =?utf-8?q?NEdehq2Hx/dk3pOucahIO3iKmzArHqM4l3eRHnERJjtoexfSxQ53nDvvCfzHF/bWH?= =?utf-8?q?HsRha6ndOMNcuoyFFMz6yGSd/qae4qhcqUsKH9vaF9Bwq+t0WQPz6jsnEV/NHbu+7?= =?utf-8?q?gbf2CD76MTOPXlha+LFYNjJzAqpegrxCClOjE77TxvJ0BmwxkiAaDCE5CMRsZ89/c?= =?utf-8?q?KgE0+aPjpDMgr1vyshzETXwBu6WM7zSgU7ZfVjAJBU3dw1DURlVs7eyHxMIyXEMN0?= =?utf-8?q?R7hT2vGjNEPVCMOWsMbi/nCefhKr78UmBN4hCzgkovX7Or0awWgPMey7egbLspRn8?= =?utf-8?q?+XzFO10uGLCD2xftg+xNvs4LqJAUmQeQhy42SX8XFsTTUGGXiniMQGLFUqXRJeepT?= =?utf-8?q?Lvq62P8MC4zNyFF3D16tdrbysnQdQ7orxXmGK4pCFzw4iWMb32SuoPylfDV+ClPS6?= =?utf-8?q?ObRRl1BTL6nP3zQMInfdsmwacka4EnGb6PhgbiQh6WuydVsJglxYIEt3J2I96Puaw?= =?utf-8?q?EyPvdSoeWqckIwVZ5qUkchzAlzTdQ/Im0Yb/+Wcpj89ns2KvRzR06rxCYDKzOdQyb?= =?utf-8?q?RZN/TXquLA4gLeOqsO6xpsk8kXKt2wF9W7lxs4mUjNOtr9YG+z/cGyqJWbZessaiK?= =?utf-8?q?91wJq3znsaP9o5qhFUdiqMCPWR8+bRsKWzZpV7gCmJJhedvHcXtfjKNgLMar+aXes?= =?utf-8?q?ozpZom9siQE94LA5sjG3v+tgPQcMO8U4PcgHs6jVoIbBzAikFgA0n+kavwSNsF/pg?= =?utf-8?q?LpaM2SJ5omDa5XwhzHjtOtWDPW+5DEjdV8ubdKDneqp3eFUrKikJo4SA=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea7c370d-2f9c-4679-e919-08dc529aa8e1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:39.2519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3iEz77DGTp4TIsNJ9TenXo8PBYZXuJDf1aIpALEPTLFd039q8Z5+9NrbBUbKZZWdFwJmnIEb2mcNPOdHrKDFEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154053_040225_BB6B60B0 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org lpcg's arg0 should use clock indices instead of index. pwm0_lpcg: clock-controller@5d400000 { ... // Col1 Col2 clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 0 0 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 1 1 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 2 4 <&lsio_bus_clk>, // 3 5 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; // 4 6 clock-indices = , , , , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. pwm1 { .... clocks = <&pwm1_lpcg 4>, <&pwm1_lpcg 1>; ^^ ^^ should be: clocks = <&pwm1_lpcg IMX_LPCG_CLK_6>, <&pwm1_lpcg IMX_LPCG_CLK_1>; }; Arg0 is divided by 4 in lpcg driver, so index 0 and 1 will be get by pwm driver, which are same as IMX_LPCG_CLK_6 and IMX_LPCG_CLK_1. Even it can work, but code logic is wrong. Fixed it by use correct indices. Cc: stable@vger.kernel.org Fixes: 23fa99b205ea ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi index 7e510b21bbac5..764c1a08e3b11 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi @@ -25,8 +25,8 @@ lsio_pwm0: pwm@5d000000 { compatible = "fsl,imx27-pwm"; reg = <0x5d000000 0x10000>; clock-names = "ipg", "per"; - clocks = <&pwm0_lpcg 4>, - <&pwm0_lpcg 1>; + clocks = <&pwm0_lpcg IMX_LPCG_CLK_6>, + <&pwm0_lpcg IMX_LPCG_CLK_1>; assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; #pwm-cells = <3>; @@ -38,8 +38,8 @@ lsio_pwm1: pwm@5d010000 { compatible = "fsl,imx27-pwm"; reg = <0x5d010000 0x10000>; clock-names = "ipg", "per"; - clocks = <&pwm1_lpcg 4>, - <&pwm1_lpcg 1>; + clocks = <&pwm1_lpcg IMX_LPCG_CLK_6>, + <&pwm1_lpcg IMX_LPCG_CLK_1>; assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; #pwm-cells = <3>; @@ -51,8 +51,8 @@ lsio_pwm2: pwm@5d020000 { compatible = "fsl,imx27-pwm"; reg = <0x5d020000 0x10000>; clock-names = "ipg", "per"; - clocks = <&pwm2_lpcg 4>, - <&pwm2_lpcg 1>; + clocks = <&pwm2_lpcg IMX_LPCG_CLK_6>, + <&pwm2_lpcg IMX_LPCG_CLK_1>; assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; #pwm-cells = <3>; @@ -64,8 +64,8 @@ lsio_pwm3: pwm@5d030000 { compatible = "fsl,imx27-pwm"; reg = <0x5d030000 0x10000>; clock-names = "ipg", "per"; - clocks = <&pwm3_lpcg 4>, - <&pwm3_lpcg 1>; + clocks = <&pwm3_lpcg IMX_LPCG_CLK_6>, + <&pwm3_lpcg IMX_LPCG_CLK_1>; assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; #pwm-cells = <3>; From patchwork Mon Apr 1 22:25:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613074 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01970CD128A for ; Mon, 1 Apr 2024 22:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=B0GQoHoIip7SsJxo8IiInYEcvfHyYHvq68FTh6w4KyA=; b=jJUvLEwUKDybg04WJQgEXmu+id EW0hdHdcwicibJPG2OppT40rgK3MVjyfNgtl5hlHP7gDnORqV5UPx+VvKF8TECWtN6gyPU01wQ9Kh RSO3+OXAhmDvpAq0rDorqfx83tH9mlhSkVBU8sqitFe3yA6eovFnQ+uokUGULV3GWJ5KmH2dMHHqF uAznY1i3IG+dkFJJ/cnrPHHjGRwceYh7DlMEXdwdEFJOwkdZp6IW4qPU+Vupw2oiFyk2MQhu2MCcN K253Zy5QOHEazsRBejSGpphG6yi2jfotfCJBfcHBLbTfW+SmLw+PZDPiXI4FHEiyZWsYE4JwKf664 U67/CshQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKJ-000000091qg-1JlP; Mon, 01 Apr 2024 22:40:27 +0000 Received: from mail-am6eur05on20701.outbound.protection.outlook.com ([2a01:111:f403:2612::701] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKF-000000091nn-0BOl for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:40:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWKF4lM7YH/GDXAmLB0v2/uyahBCswE5oQJUKlirWtrS+Uob176NMFR/bMsTPPxNlIC4TLj3RGoubxNNTMXrCbMz/Bl2UIOXs6ej0IBqltTMRqlwdT3ol72N8QjnUYj4vq4yb+v+wE+NtwpNXOLtusrZrVFkFMvGVyWXnqeVhvc/ZvqKZGT0l+NcOfcSXbBev+LzwntiLQyZ6WQjkAaO8K6Ww5JF+uL/oI2lb5NnkObT6dL4ywvboSOB/xjioGKPkzvpojJWr72/Y4H+5O2v6D2Da5N6H2kwDjFYKApC8jkGPBlpFxbrIp2nu9bUdteYDCfkFPWNcWzQ5Sfr388scQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sgeaJ4Pw2vjEI+nYH49zTPm+XjL910/96N1mkwiyItk=; b=V1FLe+0UpTdfG9SSz9pjjyLizMDbSclP74r8biq1AxXoV5D+teZ0Kn8F0XVyJBuJkUWU2bzXhR6X8ilRj7WjIqtmFo7uOjghmP77LAMwtteVC2NbaOGgl/tLEmLlP7jzMWVSE88f6LEhGSnWBPaVzIJRHg5rPmI6vBjT70ND7r4P43DTIu1LWvgd5pU3BnIerFAziDJ8FxeNqNTK3d7qv7pYMZce2OvM43CrPzIjEvumTDuE5b5qh1EFYtWxGXNUBhT3cDJTFBkJDTvdpAOsf4S2X1+yNlOuqPwUav0J1ZklCTgmvM66kBLT/U3WFiu7BRXdKQDR4OCMs+dT3695Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sgeaJ4Pw2vjEI+nYH49zTPm+XjL910/96N1mkwiyItk=; b=clrY7cnkjFvUKlDvu4R37AP9lMIexL9SwJBHiXA5ie9LwtjgFhVl3LjwOLXiRJTnh4tl5I/PqnGfVm5/U9jF4X0uUDvYC+sEoC8QABYytn8w12ZejZIU9ACitu//19qtavbul0WcQ9rnUHvSwQ8POq3Z7taG9begfnvA+0zbzCM= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:43 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:43 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:04 -0400 Subject: [PATCH 2/7] arm64: dts: imx8-ss-conn: fix usb lpcg indices Message-Id: <20240401-dts_fix-v1-2-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1863; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=15tZk+yX7OFHAMdf72JNYEbxz/+Meras9AxnabVdvAw=; b=8Ouh/fd9586+6wrzrlVRY+YjTbuep81ZZLENa6lkxlhVT8LNXOPq7Us8UceoO+XnMGjamC4Lu WxXfOTQ2zU8DH3SQ9bnwdZNBWbxwSaDjlzomq11vC3xYln6TWWFULF6 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y/TM3YozDBRbNPvNo+jzzzmY6NtzPGBq8S8/zuC8yCBS5QXb7qitqL8wyfNTz/LH3Pq5Sya98CEr4y6z1w7c532KjmI2KGY1UTCFM1QnalfkwUksNMUxE17Ry/a4kEMvvPpu7HESIOiOPgymxgOnoPGfcaS6SDMvc+9Px6yB69NP6pGzd7h41wU6xD9lOEfWXcJm+7/D4KbVyKP8I4Zm60coC393Lb4FxaA1I46wIOm3Xt4Kwc3w2VYeuPBkSJkyPFaer/Yk13dDrjZTL6XNIP0achtv89cnOCqg2PaixugRb4V87mv9yNrH7giMoYUknFKkVeBjx/mjXEGeWXsKUXg9nvgIuAlzNFeY4dtTu5kVB+iRyMbkMZOkBhjkaTiYCxNCw8+jCTkLNNvbejFQrVeu3ZD0E1ImUvFOBmOHoH6fcG6rvoU5KWOhkpz9tUPgUzlXM6u8EUqsRl7nWeuZmcK9kgbJor6adzKwEO3A3Rm4y+KpwBL4vjUaW2Sn++lr0g4PJIWACBRAGgqG3JkHoQoNEeoWcS5awesbwXiwVp8P9hg+gt10HRrFWYbkqrOtmBG8urYR+93sDCZ/QXyHJT0udNn6usmaQWW/0gWrBPF/k7/M3JMj9AZOn89g7M1tLQt/Mu5Wk5WCiMtAPxaERL5FJJ2pp3iaj+/dSR1AP2E81bUNUZa9QuXLgPmx5l8JoJ4MlFolChgwi1agOHY9TXesx2Wyno+USZ6/x734rjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Gjy3kBVFY2+bf3o1wZtRMGzrIL0r?= =?utf-8?q?3eVp/gZnjeEZGmQz9PE00etzFL09ZVZMAJ7oCWQCGadh1kAis5PPC1gUKQZbCDvss?= =?utf-8?q?inWPSQoOrV0nElBQMOg72w+lWLJ19b75NDh8+HuJaOz6YE9Bry4DLX2rj0aSfgknX?= =?utf-8?q?qTGtjYPMltrAw7Wpl5ehwfEzctXJz/+/m53rIvlXVqV6S89fZXq2H6uliHqObwtNk?= =?utf-8?q?T9O6W5IFRnuSVPd8XGdJFNQCzqI7foeDZNzE141eh4D8q9XE9PHLoEI6kgzyQzjr2?= =?utf-8?q?HYvQGddDbzts8LMX9CVGSBhSPjKlMlBHbDBNpC7d0TlppKHnEup/zuKevxh1obwSi?= =?utf-8?q?lScwmPL4gF3SOAkcHf4KnWvNL1ppHys9x+jYlrIbqJ82i2A1s3HYa7OE+E6iLkAu7?= =?utf-8?q?boPeeUbwkTbRsrsmqnzmRzrqRdAl2wjJ+X+e9lPVjZrmWq+LxIdPC4FmCqAkjM7pg?= =?utf-8?q?njMempNaAtVOBZD8+bgddaQ7dFQshQZENMNzUztqWqXxOLXs9AeNUcfDiF10jRsU+?= =?utf-8?q?df03oyTIKTgVXA8Fipc1ExxCD+kZ3TDYtn6D3W/oNhWrsZ3tgha9LAFXj74J7Su1L?= =?utf-8?q?J380FGmdzrP6Ia7cKIEAM1iMdDT+DEUkp1OVktrQLCQQI2FefPw6kfqbh+xoerneR?= =?utf-8?q?kdSzJdYNs5B77rLEdANj4hzwtbDuhUfRDiJJvEvGMGBOap1K0bf4Cng49lAfMv/K9?= =?utf-8?q?TMNS1ly/B8LtbzLpYss0ttNBE3bro0iW8IwrmM3OMFdbrtL+BMU0sWKKZpAJuiQtI?= =?utf-8?q?wEyuNH13lKe4YnlZsuMdA3BKtbzp7t5UlDi0Q+rNhe1/hWyJzIemPbK37CGafvJj5?= =?utf-8?q?6HrA/dqMGphFl3wJeZTufDc2myrCdjt+7OuHcBowXdEAlEudbVXutB9dI7p5bcc2Z?= =?utf-8?q?rqwMV+QVg8MSrfNiHkdatNWfhoxETDYdMYkRQwD/MI7NG00MU+AGJ22dxKW1BW3JO?= =?utf-8?q?IZwfrTSMuC+TZzshViuHpsODBANm7PUridPXIDdSOVk0SQFVSO/jH1fak4PsAP+SN?= =?utf-8?q?qYcAKzk6WEdagjaaS0cwnlQ+AfogSrnTq2zXjUcADb8mmiMj8RERjQt9l0kdwkmAq?= =?utf-8?q?iLRhhUoWptSilHNehI07bBSNFVpKH5d6HdkkpxuiZoOyx0oNMaF6HVJg/zf6Hz/4L?= =?utf-8?q?0jD/p56vJB0PxauPicinCeq7rNae92hRfVn8I9Hb2OUCvs6l9R5T+CjWHJwt5tg83?= =?utf-8?q?hKV4yaoX1y/moyWuPthUF6dnvwawgr9pFpWQLoOMAh/uwiT/n2CgpMNWjlMixmsaJ?= =?utf-8?q?zCWQ16k+pkvGKrckliGx6OoyKSuG6GaEsdCKSOGPu9qIIGBvWb2tH/6vrr1ScerzV?= =?utf-8?q?UpArNR9Syt6/gpXmX5FK0z27JP58ijYvkjFB+RnDfvFnycEeakWVYGv0XTqrWH7xk?= =?utf-8?q?+KuUS7W9rO58fvPmQ4ROWbchOy9VDVmm5wOkFZKXuFQ95/huoGDIQYAj/6dKfpRND?= =?utf-8?q?/qZ1B18LS7bxoFzQEeVQgxzFvb0WZKxENBa3LvDKTnRbhmSD7+4pyKZM=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 947c0415-54bc-4302-e2a8-08dc529aab67 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:43.4909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JEO0tk8PdJKL/3zAaBCsbZmukXMvnFvp/utTHmB2XDDrS4TU+sWKFGywzCb2KoMBARVC6tCfnCgeodgiB92opQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154023_097667_F5068479 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org usb2_lpcg: clock-controller@5b270000 { ... Col1 Col2 clocks = <&conn_ahb_clk>, <&conn_ipg_clk>; // 0 6 clock-indices = , ; // 0 7 ... }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. usbotg1: usb@5b0d0000 { ... clocks = <&usb2_lpcg 0>; ^^ Should be: clocks = <&usb2_lpcg IMX_LPCG_CLK_6>; }; usbphy1: usbphy@5b100000 { clocks = <&usb2_lpcg 1>; ^^ SHould be: clocks = <&usb2_lpcg IMX_LPCG_CLK_7>; }; Arg0 is divided by 4 in lpcg driver. So lpcg will do dummy enable. Fix it by use correct clock indices. Cc: stable@vger.kernel.org Fixes: 8065fc937f0f ("arm64: dts: imx8dxl: add usb1 and usb2 support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi index 3c42240e78e24..d862d2285d208 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi @@ -41,7 +41,7 @@ usbotg1: usb@5b0d0000 { interrupts = ; fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc1 0>; - clocks = <&usb2_lpcg 0>; + clocks = <&usb2_lpcg IMX_LPCG_CLK_6>; ahb-burst-config = <0x0>; tx-burst-size-dword = <0x10>; rx-burst-size-dword = <0x10>; @@ -58,7 +58,7 @@ usbmisc1: usbmisc@5b0d0200 { usbphy1: usbphy@5b100000 { compatible = "fsl,imx7ulp-usbphy"; reg = <0x5b100000 0x1000>; - clocks = <&usb2_lpcg 1>; + clocks = <&usb2_lpcg IMX_LPCG_CLK_7>; power-domains = <&pd IMX_SC_R_USB_0_PHY>; status = "disabled"; }; From patchwork Mon Apr 1 22:25:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00F99CD1288 for ; Mon, 1 Apr 2024 22:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rDwiVKuRfSa+p4KT5xWh+qnOV/tGGI4fwUweut+/wwA=; b=ZuMrGuDc5QXuhmIr31gYEnK6p5 mzUoBGPS/anssdMOyRGUepnxe80UwIAYmkxI5zGjiCpuolYyjXY9m/ndMpEmBjHaGLbmCjJb9XeQx tFG5QOAlOQkMHjfYr9Nr8/Qynz7czexYe7jVnrsrZyseGR7/SMUmw5sts5sUcctM2qW9JU18YLXpX ZzFcHBFopgLAP1t11GW8iK8zTJf9jsUUjJZ2TfxKwotyn4anEOPSdESpzV36F19C8fLr8oe6pJspi UCKPgacu/p5p0k6FU0pJeP27qs85bM/nynJHEkKDtmf1qd3RL16m2r7CrlghWrVpVfz+5bt7WVqJR mGb9Av2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQLa-000000092GP-1XVu; Mon, 01 Apr 2024 22:41:46 +0000 Received: from mail-am6eur05on20700.outbound.protection.outlook.com ([2a01:111:f403:2612::700] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQLX-000000092F0-0cfM for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:41:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDgGdRn1HMsiTTTj8E7OdH7Riulkvzgt5gZGRR7+qUztA8w4Cfar1GoC5IG3UGope/GEZ4RnpdggEBT/LQsrQ6X3WsX/ZCRiE8XJmfPi7RPnFZzRbarGxOwldDcTm+LnsIcPFWu2xWZb1UgP4bu/zAtmYxR168D/bCCK9JwEK2/Z89K8K0qMuU7lQ5sauMt4fH+1m6D78y7LbyEs/msvaDee+hSd16JxzE/DbVsSe8G4ZgfrBJMFqcrH7n2WusZ5LFWcBOGk+3WZc7k81LLhIIV4ixPANCDiIQnCg09s8J4NgtLiT7Py9e9yOCm00o9I490GV3nbHzXiWfqnXQ508w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMwZ5jtaKe4vgTwB20lnrfZVoLaEbOpy3ozujeu8LN8=; b=HzWbv+IxVAGXBSe+BRCWgrNGAGUjy5sW1UY9f2+F8v7OM8zbWRwseUfsrOsQvoGraBu9si7rq+jDI54MhD16w8s+dCyrJUA0uf4sQ/nPEUWazj6130mWMobnB6VOhPnVJLggIB1/E80xyleL3ErrkZLIheu4anhOCU7+RWJfWfkrZQ1w0V2fBavNmd5jOcm2yP+hsODs8L5f2OEI6prcUySCS6NXoodGv6y5JSwaYJSb8AwlqyNfJzK4MQotq+DZUGpPj9DevYCJMaBxc9srsQXUWjO5Q7f0fQjLGYRIrDt8foObyCFBku0a7xqGhJWkb92KdQ1WfzB1M9exf9v1GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LMwZ5jtaKe4vgTwB20lnrfZVoLaEbOpy3ozujeu8LN8=; b=VZgiGF49QJospzQ3B9wOfnk1eYSVPUX1jsbh67910X+5wWOERer3T4Xlvsm14NOYWNgR38EMpGyQjO4RpncOZgQnsNoPGYVpyR/PtW5aMHZupGw1nECYCP2zORzQSsfnT8cyfFZUD9uCDegI4cP29u1aKgu9t/YzvOY4UFJG54c= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:47 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:47 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:05 -0400 Subject: [PATCH 3/7] arm64: dts: imx8-ss-dma: fix spi lpcg indices Message-Id: <20240401-dts_fix-v1-3-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2937; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=UihqGtMDMPc/QTYsaIIsW7589SZYMUiu0ZudQvYpP9Q=; b=gt32yUq15b5dZZW4A18ogLVWndfXVLzqvL0434OACcLvL8QQ16zyuS2OinnKwVnlzTOqoE2r0 o0qr1iXHPHxC/740w4QeGwg9i/7uiOfS+XNv4jEyczqLirZYF4IXe7c X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Faz9Tg+pZUa1ApB9TZaUOG5eVzRimxAtVPrRL0sdLDi0qBlvwd4OxFg7+ADe5kcJ9eXWlTUX4PColdpsYtFN0AhG5Mkz/4Lk39YlFV1xe/uErqdTt6sbqq6a7VvOpFea/XZOPuyrpim8fv6U+oUTDyc/Qa2q72nwENsmwj0dQxn3CXikweL3CspdfmQb2sWsFDoIVKzS6nw+Bi2ObewWkwoMuPadigZbAawW8HqgYIVhfl6olv0sIigKNhjisQdabCP3pSu0XvgY2fTobkBApXj+EkFVtrUxP+mOoXXNF1FGqXKmx9uOctb/lLFyJkcn+xY7UHxvPWwn2F1lo3wpmFSX+xgxrQi0x68BpMW6x6kwEFCNvGEg/hURifIf0jaH9NQCi/wQGimAlqZc1sBHi0b0ZixeqHgg4IW1FOOVZ3JqwH8kFtE4ZJyAtIDbBgRzANYPJEc9l45zRwulZ3p+i2CbujQtY5t/rWtW/W/GGlrb6mL6ccLpbVTcaoBkpkYrtgzrom/2y56o07BXjGDL9ETw5zg5o2CvaOg5EACLnU+tp7f/kD2BBiuDdscLS3kOESHThf3Jl/PaSA6S/tbwsBFBm7nrYvZB/2n7UxR2oTYfaWeX7HXSb2O1SQJ85s1XX9RXTmCF4Jn+kU1DNRwfHHgKa4gjWgkXrTyw6oRLcZ+EXAhO3HzHAJ7ilduIy6marVyKcZsO3XSN8Rjv+feoV3MTtu1GzneLeJ6lF+wC0mM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BI63HJ/R847BBPUJK2hPNOoVziS3?= =?utf-8?q?LFvIVvSjpYOLVywtjU5uh3ye0jDskIlW/ByGMQgSfH1gx49nCrRdu6TN+reWAKVNJ?= =?utf-8?q?iFnZ09Z1RfL7hGa1HMKZrW9yXlgH54dUpEvC/V7XuERdqogOMZSxkd/NG1n+ca9o4?= =?utf-8?q?VXAlAKksXinbAmvXl6D4WR2W5DEOgg31W4MHV5tPwLoUR8V4RN76fuwZvZIrRSQey?= =?utf-8?q?bX5hNlePBG+4kaOJVTQAwnNw6cb8J21Cv7S05ISoO5vtAz91KpuORGNKDjo9I0QTG?= =?utf-8?q?7Acab71/xr9OQV818siJ9rHQ7LT9vlOyfn/XrkvpEJolgpAm4wtaCTuz4tPsXkn0e?= =?utf-8?q?9/fJ188AhOyBN19u+13h/Ca9oqnR4v6gHmLnJ4kk/P8UsX/cQd6342kB8D2Ufhqa7?= =?utf-8?q?17jRfBUzfYuJbDyyJpNWJSaGKD7fiXVF2JyHbVA1QsTkOecsXgnOibgJqqhS5y/sa?= =?utf-8?q?M9cAoHNbidragyu6mf8ktw1MuE9M+zjkNDsW5lTP96sxW2/1dcPiS/ww3N6+pToAl?= =?utf-8?q?lH1M+GhtzmlKay6yucT7ieK7f3NN2h+8r5RaTSawr9v4NNiAVY/pJ0a829r/hD0Gc?= =?utf-8?q?WNmQ70idcMaaaUCrU2vOkNUHtRgfpvcE/a7OecVTN2EO5ELv3WsXjhjRamK6Z3nT9?= =?utf-8?q?+Gb56GkkonvANCr3Gm8Oo56jMwfw7Yg55/wBJPV/ajLPLKuvXcrnqFmyyub6vi/An?= =?utf-8?q?ckpq0iqeHyE35E78JUOPK1Tq2br1Y5bITB43z9pYX6tmWHXZ9GER1Rz8Svx4xB7EA?= =?utf-8?q?ey/VJWqLaFMVVr5gfO3CMJiJIWf7ISHOrH5rke/a6LEQZ4bNtwELOIzXT0Fz4wG+f?= =?utf-8?q?0ydcyZp95CqmHrHT3k67oLcREeM2lL5FS0mIlyP1I/ecC95mBJ5z6vTRfLPct5RyC?= =?utf-8?q?ttjfpviltjJ9pi0nV+CT1NZiFZXXdpmesorrpxtcHcX/bPCadM9x27t1pGEEEXe96?= =?utf-8?q?O7OTjZvEJlmzJWQhnhWdAR/N6RA/tbnSG75dCzlDqxqY/9Adxkf2zWxs4RjkJd6AO?= =?utf-8?q?Jx0D61GAzgKB76w48A4zWEWHVZ4C5t3d+PF0GTUayOeeyNURgvZ93r+83I1J3Voms?= =?utf-8?q?YbVfgH1gmS5YIAEyIE0nwRw/5NpJfNcTvJSttHZL7/9raWqMZC88gmYHwTiImuVgY?= =?utf-8?q?XsWboLEA3KKxqm3ZcPC8j2fVb503oJI6Qo/rZF3GnLRry7tioJxoCEAacLWKnFwfL?= =?utf-8?q?hrj6h2rXaneuWS59/XcHAJZFF7dYq0+QQYHTjoS1iWS9fIT1ED4xmMivlsIcl3ssK?= =?utf-8?q?maXUL+6GdKmjky0mvuqrmTx5DEFvT4BhOGniSAEXRST00Vp1Akbqec4W/sK8rjUEB?= =?utf-8?q?uB73I6HTZJNrUKByew3ugdTYM71+r89uq6aY0hnXWvvZlm9bTOoE8znoo7e24KRJt?= =?utf-8?q?nz6VDVzKWvAciFNU8YWSfADmLFEeDXjgxj8kKdgcLWKYXQXt6Azuj9/KaFH/i+quH?= =?utf-8?q?AMUkeq+WysnargqNi4rPoulFbqMrzaQNCKuA0HWOFEMjIbRyhkP9TiG4=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5b979a-3e07-4e94-860e-08dc529aadf4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:47.7573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cxD8Wm8S8mzkrTk4WEuCFKBM2JYkZxmNYDRzAXGkf7mZbzTIUa9PZhOfpobB8/o7BVHIMnnEd63yJC2zS0b5Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154143_306179_E6CD8D91 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org spi0_lpcg: clock-controller@5a400000 { ... Col0 Col1 clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>,// 0 1 <&dma_ipg_clk>; // 1 4 clock-indices = , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. lpspi0: spi@5a000000 { ... clocks = <&spi0_lpcg 0>, <&spi0_lpcg 1>; ^ ^ Should be: clocks = <&spi0_lpcg IMX_LPCG_CLK_0>, <&spi0_lpcg IMX_LPCG_CLK_4>; }; Arg0 is divided by 4 in lpcg driver. <&spi0_lpcg 0> and <&spi0_lpcg 1> are IMX_SC_PM_CLK_PER. Although code can work, code logic is wrong. It should use IMX_LPCG_CLK_0 and IMX_LPCG_CLK_4 for lpcg arg0. Cc: stable@vger.kernel.org Fixes: c4098885e790 ("arm64: dts: imx8dxl: add lpspi support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index b0bb77150adcc..a124d6598406d 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -27,8 +27,8 @@ lpspi0: spi@5a000000 { #size-cells = <0>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&spi0_lpcg 0>, - <&spi0_lpcg 1>; + clocks = <&spi0_lpcg IMX_LPCG_CLK_0>, + <&spi0_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <60000000>; @@ -43,8 +43,8 @@ lpspi1: spi@5a010000 { #size-cells = <0>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&spi1_lpcg 0>, - <&spi1_lpcg 1>; + clocks = <&spi1_lpcg IMX_LPCG_CLK_0>, + <&spi1_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_SPI_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <60000000>; @@ -59,8 +59,8 @@ lpspi2: spi@5a020000 { #size-cells = <0>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&spi2_lpcg 0>, - <&spi2_lpcg 1>; + clocks = <&spi2_lpcg IMX_LPCG_CLK_0>, + <&spi2_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_SPI_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <60000000>; @@ -75,8 +75,8 @@ lpspi3: spi@5a030000 { #size-cells = <0>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&spi3_lpcg 0>, - <&spi3_lpcg 1>; + clocks = <&spi3_lpcg IMX_LPCG_CLK_0>, + <&spi3_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_SPI_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <60000000>; From patchwork Mon Apr 1 22:25:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613078 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76711CD1288 for ; Mon, 1 Apr 2024 22:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3Unpd9+NCeWs5EvcfQBOu0QpmgENZyAGr5bjQJUgMZw=; b=Qohq0LXdBhF5DO38lI3hZlHZFI Qt9lwk4U3xZjDGYgGDqA8SPb/iHNAf+QkJ5HTi5mnE8PG7++u5askdkmkyaU4hoS0lTK9D1G0p2CM 211kXfJ2sAOdjzLDFK6Xq64M6NaWwXtvPcGK2FT0KhCJIeS8laZa+9JKFs16lTcryqFHSugHfv2iC su5VwCFCbMo3/2umPLH0uzNobKUi7cRJLbKCzqgp4dwg4tPjjvt1GPKUmC4Edg/vRDov0oWbSmizp 0ajMaTLfLbCFD/+K6nhkW4IyMRnk+gnpnG/mZZBLQmHUqhTssXPBprAyz/jmdt0jm8hKIRcsgrb5n lqQ1hqNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQL8-0000000925y-3PxY; Mon, 01 Apr 2024 22:41:18 +0000 Received: from mail-am6eur05on20701.outbound.protection.outlook.com ([2a01:111:f403:2612::701] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQL6-00000009241-2SVJ for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:41:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8UopdBYQsXS8w2/0xFZ9BBDmYW4JBbF+i33Hn9n92a0wQ3cPbgyH7RJ1aKEo0Ek/Kc0/6Ct4pCSBt3csoGHE473+z/+DTlaykTd8dV14Kp5LATRt5NSaSwmWfDA0Ly5ExfJltIxlcg9Pj8dFCI2IHrHyW3Ggck6Mm5UOZFhC4eGPLCMu1+h5KyAn5+hMLUnbpjRyJrW8w2UEw8mihKBElPNZGeNe0ndPkehP7XqahG24iAB2Nd/6BWz3FmVzgVL9ASpYSX7cqxFC6nVh20HMeFHtkT01nqO4k91HL7Gin0Bc71TRqhpl0kUwEseB7mrENJZPv25kQnhubjbn7lBlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=GR2OoS1ddW5gH2D9XW0Vi2VNyxCZCW9+HWYLMpXecBM6IETsmqhAybgmbzKIhnbLBRiqqW7DytJik4tTnkzdvnTkERoFwkMb/YfByDRCTaOtlJq6vE4mYreiH8dWiW549wZai/s4lzFiUoZV0hTs0dYk6RboPawFOPWCCNuLr+zoP+NVVHQmvMDtqy2IUsrh/vIJvi3ZUbW5QBHmI7M+hlYxeMplk8kUpNcnn3YH2xuSY13gsy1pvEzH2wMNfgpu7xsYQddxmUGU1I8uK9ZO/fEiYmayaujQqdt99j1trEOcW/LaheX8MOOHWTDTsZrsPzNHcvnz4l+f4PybgKcaHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=CRIAky0Ovh9T+VmQa7+abDuBC84tyztsOzoCWMkFps9K+9O4TP0WUctvgKGCjdAz3nf6GipA7ET8DhBZmJXCdm71IzK1+GYhTDjBAZIEPKGHBeHYXRLZMDWIj2MCIcG5EqkszrxgKWcbn/oSJLy7lIjo+57IXbummYUE+ogRjv8= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:52 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:52 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:06 -0400 Subject: [PATCH 4/7] arm64: dts: imx8-ss-dma: fix pwm lpcg indices Message-Id: <20240401-dts_fix-v1-4-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1745; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=fdsoDcgdp2uhQaS8/tOFn5VfeICbpQvKk3TSdwKDGp4=; b=Hh3oHxBHwLYgBiYlmxkonIQ2s0FE32klh2UftURC2duBM/QoEZKeS/irbACu2GxSeH9yqGfw0 2bTkFJb5AfXBRpA6yxmOrZN7SZZ1kjxCf0hOkK3LWlYp9nrWlz5CTLI X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fye7lKqJHORFe6N9XfLjlIOVK9GX7EkUHar5+h4AzMCQ1Fn8yrtAW2XtP0kIkYS1Sdq8wBAqo7wqAZuYsRcd2FQWQya9oYXmbpqiKgfi8+n2RdTFK/psnbVG1lR3mXPt7Wls5yiJ+jn4y7lIyAS+1CeCFr3dFGAPrwSU8EGk8LuRQt0vqpGkUcUlPo3IuSAzV4WGwXdh9YBWAV5qCjVsVPyfljincGdLmGF6qdEktdAc84yJoMadUD5onyOLj/YBB/xHfswnslELGbasKsRjYQ6K+lnhPRdB3gAtjru9TM4vKvh+fX1ASfs9XWqjK2oOdqXQ4dqWs4zDkdRzl2tPTJJWG9rctoNuiPUabdlP1nIzqdlmXsEpfu00EoCZXiRaHzWS/w7ko6O2bvkNdlT0rkUMuMSFIyLjAlk5K576lk6cIvYPuCOhYJZI0bclXrfpjVo87ha/Qw3pYJJdo7M5r/NF+fD1sui3KGgzgf4DNZCXN6Xfx5Z3ZHv4I9PC9ckOzGYjUAhfJo435x+kPMbxKkcYy1/bPy8WV5nEmnbxP6TVuJRH81kdwpTTvr4nhkJggpnMyTPqyWG0Cm0YZuqLIcLGr8mVfNTyJ7eiEt50vEfHZQ0NUbyqtkStWgyKfAgTk27Jqq62yJoXx3pbjsPyma44sBY+ButjVTFJjtP20GnHdmBp5SI5rcVTF0n4uPFN7KNLwDBAK1d4XxtLtdVqbHgXDumVy+bjoezR34zdgEk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Hgv2szfdn6mViSp2iJOBDerEt6OF?= =?utf-8?q?vj+xlVUzcu61dtttB0+gmoxLrSPvczIYU19uE8lpTF0OwPg9LV6gTi6beGCZZROE2?= =?utf-8?q?2IqXZemoPUWnynGyV1T7PsozRj8Qmt9oKPJpN3a0V1c1IfeJuDxBOAxQgaOPA1lpH?= =?utf-8?q?f89Ne6MfDHOI7VM9fpOT+AD//o8P8XxdJZ3x3tABCEpfnQZjL9fI8YC7OgfiMPmUq?= =?utf-8?q?uQ/vV3pJr+6iNMHAJatozQfVEIhDRca9nqf/9fzVfzlu0GQz6WPLSDVH6AwxqBY6J?= =?utf-8?q?5FDbpPFrNJm5Na2AzQvd6QU3HjXT1ONEX2E3SjSold8ko4RbcgWU4zCjJZssGbdmH?= =?utf-8?q?RG9iGBMaosWtyoxGhiG0Tg5lMnM4X4YamGTwNXRZZMeSYBib0ROMQAWHF+W3s6JQJ?= =?utf-8?q?7yfeFKRevcSFd7agc1RFgP3IBRqNnjV4qEpJULV574J9wK3rtXykCpUEjSjlkXJh9?= =?utf-8?q?i8MPb6RMGsXFGxaUmWuFFxn4tYAjwz8iCC02nJpdT2DnLrhpY7Wzo/SYD32KkRzhN?= =?utf-8?q?tP4QTw1CExS9973604hfpy5p1L4PWURxgDwrzlmR4qtkUZGWwHyZuJvskhUA90GM+?= =?utf-8?q?kGmjNzz3NmaKTOOvba66gvUTBH60ZkJxD+5VmxtBrt34+It2KGsRFXPTFxYfNBxG3?= =?utf-8?q?P7ab8b3arIcCRH3Xh75PEYcXwu+Ep9Q+5zg4OgWxaJSBwwZuiRPSCnatThEmWu74z?= =?utf-8?q?P7ccTE4I5WjovdVzbekIrobEh6+6JEDNIJlPPbWpnqcvGErA511j6V3BKXHgg6l2q?= =?utf-8?q?mLf+/IuTXSVwkXkaM3HWESes0Sdzt8KLDUjTmTERLA6RsZvo0IciodAlMX3dOYrrD?= =?utf-8?q?FQPccrHphdCX0psXCdOvkpdwiRNuyxDba0r6I97sMlyzd+NrvEhyu7bw9V+XNYNTx?= =?utf-8?q?vISCCLUyc2jIOO1KsksE3IC8GRfeKHL6Jxy8LfTZA+z/oEsjQj4H/IEAUYLOoc3OT?= =?utf-8?q?diWJonv+Umy1UOxJ29wtIml+MnGAwzPQJCFAf4T9fJF6YViyggSZC8Si8iK8NsoYm?= =?utf-8?q?jyY1yOQgSwLwIxjy/ZKSY54ExLzHKjA1Zyj/1N+5es+4m2zTm3FgAVyxBS6TIaqRZ?= =?utf-8?q?Gl8f4LlcMx/W/PTStC6eq1HwemHw5EcULhesHrBKRG/bzewmdB9jtPR2jEkwwbV4p?= =?utf-8?q?2DK/dMKa/khjAJDu9A1nAy+U64nEgN/s/x22fqJejYI0d5+n/VHdyLEhgxWmgkCmu?= =?utf-8?q?ek9ehgYpMeMICcym9E0Axai1r9tNzzLVJLEWGkXTLiHckujjclMtyVEn3Rjg36ro+?= =?utf-8?q?KcjkHEBls1MmP7K+N683LMz5Tbul4XDdkPQjmVvnr3Y9+jHYOgNfPV73GIBvINpXP?= =?utf-8?q?un7mEDgZ+0Lj0bOcRL9MnEnXVnYLj9ZuhzQifp21ObNlCutJKMnI1PVu/JRTQdrlB?= =?utf-8?q?wuWoF6Mewsa6AiaVAEtFxyorQ8UV9H97eCO/n1G1A3I6WOY1G12ZJsWM5pO15O5Rr?= =?utf-8?q?cFhQpRN9Lo+nN9IlN02qW+C5qM7+XBDwvEAUWUxSMw8lr+2CV3+MpQ0w=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10a7e5bd-1707-4ca6-bf32-08dc529ab078 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:51.9808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UsRmB/Wna8OXWVmxaQrB4n1JaqRTbZDbVpLJ6rPIWUz7CV7YODLhuwUuFZHT1IZUiNShfGA9oJ6ZZ2snFmNXYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154116_701122_72B8B738 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org adma_pwm_lpcg: clock-controller@5a590000 { ... col1 col2 clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>; // 1 4 clock-indices = , ; ... }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. adma_pwm: pwm@5a190000 { ... clocks = <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>; ^^ ^^ Should be clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>, <&adma_pwm_lpcg IMX_LPCG_CLK_0>; }; Arg0 will be divided by 4 in lcpg driver, so pwm will get IMX_SC_PM_CLK_PER by <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>. Although function can work, code logic is wrong. Fix it by use correct indices. Cc: stable@vger.kernel.org Fixes: f1d6a6b991ef ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index a124d6598406d..d4637037ba1b6 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -144,8 +144,8 @@ adma_pwm: pwm@5a190000 { compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm"; reg = <0x5a190000 0x1000>; interrupts = ; - clocks = <&adma_pwm_lpcg 1>, - <&adma_pwm_lpcg 0>; + clocks = <&adma_pwm_lpcg IMX_LPCG_CLK_4>, + <&adma_pwm_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; From patchwork Mon Apr 1 22:25:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1E8CCD1288 for ; Mon, 1 Apr 2024 22:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=SDnhzVEX+7j74Kz5bsm5AT3Cg6kDlGjOeWL9YsnHss0=; b=XEka+7YmD3IUeUSz5/knHPI3Ul VbYvyUuT2DSqAtUCR9Q/VkqPBs1v0nil021UKmnyABEYUIhD+Ue1sauevSskoWQWZ5HgrxHSlkgfK DaqWcqX19Ne5rY4B1ACQwI2CS9et9xWR3l/AXo5MCeMA7TcX1szM5KQUFwhr3adKBQZdXe9fZrTNH qQqtk5sXbrjXeYUisd1R+VM7nwiei/0D/qMEIUYUOy8MPEjFC01SZYectscP2L6/NrzGaes5HucZr bjZKpGgRE5YYGRCz0A5UiMnvNvkGrB7hFZ5Ruc4iy4CfYOstO3oCTIb6pE8UJ3BmbP93FShgJDLpU W1kwt4oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKi-000000091uv-1VsT; Mon, 01 Apr 2024 22:40:52 +0000 Received: from mail-dbaeur03on20701.outbound.protection.outlook.com ([2a01:111:f403:260d::701] helo=EUR03-DBA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQKe-000000091sx-3QGU for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:40:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myBrHfXm2GBI4QEPng40/pJ8G9E2PUy6kRFIwk4dX2HakHNjeUk9no212Cgg6U2kPg38BiwuHeSaFaCDLWApVWns9pfSClhnMcS0fbgcnN0k49LxY1x3lNmKanbx/jcuh6Cko/CjT/BBicIermky/36AwJ8xdIs5BjhEGqwZ33z+wbX3d69ZxH95UBN7cjl0YFlC0KgzHwH6NoXNsWJP3A7NPSZwJNh35CUfrNaXsfLKtvkDpfTDOMDoV1ch7yhb7OU8lTcQkWC123uJAiM6m72MKdGfZhqUFR4WFpY6LrrkxZjcAolFp25nnSenMKXbdg/d43yIr5g/9t0JfrFJMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QT3E7dpZi48J1VSrcWmHxpkF+vwdFoPc2vglBlfmOSE=; b=kJizs2C/+44RGKCKvbWMb2fsi6xIIHDqGW7l/DyZj3AjE0QZrwGONMcirhvwpP2t5AgzHnvv7K0iwa/mI+US5I+i9UUWBQBCJ4NLl6I2WWuv4BjGXb9vlanJYSrZBgMp+K5pYwGFwysF/hBcjLSKd8NDcxj4Eo47T4mQA0wlx+GxORsJhEUlIRYgYCYpKulP7WUh+UwxI+Xn+GSa84jDZHYEUxj1DbB5yN07G/4Z8lBeorOqDHOzrmTCZudw+sm4MMs0gtt2h3FHsDa1FfhqNqpplurB1OWODbFAmEh5E941THcrG0mu1oEXhiWVcy7BCdyIwUmaU/6ZSll8/FY2KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QT3E7dpZi48J1VSrcWmHxpkF+vwdFoPc2vglBlfmOSE=; b=MVkI2rh4rLTg3oC4dFQPLwtRr7qMFUj26VYvPJYSYGHZC/RpstP2m4R/rfyfuSdKg/nusziV+LYwQuUAUc4Q56qM/uv4i5aKkHNyaU9NuftpnsdcmRTYAtaCZXIaCf2qvuB86sSIDR2vDoJXwQoES2Ek3CikBpSGJ6PmmeDM2Jc= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:56 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:56 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:07 -0400 Subject: [PATCH 5/7] arm64: dts: imx8-ss-dma: fix adc lpcg indices Message-Id: <20240401-dts_fix-v1-5-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2028; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=PqFKqzOaCh+9X9gmH8adyKHBMmo89yE+D+WZJtUo004=; b=3HrnBKewz9QWbC9cMMt4OcuPLW46GVDiuX2FoB41ZgOv9JFkveV7BwHN9mTXY2XCxC4OYuRsV 1oI0111dVdlCiPZ/xPhQta0xdFC6HfR0p5uu2HzkzpyZrT8hGDpIAeD X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0kl/BZQXYSQjfZehZYZQYFbKCzTxExmh6otv39/LwM5B6fdYN+zaI+GvJmtN/xz2HGFeHm1quSxpxuNHY069UgvG+QYNuciKQ+w7re+Sj0pVksfRTSn9QfNRbqFRiKwHleE5rBcsFE6XJwQ50eJI3QSP15kLD3c3Yg5s0dYHBRw+3TOQr2fvv7GiXoNvGv3Pla/5tM62SdvnINNJqxdFhjM6slTxT1DzNASx7aABRWgK9X+K1Z0aDKmIlAcYAGCsqL1UmUD3ruGO/m/ERNQgXgdegAvUFe4l3ENPi7aW38rxV7+Sch6KAIbu1Ss1zGh18KxGr0sv9GgZG19Iv21uKOtzLmST/76KTJy1iBOBPLUfNVob+TKxeXE9DwiCWoMdjpiYjzEwU3O9O6DE+wAVlsLNovPx+uuhcYfLVbM7Modkj1i8DvwGRyN/E+aU/2pnH0HnZ52K5S/HxAfg5Co1u4CbQcA9KNtolIK1k+cT1YuMFafp0o6EOwU1KMe9lSgTXls1nxcsQmGzIpQQNrv0mkfnEUaWAB15wpxVbDhNn/8VZ2kw2+TNNEQqH1g7wV+edNjjNGvYxk+zPkl4qFqsMgG3NiN6tStlRuYVc2OArqs87ZcWSdPvqJ3IhCfSnyXCoJ1t8+px9lerihpRsyedLte2ce8RNPPz7ivJgSDP2Da6RYPUT9y21yE1Kxov6lS0GgBX6SivA7Q/Tst6l6CKOZICVdK6foif/A1putPnLzQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?9Q55cBfs3MBXfUzlzbyV56utF0sR?= =?utf-8?q?9jqWRuSMpGGgOtRmS17Wof+FR8QhNeABnRc+iRI+ThzeZ0pmfmeNpUtWJBe6EvN4O?= =?utf-8?q?6CBEaP5Ta4d38Unt/NTnHrzpud/vo/RAcJYJNvHI9Uupw2UBG7StJ1nkcYjobYzN+?= =?utf-8?q?cipEv7nnY7Rxc/Q+k2bU/48agrl3tIOqauOn+URKC5b/LsWlM3AGj7cvWHQytDMPG?= =?utf-8?q?WytmWswnKpXPxwpFBgnIo2eXlcwBqwib5MCX5l5ZTdN7nMwXqKDftduDmcpv3XjX6?= =?utf-8?q?hfJ4lF/l1Ce+j9eXABrh0rg87GLgZ42bGoaleNpipNSgNkYQUzbVo100TZtK2ZG0B?= =?utf-8?q?b9L6dE07ZoxJ9QcjPG5sO7QZr1o8argcV7/v7Zw3q3vC6067R6+ADdTffUrtJNL60?= =?utf-8?q?1sUmguJ4yeGv9Tod3Eig/V/M36nE0oecFWvb+Y7cTp0lDNgRd6Qb/1vrSNaBL7ocM?= =?utf-8?q?dcgQ9UJLEabt+zpZuj2OHx+GTfrX4escJQ2otNig13N8+foA9RMjWD6FHqm1quLJe?= =?utf-8?q?wsxovIWO6A902/82yLoV0ntnuPYvDWeunoAkhpOZmm3HyVrlH3panX7VLHbEz5htU?= =?utf-8?q?KgX7keQnYc5tCXtjytopyw6vvoM7c3Rjb7kzyByqGKRLi/EjRK11b0lLJeacJ2M+6?= =?utf-8?q?ehLe7OyY4lEbp0ZCfhBasmF8inhXPFRRO0TGHHi4KA/b9L4RwZEb8CwHW09JYe/GD?= =?utf-8?q?TEvaCdVY6TnhI4x9zNG0nVgOgLtw+pp8HIaMoSF1tsHD4WzqaIyRjiM6UgO5fxmZM?= =?utf-8?q?v9I/CE1tQaO0b9ep2BThT093oVgKHJJbJEc3udvONQwI9BZDMhX8BebB9Wc5zGZjM?= =?utf-8?q?53Y/QOejHi/Arjf7MZuTo4hlhBxZZ5Hjbl8mx/OAO+eRlWQjlAQ6I2DQqN1VQzFFN?= =?utf-8?q?r2S45qqR7IuJba/MBl/Fa9A3Vo9/MCSgfhiR9QSlTPSUYSJ/Yaan6cQKZg2ghH6xf?= =?utf-8?q?eipJtfUeen5g8042yOqBe/F1x9JuwKRXaUcqZaRJ1DRGj/30BeiNlIXbZ8unQYBA+?= =?utf-8?q?japq3V5GvwrT9dm0a+PmVx9eoO78FctfByW9Ev0NSR9TQT7q+syY8RQnwZXdPcYes?= =?utf-8?q?Tpmb+8kmXW7T4rtTCcE7M3yo2S4uyn5895ow20NzwK+CGOEMaiUf7vrNzVfYAz54Y?= =?utf-8?q?dn//2GAQ6ERybgaSkpNHKHCpdsyq0Uq4D2/rzvBIEZIOocuGTrhmc8JqnUCdRAwK2?= =?utf-8?q?8fhUwpcvWwGLGniC9k1FVbtWt1bbSNg/xKTUl2wjZbB3+sSWhjgl/0M+3SFm68Z/4?= =?utf-8?q?7eXNvYbmGDtSYvOGE95lpNY7CmzzU0I7uGLZVbHVZEOLMchHqlVRm2UhVreJeEU1N?= =?utf-8?q?/ksjDwv2Ap8BGkMBZS4DAFfyfD3CIAprz5SDxEWP3jVEIKJ8e1kw8ABn19nqx87OM?= =?utf-8?q?dP85WabbXk94vqQ9yCGUmSakXlMbkciBkFoSCmCKkdyx8ApNnPwZ9EO/O1kU/iVb8?= =?utf-8?q?wHq2meI1Ez9kgIJ1ZiObRyQ9Z1WJtzz+l07jLn8GT3iX599W7xC9LxXE=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8779785-9b18-4049-331c-08dc529ab302 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:56.2297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bb60hX+l6TU5Ok/39CUa+2ZiRGVNaHdRGjdozkr8NWzivTMQYzQlbgfLmTtXi71mCC+BjmZfwgxhExyH4cKDzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_154048_870740_71C1BD12 X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org adc0_lpcg: clock-controller@5ac80000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>; // 1 4 clock-indices = , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. adc0: adc@5a880000 { clocks = <&adc0_lpcg 0>, <&adc0_lpcg 1>; ^^ ^^ clocks = <&adc0_lpcg IMX_LPCG_CLK_0>, <&adc0_lpcg IMX_LPCG_CLK_4>; Arg0 is divided by 4 in lpcg driver. So adc get IMX_SC_PM_CLK_PER by <&adc0_lpcg 0>, <&adc0_lpcg 1>. Although function can work, code logic is wrong. Fix it by using correct indices. Cc: stable@vger.kernel.org Fixes: 1db044b25d2e ("arm64: dts: imx8dxl: add adc0 support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index d4637037ba1b6..77ba2dd6847b4 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -377,8 +377,8 @@ adc0: adc@5a880000 { reg = <0x5a880000 0x10000>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&adc0_lpcg 0>, - <&adc0_lpcg 1>; + clocks = <&adc0_lpcg IMX_LPCG_CLK_0>, + <&adc0_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; @@ -392,8 +392,8 @@ adc1: adc@5a890000 { reg = <0x5a890000 0x10000>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&adc1_lpcg 0>, - <&adc1_lpcg 1>; + clocks = <&adc1_lpcg IMX_LPCG_CLK_0>, + <&adc1_lpcg IMX_LPCG_CLK_4>; clock-names = "per", "ipg"; assigned-clocks = <&clk IMX_SC_R_ADC_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; From patchwork Mon Apr 1 22:25:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC2ACD128A for ; Mon, 1 Apr 2024 22:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=mjtmWHblKJXdtVV+gfFi/7w6I3dTkxAOe7lFZgaubNY=; b=wwcjQDM7crNjnWwQer/dZcUQlw nORv2DileR6KAtx3kpE9dNN67dkNF39e2ySTcROgmUydC8dsTOW1uOL4yJM0AN9nO2QHQAhT12+/6 b8Ob18+NMCy1vFZ1l9HLoLdXeSX+lKoPc3MZU/g3UKs+AX8kSmliMs/QRSR6lHnL5vjCa7Dl+Rph0 ktGt7XynPJ3vwBt+QdEND43yVQPYvod6nd/yNL93o90XPwLq1D0896If9UJC3H8odm0fCRwhpuZuY Xadl1SXTgIVlgZ6yzQVcDEE8h3pDbZ+AtkaCtmemi5TiDl7cO4OHWGZbTIq03FDaLHwpyZPubwf1R /G18Zylw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6b-00000008zsw-2UzG; Mon, 01 Apr 2024 22:26:17 +0000 Received: from mail-ve1eur01on2108.outbound.protection.outlook.com ([40.107.14.108] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6Y-00000008zqg-2rMt for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:26:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khnd2/zGCiPNDa8VcDCnz7a2ToWFc9ucxi2CWYCnnhwoEgzs4woskilkyc2s7uQ1wS5C+90ZvePVi7Qi9kPvgn0uPnxIZrCyHOxd/Yddn08ZTGBZULNZd79/ZMTi1R+SUWZ8kdxwhVIOjuN7O+uqV8z4E9eSEKfNZZKYlBh8N2K0dAfvQCVt81dxEBSsIq/A1EpiqqO57wmiEFrO67EH5f4LOC0Ps5UpuVokHIH4mDSko/36RkoR9apOnjBWBDgshXmcYQbsaNC3oTvTmXwQVAVpPPcEeN4dPbZcpfv6slCQ2aV32PgdbpPBZD4ylU5i+WBpX2EXEd5eoiaGGbwMxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=AnYaNDXnx13oi7819Po3FXGIDRE5No/Afnc0JBeHN8/GjPGBLasxkHbxwBMWw2xWOjRfOldIEb15wVVuH+qWXMCTYyhQ38LgL4nk2+pa8Hs2wLTm3ceXEq9K6nS54TSmj3V2vKBdxJYxfo2/vvB991fjAo4hbd+AwCAlK6UCcgV7LDOqzf5imbV6we3lR0KQi3E3T8wLLlHN76q4piyDJhlZs/oTdq8thyi2AQmAzQ9GS6Wk3FUP+rNz63vn9E4FSTMhEfT8zHV04gDBVOZBCPtQss8cUEuJIlp/IiYkoT5O2QeAdwdXhhSmQXnYj1rJRFDcOM8blGbNqzLVdwLz+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=c91ltZ2LI01blfZVkZqNrlcH9COHXAR+oL0d7KGTf2JX0I4UsV2PCaqsyKYG5F+SDbuoRo+IDxpkT8D3EZQEGJgyMoJ1Y+ZI3hfjqZ8Kek7Qll0yX1gJIfDJ0KCgvywXKIkjLYFEMOL5bFDvzvnVeCdQhJr1gAeJ9lHwUfDDo/M= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:26:00 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:26:00 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:08 -0400 Subject: [PATCH 6/7] arm64: dts: imx8-ss-dma: fix can lpcg indices Message-Id: <20240401-dts_fix-v1-6-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2525; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=eO6HQ4nQkUGETGGZsuLNurR+PbulGpVNdui39aXhUCA=; b=zq02e6hO7o7sOd+iifS90EBTE0PozjY776Qcwp0fDEJE0JG5wcKtl6yJHY6rfVcBwVJA2mQj2 xpAjUTUNd3mBDyCoLoZMMSUc1zK7SLTXxFvmK25fJQtC04PM9miL4bN X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dL9FGh+/dH6crvq1A5b/sxHvZFwQjNGqwsMJgtYM91jMV5oO6G024UHzE/WYm9RZ7tQHykH4Ig6N7xgEHUtidPoHlqtSr19JivppzcqzATD7cy4MxrPTC9q+F3OSO68HWsXHH0Q57S6Ryf+91mTxtDuL3aqJHD2WE22z2HmPWTuSoSWnWTUiQXoPSQdt1lBXTE7kRXYEEkRBfwYAt0xb6WfAgEeSpU1c63jRCyNqvVYkrokugVlmFV8z5QhOcoSTxp6ApeOkZN7r8tQh4y/9rAxY4+vne3tfbHwkNjZV5fT4RvI2DuB5GOyFI/qunx1EOGzuq+OsqQhOLseIJRKYAeaTarcOZVukAtkcaUhJnyzD5UvmUMKOJ7yZ9T4ktVvizgI4PBG+CHuBcGE7JYFWoXKUYJ/pi6aUPOzqNrSwmshU5+Vvic7cm/ASsXOPGzw6M9pg6ebHWZ/epsI1qz0fbZKRuvU5Su2rTfE9hThPP0czdWkaKJG/ChhtH6qYWj19mPlQeWkE7gu5VBG6tqU5XXror7cRelsqeMbCEWkvlv0XjFkIt7bZQkIT9cGLO96vRGKLHX6yJOVrJd/8dYh3hkLmNDJb3A4KXxvM5iM3Bv7x+Rhy20hmRuqoeDFh5Wno+C6E/XhN+E3f1T6H/jbHDmuJKcihT5B+BHao2+YUHBFKYXukUTJjnDkGnfR2RLgVM9VHWO4vPOdfd+4rlWAVN4lN6B5rXdHw5KQ0eJCDL3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VFC/mvNS4Kq/NJD6F8O8vKZooZvC?= =?utf-8?q?AMPaRw2Z/0uH35zM+CHKYOPVLy80zcgXiZyQw9QqDTs+SIYmfjvL+0J1RxygfOVNB?= =?utf-8?q?UOhstV5vmcwbB6JfBUmirPX07RfR0CE84CdaiLSsoyNXLuzzr2yMG/vxBn5ZTO4yU?= =?utf-8?q?Ay0k1eXc6zBTRWlMUnBAxKgrCl5p+X7ZZd3/WKpfFSJw/KuFFngbHtyswPnTo93Sk?= =?utf-8?q?UajNX6C2RT+lPLZ2AI8lECkGHURpDVbq2Il7SjKTkmFqdtrZYfhPj6s4LdNNaZjCg?= =?utf-8?q?TBBOvXFwdjARHVXAaVQ1+4P9X9+6vJxuuTsPEqbeDng8/A9iw6NeT8hMMabQBB2bZ?= =?utf-8?q?pbNXyasdUCs2KB93TDx935SxFiacdIZw5E3GQYnkzh8PEE45LdqVvia9ObhI7Fyc4?= =?utf-8?q?lg1GEfV0nxaNjrJfxoiHjbApA4Np/fE6fq+CVS7u5OnV7nKeVJcq6rEyntEED2iip?= =?utf-8?q?QdgGPUzoXnaePv9b9sjXZZa2NM5TxYOsrbCL4LWt04DT7Zhmz5OkwTghrb9LkSUMg?= =?utf-8?q?lwGakoD0FHAVR/Z5860mpBAtCUBEaihyK66vdmSajL4wBDTbTewkrDW2BdldYldlB?= =?utf-8?q?MI41vrN4XL5G9wk9fxsn0fmV71hEwARoFqbp4MQ3RAeyCE8ffuJfDZax9AadKuNSx?= =?utf-8?q?/C8dQKGN2BxG7jd0sksBslRqx8mBNcs5KdDx39LnSNepsczK2q7p0jl9PEX47VulZ?= =?utf-8?q?ZsFHNUVrSrJZt5xnl2zZQAmboSw++P/iHL2qEmkX4H8PaqaKRQWU476DJVIJVnKM0?= =?utf-8?q?dtGctuj+c7WpR0J/KFVGGhCeLF7ZvR01cgLaAkKN2hZeQqwXMmoesEDI4l707SOEb?= =?utf-8?q?wIGMcTHiKmmkXGycbs0cvDGnprti5SuwO8H9+p6ZadObcHmQIIE5P9+Ni74j9JPGF?= =?utf-8?q?1QFvBGeYzAs8+Kztb7pG5UMZkmwmCjfo53+ypye5Mng4vfqjxttdUnLdgc+MR3iKi?= =?utf-8?q?epOqzjAdkoljsPHH4REjcL+hE88UF3R4ACJ31nJJ+vVa5T/ODV74eb1zz+CuBo6Ej?= =?utf-8?q?SCrDTYcdeznggOdbvVPgl8pMBPnMrdmJ5+kS0Gv/Ygxov1acJxQ0b8iLePZ6ZsIET?= =?utf-8?q?OGR/QanAUrIhNqulgvEFDKQt8s0ZAES7nCGuRVUvpxnU0ipgH4WG5YwSaqMCywfy1?= =?utf-8?q?0Qlk6TvEp0B7HaLPq8dSE+dp+rOi7x9y0xEwzwBl4m+RGECs0id0zbfz2QsGDjssW?= =?utf-8?q?A0XS0QplNU7PNrEC2M8znZkMIknxTQXZfMS5ok9DBapoiAU1Hf2EOC2be4+n7CwVe?= =?utf-8?q?+4WxgGCjwJnWtEYFHKN71xxbewOVyhwBA/RYSSOiUVjoOnnKQ8Bz6FehlOZI1I+aH?= =?utf-8?q?Vi+UpwB+XBM+ndXbDyWpdpqM7kriAF+GHUIVBLsqVofcRctTZPVl8tyGi68YnKKtx?= =?utf-8?q?ZLnylH/umNTHkKKhm53BC/TUBsh7bhMtEluM5L9ywbqhj1kV8m/KO4iSqetmFEPPu?= =?utf-8?q?I1tz4lQjYZTjF9J8OKid4jIbDI/WeNCkdJIzZdQQ6kkCGBCHnn5uwU1g=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e20618cd-2734-4a38-cd40-08dc529ab585 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:26:00.4359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YTCo1qOAsCofITJigvj+FC1Q5LGTcbLBcYqDG83GO5/8ZSPfDvQKMguB/lp7c/MLYah20aismRIShL+zxxdM4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_152614_792994_B99B3152 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org can0_lpcg: clock-controller@5acd0000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices = , , ; } Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. flexcan1: can@5a8d0000 { clocks = <&can0_lpcg 1>, <&can0_lpcg 0>; ^^ ^^ Should be: clocks = <&can0_lpcg IMX_LPCG_CLK_4>, <&can0_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. flexcan driver get IMX_SC_PM_CLK_PER by <&can0_lpcg 1> and <&can0_lpcg 0>. Although function can work, code logic is wrong. Fix it by using correct clock indices. Cc: stable@vger.kernel.org Fixes: 5e7d5b023e03 ("arm64: dts: imx8qxp: add flexcan in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index 77ba2dd6847b4..67b3c7573233a 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -406,8 +406,8 @@ flexcan1: can@5a8d0000 { reg = <0x5a8d0000 0x10000>; interrupts = ; interrupt-parent = <&gic>; - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; @@ -427,8 +427,8 @@ flexcan2: can@5a8e0000 { * CAN1 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; @@ -448,8 +448,8 @@ flexcan3: can@5a8f0000 { * CAN2 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks = <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks = <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <40000000>; From patchwork Mon Apr 1 22:25:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13613071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2989ACD1288 for ; Mon, 1 Apr 2024 22:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r8vOU1cUKFMwht3A1+Ewosi9GLpYyfRomCyqySWDilo=; b=wf0J1UYuCvZvzZk+1Tc4gd9t0+ vk7vA0TB2KezchvtNSftguwRDndVkJnHbGlojLtpjsHwPamwMhaD53rZEqQ5TlVbJ2YsdvG8Im2K4 9lsYfK1fpgwj/zCO+CuiTfscDUQVj6Y5hHdHQQUwx8R50NRi6s15o+XExjctCaBeyW/aFxj7YSZVX lRFqyUctooveeDzq2PZKyYsdTUY9bP644Uq3iwcgeXi2KD9TmK/4paC78LJ3ajd+vXsaNzAwoiyHi q6YV0uhonpfL5K8Zxj/TjkLphzuWbco3Rng6vrhYt7DHw2FYtQd2x/xUJXDJ6zn1QSHTU/6hjdgVV cFQNSoMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6d-00000008zth-2cWw; Mon, 01 Apr 2024 22:26:19 +0000 Received: from mail-ve1eur01on2108.outbound.protection.outlook.com ([40.107.14.108] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrQ6a-00000008zqg-2tfI for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2024 22:26:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNCw8eZRs+vOhF7XldOUm+Ez18cQgsbxulVah/kaBrpoBgLMQ0NdfN/dAssw6v8g1lSBKLW+qMxgIcMBznl7ZJ4CFtfSKRZ4hhforSGGC/orPi2H2HkBHfL/DTKmNFxyrgh8fudwBCNm+qdx95Kiyw38oS77M6Yt/a1egRsPz1eztj8PLUENbljt6mJu5a87HMZkl6lNK0TBI9GKreZaExGIpWWNzF2XNCjU+pmLWlN4JR+3UA7jWsSwrZ7rcckVh8dXQgTdzLf27ONxRknTN3PFvCCNqQp56+5cVNbtBdvbiq5HCcs4XAa3ue5G/oZy7qpqrpChPZCtIuSMG21uXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4iBT8217c0X3M9h9xFyhs2PbHWFfGpPCyfNWe94VNDA=; b=jwXciYrLVi9VE3Qj62aKTMIfvHLO7XrNqEu2qNTMPpuGIEyQ2gHerrR+4V/GaDr0HEDbSovhkOLefjgi64EDfYHlfoIteKvtLdB+XYhL1U78INOfY1sWKEj1mHYDngB3jMBbXEstGvdKGB7kotjJdEtlfdDUobhOUlNEaQ8eq62NQMdcsDTnnYYlnQMvUr/COqtxYLp8U3prWhD+xSIh0bGIpQi2EJjppjjvjTu1hjGDnX0jkERtMxl6ZCJLt1xWP88VqF7pq5TpE0rSrsGnrDeUy6IWI8fk31nmhfTO8Y1JDF8ylgjHWmCfDLOXGfg+6ODq4q1MK2YOSD/+9W7zEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4iBT8217c0X3M9h9xFyhs2PbHWFfGpPCyfNWe94VNDA=; b=jyM0q79AKd2hJS9BPqss3/Ymr/neZUQfYeQ8Up0Y91lGy/hiewwAE2dW+LEpOXbUAxJ5COfVuquEmJ8c3ZhRNZ/IHWx/L1tZtT8lr5aGWNGHM42quZO+F1gPCqgbjcBczNNYaek/vTRXA7BDeDCP+/4YgLtWoVofNKM/hwF3dSs= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:26:04 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:26:04 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:09 -0400 Subject: [PATCH 7/7] arm64: dts: imx8qm-ss-dma: fix can lpcg indices Message-Id: <20240401-dts_fix-v1-7-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1806; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=+Xl/NBxQeZ+jWNsmzYScwfNZfXWDsmCFIP/CHujTKh0=; b=jrIm5jsGkc0UB3hDjH5SJrKt3ZkK3KaUPw0E8aTe75F36K2+JuUiRFlOJQFNHfseu1aQxp+3V S7cMTAFNQSeA4viqwky/LgPwXC0ky+eSTW3p1aqlcTqXKyb74pJW+E0 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VLE83ChOaVZNM4zd7moPMCF2IsFqRRgSiZDRfvJpx0+yKTCv5rA35O0wz34haNXM28edcooyVOPd8+fhMzkOogrqVYO1tr/KdscZAgdUXh7LIvIaQNCugI4sg61W7h8XHKP4dwOcrN9OQphtJ1cG49H+zSpoq8VCIZBfyMnwaPtJUem6txrC8J/7Efvll/96JuQF8iYSJyl0VJ89nL7YlZ2iW+8mXXd171PRwabTgpiQQbX/6l6GvykSnyP7hTLBK02R0QL9twDMemJxiv7R2JvgEi2l8pAZN5BeOtDqllyRRCCVU1HarELwkwlZc25H+fqHBnfklhWDHIAh9AGAD0f2BkkEeoeQuP4ykmcwvWnSF3//Jnt9tCzoXFqlMdR+sUSXJfaWIGdKvAFIopnSA54U5FV0Rqu6GFnA1u1PgPfroOi5luwtdGVqAjCOBasBmm1oTPMCvEKHoGJTtJEvPXLBiW+xeA/HLl4ZYO+SgEwjhvTi0UhAV2yMAE89cjIKfo1Kbmplctrqpehlo7ySKzwEoRVY9UM+OKUjYnmsfF34SlIQJAUnFKPUrJBRrHG3AuUbdg2ayuuIN83p50EwBdjt2gtQo2BhjT9XObfK37UBaDypw/BGExInJ4XE1vzwRFjOI5SfQKT8d5do8u7HAWUWydcp1N1lQEJmCPvPoo2KtK7EUMd7Sn79MhiEmk6s1zXibHPgiM8CHay3cya9OkrS9wLpZ2+wz/F8lRhYw0o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?W0Os3UDNBBAYg7R8zF7wViepw9+w?= =?utf-8?q?Ecj0YDjzsn8IuoyEajwKS3jnH5FJ1+UJGxusOYOSp6Bitc6gtunOSBQf9Z4HXXXoD?= =?utf-8?q?kC6mwPux4QusUMWA9hiCFlfqOw/D65UXs+QoDNDRgWIjkFuLN+fe5MWyuzQ5hdJHU?= =?utf-8?q?i6GE1C0u1SS32ow4Sh0lKRsQZVWsPMnTnU/cBZkKPwADgTCSkRtWyQUKa7ht0usAJ?= =?utf-8?q?tkNlro+MTARbggI/95J0Djyab3NAOTpJ8o/+duq+e2+WqQhZohzOU8u8Hnz3YIrT8?= =?utf-8?q?5MLHUes/YSRflS1Cc5WiJ/2YBDKRU6PlXVUJNOUEJ6FnYqJNa1mvQNoK/gLmwaZo0?= =?utf-8?q?p7sy9ul1dPVefzKg0LTR/zw/Iza3tM8+hutohXn1esoWlKVErgR1VZm5WXzQ7LugT?= =?utf-8?q?LnQfp9umqfqvMXZYDrP1s94Y/J4u4IpyEFf2jFGB+QgevhArcnIRozgg42IP7j3Ce?= =?utf-8?q?kHwjbsDxReHpRgvx6D1r41iNX21R1EDXE68DWSVnFvVJ2yr60mGhhkQkctggAYEC8?= =?utf-8?q?ytBsU3fQLqGNUHiLgTzYzldsoUOzJpcaEJqJE5Ykt4Sa3fd/jB8aUeqN1ru8ibudu?= =?utf-8?q?ZQxfOk0PixreTFmY/SvzDwQNM3HDxbFioLy7+4SQm/+wzuidYYIsCN3qPv1Vt0MEw?= =?utf-8?q?wkxxsyLYk5rwZquKoa8g0QtRIkjwgyUOVe1o4x2v/V+sW/Ml2qKxbNUsjnxD4e9s+?= =?utf-8?q?QQ4V9Aifbgekv25XlO/djuqwD9DsdTzJQa5O7sQtUGVWN7QLwZw9vBz7Aiz2osmF9?= =?utf-8?q?rDB+iPP5S44sP/fqRx+6T7s/3uwaZ6ZgYgiFHBpESTp1GEpf09Otb0Fj5L/LFiXDn?= =?utf-8?q?EARwH8woPEn2XzODQfeuRF35RlYXsoV8My2f77t4c+a1xzqqdCb0uQlxrZ5YeNfpG?= =?utf-8?q?kZiJ/LeliCR6Oa1MXIAtleJFw2oa32tC2Kl1cKUUynyUWdofrBPGfFBQIqjCrGstO?= =?utf-8?q?dea3mu8aQFT7DeZzH1Y0s63JO6HTkknRUbgY6kF74trcq88X/AnPd9ADJucqrmfjQ?= =?utf-8?q?nQ9v1t5O/6yXAW3uLcKylasLJmriuK2IUyROM6BlnYa1jgN8O+57UxAY+d3sUTp9u?= =?utf-8?q?i9D65VBEHVuxpVaX1vU69Q57Kh2ChRgqdrOj7KDiPE1pWF+tQnHPDVTw4lfd/1GRT?= =?utf-8?q?OwI6cP00w+weyp/Z/1DmpLy/sJubaWvJt0N5cQoJ4DQ5LtkWKKxf+yT1SNt6M1Kj1?= =?utf-8?q?j1bfFwLpth59kYYhO1VafVeZR13dhaRWP71DWZF0dAtM50MJev431s89hhlzl+oEv?= =?utf-8?q?hSb3r33cbshvXVrc0DswDmV2xFX1XH0bI1kJlOzlqWqf9Lua6ZnA5/qddA8mEwoa2?= =?utf-8?q?iNhmeztEL5Ud2xg4wn8QZxm+9zIQRVMTbLuElujIU8X2+AcP3aahc1/2AbEVXrTY5?= =?utf-8?q?3Tpdnu+7q8RtwRUm9ntNT6BYAGqN3uRfN3x98AHyYGvXvnICXWgu6RmkSmvgUbUdY?= =?utf-8?q?l9PijgZ1r+VSavCpTC1ZJ0vsT7/uZ3UVo0QLT4+xD1tPvhelyTLEgRNg=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 629f2247-8373-4336-4f63-08dc529ab80b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:26:04.6719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4tTfeiYsc3EM64dZdMXgZiT2Fv0pVYGCqRIplyq27Z8FoSjZlB52uA0T5X7X1dnx//W34a+bz0IeXHcBKj4kdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_152616_935567_0A233719 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org can1_lpcg: clock-controller@5ace0000 { ... Col1 Col2 clocks = <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices = , , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver &flexcan2 { clocks = <&can1_lpcg 1>, <&can1_lpcg 0>; ^^ ^^ Should be: clocks = <&can1_lpcg IMX_LPCG_CLK_4>, <&can1_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. So flexcan get IMX_SC_PM_CLK_PER by <&can1_lpcg 1> and <&can1_lpcg 0>. Although function work, code logic is wrong. Fix it by using correct clock indices. Cc: stable@vger.kernel.org Fixes: be85831de020 ("arm64: dts: imx8qm: add can node in devicetree") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi index 69cb8676732ea..475702947afff 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi @@ -112,15 +112,15 @@ &flexcan1 { }; &flexcan2 { - clocks = <&can1_lpcg 1>, - <&can1_lpcg 0>; + clocks = <&can1_lpcg IMX_LPCG_CLK_4>, + <&can1_lpcg IMX_LPCG_CLK_0>; assigned-clocks = <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>; fsl,clk-source = /bits/ 8 <1>; }; &flexcan3 { - clocks = <&can2_lpcg 1>, - <&can2_lpcg 0>; + clocks = <&can2_lpcg IMX_LPCG_CLK_4>, + <&can2_lpcg IMX_LPCG_CLK_0>; assigned-clocks = <&clk IMX_SC_R_CAN_2 IMX_SC_PM_CLK_PER>; fsl,clk-source = /bits/ 8 <1>; };