From patchwork Tue Apr 2 07:22:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613488 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F6DCD1284 for ; Tue, 2 Apr 2024 07:24:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.699998.1092474 (Exim 4.92) (envelope-from ) id 1rrYVL-00041v-SI; Tue, 02 Apr 2024 07:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 699998.1092474; Tue, 02 Apr 2024 07:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVL-00041l-Jl; Tue, 02 Apr 2024 07:24:23 +0000 Received: by outflank-mailman (input) for mailman id 699998; Tue, 02 Apr 2024 07:24:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVK-0003jQ-8f for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:22 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05647a33-f0c2-11ee-a1ef-f123f15fe8a2; Tue, 02 Apr 2024 09:24:20 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id 772D94EE0742; Tue, 2 Apr 2024 09:24:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05647a33-f0c2-11ee-a1ef-f123f15fe8a2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 1/7] xen/domctl: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:04 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich --- xen/common/domctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index d94a9dae91..f2e0e36a17 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -316,6 +316,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) d = rcu_lock_domain_by_id(op->domain); if ( !d ) return -ESRCH; + break; } ret = xsm_domctl(XSM_OTHER, d, op->cmd); From patchwork Tue Apr 2 07:22:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 709F2CD1294 for ; Tue, 2 Apr 2024 07:24:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.699997.1092468 (Exim 4.92) (envelope-from ) id 1rrYVL-0003yO-FK; Tue, 02 Apr 2024 07:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 699997.1092468; Tue, 02 Apr 2024 07:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVL-0003yE-BZ; Tue, 02 Apr 2024 07:24:23 +0000 Received: by outflank-mailman (input) for mailman id 699997; Tue, 02 Apr 2024 07:24:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVJ-0003jD-LS for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05a21cdf-f0c2-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 09:24:20 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id 082074EE0744; Tue, 2 Apr 2024 09:24:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05a21cdf-f0c2-11ee-afe5-a90da7624cb6 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 2/7] console: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:05 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich --- xen/drivers/char/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index ccd5f8cc14..e185f80efe 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -568,6 +568,8 @@ static void __serial_rx(char c) if ( d != NULL ) rcu_unlock_domain(d); + + break; } #endif } From patchwork Tue Apr 2 07:22:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48706CD1293 for ; Tue, 2 Apr 2024 07:24:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.699999.1092478 (Exim 4.92) (envelope-from ) id 1rrYVM-00046V-4V; Tue, 02 Apr 2024 07:24:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 699999.1092478; Tue, 02 Apr 2024 07:24:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVL-00044X-VM; Tue, 02 Apr 2024 07:24:23 +0000 Received: by outflank-mailman (input) for mailman id 699999; Tue, 02 Apr 2024 07:24:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVK-0003jD-Lj for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:22 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05dbd7cd-f0c2-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 09:24:20 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id 8B4A04EE0743; Tue, 2 Apr 2024 09:24:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05dbd7cd-f0c2-11ee-afe5-a90da7624cb6 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , George Dunlap , Dario Faggioli Subject: [XEN PATCH 3/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:06 +0200 Message-Id: <8f91430e37594831dd8d92ab630477be88417b49.1712042178.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Use pseudo-keyword fallthrough to meet the requirements to deviate MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini --- xen/common/sched/credit2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index c76330d79d..0962b52415 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -3152,8 +3152,8 @@ static int cf_check csched2_sys_cntl( printk(XENLOG_INFO "Disabling context switch rate limiting\n"); prv->ratelimit_us = params->ratelimit_us; write_unlock_irqrestore(&prv->lock, flags); + fallthrough; - /* FALLTHRU */ case XEN_SYSCTL_SCHEDOP_getinfo: params->ratelimit_us = prv->ratelimit_us; break; From patchwork Tue Apr 2 07:22:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C92FCD1297 for ; Tue, 2 Apr 2024 07:24:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.700001.1092505 (Exim 4.92) (envelope-from ) id 1rrYVN-0004pO-Sc; Tue, 02 Apr 2024 07:24:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 700001.1092505; Tue, 02 Apr 2024 07:24:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVN-0004nD-Mp; Tue, 02 Apr 2024 07:24:25 +0000 Received: by outflank-mailman (input) for mailman id 700001; Tue, 02 Apr 2024 07:24:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVL-0003jD-M9 for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 062e93db-f0c2-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 09:24:21 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id E6E614EE0746; Tue, 2 Apr 2024 09:24:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 062e93db-f0c2-11ee-afe5-a90da7624cb6 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 4/7] xen/evtchn: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:07 +0200 Message-Id: <98c4197ab3bcf82d0055836cf950f1268dbcc91c.1712042178.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich --- xen/common/event_channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 20f586cf5e..aceee0695f 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -853,6 +853,7 @@ int evtchn_send(struct domain *ld, unsigned int lport) break; default: ret = -EINVAL; + break; } out: From patchwork Tue Apr 2 07:22:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B128C6FD1F for ; Tue, 2 Apr 2024 07:24:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.700000.1092487 (Exim 4.92) (envelope-from ) id 1rrYVM-0004FG-Ky; Tue, 02 Apr 2024 07:24:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 700000.1092487; Tue, 02 Apr 2024 07:24:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVM-0004DM-Ao; Tue, 02 Apr 2024 07:24:24 +0000 Received: by outflank-mailman (input) for mailman id 700000; Tue, 02 Apr 2024 07:24:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVL-0003jQ-Ge for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 068280dd-f0c2-11ee-a1ef-f123f15fe8a2; Tue, 02 Apr 2024 09:24:22 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id 77F4D4EE0743; Tue, 2 Apr 2024 09:24:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 068280dd-f0c2-11ee-a1ef-f123f15fe8a2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , George Dunlap , Dario Faggioli Subject: [XEN PATCH 5/7] xen/sched: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:08 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich --- xen/common/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 3e48da1cdd..0cb33831d2 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2007,6 +2007,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) default: ret = -ENOSYS; + break; } return ret; From patchwork Tue Apr 2 07:22:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 957F2CD1296 for ; Tue, 2 Apr 2024 07:24:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.700002.1092517 (Exim 4.92) (envelope-from ) id 1rrYVP-0005DC-4k; Tue, 02 Apr 2024 07:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 700002.1092517; Tue, 02 Apr 2024 07:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVP-0005Cf-11; Tue, 02 Apr 2024 07:24:27 +0000 Received: by outflank-mailman (input) for mailman id 700002; Tue, 02 Apr 2024 07:24:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVM-0003jD-MO for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:24 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06b4bb90-f0c2-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 09:24:22 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id DEF644EE073F; Tue, 2 Apr 2024 09:24:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06b4bb90-f0c2-11ee-afe5-a90da7624cb6 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu Subject: [XEN PATCH 6/7] xen/vm-event: address a violation of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:09 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add break statement to address a violation of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause "). No functional change. Signed-off-by: Federico Serafini Acked-by: Tamas K Lengyel --- xen/common/vm_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index ecf49c38a9..fbf1aa0848 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -770,6 +770,7 @@ int vm_event_domctl(struct domain *d, struct xen_domctl_vm_event_op *vec) default: rc = -ENOSYS; + break; } return rc; From patchwork Tue Apr 2 07:22:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13613491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06F82CD1284 for ; Tue, 2 Apr 2024 07:24:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.700003.1092522 (Exim 4.92) (envelope-from ) id 1rrYVP-0005IU-I2; Tue, 02 Apr 2024 07:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 700003.1092522; Tue, 02 Apr 2024 07:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVP-0005Hf-C7; Tue, 02 Apr 2024 07:24:27 +0000 Received: by outflank-mailman (input) for mailman id 700003; Tue, 02 Apr 2024 07:24:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrYVN-0003jD-MN for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 07:24:25 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0700aa4f-f0c2-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 09:24:22 +0200 (CEST) Received: from truciolo.homenet.telecomitalia.it (host-82-59-164-46.retail.telecomitalia.it [82.59.164.46]) by support.bugseng.com (Postfix) with ESMTPSA id 5A84B4EE0745; Tue, 2 Apr 2024 09:24:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0700aa4f-f0c2-11ee-afe5-a90da7624cb6 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 7/7] vsprintf: address violations of MISRA C:2012 Rule 16.3 Date: Tue, 2 Apr 2024 09:22:10 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 MISRA C:2012 Rule 16.3 states: "An unconditional `break' statement shall terminate every switch-clause". Add break statement to address violations of the rule or add pseudo-keyword fallthrough to meet the requirements to deviate it. No functional change. Signed-off-by: Federico Serafini --- xen/common/vsprintf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c index c49631c0a4..612751c90f 100644 --- a/xen/common/vsprintf.c +++ b/xen/common/vsprintf.c @@ -377,7 +377,7 @@ static char *pointer(char *str, const char *end, const char **fmt_ptr, str = number(str, end, hex_buffer[i], 16, 2, -1, ZEROPAD); if ( ++i == field_width ) - return str; + break; if ( sep ) { @@ -386,6 +386,8 @@ static char *pointer(char *str, const char *end, const char **fmt_ptr, ++str; } } + + return str; } case 'p': /* PCI SBDF. */ @@ -619,6 +621,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'X': flags |= LARGE; + fallthrough; case 'x': base = 16; break; @@ -626,6 +629,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case 'd': case 'i': flags |= SIGN; + fallthrough; case 'u': break;