From patchwork Fri Feb 22 16:47:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10826643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C01A817E9 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9784329D8 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CF0932A09; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DD59329D8 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbfBVQrc (ORCPT ); Fri, 22 Feb 2019 11:47:32 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:54188 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbfBVQrc (ORCPT ); Fri, 22 Feb 2019 11:47:32 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1MGiAV2158986 for ; Fri, 22 Feb 2019 16:47:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=7bpymWF63sgdGZ1fN6djZBO80E3BoHHpiXWq5fqzCKQ=; b=lvd3xJyvULgS3nvA/OJtEpATtm/pATueJajn2RawOQQ/Mi6+a38Zn8Z/KJ3gNshGGf7O mK1zL4ELjOTwN3tdWVgm8OvCcpWCams0s5r6mnitKe1JoMfcufBbuRQwHFfD6MLF9xaI RZp+5gRtmIkpYysHNHBLRR02T2hco4WZwtr1olxnn1cHou12RJw7w69dwx0KCdytkdoE +K7jsUdvac4ilI/BCPpPTGhQroCP5PzZSom1v29ugbn51sXT2HqxhqOhadlA+oPRls8i UWir32jyA+Ub5uF1Dve/KSEF/c8+XIElO3ZsKkKlBm5UK8Zj2qNc0rfxP23vGKhoaN9I SA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2qp81erevq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:30 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGlP7B011316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:25 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1MGlOp5030474 for ; Fri, 22 Feb 2019 16:47:25 GMT Received: from localhost (/10.159.254.125) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Feb 2019 08:47:24 -0800 Subject: [PATCH 1/4] xfs_restore: refactor open-coded file creation code From: "Darrick J. Wong" To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 22 Feb 2019 08:47:24 -0800 Message-ID: <155085404462.5141.11851529133557195388.stgit@magnolia> In-Reply-To: <155085403848.5141.1866278990901950186.stgit@magnolia> References: <155085403848.5141.1866278990901950186.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9175 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902220118 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Create a helper to unlink, recreate, and reserve space in a file so that we don't have two open-coded versions. We lose the broken ALLOCSP code since it never worked anyway. Signed-off-by: Darrick J. Wong --- restore/dirattr.c | 97 ++++++++++++++++++----------------------------------- restore/dirattr.h | 2 + restore/namreg.c | 70 +++----------------------------------- 3 files changed, 41 insertions(+), 128 deletions(-) diff --git a/restore/dirattr.c b/restore/dirattr.c index 5368664..0fb2877 100644 --- a/restore/dirattr.c +++ b/restore/dirattr.c @@ -55,6 +55,37 @@ #include "openutil.h" #include "mmap.h" +/* Create a file, try to reserve space for it, and return the fd. */ +int +create_filled_file( + const char *pathname, + off64_t size) +{ + struct flock64 fl = { + .l_len = size, + }; + int fd; + int ret; + + (void)unlink(pathname); + + fd = open(pathname, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR); + if (fd < 0) + return fd; + + ret = ioctl(fd, XFS_IOC_RESVSP64, &fl); + if (ret && errno != ENOTTY) + mlog(MLOG_VERBOSE | MLOG_NOTE, +_("attempt to reserve %lld bytes for %s using %s failed: %s (%d)\n"), + size, pathname, "XFS_IOC_RESVSP64", + strerror(errno), errno); + if (ret == 0) + goto done; + +done: + return fd; +} + /* structure definitions used locally ****************************************/ /* node handle limits @@ -238,13 +269,8 @@ dirattr_init(char *hkdir, bool_t resume, uint64_t dircnt) return BOOL_FALSE; } } else { - /* create the dirattr file, first unlinking any older version - * laying around - */ - (void)unlink(dtp->dt_pathname); - dtp->dt_fd = open(dtp->dt_pathname, - O_RDWR | O_CREAT | O_EXCL, - S_IRUSR | S_IWUSR); + dtp->dt_fd = create_filled_file(dtp->dt_pathname, + DIRATTR_PERS_SZ + (dircnt * sizeof(struct dirattr))); if (dtp->dt_fd < 0) { mlog(MLOG_NORMAL | MLOG_ERROR, _( "could not create directory attributes file %s: " @@ -253,63 +279,6 @@ dirattr_init(char *hkdir, bool_t resume, uint64_t dircnt) strerror(errno)); return BOOL_FALSE; } - - /* reserve space for the backing store. try to use RESVSP64. - * if doesn't work, try ALLOCSP64. the former is faster, as - * it does not zero the space. - */ - { - bool_t successpr; - unsigned int ioctlcmd; - int loglevel; - size_t trycnt; - - for (trycnt = 0, - successpr = BOOL_FALSE, - ioctlcmd = XFS_IOC_RESVSP64, - loglevel = MLOG_VERBOSE - ; - ! successpr && trycnt < 2 - ; - trycnt++, - ioctlcmd = XFS_IOC_ALLOCSP64, - loglevel = max(MLOG_NORMAL, loglevel - 1)) { - off64_t initsz; - struct flock64 flock64; - int rval; - - if (! ioctlcmd) { - continue; - } - - initsz = (off64_t)DIRATTR_PERS_SZ - + - ((off64_t)dircnt * sizeof(dirattr_t)); - flock64.l_whence = 0; - flock64.l_start = 0; - flock64.l_len = initsz; - rval = ioctl(dtp->dt_fd, ioctlcmd, &flock64); - if (rval) { - if (errno != ENOTTY) { - mlog(loglevel | MLOG_NOTE, _( - "attempt to reserve %lld bytes for %s " - "using %s " - "failed: %s (%d)\n"), - initsz, - dtp->dt_pathname, - ioctlcmd == XFS_IOC_RESVSP64 - ? - "XFS_IOC_RESVSP64" - : - "XFS_IOC_ALLOCSP64", - strerror(errno), - errno); - } - } else { - successpr = BOOL_TRUE; - } - } - } } /* mmap the persistent descriptor diff --git a/restore/dirattr.h b/restore/dirattr.h index dd37a98..e81e69c 100644 --- a/restore/dirattr.h +++ b/restore/dirattr.h @@ -88,4 +88,6 @@ extern bool_t dirattr_cb_extattr(dah_t dah, extattrhdr_t *ahdrp, void *ctxp); +int create_filled_file(const char *pathname, off64_t size); + #endif /* DIRATTR_H */ diff --git a/restore/namreg.c b/restore/namreg.c index 89fa5ef..d0d5e89 100644 --- a/restore/namreg.c +++ b/restore/namreg.c @@ -37,6 +37,10 @@ #include "namreg.h" #include "openutil.h" #include "mmap.h" +#include "global.h" +#include "content.h" +#include "content_inode.h" +#include "dirattr.h" /* structure definitions used locally ****************************************/ @@ -153,13 +157,8 @@ namreg_init(char *hkdir, bool_t resume, uint64_t inocnt) return BOOL_FALSE; } } else { - /* create the namreg file, first unlinking any older version - * laying around - */ - (void)unlink(ntp->nt_pathname); - ntp->nt_fd = open(ntp->nt_pathname, - O_RDWR | O_CREAT | O_EXCL, - S_IRUSR | S_IWUSR); + ntp->nt_fd = create_filled_file(ntp->nt_pathname, + NAMREG_PERS_SZ + (inocnt * NAMREG_AVGLEN)); if (ntp->nt_fd < 0) { mlog(MLOG_NORMAL | MLOG_ERROR, _( "could not create name registry file %s: " @@ -168,63 +167,6 @@ namreg_init(char *hkdir, bool_t resume, uint64_t inocnt) strerror(errno)); return BOOL_FALSE; } - - /* reserve space for the backing store. try to use RESVSP64. - * if doesn't work, try ALLOCSP64. the former is faster, as - * it does not zero the space. - */ - { - bool_t successpr; - unsigned int ioctlcmd; - int loglevel; - size_t trycnt; - - for (trycnt = 0, - successpr = BOOL_FALSE, - ioctlcmd = XFS_IOC_RESVSP64, - loglevel = MLOG_VERBOSE - ; - ! successpr && trycnt < 2 - ; - trycnt++, - ioctlcmd = XFS_IOC_ALLOCSP64, - loglevel = max(MLOG_NORMAL, loglevel - 1)) { - off64_t initsz; - struct flock64 flock64; - int rval; - - if (! ioctlcmd) { - continue; - } - - initsz = (off64_t)NAMREG_PERS_SZ - + - ((off64_t)inocnt * NAMREG_AVGLEN); - flock64.l_whence = 0; - flock64.l_start = 0; - flock64.l_len = initsz; - rval = ioctl(ntp->nt_fd, ioctlcmd, &flock64); - if (rval) { - if (errno != ENOTTY) { - mlog(loglevel | MLOG_NOTE, _( - "attempt to reserve %lld bytes for %s " - "using %s " - "failed: %s (%d)\n"), - initsz, - ntp->nt_pathname, - ioctlcmd == XFS_IOC_RESVSP64 - ? - "XFS_IOC_RESVSP64" - : - "XFS_IOC_ALLOCSP64", - strerror(errno), - errno); - } - } else { - successpr = BOOL_TRUE; - } - } - } } /* mmap the persistent descriptor From patchwork Fri Feb 22 16:47:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10826645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E760413B5 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D37A2329D8 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7C0D32A03; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EE0132A01 for ; Fri, 22 Feb 2019 16:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725986AbfBVQrd (ORCPT ); Fri, 22 Feb 2019 11:47:33 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:52012 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbfBVQrc (ORCPT ); Fri, 22 Feb 2019 11:47:32 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1MGiL6R159692 for ; Fri, 22 Feb 2019 16:47:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=2Vaxo6BBpIb+AVkdEGV7bdFC6b7LMj5FivU2Z2/Iuj0=; b=NKoFCSMrM7deEWnxnnuSNMKUnul1H1F/KHbn6HnxrhjhmCeSy2/S5tdlAUgtVZhOMqFE Hx64t0MyUUoWUOeaRV/kaI/D+egP8GrwNRDMRLwJ/A1Z8iK1n4I1GLmtqz9LbXWyTgyM CjlVXOGURwC0+3fu5gmNUeVxFOh1+Fg+uT8Cx3dfcgH82ewpSFp8H9AsOBpbjrkOMQdM n8Nwz10wWCm7pNKYxXtNN+Hg5i5ez/dykeKoIcQYZsxht9BtufucjZ4Oc7uwqzG9UXga 1C3TF2sqH+SC6BoO5arWLhmYWXWMgd71iga0x8aw3EmwdaiJSr5uUUgzYQ4qSYg3ctdn MQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2qpb5s071p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:31 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGlVcZ010477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:31 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1MGlVEV016733 for ; Fri, 22 Feb 2019 16:47:31 GMT Received: from localhost (/10.159.254.125) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Feb 2019 08:47:30 -0800 Subject: [PATCH 2/4] xfs_restore: check return value From: "Darrick J. Wong" To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 22 Feb 2019 08:47:30 -0800 Message-ID: <155085405082.5141.12150949924461780415.stgit@magnolia> In-Reply-To: <155085403848.5141.1866278990901950186.stgit@magnolia> References: <155085403848.5141.1866278990901950186.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9175 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=927 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902220118 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Check the return value of the unlink call when creating a new file. Signed-off-by: Darrick J. Wong Reviewed-by: Allison Collins --- restore/dirattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/restore/dirattr.c b/restore/dirattr.c index 0fb2877..4257a1b 100644 --- a/restore/dirattr.c +++ b/restore/dirattr.c @@ -67,7 +67,9 @@ create_filled_file( int fd; int ret; - (void)unlink(pathname); + ret = unlink(pathname); + if (ret && errno != ENOENT) + return ret; fd = open(pathname, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR); if (fd < 0) From patchwork Fri Feb 22 16:47:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10826647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8EEE917E9 for ; Fri, 22 Feb 2019 16:47:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76B22329D8 for ; Fri, 22 Feb 2019 16:47:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 691B832A03; Fri, 22 Feb 2019 16:47:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22B9E329D8 for ; Fri, 22 Feb 2019 16:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726229AbfBVQrk (ORCPT ); Fri, 22 Feb 2019 11:47:40 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:39420 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbfBVQrk (ORCPT ); Fri, 22 Feb 2019 11:47:40 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1MGiBN8154826 for ; Fri, 22 Feb 2019 16:47:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Eclkxvyhiv2hmxqNY5tiBag+ZRA0s3xXR/W5HJg0In8=; b=wR4/tzb24WAPMPbsrDWNCfDztVfsqIqM2OyLqji7G502/X3q6ieeeh392d9OuG8roi4W fBRfozEiGRXvbizzKeEi+yuGWA9PAg1USsIx4G2erp9RTVw5SjV2+LCMKAdLzLhpCzzx K1m0IxsxhQUaTg9Xml/pdcs2AR62KClHm9bAYfdk287JxdLwrUkLct9v9ILU6i9YT9SF R05vrHZ/i+V1gXeTQLDwU5o1c2zbNmOwhzvkDHJ+Bgk27VGTxJgonYviDRMLSwplrkNx opmMEtv0VoI3JvryJ/Zc9plZjSRNrvwG/uqjpp+EJtbDZGqR0bROmWU1D5MPcaRIEldr jw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2qp9xugauv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:38 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGlcaw010924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:38 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGlcTv025192 for ; Fri, 22 Feb 2019 16:47:38 GMT Received: from localhost (/10.159.254.125) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Feb 2019 08:47:38 -0800 Subject: [PATCH 3/4] xfs_restore: fix unsupported ioctl detection From: "Darrick J. Wong" To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 22 Feb 2019 08:47:37 -0800 Message-ID: <155085405698.5141.702624754882653044.stgit@magnolia> In-Reply-To: <155085403848.5141.1866278990901950186.stgit@magnolia> References: <155085403848.5141.1866278990901950186.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9175 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=872 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902220118 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Linux ioctls can return ENOTTY or EOPNOTSUPP, so filter both of them when logging reservation failure. Signed-off-by: Darrick J. Wong Reviewed-by: Allison Collins --- restore/dirattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/restore/dirattr.c b/restore/dirattr.c index 4257a1b..3fa8fb6 100644 --- a/restore/dirattr.c +++ b/restore/dirattr.c @@ -76,7 +76,7 @@ create_filled_file( return fd; ret = ioctl(fd, XFS_IOC_RESVSP64, &fl); - if (ret && errno != ENOTTY) + if (ret && (errno != EOPNOTSUPP && errno != ENOTTY)) mlog(MLOG_VERBOSE | MLOG_NOTE, _("attempt to reserve %lld bytes for %s using %s failed: %s (%d)\n"), size, pathname, "XFS_IOC_RESVSP64", From patchwork Fri Feb 22 16:47:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10826649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 728B417E9 for ; Fri, 22 Feb 2019 16:47:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DC7F32A01 for ; Fri, 22 Feb 2019 16:47:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5256D32A09; Fri, 22 Feb 2019 16:47:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6FC1232A01 for ; Fri, 22 Feb 2019 16:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbfBVQrv (ORCPT ); Fri, 22 Feb 2019 11:47:51 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:39624 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbfBVQru (ORCPT ); Fri, 22 Feb 2019 11:47:50 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1MGidm6155034 for ; Fri, 22 Feb 2019 16:47:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Nwy/e5h0CZEKkTN10twdb7wUfyCilDyyQgv0AgvDozo=; b=OxecB5ViuveiYtfz9X93W0OJkHLfV5FnydcItL9VEVj5DPQrqu++dMDDtrXilaatcm8G /R7dIeyqGv6mqSP6yooRCrTOrak3vNY2hNj1zGdcL8CUYZebHv2I+Huu4aphwa2g8utf EEoD8DMeEXlDI58n60IYvW+gXKTj/7PHuKQhwTBFh5wm+Q5zXN8L28121SUK4c96blWf ZBCvurP7rERUFL7muR+x2MWOv8JWerfbuZD9ToPmrNcVYxik5woD6ML4ieFiqDB6Bybg f+bqlUp1GZq+2Al32JidyOd520enHRiXrALNE2TxReK/cyU5LbnBpqboM/CPTTFND+BR JQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qp9xugavw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:49 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGlm1v011184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Feb 2019 16:47:48 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1MGllO5025240 for ; Fri, 22 Feb 2019 16:47:47 GMT Received: from localhost (/10.159.254.125) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Feb 2019 08:47:47 -0800 Subject: [PATCH 4/4] xfs_restore: support fallocate when reserving space for a file From: "Darrick J. Wong" To: darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 22 Feb 2019 08:47:44 -0800 Message-ID: <155085406431.5141.9035398131483539445.stgit@magnolia> In-Reply-To: <155085403848.5141.1866278990901950186.stgit@magnolia> References: <155085403848.5141.1866278990901950186.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9175 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=15 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902220118 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Update the file creation helper to try fallocate when restoring a filesystem before it tries RESVSP. Signed-off-by: Darrick J. Wong Reviewed-by: Allison Collins --- configure.ac | 2 ++ include/builddefs.in | 1 + m4/Makefile | 1 + m4/package_libcdev.m4 | 15 +++++++++++++++ restore/Makefile | 4 ++++ restore/dirattr.c | 11 +++++++++++ 6 files changed, 34 insertions(+) create mode 100644 m4/package_libcdev.m4 diff --git a/configure.ac b/configure.ac index a77054c..73dedd7 100644 --- a/configure.ac +++ b/configure.ac @@ -84,6 +84,8 @@ AC_PACKAGE_NEED_ATTRIBUTES_H AC_PACKAGE_NEED_ATTRIBUTES_MACROS AC_PACKAGE_NEED_ATTRGET_LIBATTR +AC_HAVE_FALLOCATE + AC_MANUAL_FORMAT AC_CONFIG_FILES([include/builddefs]) diff --git a/include/builddefs.in b/include/builddefs.in index 269c928..1c7e12f 100644 --- a/include/builddefs.in +++ b/include/builddefs.in @@ -69,6 +69,7 @@ ENABLE_SHARED = @enable_shared@ ENABLE_GETTEXT = @enable_gettext@ HAVE_ZIPPED_MANPAGES = @have_zipped_manpages@ +HAVE_FALLOCATE = @have_fallocate@ GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall # -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-decl diff --git a/m4/Makefile b/m4/Makefile index 9a35056..ae452f7 100644 --- a/m4/Makefile +++ b/m4/Makefile @@ -16,6 +16,7 @@ LSRCFILES = \ manual_format.m4 \ package_attrdev.m4 \ package_globals.m4 \ + package_libcdev.m4 \ package_ncurses.m4 \ package_pthread.m4 \ package_utilies.m4 \ diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4 new file mode 100644 index 0000000..050f82c --- /dev/null +++ b/m4/package_libcdev.m4 @@ -0,0 +1,15 @@ +# +# Check if we have a fallocate libc call (Linux) +# +AC_DEFUN([AC_HAVE_FALLOCATE], + [ AC_MSG_CHECKING([for fallocate]) + AC_TRY_LINK([ +#include +#include + ], [ + fallocate(0, 0, 0, 0); + ], have_fallocate=yes + AC_MSG_RESULT(yes), + AC_MSG_RESULT(no)) + AC_SUBST(have_fallocate) + ]) diff --git a/restore/Makefile b/restore/Makefile index 20c870a..ac3f8c8 100644 --- a/restore/Makefile +++ b/restore/Makefile @@ -102,6 +102,10 @@ LTDEPENDENCIES = $(LIBRMT) LCFLAGS = -DRESTORE +ifeq ($(HAVE_FALLOCATE),yes) +LCFLAGS += -DHAVE_FALLOCATE +endif + default: depend $(LTCOMMAND) include $(BUILDRULES) diff --git a/restore/dirattr.c b/restore/dirattr.c index 3fa8fb6..82eb1de 100644 --- a/restore/dirattr.c +++ b/restore/dirattr.c @@ -75,6 +75,17 @@ create_filled_file( if (fd < 0) return fd; +#ifdef HAVE_FALLOCATE + ret = fallocate(fd, 0, 0, size); + if (ret && (errno != EOPNOTSUPP && errno != ENOTTY)) + mlog(MLOG_VERBOSE | MLOG_NOTE, +_("attempt to reserve %lld bytes for %s using %s failed: %s (%d)\n"), + size, pathname, "fallocate", + strerror(errno), errno); + if (ret == 0) + goto done; +#endif + ret = ioctl(fd, XFS_IOC_RESVSP64, &fl); if (ret && (errno != EOPNOTSUPP && errno != ENOTTY)) mlog(MLOG_VERBOSE | MLOG_NOTE,