From patchwork Wed Apr 3 03:10:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13614901 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891581C29F for ; Wed, 3 Apr 2024 03:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712113863; cv=none; b=KNh2Dz0TvXwuEPFL3rQKWPTr3UqqmKRYZraN10jQoEEkakYtJfIsmsm2M3mMrUVzhwsTO+XW4LAoikNPcbTi8DuljirmHk2oJXxg5y2PV7o3a/huzhWZdMvvr1UEmFAkD1FVFetun/xqcaldaiNznjjPwWz1Wh+ClNB0H1qvJZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712113863; c=relaxed/simple; bh=zsWd0i7Kk841N8SmXs9tnRrxsAh7c4DjxAGKwlg50z0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n2iZoJQR/ikJAkbdTwgE4yxGDfgCnFvd5AqW3kLBzJmghTuVMLNJesZ91NQ9cw9lauVpTwdePHjB2ULXqLrvsYC/gpARb3ql0CVl64lM+cnzDh5E1XAPCzDdnAnSH7Kg59V7LTG87uhP/87cSnHBDe+8qedeixYtJcijevDynd0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MfnhrtJk; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MfnhrtJk" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d718efedb2so87712311fa.0 for ; Tue, 02 Apr 2024 20:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712113860; x=1712718660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=azM/yEhe+aJWB0XejrkxVawtRjtvg2L/lzix2nFDCVo=; b=MfnhrtJksEPy8eIUchMDWWTTJzyAYTQJu0X9rC5nazuwydPu0n/ky95lKxBtI7T0WT WkfC78Gh2UiEJ1lUlzZTkd6ckcKgUFR+yuJIpOr2L04tS6LQEViqZB3+ZEQbrv7QJK1p UyZ0Y4fBROLXAErgfCJZ8wUHrEkolybEnjhwKFnsRFQ5nnhONOPT8ID+6HNjFEjdMjPu Txb0Nv9O2pFddk3H8nNiLJdh+Inu7iDOAjUiRAePsAdSUJMzXTItcI1V26SLGWS5AvXo GHAPkgdMtoX99JyxNkpUkxyDRUOZ8P/Fts6qrTm3xN6W372S8EIvaHQL+lLlFMlZyJNL /nJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712113860; x=1712718660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azM/yEhe+aJWB0XejrkxVawtRjtvg2L/lzix2nFDCVo=; b=VoYWrn1W5Bi+rpdphpmn9y7lKGYIfUY+MekeawaXRyzsDWIX87iwVE6w8n4Mf2+LaV 09Qyf2mBNfEZYhZih3nAapIC4/A2GpS+b1gBrlJiYoWkxR18KWsVgO9byGsb7EhEeRcw 3gqzTLsNNm+4XG6c3l++w7W0j36ORKWhi9fntbdb8E/hvI62QZlITzWEXdvUw9zixSia MeHdKBxkrg0jT7Sy77AjSH29w5HZpJ7L9AXAVHfPTITOdGoPc5NAlzPzIFkfUHbHVS2V FUp+F0xwW/z+sG09CqUm+0iECLwLGipRyhOA17DbvzBCi6xvBiuxoqJN65U8B1eqiMMi OHkQ== X-Gm-Message-State: AOJu0YxQLaooQDbq/ifaMxuPFhtuV29PIQWIbpTfAxnuRJisetUrR4HW 4Ciz0R1Z+h+EHsXyCigh7a6qYliXycezSnKn6piRcIqdnOQV7SZfJzdSSwwW1uY= X-Google-Smtp-Source: AGHT+IHKwJzVCx/ob14SfNesIFCCJ67C8Z31d/2TZkOdKwb+Ve1tW2YfR7Ykl1Vp/JTVC19y4fSjpg== X-Received: by 2002:a05:651c:83:b0:2d6:c749:17bc with SMTP id 3-20020a05651c008300b002d6c74917bcmr2738152ljq.31.1712113859836; Tue, 02 Apr 2024 20:10:59 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id k11-20020a2ea26b000000b002d808b86073sm1056970ljm.78.2024.04.02.20.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:10:59 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 03 Apr 2024 06:10:57 +0300 Subject: [PATCH v2 1/2] soc: qcom: pmic_glink: don't traverse clients list without a lock Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240403-pmic-glink-fix-clients-v2-1-aed4e02baacc@linaro.org> References: <20240403-pmic-glink-fix-clients-v2-0-aed4e02baacc@linaro.org> In-Reply-To: <20240403-pmic-glink-fix-clients-v2-0-aed4e02baacc@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1331; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=zsWd0i7Kk841N8SmXs9tnRrxsAh7c4DjxAGKwlg50z0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDMjCdFu6teXZQf5u4HIDTG4OqIy3j6H++7+uQ f9zBQhOLb6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZgzIwgAKCRCLPIo+Aiko 1U6pCACMRalj9NllMhjXSC/UUWdIb7M/YVky4IUqf8KnFOkh9oQttGiVbIK6C7SjFPdaVcAsOQs Z8PAzojdrGFOTwd20fjNF6Fyd6SRdPNXk+NY38iTD9d5GvuVxh2GWoaftMtGPEq6ElJOlQKt1C5 3PnCA8EAMnwRV0K5v8QX0YnwaIundIZx3Ih1w84tSBljwoVZB5p5LMq8vNN8NlXs7FNVBrffBIk fcoZjZSfMY9Uz0RVMxQle0eXVMlaRoA8tzaIUos5pDk/cxUgGoU1ogHzo5F2rRW4wclzWUOcD4X eHKodwwiwJJ/PzrxCLw1iElawAy9AsLdJeoQBdrzAdK0GMom X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Take the client_lock before traversing the clients list at the pmic_glink_state_notify_clients() function. This is required to keep the list traversal safe from concurrent modification. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Signed-off-by: Dmitry Baryshkov Reviewed-by: Andrew Halaney Reviewed-by: Mukesh Ojha --- drivers/soc/qcom/pmic_glink.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index f913e9bd57ed..2b2cdf479654 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -115,10 +115,12 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data, hdr = data; + mutex_lock(&pg->client_lock); list_for_each_entry(client, &pg->clients, node) { if (client->id == le32_to_cpu(hdr->owner)) client->cb(data, len, client->priv); } + mutex_unlock(&pg->client_lock); return 0; } @@ -168,8 +170,10 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg) } if (new_state != pg->client_state) { + mutex_lock(&pg->client_lock); list_for_each_entry(client, &pg->clients, node) client->pdr_notify(client->priv, new_state); + mutex_unlock(&pg->client_lock); pg->client_state = new_state; } } From patchwork Wed Apr 3 03:10:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13614902 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CFC31C68A for ; Wed, 3 Apr 2024 03:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712113864; cv=none; b=jSpYdof7JVAOIlt8D78ns8V3Wk8T+hJSPa13yTXJeXO7vEbQDcyZEWi4h7oikpmhYf4MUHaP9Ru1GyeA63UFlyxO//CeUGQJm0hNR4iVjYt6LATmOBnu8YLUcNTm8o/UwSgFexZl9yWcK/EEDlfZDgHcO0EUfStYzLXQ6SpLIAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712113864; c=relaxed/simple; bh=OuT4Ms0hyGHoF8Nrz/OiAPjZGEMCazNleVYauL/3yDY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y7UOSafTkT/MZdyNW3PI5nQX6o0bqzctEomijb6og/QJX16Qwaf1SgGKa/gWK1ccRqkODThnOKLHPCn3v9TOYuR7z3kaUJtUFK3cmcCAC0AMr18BtmKeF3bLLUMEx3ub6q140RjHEkbGmEeGXc/lNYMwAbTIb2DsaksGGkyGrk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ofLRt8vF; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ofLRt8vF" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d71765d3e1so60195311fa.0 for ; Tue, 02 Apr 2024 20:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712113860; x=1712718660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Wt3FSX8GBzUAFfEXsSOq4FgRCMLSgIuXafkffb5+jtk=; b=ofLRt8vFpJqVDqaPKzSIUvrWGf0YGFxd6WrCcYmBh/+0ryuhUtrX6DTWqJW/ANtaLV 36iK49CoHthZd7m3YHsiGGnytQgg7LuNeVCypGCbZj6EvPO8o3jmBSN2CT/aW0xKUxHM +mB8ils00Y5/esC0g2TI9a90TQi6j5wGhv8WudP/aXHUhlw2kRciMR33/f5xHYTef+O7 d3yympNL6YeSsdZM4CR2m3KQBJgElXjwHdrcTrW/Lv/jrNt+r/rE/tEE5HKggH8U8VRp kqG3x7xUF6VLP1EMTXEB1T9j/gwYXK/NNDSp+2CcaACw5oCRA6veo2aabhJzPewmxoY6 nfVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712113860; x=1712718660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wt3FSX8GBzUAFfEXsSOq4FgRCMLSgIuXafkffb5+jtk=; b=bfHhQEBbNTbT1XaFSSErGh2RPiaJiL8S5d/13dYjmxCIkVUdepM5X9FBfkuiTK1WRl IXjtSQB31jxkV51/GYa6r8fMcQvz62W/iEKX0AFGv2X2FmsTGTVImxMYFXe5Vx4kyLLh 8dSETwTWvLt6x4/divxypPMN5mnM1NXRko+6bWhUVaDvaDk8Hr1lwiwUxEJDQnFbdDrU z5oy1XsVYDBU0AszNZsqSDCLHLX2PGZj/zEZEU+ewshNXWGIjhbW3d3y/37FDwp1XYtm np9VtYbrHCd7ymlXSHeBVjmBL4n98Mq6ORWNuOMYMa91S+ASd2lHrvBuryl8mj6EgHsv RJGQ== X-Gm-Message-State: AOJu0Yx7pmQbr+zZF5G1EWmzazRQv9/9snLhHPR2suWaeexVtANI2FsQ H0tEBgFl/VkxIG5TH4V93yWKdRdXWk1wPNDu7PIhAyOJ8cjSj2CX44z08dGInD0= X-Google-Smtp-Source: AGHT+IGRrhrBaYek4okkBS1ZQ287krmrf/K/uKSBMtjwg2p3QX38phzQHFOMG7BBJEC+YmYgvlaXwA== X-Received: by 2002:a2e:82d7:0:b0:2d4:35d6:1984 with SMTP id n23-20020a2e82d7000000b002d435d61984mr9587317ljh.6.1712113860661; Tue, 02 Apr 2024 20:11:00 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id k11-20020a2ea26b000000b002d808b86073sm1056970ljm.78.2024.04.02.20.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:11:00 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 03 Apr 2024 06:10:58 +0300 Subject: [PATCH v2 2/2] soc: qcom: pmic_glink: notify clients about the current state Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240403-pmic-glink-fix-clients-v2-2-aed4e02baacc@linaro.org> References: <20240403-pmic-glink-fix-clients-v2-0-aed4e02baacc@linaro.org> In-Reply-To: <20240403-pmic-glink-fix-clients-v2-0-aed4e02baacc@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Andrew Halaney X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1135; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=OuT4Ms0hyGHoF8Nrz/OiAPjZGEMCazNleVYauL/3yDY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDMjCXwTVm+bM0YQpPVWy5ETBA6Gi5jc9LfqWv 5Nt1GI7/Z+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZgzIwgAKCRCLPIo+Aiko 1UyRB/9ejFH+A6ef/HfzL5au8cQ18WNJmIeffRbd0reatZmZj3ESY/KS443GfOi2FZbI/suogka hKEq9z/8bKGBYqjoQfHg4xOxJ/XtOq1iehzc3nZo6UZxLL024+MnuuXJO+opAGWE5ygpyThObEx v4p+fjExM/9J9Lf0Zx6GkSpAN0Y0d67vBFITKYbtcRLBVetRMIZs7/Oijcg+Q92VFGrpiN5ygEC 15bXWXtkt5l241yZk3YEPm7CP0oNZuSo7KKDaail5NdjgnAocJjNUkluaBYLxM9E217oL/qzSbc IRnk5Y1QEOYWNRH+93XG6D4nKDhA8z3qDXuzpefTliW3PGaZ X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A In case the client is registered after the pmic-glink recived a response from the Protection Domain mapper, it is going to miss the notification about the state. Notify clients about the current state upon registration. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Reviewed-by: Andrew Halaney Signed-off-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha --- drivers/soc/qcom/pmic_glink.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 2b2cdf479654..e85a12ec2aab 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev, client->pdr_notify = pdr; client->priv = priv; + mutex_lock(&pg->state_lock); mutex_lock(&pg->client_lock); + list_add(&client->node, &pg->clients); + client->pdr_notify(client->priv, pg->client_state); + mutex_unlock(&pg->client_lock); + mutex_unlock(&pg->state_lock); devres_add(dev, client);