From patchwork Wed Apr 3 11:31:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Travkin via B4 Relay X-Patchwork-Id: 13616004 X-Patchwork-Delegate: rjw@sisk.pl Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6EA1419BA; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; cv=none; b=f+VAi1gX16jnFFYLdMiETv4kQ+nGDcPDQrCGicO0tKQdAgykJabaZbErhRaCudQmfdqfABtrdD8v+vGLrM3jVN6WA5UroeJ3DZaLBj9AhmXlBJw6Lm19CWHPsgUf8IhFBF+cgdcMCYoIQRmGEfQM3Om4DMdDZgbgtK0xpHoxI1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; c=relaxed/simple; bh=ddqmNwmKtbMZQAEP8NHIOGf4ihAZCUA7/OjrRSzy+q8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ht6cBDI97WQfHC4GvyVfliLKv5MeE4Opax6faPvk13sAIieeUMQYhS2dNuLopXYPRuArA2LvkBQi2zK/0LzUxEUExHaFr25Yw1+StOC4OSkytAvxW/8rXiounmwIYlTkybAYER1VS0FiwzM4oAYLxB56+pulj5EfD6IOU4qtqww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q6dawHse; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q6dawHse" Received: by smtp.kernel.org (Postfix) with ESMTPS id AD8F5C43394; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712144092; bh=ddqmNwmKtbMZQAEP8NHIOGf4ihAZCUA7/OjrRSzy+q8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=q6dawHse5U4mUcIqqLq9WWPNXMoHky+1qpbZ7ZFOKIs0NFRqA8oDu3jeSb9xmQ4sp ITyNMCPq51aHG6FNxP/gYN3Jvyl7E+YargYf37c+4V3VWtp2FIgD2ZFQ+H/yr2XA+T TpfPyMfCKQW6aOJqam7x9oWS1fyuDUziNwM24fWp77ivCMEDxtF1G7gVGVOmRuHi39 V5S04uJ4nJ64J2uaqTOn+yGp87FTAhtzWHjuGY+SY0GAVlvUP6ElKqI8A3Y/6HJuuq dv8BPuWDxERR34e1l6jpuyYxUgigljEp0XQCp/UR//9fgxS6VOcfQa4+4C8JCKXkYs NzQAd79jxrISA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCA7CD1288; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) From: Nikita Travkin via B4 Relay Date: Wed, 03 Apr 2024 16:31:40 +0500 Subject: [PATCH v2 1/3] thermal: gov_power_allocator: Allow binding without cooling devices Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240403-gpa-no-cooling-devs-v2-1-79bdd8439449@trvn.ru> References: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> In-Reply-To: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> To: Lukasz Luba , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Travkin , Nikita Travkin X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1265; i=nikita@trvn.ru; h=from:subject:message-id; bh=JaFVxsb39ZVmN8wxFQAGbfSwFLxid+4cjStl8B0OjYU=; b=owEBbQKS/ZANAwAIAUMc7O4oGb91AcsmYgBmDT7ayj71lCR3yKHW00w225BagKD45KIyeK4Zo Nv9WOzvxBmJAjMEAAEIAB0WIQTAhK9UUj+qg34uxUdDHOzuKBm/dQUCZg0+2gAKCRBDHOzuKBm/ dT67D/9Y1rHlBY/kqI+8fIkl2IAGpkr14cQ8CMjProFR1nblh9duMXXVUlJ3kJPEwfyiBVueb3z OqcICS2efrky3ton7DizOwYuGNd6MuOHuk21GPsIJNOq2JbBehC8zwVI3ipFO0YrDkjhXPsh5MJ xv+ASjjpMSMjA0luUNfNrc1CdsCrf0JBNRI3vuiNU9Qcb7oCD8vaZaMj8x4oIbcyuODKQvMZudE fG0d6sSaXtHq7GOee+I9h9K8mQGawxUlISRmWT9/tSDkge5xb3p9ZjItxaAyvNaon2/cOZiGhUf +vfdhWkvpaDjhoIh7jHbuTFdWJgcHexIpqkUhw+5/rYMr+xOnecukNB6eaSfssF1NwBe+Cg4U6f Ai/zwuJP96XX7hgQ69twdM+VWDVKTLjzoVycefjdSLc+jsK4tIyiqOx9ZITQK+e3lVQiLmZFz+j Wtd5UXDRRH6Ehf1BjokhS6IhQYFegT5q6NFi3qANv8WRsP7MWVnirYkiA7pXpNe3WELEUt5lfCe YiREDoGWS+gUmQbCJFv3vHDI+bT6S9n2PP2dr99NZW1amGh7w6heLAfPAAmN5QI2KwOLVclObW9 cylBhpIRiVC9a1Wo3jxsx2Ow+J4mYfY8MAJVo6pWw0MUZ428VY2MZoQmCHAJJsN4h8TRoccukM+ lD2vYzImEvAt0DQ== X-Developer-Key: i=nikita@trvn.ru; a=openpgp; fpr=C084AF54523FAA837E2EC547431CECEE2819BF75 X-Endpoint-Received: by B4 Relay for nikita@trvn.ru/default with auth_id=151 X-Original-From: Nikita Travkin Reply-To: nikita@trvn.ru From: Nikita Travkin IPA was recently refactored to split out memory allocation into a separate funciton. That funciton was made to return -EINVAL if there is zero power_actors and thus no memory to allocate. This causes IPA to fail probing when the thermal zone has no attached cooling devices. Since cooling devices can attach after the thermal zone is created and the governer is attached to it, failing probe due to the lack of cooling devices is incorrect. Change the allocate_actors_buffer() to return success when there is no cooling devices present. Fixes: 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") Signed-off-by: Nikita Travkin Reviewed-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index 1b17dc4c219c..ec637071ef1f 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -606,7 +606,7 @@ static int allocate_actors_buffer(struct power_allocator_params *params, /* There might be no cooling devices yet. */ if (!num_actors) { - ret = -EINVAL; + ret = 0; goto clean_state; } From patchwork Wed Apr 3 11:31:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Travkin via B4 Relay X-Patchwork-Id: 13616007 X-Patchwork-Delegate: rjw@sisk.pl Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E812142E82; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; cv=none; b=fxZwwF0HcvXNETtj45+2HOvLZi33vUuhNi+AAwt7k08u/2OabGfjPVGSSAcW+M9uBAsA/Kd636L93jAQ0ZEZjFE3eZNBn2Srbm3AIcFN5UU5oUGn00XG+bDICtyzWHZgqgA/nTE4byYG/b+uMwr5TW2rsM/yPm2y4XY9iWmdWpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; c=relaxed/simple; bh=UDYQPhlA5eM2YlkU/4jxQmmyMYA7pLirv/wkMA+a+Ho=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mPu4lze0biA072mb/yoKE2axXywKHX5AnPf41PVFYMKc07rDO9ltYoBRg3+XN4idhsyyid+vB4fspFfaNtP4mSpnNQOiZdF9SPgWCyfKl2WnyXQiteAK3BUkYMvexXxY+SqSxmIsaSeJsdEaZX0wYNPZFAivjEfWYklMNHwq+TY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gHpTDr9J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gHpTDr9J" Received: by smtp.kernel.org (Postfix) with ESMTPS id BA40CC43390; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712144092; bh=UDYQPhlA5eM2YlkU/4jxQmmyMYA7pLirv/wkMA+a+Ho=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=gHpTDr9J4ABLAfofTIZdmHgcF4X53E+MsA6Kyy0gCDir23w+XUVIYdfO+3xBKjEpU Xbp9VqWa+vLSSl+HkQPE13x5tjw1UYmm/5USbToax6j4AR6S0Cs2aK84zm20xJ5gaB IWtpyV016XByzp5mRTBWI1rWgs20lywAc2gnkCF4SymrFD3Z0pFEt/s3hot2gkxMgr cWgVBJWFiARaE2fy5folobdM26YrABLFjQSkbBVuI7AH261LjHDgL32bwg4KKo0a2+ nLBeTFQSjmzHCOi2gX9ejTwsgj0oWGC1mCJaodOIVeGPNrRKXToFga+gbauU3XLHQ3 y3cgia0J9i4NQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEEFCD128A; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) From: Nikita Travkin via B4 Relay Date: Wed, 03 Apr 2024 16:31:41 +0500 Subject: [PATCH v2 2/3] thermal: gov_power_allocator: Allow binding without trip points Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240403-gpa-no-cooling-devs-v2-2-79bdd8439449@trvn.ru> References: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> In-Reply-To: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> To: Lukasz Luba , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Travkin , Nikita Travkin X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2101; i=nikita@trvn.ru; h=from:subject:message-id; bh=aX3XyiCHA+n2cubW1L4ZLcOrqQkfy11LKyh/4X5tJVw=; b=owEBbQKS/ZANAwAIAUMc7O4oGb91AcsmYgBmDT7aDjJW3qq1rSoA7iBt+c+AS53Nu9qzgj6L+ e0DzRUDI5yJAjMEAAEIAB0WIQTAhK9UUj+qg34uxUdDHOzuKBm/dQUCZg0+2gAKCRBDHOzuKBm/ dcvlD/0VZ9HatTS7LP55/Kje6FO3xvMn0crj+CRHX3Z1csFoUDnlTFaJsyFONaS5LvROuIutiJK gObneneKf2549moPVUtubHdi/vHQTdf2MWmxxSjhqyh+cNskIQk8WoRDpYVPrPY1Vma8858G4fb uhtSt4ygEXqClScqki9DlizOcWv1qqy3yMPMG/qR/Mi5C+s8rky9kbXaeN57QODSqtweVGD9Egw x027zgNdA0z8Tge29DlydmPAug6dAXHNWcSzhge48pXUjyoDTxIqfbxZGcgyV8meRB2nMCJSjXp SpJzRltV4m1uMirSDvEpoTrMrjZ1FL4he3D/0iQEcpBkBJTXfJTHiWSmlvsF5y/MFeknm8k6esu /2sW2+sD+5YY7h1nf1gPY+rVp+RPh3f10tYGLFvpLaO+6EtOFDxWPeUJJi4OAz2MQNZJbGtA7Sm J9uor6qK1GdCY8NYd1aMFRQCk6yytDi/XAkOKCQxQUsqmTPg3R9deMGLwJL5Wu3H98n+2vlWiMP lAYXs5mseKe8PKi08v0eWBmXPSmYL8ooqmv2P4nkKAmb9tqSRM/CZWDcHvFDqMLlnjaXGUm1vEY Ovppz7SH/mDIs0uu4Se0Exvel+IKYx7GV/ZvxVBI2kfE4zb7PfVLLc9CePlsPv1uzPxD0s6qcrq cvLXDNfkIfKxeFg== X-Developer-Key: i=nikita@trvn.ru; a=openpgp; fpr=C084AF54523FAA837E2EC547431CECEE2819BF75 X-Endpoint-Received: by B4 Relay for nikita@trvn.ru/default with auth_id=151 X-Original-From: Nikita Travkin Reply-To: nikita@trvn.ru From: Nikita Travkin IPA probe function was recently refactored to perform extra error checks and make sure the thermal zone has trip points necessary for the IPA operation. With this change, if a thermal zone is probed such that it has no trip points that IPA can use, IPA will fail and the TZ won't be created. This is the case if a platform defines a TZ without cooling devices and only with "hot"/"critical" trip points, often found on some Qualcomm devices [1]. Documentation across IPA code (notably get_governor_trips() kerneldoc) suggests that IPA is supposed to handle such TZ even if it won't actually do anything. This commit partially reverts the previous change to allow IPA to bind to such "empty" thermal zones. [1] arch/arm64/boot/dts/qcom/sc7180.dtsi#n4776 Fixes: e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") Signed-off-by: Nikita Travkin Reviewed-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index ec637071ef1f..e25e48d76aa7 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -679,11 +679,6 @@ static int power_allocator_bind(struct thermal_zone_device *tz) return -ENOMEM; get_governor_trips(tz, params); - if (!params->trip_max) { - dev_warn(&tz->device, "power_allocator: missing trip_max\n"); - kfree(params); - return -EINVAL; - } ret = check_power_actors(tz, params); if (ret < 0) { @@ -714,9 +709,10 @@ static int power_allocator_bind(struct thermal_zone_device *tz) else params->sustainable_power = tz->tzp->sustainable_power; - estimate_pid_constants(tz, tz->tzp->sustainable_power, - params->trip_switch_on, - params->trip_max->temperature); + if (params->trip_max) + estimate_pid_constants(tz, tz->tzp->sustainable_power, + params->trip_switch_on, + params->trip_max->temperature); reset_pid_controller(params); From patchwork Wed Apr 3 11:31:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Travkin via B4 Relay X-Patchwork-Id: 13616006 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E7AB142E75; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; cv=none; b=CJOevTUBWGvdcwGEmvg9ZWyUNgyO0Ir5O8DsraUA5K2J+qCj7I1JrdUMYTz5Yo5cTS7tOnpp7RmntUcqIPGngM+rWQhNg5TQaV5iCe9DrEAwnt8B7cbcopAD8hoNwJgKZy7n5IDN+K0+E0Xus0RemSSnqUvvNe+YjdDcATdn17c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712144093; c=relaxed/simple; bh=9758iPN/JC97kvoDw1mamVXOKflxBHmJlpHg9S7rrE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I5b/BT26Jg4v+QVSot2zXezXUM1nAVTdpeUF0GV5s91JmioPiEZ7ddZgRPGJLoG9reSt3pBrvvkJbDFcUWywvhL0otl33TBObNbDVp5wRV4JwiLnJmJ/50XMjir9ZQKuQiQU6ouhqt3U6Ea7s3Gnvt8ZpsHV8kJ6jVDa+H033Bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f2vn7QmH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f2vn7QmH" Received: by smtp.kernel.org (Postfix) with ESMTPS id C2BF3C433A6; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712144092; bh=9758iPN/JC97kvoDw1mamVXOKflxBHmJlpHg9S7rrE4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=f2vn7QmHwXQ8S+xD1N0fPX0NzPWSSvRNLF5lINARbs8A11BBpw0JH5Z/OUm2tJeRm gj3sdslr/9HBzxOPQfGTSJuRBfDRJek83Bh9a5DMjDbcisARDNrCYGubU5ushMnTKN 7YtBu13wzUeN5s5bnYtInW/9FgrlhxF2mwyDPMqnt7gDBw4FkMAbTlxxaYzQY4c9VY fRTlctlooO1tLICiEc1XAEjQc5qqhBBqxtt32gNd+89mdC5j7VjcP2Cc0ycDnSWYY0 q6Iz5LkrkkJ9ieAIw8/eA6MYepbpp9DI2keIQtfrCh8AuZOBSh1Sh2FlhOOBd5Rhq+ v/GSRVWr0r2Kw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B586DCD1299; Wed, 3 Apr 2024 11:34:52 +0000 (UTC) From: Nikita Travkin via B4 Relay Date: Wed, 03 Apr 2024 16:31:42 +0500 Subject: [PATCH v2 3/3] thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240403-gpa-no-cooling-devs-v2-3-79bdd8439449@trvn.ru> References: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> In-Reply-To: <20240403-gpa-no-cooling-devs-v2-0-79bdd8439449@trvn.ru> To: Lukasz Luba , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Travkin , Nikita Travkin X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1262; i=nikita@trvn.ru; h=from:subject:message-id; bh=gQ/lCJyqNkEYXe64V1azuLWqhZDrPtWfWIzY6a+krrM=; b=owEBbQKS/ZANAwAIAUMc7O4oGb91AcsmYgBmDT7a1s4sHI60htO7JPYtLc7eKRvDv6ApO1t84 n+JQrinvFmJAjMEAAEIAB0WIQTAhK9UUj+qg34uxUdDHOzuKBm/dQUCZg0+2gAKCRBDHOzuKBm/ damjD/9nikGP8u0SyJYkb8/hRI+pmOTDJA6BZr9vFr3xFe9n8VUXi/uAQCG6N6g0/DMZZe1wHwD n7SObRXMQBQ8p6G7XxIbkEKqVyQgczzrt2q878TJ9utGt9JTGSlSKKVnslumOQ5brXm9Ykywd9D S+O4JveQ5TS1yFPEb4y9G/Y9BmP/URNMt2Y1smsu4E7PwbfFylfM/UUv30MhfXMK62wgQ9lecmf lj4KPmxY0DkmV5LTOZDB0WLz75bHQ/7z2ubYtv8FCZJHyZjIVeWCjr7XxDz7fmb2tZc1nmuEZAG zdSWk2wr3i/4kc2CY9FTNzqJ9Go6cLlWvMB7xNp7rx8oCSo4YBE/ifUVGncff3gVgTx96HmdyBR r3StSRE0Ss8Iz6Clwsi0bexqXEMJWDBryOIuu4h38WVUshRaYP/XAam/9bfWaPiad8CeIVGx+Eg RrgzNMB4AyKLeWqUjNwWQwoz7NQQXr1rcB/bIx2JY8T7MGlCdgTKNwjIfRGXna44VmTDwmFClpo 77Nx6AAFdDkHjdpTCSEpzgvT+9i1p9kgfFEPK+tSDZn5bGu68pMmzJjlVmRb0TUWjxBpqn9cYmb gmbdl/egKr5zgMwp2p32obMQq9/w2kMubA2wXhBBHKPWu3iJy8m8A10uMbm9AAJJj6fxinf7NX8 pL7h1RbIlz0xjtw== X-Developer-Key: i=nikita@trvn.ru; a=openpgp; fpr=C084AF54523FAA837E2EC547431CECEE2819BF75 X-Endpoint-Received: by B4 Relay for nikita@trvn.ru/default with auth_id=151 X-Original-From: Nikita Travkin Reply-To: nikita@trvn.ru From: Nikita Travkin IPA warns if the thermal zone it was attached to doesn't define sustainable_power value. In some cases though IPA may be bound to an "empty" TZ, in which case the lack of sustainable_power doesn't matter. Suppress the warning in case when IPA is bound to an empty TZ to make it easier to see the warnings that actually matter. Signed-off-by: Nikita Travkin --- I've decided to add this along to supress those warnings for some TZ on sc7180. Feel free to drop this patch if you think the warning should always appear. --- drivers/thermal/gov_power_allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c index e25e48d76aa7..05a40f6b5928 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -704,7 +704,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz) params->allocated_tzp = true; } - if (!tz->tzp->sustainable_power) + if (!tz->tzp->sustainable_power && params->trip_max) dev_warn(&tz->device, "power_allocator: sustainable_power will be estimated\n"); else params->sustainable_power = tz->tzp->sustainable_power;