From patchwork Fri Feb 22 20:31:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?B=C3=A1rbara_Fernandes?= X-Patchwork-Id: 10826967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 948C914E1 for ; Fri, 22 Feb 2019 20:32:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8234932ADF for ; Fri, 22 Feb 2019 20:32:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7426132AE8; Fri, 22 Feb 2019 20:32:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE93532ADF for ; Fri, 22 Feb 2019 20:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726870AbfBVUcZ (ORCPT ); Fri, 22 Feb 2019 15:32:25 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33135 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfBVUcZ (ORCPT ); Fri, 22 Feb 2019 15:32:25 -0500 Received: by mail-qt1-f194.google.com with SMTP id z39so4072267qtz.0 for ; Fri, 22 Feb 2019 12:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tOKqtonCY30q8dxTzna/mDA4QR3QSgJhSBf9tddOgk4=; b=t+XuVKzGZRrGmPDJ2QMgATI+pISA21Qec2yko9tT94Viga8JYrqL0LqN8lAgJ953Xf RGSlRI/b1hInXT9bUhDLFAJ3/yMsumZVkI/P0Uf1aOPveXuSnDiCp6U+rcVXqRqUVR36 1LyDDzu4U1LnqbaamQvXq8KcNv6q4hVsVLLEF3209CZk/hWiRwFqvjM6X6HMrGU9Rqgl roWztz89gVX/t9QAtNfA/+QS5PZVx9tRIeGwbipURj/qhBSwqcK/GmAC7qPNW7Szetw3 Qdb95U2ns9MC30sjOz293tG+0M0arkcPgcEpqiO3AxMxPKytjGnF2qR3cwGykHq6zxN7 69uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tOKqtonCY30q8dxTzna/mDA4QR3QSgJhSBf9tddOgk4=; b=E9fgx0RGnOS7Y7kc8dXcDX8rf59ps5kSKhujp5wp1fKOTFSieAt88Pwfxmv8F5bPFJ fi87KgpDobzR11qtFwi2FgJsnkLF9HAkCAYWiVxV/6eOoVNiprfZ0JIWwHHva1+ThvjT DMLjHI1aSq54HSeg1GJSNRRDJShy/TEQLzQYQufWbGgGV8exNq5bFMzUnitBo5HCwTBk E+v8OPf/rixdrrDgTlAJHFsjJLUMPeS/Oo4cx/ocQrRzPwxC6Xmyl8h44YtqYgfl5Bj3 o3pk9Ry3j9BdH7kbvLWWMTHWzl09eaOobBPcyZe5cpzYVWMPzMq2f67rcMo13A0GbB0h 1J+g== X-Gm-Message-State: AHQUAubt2LTm28hbUAYilShAlV69WP17d96tvzBDL/DRT/sKAsVxq/2x fsijbReqcAXy3boQThL7vW/WQA== X-Google-Smtp-Source: AHgI3IZ1wiTsQxMHvrBSouICUS7/WaLhE49ljQUYafXnFLNtmTPrD6C+vhGB2c/S/skD3jWKdwCcfg== X-Received: by 2002:a0c:fb10:: with SMTP id c16mr4609710qvp.187.1550867543865; Fri, 22 Feb 2019 12:32:23 -0800 (PST) Received: from greta.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id v26sm1449149qtk.22.2019.02.22.12.32.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 12:32:23 -0800 (PST) From: =?utf-8?q?B=C3=A1rbara_Fernandes?= To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, =?utf-8?q?B=C3=A1rbara_Fernandes?= Subject: [PATCH 1/4] iio:adc:ad7923: Align broken line to parenthesis Date: Fri, 22 Feb 2019 17:31:56 -0300 Message-Id: <20190222203159.15116-2-barbara.fernandes@usp.br> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190222203159.15116-1-barbara.fernandes@usp.br> References: <20190222203159.15116-1-barbara.fernandes@usp.br> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Get broken line aligned with parenthesis on upper line. Solves checkpatch.pl's message: CHECK: Alignment should match open parenthesis Signed-off-by: Bárbara Fernandes --- drivers/iio/adc/ad7923.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index d62dbb62be45..ebae7522710a 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -130,7 +130,7 @@ static const struct ad7923_chip_info ad7923_chip_info[] = { * ad7923_update_scan_mode() setup the spi transfer buffer for the new scan mask **/ static int ad7923_update_scan_mode(struct iio_dev *indio_dev, - const unsigned long *active_scan_mask) + const unsigned long *active_scan_mask) { struct ad7923_state *st = iio_priv(indio_dev); int i, cmd, len; @@ -181,7 +181,7 @@ static irqreturn_t ad7923_trigger_handler(int irq, void *p) goto done; iio_push_to_buffers_with_timestamp(indio_dev, st->rx_buf, - iio_get_time_ns(indio_dev)); + iio_get_time_ns(indio_dev)); done: iio_trigger_notify_done(indio_dev->trig); @@ -314,7 +314,7 @@ static int ad7923_probe(struct spi_device *spi) return ret; ret = iio_triggered_buffer_setup(indio_dev, NULL, - &ad7923_trigger_handler, NULL); + &ad7923_trigger_handler, NULL); if (ret) goto error_disable_reg; From patchwork Fri Feb 22 20:31:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?B=C3=A1rbara_Fernandes?= X-Patchwork-Id: 10826969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A872714E1 for ; Fri, 22 Feb 2019 20:32:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97B6D32ADF for ; Fri, 22 Feb 2019 20:32:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B7E132AE8; Fri, 22 Feb 2019 20:32:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F3D832ADF for ; Fri, 22 Feb 2019 20:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726344AbfBVUcb (ORCPT ); Fri, 22 Feb 2019 15:32:31 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:33154 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfBVUcb (ORCPT ); Fri, 22 Feb 2019 15:32:31 -0500 Received: by mail-qt1-f196.google.com with SMTP id z39so4072629qtz.0 for ; Fri, 22 Feb 2019 12:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kw6AUIg4Ejwdusxaso+DCJFNAKWhgIjCRtvWWiMb+yg=; b=VHQlxExO7J8BmmpDL1RchzVfDQ0q+Hkk9BkcuF2CzdURTzmxQsi1IWux5ePeQZEfrv bi4b4oS6ag0inLRgiGJOsl8Gc8qaW+8DuT44nkFytA8x2nhXgSfdHWTyvWEiRiqrhDA5 1WI3GYz6CYHmNNuwVapiDFoZtGPAWfD2jMXKYHIYWWh9x0f6K0RZN0zHGgcg9M61MOlY x1vNx+b1phjpvslWvDwgUIRcwtA8L7NshL4cNbp5FU+kJmQqLqW9S+2PMBvkFQuUrTpb bV8nvKriVF4BiUkA3cSlNv1P9x8JOnWqtxL/rlEKmSW8axz8tHn0Fo0CKuQmUSWIPNAA ld2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kw6AUIg4Ejwdusxaso+DCJFNAKWhgIjCRtvWWiMb+yg=; b=UXlVKfnv2/Z1QSp7f5E9EJVHBJivnYEUzFCwfIhIYBitkaXh52Bz1mehywR1/si8OT wLnXslipMhQhmHt7IUTledcpgTtoyTSaq26h8+H579ZvOnXpK9hjUAS2beFNCMPAw5UV 63YcWNkY4Lp/7KxyYvmT4dnrDmKE7mfyny4t8b17SG+UAjHwj2nLURuFqVX079/rMpeO NgzGA5GRlY0eUqe0vZJY3ECiFWvcTcfLhKIQPNPRk98lKga/o4KX73COVfj2e57togtW XZK78eqbzDZOnFEvwdVugBKRRPv9jU9Nztm03ZU2Ij1knjxIYszgstNO/isbPAz/9dJK XEug== X-Gm-Message-State: AHQUAuZ3/2GDWyZ1S9S+J9uoaMkYa0A9+LHq1L9ACYIAgViu22kPXZCy 9elymTL2625Jb2LV7JTTa2NerA== X-Google-Smtp-Source: AHgI3IawQWj/G3jwOl3NvvNLrncK/FPR5vFIis0K7ZRv9VYT0RlFmBvcRL9YAUl7KCpVJ8xEEmWzIw== X-Received: by 2002:ac8:fb0:: with SMTP id b45mr4791487qtk.146.1550867549709; Fri, 22 Feb 2019 12:32:29 -0800 (PST) Received: from greta.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id v26sm1449149qtk.22.2019.02.22.12.32.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 12:32:29 -0800 (PST) From: =?utf-8?q?B=C3=A1rbara_Fernandes?= To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, =?utf-8?q?B=C3=A1rbara_Fernandes?= Subject: [PATCH 2/4] iio:adc:ad7923: Use BIT macro instead of bitshift Date: Fri, 22 Feb 2019 17:31:57 -0300 Message-Id: <20190222203159.15116-3-barbara.fernandes@usp.br> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190222203159.15116-1-barbara.fernandes@usp.br> References: <20190222203159.15116-1-barbara.fernandes@usp.br> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace use of the operation '<<' by the BIT macro. Solves checkpath.pl's message: CHECK: Prefer using the BIT macro Signed-off-by: Bárbara Fernandes --- drivers/iio/adc/ad7923.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index ebae7522710a..b39ea834cdd6 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -24,9 +24,9 @@ #include #include -#define AD7923_WRITE_CR (1 << 11) /* write control register */ -#define AD7923_RANGE (1 << 1) /* range to REFin */ -#define AD7923_CODING (1 << 0) /* coding is straight binary */ +#define AD7923_WRITE_CR BIT(11) /* write control register */ +#define AD7923_RANGE BIT(1) /* range to REFin */ +#define AD7923_CODING BIT(0) /* coding is straight binary */ #define AD7923_PM_MODE_AS (1) /* auto shutdown */ #define AD7923_PM_MODE_FS (2) /* full shutdown */ #define AD7923_PM_MODE_OPS (3) /* normal operation */ From patchwork Fri Feb 22 20:31:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?B=C3=A1rbara_Fernandes?= X-Patchwork-Id: 10826971 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 35918922 for ; Fri, 22 Feb 2019 20:32:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2369432ADF for ; Fri, 22 Feb 2019 20:32:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17C8B32AE8; Fri, 22 Feb 2019 20:32:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5B0332ADF for ; Fri, 22 Feb 2019 20:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbfBVUch (ORCPT ); Fri, 22 Feb 2019 15:32:37 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35490 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbfBVUcg (ORCPT ); Fri, 22 Feb 2019 15:32:36 -0500 Received: by mail-qk1-f194.google.com with SMTP id z13so1959769qki.2 for ; Fri, 22 Feb 2019 12:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kvvzSc4t3o2R7pWzEPHRmrdi9rCvNLjs4c+WRCjXEjk=; b=K5I7KxLbqnE4yuHfARvYND3aunWyNYwasdaRypPqIr385aRTMXK1C/ZCCXCM3bvdzy binp6R+CHO5mbsL5tU/KKR64lwwLer2djStLZN9i5gsqqt3imxWoXxxR9Svex2fIHMs9 V6pHznAvm1yBZx6iSe7rUPBRFiVuA+uXfR2Vj/v097QwvO5XXtcHhTj4pP8gDn7rR0AF dfiH7yK0RG8670+4NM/vIln+XS9pfYRkhgf7QHxb/OLkeLH88cDnCJYnB64S9DD1iUOD oi/3xsjloBXMLFGMWQJ7EqcILqWOZGY9T2z6si1dReBOaCzA6kc6frJ3gx4QV79w//pT xLJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kvvzSc4t3o2R7pWzEPHRmrdi9rCvNLjs4c+WRCjXEjk=; b=j58fzNH/8gjGve8BqgaQWD+0L7uE/IltxCjP5vk5PQrgfC+I8YPZmdVLaJYgdwPCOw Zuwslo7koPxuofq9m/MOLUWj9ejKmCe/UoBFDuMxeheCOet8xoB7Twz+hwxdeGSNAMWS lfps+brY7Z+SbFXoWQynqTOIjwIX3xRNpoFks6jc1Z+t/Vh+9UPtEy+ECnY/jgUgGaT6 Pgfj+hrcMiPWmSuh1OoBUs3rfidQpgogZ/fGRGh0pdYE0YxlOiqs8KLL4VgsLHbIoc+u hABo6Lr3rrsSFgBUkCUqG6pBwacFfg5UPFU4bZ+YWunJE0qZRNIeCgZgz1yYaF0QIfY3 A9Ig== X-Gm-Message-State: AHQUAuZFv/cznvZOhhAffdURPiVocXyEjxbQeSM4oec/1AFkZywL2Bth vnT4J4XDEGGkrfM5QTjKWS6yjQ== X-Google-Smtp-Source: AHgI3IbJfkIthHg6+Jg3H0vK4CuDLmwe12wJzP1xpgA1w8GvMa6O/no7rPh/SZ0ugQQyrQMqil5DBA== X-Received: by 2002:ae9:c119:: with SMTP id z25mr4353813qki.222.1550867556032; Fri, 22 Feb 2019 12:32:36 -0800 (PST) Received: from greta.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id v26sm1449149qtk.22.2019.02.22.12.32.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 12:32:35 -0800 (PST) From: =?utf-8?q?B=C3=A1rbara_Fernandes?= To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, =?utf-8?q?B=C3=A1rbara_Fernandes?= Subject: [PATCH 3/4] iio:adc:ad7923: Put macro argument between ()'s Date: Fri, 22 Feb 2019 17:31:58 -0300 Message-Id: <20190222203159.15116-4-barbara.fernandes@usp.br> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190222203159.15116-1-barbara.fernandes@usp.br> References: <20190222203159.15116-1-barbara.fernandes@usp.br> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Put macro argument between parenthesis in order to avoid precedence issues. Solves the following checkpath.pl's messages: CHECK: Macro argument 'mode' may be better as '(mode)' to avoid precedence issues CHECK: Macro argument 'channel' may be better as '(channel)' to avoid precedence issues CHECK: Macro argument reuse 'sequence' - possible side-effects? CHECK: Macro argument 'sequence' may be better as '(sequence)' to avoid precedence issues CHECK: Macro argument 'val' may be better as '(val)' to avoid precedence issues CHECK: Macro argument 'dec' may be better as '(dec)' to avoid precedence issues CHECK: Macro argument 'bits' may be better as '(bits)' to avoid precedence issues Signed-off-by: Bárbara Fernandes --- drivers/iio/adc/ad7923.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index b39ea834cdd6..dbece44e26e4 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -40,16 +40,16 @@ #define AD7923_MAX_CHAN 4 -#define AD7923_PM_MODE_WRITE(mode) (mode << 4) /* write mode */ -#define AD7923_CHANNEL_WRITE(channel) (channel << 6) /* write channel */ -#define AD7923_SEQUENCE_WRITE(sequence) (((sequence & 1) << 3) \ - + ((sequence & 2) << 9)) +#define AD7923_PM_MODE_WRITE(mode) ((mode) << 4) /* write mode */ +#define AD7923_CHANNEL_WRITE(channel) ((channel) << 6) /* write channel */ +#define AD7923_SEQUENCE_WRITE(sequence) ((((sequence) & 1) << 3) \ + + (((sequence) & 2) << 9)) /* write sequence fonction */ /* left shift for CR : bit 11 transmit in first */ #define AD7923_SHIFT_REGISTER 4 /* val = value, dec = left shift, bits = number of bits of the mask */ -#define EXTRACT(val, dec, bits) ((val >> dec) & ((1 << bits) - 1)) +#define EXTRACT(val, dec, bits) (((val) >> (dec)) & ((1 << (bits)) - 1)) struct ad7923_state { struct spi_device *spi; From patchwork Fri Feb 22 20:31:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?B=C3=A1rbara_Fernandes?= X-Patchwork-Id: 10826973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 491D4922 for ; Fri, 22 Feb 2019 20:32:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38E3032ADF for ; Fri, 22 Feb 2019 20:32:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C8A932AE8; Fri, 22 Feb 2019 20:32:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D13A832ADF for ; Fri, 22 Feb 2019 20:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726287AbfBVUcr (ORCPT ); Fri, 22 Feb 2019 15:32:47 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46544 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbfBVUcn (ORCPT ); Fri, 22 Feb 2019 15:32:43 -0500 Received: by mail-qt1-f195.google.com with SMTP id z25so3981133qti.13 for ; Fri, 22 Feb 2019 12:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KWrDT+N2hTJztj5qg3/F190Jbid6q1JWQQqk7w1nQHk=; b=ZIIR996g2a525uzIzoHH7wyxHA46C4r1XCwqy1KEpi38vgU43lq6jWMKHLu28/UvRt Ju7nRtb01XOt5WS15JWzTXd1mozlNlln6O8vBo4qduyS3F8SOIEPsTMpgZcSp2hovlE0 FV++ecxyaxiQxcHvSPK3l+8BLHe8Rx8r9tNaS83DpDDYt1TyGqN9ImB1S+8RAVeuvgqI 2exgCoY4wkD6dtLkqeLjj9BrG+xlkhPz1q808iZC63tPe8S2wvAYccXOkYpMqKf4qkzX 0dmd0EPsi+GjoDfjzWJlabGYWMhZ6U9U9QrJwHJSyg4zOrPoNBlyN5OFYRyeRaoBNoPi MPFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KWrDT+N2hTJztj5qg3/F190Jbid6q1JWQQqk7w1nQHk=; b=fV/95PxR5mZZJaAXWNi3GY0Sw8sJRWHtvx/mpI9knCQjUTboIOIz68S9CbzTfHMmUy w+9nnYHp9FTAUcUMRptvoLmA0gcmv5jYLYHWwZVQ1j6VrcSnZ1OTQSfXGMxLUvG/iO01 QZYmgpwyWOqFVqDtgmlDStWEUfoDY/yA1td0FwtQZ7fhTH7Qg/MKHHvuc0yS14ZKVYvj 6xzLdLlv5vG98BTP608TUbX44i/a+tf2yb+1HhWydFUYLcYlHrqKsRdDPyyC2vWO+Txm KuvvcHh1Sth8Rh+WJswsTnvdtpkRE6MflivRIrYlnNsTZMBDaWyWPPEPa6JpogSa0qqg p4zg== X-Gm-Message-State: AHQUAub6NpvGUW29IMOQyZQeq0VvS8FZXCrq+Ufdo+xLNi+WjIkYMa7k ECCD3e5xW2FA+3VfKR5U7kYX4wiPHh6s1A== X-Google-Smtp-Source: AHgI3IbaMKql4aox766FC7vjTtMxLaJYWeE2bmiXIYFXJMKlBpnJFOfYcUj6u1RpYE74XTQwKesSDg== X-Received: by 2002:a0c:b5c8:: with SMTP id o8mr4697533qvf.213.1550867562632; Fri, 22 Feb 2019 12:32:42 -0800 (PST) Received: from greta.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id v26sm1449149qtk.22.2019.02.22.12.32.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 12:32:41 -0800 (PST) From: =?utf-8?q?B=C3=A1rbara_Fernandes?= To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, =?utf-8?q?B=C3=A1rbara_Fernandes?= Subject: [PATCH 4/4] iio:adc:ad7923: Rewrite comparison to NULL Date: Fri, 22 Feb 2019 17:31:59 -0300 Message-Id: <20190222203159.15116-5-barbara.fernandes@usp.br> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190222203159.15116-1-barbara.fernandes@usp.br> References: <20190222203159.15116-1-barbara.fernandes@usp.br> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Solves checkpath.pl's message: CHECK: Comparison to NULL could be written "!indio_dev" Signed-off-by: Bárbara Fernandes --- drivers/iio/adc/ad7923.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index dbece44e26e4..cb7b854df00c 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -272,7 +272,7 @@ static int ad7923_probe(struct spi_device *spi) int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); - if (indio_dev == NULL) + if (!indio_dev) return -ENOMEM; st = iio_priv(indio_dev);