From patchwork Mon Apr 8 06:44:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 13620613 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A380111A8 for ; Mon, 8 Apr 2024 06:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712558699; cv=none; b=XAWVBsKX7gX2zZut8LJ9SjL3IxLhLiQDc7olbN3Ws+8vvu+SBM5QiLirvOT7DqPEj0Q6x10ygr6+Z02ZJKkzBjYHUa2rwpYcRneVvYlccmAjOzbjpoYlcsO3McxXPAc6h99t+b1N68zwK1wUYXc0RfcKux54+aw2MRiY5PY2jhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712558699; c=relaxed/simple; bh=xcu2JJeUBxhfJ2Cc+vMD1v0kZJu2HM1hHarpo5Jxx7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=ItaPMlS6r7lWB12UBAJvYJtmsbUYoJ48nwHN35d8q7jicvL5DQXNsOkEoVNoBMqCCsxJc+pkRHWuQ8lEmY+qZ9yxOUTcNBKkwfOr0zy9XGVYQgMKZSohf+40jYhLZ/+3jCpFAxWSDiymH2bviHVVh2vypXAXaM9f+w0FSh7VmSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtikC-0008Fs-QO; Mon, 08 Apr 2024 08:44:40 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rtik9-00B3lF-N6; Mon, 08 Apr 2024 08:44:37 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rtik9-00EdB4-22; Mon, 08 Apr 2024 08:44:37 +0200 From: Sascha Hauer Date: Mon, 08 Apr 2024 08:44:10 +0200 Subject: [PATCH] dt-bindings: net: rockchip-dwmac: use rgmii-id in example Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-rockchip-dwmac-rgmii-id-binding-v1-1-3886d1a8bd54@pengutronix.de> X-B4-Tracking: v=1; b=H4sIADqSE2YC/x2NwQqDMBAFf0X27EKUGGx/pXiIyRofxSgbaAXx3 xt6HBhmLiqikELP5iKVDwr2XKFrGwqrz0kYsTL1prfGmpF1D++w4uD43XxgTRtQHZ6RI3Ji1zn nFzc8RjtQrRwqC87/4TXd9w816dqvcQAAAA== To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , David Wu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Sascha Hauer X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712558677; l=1265; i=s.hauer@pengutronix.de; s=20230412; h=from:subject:message-id; bh=xcu2JJeUBxhfJ2Cc+vMD1v0kZJu2HM1hHarpo5Jxx7k=; b=jRDgsC+uUqYxVFiGlrM8R8L11V8C7WJF68mlTmsMeRmDf4vl4YqM+bKeqYcS7YiwmvyTokY51 XTH7+rpgZeWBf4+LCXJQYOuBNQY6QZwVoTCo1wPn09IRhSwQMT03UZL X-Developer-Key: i=s.hauer@pengutronix.de; a=ed25519; pk=4kuc9ocmECiBJKWxYgqyhtZOHj5AWi7+d0n/UjhkwTg= X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: s.hauer@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The dwmac supports specifying the RGMII clock delays, but it is recommended to use rgmii-id and to specify the delays in the phy node instead [1]. Change the example accordingly to no longer promote this undesired setting. [1] https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ Signed-off-by: Sascha Hauer Reviewed-by: Andrew Lunn Reviewed-by: Dragan Simic Reviewed-by: Heiko Stuebner Acked-by: Conor Dooley --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f change-id: 20240408-rockchip-dwmac-rgmii-id-binding-6166af659845 Best regards, diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 70bbc4220e2ac..6bbe96e352509 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -137,8 +137,6 @@ examples: assigned-clock-parents = <&ext_gmac>; rockchip,grf = <&grf>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; clock_in_out = "input"; - tx_delay = <0x30>; - rx_delay = <0x10>; };