From patchwork Wed Apr 10 11:24:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9344BCD128A for ; Wed, 10 Apr 2024 11:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eg3NAfRJyU9PsLYyr9aU1RUmJwCpJ+H6dXTaikO0y30=; b=t7x0YRzTw7av+U rRSNoR7NgHPtrtR0MJcXLyMzh+6pLb9sDkQ9mxwqIpiZjV1RhyiqH/Z3zd4SvD3yqoBliLqklICN3 fTxWKH/6hixgWO6RUmzwkXc8BHqffIxhFSPT1bUb4E4puG2wMl2PNn4pqNOusrgQMjuVpdsw66aYQ gjyoh/fMk+8+/5Y6gdD91b+7rJ38XYH0mR1oCsBzdTv0MhMxeAe7Y675eoTvNs354q0c4ISUT7al8 mpaU+wgndu+1nEBgxiGuK9AxPcGrCciRpvL5Qp2L+7hA76H6D/a2eSR0dF3biuNubSiuob6oFnw8y tK9Q39/xMASze6da+jHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4u-00000006bHX-1ACh; Wed, 10 Apr 2024 11:25:20 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4f-00000006b6B-3B0L for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=g8alMqK48I9QhL3+4HvdPnnuLkdA4QOsMgnkT/Ultao=; b=XqNqXH KqxLFkogTA3zf784DTUGVZrJlnFkcqAUey3BtoR4FoF1KSdkHhZ/fN7CC7qITyCK rb8djWae4TKmyCwY3w2ke627cmkh498XKMmAgOQu9AXKKh1K8ya5KHAteYwkNy7s Klkbcw90ixoO4u4/1F+qe2bc/WVhG46/6reYmEzcQW37FTboAnMiMmq/eKLFhsFL kr5hGRO6oOSY24T7/cJAOLQe5lceLjq7zL+qBliz++NcB4Fgf8mzv0cvVoDZ0K0i gyiQ4yHrN1a5YNz9FOQ1Ohq6qfVSRFsJXPeu2WXg/HoSBSZBO50UNIcTsSsWfCxu kGQTFW7qICIiiotA== Received: (qmail 521337 invoked from network); 10 Apr 2024 13:24:59 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:24:59 +0200 X-UD-Smtp-Session: l3s3148p1@dNDtSbwVhm5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Subject: [PATCH 01/18] i2c: at91-master: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:15 +0200 Message-ID: <20240410112418.6400-21-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042506_596224_EDC917E4 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Andi Shyti , linux-kernel@vger.kernel.org, Claudiu Beznea , Wolfram Sang , Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-at91-master.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c index d311981d3e60..ee3b469ddfb9 100644 --- a/drivers/i2c/busses/i2c-at91-master.c +++ b/drivers/i2c/busses/i2c-at91-master.c @@ -591,7 +591,6 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev) dev->adapter.timeout); if (time_left == 0) { dev->transfer_status |= at91_twi_read(dev, AT91_TWI_SR); - dev_err(dev->dev, "controller timed out\n"); at91_init_twi_bus(dev); ret = -ETIMEDOUT; goto error; From patchwork Wed Apr 10 11:24:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20DF6CD11C2 for ; Wed, 10 Apr 2024 11:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1T6d9zVD13+toqBQuKEfmwj/E2Vo7CECMVapYsVnKc=; b=A8X3B/qtBRqy+H n3ZjaVz/B4q/yFfNite1/Lk2Iewh1FyrFB3z2pcj4/mCTkoDDLLJ5jKPehJuDZaFpV9vz/8HjN0cF zhM8X/UvGomIzuy0/red/NQs1ZzEFv9V7Dp+6wMKZSWP6DEDLOy2XIDU0triwt/I/ppAeebj3ggPv v82KKspXwljTA2b1tps8NZyJM3QKCJNv3ekTjo7LvpmxVO+NARrVN6Uvwam4zANJvoyeOUHtL7WfR h7090X9U7ddDySOhLSVennvMvqV2emAqGkm2dhpenJQtJs0Fo/TyemBSmDo++mffKYiEgpt9ifPY4 a7CVjvoXTR7NAmpBHTUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4w-00000006bJ7-2wCO; Wed, 10 Apr 2024 11:25:22 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4f-00000006b73-2CoT for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Q2XuHTnpBIWpyQZNHPcbLppoXDYJ4UpElNhcDdmY5jE=; b=bT56KS qE/8jdTPtzKVw2Ql1egR3fsIujU6yyooIfip4LLJuwCIwiFEVnYf4cJk3MF5AgG1 lViwoGWmMBRNYcFlrDHP8D4F1gA7UiHBIJXqw/xL592owDRZJvvZA6mJnXea7zER RU4D3At3BuQwZXPGy/dEhD7KSR8RhtmzgrSEEF5VCgPT5fxIjYjCHXAab+1g71nL wkhCFyxZkp9dG0SQNjR5ZsyuYEKtHBZ5xzWufQAhPK7SHvc7noOMJdUrgbDH3otw RXKQ0TH9Uw/dKTgvDYtZUDAqliK8B2DgNx2tQq7L3KL4p8YUrgE0rcuTn0CiiyZp fRh8SaupDeeDUvng== Received: (qmail 521390 invoked from network); 10 Apr 2024 13:25:00 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:00 +0200 X-UD-Smtp-Session: l3s3148p1@xiz9SbwVCgdtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/18] i2c: bcm-iproc: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:16 +0200 Message-ID: <20240410112418.6400-22-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042506_614818_D983975E X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index e905734c26a0..133d02899c6b 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -811,8 +811,6 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i2c_dev *iproc_i2c, } if (!time_left && !iproc_i2c->xfer_is_done) { - dev_err(iproc_i2c->device, "transaction timed out\n"); - /* flush both TX/RX FIFOs */ val = BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); From patchwork Wed Apr 10 11:24:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06772CD11C2 for ; Wed, 10 Apr 2024 11:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GvZW2QO/mHMIjTT7EA5i6CANCq3NKB8fEb5j96YBB9M=; b=Fjjb3iwYuTGHUF R3K/H/rBYjiqD7/8z6Js2/tCAzpwjZ5vQ/Lgq4VrGuDOrX13Z6SXEk8QOw9pBPxKncah7NtNRvY+8 9X/fpZbbYJuq3n9N//zXD4B2Tac84+V5+G8l98px0/j14lmcvggXQy7k2a+hRElJC34IpP86ZXKGR SsnPasQoQupTvY7DKyHAAII6EMWI9cgzQ03WWQhT7R1nML7l9V/pzyVhs/zMXfXtKOHV7EJMx+apP xybzt+y/+xosaPwQkVEN7ibpnta4V8MdApzcDTZZG+u9KmOOQUs5M0DToAaLqvhXu5xM5P5VhQJZu HUkZoBcGBe7VDmU7HC+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5C-00000006bSt-0pA2; Wed, 10 Apr 2024 11:25:38 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4l-00000006bCu-05PC for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=4EUSyGzomATeNIcG8P0cZgKgvqo4WHF+lzVzVLKSadU=; b=QphoD0 IcmvSEdfsDJaszWGUfYISArnr7pFEh3iVuEliuWPXsaTgp99s+8UAb1PeiQ2J4Gu YVzkQFx3QKuRWskt4wncxwHVmjHKjJzyR7pgQVM3JZumJ3aMUasyuyrdbjPI09MX orqntkK7cBII9SSeznWLuksgjiYzPM25iII9cciqsLVPmcQPgblgN2v6WFy+xDAR GYaOcP6HHNAsj3qUD8mkxKXUqEpyl8BtH28WnzKa1Tn7BnuTR3JmA+ZZr0FdXKwq nFtZzB+Yb9qVvDlZJkJ2v7nmQEJW9ryYrinepeH7aZSYWbDr2HyBE0CLJiGG1swO lMVX3FG5Sbd7o0jw== Received: (qmail 521447 invoked from network); 10 Apr 2024 13:25:01 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:01 +0200 X-UD-Smtp-Session: l3s3148p1@AQUNSrwVyC5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/18] i2c: bcm2835: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:17 +0200 Message-ID: <20240410112418.6400-23-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042511_471694_F4F13427 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm2835.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index b92de1944221..3045ba82380d 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busses/i2c-bcm2835.c @@ -370,7 +370,6 @@ static int bcm2835_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], if (!time_left) { bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_C, BCM2835_I2C_C_CLEAR); - dev_err(i2c_dev->dev, "i2c transfer timed out\n"); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D21EDCD11C2 for ; Wed, 10 Apr 2024 11:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1GkHu73AfB1Y0ZDv2sNIdn1FAbhu2RMwp0wB/MX8siU=; b=b8XBDSICSTt4OG 8Cqy8n/jj8bXUqRJOAUHV3F4igLqnXc2ES9EKBLVOKM7rcXHM+tHXLvXfiUFgcXi+rZqyblt4JgM7 8/BBMPwX7USAIyQrZcrbRL1yPKSBgk+WVJbFIMCqCfCSAuB8caYEe+uzuiFAOVUbau7GLP8E0y/g4 gjiubrmUBBhWHSG1DNDDQ9xa/1esZk/PaBZdh58i9nZ0reMnbWtLlbs5tMrrUk7FvPacq8ROmrUIf lNmrFr9xn55CTamWhSnSvvetZnM+hi6eJt4azloV/NQ5dT6ZZRcjMRFIZ2QIAPWOTRKp/t1/2sIXP 0LOhUvlecK/W3OA4cQbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5F-00000006bVB-2hZY; Wed, 10 Apr 2024 11:25:41 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4m-00000006bDG-1c2J for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=hD8uz8cN1ScOd8WPchdst4mxCACdD20Wmh45ImGI/X8=; b=a6oVtx Bh1gvv6bITBD1Cz3DUhfELjmFMxhEhR+AHoeksfm5KrUSRVeoTQikoU/us2SJR36 rqhzW6yJBUHl7MfBms5eST+3Y5CC5UJ1MuHezo3gp8VXpRwwjOOg/8rhgsMCskuF 4kgy7RaL4OCO2tK/P8srJT2kFViURleSD/lh+JjCUqSVLQCTDpHLB0ve+pzwFifE Pyz8EWOzPRxhwJj0gt3aNTVOi+tPxvtNMLR9t/vS/RZmprV/kWIG/G7cE4I5fTp5 gzwrWLO2uV0sO78yYo2yAFoG6TXLqyFhb2BMuq7eorRE5aoF/PYcKhXZzZXokYVg 61UO01t9i8Cf5lpQ== Received: (qmail 521473 invoked from network); 10 Apr 2024 13:25:02 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:02 +0200 X-UD-Smtp-Session: l3s3148p1@iO4iSrwVDyBtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Michal Simek , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/18] i2c: cadence: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:18 +0200 Message-ID: <20240410112418.6400-24-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042513_216205_FD72AF6F X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Acked-by: Michal Simek --- drivers/i2c/busses/i2c-cadence.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index 4bb7d6756947..1b0006e3b95c 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -789,8 +789,6 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg, time_left = wait_for_completion_timeout(&id->xfer_done, msg_timeout); if (time_left == 0) { cdns_i2c_master_reset(adap); - dev_err(id->adap.dev.parent, - "timeout waiting on completion\n"); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624104 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AE6ACD1296 for ; Wed, 10 Apr 2024 11:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y15ZIymm+CH2GuCKSeDFfrvFTwtWXfIC7aeRW2vtkvs=; b=gCCrBHl5AhQ+Rg UzpBZVX6gkIjGGLpD/2AnB171RnAARQHsKxiQ2kJZ0Oy0FG9kOqV7hJVJNIiUwmAXuOOzncW0a3lH svBl0Mh0lR+y17N3bqqLzTTMXqmMCP+5aat6HeHOPAZtELwF6dQFXx2hhBVCIxrvawWw0zESWTGpG RsZNXyYduLiQ0inJ459lDNaN+k6vjzmTeW3REU65hbR6/m5NcQaKzHBYYN6nbrcpE2L48E4i3d7u2 BWYKc3O0AEbBLlUNm6iOZXjalm+gbIeNRM7V+eUOgHzkficMekhAVsPIBXNsSJBxLuZn67Na3wQi6 8dl0CmoZk7EKhKs1lTag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5I-00000006bYF-1hgG; Wed, 10 Apr 2024 11:25:44 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4m-00000006bDi-3xyg for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=q5jkr9/WM9vH86xqE+ltTHo/KtY4HZuCeBtACkBfJFo=; b=lWenHI ytoeCjSQDSkx0iz1ocAdTupCRi3QvuCSWs9BjyFctMM7jbinxlmB0DDLVZ9IVdTC WJB2GPpFINtxSKOmuUGqhtoEOoji6KndgfHhIzarj1T8MVueDYlCXOxU/6I6yDYI ENtPl0mMrV/KL2nBY+z6njeFHn0i3HjdxgF2qPbf/R6nWDfvGgNuYBxd5XVr71cq JCCZpi75etxa5d5Bjy22TX8uN0H0z6JH0bYEDST3X7BPuh/zh3Uk+93Jn+vMy/YH XcZDocjV5wMEQRh1xnYWA91DZFo3elBiSVsFEXtIXI3K9E+abOQVoL4959teXxNx UHyGT3gkagV/b/Jg== Received: (qmail 521490 invoked from network); 10 Apr 2024 13:25:04 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:04 +0200 X-UD-Smtp-Session: l3s3148p1@sBY6SrwV/yZtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Bartosz Golaszewski , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/18] i2c: davinci: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:19 +0200 Message-ID: <20240410112418.6400-25-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042513_669850_DA7A7336 X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-davinci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index 02b3b1160fb0..7ae611120cfa 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -489,7 +489,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop) time_left = wait_for_completion_timeout(&dev->cmd_complete, dev->adapter.timeout); if (!time_left) { - dev_err(dev->dev, "controller timed out\n"); i2c_recover_bus(adap); dev->buf_len = 0; return -ETIMEDOUT; From patchwork Wed Apr 10 11:24:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B6BDCD11C2 for ; Wed, 10 Apr 2024 11:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZxNZxfL/m1lO2lpm+ezsRBQWXdaGdwiHfMaQUa0vi8w=; b=Thjto8EoFseELa +gPJUkWiVcMSEJtgoD+iQZ7x+E/J5VeyaGYCx0a8r51tcyju8nyoeXGlrNwhHpH1rHzeK93fS1e7m rZbzTvvRtkMXqZrCCJHJtTTEP8DHmLLH2mAllHn+ygI55Rx3UllAShNe8lu1EomSRAj6xdynEXUc7 bKtKHplLzTKpBNI9EVqrtQtfmuTAP1Bylkvz2xMnVS5U//djMbVAAxYdkGjlFi5mjpUXeoCapAiZv et5BRTw8NM5GCswPT37H1PDpf1SOtLnkGYDii6rBbOeTibdMt4UIXD8t1oEV7lT/32B6pYtkcmIE9 UFnW7eZV91nKN1+7NqlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5L-00000006ba9-1H8p; Wed, 10 Apr 2024 11:25:47 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4q-00000006bFL-0BEz for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=3esuL+DU1erk/gYHtm2gF1OBGVxFNyh1r/SypUa9yCM=; b=Vr6qAr 8iFkO2wOh0d1gYTcxzNKRyDBqot/1ghiSOBRenx8UjsO+5PnOwwgoljk8Bs/UjIQ kbTetXqSgGkGWju9mEG5XkPttMpOltFo8bPzQwTAte/ly+rE108AWwHLP8sAtiZj diJblVIrmuAlp9n2ASvIDo9yY7FXDSOFWXfHqJ4sNFcPO3D/2OiY4q+t4uqm0e/f q8QmDwWXO42uR8VA1W5j5/WFcbOq6LzMSrn3wvZ5jYrLQM+c1XQhE3zlg2+bLwYP zgG8WxIPhfFPh0+uULC/GQpyFKVXQQUW+QiQkzK3WqGAGQ4YeBeVzrIJJ6N8Woqp N96as7wrkefpS4xA== Received: (qmail 521590 invoked from network); 10 Apr 2024 13:25:08 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:08 +0200 X-UD-Smtp-Session: l3s3148p1@YCV+SrwVeGJtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Linus Walleij , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/18] i2c: nomadik: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:23 +0200 Message-ID: <20240410112418.6400-29-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042516_436173_F0A9323A X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Linus Walleij --- drivers/i2c/busses/i2c-nomadik.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 4f41a3c7824d..45c6df26fcbf 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -542,12 +542,9 @@ static int read_i2c(struct nmk_i2c_dev *priv, u16 flags) xfer_done = nmk_i2c_wait_xfer_done(priv); - if (!xfer_done) { - /* Controller timed out */ - dev_err(&priv->adev->dev, "read from slave 0x%x timed out\n", - priv->cli.slave_adr); + if (!xfer_done) status = -ETIMEDOUT; - } + return status; } From patchwork Wed Apr 10 11:24:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF1CFCD129A for ; Wed, 10 Apr 2024 11:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z55KIezT2TFnvIj6ViHQQAHqmZh4ZzRJg1xKjyPI/FY=; b=D0Q4mKYNlZHXIV m8afRqc4PunTu45nMe3mkCmpFY4P9zKtuHE6O2WlDMY4SkAmNYW0uoVUONndPLukBK3rZSLh97c/a tmJJiDM4uZFntZWOd5Qm1trcfvHc8DwnDvqV4bClIN+/ITaU6jueiilgRWewdi1NKNBsNE4zi7Gzn eT0bKpHavvAxs6+VPIDjFJMHKZl6vGXj8D1nsBLf/nkD+0yU1qSuk10neJTZioawvCXFLFx15v+84 taDVTprqAvD8kjghM4D6zW4NMRS1uufUVIsqHGDXun2OgyPFbvingeBNI/89P0xeYSsBtH6JcChWC 9dR0UJqZpcLFmpD5gKDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5O-00000006bd2-38Rq; Wed, 10 Apr 2024 11:25:50 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4u-00000006bHH-3fAV for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=tTh5gHnHTO8tnn3N/EUqm3Hs/2cCwpj+zf5vzhI2jO4=; b=e61aOT hHkW2NOKlDMp0TsvrVPjYTmQqz9G6Xfcy4dHz+uo7EKsZwsdYFgTTcGXuAn7f+hN PfX+75V6R6IdoC8PKSbQrHZht+Z8lwzqghjNxgf6NDV/Q1eq6+QWkooxVjjytOoF m+j5jM1//kWHUH3M65OJFa6CFln6Z20DJE5R68iZuhIAtGClWAkld7cvKeWG96gq OytNpo2VNSVE5AKSL8nl3TZvZW9zWokIbnswIEBw7J9RzT2+6qsa8QkyX9Kae2vF KPk41mjCQLuUsJZWVYzYK/4n6kn3jL9Y6ZwEmUDbCUkn4AUTtb3+EjN1DBxsliIn 68yvSpKSLylj7xwg== Received: (qmail 521797 invoked from network); 10 Apr 2024 13:25:14 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:14 +0200 X-UD-Smtp-Session: l3s3148p1@25HGSrwV9SJtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Heiko Stuebner , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:27 +0200 Message-ID: <20240410112418.6400-33-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042521_324860_CDAB857F X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-rk3x.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 086fdf262e7b..8c7367f289d3 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct i2c_adapter *adap, spin_lock_irqsave(&i2c->lock, flags); if (timeout == 0) { - dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n", - i2c_readl(i2c, REG_IPD), i2c->state); - /* Force a STOP condition without interrupt */ i2c_writel(i2c, 0, REG_IEN); val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK; From patchwork Wed Apr 10 11:24:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864E6CD128A for ; Wed, 10 Apr 2024 11:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7iuvB+IZtJDhj3K0tycRBityyOhYknjg7xziuax6Qqw=; b=KQDkFNe2yHpr85 iyk8S5iLu4MItKkCSKh3yqoG3c4d8gO5bypAM60LQQvuDNwZSWNzS60coP2WRKuNgDsBAN4t3Ori0 80Qc0bSdEotaDmD6mYADD0HsbU3oGrVlX3LIGaoZN5CFmfOmtWPJkytNPukf6UXKUxueJGqgpPumv Lf1/txkEhB+LTu/2pOgowMG/Hi6Cf5P1UzGKawIepPOpTO4diIEaJmzVoe0b0EsvOT6wKG72jJ5Bh CnjHnwzY96t3O/7NXwkjTLFW+8knZlvMSDSOX/FViG+5W/+lcOWQELnu5WT/K2H338xSnCt+dQDvw 04ojBGgNMWwZdUXmEIlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5X-00000006bkc-0hKt; Wed, 10 Apr 2024 11:25:59 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4w-00000006bHk-0E2T for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=X7d+g6GmFE6xmFhmuPXFDnzDcw798Dd53vujZTSLEyU=; b=PKAMFF 2dGmeXmjkFQh4VLGO9ahOzd7m3cQAUQF27XMFlDxU2MFkPjfPwebZM/2DObDBa0Z LeRpedKIml6vzuUsJGQVa35jts19EyAcml/wUVHDGxDue5BMe/AaBrTrLc5EpqwI wsXlvha5j/soHtNQ9s5+t8aBrbNQiBOw1MM5thC+WHeBXkqomwlM7UfRmCalc++Q w37nbeaKUNpocTlHK65IQOQbcZCpQ0uWSJUZyoILOgoZE5JMNKN2IeF978hvP5fH 0IcZuO9tczGuL7Aer1RI4as0VaM4cbtUwD5wrsxZsGqHK/894Df8sprTkyTxifOq q6utamIoTepr1SuA== Received: (qmail 521909 invoked from network); 10 Apr 2024 13:25:16 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:16 +0200 X-UD-Smtp-Session: l3s3148p1@oQz1SrwVMHttKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Patrice Chotard , Andi Shyti , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/18] i2c: st: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:29 +0200 Message-ID: <20240410112418.6400-35-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042522_434151_CDDF0916 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-st.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index ce2333408904..dbb93394ff94 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -689,11 +689,8 @@ static int st_i2c_xfer_msg(struct st_i2c_dev *i2c_dev, struct i2c_msg *msg, i2c_dev->adap.timeout); ret = c->result; - if (!timeout) { - dev_err(i2c_dev->dev, "Write to slave 0x%x timed out\n", - c->addr); + if (!timeout) ret = -ETIMEDOUT; - } i2c = SSC_I2C_STOPG | SSC_I2C_REPSTRTG; st_i2c_clr_bits(i2c_dev->base + SSC_I2C, i2c); From patchwork Wed Apr 10 11:24:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624108 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 514C1CD1296 for ; Wed, 10 Apr 2024 11:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x2HELeL2ICdqO2Ipmyz0Af2NdyHFwL/ZgIZAx4+rNDU=; b=sNH23YW/SatDE6 WyvPZvUqqT0gIHJQOEPzz+WDTDDSUxtWLOqMvGNVPwjevEOA5bg23BlrbbIzJe3iGG50hjpJa4jtv HTqeUmrGj5peVypUItcLMyRH3aTyKEDf+46+XEXG6Z3zzcW1Uzp30nRXm97ChzGhI73l/b/COUkKw X/JEpRK68PzRRoBYH4Y/Sb2cVeoY+enggOCu+ptv2ggXZ2JgA7uT9RHENqwzdGIUTzhqqWXD9GpAH kCXsAq9iyIFMay2x7fc3Na852ziI7RE2BZMrB27s7vybPGK4mlcog2wKj3PymFRsK/LFh2sMIwcb8 VPVwXOKR33fHNgP+1beQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW5b-00000006boO-3riF; Wed, 10 Apr 2024 11:26:03 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4y-00000006bJO-2y01 for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=gKURZrg2dPN47J/dR48oUq5R0Q8Z55DZunehHrLXhjY=; b=mDWAnL gNfGa3lR6+tkelsSUPEL/OPRCw/MYUCnsojYR12yqanKWlWbcLUtepEPKg4D7ixn Yih1ykxaPomgjuJVvSkKSmalYM8qukeKuawv+zNpbX/LkYHu2Ztz0SN3QTsEC3PJ aAjVWhjvNGxOWpb0lcSu9nA42kTRmlSxpYV4IVTtxSDDljvdNrM1up2MX23RnP4p IvFaDILeaTM03sbi5nMkBD2WFrupmGEKvXuPGFSqSYnGJVtTv61pwIdUDqRHgnsP GeTLaQmA77GN9fJ6754G4myNWE6Q9SO7fD7GdkqCbgrRRv82b0Cc7woJtkD+ZuSU zYBkqnLk3LQrCVxQ== Received: (qmail 521989 invoked from network); 10 Apr 2024 13:25:18 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:18 +0200 X-UD-Smtp-Session: l3s3148p1@YP8ZS7wVeW5tKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Kunihiko Hayashi , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/18] i2c: uniphier-f: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:31 +0200 Message-ID: <20240410112418.6400-37-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042525_742761_D8589587 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-uniphier-f.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index dbc91c7c3788..6c3dac2cf568 100644 --- a/drivers/i2c/busses/i2c-uniphier-f.c +++ b/drivers/i2c/busses/i2c-uniphier-f.c @@ -358,7 +358,6 @@ static int uniphier_fi2c_master_xfer_one(struct i2c_adapter *adap, spin_unlock_irqrestore(&priv->lock, flags); if (!time_left) { - dev_err(&adap->dev, "transaction timeout.\n"); uniphier_fi2c_recover(priv); return -ETIMEDOUT; } From patchwork Wed Apr 10 11:24:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13624109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93D28CD11C2 for ; Wed, 10 Apr 2024 11:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fLTR7YpNaMLbhEJYBtm04renqEiXWElvBYg6D5GRtyU=; b=TKj3etgvAr+K5L ctjUSlqkB96gGIHhmtoiI0dVF8m1K/jRBmFun/HrCn2gzq0fwBaVHU6Pyradn69ZT20z8C3U/6DPo ZWZqqcOMsiS2Il+j2JafrdWIVyPp1XAvmAUWLAtmCa9Hz3h9NCIX+UbADe3AQ5LwZwaZOLwQmTpx6 AN8Ko5eDRVzTK83Inr5eYy07qzKFIO5rOJvz0pEo2DmYbqo0FryasV16DjCnkHlMlCgmXa/7sx+Uz IA2eNv+jHyeHjMAHI6HkySFyUtzTDqKqBqde8CrpuzN3d3NNxkx6J4Cb7e7SxQSePgaUcs7cNu61K Z4UsUdiNYYYBGOlxw49w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW6D-00000006cGR-0E65; Wed, 10 Apr 2024 11:26:41 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruW4z-00000006bK2-20bq for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 11:25:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=61Yt0QJyesrW2fxW1vjW+vSic4XhfkDmhgxF5NliaQY=; b=IViNnx eHj5O7F0ATf1ZZxzzvdVQShvxXYAouzRxRIxxXNaHE6LWqn5DqSsZEc2Zs0Q4tbY LNAG8XFS2dYtwS6Z79oh8bi3bFWPTp2k8OO41KzviQFrX4OYBsLoZkWWjdssFGb8 gXL3C/0XjyZUDsaG+77QnuyuY+OCMho73iTthf3YS9WAFiFNETFTD9IT0d7tMkPY wc/FlE4DsHk2WncjxqpAdEvpy/7k/zOd9FTdFOcIED0ZywK7pDkE81XnkqrIrw7m NSLNbw2gZfg65WUxHxWM1226ovjfS3RByq9vRwKXYAnJfmVMNwhcueb0fujWHKXG Qs2aPyepbCwSftYg== Received: (qmail 522049 invoked from network); 10 Apr 2024 13:25:20 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Apr 2024 13:25:20 +0200 X-UD-Smtp-Session: l3s3148p1@u+osS7wV6xNtKPEL From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andi Shyti , Kunihiko Hayashi , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/18] i2c: uniphier: remove printout on handled timeouts Date: Wed, 10 Apr 2024 13:24:32 +0200 Message-ID: <20240410112418.6400-38-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_042526_107741_B57C80E9 X-CRM114-Status: UNSURE ( 9.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-uniphier.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index 854ac25b5862..e1b4c80e0285 100644 --- a/drivers/i2c/busses/i2c-uniphier.c +++ b/drivers/i2c/busses/i2c-uniphier.c @@ -71,10 +71,8 @@ static int uniphier_i2c_xfer_byte(struct i2c_adapter *adap, u32 txdata, writel(txdata, priv->membase + UNIPHIER_I2C_DTRM); time_left = wait_for_completion_timeout(&priv->comp, adap->timeout); - if (unlikely(!time_left)) { - dev_err(&adap->dev, "transaction timeout\n"); + if (unlikely(!time_left)) return -ETIMEDOUT; - } rxdata = readl(priv->membase + UNIPHIER_I2C_DREC); if (rxdatap)