From patchwork Wed Apr 10 14:09:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 13624640 X-Patchwork-Delegate: ilpo.jarvinen@linux.intel.com Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36ECF13E3F3 for ; Wed, 10 Apr 2024 14:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758222; cv=fail; b=ErAB1BLxMbHn/X14KBNcB42c+B73+cYIro35h3SlyoCJMOfmC7tgf9P+9ru0jqjZIaFg4UEf1EOjiLKV9SiNAXGFcBEJ7mwwkyuXT4hu5IMSKj5DreM+bjJTtjo1mDaiOpA6bwQMNFHhSBfv+mV76sv1VQw57rkZ1pakKptQtRg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758222; c=relaxed/simple; bh=IIBiiwIX8s+EuILgthvA0p+BvGBY77/Tzz72zQUehro=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=dp4N/AZN7G72uWbOvtpfF/DfcrxGYSHBiAndAJzK3uE6cU7VWc16u8SYUQmzNkC/gJdJY2BQ1wqmSUWsa5yID72Yd8KomVgTmX0g46DqokQWcjYmYy0fJtMNSt3rk/Dfci81+610Ct/dPQDgnAZn/ki2lOgwR+O7CpaGKb0ALM0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lS4RpwBK; arc=fail smtp.client-ip=40.107.92.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lS4RpwBK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gwWUYiZNJ3BWpyZV3M8BbazP82bsjXEOC6DChsTCTInMFfI0nM0s0Ran0NygvpKCpCco1ACKcTNkVF1hVjtEq1vhg2RU7r5tddC3a+QFiuB0og+ozmfSBc/yDKtYtHWae1irscJjTgCXOLIHNvHyBj7VnqUuKSnGYgTBTYe5VZ+F/ZD9i7Joth6narvGtgtAAyusffGcBa6j//jbl2J9YQISsDu/cHuERwNyeFRy2hFl9WXCkS/mr7cXjBhfTuR95L6YZqK3MBhtTVDwcwHMT2X0i/0TVp+S4CoqMJ6C12CPm4XAJeEMX9oiHusl2H8WT3w/F2cMp3jRu3hsimZr6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d1rpRrSBjDLlyp8kfrtI2j93ypt3zZg5YREyo3YvmAo=; b=UW4oqwC0xcbvBV5stLQgMRqO2Xx5xMcZabHX2q+1XtSMWnmO8aa+eSxHiYlEVUeJu73zjKEsbpNC6Elws2fJz08qkAKZIQ8Naq0A0PNK9fHU5yzR/7QEf0JGOBlPJjauHAQvBztogEfYAY3Qw1nRZHhjjzNSXqad58Plo37JXJC6EEeq0yakHoNULR5VvWdX6uyh8nIP2sggUbiCWYhchNBcTCZzDw91Tc/OoJKbrKe2QQnnw5xmLzfhYIg8esNgTsIzaOXFAF/gFVCE5lT44p9BRNGxnfodCQAJuh6uZVH4lOfL2/1HuRAGHssFlvV3xbRB9lv996mN59H4/ibQIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d1rpRrSBjDLlyp8kfrtI2j93ypt3zZg5YREyo3YvmAo=; b=lS4RpwBKFGjOAkJLZVNphZZzV0Ji+CnDOW23ABRkSQHsoQ5tvSJW9LzojSUDmkhE9TiBa5EHjAEN7dLbaej/R9ZuMin0Ghh1MKCQnMpIVCHl++U63rxzFY9lHM5Rb6BZnHVPhqKbDMXiRRf2NhWFHoH4CAsqjwle+NQLDT4/yXQ= Received: from CH0PR03CA0229.namprd03.prod.outlook.com (2603:10b6:610:e7::24) by MN0PR12MB6175.namprd12.prod.outlook.com (2603:10b6:208:3c4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 14:10:13 +0000 Received: from CH1PEPF0000AD76.namprd04.prod.outlook.com (2603:10b6:610:e7:cafe::22) by CH0PR03CA0229.outlook.office365.com (2603:10b6:610:e7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.36 via Frontend Transport; Wed, 10 Apr 2024 14:10:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000AD76.mail.protection.outlook.com (10.167.244.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Wed, 10 Apr 2024 14:10:12 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 09:10:11 -0500 From: Mario Limonciello To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= CC: "open list:X86 PLATFORM DRIVERS" , Shyam Sundar S K , , "Mario Limonciello" Subject: [PATCH 1/3] platform/x86/amd: pmf: Decrease error message to debug Date: Wed, 10 Apr 2024 09:09:54 -0500 Message-ID: <20240410140956.385-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD76:EE_|MN0PR12MB6175:EE_ X-MS-Office365-Filtering-Correlation-Id: de75c556-3bf6-41a4-c5bf-08dc5967f054 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dH5W1jBxMJ51EZtEtm23fdnv4EuTFQ9y0/tcIxmocZ6lwrwxr4liiuwLeGveuGtvGTPM0cSOw9XnK7yqROqLgb+Bp8+U0zKfok50M/dy9CPH1wtcJHDs/qsfIKs9VJ8T3YrdKM+ke8bikGhi5nDzyaiRSAzleSohKh7sQH22bLCVm5Sxof8sbfqsq/0xAEqh/9gWEfbZlc7+qjkYyM06IOdBmL3RPxPf06F/UsdCUTlfjVkl1Rvqqe+8DDWJxfKJQmf/fOmgxrJD1NXq8YckfJ88st1bUeC4viSrl8rL4J1z7QQvxuaq4ZaN5vGZkRMgO5anUxE58rAQPa+b2A3JjS/MiNE/B37visNwWoXudql6j13hffOlU/gDXeT7uHO+4x418FoQ+i/zpt4N6V3MP6TyekTn93tmk1XWDgeULeWGwPcloglR8egKRplpLYzVyWaBRBdeoeBrEVno44vZVXbEDXb+03qFIri+da063x1Z7+dGYMLAVIbNMDcip7feX69gCYzdEn7A3tgtGbRA5ABbzdxL4nkgkkjRT8sVUgpJmT7Aq7zr0X7JB6EhONn5vcMyWiNN3+Bt5ncdXVCZu3cbMSOUnQelvW528aFgTyxgzHbosdu65DBLYhYy5rlUzm9YskIsUbhO+uc5ljRujY2JxAuRCRDPsgAyp51R7q0p5o+yPoDIxw6vAwHV339pYFpjUFF6PR2NCidOPDFuSTa4uMn40PJa2/wyH7UWd/qYiVeiKReSIHySFgLdfOaZRXmdzWi5psGlhDt6DqRs3R/BSOQv70ZHquUv89R4DZc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(32650700005)(1800799015)(82310400014)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 14:10:12.7733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de75c556-3bf6-41a4-c5bf-08dc5967f054 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD76.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6175 ASUS ROG Zephyrus G14 doesn't have _CRS in AMDI0102 device and so there are no resources to walk. This is expected behavior because it doesn't support Smart PC. Decrease error message to debug. Link: https://bugzilla.kernel.org/show_bug.cgi?id=218685 Signed-off-by: Mario Limonciello Reviewed-by: Hans de Goede --- drivers/platform/x86/amd/pmf/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c index d0cf46e2fc8e..60fc71c9fb0f 100644 --- a/drivers/platform/x86/amd/pmf/acpi.c +++ b/drivers/platform/x86/amd/pmf/acpi.c @@ -437,7 +437,7 @@ int apmf_check_smart_pc(struct amd_pmf_dev *pmf_dev) status = acpi_walk_resources(ahandle, METHOD_NAME__CRS, apmf_walk_resources, pmf_dev); if (ACPI_FAILURE(status)) { - dev_err(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); + dev_dbg(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status); return -EINVAL; } From patchwork Wed Apr 10 14:09:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 13624639 X-Patchwork-Delegate: ilpo.jarvinen@linux.intel.com Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2078.outbound.protection.outlook.com [40.107.100.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22F3158D6B for ; Wed, 10 Apr 2024 14:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758221; cv=fail; b=DXR/hvcTN8gyvvgd74dv4PP1guNT3/rabi56r9JninpKr8nHckg2a5FCknGWk75iyPiVsCB5IBcr28HzxtndPr4LR1S7urJlRh7mT/js6zPrs6WRkZ+VaCxAuYNJFUffdcFPiUQY8Ygb73JT9R294ck35qXkcuaTgGNPut0SDfo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758221; c=relaxed/simple; bh=gVjxVP6kJSSdLzU54m1vdkt6MfZwKCFo5qnkKGiy+fs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mqmo3oOH4zS44o20zWmbuiUXDXK2dpZuX/6mXeHqNVCZ//eX/KmMTg3ym01kRY+mZM7Dhqw+8/viWE+eSFgx2Pw34cLlGORojMjIRqvKq+Jvy54sLB+xJ6lPCI3OwWl45aRf3jQZaADQip4ZUru/OK3zKoJqLh82pVPSGVkYN0M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=xO/bmDi2; arc=fail smtp.client-ip=40.107.100.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="xO/bmDi2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DxqS8lLXz9DZfx11r27+Dr1X0jF0E7B8kbL7GmO49NWlfm4sdJVykXPFnq6fqNXNZ/ucIv2gWYN6voW7ALjYvpzxVqdFI3M9MNC9vKpeWARQH884yCaliEliBxWOUvi6GsXrGQqmScgw7zFO/9AFYsuTt25hYbAmsgX/L653WPIc4rvBTBXAizu9icANOjtURuksqjKifAoJicbAaHYaLcYEF446DuTpkMSQ/7qEjoApgJm6sGOuiXc2vO+RYYZ98NRZLbWEKfrcZPPBXmMuBHYPi32aKjFLDnokkqNveqZeUpPc8eWPe5+UYEq+ZUOYrWlLE9KvQodWzfik67JUpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ZumNjKEWPcmFLrXFiH6uaSWICK8J3syqnmZQPj0blc=; b=MRQDeL/8liNpNqYjJLX9fbrx/v7pm2nickDtHI6H4tPM3afYSMrFPYM2F8MxQghWTQszk6bWlXqKGxFo2tbjH957royzbGl2VrS85H/CMwHcss718O30dNvel65cptUkPKw3sCuyJCORn8n46cb+mYJwp4lPnsho47Dhji2szJLhfjdUVDVt3AFJi1iXmE0v2NAMRr65SmEuubk6B+R1xfka1Bg385aJGDSvyj1/m0yIObPh5XO93oULCFItwEI9YuFpIV0phYez6DvBj5lpAdITyTFjEOibpir5WZHf9UEN22LP7m/T6X7hPrJKTZ6uMorbVfdVkXOPc1CRg1ZsVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=temperror action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ZumNjKEWPcmFLrXFiH6uaSWICK8J3syqnmZQPj0blc=; b=xO/bmDi2jnQ3Aa00t83qauzN006TZQqSgPoKGkYniLOb9qUIat58WurGL78cJk5wsS7l3wC101iqruTAwUgUtJ4N/hcP7R6u9xy1urE7o6AdSMC+AXCPW/rt93htd6SRFm61ySeXIS0i10WzEkTf18ZjpXzjQ2XDllaIaSwtK7o= Received: from BYAPR21CA0026.namprd21.prod.outlook.com (2603:10b6:a03:114::36) by SA1PR12MB7366.namprd12.prod.outlook.com (2603:10b6:806:2b3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 14:10:16 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:114:cafe::ae) by BYAPR21CA0026.outlook.office365.com (2603:10b6:a03:114::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.8 via Frontend Transport; Wed, 10 Apr 2024 14:10:16 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=amd.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of amd.com: DNS Timeout) Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Wed, 10 Apr 2024 14:10:14 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 09:10:12 -0500 From: Mario Limonciello To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= CC: "open list:X86 PLATFORM DRIVERS" , Shyam Sundar S K , , "Mario Limonciello" Subject: [PATCH 2/3] platform/x86/amd: pmf: Add infrastructure for quirking supported funcs Date: Wed, 10 Apr 2024 09:09:55 -0500 Message-ID: <20240410140956.385-2-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240410140956.385-1-mario.limonciello@amd.com> References: <20240410140956.385-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|SA1PR12MB7366:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a8b9891-b3e5-4733-faff-08dc5967f16d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cYMB1rcOyrtH1Oa3ILmuXgofV2bGtgLotb3cJiO+MNPookDEpwQXrClAi2Cy0mZLL3fItqn166VNQT4NLQ+ZlBuYwniJCUX22fZcQEBzNPLcHPtxrBkHZhuoWwDar/w8eMPqBUvz0dSSnhmNI7knpxD9wDBHTLhfAl5nLkPCZFUPZCyoFyrPIflrkr6O4lXOJ8c/zhHfrcI/FUtHRlm4OZ9Bzbnd/CmRRYz7Mb6kA+LmKXzWMWuXCzv7IY3Srv/zEs37zlFTH6Er6PpmedowCuXo8vpyjt1uONwOSwNE6vAaa/7o7K02t6XkHy4aFVbYRE/0bC3/gLqz2JaaDtYJlXpRZCP6v1rkiKX9Kd1RXH2IiBmxjJLhNLSW4XVqPL5+my7ByLkMPp2sXEAlDV+Y0FksZDNVu09tVxR9Q/QRCeuWDGyHxv425jiDUiYD4jyQk7f6Y1AhtI5AD03dWS46YIhg9l7XuC6CW0vGqNQEIaLpSqZzYwWza3BY/XRtXz4UFnWEe6t3UQvkDQvtj+V3UJzQq+P4d3CZFmuGW7U73L9lCpZyY/vgd54tK6mK6ff6dvzDNOd9jCwG5Dj6hX7v/Rjw8X6RoFZJdLfxSOcQBAPfNv6eDbvgTPkOkJLwtXLUwLcH3Ijo1U/BGfvJSmpYqr9xQoOwAXNl51ghCyuxgTRSpLlq9neoi21pj4gH9weUwFf2img+aSFphLHtvntz7RjV+9tMk/aC9TxZP4rKKPYh/75sulKGO8tMSR4xhoSpiLYUTU11C5aKKpw9SP0fC0PQ62Q0+mNzwQ7ohKuCjTc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(32650700005)(1800799015)(36860700004)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 14:10:14.5381 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8b9891-b3e5-4733-faff-08dc5967f16d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7366 In the event of a BIOS bug add infrastructure that will be utilized to override the return value for supported_funcs to avoid enabling features. Signed-off-by: Mario Limonciello --- drivers/platform/x86/amd/pmf/Makefile | 2 +- drivers/platform/x86/amd/pmf/acpi.c | 5 ++- drivers/platform/x86/amd/pmf/core.c | 1 + drivers/platform/x86/amd/pmf/pmf-quirks.c | 43 +++++++++++++++++++++++ drivers/platform/x86/amd/pmf/pmf.h | 3 ++ 5 files changed, 52 insertions(+), 2 deletions(-) create mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c diff --git a/drivers/platform/x86/amd/pmf/Makefile b/drivers/platform/x86/amd/pmf/Makefile index 6b26e48ce8ad..7d6079b02589 100644 --- a/drivers/platform/x86/amd/pmf/Makefile +++ b/drivers/platform/x86/amd/pmf/Makefile @@ -7,4 +7,4 @@ obj-$(CONFIG_AMD_PMF) += amd-pmf.o amd-pmf-objs := core.o acpi.o sps.o \ auto-mode.o cnqf.o \ - tee-if.o spc.o + tee-if.o spc.o pmf-quirks.o diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c index 60fc71c9fb0f..1157ec148880 100644 --- a/drivers/platform/x86/amd/pmf/acpi.c +++ b/drivers/platform/x86/amd/pmf/acpi.c @@ -343,7 +343,10 @@ static int apmf_if_verify_interface(struct amd_pmf_dev *pdev) if (err) return err; - pdev->supported_func = output.supported_functions; + /* only set if not already set by a quirk */ + if (!pdev->supported_func) + pdev->supported_func = output.supported_functions; + dev_dbg(pdev->dev, "supported functions:0x%x notifications:0x%x version:%u\n", output.supported_functions, output.notification_mask, output.version); diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c index 5d4f80698a8b..64e6e34a2a9a 100644 --- a/drivers/platform/x86/amd/pmf/core.c +++ b/drivers/platform/x86/amd/pmf/core.c @@ -445,6 +445,7 @@ static int amd_pmf_probe(struct platform_device *pdev) mutex_init(&dev->lock); mutex_init(&dev->update_mutex); + amd_pmf_quirks_init(dev); apmf_acpi_init(dev); platform_set_drvdata(pdev, dev); amd_pmf_dbgfs_register(dev); diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c new file mode 100644 index 000000000000..9f3790eaaa30 --- /dev/null +++ b/drivers/platform/x86/amd/pmf/pmf-quirks.c @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * AMD Platform Management Framework Driver Quirks + * + * Copyright (c) 2024, Advanced Micro Devices, Inc. + * All Rights Reserved. + * + * Author: Mario Limonciello + */ + +#include + +#include "pmf.h" + +struct quirk_entry { + u32 supported_func; +}; + +static struct quirk_entry quirk_no_sps_bug = { + .supported_func = 0x4003, +}; + +static const struct dmi_system_id fwbug_list[] = { + {} +}; + +void amd_pmf_quirks_init(struct amd_pmf_dev *dev) +{ + const struct dmi_system_id *dmi_id; + struct quirk_entry *quirks; + + dmi_id = dmi_first_match(fwbug_list); + if (!dmi_id) + return; + + quirks = dmi_id->driver_data; + if (quirks->supported_func) { + dev->supported_func = quirks->supported_func; + pr_info("Using supported funcs quirk to avoid %s platform firmware bug\n", + dmi_id->ident); + } +} + diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h index 8c4df5753f40..eeedd0c0395a 100644 --- a/drivers/platform/x86/amd/pmf/pmf.h +++ b/drivers/platform/x86/amd/pmf/pmf.h @@ -720,4 +720,7 @@ int apmf_check_smart_pc(struct amd_pmf_dev *pmf_dev); void amd_pmf_populate_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in); void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in); +/* Quirk infrastructure */ +void amd_pmf_quirks_init(struct amd_pmf_dev *dev); + #endif /* PMF_H */ From patchwork Wed Apr 10 14:09:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 13624641 X-Patchwork-Delegate: ilpo.jarvinen@linux.intel.com Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2084.outbound.protection.outlook.com [40.107.236.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B52D615FA61 for ; Wed, 10 Apr 2024 14:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758223; cv=fail; b=qmHQ2oKRJSZIKESFLyn6ByRXDVzyRfblqVMuMQ4T8awZJcq04YFY/WtRQd7xAwXQU02oaoKTnmyHOvzZCgWe37mQF3SawwI02azmL609QoDh4oECW8sxfq4dHXhJM5W86YzjaY0j3sRa8JBwszVZVKwmbNzT5RHiNDLEVQZJdmc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758223; c=relaxed/simple; bh=raNXm6jDLj2l/vcnp4IAVrVyjFbfGoLZbw2T3NYSCR0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tbuAl9g2qCBTnlK5QxGCZyBljpLGl2khHnoDElIWDbXCj6sXr5bOKnSc5xJ4B1776nXOGD3YsD7epowkZ4wSuKUj8rzCuUozxePUbYvavVVhRXY9I0uSyoQ3mq7j0yfkuOY/m4ZbNEpgzN3UhoSaLzLoBbE53qzt3phF4Oe5Vo0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=5WEPLXW4; arc=fail smtp.client-ip=40.107.236.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="5WEPLXW4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/nMkV8eoRhokpxaMqOayf5JqDL7SeVWg1pFURAYgnpo+eTPKfiffEzWpcOGtQI/H4cGFvpt0auQFKpITfFSPeQH/SLNL+vuiCp8jLaTcohYm1KvC35Ew+9bQVrYuyNqou3GvVe7sPp5yqYg6q8s+7YOC1Owm92dKkMzlEqA8I7TEOfjpUjUiBy/VYWAsYuKVHh6uDfIEAs5BNcHgMpadpLOrsmQA4xQSeKaNJDLWB2hLgRhntFlbfGLbE2SLqRAkoAYkMPPV+0WR9nzRNL94SKtiyaF03c8JXSrEoGbBccNJUPXBbcFJT90JukezgWFzyy1eXXWdPFAH6jzScrMfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FETWJEU5JErB+zNSVjp9MjUrZD0KydkJptt2frHiLF8=; b=IB2rrAAuK7hWlMBa6Sq1mfL8xGvrWNowD040V8igIfsZpLEFZlGD6L7BvFiihyQqkClJZgCamn1Qw77hEzwL3StNhuiHwmMQOcXsWCm2N0CXQnQVJnItpx7DTO8ckiMGcXFBkuF+RWeca3NtoajZkOeTF9X1NzLEEoFbC0p4+39KiGAyP6vs6hP5p2/w+nZL5l+R7ce3oi/AwClTEbv78QdZpJGupIU8a5g5TquoFKbVkrictBPVVPKosJDAQ3OVvR3wIPmBFPytdnwvsrtwZC+mAyhGpm1BJ2HJI+fWl61fDxFqjUC6zq4LgfeNMKxCamunKx0jKSX4/8D2v742gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FETWJEU5JErB+zNSVjp9MjUrZD0KydkJptt2frHiLF8=; b=5WEPLXW4SiBjnd/tTSh7BOGhnlSAhIZO3aEY/F1cGoiQonFd+qvdBdlO/JqQbbhY6Yrm5he+sPGNuRc627fI3FLWeJpB8UOEkftsTH5Y+mqokWWKuzOX9m+nu+h0tV3MC8CvCJMDr+yVn31hp6El0vFtVX6i2WRm2q4BpUB6bK8= Received: from BYAPR21CA0020.namprd21.prod.outlook.com (2603:10b6:a03:114::30) by SA1PR12MB8164.namprd12.prod.outlook.com (2603:10b6:806:338::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 14:10:17 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:114:cafe::67) by BYAPR21CA0020.outlook.office365.com (2603:10b6:a03:114::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.9 via Frontend Transport; Wed, 10 Apr 2024 14:10:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Wed, 10 Apr 2024 14:10:17 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 09:10:12 -0500 From: Mario Limonciello To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= CC: "open list:X86 PLATFORM DRIVERS" , Shyam Sundar S K , , "Mario Limonciello" Subject: [PATCH 3/3] platform/x86/amd: pmf: Add quirk for ROG Zephyrus G14 Date: Wed, 10 Apr 2024 09:09:56 -0500 Message-ID: <20240410140956.385-3-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240410140956.385-1-mario.limonciello@amd.com> References: <20240410140956.385-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|SA1PR12MB8164:EE_ X-MS-Office365-Filtering-Correlation-Id: 93a583cd-4183-40ab-1199-08dc5967f2e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AeDBXLKsN0a/fV4Vb/zI+6qhAesqj6l2USAtbxKF+w50omMLsvRAB/gSE7hYs8570IOBAyrXMLLGzDYGqS9+OmLgUaUBnjtagnVLBFq4Sa2a8Atlvjd7c5P9bm1rEVXGtMNRoy2ILT6ndZD2lK+9WYMDRiKZIkTCLzqra6oT0n9fecrBNPRBjfzTbxOhZtWUbXs7MPRh4hmFEeIZfRIYoModw3QP0Kp8fVkK0HdzkknBT9Ex00P0BkU3dREEA5A8Bblu8ZomXcBCUElkT+nHbaU17DGPEdnXuPhWJ22Z1tyuU3PpaKNNQtWLk5haWKGGSFrCdzl2HMWAx0M6szF8oJtW4Zt1eDfhKn1cTlCX6HKvJhup7tTjvdRZiDVgZNTa2tf1dvQOUwYD+Usl6GNNo6uJSo1M2EBy558xYZBvh6uZ3MZBA/uACSbceYc2AVPQez13VN2oNmAVhkNHCF6txqWgp1H86jaxT1amBtonqF9/ZKzXhhF/CD8PX/v492oVf0Yh+KST/QEkVATGV7w9tGLiTNsxo8wtQbuJFiXlZK2f32rX7ufHWEpnuU5kscrtZoQkIKsctnOP2Q+s3pve2dUIwvRNuOmRGiTfvgb+PRzXaojeSDim+p+lH2d2ZXRlzRIITkXdm9YkNbK/rmRLFvrt6mB2nPnHZEQ3alAtHncot9EWOp9vLUlY2xB7A9Z6BZMIfGrohOeXx+WAi8TQ1XVpOWQXKHNebun2ugadtFJPEOTFIvwBi67g0DUqpWrwcbavCJDbCV6FzNA1hrUgKbxw0Egp3sGtMEaEOv9C7uI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(32650700005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 14:10:17.0225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93a583cd-4183-40ab-1199-08dc5967f2e9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8164 ROG Zephyrus G14 advertises support for SPS notifications to the BIOS but doesn't actually use them. Instead the asus-nb-wmi driver utilizes such events. Add a quirk to prevent the system from registering for ACPI platform profile when this system is found to avoid conflicts. Reported-by: al0uette@outlook.com Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218685 Signed-off-by: Mario Limonciello --- drivers/platform/x86/amd/pmf/pmf-quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c index 9f3790eaaa30..0b2eb0ae85fe 100644 --- a/drivers/platform/x86/amd/pmf/pmf-quirks.c +++ b/drivers/platform/x86/amd/pmf/pmf-quirks.c @@ -21,6 +21,14 @@ static struct quirk_entry quirk_no_sps_bug = { }; static const struct dmi_system_id fwbug_list[] = { + { + .ident = "ROG Zephyrus G14", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "GA403UV"), + }, + .driver_data = &quirk_no_sps_bug, + }, {} };