From patchwork Wed Apr 10 23:26:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 13625116 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177B9383B5 for ; Wed, 10 Apr 2024 23:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791604; cv=none; b=kTZiXcxM0V/SZnhewQ9K0PeS0jA3sigkBUIBk3fjRMWnQVzlEvyou1aWXhoDWSHMWMmw0Qiaq83vCUGn6A33XxqqE3kupCOUQWfj6ZWh4U2WtD0Xtmm38VT+lvWSnz9Tt6UPdRvC7b26a5Or8tVKNVtKLxkdOvVG9AVUkKH7uOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791604; c=relaxed/simple; bh=5Uh22vIKOPqTl08nz2cIcEKFa+Ku5iV4cUKiaiK6UwA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=kaDpiHYERJcNBhUE81XFOons5vCPaUAYAqktaoONkNg3Z7I0pg5U8xMNJR+XGR5fmC3OkMHZGGPvwL0OIkVZm6p87MqDs709D3h0Aih9qVakCJskICZq7jfpniouoGV1ggiM1KkyswX2fg5En3Hg2ORk0sgcIsQKzHMJU/mSopI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xQC5MJhR; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xQC5MJhR" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcc05887ee9so9782645276.1 for ; Wed, 10 Apr 2024 16:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712791602; x=1713396402; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=7JUe0tFRaoQ0RUO8nlo0bS/Trq4cm4/yvOCnk0PY7Tw=; b=xQC5MJhR8h16ucTxDkSCS0kzlCzvIGb4c/lM4x7/hgiNv6msb6mBXrxe3ZnHBB+U1u dvHKh132tWkCey+vRuwgAjQhTrM7FP+Sz51ZFvv+5pZ+KHRnO6Fum9SD7CU/EnugHNpX p6vc2VNhd/iDFrS5J2ePxqVfBzQU4LJEU3To13fBjQa7vdwVNW0tgNcGCdY/RKM8DycF eJjjS+npP5fAMAeCTsGqwSpacmS0jSJ5AuBvAP6e9yZkNcFH0b4KfPwQGpjVn6ztKH97 y8Iq8d/rZI/ZxoH9U8Jjp54/MNbZc62rXXCIBNF3zf9j/0exPwKotDSOEGV1lJTKG3TG n+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712791602; x=1713396402; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7JUe0tFRaoQ0RUO8nlo0bS/Trq4cm4/yvOCnk0PY7Tw=; b=HYbRvvbB7JT49Y0tgpAesTkeuw2YY9Ttp864x//EMUNiIBycSp4PIJHDMZxM6HEEHw FpAVlmiAsqa7kDo7CRL0vjK+8alvpCteZsrHnjPRMR5vmf4NHPUuX1JYccZoniy4S6R6 LComDTpfvXm4RLbR7T0flPiS3d8QzVcibGZqMu+giJUo3+CEz9lHWPCrtx6wMqdY/AnT HH6bxSO+MeEUbLAket1m+ZkEFVqv0eiT67hJ5WV9kt9rz2SsHEgFVr/oZg1lc+h/4wKn WsLU2h2diPKucmWwdXH21AIhJWoRCZa5H6Rh5j556l75ItAHgptgxaBOoTXo/+iUSp2w mO9A== X-Forwarded-Encrypted: i=1; AJvYcCXxXo/+gov1WJe+PabWhJLCqNz0uGwhxfa5p5U2ast3AEX0QevrVMMd71SALhAlhavhU/qLoiwc6kR0bssHLDJ3TFLX82iFVMLgRP6E3DZY X-Gm-Message-State: AOJu0YwQ4AkMHDNJjI+kf+cnqoBfDvaTY+6BYqMFcxTV8P/pKvX/Yc9b wrulczNE87dBKMIfc9DbKmzvj5YQ6pcdv6g1aKflI9KqeYexOvehL9a5y8o0QcNZffHfT+SnGDj 6S6VC X-Google-Smtp-Source: AGHT+IHn3qElAk799zrmqQpVWrjI3Xobk90HnjvS6MfZsB7fQ82snexs+qbkA8nn2poKmRJTuL3bOeMuPJfp X-Received: from jstultz-noogler2.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:600]) (user=jstultz job=sendgmr) by 2002:a05:6902:18ca:b0:dc6:b813:5813 with SMTP id ck10-20020a05690218ca00b00dc6b8135813mr358269ybb.9.1712791601994; Wed, 10 Apr 2024 16:26:41 -0700 (PDT) Date: Wed, 10 Apr 2024 16:26:28 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240410232637.4135564-1-jstultz@google.com> Subject: [PATCH 1/3] selftests: timers: Fix posix_timers ksft_print_msg warning From: John Stultz To: LKML Cc: John Stultz , Shuah Khan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Oleg Nesterov , Andrew Morton , Edward Liaw , Carlos Llamas , kernel-team@android.com, linux-kselftest@vger.kernel.org After commit 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()") I started seeing the following warning building with an older gcc: posix_timers.c:250:2: warning: format not a string literal and no format arguments [-Wformat-security] 250 | ksft_print_msg(errmsg); | ^~~~~~~~~~~~~~ Fix this up by changing it to ksft_print_msg("%s", errmsg) Cc: Shuah Khan Cc: Anna-Maria Behnsen Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Bill Wendling Cc: Justin Stitt Cc: Oleg Nesterov Cc: Andrew Morton Cc: Edward Liaw Cc: Carlos Llamas Cc: kernel-team@android.com Cc: linux-kselftest@vger.kernel.org Fixes: 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()") Signed-off-by: John Stultz Acked-by: Justin Stitt Acked-by: Shuah Khan --- tools/testing/selftests/timers/posix_timers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c index d86a0e00711e..348f47176e0a 100644 --- a/tools/testing/selftests/timers/posix_timers.c +++ b/tools/testing/selftests/timers/posix_timers.c @@ -247,7 +247,7 @@ static int check_timer_distribution(void) ksft_test_result_skip("check signal distribution (old kernel)\n"); return 0; err: - ksft_print_msg(errmsg); + ksft_print_msg("%s", errmsg); return -1; } From patchwork Wed Apr 10 23:26:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 13625117 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7183335DB for ; Wed, 10 Apr 2024 23:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791606; cv=none; b=SFuEUA/K45UwvXeePMGoBkJfJUehn4gD3P93iinhF33Jy/NJJn/ZirGZ8TdDB/2ywtr+FcVR7zZOVIl5oZrcnjcr3YThaq6+ZRT0tVnNkH3Ebb8QEa2KDOtOa1RrriBNaCCfonsj9dz/hO/xIZ4yDU7XlbM1Kgcn7CB2Sj+AuWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791606; c=relaxed/simple; bh=VoLCsCIDC0AKpRM6tLqdI9FChyNA7KdpvNzq3N9K8Qg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=JTe3BtPhq7mGRYKZVF1bZFN/Yn0wkCvY6ndpRdoHZcpvjqLh69PhBTMEr238kgyUY+JEaVP9t46GR6yFcZFE6espwim1AHrfKv6pouDgxFOLwQyRNwSwzLXVFZxSWDzllU9n6BPuIHKKJH4N8C6aRO0PlRNvqglhgkUAdV+aV/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=B8nxfyCx; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="B8nxfyCx" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6ceade361so12026273276.0 for ; Wed, 10 Apr 2024 16:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712791604; x=1713396404; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Zlurd5WmAU6KZdndMyIzN+3lsSewcbke/BSJIsyJm9I=; b=B8nxfyCxhDMThVF8zrt7SlovVFFHXvqnZ3GmzKuwzdPdWMG9HPNltDFwfxYkkCiRxU NNIK+zVM0AIDmui549+UA/PEgS801IW0MJlyVDye3dCdHUTd+o5R9SmDQ7LleNbATH8L EcQVo9AGQ59obMXD4eT8A1oRES0Rbuxd2pcvdW6Y/58tWuhnotdjrph3G++4ncTGYlg/ J2hfQkGmQVImjSkEuamjDFFyNC36nEP0rscpSG9Og7COoOql5Ya0LvwusPsXAo4RFPUe dOqCXd0II4ZGmVtPMmz7v6cnFxvnBiwW09SZHxxSfZbV7vMmuKJOt8bnuflCyPAlsn8c vK0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712791604; x=1713396404; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zlurd5WmAU6KZdndMyIzN+3lsSewcbke/BSJIsyJm9I=; b=cLLII67Lt0iY2djlj3VK7Z4vY7NeEfi7Dxw1h2BQcmbdEtCYIUBa/QkyFNz6fDkre+ 8MLPMfCELvLbnC2Izdjpudik1+RngSCNBq/Px4FqhuPFmLQ8mpyhafgnqUhauzI+lxn6 qnbiOwV2BmA38hzi+/XVs0Fur5vi/E7QRTF/7lcjvnR21/cRPJVSl5vMa+zKjdNZwKiz JgSP3Ji8mGPkBfn1MjYaBwTktDKsIfC3AegjxqmaPESE+HpUCLWpXcgixuowGJqyAHc+ W+yaQ/pzdVvm6XQYreKLxAzK+9ysvGjZlV0x9zecXgM16iAT/sK+lhuepIZSnwvYHwvY 143g== X-Forwarded-Encrypted: i=1; AJvYcCVDR99+aZ2zHr1MkLJndmrRq7lawh+yvQi2uYbi97uND+OFC1dThgMoFolVEB0DYqGluRuhaJSdxIf+pZ32DssxuezYZfbXOxG9fW6+9Et2 X-Gm-Message-State: AOJu0YzPVOIA+ceG7+kWr2u5gsfeGsBSFBDbRDQcyIVbRcj5gSg4UquU 29jmowB4taDzOZi2jEU/kCmvR/Nfsc4UvrvHsIfdi8eEvtmaYuR8AXXp0pFxHL9sCW/HTyEw8A6 VFzRx X-Google-Smtp-Source: AGHT+IHlbDC6ToGv1bXxA7Ao7B2WmThFk0HhdVs5BWSwsysizqGhpLzvpd+POKg06SuokF65H5Kbm0yuXOGl X-Received: from jstultz-noogler2.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:600]) (user=jstultz job=sendgmr) by 2002:a25:a124:0:b0:dcc:54d0:85e0 with SMTP id z33-20020a25a124000000b00dcc54d085e0mr1134663ybh.11.1712791603824; Wed, 10 Apr 2024 16:26:43 -0700 (PDT) Date: Wed, 10 Apr 2024 16:26:29 -0700 In-Reply-To: <20240410232637.4135564-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240410232637.4135564-1-jstultz@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240410232637.4135564-2-jstultz@google.com> Subject: [PATCH 2/3] selftests: timers: Fix uninitialized variable warning in ksft_min_kernel_version From: John Stultz To: LKML Cc: John Stultz , Shuah Khan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Oleg Nesterov , Andrew Morton , Edward Liaw , Carlos Llamas , kernel-team@android.com, linux-kselftest@vger.kernel.org Building with clang, I see the following warning: In file included from posix_timers.c:17: ./../kselftest.h:398:6: warning: variable 'major' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2) ^~~~~~~~~~~~ ./../kselftest.h:401:9: note: uninitialized use occurs here return major > min_major || (major == min_major && minor >= min_minor); ^~~~~ This is a bit of a red-herring as if the uname() call did fail, we would hit ksft_exit_fail_msg() which should exit. But to make clang happpy, lets initialize the major/minor values to zero. Cc: Shuah Khan Cc: Anna-Maria Behnsen Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Bill Wendling Cc: Justin Stitt Cc: Oleg Nesterov Cc: Andrew Morton Cc: Edward Liaw Cc: Carlos Llamas Cc: kernel-team@android.com Cc: linux-kselftest@vger.kernel.org Fixes: 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()") Signed-off-by: John Stultz --- tools/testing/selftests/kselftest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h index 973b18e156b2..12e2f3ab8b13 100644 --- a/tools/testing/selftests/kselftest.h +++ b/tools/testing/selftests/kselftest.h @@ -392,7 +392,7 @@ static inline __printf(1, 2) int ksft_exit_skip(const char *msg, ...) static inline int ksft_min_kernel_version(unsigned int min_major, unsigned int min_minor) { - unsigned int major, minor; + unsigned int major = 0, minor = 0; struct utsname info; if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2) From patchwork Wed Apr 10 23:26:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 13625118 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD663A1CF for ; Wed, 10 Apr 2024 23:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791607; cv=none; b=J7rehGTpzvzu2nKL0HGXDsy7LdqDMCm9le5rtyuHjcWRYZhwv6V4x+V+VQp3f6+dYq62PE3OG8lHwKu4bwtPsuxH/fjAfwp6eTAaznvE7P1Y6mCj5YuWmY/BJ6paM0xPXHRS1vRDPn/wvdaW+Q15Gr4PmlKFetcUeCB1GR6FaTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712791607; c=relaxed/simple; bh=QVx11GFaCCb7N4Yio7fGICCAENUW3V/BWi5Vnx+PoZQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cVSMhUISaT/aOvx2qQOA+lZfSl16ap9kGkOnNp118BWZTPBPinB0GIwoG/ja1N2+ugbv+UhY1KEVwX4vorIRXN42ntX9Kd5DuGZjkE/x/dR8fqYXMejWe0jEwEcBa03BhJaUMMaTUGRY7yoUbcETuQSG72RZ1Lg28meyTAtZ8F4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2bAxsRGs; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2bAxsRGs" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1e41c665bb2so30671425ad.1 for ; Wed, 10 Apr 2024 16:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712791606; x=1713396406; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YqMlKesOrPLSfKThat23VwjdSe9gCiof2Hkve//abGE=; b=2bAxsRGs/vAdnVweQ+LLBJ6rSvemZw9Iv/VYWQij7estfWltypbn51JkVgHb1z30DK JBgx063VJ4PIkSTROBL5m2smau21aSUKqVbV5G+3mMO4K+U3YTPNcHFECyKGjC/RMKNP 939UEp98XTzhXBqV5So7ZxkoEdsKeMRFYdYw6mDFYG/6+9T21ApLAL8TBuMKDOZrwif5 fCsp0urUhTy9yIsz9u6lYmKf41xhWUYDASELO7KBeSA5mIpcOY+yoqA87mATeThAhn2R hX2Z/ARNtPrYrGAC31tdF4MdoNIHqxWqng8wC/8qhvual0Aadqnf40bSMgqcbq2C+Pya U7gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712791606; x=1713396406; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YqMlKesOrPLSfKThat23VwjdSe9gCiof2Hkve//abGE=; b=Q8zDlcUzChSFlSuBFr6+T/9ssxvMLG+Nrcg+etCcoR3BaQ5W4t9TgqXiQvo+/hpDxY 8qmMOtwylPmd/dF2p5umIhv5bkYheWr8pC8L0g4wS2BntTpx4ER9HybYgHH9sbey7F9O yY4mIkm6bAX/D5JZ8AO4Bxh09hi2b7Z+u0OwE68Ov4fNPQtuMncCQ1MRxp5HQqZ9nfaf 36mXaZk4E4FW6j6prD9FEnUDzNvsn5vPBng2gj3SVqU64F0Oz4zV8GRvRUZYbrsUQWiE 9am5gq0BkxuMw6vomuLhQuFfk8zsD5P4coBJyspwAv/xfL8mtySzcj//8Cucn5bzHoDa jMwA== X-Forwarded-Encrypted: i=1; AJvYcCU4O7wn/wpHWkmF6X7xuS+3AVZIh4oGbpdIZTtAZEVlhGAgnypF1xBn0rO+Li7FFJA2JfpZYsJHxOigkqmPobdwVg57AUdqegyZ3CL70+Mj X-Gm-Message-State: AOJu0YyCn9OGuWS0ULvYN0AUb6csKVykuQ5jz7TpVNjQICHkxDnVhvnK REvrdEvNxfvY7RuL6sKkv8xrozpwP5ZNpShaZxLKYbq4m2wRF/GLJFw9l9o2Ru8m+wjJS6wYeVA 0w1e3 X-Google-Smtp-Source: AGHT+IHouF3P+iPzjB2QiKGl6ZZPLBEONmG9rrx+ed3xbWsI4elR12lweA0nFbIvZPSYd5HufyBuz5M+ZKmN X-Received: from jstultz-noogler2.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:600]) (user=jstultz job=sendgmr) by 2002:a17:902:e80c:b0:1e0:feef:5c1d with SMTP id u12-20020a170902e80c00b001e0feef5c1dmr311262plg.10.1712791605672; Wed, 10 Apr 2024 16:26:45 -0700 (PDT) Date: Wed, 10 Apr 2024 16:26:30 -0700 In-Reply-To: <20240410232637.4135564-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240410232637.4135564-1-jstultz@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240410232637.4135564-3-jstultz@google.com> Subject: [PATCH 3/3] selftests: timers: Fix abs() warning in posix_timers test From: John Stultz To: LKML Cc: John Stultz , Shuah Khan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Oleg Nesterov , Andrew Morton , Edward Liaw , Carlos Llamas , kernel-team@android.com, linux-kselftest@vger.kernel.org Building with clang, I'm seeing: posix_timers.c:69:6: warning: absolute value function 'abs' given an argument of type 'long long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value] if (abs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) { ^ So switch to using llabs() instead. Cc: Shuah Khan Cc: Anna-Maria Behnsen Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Bill Wendling Cc: Justin Stitt Cc: Oleg Nesterov Cc: Andrew Morton Cc: Edward Liaw Cc: Carlos Llamas Cc: kernel-team@android.com Cc: linux-kselftest@vger.kernel.org Fixes: 0bc4b0cf1570 ("selftests: add basic posix timers selftests") Signed-off-by: John Stultz --- tools/testing/selftests/timers/posix_timers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c index 348f47176e0a..c001dd79179d 100644 --- a/tools/testing/selftests/timers/posix_timers.c +++ b/tools/testing/selftests/timers/posix_timers.c @@ -66,7 +66,7 @@ static int check_diff(struct timeval start, struct timeval end) diff = end.tv_usec - start.tv_usec; diff += (end.tv_sec - start.tv_sec) * USECS_PER_SEC; - if (abs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) { + if (llabs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) { printf("Diff too high: %lld..", diff); return -1; }